From nobody Wed Oct 1 22:19:48 2025 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D07032765CA for ; Wed, 1 Oct 2025 02:21:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759285302; cv=pass; b=Tyj2Dx+ZmatMv0bvJvJihyO+ORYNGP4BzxZiwqvns2ezL2UWsLI78eFY8CKp0IqkLjJVX7Ne2cu8PRIeIN1sQLGHDOk4QQcuqxLLDFqpIlv/W30jrL9QI9J7cE8YXDuKkVKFB5MTdZoQvO5/PGJE3/bwLBBOnCoweB1+rurL/N4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759285302; c=relaxed/simple; bh=0X77hVB5IinZE2DDAqxZVMHHhy5p8Y4Cr+d0655vEnM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=mX0BgG2K2ngmc7+Ydi+0sLV9kLCXOujGv3hyBgWjdwX4CC0nDVHHB16E81OgV2SD2cji6vnWWzLGWEn+JvKbeuKqVaHNjoy6fNJKLLp5aTjvr8ijNb23U3KzLSMKl9Ad+elvkpeHl12WCqYtriZeKc+DIFTQAu8ctp2dE/iZTxc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=ShpwFGmp; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="ShpwFGmp" ARC-Seal: i=1; a=rsa-sha256; t=1759285284; cv=none; d=zohomail.com; s=zohoarc; b=FsOYxeoREEgkVUVlrRFvlchmgcqrWr5VqtXyaTEK/GDqEGhuMTv8RaE76lOEhlw5ObpWLc5CBHFFg2b2jFGi85mq/l3JGhKD1E/a1Zb3AgtgckZ9ZhH8i/XXnuzYCKIXQ96wx3yf/4x4Us+n7/4ZA0zi2wIjAvBYtU7OcFXKyXA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759285284; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=NDV1dkD4lYlsoVNmEVl2YMbAz2WyWMuIkB4qJIoRD4I=; b=bDKo5z2LIpu0De3vz9sYP9gQAS83uqhKOehtmW64rNUGlYVspECrVHC/XCZd2CisXvOr5KQVaTuQCCarPYVbqbq+ukH76rd2e5krRU1ZtQ1A+uRUEzVarAwWZWDdjwsYNT//WYVpiLJR5ohIZWXuKUmIBhe0baXew2bp2qN1M98= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1759285284; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=NDV1dkD4lYlsoVNmEVl2YMbAz2WyWMuIkB4qJIoRD4I=; b=ShpwFGmpj1YjuiNVp4BWgcKVKSNpM5XJnEYKXY8ncLcVfxpQ0S/B435l6y28muHf 9RvlE/7jOC4yAOEzJv7F1gJEJ86JuLH+HTWgOnnkJTUQb5VjAOhTlqJsXuJyBRyxodk sj+kXlGx/dl+S8rCqXXZX8bh0lYNYbOyP/quRU9I= Received: by mx.zohomail.com with SMTPS id 1759285282788540.9452776271363; Tue, 30 Sep 2025 19:21:22 -0700 (PDT) From: =?UTF-8?q?Adri=C3=A1n=20Larumbe?= To: linux-kernel@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, Steven Price , Boris Brezillon , kernel@collabora.com, =?UTF-8?q?Adri=C3=A1n=20Larumbe?= , Rob Herring , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Subject: [PATCH v4 03/10] drm/panfrost: Handle job HW submit errors Date: Wed, 1 Oct 2025 03:20:24 +0100 Message-ID: <20251001022039.1215976-4-adrian.larumbe@collabora.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251001022039.1215976-1-adrian.larumbe@collabora.com> References: <20251001022039.1215976-1-adrian.larumbe@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Avoid waiting for the DRM scheduler job timedout handler, and instead, let the DRM scheduler core signal the error fence immediately when HW job submission fails. That means we must also decrement the runtime-PM refcnt for the device, because the job will never be enqueued or inflight. Reviewed-by: Boris Brezillon Signed-off-by: Adri=C3=A1n Larumbe --- drivers/gpu/drm/panfrost/panfrost_job.c | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panf= rost/panfrost_job.c index a0123d0a1b7d..3f60adc9b69d 100644 --- a/drivers/gpu/drm/panfrost/panfrost_job.c +++ b/drivers/gpu/drm/panfrost/panfrost_job.c @@ -196,7 +196,7 @@ panfrost_enqueue_job(struct panfrost_device *pfdev, int= slot, return 1; } =20 -static void panfrost_job_hw_submit(struct panfrost_job *job, int js) +static int panfrost_job_hw_submit(struct panfrost_job *job, int js) { struct panfrost_device *pfdev =3D job->pfdev; unsigned int subslot; @@ -208,10 +208,11 @@ static void panfrost_job_hw_submit(struct panfrost_jo= b *job, int js) =20 ret =3D pm_runtime_get_sync(pfdev->base.dev); if (ret < 0) - return; + goto err_hwsubmit; =20 if (WARN_ON(job_read(pfdev, JS_COMMAND_NEXT(js)))) { - return; + ret =3D -EINVAL; + goto err_hwsubmit; } =20 cfg =3D panfrost_mmu_as_get(pfdev, job->mmu); @@ -262,6 +263,12 @@ static void panfrost_job_hw_submit(struct panfrost_job= *job, int js) job, js, subslot, jc_head, cfg & 0xf); } spin_unlock(&pfdev->js->job_lock); + + return 0; + +err_hwsubmit: + pm_runtime_put_autosuspend(pfdev->base.dev); + return ret; } =20 static int panfrost_acquire_object_fences(struct drm_gem_object **bos, @@ -384,6 +391,7 @@ static struct dma_fence *panfrost_job_run(struct drm_sc= hed_job *sched_job) struct panfrost_device *pfdev =3D job->pfdev; int slot =3D panfrost_job_get_slot(job); struct dma_fence *fence =3D NULL; + int ret; =20 if (job->ctx->destroyed) return ERR_PTR(-ECANCELED); @@ -405,7 +413,11 @@ static struct dma_fence *panfrost_job_run(struct drm_s= ched_job *sched_job) dma_fence_put(job->done_fence); job->done_fence =3D dma_fence_get(fence); =20 - panfrost_job_hw_submit(job, slot); + ret =3D panfrost_job_hw_submit(job, slot); + if (ret) { + dma_fence_put(fence); + return ERR_PTR(ret); + } =20 return fence; } --=20 2.51.0