From nobody Wed Oct 1 21:27:08 2025 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFC921D9663 for ; Wed, 1 Oct 2025 01:19:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759281591; cv=none; b=DDO459FaWLboHMIsrP9KfHByOJc+wGVJYZ6wuyRNNislMqizapD8yd9PRK3nBQ1Xh2el7GASlT+i1GFZUYekFvM25g61C5F16LszJslKI19PIvcqLHUF2K9htT5bg61XyDWviRQ1tFnOXQMuiZvvr3BggLKuB+I2R49NfPXnXw4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759281591; c=relaxed/simple; bh=OMy9A9SqZGQf0tjcKqASd6TeRIal9Kox3RhJbc6xON0=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=not+c7GG51fO9RHN2rsjL6hp59wuGNpn5CZeI/j4QzDHFSx57lfQa7Nq3k33sIgYCyhXpxidrIWNsJOzITKDe+FAZUCQ575BkC4/07VKwl1zVkcggt2QXoCDLjx4uH9aEns3osQxkAOzaPiNWi3WH124vvzggDdxm0wFozd8VVI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jasonmiu.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=GYKRqKGV; arc=none smtp.client-ip=209.85.214.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jasonmiu.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="GYKRqKGV" Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-27eeb9730d9so54459135ad.0 for ; Tue, 30 Sep 2025 18:19:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1759281588; x=1759886388; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=aeA8pNm0Fq4shIPD7vJcUgfL7lzd9fMzUIFSk5mhTv4=; b=GYKRqKGV8/KZDHqmxiJKkWHpnTBxibWGRUc9f/zPOY4g9S5wpndcniCUDp2R+C//qr Swicf0Y4lJxd5Vk+whiE0AjMfi6nffrdoyUV3KUwBkQkaEcjuh2As4PDbXKA0E/NpTHZ Apl1UYaaGZUMSqizMjuMt8xswbeHG4jB+TGvQDGh1ye1A3GTIMJC4dexWJ6Sy8cJCnL1 Wg8fSYq/YzhUTcSkXCxf/7iXtsq7VmD3gJ9yRqqWNqCNuQG0Egfp/hN180OygiYOjdI6 NRcjneOQctfghvYMBNcumXerSHPsXjKnKdZslObyrUOgBu+Ui7LJeCQ4Gi1i263OxEx2 YafA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759281588; x=1759886388; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aeA8pNm0Fq4shIPD7vJcUgfL7lzd9fMzUIFSk5mhTv4=; b=SX05j1TZ3D9zITsr5mp8PVL0+YS+VYVMA9zv1wlmiAXQVbaFla5FdmvPNdaZBK8Akx GIXLelJSJkBG2qHlFIeE8Ni/f6VPS0ocJc6AzqHdoWXW9L7c8/GTBmsAr/yCGsTZ4zj/ 12SvcZLG/l6vJof0bJdyGgJ3q+ZtBEgnAgE/D95FKOxGJs07JRmHgsOT86ZlBwg4949y +MKmWuz/q1+2oGTczGy0t9X6bfVe5LsM2uGRu78Xq42w/pSmRn1pq/PkG1OEbpH7bidB e3uqjfqgo6valBjN6n9EYUAZrrEWgEa5ekAN+5dDTtgeb8DD9e4csQN3S9sJO5rBkalb o6UQ== X-Forwarded-Encrypted: i=1; AJvYcCWS/wgEp/+h5B23RKpZ0s5almcOLw+IGXDvFzwtQoDSN7O6g40bjvLho2zyxFcrV7oOYIkrsGivKSKxoCk=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5N59LEWrtDOYodtDublHHsij55dkFI5bX7jpWGr6OStATsg2M 4Kkc7NsBkiuI0eWgxSUJQyhyVA8XXLI/NX2Eq8jUVwybDs7C0KbFD9A9jyka7WJzicfAVtGu3jo L+JI25YFPLDxUsA== X-Google-Smtp-Source: AGHT+IESrZiX8ecOTHtWIxgWXgm8rK3Z4Z0P+E9YaEUe495lkH4WCES4F2JmaDmVF2Sy3OapzD9Bxbw4JHZeSQ== X-Received: from plek4.prod.google.com ([2002:a17:903:4504:b0:248:7db1:3800]) (user=jasonmiu job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:289:b0:273:c463:7b2c with SMTP id d9443c01a7336-28e7f26f319mr20106045ad.3.1759281587846; Tue, 30 Sep 2025 18:19:47 -0700 (PDT) Date: Tue, 30 Sep 2025 18:19:39 -0700 In-Reply-To: <20251001011941.1513050-1-jasonmiu@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251001011941.1513050-1-jasonmiu@google.com> X-Mailer: git-send-email 2.51.0.618.g983fd99d29-goog Message-ID: <20251001011941.1513050-2-jasonmiu@google.com> Subject: [PATCH v1 1/3] kho: Adopt KHO radix tree data structures From: Jason Miu To: Alexander Graf , Andrew Morton , Baoquan He , Changyuan Lyu , David Matlack , David Rientjes , Jason Gunthorpe , Jason Miu , Mike Rapoport , Pasha Tatashin , Pratyush Yadav , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Introduce a radix tree data structure for tracking preserved memory pages in KHO, which will replace the current xarray-based implementation. The primary motivation for this change is to eliminate the need for serialization. By marking preserved pages directly in the new KHO radix tree and passing them to the next kernel, the entire serialization process can be removed. This ultimately allows for the removal of the KHO finalize and abort states, simplifying the overall design. The preserved page physical address and its order are encoded in to a value. The KHO radix tree has multiple level of nodes where each node is a table contining a descriptor to the next level of nodes. The encoded value get split and stored its parts along the tree traversal. The tree traversal ends with the `kho_bitmap_table`, where each bit represents a single preserved page. Instead of serializing the memory map, the first kernel store the KHO radix tree root in the FDT. This KHO radix tree root is passed to the second kernel after kexec, hence elimitated the KHO finalize and abort states. The second kernel walks the passed-in KHO radix tree from its root. It restores the memory pages and their orders by decoding the value stored in the KHO radix tree. This architectural shift to using a shared radix tree structure simplifies the KHO design and eliminates the overhead of serializing and deserializing the preserved memory map. Signed-off-by: Jason Miu --- include/linux/kexec_handover.h | 17 - kernel/kexec_handover.c | 729 +++++++++++++++------------------ 2 files changed, 322 insertions(+), 424 deletions(-) diff --git a/include/linux/kexec_handover.h b/include/linux/kexec_handover.h index 348844cffb13..c8229cb11f4b 100644 --- a/include/linux/kexec_handover.h +++ b/include/linux/kexec_handover.h @@ -19,23 +19,6 @@ enum kho_event { struct folio; struct notifier_block; =20 -#define DECLARE_KHOSER_PTR(name, type) \ - union { \ - phys_addr_t phys; \ - type ptr; \ - } name -#define KHOSER_STORE_PTR(dest, val) \ - ({ \ - typeof(val) v =3D val; \ - typecheck(typeof((dest).ptr), v); \ - (dest).phys =3D virt_to_phys(v); \ - }) -#define KHOSER_LOAD_PTR(src) = \ - ({ \ - typeof(src) s =3D src; \ - (typeof((s).ptr))((s).phys ? phys_to_virt((s).phys) : NULL); \ - }) - struct kho_serialization; =20 #ifdef CONFIG_KEXEC_HANDOVER diff --git a/kernel/kexec_handover.c b/kernel/kexec_handover.c index ecd1ac210dbd..34cf0ce4f359 100644 --- a/kernel/kexec_handover.c +++ b/kernel/kexec_handover.c @@ -18,6 +18,7 @@ #include #include #include +#include =20 #include =20 @@ -29,7 +30,7 @@ #include "kexec_internal.h" =20 #define KHO_FDT_COMPATIBLE "kho-v1" -#define PROP_PRESERVED_MEMORY_MAP "preserved-memory-map" +#define PROP_PRESERVED_PAGE_RADIX_TREE "preserved-page-radix-tree" #define PROP_SUB_FDT "fdt" =20 static bool kho_enable __ro_after_init; @@ -46,143 +47,306 @@ static int __init kho_parse_enable(char *p) } early_param("kho", kho_parse_enable); =20 +typedef int (*kho_radix_tree_walk_callback_t)(unsigned long encoded); + /* - * Keep track of memory that is to be preserved across KHO. + * The KHO radix tree tracks preserved memory pages. It is a hierarchical + * structure that starts with a single root `kho_radix_tree`. This single + * tree stores pages of all orders. + * + * This is achieved by encoding the page's physical address and its order = into + * a single `unsigned long` value. This encoded value is then used to trav= erse + * the tree. + * + * The tree hierarchy is shown below: + * + * kho_radix_tree_root + * +-------------------+ + * | Level 6 | (struct kho_radix_tree) + * +-------------------+ + * | + * v + * +-------------------+ + * | Level 5 | (struct kho_radix_tree) + * +-------------------+ + * | + * | ... (intermediate levels) + * | + * v + * +-------------------+ + * | Level 1 | (struct kho_bitmap_table) + * +-------------------+ + * + * The following diagram illustrates how the encoded value is split into + * indices for the tree levels: * - * The serializing side uses two levels of xarrays to manage chunks of per= -order - * 512 byte bitmaps. For instance if PAGE_SIZE =3D 4096, the entire 1G ord= er of a - * 1TB system would fit inside a single 512 byte bitmap. For order 0 alloc= ations - * each bitmap will cover 16M of address space. Thus, for 16G of memory at= most - * 512K of bitmap memory will be needed for order 0. + * 63:60 59:51 50:42 41:33 32:24 23:15 14:0 + * +---------+--------+--------+--------+--------+--------+---------------= --+ + * | 0 | Lv 6 | Lv 5 | Lv 4 | Lv 3 | Lv 2 | Lv 1 (bitmap)= | + * +---------+--------+--------+--------+--------+--------+---------------= --+ * - * This approach is fully incremental, as the serialization progresses fol= ios - * can continue be aggregated to the tracker. The final step, immediately = prior - * to kexec would serialize the xarray information into a linked list for = the - * successor kernel to parse. + * Each `kho_radix_tree` (Levels 2-6) and `kho_bitmap_table` (Level 1) is + * PAGE_SIZE. Each entry in a `kho_radix_tree` is a descriptor (a physical + * address) pointing to the next level node. For Level 2 `kho_radix_tree` + * nodes, these descriptors point to a `kho_bitmap_table`. The final + * `kho_bitmap_table` is a bitmap where each set bit represents a single + * preserved page. */ +struct kho_radix_tree { + unsigned long table[PAGE_SIZE / sizeof(unsigned long)]; +}; =20 -#define PRESERVE_BITS (512 * 8) - -struct kho_mem_phys_bits { - DECLARE_BITMAP(preserve, PRESERVE_BITS); +struct kho_bitmap_table { + unsigned long bitmaps[PAGE_SIZE / sizeof(unsigned long)]; }; =20 -struct kho_mem_phys { +/* + * `kho_radix_tree_root` points to a page thats serves as the root of the + * KHO radix tree. This page is allocated during KHO module initialization. + * Its physical address is written to the FDT and passed to the next kernel + * during kexec. + */ +static struct kho_radix_tree *kho_radix_tree_root; +static DECLARE_RWSEM(kho_radix_tree_root_sem); + +static int kho_radix_tree_max_depth(void) +{ + int page_offset_bit_num =3D BITS_PER_LONG - PAGE_SHIFT; + int order_bit_num =3D ilog2(__roundup_pow_of_two(page_offset_bit_num)); + int bitmap_bit_num =3D PAGE_SHIFT + ilog2(BITS_PER_BYTE); + int table_bit_num =3D ilog2(PAGE_SIZE / sizeof(unsigned long)); + int table_level_num =3D DIV_ROUND_UP(page_offset_bit_num - + bitmap_bit_num + order_bit_num, + table_bit_num); + /* - * Points to kho_mem_phys_bits, a sparse bitmap array. Each bit is sized - * to order. + * The total tree depth is the number of intermediate levels + * and 1 bitmap level. */ - struct xarray phys_bits; -}; + return table_level_num + 1; +} =20 -struct kho_mem_track { - /* Points to kho_mem_phys, each order gets its own bitmap tree */ - struct xarray orders; -}; +static struct kho_radix_tree *kho_alloc_radix_tree(void) +{ + return (struct kho_radix_tree *)get_zeroed_page(GFP_KERNEL); +} =20 -struct khoser_mem_chunk; +/* + * The KHO radix tree tracks preserved pages by encoding a page's physical + * address (pa) and its order into a single unsigned long value. This value + * is then used to traverse the tree. The encoded value is composed of two + * parts: the 'order bits' in the upper part and the 'page offset' in the + * lower part. + * + * <-- Higher Bits ------------------------------------ Lower Bits --> + * +--------------------------+-----------------------------------------+ + * | Order Bits | Page Offset | + * +--------------------------+-----------------------------------------+ + * | ... 0 0 1 0 0 ... | pa >> (PAGE_SHIFT + order) | + * +--------------------------+-----------------------------------------+ + * ^ + * | + * This single '1' bit's position + * uniquely identifies the 'order'. + * + * + * Page Offset: + * The 'page offset' is the physical address normalized for its order. It + * effectively represents the page offset for the given order. + * + * Order Bits: + * The 'order bits' encode the page order by setting a single bit at a + * specific position. The position of this bit itself represents the order. + * + * For instance, on a 64-bit system with 4KB pages (PAGE_SHIFT =3D 12), the + * maximum range for a page offset (for order 0) is 52 bits (64 - 12). This + * offset occupies bits [0-51]. For order 0, the order bit is set at + * position 52. + * + * As the order increases, the number of bits required for the 'page offse= t' + * decreases. For example, order 1 requires one less bit for its page + * offset. This allows its order bit to be set at position 51 without + * conflicting with the page offset bits. + * + * This scheme ensures that the single order bit is always in a higher + * position than any bit used by the page offset for that same order, + * preventing collisions. + */ +static unsigned long kho_radix_encode(unsigned long pa, unsigned int order) +{ + unsigned long h =3D 1UL << (BITS_PER_LONG - PAGE_SHIFT - order); + unsigned long l =3D pa >> (PAGE_SHIFT + order); =20 -struct kho_serialization { - struct page *fdt; - struct list_head fdt_list; - struct dentry *sub_fdt_dir; - struct kho_mem_track track; - /* First chunk of serialized preserved memory map */ - struct khoser_mem_chunk *preserved_mem_map; -}; + return h | l; +} =20 -static void *xa_load_or_alloc(struct xarray *xa, unsigned long index, size= _t sz) +static unsigned long kho_radix_decode(unsigned long encoded, unsigned int = *order) { - void *elm, *res; + unsigned long order_bit =3D fls64(encoded); + unsigned long pa; =20 - elm =3D xa_load(xa, index); - if (elm) - return elm; + *order =3D BITS_PER_LONG - PAGE_SHIFT - order_bit + 1; + pa =3D encoded << (PAGE_SHIFT + *order); =20 - elm =3D kzalloc(sz, GFP_KERNEL); - if (!elm) - return ERR_PTR(-ENOMEM); - - res =3D xa_cmpxchg(xa, index, NULL, elm, GFP_KERNEL); - if (xa_is_err(res)) - res =3D ERR_PTR(xa_err(res)); + return pa; +} =20 - if (res) { - kfree(elm); - return res; +static unsigned long kho_radix_get_index(unsigned long encoded, int level) +{ + int table_bit_num =3D ilog2(PAGE_SIZE / sizeof(unsigned long)); + int bitmap_bit_num =3D PAGE_SHIFT + ilog2(BITS_PER_BYTE); + unsigned long mask; + int s; + + if (level =3D=3D 1) { + s =3D 0; + mask =3D (1UL << bitmap_bit_num) - 1; + } else { + s =3D ((level - 2) * table_bit_num) + bitmap_bit_num; + mask =3D (1UL << table_bit_num) - 1; } =20 - return elm; + return (encoded >> s) & mask; } =20 -static void __kho_unpreserve(struct kho_mem_track *track, unsigned long pf= n, - unsigned long end_pfn) +static int kho_radix_set_bitmap(struct kho_bitmap_table *bit_tlb, unsigned= long offset) { - struct kho_mem_phys_bits *bits; - struct kho_mem_phys *physxa; + if (!bit_tlb || + offset >=3D PAGE_SIZE * BITS_PER_BYTE) + return -EINVAL; =20 - while (pfn < end_pfn) { - const unsigned int order =3D - min(count_trailing_zeros(pfn), ilog2(end_pfn - pfn)); - const unsigned long pfn_high =3D pfn >> order; + set_bit(offset, bit_tlb->bitmaps); + return 0; +} =20 - physxa =3D xa_load(&track->orders, order); - if (!physxa) - continue; +static int kho_radix_preserve_page(unsigned long pa, unsigned int order) +{ + unsigned long encoded =3D kho_radix_encode(pa, order); + int num_tree_level =3D kho_radix_tree_max_depth(); + struct kho_radix_tree *current_tree, *new_tree; + struct kho_bitmap_table *bitmap_table; + int err =3D 0; + int i, idx; =20 - bits =3D xa_load(&physxa->phys_bits, pfn_high / PRESERVE_BITS); - if (!bits) - continue; + down_write(&kho_radix_tree_root_sem); =20 - clear_bit(pfn_high % PRESERVE_BITS, bits->preserve); + current_tree =3D kho_radix_tree_root; =20 - pfn +=3D 1 << order; + /* Go from high levels to low levels */ + for (i =3D num_tree_level; i >=3D 1; i--) { + idx =3D kho_radix_get_index(encoded, i); + + if (i =3D=3D 1) { + bitmap_table =3D (struct kho_bitmap_table *)current_tree; + err =3D kho_radix_set_bitmap(bitmap_table, idx); + goto out; + } + + if (!current_tree->table[idx]) { + new_tree =3D kho_alloc_radix_tree(); + if (!new_tree) { + err =3D -ENOMEM; + goto out; + } + + current_tree->table[idx] =3D + (unsigned long)virt_to_phys(new_tree); + } + + current_tree =3D (struct kho_radix_tree *) + phys_to_virt(current_tree->table[idx]); } + +out: + up_write(&kho_radix_tree_root_sem); + return err; } =20 -static int __kho_preserve_order(struct kho_mem_track *track, unsigned long= pfn, - unsigned int order) +static int kho_radix_walk_bitmaps(struct kho_bitmap_table *bit_tlb, + unsigned long offset, + kho_radix_tree_walk_callback_t cb) { - struct kho_mem_phys_bits *bits; - struct kho_mem_phys *physxa, *new_physxa; - const unsigned long pfn_high =3D pfn >> order; + unsigned long encoded =3D offset << (PAGE_SHIFT + ilog2(BITS_PER_BYTE)); + unsigned long *bitmap =3D (unsigned long *)bit_tlb; + int err =3D 0; + int i; =20 - might_sleep(); + for_each_set_bit(i, bitmap, PAGE_SIZE * BITS_PER_BYTE) { + err =3D cb(encoded | i); + if (err) + return err; + } =20 - physxa =3D xa_load(&track->orders, order); - if (!physxa) { - int err; + return 0; +} =20 - new_physxa =3D kzalloc(sizeof(*physxa), GFP_KERNEL); - if (!new_physxa) - return -ENOMEM; +static int kho_radix_walk_trees(struct kho_radix_tree *root, int level, + unsigned long offset, + kho_radix_tree_walk_callback_t cb) +{ + int level_shift =3D ilog2(PAGE_SIZE / sizeof(unsigned long)); + struct kho_radix_tree *next_tree; + unsigned long encoded, i; + int err =3D 0; =20 - xa_init(&new_physxa->phys_bits); - physxa =3D xa_cmpxchg(&track->orders, order, NULL, new_physxa, - GFP_KERNEL); + if (level =3D=3D 1) { + encoded =3D offset; + return kho_radix_walk_bitmaps((struct kho_bitmap_table *)root, + encoded, cb); + } =20 - err =3D xa_err(physxa); - if (err || physxa) { - xa_destroy(&new_physxa->phys_bits); - kfree(new_physxa); + for (i =3D 0; i < PAGE_SIZE / sizeof(unsigned long); i++) { + if (root->table[i]) { + encoded =3D offset << level_shift | i; =20 + next_tree =3D (struct kho_radix_tree *) + phys_to_virt(root->table[i]); + err =3D kho_radix_walk_trees(next_tree, level - 1, encoded, cb); if (err) return err; - } else { - physxa =3D new_physxa; } } =20 - bits =3D xa_load_or_alloc(&physxa->phys_bits, pfn_high / PRESERVE_BITS, - sizeof(*bits)); - if (IS_ERR(bits)) - return PTR_ERR(bits); + return 0; +} =20 - set_bit(pfn_high % PRESERVE_BITS, bits->preserve); +static int kho_memblock_reserve(phys_addr_t pa, int order) +{ + int sz =3D 1 << (order + PAGE_SHIFT); + struct page *page =3D phys_to_page(pa); + + memblock_reserve(pa, sz); + memblock_reserved_mark_noinit(pa, sz); + page->private =3D order; =20 return 0; } =20 +static int kho_radix_walk_trees_callback(unsigned long encoded) +{ + unsigned int order; + unsigned long pa; + + pa =3D kho_radix_decode(encoded, &order); + + return kho_memblock_reserve(pa, order); +} + +struct kho_serialization { + struct page *fdt; + struct list_head fdt_list; + struct dentry *sub_fdt_dir; +}; + +static int __kho_preserve_order(unsigned long pfn, unsigned int order) +{ + unsigned long pa =3D PFN_PHYS(pfn); + + might_sleep(); + + return kho_radix_preserve_page(pa, order); +} + /* almost as free_reserved_page(), just don't free the page */ static void kho_restore_page(struct page *page, unsigned int order) { @@ -224,152 +388,29 @@ struct folio *kho_restore_folio(phys_addr_t phys) } EXPORT_SYMBOL_GPL(kho_restore_folio); =20 -/* Serialize and deserialize struct kho_mem_phys across kexec - * - * Record all the bitmaps in a linked list of pages for the next kernel to - * process. Each chunk holds bitmaps of the same order and each block of b= itmaps - * starts at a given physical address. This allows the bitmaps to be spars= e. The - * xarray is used to store them in a tree while building up the data struc= ture, - * but the KHO successor kernel only needs to process them once in order. - * - * All of this memory is normal kmalloc() memory and is not marked for - * preservation. The successor kernel will remain isolated to the scratch = space - * until it completes processing this list. Once processed all the memory - * storing these ranges will be marked as free. - */ - -struct khoser_mem_bitmap_ptr { - phys_addr_t phys_start; - DECLARE_KHOSER_PTR(bitmap, struct kho_mem_phys_bits *); -}; - -struct khoser_mem_chunk_hdr { - DECLARE_KHOSER_PTR(next, struct khoser_mem_chunk *); - unsigned int order; - unsigned int num_elms; -}; - -#define KHOSER_BITMAP_SIZE \ - ((PAGE_SIZE - sizeof(struct khoser_mem_chunk_hdr)) / \ - sizeof(struct khoser_mem_bitmap_ptr)) - -struct khoser_mem_chunk { - struct khoser_mem_chunk_hdr hdr; - struct khoser_mem_bitmap_ptr bitmaps[KHOSER_BITMAP_SIZE]; -}; - -static_assert(sizeof(struct khoser_mem_chunk) =3D=3D PAGE_SIZE); - -static struct khoser_mem_chunk *new_chunk(struct khoser_mem_chunk *cur_chu= nk, - unsigned long order) -{ - struct khoser_mem_chunk *chunk; - - chunk =3D kzalloc(PAGE_SIZE, GFP_KERNEL); - if (!chunk) - return NULL; - chunk->hdr.order =3D order; - if (cur_chunk) - KHOSER_STORE_PTR(cur_chunk->hdr.next, chunk); - return chunk; -} - -static void kho_mem_ser_free(struct khoser_mem_chunk *first_chunk) -{ - struct khoser_mem_chunk *chunk =3D first_chunk; - - while (chunk) { - struct khoser_mem_chunk *tmp =3D chunk; - - chunk =3D KHOSER_LOAD_PTR(chunk->hdr.next); - kfree(tmp); - } -} - -static int kho_mem_serialize(struct kho_serialization *ser) -{ - struct khoser_mem_chunk *first_chunk =3D NULL; - struct khoser_mem_chunk *chunk =3D NULL; - struct kho_mem_phys *physxa; - unsigned long order; - - xa_for_each(&ser->track.orders, order, physxa) { - struct kho_mem_phys_bits *bits; - unsigned long phys; - - chunk =3D new_chunk(chunk, order); - if (!chunk) - goto err_free; - - if (!first_chunk) - first_chunk =3D chunk; - - xa_for_each(&physxa->phys_bits, phys, bits) { - struct khoser_mem_bitmap_ptr *elm; - - if (chunk->hdr.num_elms =3D=3D ARRAY_SIZE(chunk->bitmaps)) { - chunk =3D new_chunk(chunk, order); - if (!chunk) - goto err_free; - } - - elm =3D &chunk->bitmaps[chunk->hdr.num_elms]; - chunk->hdr.num_elms++; - elm->phys_start =3D (phys * PRESERVE_BITS) - << (order + PAGE_SHIFT); - KHOSER_STORE_PTR(elm->bitmap, bits); - } - } - - ser->preserved_mem_map =3D first_chunk; - - return 0; - -err_free: - kho_mem_ser_free(first_chunk); - return -ENOMEM; -} - -static void __init deserialize_bitmap(unsigned int order, - struct khoser_mem_bitmap_ptr *elm) -{ - struct kho_mem_phys_bits *bitmap =3D KHOSER_LOAD_PTR(elm->bitmap); - unsigned long bit; - - for_each_set_bit(bit, bitmap->preserve, PRESERVE_BITS) { - int sz =3D 1 << (order + PAGE_SHIFT); - phys_addr_t phys =3D - elm->phys_start + (bit << (order + PAGE_SHIFT)); - struct page *page =3D phys_to_page(phys); - - memblock_reserve(phys, sz); - memblock_reserved_mark_noinit(phys, sz); - page->private =3D order; - } -} - static void __init kho_mem_deserialize(const void *fdt) { - struct khoser_mem_chunk *chunk; const phys_addr_t *mem; int len; + struct kho_radix_tree *tree_root; =20 - mem =3D fdt_getprop(fdt, 0, PROP_PRESERVED_MEMORY_MAP, &len); + /* Retrieve the KHO radix tree from passed-in FDT. */ + mem =3D fdt_getprop(fdt, 0, PROP_PRESERVED_PAGE_RADIX_TREE, &len); =20 if (!mem || len !=3D sizeof(*mem)) { - pr_err("failed to get preserved memory bitmaps\n"); + pr_err("failed to get preserved KHO memory tree\n"); return; } =20 - chunk =3D *mem ? phys_to_virt(*mem) : NULL; - while (chunk) { - unsigned int i; + tree_root =3D *mem ? + (struct kho_radix_tree *)phys_to_virt(*mem) : + NULL; =20 - for (i =3D 0; i !=3D chunk->hdr.num_elms; i++) - deserialize_bitmap(chunk->hdr.order, - &chunk->bitmaps[i]); - chunk =3D KHOSER_LOAD_PTR(chunk->hdr.next); - } + if (!tree_root) + return; + + kho_radix_walk_trees(tree_root, kho_radix_tree_max_depth(), + 0, kho_radix_walk_trees_callback); } =20 /* @@ -633,25 +674,15 @@ EXPORT_SYMBOL_GPL(kho_add_subtree); =20 struct kho_out { struct blocking_notifier_head chain_head; - struct dentry *dir; - - struct mutex lock; /* protects KHO FDT finalization */ - struct kho_serialization ser; - bool finalized; }; =20 static struct kho_out kho_out =3D { .chain_head =3D BLOCKING_NOTIFIER_INIT(kho_out.chain_head), - .lock =3D __MUTEX_INITIALIZER(kho_out.lock), .ser =3D { .fdt_list =3D LIST_HEAD_INIT(kho_out.ser.fdt_list), - .track =3D { - .orders =3D XARRAY_INIT(kho_out.ser.track.orders, 0), - }, }, - .finalized =3D false, }; =20 int register_kho_notifier(struct notifier_block *nb) @@ -679,12 +710,8 @@ int kho_preserve_folio(struct folio *folio) { const unsigned long pfn =3D folio_pfn(folio); const unsigned int order =3D folio_order(folio); - struct kho_mem_track *track =3D &kho_out.ser.track; =20 - if (kho_out.finalized) - return -EBUSY; - - return __kho_preserve_order(track, pfn, order); + return __kho_preserve_order(pfn, order); } EXPORT_SYMBOL_GPL(kho_preserve_folio); =20 @@ -701,14 +728,8 @@ EXPORT_SYMBOL_GPL(kho_preserve_folio); int kho_preserve_phys(phys_addr_t phys, size_t size) { unsigned long pfn =3D PHYS_PFN(phys); - unsigned long failed_pfn =3D 0; - const unsigned long start_pfn =3D pfn; const unsigned long end_pfn =3D PHYS_PFN(phys + size); int err =3D 0; - struct kho_mem_track *track =3D &kho_out.ser.track; - - if (kho_out.finalized) - return -EBUSY; =20 if (!PAGE_ALIGNED(phys) || !PAGE_ALIGNED(size)) return -EINVAL; @@ -717,19 +738,14 @@ int kho_preserve_phys(phys_addr_t phys, size_t size) const unsigned int order =3D min(count_trailing_zeros(pfn), ilog2(end_pfn - pfn)); =20 - err =3D __kho_preserve_order(track, pfn, order); - if (err) { - failed_pfn =3D pfn; - break; - } + err =3D __kho_preserve_order(pfn, order); + if (err) + return err; =20 pfn +=3D 1 << order; } =20 - if (err) - __kho_unpreserve(track, start_pfn, failed_pfn); - - return err; + return 0; } EXPORT_SYMBOL_GPL(kho_preserve_phys); =20 @@ -737,150 +753,6 @@ EXPORT_SYMBOL_GPL(kho_preserve_phys); =20 static struct dentry *debugfs_root; =20 -static int kho_out_update_debugfs_fdt(void) -{ - int err =3D 0; - struct fdt_debugfs *ff, *tmp; - - if (kho_out.finalized) { - err =3D kho_debugfs_fdt_add(&kho_out.ser.fdt_list, kho_out.dir, - "fdt", page_to_virt(kho_out.ser.fdt)); - } else { - list_for_each_entry_safe(ff, tmp, &kho_out.ser.fdt_list, list) { - debugfs_remove(ff->file); - list_del(&ff->list); - kfree(ff); - } - } - - return err; -} - -static int kho_abort(void) -{ - int err; - unsigned long order; - struct kho_mem_phys *physxa; - - xa_for_each(&kho_out.ser.track.orders, order, physxa) { - struct kho_mem_phys_bits *bits; - unsigned long phys; - - xa_for_each(&physxa->phys_bits, phys, bits) - kfree(bits); - - xa_destroy(&physxa->phys_bits); - kfree(physxa); - } - xa_destroy(&kho_out.ser.track.orders); - - if (kho_out.ser.preserved_mem_map) { - kho_mem_ser_free(kho_out.ser.preserved_mem_map); - kho_out.ser.preserved_mem_map =3D NULL; - } - - err =3D blocking_notifier_call_chain(&kho_out.chain_head, KEXEC_KHO_ABORT, - NULL); - err =3D notifier_to_errno(err); - - if (err) - pr_err("Failed to abort KHO finalization: %d\n", err); - - return err; -} - -static int kho_finalize(void) -{ - int err =3D 0; - u64 *preserved_mem_map; - void *fdt =3D page_to_virt(kho_out.ser.fdt); - - err |=3D fdt_create(fdt, PAGE_SIZE); - err |=3D fdt_finish_reservemap(fdt); - err |=3D fdt_begin_node(fdt, ""); - err |=3D fdt_property_string(fdt, "compatible", KHO_FDT_COMPATIBLE); - /** - * Reserve the preserved-memory-map property in the root FDT, so - * that all property definitions will precede subnodes created by - * KHO callers. - */ - err |=3D fdt_property_placeholder(fdt, PROP_PRESERVED_MEMORY_MAP, - sizeof(*preserved_mem_map), - (void **)&preserved_mem_map); - if (err) - goto abort; - - err =3D kho_preserve_folio(page_folio(kho_out.ser.fdt)); - if (err) - goto abort; - - err =3D blocking_notifier_call_chain(&kho_out.chain_head, - KEXEC_KHO_FINALIZE, &kho_out.ser); - err =3D notifier_to_errno(err); - if (err) - goto abort; - - err =3D kho_mem_serialize(&kho_out.ser); - if (err) - goto abort; - - *preserved_mem_map =3D (u64)virt_to_phys(kho_out.ser.preserved_mem_map); - - err |=3D fdt_end_node(fdt); - err |=3D fdt_finish(fdt); - -abort: - if (err) { - pr_err("Failed to convert KHO state tree: %d\n", err); - kho_abort(); - } - - return err; -} - -static int kho_out_finalize_get(void *data, u64 *val) -{ - mutex_lock(&kho_out.lock); - *val =3D kho_out.finalized; - mutex_unlock(&kho_out.lock); - - return 0; -} - -static int kho_out_finalize_set(void *data, u64 _val) -{ - int ret =3D 0; - bool val =3D !!_val; - - mutex_lock(&kho_out.lock); - - if (val =3D=3D kho_out.finalized) { - if (kho_out.finalized) - ret =3D -EEXIST; - else - ret =3D -ENOENT; - goto unlock; - } - - if (val) - ret =3D kho_finalize(); - else - ret =3D kho_abort(); - - if (ret) - goto unlock; - - kho_out.finalized =3D val; - ret =3D kho_out_update_debugfs_fdt(); - -unlock: - mutex_unlock(&kho_out.lock); - return ret; -} - -DEFINE_DEBUGFS_ATTRIBUTE(fops_kho_out_finalize, kho_out_finalize_get, - kho_out_finalize_set, "%llu\n"); - static int scratch_phys_show(struct seq_file *m, void *v) { for (int i =3D 0; i < kho_scratch_cnt; i++) @@ -921,11 +793,6 @@ static __init int kho_out_debugfs_init(void) if (IS_ERR(f)) goto err_rmdir; =20 - f =3D debugfs_create_file("finalize", 0600, dir, NULL, - &fops_kho_out_finalize); - if (IS_ERR(f)) - goto err_rmdir; - kho_out.dir =3D dir; kho_out.ser.sub_fdt_dir =3D sub_fdt_dir; return 0; @@ -1037,6 +904,37 @@ static __init int kho_in_debugfs_init(const void *fdt) return err; } =20 +static int kho_out_fdt_init(void) +{ + int err =3D 0; + void *fdt =3D page_to_virt(kho_out.ser.fdt); + u64 *preserved_radix_tree_root; + + err |=3D fdt_create(fdt, PAGE_SIZE); + err |=3D fdt_finish_reservemap(fdt); + err |=3D fdt_begin_node(fdt, ""); + err |=3D fdt_property_string(fdt, "compatible", KHO_FDT_COMPATIBLE); + + err |=3D fdt_property_placeholder(fdt, PROP_PRESERVED_PAGE_RADIX_TREE, + sizeof(*preserved_radix_tree_root), + (void **)&preserved_radix_tree_root); + if (err) + goto abort; + + down_read(&kho_radix_tree_root_sem); + *preserved_radix_tree_root =3D (u64)virt_to_phys(kho_radix_tree_root); + up_read(&kho_radix_tree_root_sem); + + err |=3D fdt_end_node(fdt); + err |=3D fdt_finish(fdt); + +abort: + if (err) + pr_err("Failed to convert KHO memory tree: %d\n", err); + + return err; +} + static __init int kho_init(void) { int err =3D 0; @@ -1051,15 +949,29 @@ static __init int kho_init(void) goto err_free_scratch; } =20 + kho_radix_tree_root =3D (struct kho_radix_tree *) + kzalloc(PAGE_SIZE, GFP_KERNEL); + if (!kho_radix_tree_root) { + err =3D -ENOMEM; + goto err_free_fdt; + } + + err =3D kho_out_fdt_init(); + if (err) + goto err_free_kho_radix_tree_root; + debugfs_root =3D debugfs_create_dir("kho", NULL); if (IS_ERR(debugfs_root)) { err =3D -ENOENT; - goto err_free_fdt; + goto err_free_kho_radix_tree_root; } =20 err =3D kho_out_debugfs_init(); if (err) - goto err_free_fdt; + goto err_free_kho_radix_tree_root; + + /* Preserve the memory page of FDT for the next kernel */ + kho_preserve_phys(page_to_phys(kho_out.ser.fdt), PAGE_SIZE); =20 if (fdt) { err =3D kho_in_debugfs_init(fdt); @@ -1087,6 +999,9 @@ static __init int kho_init(void) =20 return 0; =20 +err_free_kho_radix_tree_root: + kfree(kho_radix_tree_root); + kho_radix_tree_root =3D NULL; err_free_fdt: put_page(kho_out.ser.fdt); kho_out.ser.fdt =3D NULL; --=20 2.51.0.618.g983fd99d29-goog From nobody Wed Oct 1 21:27:08 2025 Received: from mail-qk1-f202.google.com (mail-qk1-f202.google.com [209.85.222.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E65F23C4F2 for ; Wed, 1 Oct 2025 01:19:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759281592; cv=none; b=qpLP0X71b0JGHEWXI0pYM+rkYWqc8oLANlu2g7Q9IykybQdVQM2hJOMAEePsOIzWgt1WtOQNQBrD+2TNPfAQryvVJj6f9uCJKihsxTpbR4IiIlZ6Jj39J5yn2Hw5jlnBUJuYdUUEz9Fis092G8p4JN7/WcX009xwJqC6ku25AzU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759281592; c=relaxed/simple; bh=wihiLfLip0evevk6YNvisggLUvvTyaQ0jFm7Qf/Wmic=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=e2332jh2n7lGucSP9TjRgEGhMQ0+HM0zy+tv+zyPuqLLpWWFxfgzaj9Igdi4I6OyN5iGiwpQ9R2QA+vb1a8Lq9NihrKnETUln7NvYjVkdIL0tUvzI+GwogBHaMLA9Bpru5YbihwYxufXEtR5mZDMFimp1ors39xv/WMHljd3/EE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jasonmiu.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=u4QSt/dG; arc=none smtp.client-ip=209.85.222.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jasonmiu.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="u4QSt/dG" Received: by mail-qk1-f202.google.com with SMTP id af79cd13be357-86df46fa013so528719085a.2 for ; Tue, 30 Sep 2025 18:19:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1759281590; x=1759886390; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=4ibfSbZvRgj9j6yQ0MCtEacyn1TcRaC1JpE6HwVQGXI=; b=u4QSt/dGmEpa1m+jsrcFcUx21Ql8H9lmxgDH14gnw3LMK09UBfAvBJSmcrTUCCKuJe VfmdJxJIgCSOzsVl2Smm8sehIh1PyNjRoOghnZ44N0P3GrMB9tfCxjBInMpBfLqMwD35 rvf4T9z3IJRGTsMMBAaXpMgB5fKL3hjw8gyhYNLF26erxSYiO2OH8W1NReak7KWYQZZh ej26e3aeBjSX2SFBGTsE5rkkW5cAto42xEYLeIdsPs0g/sT/NxqosmTb/1DUNP+zx/kd iorZDhYBXO7ZuJV1PYVtv8pZPZjBbv0AoePMSs+ESldvS1rkmZAwrvf2ZkCKrKnI4Onz 2bnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759281590; x=1759886390; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4ibfSbZvRgj9j6yQ0MCtEacyn1TcRaC1JpE6HwVQGXI=; b=f8QHhdox1pjwkhYr8JWhgAHnySJqEFchBg0Vgdh2U5s09YiV/AiVRs3BIKyS6yjkf0 Mdv7jQ78P77pNu/tscSaFmEvi4L+ueMPmggCuwD3CVfvj4rUBWCumJ/5/eFIdHgyxY7q 8dqAaFppIQ+a3uVGaRzPafdg5R5u8Kb9B2VJ8TGGdTR4Wfqptnf7cgFvZBI6pBGnTjJ/ lDihFkO1q3CSlfTATrbW15St/YM2Z4db9zq5creJ/G/RC68eQ+QaI30TNpnP0RnhUytB J/fpU2yH35MgmOf8MXRqauutSeEodiPE4a5J6p7fCTQlA9SAOZhGTqWDrIh7WQEEmM8H WM1A== X-Forwarded-Encrypted: i=1; AJvYcCX6lHBAwM5K1FUNfF/cGsZUHZUE1HBYSRvKcYCvjwhFOx0VpRR3Tjiwx1/xvVNCnOPtnWskTFarKnuuNzY=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3wCGmRvVxsqF3ItCYCKiWwChuQpTgGmFKapCCnw7AGgw1LKb+ mrWxWwviE/L5AZ2W/WgEnxYvXBIqdlXT/5Poy8aF0/Kv7OKH2ZQrkzkbCVG0ugMfXY3wRK6KQpc f6HN/ljjwpEqScA== X-Google-Smtp-Source: AGHT+IGndh3BKmmwYu3HLjg8lqiwBwPnFbZVMWVM52TvRbv89JPU+RpTm1KO5ghpiMevFLIMLJgkTv9IkxTRLg== X-Received: from qkpg1.prod.google.com ([2002:a05:620a:2781:b0:863:2d0a:f9a6]) (user=jasonmiu job=prod-delivery.src-stubby-dispatcher) by 2002:a05:620a:4723:b0:82e:6ec8:9887 with SMTP id af79cd13be357-87371172610mr285500485a.24.1759281589908; Tue, 30 Sep 2025 18:19:49 -0700 (PDT) Date: Tue, 30 Sep 2025 18:19:40 -0700 In-Reply-To: <20251001011941.1513050-1-jasonmiu@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251001011941.1513050-1-jasonmiu@google.com> X-Mailer: git-send-email 2.51.0.618.g983fd99d29-goog Message-ID: <20251001011941.1513050-3-jasonmiu@google.com> Subject: [PATCH v1 2/3] memblock: Remove KHO notifier usage From: Jason Miu To: Alexander Graf , Andrew Morton , Baoquan He , Changyuan Lyu , David Matlack , David Rientjes , Jason Gunthorpe , Jason Miu , Mike Rapoport , Pasha Tatashin , Pratyush Yadav , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove the KHO notifier registration and callbacks from the memblock subsystem. These notifiers were tied to the former KHO finalize and abort events, which are no longer used. Memblock now preserves its `reserve_mem` regions and registers its metadata by calling kho_preserve_phys(), kho_preserve_folio(), and kho_add_subtree() directly within its initialization function. Signed-off-by: Jason Miu --- include/linux/kexec_handover.h | 5 ++-- kernel/kexec_handover.c | 48 +++++++++++++++++++++------------- mm/memblock.c | 45 +++++++------------------------ 3 files changed, 42 insertions(+), 56 deletions(-) diff --git a/include/linux/kexec_handover.h b/include/linux/kexec_handover.h index c8229cb11f4b..9566c90a3501 100644 --- a/include/linux/kexec_handover.h +++ b/include/linux/kexec_handover.h @@ -27,7 +27,7 @@ bool kho_is_enabled(void); int kho_preserve_folio(struct folio *folio); int kho_preserve_phys(phys_addr_t phys, size_t size); struct folio *kho_restore_folio(phys_addr_t phys); -int kho_add_subtree(struct kho_serialization *ser, const char *name, void = *fdt); +int kho_add_subtree(const char *name, void *fdt); int kho_retrieve_subtree(const char *name, phys_addr_t *phys); =20 int register_kho_notifier(struct notifier_block *nb); @@ -58,8 +58,7 @@ static inline struct folio *kho_restore_folio(phys_addr_t= phys) return NULL; } =20 -static inline int kho_add_subtree(struct kho_serialization *ser, - const char *name, void *fdt) +static inline int kho_add_subtree(const char *name, void *fdt) { return -EOPNOTSUPP; } diff --git a/kernel/kexec_handover.c b/kernel/kexec_handover.c index 34cf0ce4f359..ee4f430dfae0 100644 --- a/kernel/kexec_handover.c +++ b/kernel/kexec_handover.c @@ -640,9 +640,21 @@ static int kho_debugfs_fdt_add(struct list_head *list,= struct dentry *dir, return 0; } =20 +struct kho_out { + struct blocking_notifier_head chain_head; + struct dentry *dir; + struct kho_serialization ser; +}; + +static struct kho_out kho_out =3D { + .chain_head =3D BLOCKING_NOTIFIER_INIT(kho_out.chain_head), + .ser =3D { + .fdt_list =3D LIST_HEAD_INIT(kho_out.ser.fdt_list), + }, +}; + /** * kho_add_subtree - record the physical address of a sub FDT in KHO root = tree. - * @ser: serialization control object passed by KHO notifiers. * @name: name of the sub tree. * @fdt: the sub tree blob. * @@ -655,16 +667,29 @@ static int kho_debugfs_fdt_add(struct list_head *list= , struct dentry *dir, * * Return: 0 on success, error code on failure */ -int kho_add_subtree(struct kho_serialization *ser, const char *name, void = *fdt) +int kho_add_subtree(const char *name, void *fdt) { + struct kho_serialization *ser =3D &kho_out.ser; int err =3D 0; + int root_node_offset, subnode_offset; u64 phys =3D (u64)virt_to_phys(fdt); void *root =3D page_to_virt(ser->fdt); =20 - err |=3D fdt_begin_node(root, name); - err |=3D fdt_property(root, PROP_SUB_FDT, &phys, sizeof(phys)); - err |=3D fdt_end_node(root); + /* Reload the KHO root FDT to the same buffer */ + err =3D fdt_open_into(root, root, PAGE_SIZE); + if (err) + return err; + + root_node_offset =3D fdt_path_offset(fdt, "/"); + if (root_node_offset < 0) + return root_node_offset; + + subnode_offset =3D fdt_add_subnode(root, root_node_offset, name); + if (subnode_offset < 0) + return subnode_offset; =20 + err =3D fdt_setprop(root, subnode_offset, + PROP_SUB_FDT, &phys, sizeof(phys)); if (err) return err; =20 @@ -672,19 +697,6 @@ int kho_add_subtree(struct kho_serialization *ser, con= st char *name, void *fdt) } EXPORT_SYMBOL_GPL(kho_add_subtree); =20 -struct kho_out { - struct blocking_notifier_head chain_head; - struct dentry *dir; - struct kho_serialization ser; -}; - -static struct kho_out kho_out =3D { - .chain_head =3D BLOCKING_NOTIFIER_INIT(kho_out.chain_head), - .ser =3D { - .fdt_list =3D LIST_HEAD_INIT(kho_out.ser.fdt_list), - }, -}; - int register_kho_notifier(struct notifier_block *nb) { return blocking_notifier_chain_register(&kho_out.chain_head, nb); diff --git a/mm/memblock.c b/mm/memblock.c index 117d963e677c..602a16cb467a 100644 --- a/mm/memblock.c +++ b/mm/memblock.c @@ -2510,39 +2510,6 @@ int reserve_mem_release_by_name(const char *name) #define RESERVE_MEM_KHO_NODE_COMPATIBLE "reserve-mem-v1" static struct page *kho_fdt; =20 -static int reserve_mem_kho_finalize(struct kho_serialization *ser) -{ - int err =3D 0, i; - - for (i =3D 0; i < reserved_mem_count; i++) { - struct reserve_mem_table *map =3D &reserved_mem_table[i]; - - err |=3D kho_preserve_phys(map->start, map->size); - } - - err |=3D kho_preserve_folio(page_folio(kho_fdt)); - err |=3D kho_add_subtree(ser, MEMBLOCK_KHO_FDT, page_to_virt(kho_fdt)); - - return notifier_from_errno(err); -} - -static int reserve_mem_kho_notifier(struct notifier_block *self, - unsigned long cmd, void *v) -{ - switch (cmd) { - case KEXEC_KHO_FINALIZE: - return reserve_mem_kho_finalize((struct kho_serialization *)v); - case KEXEC_KHO_ABORT: - return NOTIFY_DONE; - default: - return NOTIFY_BAD; - } -} - -static struct notifier_block reserve_mem_kho_nb =3D { - .notifier_call =3D reserve_mem_kho_notifier, -}; - static int __init prepare_kho_fdt(void) { int err =3D 0, i; @@ -2583,7 +2550,7 @@ static int __init prepare_kho_fdt(void) =20 static int __init reserve_mem_init(void) { - int err; + int err, i; =20 if (!kho_is_enabled() || !reserved_mem_count) return 0; @@ -2592,7 +2559,15 @@ static int __init reserve_mem_init(void) if (err) return err; =20 - err =3D register_kho_notifier(&reserve_mem_kho_nb); + for (i =3D 0; i < reserved_mem_count; i++) { + struct reserve_mem_table *map =3D &reserved_mem_table[i]; + + err |=3D kho_preserve_phys(map->start, map->size); + } + + err |=3D kho_preserve_folio(page_folio(kho_fdt)); + err |=3D kho_add_subtree(MEMBLOCK_KHO_FDT, page_to_virt(kho_fdt)); + if (err) { put_page(kho_fdt); kho_fdt =3D NULL; --=20 2.51.0.618.g983fd99d29-goog From nobody Wed Oct 1 21:27:08 2025 Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72E3923E32D for ; Wed, 1 Oct 2025 01:19:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759281593; cv=none; b=SX8rZ3PrD5uyb1eLwfCpvZ90Fz24BYKpmSiG/9vYhCpDEwdeIvzhTdZNIj089IPpAr8fLdLssOMQheOOiWZof9DEDL027BJXBlLu6UEvFg5RS4hQYeFuX0W6KU5bhcpywD8YVOFt/UESgO6poKLz3XPs478xLF3J0I5yyJFw08U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759281593; c=relaxed/simple; bh=eyhAqvClZGxGAi9GqsE4GIrUwtn7ku8Q5iIwLCXU1qA=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=LxRdbH+gu/r1hOG7hPU60TIB7NLj9fB+mW9KbYSFuxImwC2rhG0cIljL7AC+PXxEz5ItXitq5DEtMA1dASvE6ctlPq6ABSmbBaF60JqlSQsdDySOAfta/ISXuk7fFwHovb20p3WLZ13RIMdigJW3h7g7Bv2nwEacyUJO9JqE3hQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jasonmiu.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=UYkd7BTC; arc=none smtp.client-ip=209.85.215.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jasonmiu.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="UYkd7BTC" Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-b5a013bc46dso3060687a12.1 for ; Tue, 30 Sep 2025 18:19:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1759281592; x=1759886392; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=x4HnKiiE09rl43LC3UECv7NDLXowg9VsBNh2ns+1RXE=; b=UYkd7BTC/AQ7MYOEdsmZFWTed/etj2OPxazuEjG8L1XWV7Kr4BJH1wB4JQVFdcU83n 243fKjRxHK/00/+WzvOTditg7x2VGd2AcrRpxFMIP2Y+SP85XetCZtbp/ou/ouvUuIJ8 EG5E25yceLv0tbsDGt62jXPPw+bW9ZzWhanAI4++Wr1mmDAX/xAU4vCVfZxZGJBlkjgM D08jJP9FZjzHhAF/EgTAcI78qnuvkQMvl9grLLf588ufCewoxBIwzEYDisj/wT7Sxfw7 x22cEg8qXG9jq1GFvuUU7Aep3E9aixnBq4FXq443RgCXbK45OsMYJMlMHQ1ieWz9PVKH A+UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759281592; x=1759886392; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=x4HnKiiE09rl43LC3UECv7NDLXowg9VsBNh2ns+1RXE=; b=dFNKiZdM5dg1SCInnouNzgl+FBABtMpBciSZXSskmbJnOYm87FiUTzXgySbKEJ+1t0 zCidkKB6HSzLEtSlp1E5qyQK6HWZkanEpJwUJLoPNDjbtUDzy3GdRhHcjhNKR3qcvYyD ebhgwnblx/lmtHUH8RPfW66opOgXbzMNCtg/2UxYty7+P4xq2L28EORMLxdAQPAEejjh zg6liMbJp/NZc7ZiRcSMSwtiE4FUEWrjvkfHSom3SMJRlAdLf3oQmMfnjtltZij0EDVL YywQskAwcOtqcgKecqnxjvuu4M+BCp0hXnQtAvkN8+YyrDLzg77Y88/tqE69bWOhKLb9 XIZA== X-Forwarded-Encrypted: i=1; AJvYcCURZZe1RTCXTgV4vK9mGMFAxllYXaawiiWN9fo7xsfItC0y11LYEJgh4udnAYydXYP2UFJkot8uU/dzRZs=@vger.kernel.org X-Gm-Message-State: AOJu0Yyu1tiOY07vvLeyBVQM/fzizNvzi+u2HqJW80FkdKThPRuPFcYo KIDMpYrrEE2OjnE7YMvuIYL+dG2aVejPxgEZH4DE5r6SwP76gHOA5ymakz6InQyDKMxwUvakZBc bwh4ZABzzFR9FnA== X-Google-Smtp-Source: AGHT+IEBtmTt/de8ZAH/Gty67fG7K6wz+DH/TLooGqCBdKidWKsNfouEipgjC7MTQ3Jd+/633JnpD2gkYNbqjw== X-Received: from plbml5.prod.google.com ([2002:a17:903:34c5:b0:24b:1657:c088]) (user=jasonmiu job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:f642:b0:266:ddd:772f with SMTP id d9443c01a7336-28e7f276df7mr19249665ad.9.1759281591707; Tue, 30 Sep 2025 18:19:51 -0700 (PDT) Date: Tue, 30 Sep 2025 18:19:41 -0700 In-Reply-To: <20251001011941.1513050-1-jasonmiu@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251001011941.1513050-1-jasonmiu@google.com> X-Mailer: git-send-email 2.51.0.618.g983fd99d29-goog Message-ID: <20251001011941.1513050-4-jasonmiu@google.com> Subject: [PATCH v1 3/3] kho: Remove notifier system infrastructure From: Jason Miu To: Alexander Graf , Andrew Morton , Baoquan He , Changyuan Lyu , David Matlack , David Rientjes , Jason Gunthorpe , Jason Miu , Mike Rapoport , Pasha Tatashin , Pratyush Yadav , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Eliminate the core KHO notifier API functions (`register_kho_notifier`, `unregister_kho_notifier`), the `kho_event` enum, and the notifier chain head from KHO internal structures. This infrastructure was used to support the now-removed finalize and abort states and is no longer required. Client subsystems now interact with KHO through direct API calls. Signed-off-by: Jason Miu --- include/linux/kexec_handover.h | 22 ---------------------- kernel/kexec_handover.c | 15 --------------- 2 files changed, 37 deletions(-) diff --git a/include/linux/kexec_handover.h b/include/linux/kexec_handover.h index 9566c90a3501..09e8f0b0fcab 100644 --- a/include/linux/kexec_handover.h +++ b/include/linux/kexec_handover.h @@ -10,16 +10,7 @@ struct kho_scratch { phys_addr_t size; }; =20 -/* KHO Notifier index */ -enum kho_event { - KEXEC_KHO_FINALIZE =3D 0, - KEXEC_KHO_ABORT =3D 1, -}; - struct folio; -struct notifier_block; - -struct kho_serialization; =20 #ifdef CONFIG_KEXEC_HANDOVER bool kho_is_enabled(void); @@ -30,9 +21,6 @@ struct folio *kho_restore_folio(phys_addr_t phys); int kho_add_subtree(const char *name, void *fdt); int kho_retrieve_subtree(const char *name, phys_addr_t *phys); =20 -int register_kho_notifier(struct notifier_block *nb); -int unregister_kho_notifier(struct notifier_block *nb); - void kho_memory_init(void); =20 void kho_populate(phys_addr_t fdt_phys, u64 fdt_len, phys_addr_t scratch_p= hys, @@ -68,16 +56,6 @@ static inline int kho_retrieve_subtree(const char *name,= phys_addr_t *phys) return -EOPNOTSUPP; } =20 -static inline int register_kho_notifier(struct notifier_block *nb) -{ - return -EOPNOTSUPP; -} - -static inline int unregister_kho_notifier(struct notifier_block *nb) -{ - return -EOPNOTSUPP; -} - static inline void kho_memory_init(void) { } diff --git a/kernel/kexec_handover.c b/kernel/kexec_handover.c index ee4f430dfae0..fc290226e58b 100644 --- a/kernel/kexec_handover.c +++ b/kernel/kexec_handover.c @@ -16,7 +16,6 @@ #include #include #include -#include #include #include =20 @@ -641,13 +640,11 @@ static int kho_debugfs_fdt_add(struct list_head *list= , struct dentry *dir, } =20 struct kho_out { - struct blocking_notifier_head chain_head; struct dentry *dir; struct kho_serialization ser; }; =20 static struct kho_out kho_out =3D { - .chain_head =3D BLOCKING_NOTIFIER_INIT(kho_out.chain_head), .ser =3D { .fdt_list =3D LIST_HEAD_INIT(kho_out.ser.fdt_list), }, @@ -697,18 +694,6 @@ int kho_add_subtree(const char *name, void *fdt) } EXPORT_SYMBOL_GPL(kho_add_subtree); =20 -int register_kho_notifier(struct notifier_block *nb) -{ - return blocking_notifier_chain_register(&kho_out.chain_head, nb); -} -EXPORT_SYMBOL_GPL(register_kho_notifier); - -int unregister_kho_notifier(struct notifier_block *nb) -{ - return blocking_notifier_chain_unregister(&kho_out.chain_head, nb); -} -EXPORT_SYMBOL_GPL(unregister_kho_notifier); - /** * kho_preserve_folio - preserve a folio across kexec. * @folio: folio to preserve. --=20 2.51.0.618.g983fd99d29-goog