From nobody Wed Oct 1 20:31:50 2025 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 064BE26056E for ; Wed, 1 Oct 2025 15:13:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759331613; cv=none; b=U6QXWgGIX0QYZVlxz6iWt41+dZhOKizxfyulw9cp92DDe+rZ/hkmeGYCAcunToCGFsllkEqiM9kywNY3nHzL9n6rb3DuIzXUCbSCANFXHt6x6OSmc8V8+sQUPn+OetmQcjlwxSb8iNbmcY9K2V7LmIRPL62P3iEo9CBX9kyFeSI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759331613; c=relaxed/simple; bh=zRnYw0c/jEYg6tUfOIO2XTCeocsoj1LuLA2X2KUMWjo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=sB9CJrtch/ZPKJasJ58cH++RxaH6YdiMjYjQgHJvnyhSPomXZIHa8XypobTRadNAKmlyk04iHzx9zCS+940eAaEcXfzOlwVh2XALfuuDH/x55HurxGl9NR+9dytl+dJAUDkOsBTsKUtK0hDyg0XRc4X9KXI2E/zJ2LhDlZAfqH8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ci6/nRZ/; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ci6/nRZ/" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-b3da3b34950so671064966b.3 for ; Wed, 01 Oct 2025 08:13:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1759331609; x=1759936409; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=SEEUny1Be1BFGwKqqn+oNj/RmCjib3ttC0W23b9Ns+s=; b=ci6/nRZ/4MuEYA0OJYZnxVJ21xzIPaqeqzs2qApreXIib0h2sZYflSBjBTDUvZvJ1J 9ZKLaZTaQTRqKXmns1BvGnil/+2OgVe8LlsZVNkNzWx72AVeSSg7qpTcoFeQSofpKxYR rUUb7ceVKyS7LwM38RUxelEOWRm+eKXMynAhMQF/f+TAB0PU5CPznmftXaTee1xflzSE IP7aGHRzddI2diFu7+fs3WrjkdxX8JckmFnJ9sjNniKcKsPQEMXMcVRbWDGmtskepumI vC763HRwKFF7E1KIMrWmrCQ1j1C18K07+LX2Uq43H5/aifgtNN8zWA92boOUBUt4Nqq/ zNFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759331609; x=1759936409; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SEEUny1Be1BFGwKqqn+oNj/RmCjib3ttC0W23b9Ns+s=; b=NQpOwlfoWaoVmMnBPcCGsNIbTIv1sGQGuXOetnvJYl4bXyLpZqkXLM6E4+E3S1VCNf kUGGVGvNa79lTrqmrk9abgrtGDoZfPeb1S52v6t53xOO4KjKg/gpe5JeJja083/Q6Q7v KIyr5ibyZu2Y7kADFRU4i9uMA9r4nLBh6BgywaYMFHl9+Kz4yaiMQsZUeYMi2vzx64b6 DoB/JP0oT30RdobglwyPUSnrN3kd+CHvYZXiG8IJ46rfK+OqWalPFxitaWUtKlaitDKe +8/l0vmHR1RmiC3WcJ6A7Dr5Bd1uBwafEo97tpkGldVPI6fPSIZkm1JNxhqsb0UWBCEN g+eA== X-Forwarded-Encrypted: i=1; AJvYcCWscHvVkyfSurkK5TGR7SdNpnCkxu6xi/ufQfGPlslkRJxV0l93QDti6xxsZU8SSXGvxHX4tLA5Ut2Z7rs=@vger.kernel.org X-Gm-Message-State: AOJu0YzpC2Ipekz3JVsCum/G0wyLlip7blEC9r6I8MoFgDK2BfmVq2J1 HUIIKez2B8eEEG5hr0yK8v/lnAoWhaA9rU7a7NzGlwLXCVT8OkUxq28Hj5+E97YfWZk= X-Gm-Gg: ASbGncslxy9HglFDMcoqqhEMZQZXdUoRXiydFDmkBWk33+3NP4Qw9fe1DnEqV6kmcfm qqyaxXp82QmAKHyaxM3yVwU6z2PyrksRtHp4NEctW2ftFZfYXQ3wWgkLXuFaEt36znIPSrHq9AN D8XS11jpuyr6xRJvu29XDv1zkOj5GLMoXzqdcH+EViUmzURBtuZflUJXkIRGaaQQO5LJ6NdwQJJ znK7CgBR5djMX45Gz82eWTSXrZrKxrMX68xU3bUCHrY4ncTE3NKPftRiySwSXzlJHgkFtar7lNG 3Zrv2jwV6T+IMlKdOS7y/I72Br/oCGYQmKMD6PiXElLnTXSMwE61DTVdRGNYidxn3Lv61YOAyEt JLtNjCJ/rqYi+YgfPGyswvB4sG7vB+zYkwxSazgR8y7ZlGSYOkXIIhLlezzsDdzxFMKl2YVcM0G 72EwByx8GEJvy3f2Q5vTLVL90e1MxIXcdPOQy8 X-Google-Smtp-Source: AGHT+IHBCc4NxqsoRLhxkWHk/fgJ6Xl1FY/slzvWV2YPuSfVBu5/dMpl+l0CNjy2qT0HCYNogprb6A== X-Received: by 2002:a17:906:3746:b0:b47:70bf:645 with SMTP id a640c23a62f3a-b4770bf06f8mr246716466b.58.1759331609281; Wed, 01 Oct 2025 08:13:29 -0700 (PDT) Received: from puffmais2.c.googlers.com (224.138.204.35.bc.googleusercontent.com. [35.204.138.224]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b3cedacd973sm797226866b.49.2025.10.01.08.13.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Oct 2025 08:13:28 -0700 (PDT) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Wed, 01 Oct 2025 16:13:16 +0100 Subject: [PATCH] clk: samsung: clk-pll: simplify samsung_pll_lock_wait() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251001-samsung-clk-pll-simplification-v1-1-d12def9e74b2@linaro.org> X-B4-Tracking: v=1; b=H4sIAAxF3WgC/x2NQQrCMBAAv1L23IXsiqB+pfQQ4qYupjFk2yKE/ t3gcQ4z08Ckqhg8hgZVDjX95A40DhBePi+C+uwM7PhKzhGaX23PC4b0xpISmq4ladTgt67iRRz H252YmKFHSpWo3/9gms/zB//yC0hwAAAA X-Change-ID: 20251001-samsung-clk-pll-simplification-3e02f8912122 To: Krzysztof Kozlowski , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Michael Turquette , Stephen Boyd Cc: Peter Griffin , Tudor Ambarus , Will McVicker , kernel-team@android.com, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 readl_relaxed_poll_timeout_atomic() has been updated in 2023 in commit 7349a69cf312 ("iopoll: Do not use timekeeping in read_poll_timeout_atomic()") to avoid usage of timekeeping APIs. It also never used udelay() when no delay was given. With the implementation avoiding timekeeping APIs, and with a caller not passing a delay, the timeout argument simply becomes a loop counter. Therefore the code here can be simplified to unconditionally use readl_relaxed_poll_timeout_atomic(). The difference being the last argument, the timeout (loop counter). Simply adjust it to pass the more generous counter in all cases. Signed-off-by: Andr=C3=A9 Draszik --- drivers/clk/samsung/clk-pll.c | 31 ++++++++++--------------------- 1 file changed, 10 insertions(+), 21 deletions(-) diff --git a/drivers/clk/samsung/clk-pll.c b/drivers/clk/samsung/clk-pll.c index 7bea7be1d7e45c32f0b303ffa55ce9cde4a4f71d..a7e693f6983ec073bedd633ed8d= a7efafc1a20bb 100644 --- a/drivers/clk/samsung/clk-pll.c +++ b/drivers/clk/samsung/clk-pll.c @@ -17,8 +17,7 @@ #include "clk.h" #include "clk-pll.h" =20 -#define PLL_TIMEOUT_US 20000U -#define PLL_TIMEOUT_LOOPS 1000000U +#define PLL_TIMEOUT_LOOPS 20000U =20 struct samsung_clk_pll { struct clk_hw hw; @@ -84,7 +83,7 @@ arch_initcall(samsung_pll_disable_early_timeout); static int samsung_pll_lock_wait(struct samsung_clk_pll *pll, unsigned int reg_mask) { - int i, ret; + int ret; u32 val; =20 /* @@ -93,25 +92,15 @@ static int samsung_pll_lock_wait(struct samsung_clk_pll= *pll, * initialized, another when the timekeeping is suspended. udelay() also * cannot be used when the clocksource is not running on arm64, since * the current timer is used as cycle counter. So a simple busy loop - * is used here in that special cases. The limit of iterations has been - * derived from experimental measurements of various PLLs on multiple - * Exynos SoC variants. Single register read time was usually in range - * 0.4...1.5 us, never less than 0.4 us. + * is used here. + * The limit of iterations has been derived from experimental + * measurements of various PLLs on multiple Exynos SoC variants. Single + * register read time was usually in range 0.4...1.5 us, never less than + * 0.4 us. */ - if (pll_early_timeout || timekeeping_suspended) { - i =3D PLL_TIMEOUT_LOOPS; - while (i-- > 0) { - if (readl_relaxed(pll->con_reg) & reg_mask) - return 0; - - cpu_relax(); - } - ret =3D -ETIMEDOUT; - } else { - ret =3D readl_relaxed_poll_timeout_atomic(pll->con_reg, val, - val & reg_mask, 0, PLL_TIMEOUT_US); - } - + ret =3D readl_relaxed_poll_timeout_atomic(pll->con_reg, val, + val & reg_mask, 0, + PLL_TIMEOUT_LOOPS); if (ret < 0) pr_err("Could not lock PLL %s\n", clk_hw_get_name(&pll->hw)); =20 --- base-commit: 3b9b1f8df454caa453c7fb07689064edb2eda90a change-id: 20251001-samsung-clk-pll-simplification-3e02f8912122 Best regards, --=20 Andr=C3=A9 Draszik