From nobody Wed Oct 1 22:37:08 2025 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40C022BE7DC for ; Tue, 30 Sep 2025 07:43:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759218227; cv=none; b=u7g/1ieOJizrMAj7oTDBcOSccYjjIEB/h5wgjocqDFF/DQXMsjSHz6mZLWvkpDADmRRovx0uy7yazEx7JBdzP6+Bfc5B07BPsfYlNU3JBZDKhE+MAIwaHphKYZGfTLU2H8k+6vY+xNCeUu51dIEW8/JCI32DnL+cbnKty08Z7Hs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759218227; c=relaxed/simple; bh=XBNmMhEti5u5N9olH/YhkixwaEYi8hnuS7cZQWw0FYg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References; b=W3tg6gdmwSz2yEPMSpeKjdlaePLRNBsHvPTsOZyDsRw01zD/CjC9jz6OIZREHDpl4hXhaXCAN0C3+rCF4FLelVt97RRzDT9WJerGC1uyw24Lg0br7j80jiIYOu9pNT9nIEp5bT8WBCiXYID1cVO0MmlN57WnJw8TOKrqiB3p1Lw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com; spf=pass smtp.mailfrom=bytedance.com; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b=Iqj5tBk+; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bytedance.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b="Iqj5tBk+" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2698d47e776so48650135ad.1 for ; Tue, 30 Sep 2025 00:43:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1759218225; x=1759823025; darn=vger.kernel.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=l+MFzw/am516PEFKIA1HZN/VZns9FQH6Q0OdRD4dEOQ=; b=Iqj5tBk+071xqER8EiofzGfa0ECllCL+migVaa0kUnTd9BOtrQM8DwvGgMqDeSIl6i ZDDUlcoXUz6N4mkJ/Dk05w5TdZ5FDIYw4TrKLTIHNxyyLMe9DOgbViDL2Yurmbaqu+M+ 6O62CvxjRtqu7T8WCXNtS+Aiyjst9I71c1PfzPNBurRjXKXXd2H31ICksBaLIg0tMtQF X0AuLFjE0U/LM5jT6K0upEMUCK2ZDQNA6uzSpUHbu80Ha00vval5hDxe2DyDUZopGNWy zr6FhRLUmdsUehc5o35GVEvCVQ3TW3QPFsH7tt4Jk7kXjBO2v1Y3VEuzZJvhVugddZ54 YVgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759218225; x=1759823025; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=l+MFzw/am516PEFKIA1HZN/VZns9FQH6Q0OdRD4dEOQ=; b=IFlinYatygHOzR3THPwDvvnhnx/G8Hzs61tP3lakRQBgg69nTbDmahxt6p62ANon29 46hz3+1n7HVo5QOsLliPggy7126RmirVD5PR0Hd1diHqJlzV6V+Lj1dgbB+XAAb0o867 hSacoXOtikLVFg0BbgRhFi2kX/+GEXvkN0g2L3gvngBKhkYSIEBDidr0MaRDL0D0NJVc FHANXWeB5FmHTKt/9MWtfMVmiOq92RHlIwjAEJ52CE+3nDwmr0qp568GJxY623etmJ2R E0d0D7+QIuv5+l02RjiqsvfxyfjcIGTleanlSGeSlwyjtdiKUvNikIYV8mMLW8zVaA1j Cdpg== X-Forwarded-Encrypted: i=1; AJvYcCWh/PtSotmwsC24lO+UbNUYOv1oSTptm/dsLH1ZFRiSOISId0C+RzAkFaDFybyZJMwrN8QMf5GKIj1S0vs=@vger.kernel.org X-Gm-Message-State: AOJu0YyfICeYJAV/ylBJ3M5AERzqQrgm4dAVQM4VU7j30eFkuRu/punt D3zmOKTN+qbU429GCDG1/yN20/6oIIbl5sT5BC6d3HDpOe+NouQUNLhAsAwQYD47rqH44R1Gn9N G5LEi X-Gm-Gg: ASbGnctnXmok0XQMkP1WSH2mx+JuHzJSiJdF++fXrvQeRRa8TkCYZVVMJkgnR56Ic1J bj29jz4HVcKSphT/BMXFpy1dSiXjrLPwaL/h+twpSMasqrLnX4T5Jx4ZeESY3Unf6bMquOqP8SA SDlEsMgtPjFYSfFkJQdm3lh9FRNdpfRRX70zsl539fzZ9BDqWNc+4m5o5zR6CZJendaL257GIox x3/Hz8X0zUvg+jwHm/dfEbvfYjoNtxQdrK3AxWJi1if8KIqseDX3UeN1zmxVlkyG7Hp4Qm+tAD6 dlxRckO5soKeSRW5CJltPZxoKuF5z9CWuPh5NQeHxCQUy+qcluPMaC3oE/JujR2mc80R3ibabUp iU8knIRXFIgJ1EalhELRO5G6+gFkzBOV3wgHPL7slaD0auIqbNbJ3lwp27MlyvAPp969dp/68sj +6bm9UTyVm3wafvaYH6Nq0M9g= X-Google-Smtp-Source: AGHT+IEz5W4HFaTVSimEhs34yYbp0/rsgNJrvabhbkCWMxTkpZ90HkeOCYdscjnIU5ruvu9wBwJzwA== X-Received: by 2002:a17:902:f64d:b0:259:5284:f87b with SMTP id d9443c01a7336-27ed49d0965mr208847315ad.16.1759218225403; Tue, 30 Sep 2025 00:43:45 -0700 (PDT) Received: from 5CG3510V44-KVS.bytedance.net ([139.177.225.243]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-338386f577bsm3535374a91.2.2025.09.30.00.43.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Sep 2025 00:43:44 -0700 (PDT) From: Jinhui Guo To: corey@minyard.net Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org, guojinhui.liam@bytedance.com Subject: [PATCH v2 1/3] ipmi: Fix the race between __scan_channels() and deliver_response() Date: Tue, 30 Sep 2025 15:42:37 +0800 Message-Id: <20250930074239.2353-2-guojinhui.liam@bytedance.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20250930074239.2353-1-guojinhui.liam@bytedance.com> References: <20250930074239.2353-1-guojinhui.liam@bytedance.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The race window between __scan_channels() and deliver_response() causes the parameters of some channels to be set to 0. 1.[CPUA] __scan_channels() issues an IPMI request and waits with wait_event() until all channels have been scanned. wait_event() internally calls might_sleep(), which might yield the CPU. (Moreover, an interrupt can preempt wait_event() and force the task to yield the CPU.) 2.[CPUB] deliver_response() is invoked when the CPU receives the IPMI response. After processing a IPMI response, deliver_response() directly assigns intf->wchannels to intf->channel_list and sets intf->channels_ready to true. However, not all channels are actually ready for use. 3.[CPUA] Since intf->channels_ready is already true, wait_event() never enters __wait_event(). __scan_channels() immediately clears intf->null_user_handler and exits. 4.[CPUB] Once intf->null_user_handler is set to NULL, deliver_response() ignores further IPMI responses, leaving the remaining channels zero-initialized and unusable. CPUA CPUB ------------------------------- ----------------------------- __scan_channels() intf->null_user_handler =3D channel_handler; send_channel_info_cmd(intf, 0); wait_event(intf->waitq, intf->channels_ready); do { might_sleep(); deliver_response() channel_handler() intf->channel_list =3D intf->wchannels + set; intf->channels_ready =3D true; send_channel_info_cmd(intf, intf->curr_channel); if (condition) break; __wait_event(wq_head, condition); } while(0) intf->null_user_handler =3D NULL; deliver_response() if (!msg->user) if (intf->null_user_handler) rv =3D -EINVAL; return rv; ------------------------------- ----------------------------- Fix the race between __scan_channels() and deliver_response() by deferring both the assignment intf->channel_list =3D intf->wchannels and the flag intf->channels_ready =3D true until all channels have been successfully scanned or until the IPMI request has failed. Signed-off-by: Jinhui Guo --- drivers/char/ipmi/ipmi_msghandler.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_m= sghandler.c index 8e9050f99e9e..a6e2e8246ab1 100644 --- a/drivers/char/ipmi/ipmi_msghandler.c +++ b/drivers/char/ipmi/ipmi_msghandler.c @@ -3406,8 +3406,6 @@ channel_handler(struct ipmi_smi *intf, struct ipmi_re= cv_msg *msg) intf->channels_ready =3D true; wake_up(&intf->waitq); } else { - intf->channel_list =3D intf->wchannels + set; - intf->channels_ready =3D true; rv =3D send_channel_info_cmd(intf, intf->curr_channel); } =20 --=20 2.20.1 From nobody Wed Oct 1 22:37:08 2025 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0ADB829E11A for ; Tue, 30 Sep 2025 07:43:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759218235; cv=none; b=ksQ2zZ3ttAmy4OPlGMD1RtQZPWTFazMrnDpxJ3goS4J5iNw4pu/cUzb7Bph+kYFJZxtZbdms3ys5BzYgW7AWV/BDtROmwLXxFqUynYTnnbKmLt3/NZ1GcObPVmxQ4q7WOKCJHdNsTLeWCHBAyNGvPgBy6phLf8eMWExBXooTndk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759218235; c=relaxed/simple; bh=GS7WqF0LF08bwFtmgD01RFP9YngCcT17XIqLFbp8DBc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References; b=Y78N7bI6QI9E/q+AifozNVQJDbJeJ97vHzlAOsBE/d9jIdXx0O8z8JANCUiH3ZEdyzDTHDHNlvMLGfYkIofSDGlW9lNYRAa926fx45t8Ipyz9SPrvkwfEQcCBXcfVealuW7c9UCq1OOm1lkELREqoVDS9Wt/so/nDnxttlrfbbo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com; spf=pass smtp.mailfrom=bytedance.com; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b=ZAnVlAL5; arc=none smtp.client-ip=209.85.215.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bytedance.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b="ZAnVlAL5" Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-b551b040930so3759144a12.2 for ; Tue, 30 Sep 2025 00:43:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1759218233; x=1759823033; darn=vger.kernel.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=hgG+aaQgnT9ZPHFiK/eFUVeZgtIS+EmmmaaEftFkXN0=; b=ZAnVlAL5AmBqNdQbdXm3YZvl9Ybo2Q9cMYSlSDyQltoXto/0ebSexF4TO0Pb8YFds1 NcPh5bcIOqZB6d451egPq7sZF+n8aq0L1yAwhnYy7O8mv4zQawVhavtQ7ePPY7zVuhsI ynIqYtc+hjcIP1hGvT5QOyZBN348w7evu5zOsRxf09ECueAL6UAIDWQcEMHJ4RR58sKB TedMUd1RRAUp15PxQnXgNM/e8i0K0ri7KdGkfI5YtbdVOdzuBaNJWSJrMTCfAg3Ce5Xo o50XELF7cUxdMs4KLFF2hC2NX0xNmQBwKFCZV3FMwQ0SqkurLcS5hif887JBKEp+DsWE gDNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759218233; x=1759823033; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hgG+aaQgnT9ZPHFiK/eFUVeZgtIS+EmmmaaEftFkXN0=; b=eqbQi4TjmWM+p4/d+by2oUmFZKTFc0P9Uc/WlUn0yG3oarjV8w0HHJrFbMc9YrnEXn 4hTKlXwc8qxXBiI0CaglHi4MKzNROHjZmjrUE498gOdJoKdH57G4k60lEWG+IkHS5DV9 uoc29v7qI7MsXrJ3rJDg6d6S2yElFMcP7/lwOcp15jOJ1YnMUcp08pwjYiRsi4XO+XPr ++DJZ30/ucK+n9Wj1o9PE4eat2vxSxt/REtEjLMS32uXTyIY1x5cdQZTmcxjjnM8wCw8 3l6GCpUkrJR1EuasKifkV/rUSpXnYZ9MTjlD5ZOMpairJd5s/LCW6XCKDdib/dSNvRXN 49KA== X-Forwarded-Encrypted: i=1; AJvYcCVJhvEepqFgUQ0hJttBld99D3y9G32HByv7DZiqtlzTWbKQ6YozK/F/J+HmjujL6fhJ7XyHmWmgTksgsfQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yzl8u50RgtcgL9dSsnrL97Etk3FVMQLs+FIwim7tqPe3Z4PZWRD i3iGTq9HDXsxlqXQxCYfo6/HPqa0jFt78QWAY4+AQTYnwu5ZoGfXh5VKyOrnvNzZanrtCrenDfZ wOssM X-Gm-Gg: ASbGnctjPXRBjHCQEEKGW8dhbvU/ApH1j0+M4UOJD6mEayRINaENIpFDqB89npTwOMK 0ZTNgGBxLqITiDZnqDheAN2RlGSK/LHrD4POSFE2S5VMkTXTjMQ4DNGB2+W62a8UcrJiEoYu8db DLkA/gG3QRX35BUzwOyr/HZaI1Hq82jHKQ4xQ+htNNeSxFaRidEj140gEQ0TjfEazXC5u5glUIR QSmexyH+CUEQCbZTqhQFaX8RtVqHpNR4uf1UHrHWN/+Pk5mZFN1ON/OfaHnCPT+OCU1Kt8WslgR DZEZJtVO5KNC5zX+lgYMxjTZ9xWjKZIh4+17qQFAYDGb7oxy4QgpXNO18DzeVBh1kW7FYqd6InF EKefSBGxW6nJTk3dJ3S3ORJ4SkERzItXIdaCsPoEld32fAWb6Xb6+HQxv+dmhSEth9DwtqI0H92 4/uxsgVa9RAKVOZVmLi+MFlz6JZ/8h24tMzw== X-Google-Smtp-Source: AGHT+IHusydmYb+60/mYolM5grNKdUqMD996medk1CNvk9KNDDE8cc9bcWqn/LVsyVs8k2//Dwhssg== X-Received: by 2002:a17:902:f611:b0:271:fead:9930 with SMTP id d9443c01a7336-27ed4a78d72mr215723505ad.59.1759218233180; Tue, 30 Sep 2025 00:43:53 -0700 (PDT) Received: from 5CG3510V44-KVS.bytedance.net ([139.177.225.243]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-338386f577bsm3535374a91.2.2025.09.30.00.43.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Sep 2025 00:43:52 -0700 (PDT) From: Jinhui Guo To: corey@minyard.net Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org, guojinhui.liam@bytedance.com Subject: [PATCH v2 2/3] ipmi: Fix __scan_channels() failing to rescan channels Date: Tue, 30 Sep 2025 15:42:38 +0800 Message-Id: <20250930074239.2353-3-guojinhui.liam@bytedance.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20250930074239.2353-1-guojinhui.liam@bytedance.com> References: <20250930074239.2353-1-guojinhui.liam@bytedance.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" channel_handler() sets intf->channels_ready to true but never clears it, so __scan_channels() skips any rescan. When the BMC firmware changes a rescan is required. Allow it by clearing the flag before starting a new scan. Signed-off-by: Jinhui Guo --- drivers/char/ipmi/ipmi_msghandler.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_m= sghandler.c index a6e2e8246ab1..536484b8e52d 100644 --- a/drivers/char/ipmi/ipmi_msghandler.c +++ b/drivers/char/ipmi/ipmi_msghandler.c @@ -590,7 +590,8 @@ static void __ipmi_bmc_unregister(struct ipmi_smi *intf= ); static int __ipmi_bmc_register(struct ipmi_smi *intf, struct ipmi_device_id *id, bool guid_set, guid_t *guid, int intf_num); -static int __scan_channels(struct ipmi_smi *intf, struct ipmi_device_id *i= d); +static int __scan_channels(struct ipmi_smi *intf, + struct ipmi_device_id *id, bool rescan); =20 static void free_ipmi_user(struct kref *ref) { @@ -2657,7 +2658,7 @@ static int __bmc_get_device_id(struct ipmi_smi *intf,= struct bmc_device *bmc, if (__ipmi_bmc_register(intf, &id, guid_set, &guid, intf_num)) need_waiter(intf); /* Retry later on an error. */ else - __scan_channels(intf, &id); + __scan_channels(intf, &id, false); =20 =20 if (!intf_set) { @@ -2677,7 +2678,7 @@ static int __bmc_get_device_id(struct ipmi_smi *intf,= struct bmc_device *bmc, goto out_noprocessing; } else if (memcmp(&bmc->fetch_id, &bmc->id, sizeof(bmc->id))) /* Version info changes, scan the channels again. */ - __scan_channels(intf, &bmc->fetch_id); + __scan_channels(intf, &bmc->fetch_id, true); =20 bmc->dyn_id_expiry =3D jiffies + IPMI_DYN_DEV_ID_EXPIRY; =20 @@ -3427,10 +3428,17 @@ channel_handler(struct ipmi_smi *intf, struct ipmi_= recv_msg *msg) /* * Must be holding intf->bmc_reg_mutex to call this. */ -static int __scan_channels(struct ipmi_smi *intf, struct ipmi_device_id *i= d) +static int __scan_channels(struct ipmi_smi *intf, + struct ipmi_device_id *id, + bool rescan) { int rv; =20 + if (rescan) { + /* Clear channels_ready to force channels rescan. */ + intf->channels_ready =3D false; + } + if (ipmi_version_major(id) > 1 || (ipmi_version_major(id) =3D=3D 1 && ipmi_version_minor(id) >=3D 5)) { @@ -3632,7 +3640,7 @@ int ipmi_add_smi(struct module *owner, } =20 mutex_lock(&intf->bmc_reg_mutex); - rv =3D __scan_channels(intf, &id); + rv =3D __scan_channels(intf, &id, false); mutex_unlock(&intf->bmc_reg_mutex); if (rv) goto out_err_bmc_reg; --=20 2.20.1 From nobody Wed Oct 1 22:37:08 2025 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFB9729E11A for ; Tue, 30 Sep 2025 07:44:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759218245; cv=none; b=CMi/cyvSjU5fSTukX3Pm3ioC6NBtAv8XKDLfXizPpveRBTaZ9mHakv6hDEzQw87/2Sriq+FqmNSaaD3QUfYOQkzzpHgNSOhs2g+RWob2J5/pWLsey4197tJhXoUBHvGd8MxgcDKQoLysVFcqBfH3NFUElIq5eKrJiRs22+Looi4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759218245; c=relaxed/simple; bh=fT9soEm15HrCXq7EaWTOx+9+Z9/K99syifo6afXlc2E=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References; b=d08L/EQ0jhsqD8NKrb0x98sRG0811u4l0J99oyEVm4PdUSftXReQE9ZENekkDwf0MVf07S4VfNsLopwCra7fMJekcW9MvZcym5Wk7jv5ozyWbIXKao7VmLYm5RskF4pTRdjsOhz5VgR+17EOEQONRCjHy6b5oQWXNce/AOzrecs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com; spf=pass smtp.mailfrom=bytedance.com; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b=COsHEaPF; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bytedance.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b="COsHEaPF" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-3304dd2f119so4304965a91.2 for ; Tue, 30 Sep 2025 00:44:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1759218242; x=1759823042; darn=vger.kernel.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=S+GWBz0oO7f/Lmd1JETTBBhflgvMDIE2U8FWt4CXlOU=; b=COsHEaPFbor1d9eMRXKSFcV8jb7+hNTFfY4Gncla+qIPOYLtRY2Xu0Aogzxp3Z9X8+ +u64oH9H0lcNjL6TESIh/cKxsVWGiBejbY9G87LH5D3SoeEAVmEqxc7FgY9raUryg3ou /D2P+/XUXn9cPeJx5c/I7ENQVeFI45DaxU/42L17fWHOBBnKUylB94tktez38pJLkvYz fgmt7Cz9hnA8RKIfrYnQNs/Da2s/6IgjYQYUC1L981OWcORMmr7vxAmz1mER0SW0rbyA Ssu9SK0CKcWVa820d7Jf6nBuulNvLMWpiNoSdVYP6R9smnzyps+qvMHUxJAmEYKOokx1 VGGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759218242; x=1759823042; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=S+GWBz0oO7f/Lmd1JETTBBhflgvMDIE2U8FWt4CXlOU=; b=oy8+7m5R6xUIJzyEHqsAKKO8x2nBTnioMA4yJ69+ltBZdTrFn3UDg36rsb0QBVU/Sw C5W18qMoULKAXoAIfrfIkRRiv62eS9u43yhLGglIq9FSTr9niAZcn8IRgqrPVkS7PKP3 G/Dh2fj9Fu9LC9Qx7UT5l59pUm3vZTiPHAONv2AIco73+P764peck1Jgc4Au+UxKI7C6 eaXkbHtt+Jce3o01t4m9KVjdWlQNyzWSjZkiWDIc+n40VSkdARwT/3qSHAfQ+cY9dW1G jO1S6QnVrkcgN6I+Z2ROWgdmpw+X9unRCDg7I8iiFM8RIeeMK6yyuyZCj5Hvt5GsNi1F gJyQ== X-Forwarded-Encrypted: i=1; AJvYcCXOSmz7xKH5j7Yd42k+M6nIDhECDNKVF8YpfXXx9IB1YAVG77QcBjNOMxJmsQpdWyszqks454oCWTdKaVc=@vger.kernel.org X-Gm-Message-State: AOJu0YzDs7hGMjk5cwAyKqgteLudPepQgLnfLZ4aOeVBPJ+LWC32sL6u gRbPAZS0lhjZJxyjupmIWHFGuND6mCgYeiDqEOE0Mlrzk+S0VJJin9s+Rz/+3Prqp2M= X-Gm-Gg: ASbGnctJKbD5ZxaqYVexskCT/0YRAfGf0ADZJBLuFhBudGKdJOQ+wBteJu6zOvwkWvk l02IkW0331ABEvk5NF6MPVZsM3/g5mNRkIqSyTMcAMudhtBukXr06lWLHiQQ9NHzgL6Qr080SdB 37UT5w+ZQDEugAbPZN01NN4RnQuYIAbjoULIP04ivZWTrD7vok3zh5ip1To6b1B10QxN/z9c7q0 wgw5+1jx/4nYRHhUT1ah/BTNPxvm5aqcplPE+SFc3RPkBEpVbXUtEZrpoTCfV+PCmjP2BiHfPiA IqpjeT2OLYmUA6MGgdF4hAm4YetQ6yb3+fA00+0azuLJDA/lZhpZkH2YER/bxCxQ577W/39l4oZ Ia7jgJHcXY121skhZgNxebAsnul29zgTskjfY/HKuw7cq4ZAMKHEGcMCX9/K/8jLMfIccCL4sSW B0JsMFzGY7QYasP5hPmbqvR8k= X-Google-Smtp-Source: AGHT+IFEbpHK7DlmslkbdpJiHFyYSOPszmOBBa9J2pFP03qYZpUo6cclFGnoot3eNpMyiKMXXRLIJQ== X-Received: by 2002:a17:90b:38c4:b0:338:3cea:6089 with SMTP id 98e67ed59e1d1-3383cea60d3mr3829629a91.14.1759218241989; Tue, 30 Sep 2025 00:44:01 -0700 (PDT) Received: from 5CG3510V44-KVS.bytedance.net ([139.177.225.243]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-338386f577bsm3535374a91.2.2025.09.30.00.43.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Sep 2025 00:44:01 -0700 (PDT) From: Jinhui Guo To: corey@minyard.net Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org, guojinhui.liam@bytedance.com Subject: [PATCH v2 3/3] ipmi: Skip channel scan if channels are already marked ready Date: Tue, 30 Sep 2025 15:42:39 +0800 Message-Id: <20250930074239.2353-4-guojinhui.liam@bytedance.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20250930074239.2353-1-guojinhui.liam@bytedance.com> References: <20250930074239.2353-1-guojinhui.liam@bytedance.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Channels remain static unless the BMC firmware changes. Therefore, rescanning is unnecessary while they are marked ready and no BMC update has occurred. Signed-off-by: Jinhui Guo --- drivers/char/ipmi/ipmi_msghandler.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_m= sghandler.c index 536484b8e52d..db8ef2e46488 100644 --- a/drivers/char/ipmi/ipmi_msghandler.c +++ b/drivers/char/ipmi/ipmi_msghandler.c @@ -3439,6 +3439,10 @@ static int __scan_channels(struct ipmi_smi *intf, intf->channels_ready =3D false; } =20 + /* Skip channel scan if channels are already marked ready */ + if (intf->channels_ready) + return 0; + if (ipmi_version_major(id) > 1 || (ipmi_version_major(id) =3D=3D 1 && ipmi_version_minor(id) >=3D 5)) { --=20 2.20.1