From nobody Thu Oct 2 02:13:28 2025 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F33E2459E7 for ; Tue, 30 Sep 2025 02:45:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759200302; cv=none; b=qVqPeTpsOVXjYm6ch8/ieEnlx3S3tLg67HHgvnpfss2DDRPi3GKjW5pyD2YZAxDJv9afGVqoowtztKG5a9FTMfax3nQcMCgLKynHtuRV9p3vaOSRiB3ALhk1MQ6ZtUijPC3niV13a8+ifthpk4LSbXVt7OI3F8OYHgqFxsWSuU0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759200302; c=relaxed/simple; bh=9SDUPEZSlMV40T53tfVBMh3pQptZtl+KprWlK44Wx6c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qmlB5LOJDs9gnmEkitk67BEgvpf73un6zFuQanJFvS6eKaucE3WUsKUi4oWUC8rx3pdklAELUIGHjPJcx7NkhdvnNIMQOKKo/HgBTeaOA/NjXeGP0gi5VoigQlMzwNHbnrm67LbdRz+6LQmiGwuQV8cYvNMCJ0aG5wsUsBNeKh0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=R3xq3Lxq; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R3xq3Lxq" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-329a41dc2ebso4463266a91.3 for ; Mon, 29 Sep 2025 19:45:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759200300; x=1759805100; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EtGUQc6HOhuSXywhIDZ+AUqHUInlRCKup6JfN/4+ZEc=; b=R3xq3LxqEZxsiGZGYi3bq6u9DZ2mJuAa5YCT0IsFAPS34YFd2Rubj3uXbjrvFN/t3O P69i8+OerthgXZT8E+gWCvYQc+wQdd1pFNLfuJHewLBA5LMLgEl5VP7T3SsopcqUaBSs Qx9lAEjWasG6aPolnsyvatg0QBWDXvMgCGnlVJd/InvwHesw+lApPojdax/ZD5VwZtHC 6ZdOxFkAmtUdWjee3RHkSxvJq8LmyIgKtgCRCxCqTIVf5g6PRYO7ZSZkXttRCe4gfUJ5 6rP4IirgYRWR3zArJS+u7DncpyRvZmexxcKYBVzkV/Mx7PVVGSB9O30JBbkzfrka7ojH G/eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759200300; x=1759805100; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EtGUQc6HOhuSXywhIDZ+AUqHUInlRCKup6JfN/4+ZEc=; b=dZ6eknRtWMRbqGoZz7ZDqg6naRuoUpcFxPMtIJ5+SaIjUPqBaOLAdJUdXfE4r/pvXS LB+fFtjtutq/mzAtPNMMFEevjXbUH8leLrgiJx9OkoschY6mive7HWUd1VXmwPyO9c3O wMI8j5OBJmcntcRwWHcZ08cj/drfiT5NkMr2u6viLIV9VDPyy0v8t3N7HObwESIAe32M hEzxLMDTKMr5AngNXsrzkABKv2AQ+gcTPaJXXJkQ9spQWTmA92dXDQ4bzsFM6kooH7MP e2oBWGcp/lWFOAfol/Uqyryvr20t/Izpn854yrOELOS6suLa1Lv74LcdSqFiR64wmdZd QP0w== X-Forwarded-Encrypted: i=1; AJvYcCXEJXgDBUtqQ1mVW1u6RoRv08JXnSZV3XBE/eo4VR/teXdfYpKyyLpi0Ekg3K0VJ/9OrlLkDXNE7ftRT9U=@vger.kernel.org X-Gm-Message-State: AOJu0YwlXa/IoGNIFv1r165Rc8VV+t9O+/qc5MRgxkYQGLI0JUdBCs7U 0AwkEmXmbj8n7J5WFXD11Qs+A9hbs7S+Bwcqjv/omxmBwdZ56BjWj0pf X-Gm-Gg: ASbGncuWEjqfHzaRP3R31Sh+377e+kM6Vsp4SdzJfRG3Ot/NsHrauC30cewH3KtoMHs macl/ozTAlI+M1j2Okr8W9MuT6Yi+aD6jbesuReW+mRxMFD9zKR6y54RUnslsQJBwQ1xIy9sdZk k5BlttyXbLON83/0bRBPC+Lb49B/pCNcimczuDsq6PFMOSoomGmuDrYYSz2/WLpdnu/MlZPxMhI 590gdVKHYsvIC7BxXTUM+y2FqF1QqxhvWs9D3S/O8RO827Hu5ae+fIxr+OlSxj1VmZwu8udRLot Nl9BAvUNejUge55XcvI6JIE9krqZLCCatz7mAZRUZo/jwCd+G4BCoFz1GVzgwfYbkc4gT07zzh4 kEq7ql6WEQHS2yPyFEt43W1Ua3u+xQpuwFfywQ9YAuN9njKh9F89vgXxYStoOh60xkw== X-Google-Smtp-Source: AGHT+IE6QAYldFReTbNhwKklFYNdCEVJpgfxwTpvKILLxf8DP4CkMPu7V/vifWE/k6I2u8vpWc3E8w== X-Received: by 2002:a17:90b:1b4d:b0:330:797a:f504 with SMTP id 98e67ed59e1d1-3342a215b70mr18813357a91.3.1759200300239; Mon, 29 Sep 2025 19:45:00 -0700 (PDT) Received: from localhost ([45.142.167.196]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-338387255adsm2766677a91.19.2025.09.29.19.44.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Sep 2025 19:44:59 -0700 (PDT) From: Jinchao Wang To: Andrew Morton , Masami Hiramatsu , Peter Zijlstra , Mike Rapoport , Alexander Potapenko , Randy Dunlap , Marco Elver , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Kees Cook , Alice Ryhl , Sami Tolvanen , Miguel Ojeda , Masahiro Yamada , Rong Xu , Naveen N Rao , David Kaplan , Andrii Nakryiko , Jinjie Ruan , Nam Cao , workflows@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-mm@kvack.org, llvm@lists.linux.dev, Andrey Ryabinin , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , kasan-dev@googlegroups.com, "David S. Miller" , Mathieu Desnoyers , linux-trace-kernel@vger.kernel.org Cc: Jinchao Wang Subject: [PATCH v6 08/23] mm/ksw: Add atomic watchpoint management api Date: Tue, 30 Sep 2025 10:43:29 +0800 Message-ID: <20250930024402.1043776-9-wangjinchao600@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250930024402.1043776-1-wangjinchao600@gmail.com> References: <20250930024402.1043776-1-wangjinchao600@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add three functions for atomic lifecycle management of watchpoints: - ksw_watch_get(): Acquires a watchpoint from a llist. - ksw_watch_on(): Enables the watchpoint on all online CPUs. - ksw_watch_off(): Disables the watchpoint and returns it to the llist. For cross-CPU synchronization, updates are propagated using direct modification on the local CPU and asynchronous IPIs for remote CPUs. Signed-off-by: Jinchao Wang --- mm/kstackwatch/kstackwatch.h | 4 ++ mm/kstackwatch/watch.c | 85 +++++++++++++++++++++++++++++++++++- 2 files changed, 88 insertions(+), 1 deletion(-) diff --git a/mm/kstackwatch/kstackwatch.h b/mm/kstackwatch/kstackwatch.h index 4eac1be3b325..850fc2b18a9c 100644 --- a/mm/kstackwatch/kstackwatch.h +++ b/mm/kstackwatch/kstackwatch.h @@ -38,11 +38,15 @@ const struct ksw_config *ksw_get_config(void); /* watch management */ struct ksw_watchpoint { struct perf_event *__percpu *event; + call_single_data_t __percpu *csd; struct perf_event_attr attr; struct llist_node node; // for atomic watch_on and off struct list_head list; // for cpu online and offline }; int ksw_watch_init(void); void ksw_watch_exit(void); +int ksw_watch_get(struct ksw_watchpoint **out_wp); +int ksw_watch_on(struct ksw_watchpoint *wp, ulong watch_addr, u16 watch_le= n); +int ksw_watch_off(struct ksw_watchpoint *wp); =20 #endif /* _KSTACKWATCH_H */ diff --git a/mm/kstackwatch/watch.c b/mm/kstackwatch/watch.c index 1d8e24fede54..887cc13292dc 100644 --- a/mm/kstackwatch/watch.c +++ b/mm/kstackwatch/watch.c @@ -31,11 +31,83 @@ static void ksw_watch_handler(struct perf_event *bp, panic("Stack corruption detected"); } =20 +static void ksw_watch_on_local_cpu(void *info) +{ + struct ksw_watchpoint *wp =3D info; + struct perf_event *bp; + ulong flags; + int cpu; + int ret; + + local_irq_save(flags); + cpu =3D raw_smp_processor_id(); + bp =3D per_cpu(*wp->event, cpu); + if (!bp) { + local_irq_restore(flags); + return; + } + + ret =3D modify_wide_hw_breakpoint_local(bp, &wp->attr); + local_irq_restore(flags); + WARN(ret, "fail to reinstall HWBP on CPU%d ret %d", cpu, ret); +} + +static void ksw_watch_update(struct ksw_watchpoint *wp, ulong addr, u16 le= n) +{ + call_single_data_t *csd; + int cur_cpu; + int cpu; + + wp->attr.bp_addr =3D addr; + wp->attr.bp_len =3D len; + + cur_cpu =3D raw_smp_processor_id(); + for_each_online_cpu(cpu) { + /* remote cpu first */ + if (cpu =3D=3D cur_cpu) + continue; + csd =3D per_cpu_ptr(wp->csd, cpu); + smp_call_function_single_async(cpu, csd); + } + ksw_watch_on_local_cpu(wp); +} + +int ksw_watch_get(struct ksw_watchpoint **out_wp) +{ + struct ksw_watchpoint *wp; + struct llist_node *node; + + node =3D llist_del_first(&free_wp_list); + if (!node) + return -EBUSY; + + wp =3D llist_entry(node, struct ksw_watchpoint, node); + WARN_ON_ONCE(wp->attr.bp_addr !=3D (u64)&holder); + + *out_wp =3D wp; + return 0; +} +int ksw_watch_on(struct ksw_watchpoint *wp, ulong watch_addr, u16 watch_le= n) +{ + ksw_watch_update(wp, watch_addr, watch_len); + return 0; +} + +int ksw_watch_off(struct ksw_watchpoint *wp) +{ + WARN_ON_ONCE(wp->attr.bp_addr =3D=3D (u64)&holder); + ksw_watch_update(wp, (ulong)&holder, sizeof(ulong)); + llist_add(&wp->node, &free_wp_list); + return 0; +} + static int ksw_watch_alloc(void) { int max_watch =3D ksw_get_config()->max_watch; struct ksw_watchpoint *wp; + call_single_data_t *csd; int success =3D 0; + int cpu; int ret; =20 init_llist_head(&free_wp_list); @@ -45,6 +117,16 @@ static int ksw_watch_alloc(void) wp =3D kzalloc(sizeof(*wp), GFP_KERNEL); if (!wp) return success > 0 ? success : -EINVAL; + wp->csd =3D alloc_percpu(call_single_data_t); + if (!wp->csd) { + kfree(wp); + return success > 0 ? success : -EINVAL; + } + + for_each_possible_cpu(cpu) { + csd =3D per_cpu_ptr(wp->csd, cpu); + INIT_CSD(csd, ksw_watch_on_local_cpu, wp); + } =20 hw_breakpoint_init(&wp->attr); wp->attr.bp_addr =3D (ulong)&holder; @@ -54,6 +136,7 @@ static int ksw_watch_alloc(void) ksw_watch_handler, wp); if (IS_ERR((void *)wp->event)) { ret =3D PTR_ERR((void *)wp->event); + free_percpu(wp->csd); kfree(wp); return success > 0 ? success : ret; } @@ -75,6 +158,7 @@ static void ksw_watch_free(void) list_for_each_entry_safe(wp, tmp, &all_wp_list, list) { list_del(&wp->list); unregister_wide_hw_breakpoint(wp->event); + free_percpu(wp->csd); kfree(wp); } mutex_unlock(&all_wp_mutex); @@ -88,7 +172,6 @@ int ksw_watch_init(void) if (ret <=3D 0) return -EBUSY; =20 - return 0; } =20 --=20 2.43.0