From nobody Thu Oct 2 02:13:28 2025 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1EC1216E32 for ; Tue, 30 Sep 2025 02:45:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759200312; cv=none; b=BLU1CCZPsfSISuHqbvdgwQGG08/eSJHCxA1Pq9pqfqzicJyZp/hgUcX7FQ2X0JUVHWAjPXhNFKOwHghSEy8omOl4s6vgb411p/r1emwX7XCx1UhbHuSpwmZrltSkgV9rLfAcAatpmrIB5TkxEdtTGBKgtr4TZQ5tQ3JgsPUXdPs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759200312; c=relaxed/simple; bh=EtuMaKP8CWfi9pjY9FcQGV9HEHi4WtiOKMPT566R1T4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pIKaTveVQHZhkhuGubzphPF3178kqrvrwBYNnXrTnApUVO+/jFoNCHgqqrBxL62whyu3FAX4Zc6x/mdmqsnh8Kv7dMt8p/AD6VQPJVOqVDQhG4DatxarxWF07QLQLz5sRghHpzEotcb9bf+Tes4suE0HmIodGR5vp+rcs0W9qFM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GsITOqqY; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GsITOqqY" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-781ea2cee3fso2301895b3a.0 for ; Mon, 29 Sep 2025 19:45:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759200310; x=1759805110; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VplC5p74+BCL3Xjzqw2UL/AL1hevTQUKrGPaYOT40mY=; b=GsITOqqYnKqZ1zRX4YByuGKp8skPIoPTvM2JpobPjAuYfxoIK8XcoyyL/slPo7DPzx g7QcrpZkln2+aaFM9C/a0nzNKl2IVdXxpsao+IuZoWj2ncebpODIgQAQp/vTbOasgvvc wk2gJDEUdhKiG8C6CXEu30npaYDNHzDVYv8MWtf3l1zz/p36tUiYM6C74IovR1cQblNg 879SZoWJ94tFnPnmxyqFA6605yTBqNmybm0vCSiTxsky7t+JL+mrFVnzSSAjH094i/Hp ii44jnyfE427PJEBd+VWOGIdWCQlQ2Tb5PnbzLaaoAXIxTCyWc06a+AxacNyQSC5R/ro Gdww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759200310; x=1759805110; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VplC5p74+BCL3Xjzqw2UL/AL1hevTQUKrGPaYOT40mY=; b=UU65O3PqfVlq15BHtSjOkCQzeV0TrPMmgJINSstKbZKqO16qi3lGHZSyvJLfKe12yY 8uNPUScUJDLgQiRLY7M5UY+sahIQnQ2tRzwYznAGvxeJ402zNPoN3GTK/aMQGaD5dttv cLFbHNAexoVXhMUlNQKcZLC7/s/JsuZnOPCiQ1Z0BxonWkrGnAFuuVYGWdTsA3fKKPoF WV18l8BBtcQK4M16NRy6kvaJTF6FTQZ/leuSzugvZSewFJoniZdazy52HPrhcW7oIl3y 8MMivftPCdf3L8guc3SPCXoPTC99LjgkvF01tUxjEarj0QrCgU3Ifwuc2VQpQ0MxcaQx HAfA== X-Forwarded-Encrypted: i=1; AJvYcCX83SBLo2s96Ni+ueH8DYc6HsYr3jHJhxZSfbKvehGP+r1lUGL1T3P6n9IBl/RoUycOgzoNsw6nfF+wnao=@vger.kernel.org X-Gm-Message-State: AOJu0YzhDdDxOQWwFBuiw0oNWAFU73MTKCKG0wL6CxdK6c+6YdEDRS66 eyz7tSZcETjLuFPh6HMNxjFBPBG9xOe7Tv8t+1BaTmV1ZKHZUancNIAV X-Gm-Gg: ASbGncsajmIruJS58cQe5nltOJYk6e3z/gFE1x9pFDPrNZycGsYX6VgyG+9y8sb07Ao 13cAh0vgjZg/c7iIg/pOVKhGxGb5HRxXvYVVNx95UZOefPEs36l7QIZ1/qPKw5pDTcvyKTfZ87I mjeyWz5CriXoRFr5mG/lmZ5lT9wU02vDnYrC/x+v6yxoyfgm9oBzwp2y8O5gTdBexw0CpAoRwCC 79Jfgz82yRfyccGkNZNPDvvmlrRKfExl3eyfROphxBeH7hNTOhvUL/NOYQbVMU9qdRm5YWEhRMC YvyemP4uVuNVdsXlY8jhZKZOAURV0jRYBpXvFnXOplp8jGhvGxFpOeZSLOogjSbDGVcAcxu9NW6 aRQJhcNSSTfYpf1FJ0arQk3AiiLndqEVPxjaJ5BsqIP06sjkxucVzHX12KtzGfCcBs1sosqngXR Yt X-Google-Smtp-Source: AGHT+IFzdUzonqFGpCtXDfhyMuXTs8sxTYcPas1DIEDImQCxbrq0zIYK9+c7MQCk4izaUyzaG6ziGA== X-Received: by 2002:a05:6a21:e098:b0:250:f80d:b355 with SMTP id adf61e73a8af0-2e7cdd9ffe2mr5395317637.33.1759200309894; Mon, 29 Sep 2025 19:45:09 -0700 (PDT) Received: from localhost ([45.142.167.196]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-78102b23206sm12485889b3a.58.2025.09.29.19.45.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Sep 2025 19:45:09 -0700 (PDT) From: Jinchao Wang To: Andrew Morton , Masami Hiramatsu , Peter Zijlstra , Mike Rapoport , Alexander Potapenko , Randy Dunlap , Marco Elver , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Kees Cook , Alice Ryhl , Sami Tolvanen , Miguel Ojeda , Masahiro Yamada , Rong Xu , Naveen N Rao , David Kaplan , Andrii Nakryiko , Jinjie Ruan , Nam Cao , workflows@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-mm@kvack.org, llvm@lists.linux.dev, Andrey Ryabinin , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , kasan-dev@googlegroups.com, "David S. Miller" , Mathieu Desnoyers , linux-trace-kernel@vger.kernel.org Cc: Jinchao Wang Subject: [PATCH v6 10/23] mm/ksw: support CPU hotplug Date: Tue, 30 Sep 2025 10:43:31 +0800 Message-ID: <20250930024402.1043776-11-wangjinchao600@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250930024402.1043776-1-wangjinchao600@gmail.com> References: <20250930024402.1043776-1-wangjinchao600@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Register CPU online/offline callbacks via cpuhp_setup_state_nocalls() so stack watches are installed/removed dynamically as CPUs come online or go offline. When a new CPU comes online, register a hardware breakpoint for the holder, avoiding races with watch_on()/watch_off() that may run on another CPU. The watch address will be updated the next time watch_on() is called. Signed-off-by: Jinchao Wang --- mm/kstackwatch/watch.c | 52 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 52 insertions(+) diff --git a/mm/kstackwatch/watch.c b/mm/kstackwatch/watch.c index 722ffd9fda7c..f32b1e46168c 100644 --- a/mm/kstackwatch/watch.c +++ b/mm/kstackwatch/watch.c @@ -89,6 +89,48 @@ static void ksw_watch_on_local_cpu(void *info) WARN(ret, "fail to reinstall HWBP on CPU%d ret %d", cpu, ret); } =20 +static int ksw_watch_cpu_online(unsigned int cpu) +{ + struct perf_event_attr attr; + struct ksw_watchpoint *wp; + call_single_data_t *csd; + struct perf_event *bp; + + mutex_lock(&all_wp_mutex); + list_for_each_entry(wp, &all_wp_list, list) { + attr =3D wp->attr; + attr.bp_addr =3D (u64)&holder; + bp =3D perf_event_create_kernel_counter(&attr, cpu, NULL, + ksw_watch_handler, wp); + if (IS_ERR(bp)) { + pr_warn("%s failed to create watch on CPU %d: %ld\n", + __func__, cpu, PTR_ERR(bp)); + continue; + } + + per_cpu(*wp->event, cpu) =3D bp; + csd =3D per_cpu_ptr(wp->csd, cpu); + INIT_CSD(csd, ksw_watch_on_local_cpu, wp); + } + mutex_unlock(&all_wp_mutex); + return 0; +} + +static int ksw_watch_cpu_offline(unsigned int cpu) +{ + struct ksw_watchpoint *wp; + struct perf_event *bp; + + mutex_lock(&all_wp_mutex); + list_for_each_entry(wp, &all_wp_list, list) { + bp =3D per_cpu(*wp->event, cpu); + if (bp) + unregister_hw_breakpoint(bp); + } + mutex_unlock(&all_wp_mutex); + return 0; +} + static void ksw_watch_update(struct ksw_watchpoint *wp, ulong addr, u16 le= n) { call_single_data_t *csd; @@ -210,6 +252,16 @@ int ksw_watch_init(void) if (ret <=3D 0) return -EBUSY; =20 + ret =3D cpuhp_setup_state_nocalls(CPUHP_AP_ONLINE_DYN, + "kstackwatch:online", + ksw_watch_cpu_online, + ksw_watch_cpu_offline); + if (ret < 0) { + ksw_watch_free(); + pr_err("Failed to register CPU hotplug notifier\n"); + return ret; + } + return 0; } =20 --=20 2.43.0