From nobody Thu Oct 2 02:15:10 2025 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E26D227599 for ; Mon, 29 Sep 2025 21:14:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759180449; cv=none; b=iczK+pQKYjOPzYHfIeHgBFx0sFRY9M7txSglw7sRZkIbPSu3V8o2di7LcQTJZcRv4S+5bGFhdVSLaU5E1gGBB/C9BMHsaiLb9zYV9cCK2PdkDzZ9sZioQ4jtb94Pmc/nTt7j0tTmpLOKiMIq3gcjPDhVyDQUebPZ1UTRBBnv7yY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759180449; c=relaxed/simple; bh=Ynh5t1oq+BGC5ayEleKfAh77OocncN7vunfZBZxFxdQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=fWikBdiZfk6BxRwM1RqCSnOqA2ce4TcPYnuTpVsEwPfx/KjqsrliSEBfwcChqGiHAhYoKBYZQOWYrfGWf+YWwZhFCFVuvMBcmINwhzKrGNY4Gwxxg2Uq1XhfQB2NPgVG1dfBm9j4x21mRI5vq8OwsRcWpj0AuTtbDKRVXTbElcI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LyaZ7L+D; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LyaZ7L+D" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-279e2554c8fso53548275ad.2 for ; Mon, 29 Sep 2025 14:14:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759180447; x=1759785247; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=qPMfvOFUo6Dm7WbBf/aklHipttbPQuSYzlg3rBgSq2c=; b=LyaZ7L+D176EL9Dua5/7Z2elCRae9ogEebkyI+b3WveGWfF/UIdIOLDA56JlblBh5f zyq+g+L+rXgR1PADVuzvh5aYKxN+NLOk5Zq+23+O1AZqoHjhqRjm4xVKbT1N2LY3HDHW Vol5xvefJY+j8w2csno0LhOv2+XIVld2GwZPBw0fmXRAkKwHt8nSHtxFEFHaJPWv6wZ4 IpII/zvREvtUGYCYr+wvoA0npa+/41tzXJgQult+KIhIdiRrdqYLzrbnDSGO+rIDsJWC kPqGtl6yIv5POCtHY3IkqBeJZLl6b+14ivwKSRbLSdZD2UIZTC0xQlmZ1Nyk3LQNL/hM Abzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759180447; x=1759785247; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qPMfvOFUo6Dm7WbBf/aklHipttbPQuSYzlg3rBgSq2c=; b=XaUIoc6mJlbFKmkC2o/QuZpDk1VqrwuVEOk9VKkZINQcaqeUDLoFWhaTpnRk9WRuQ8 g8AQlx/WdwHl3ecUOCkQKqnqFMfvpeHE7fG9AZ+X7dRK6aM2clu4B/CkCgV87j2GVQ8p /CVVD2sKpkS/twSikS8jmceSoTikh63eeq1JorV9ovO7K5ZvMZvxFlFVhjIHf3ZN9gx8 dfHW7SjfTHu1nIe8V4OtV9OBJ2e6Oe7kkwBwUuElB+e42Eew+P9Wxr3gSU0e034twPgB 2IIfxpviejdwytoSdEFEvTjH77bMeQqjXFxZW094/UGN/hOptMT9wWc6uJZX5EOObef2 WzPg== X-Forwarded-Encrypted: i=1; AJvYcCW3249zZdDkWWTsNyRwTkhghsAY5Mouvw4MFByESexxF2Cr5Vdfn9QhbC2z7uOiw7aZPHSz4N5PsLQARck=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7ocIjcnQlJFm9OpfpPYKhUjUxKysS3ukWGyS6/ScFawHb3xrs WI1ff66keXXLk/EcjnvCViGNoA2P261Z0fNXkxVebj77Wnk9XhNRqaaq X-Gm-Gg: ASbGncvFtsFJ9cmEgA0Z2BHq56E9LxIaF+bQoWXdb9ZCLg95zWecijIvUHECiAYdaUH ASBK1S7ci1rYOwhO/0/5SJHwd2WSfigu4OngjTaQtnVjFTwxtGMCDXa1MCn9KiKRO7RKymGwbDT LjnUDbpo48yr5I+p9wINtNxfN7D5RptgpfV7CWOKsqA5aicqk4f0Y1x4IsiCX/azW/mg3D+JvYQ xghqzyfA1A9H5BnS8yKqKU/ElmBz9y9yVWTZdjhf97p7/AskqI/QTI78jXgRXJ99j2o0+kdRxof ox0K02KqZTKsiMaFI3xr+0RV+9q3iYqV33LwgESrS6OeNH4qPsmoU34UvSo/Qvrq1mnqEOnDnjm 4ES7YtRS6bp0NQtL81gzqSafaI8N6 X-Google-Smtp-Source: AGHT+IG0ZHDqFJrZOvYs432O3Vs3qhLTPiCHHRZ6amJmNF+g4TGNvnUA39X9wjADrt/48NlD7oC1jQ== X-Received: by 2002:a17:903:90d:b0:268:baa6:94ba with SMTP id d9443c01a7336-27ed4ab65b8mr155433085ad.53.1759180446950; Mon, 29 Sep 2025 14:14:06 -0700 (PDT) Received: from y740.local ([2401:4900:1f31:e91f:2d6d:e8a8:f2d7:94ae]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-27ed69b12cdsm137943045ad.115.2025.09.29.14.14.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Sep 2025 14:14:06 -0700 (PDT) From: Sidharth Seela To: antonio@openvpn.net, sd@queasysnail.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, shuah@kernel.org, willemdebruijn.kernel@gmail.com, kernelxing@tencent.com, nathan@kernel.org, nick.desaulniers+lkml@gmail.com, morbo@google.com, justinstitt@google.com Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Sidharth Seela Subject: [PATCH net v3] selftest:net: Fix uninit return values Date: Tue, 30 Sep 2025 02:42:42 +0530 Message-ID: <20250929211241.55701-2-sidharthseela@gmail.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix functions that return undefined values. These issues were caught by running clang using LLVM=3D1 option; and are as follows: -- ovpn-cli.c:1587:6: warning: variable 'ret' is used uninitialized whenever '= if' condition is true [-Wsometimes-uninitialized] 1587 | if (!sock) { | ^~~~~ ovpn-cli.c:1635:9: note: uninitialized use occurs here 1635 | return ret; | ^~~ ovpn-cli.c:1587:2: note: remove the 'if' if its condition is always false 1587 | if (!sock) { | ^~~~~~~~~~~~ 1588 | fprintf(stderr, "cannot allocate netlink socket\n"); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1589 | goto err_free; | ~~~~~~~~~~~~~~ 1590 | } | ~ ovpn-cli.c:1584:15: note: initialize the variable 'ret' to silence this war= ning 1584 | int mcid, ret; | ^ | =3D 0 ovpn-cli.c:2107:7: warning: variable 'ret' is used uninitialized whenever s= witch case is taken [-Wsometimes-uninitialized] 2107 | case CMD_INVALID: | ^~~~~~~~~~~ ovpn-cli.c:2111:9: note: uninitialized use occurs here 2111 | return ret; | ^~~ ovpn-cli.c:1939:12: note: initialize the variable 'ret' to silence this war= ning 1939 | int n, ret; | ^ | -- Fixes: 959bc330a439 ("testing/selftests: add test tool and scripts for ovpn= module") ovpn module") v3: - Use prefix net. - Remove so_txtime fix as default case calls error(). - Changelog before sign-off. - Three dashes after sign-off v2: - Use subsystem name "net". - Add fixes tags. - Remove txtimestamp fix as default case calls error. - Assign constant error string instead of NULL. Signed-off-by: Sidharth Seela --- diff --git a/tools/testing/selftests/net/ovpn/ovpn-cli.c b/tools/testing/se= lftests/net/ovpn/ovpn-cli.c index 9201f2905f2c..20d00378f34a 100644 --- a/tools/testing/selftests/net/ovpn/ovpn-cli.c +++ b/tools/testing/selftests/net/ovpn/ovpn-cli.c @@ -1581,7 +1581,7 @@ static int ovpn_listen_mcast(void) { struct nl_sock *sock; struct nl_cb *cb; - int mcid, ret; + int mcid, ret =3D -1; =20 sock =3D nl_socket_alloc(); if (!sock) { @@ -1936,7 +1936,7 @@ static int ovpn_run_cmd(struct ovpn_ctx *ovpn) { char peer_id[10], vpnip[INET6_ADDRSTRLEN], laddr[128], lport[10]; char raddr[128], rport[10]; - int n, ret; + int n, ret =3D -1; FILE *fp; =20 switch (ovpn->cmd) { --=20 2.47.3