From nobody Thu Oct 2 02:15:09 2025 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B87227F198 for ; Mon, 29 Sep 2025 19:09:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759172954; cv=none; b=GWi1ag9Xycpznu0fXplfoj/0GCyJ7INGniXqzI2Yx6PxK0V7DFrAID3FEySXYArv93jn1I5e2dhTRUE449A5MQv2oqqWpj5dqCenkvRF5F4qWCYC8Xpp34Dshn4JyE5ju8XuvDLQPmH3fIJH6Mmqrm4m9+k8/oMPkhBK2+f0IIk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759172954; c=relaxed/simple; bh=PDbyASb6oi0nl45LtWvyo0kRcHkCyKYVr1dxxwhi2G4=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=ZyUxyNinfyx8ks0KqepTmkiDZx62hXri7+lAO/e7ttuYGDIDVRhnn3TSyCmcmvcUAsYbktr5tdRM/IfNtvZA9hbktaBD2ynQsOCdzjdxsXEop61kevDZPH/BaqFUU+8a8qagjm051RG4Ofp6WwBHdY68j7zprYaF1vJ1F1iCAAI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=LDwfccL7; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="LDwfccL7" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-335276a711cso4447837a91.2 for ; Mon, 29 Sep 2025 12:09:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1759172952; x=1759777752; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=CLBs8A19UY4qrfPktznrRiT2oVtJL0cBY+Wi6IC10nw=; b=LDwfccL7uRQgfpCEQZZPD+6l7KV4Xtx9XfOYA/jsGBZe14VB7obvt+zM/snu6FkAoh pxIwVnd5u3VXGRj8hq1Gvh3BF3P9Oa1RRaBlcipiArqaCFlP2ZCHC6xs/8GF+NT86xOI +aHuHfSf33+AE+T6kNkxOFH1iF25HZ82B8oxQUhkA0acbj1PufWvpFY4Bu7Hfy7tmaGB Ftcg3X3/7YF6aoVmPzqGcxWOKzNFmeK6NZkFYPNLCm+PPfZ8kkjvTw8L2glDQ/n+mt/6 aPEiPNm28p9cMLFQa3CvrpZGYW0NYNZcVersnOSVocEqmq3eG1pv1fx8yWxSBDW954KD XTNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759172952; x=1759777752; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CLBs8A19UY4qrfPktznrRiT2oVtJL0cBY+Wi6IC10nw=; b=pj9h9U+L481+PJm5yPC0eFcImqF2dj0OQNrej9qnVaK8ZTb7z5udcHZCnVxl81K+BU Qrp+xONtX7sbYD8ciXalV10LfQQFLgvRI5SkVXh8JS9iaJ01oLs70bBxzc/hzCqi76G0 cNyM3Q3amEX3mvNT0UoPQUZQP9Ju6JNOtn8m/uLUbPynMCzzaySbzJWEZihJpD43XKRF pOv4DHK734Y+DoT8ZKe3pdYqGWLHbC/iVxyt8LulreLVh0Uk/MMzRBerrNucfNbEoKds Ify0mbJzJhl/BiZwdewfQ7H0+IFjKvTEI2ViRR+H31US8oB+wpPRM7X6sN3H3o3G9QWh Ojvg== X-Forwarded-Encrypted: i=1; AJvYcCUcGN2ZHS3+S2cDOYUPVGVWjpCesVe2Sq5dISsIpXYG1rxnSBD3wIuXGu6C2EKMstihcPoI98mucjkYXtQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxS9C9pNPEtQzpOov2sD3or6o3sQvbtDzZ2/mE/oEXP/W27Opku elQ8+TKk15EhjLrRxbMhGyJt5NgWrsVy3v+K6NCTRtf9mmlAmzi5KbgU03lurw3w5JzbQR8e90u mn9jd0OGdtQ== X-Google-Smtp-Source: AGHT+IEAC9a1XEUOGGyjwkk2VhXg5eHtNB/otbVrKPS7fT7pgJKU6BcOUwXrzCMoVf6kg30mhKL3QelUZQIH X-Received: from pjbsf12.prod.google.com ([2002:a17:90b:51cc:b0:334:1935:56cc]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:1f8c:b0:330:797a:f4ea with SMTP id 98e67ed59e1d1-3342a2e73d7mr21521918a91.29.1759172952591; Mon, 29 Sep 2025 12:09:12 -0700 (PDT) Date: Mon, 29 Sep 2025 12:08:01 -0700 In-Reply-To: <20250929190805.201446-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250929190805.201446-1-irogers@google.com> X-Mailer: git-send-email 2.51.0.570.gb178f27e6d-goog Message-ID: <20250929190805.201446-12-irogers@google.com> Subject: [PATCH v6 11/15] perf llvm: Disassemble cleanup From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Charlie Jenkins , Eric Biggers , "Masami Hiramatsu (Google)" , James Clark , Collin Funk , "Dr. David Alan Gilbert" , Li Huafei , Athira Rajeev , Stephen Brennan , Dmitry Vyukov , Alexandre Ghiti , Haibo Xu , Andi Kleen , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, bpf@vger.kernel.org, llvm@lists.linux.dev, Song Liu Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Move the 3 LLVM initialization routines to be called in a single init_llvm function that has its own bool to avoid repeated initialization. Reduce the scope of triplet and avoid copying strings for x86. Signed-off-by: Ian Rogers --- tools/perf/util/llvm.c | 32 ++++++++++++++++++++------------ 1 file changed, 20 insertions(+), 12 deletions(-) diff --git a/tools/perf/util/llvm.c b/tools/perf/util/llvm.c index a0774373f0d6..a28f130c8951 100644 --- a/tools/perf/util/llvm.c +++ b/tools/perf/util/llvm.c @@ -244,6 +244,17 @@ static void perf_LLVMDisasmDispose(LLVMDisasmContextRe= f context) #endif } =20 +static void init_llvm(void) +{ + static bool init; + + if (!init) { + perf_LLVMInitializeAllTargetInfos(); + perf_LLVMInitializeAllTargetMCs(); + perf_LLVMInitializeAllDisassemblers(); + init =3D true; + } +} =20 static void free_llvm_inline_frames(struct llvm_a2l_frame *inline_frames, int num_frames) @@ -339,7 +350,6 @@ int symbol__disassemble_llvm(const char *filename, stru= ct symbol *sym, u64 buf_len; u64 pc; bool is_64bit; - char triplet[64]; char disasm_buf[2048]; size_t disasm_len; struct disasm_line *dl; @@ -352,27 +362,25 @@ int symbol__disassemble_llvm(const char *filename, st= ruct symbol *sym, if (args->options->objdump_path) return -1; =20 - perf_LLVMInitializeAllTargetInfos(); - perf_LLVMInitializeAllTargetMCs(); - perf_LLVMInitializeAllDisassemblers(); - buf =3D dso__read_symbol(dso, filename, map, sym, &code_buf, &buf_len, &is_64bit); if (buf =3D=3D NULL) return -1; =20 + init_llvm(); if (arch__is(args->arch, "x86")) { - if (is_64bit) - scnprintf(triplet, sizeof(triplet), "x86_64-pc-linux"); - else - scnprintf(triplet, sizeof(triplet), "i686-pc-linux"); + const char *triplet =3D is_64bit ? "x86_64-pc-linux" : "i686-pc-linux"; + + disasm =3D perf_LLVMCreateDisasm(triplet, &storage, /*tag_type=3D*/0, + /*get_op_info=3D*/NULL, symbol_lookup_callback); } else { + char triplet[64]; + scnprintf(triplet, sizeof(triplet), "%s-linux-gnu", args->arch->name); + disasm =3D perf_LLVMCreateDisasm(triplet, &storage, /*tag_type=3D*/0, + /*get_op_info=3D*/NULL, symbol_lookup_callback); } - - disasm =3D perf_LLVMCreateDisasm(triplet, &storage, 0, NULL, - symbol_lookup_callback); if (disasm =3D=3D NULL) goto err; =20 --=20 2.51.0.570.gb178f27e6d-goog