From nobody Wed Oct 1 23:30:06 2025 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0DC73019C2 for ; Mon, 29 Sep 2025 11:38:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759145905; cv=none; b=UgP9QO0jHeX7jF228ORoCT0IOpglT9I9gvuRG4tCnzDXnVivhcur+DumqjzQpXyk/Q05FwKuH3LOC/Eo+rxTkZRfz7vUpjbavTbCBEHIJndhol90t+xac3BeOwNPut47zkJQDvse4AryXmpreIQdN8W0wLAi/F05frvWcTAfW9c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759145905; c=relaxed/simple; bh=OuzlMBf2DYxUrGozGqCnGqXutFM3aRqod7/0oO6AhUE=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MXVO2A+yUIOLkBAo3cS8ZHr1PGBXqPpkFA0PlebD8Zm/hHWgD/Mo4zJ7041coKgKRtumjLNrCcD88liYCHnqXMUBXaLOBSuvqQ2SoLZADDN6eKdjnIUrh5Z9mlM5nTzlNUyTRQaq4LGR3z1O6OHOBKPXBpk6iHlqETUA/DNb3s4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cDg4tRWN; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cDg4tRWN" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-46e2826d5c6so34054575e9.1 for ; Mon, 29 Sep 2025 04:38:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759145901; x=1759750701; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=3LU04oH6Jeu7LPnO6lTLYJu+6qHSNvnAGZMQiBqSTLE=; b=cDg4tRWNlagFMKq37giuUe8paoEMsdJzfqj5yqjtUm+vHz1Oyr6GKuKSVYusQ1ldqF 1fFTOG5vky8NLD6170RjsR2CG5P/5vV80nWCUoV4Xq4CXUsymPO/6ZzXSCAjxcOOFBHs z59DyiKFx0V3HlDd5Qpf09NcM0CE+v3YRzoU62VpaKtvD//L42HPF6xO+S3xhBswl6b2 sRlUL5F86XW+j2LYcdyxQx09rxTQ66Gv574PT+uarL/o/0P0pkSU09goo8lgaOcp3f4y 7HyWyg8TG2rLnzfvTYCfweg+jdd5TC0Hw9G84sRUswxo7JVg+wX0QhtF0Cq8RCkiQgvx d/Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759145901; x=1759750701; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3LU04oH6Jeu7LPnO6lTLYJu+6qHSNvnAGZMQiBqSTLE=; b=aF/cYPdrajFTM/UH6zAMBI1bNc4UBQCzd7HzrU8SmnccDGMFiM+0qf4bZpZnt8zS2J d6Y/qxtPWBRohZyS9Q86RCzQKGYGBSD5E5J84HNA06DOD44clwIFemYtVYJpnPWnoB4u nEXpGUWT1T9SvRTcT/kzYbBdv3O71SWH0dnKP7vsI2R2DQuAqfH+2Evy795P5zfVP/2I O+HmcfGRFzfGrfZuk/GHvU/QQ7Za078z1CUlsVohZWIjCaf28uNviVrGj1Rc4BFCxpbQ 5YM31tylkf2sbRX2Gy+DRDzyhJTGl0vlMS4vnRzodvvmtz37FYtKlcEq5k10NVnWrdP0 nKLw== X-Forwarded-Encrypted: i=1; AJvYcCXePHFfd1KN+T+1p6ZVQeXaG29Nb+VijE81WvxkULKtwrbSk9vIDFiIDeEUYyJvzECDvNfE8FY9twbppxg=@vger.kernel.org X-Gm-Message-State: AOJu0YyCJHKf31Ssnoa+aWAsqavGJkVZuZqMuPX2XHqJZ6gdHZFRJ6TS E/3qxfS0nAO5W/9Uz2TU2nduu5gDDJ1T1iwgQZExYEDOrUDK+AftgDuVymilNw== X-Gm-Gg: ASbGncuP/Tp2eMMaSbE/4dNztdNXiEpFB1iUzYS28l+Zba3sfLUK5lBsEBXE8whm08s BPQ4nFyrBMy2rCQAiq7E8xKOJ3JkitAQuHcg/p5u/UG3+7+KtdU3JXwK22Zewf0elgMlCgMrdlZ BkOlpogkVvG9oMtP0CwdpRvMROx02nUnQ+qXWAS/dT9BRgYGJrk/I1f0Vv8RjkAqNEbKCqKPCj3 aDPZLDwLdEd2GFptNJ6ZvriA52hUBVg78zaUIhoh1G4hNiFF2/JeskfSxLSpzyzMgO9+Q0jka+J HSoYH//Wyvr3C9DmQbKbpcieTtKsHzNjL1REeJJSqpfFQoQ2mbgmva7gUAaQyjkR1tfFegYWfvz wWXW4BROt0rwbtJkSXpUusNrvMvUBchNgusnauyu7qt8DK+rg4kqLjT/S4UfsUQ4RwdUdpm8= X-Google-Smtp-Source: AGHT+IGwis8GqJEF1Qzf9bSzV6u14blzsX+OeBzCW6GOkWLJgWkwGAve2YAB0K6RDda7Irm9+euaNA== X-Received: by 2002:a05:600c:1e23:b0:46e:39e1:fc3c with SMTP id 5b1f17b1804b1-46e3a4e1b6amr123957035e9.5.1759145901122; Mon, 29 Sep 2025 04:38:21 -0700 (PDT) Received: from Ansuel-XPS24 (host-95-249-236-54.retail.telecomitalia.it. [95.249.236.54]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-46e56f53596sm9502465e9.7.2025.09.29.04.38.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Sep 2025 04:38:20 -0700 (PDT) From: Christian Marangi To: Ryder Lee , Jianjun Wang , Bjorn Helgaas , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Christian Marangi , linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 4/5] PCI: mediatek: convert bool to single flags entry and bitmap Date: Mon, 29 Sep 2025 13:38:03 +0200 Message-ID: <20250929113806.2484-5-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250929113806.2484-1-ansuelsmth@gmail.com> References: <20250929113806.2484-1-ansuelsmth@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" To clean Mediatek SoC PCIe struct, convert all the bool to a bitmap and use a single flags to reference all the values. This permits cleaner addition of new flag without having to define a new bool in the struct. Signed-off-by: Christian Marangi --- drivers/pci/controller/pcie-mediatek.c | 28 +++++++++++++++----------- 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/drivers/pci/controller/pcie-mediatek.c b/drivers/pci/controlle= r/pcie-mediatek.c index 24cc30a2ab6c..1678461e56d3 100644 --- a/drivers/pci/controller/pcie-mediatek.c +++ b/drivers/pci/controller/pcie-mediatek.c @@ -142,24 +142,29 @@ =20 struct mtk_pcie_port; =20 +enum mtk_pcie_flags { + NEED_FIX_CLASS_ID =3D BIT(0), /* host's class ID needed to be fixed */ + NEED_FIX_DEVICE_ID =3D BIT(1), /* host's device ID needed to be fixed */ + NO_MSI =3D BIT(2), /* Bridge has no MSI support, and relies on an + * external block + */ +}; + /** * struct mtk_pcie_soc - differentiate between host generations - * @need_fix_class_id: whether this host's class ID needed to be fixed or = not - * @need_fix_device_id: whether this host's device ID needed to be fixed o= r not * @no_msi: Bridge has no MSI support, and relies on an external block * @device_id: device ID which this host need to be fixed * @ops: pointer to configuration access functions * @startup: pointer to controller setting functions * @setup_irq: pointer to initialize IRQ functions + * @flags: pcie device flags. */ struct mtk_pcie_soc { - bool need_fix_class_id; - bool need_fix_device_id; - bool no_msi; unsigned int device_id; struct pci_ops *ops; int (*startup)(struct mtk_pcie_port *port); int (*setup_irq)(struct mtk_pcie_port *port, struct device_node *node); + u32 flags; }; =20 /** @@ -703,7 +708,7 @@ static int mtk_pcie_startup_port_v2(struct mtk_pcie_por= t *port) writel(val, port->base + PCIE_RST_CTRL); =20 /* Set up vendor ID and class code */ - if (soc->need_fix_class_id) { + if (soc->flags & NEED_FIX_CLASS_ID) { val =3D PCI_VENDOR_ID_MEDIATEK; writew(val, port->base + PCIE_CONF_VEND_ID); =20 @@ -711,7 +716,7 @@ static int mtk_pcie_startup_port_v2(struct mtk_pcie_por= t *port) writew(val, port->base + PCIE_CONF_CLASS_ID); } =20 - if (soc->need_fix_device_id) + if (soc->flags & NEED_FIX_DEVICE_ID) writew(soc->device_id, port->base + PCIE_CONF_DEVICE_ID); =20 /* 100ms timeout value should be enough for Gen1/2 training */ @@ -1099,7 +1104,7 @@ static int mtk_pcie_probe(struct platform_device *pde= v) =20 host->ops =3D pcie->soc->ops; host->sysdata =3D pcie; - host->msi_domain =3D pcie->soc->no_msi; + host->msi_domain =3D !!(pcie->soc->flags & NO_MSI); =20 err =3D pci_host_probe(host); if (err) @@ -1187,9 +1192,9 @@ static const struct dev_pm_ops mtk_pcie_pm_ops =3D { }; =20 static const struct mtk_pcie_soc mtk_pcie_soc_v1 =3D { - .no_msi =3D true, .ops =3D &mtk_pcie_ops, .startup =3D mtk_pcie_startup_port, + .flags =3D NO_MSI, }; =20 static const struct mtk_pcie_soc mtk_pcie_soc_mt2712 =3D { @@ -1199,19 +1204,18 @@ static const struct mtk_pcie_soc mtk_pcie_soc_mt271= 2 =3D { }; =20 static const struct mtk_pcie_soc mtk_pcie_soc_mt7622 =3D { - .need_fix_class_id =3D true, .ops =3D &mtk_pcie_ops_v2, .startup =3D mtk_pcie_startup_port_v2, .setup_irq =3D mtk_pcie_setup_irq, + .flags =3D NEED_FIX_CLASS_ID, }; =20 static const struct mtk_pcie_soc mtk_pcie_soc_mt7629 =3D { - .need_fix_class_id =3D true, - .need_fix_device_id =3D true, .device_id =3D PCI_DEVICE_ID_MEDIATEK_7629, .ops =3D &mtk_pcie_ops_v2, .startup =3D mtk_pcie_startup_port_v2, .setup_irq =3D mtk_pcie_setup_irq, + .flags =3D NEED_FIX_CLASS_ID | NEED_FIX_DEVICE_ID, }; =20 static const struct of_device_id mtk_pcie_ids[] =3D { --=20 2.51.0