From nobody Wed Oct 1 23:46:49 2025 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A2C2283FCB; Mon, 29 Sep 2025 09:14:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=68.232.153.233 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759137252; cv=none; b=ADPrsb1hMVY0F40LOo0a/+XQrdQNGYYs0GIFoMQb5KIEiJjuT/6Kx/CDJrKJ+ah1d7ntlYJV68ICe/Zga1JpUPNAaaRdPlbDU0AvyGRkKPy+GgWpeGakHKP4aq0hDNBRZNDrWWmaacDQ0X99tx/NschOalQJiwzzN1WUQZ7VoSk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759137252; c=relaxed/simple; bh=eurQv0xeKau5jRgrZWm1V5cTpeVBo/sd9VBHUwcd3rM=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Ph14rmZy8isZaScT15Kh5z1giJm8RZqKmyaaEEf11qY9bo1T3iJSX3UcNkj0wvbsJAhnNRx26dSuSjJqTTMI56x8si2iOU/aEWF/oo5C83vuv+ltUFlTTrzMre0wDo13NvRE1vBHc7bOoCbI+7I6NM1LrZ448tO7te0xtI+2uOc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com; spf=pass smtp.mailfrom=microchip.com; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b=yEPT6GlO; arc=none smtp.client-ip=68.232.153.233 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=microchip.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="yEPT6GlO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1759137251; x=1790673251; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=eurQv0xeKau5jRgrZWm1V5cTpeVBo/sd9VBHUwcd3rM=; b=yEPT6GlON7AoZBuyYsksiedDTR7dEiHqQWWiyCzxmaYUycRKxvlAe3wl XEuF6cOuymy0w5+iVgIwNsqt2jgeWAxN3bZaknP0h1fVfG4WyLygK3ufF xpbIS3W397TYsXDSYsq9ALFkrLK17la4XrwqaeEGvLsJoJ6GA9Ve2JtmC F7dYgYk2KkOn4W8QHTbyEkiG97kmolkoLbr1XlgZHLqduDLPpFZwhESjf 0QtMVKy26rg0STEOAIQTNsWizpF3+UXy0NfCV7tbDBCMC59NGkfIDdmgB TQOekarCDkXAiyzHu9m9lSbAfgWQkXzYssScg3CUJLJQR8Ut1JvTP9VCI A==; X-CSE-ConnectionGUID: PK2+grhpRW+bN+pyp3oWNw== X-CSE-MsgGUID: doHqLwRVTN+NoZ+K4f0SUg== X-IronPort-AV: E=Sophos;i="6.18,301,1751266800"; d="scan'208";a="53066881" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa1.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Sep 2025 02:14:03 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.58; Mon, 29 Sep 2025 02:13:55 -0700 Received: from DEN-DL-M31836.microchip.com (10.10.85.11) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.2507.58 via Frontend Transport; Mon, 29 Sep 2025 02:13:52 -0700 From: Horatiu Vultur To: , , , , , , , , , , , , , CC: , , Horatiu Vultur Subject: [PATCH net v3 2/2] phy: mscc: Fix PTP for VSC8574 and VSC8572 Date: Mon, 29 Sep 2025 11:13:02 +0200 Message-ID: <20250929091302.106116-3-horatiu.vultur@microchip.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250929091302.106116-1-horatiu.vultur@microchip.com> References: <20250929091302.106116-1-horatiu.vultur@microchip.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The PTP initialization is two-step. First part are the function vsc8584_ptp_probe_once() and vsc8584_ptp_probe() at probe time which initialize the locks, queues, creates the PTP device. The second part is the function vsc8584_ptp_init() at config_init() time which initialize PTP in the HW. For VSC8574 and VSC8572, the PTP initialization is incomplete. It is missing the first part but it makes the second part. Meaning that the ptp_clock_register() is never called. There is no crash without the first part when enabling PTP but this is unexpected because some PHys have PTP functionality exposed by the driver and some don't even though they share the same PTP clock PTP. Fixes: 774626fa440e ("net: phy: mscc: Add PTP support for 2 more VSC PHYs") Signed-off-by: Horatiu Vultur --- drivers/net/phy/mscc/mscc_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/phy/mscc/mscc_main.c b/drivers/net/phy/mscc/mscc_m= ain.c index d05f6ed052ad0..90b62b8fd4af6 100644 --- a/drivers/net/phy/mscc/mscc_main.c +++ b/drivers/net/phy/mscc/mscc_main.c @@ -2613,7 +2613,7 @@ static struct phy_driver vsc85xx_driver[] =3D { .suspend =3D &genphy_suspend, .resume =3D &genphy_resume, .remove =3D &vsc85xx_remove, - .probe =3D &vsc8574_probe, + .probe =3D &vsc8584_probe, .set_wol =3D &vsc85xx_wol_set, .get_wol =3D &vsc85xx_wol_get, .get_tunable =3D &vsc85xx_get_tunable, @@ -2636,12 +2636,12 @@ static struct phy_driver vsc85xx_driver[] =3D { .config_aneg =3D &vsc85xx_config_aneg, .aneg_done =3D &genphy_aneg_done, .read_status =3D &vsc85xx_read_status, - .handle_interrupt =3D vsc85xx_handle_interrupt, + .handle_interrupt =3D vsc8584_handle_interrupt, .config_intr =3D &vsc85xx_config_intr, .suspend =3D &genphy_suspend, .resume =3D &genphy_resume, .remove =3D &vsc85xx_remove, - .probe =3D &vsc8574_probe, + .probe =3D &vsc8584_probe, .set_wol =3D &vsc85xx_wol_set, .get_wol =3D &vsc85xx_wol_get, .get_tunable =3D &vsc85xx_get_tunable, --=20 2.34.1