From nobody Wed Oct 1 22:37:04 2025 Received: from PH0PR06CU001.outbound.protection.outlook.com (mail-westus3azon11011018.outbound.protection.outlook.com [40.107.208.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FF092BEC26 for ; Mon, 29 Sep 2025 07:38:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.208.18 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759131510; cv=fail; b=U4Sn7T6lGykX2ThvYZ/aUAQ2OyoDvUU80MjFr8nBo4LkuS0NG6bFBJnS2HoIpvpFg4GQuZCKAkm/1lILVDPex89i63/TMCZ6VNd2jKYEwtUBPjvQRb7bYk1anCsnslwPCUyo6x1fOoWErVWgvXkzGxGG7HE00i9Q4TFuqTpfNU8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759131510; c=relaxed/simple; bh=yFxIoZ+vsEhWM2802SjmW/ljWj8NdXcTks/UdiNjPNo=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Zm/44K4h0yYFT7DZCme+/WjPbUhntM9JJlvF4Wp8Xxhkwyv7rJE6HpigufxRx8iz81upQC4W1raDkBWLOJBSS+JFo4gru0Ju0LPgZTHsG3OIG99q2TuGnGEyjZmiqqr1wz1EbNxbHPJMsxaIKe230FrL7e9lEiDS7JQcXKVj3uM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=NfkMvMhL; arc=fail smtp.client-ip=40.107.208.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="NfkMvMhL" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lqj3KpZfJfI3GtBvQpKvfePdS8UYlrC2aOGSU6nZqO7F3sxLUVln9z0M///lTYRQSF/4G20mQzoWR2Lt6rgrscPl3g6mPeuN/kkeZCSYtIHkv5OqcjQyj6GqhpOse+st2hoFG8FZGOQDctrxkXKbhRNvJdqFsd0IJ34SaUn2mS0eymTvIC88yxAyhBO+Xtny4O7WPoIUTZk0vzDhwP1C9SIr9c0dRDs/gsYgWUFgJyKYdtIAZONQxOHARgWFCh6SAvs603mAb43gY9LCO14JNbyheOa74Yo39Vk6T7I9+RTCuKdZkynmeOc6RUglJkmP7mkHKPHFSpi6W1JA8loKlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aIJ3xA1SPOEd2mgilRha1ETEgH03qNaHwcw6RvQZfNM=; b=udN6HvZJoPpDPKpwquG/qMyO0WgNJeMd4ce8hv9TgbdUp8Q132CCBhgvQ/qcXYzMxtPeNiyFugByyYXGJVs2bP35yxvc84Kpe79FV71GXHpb5uqbM24pdqSxyZJ/N9AfwHfWSeSbG10W5UIP4nmGMSd7jItN/+EbcXkbYp/9m95W1BpvfT1IGVi1rshDqskc+JBL2qwBvi/LhUc+zD8NS5Ti1naLyzJViwznShagBIvtU0BWOriDdjhZMeVGLQXkTt07z46FMNoSRAejs8onXRi/7fB1OfS3KyebucWuHpjpbdoebZIWgjq6uTZM6e93/9Vfwm+tWrtKduHc64q5LQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aIJ3xA1SPOEd2mgilRha1ETEgH03qNaHwcw6RvQZfNM=; b=NfkMvMhLZcPlheCo3PwniKCHO0Pyle3e/NzQDSnasBiHdgNtJUkl6XZs2Lk3lbfMZZrs27xarDQM7nfCBfiCsy8vk5WzNbPHMsRggu0P6erpcw+U2EFGaNiL2bWftoDZZKoLcrX8cVwMMWVHFH1SQRHwKaCx8Rml0AIM5zik+2g= Received: from BY3PR10CA0024.namprd10.prod.outlook.com (2603:10b6:a03:255::29) by CY1PR12MB9650.namprd12.prod.outlook.com (2603:10b6:930:105::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.13; Mon, 29 Sep 2025 07:38:24 +0000 Received: from SJ1PEPF00001CE6.namprd03.prod.outlook.com (2603:10b6:a03:255:cafe::c8) by BY3PR10CA0024.outlook.office365.com (2603:10b6:a03:255::29) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9160.16 via Frontend Transport; Mon, 29 Sep 2025 07:38:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by SJ1PEPF00001CE6.mail.protection.outlook.com (10.167.242.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.9 via Frontend Transport; Mon, 29 Sep 2025 07:38:24 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.2562.17; Mon, 29 Sep 2025 00:37:55 -0700 Received: from satlexmb08.amd.com (10.181.42.217) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 29 Sep 2025 02:37:53 -0500 Received: from xhdharinit40.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Mon, 29 Sep 2025 00:37:51 -0700 From: Harini T To: , , CC: , , , Harini T Subject: [PATCH V2 1/4] mailbox: zynqmp-ipi: Remove redundant mbox_controller_unregister() call Date: Mon, 29 Sep 2025 13:07:20 +0530 Message-ID: <20250929073723.139130-2-harini.t@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250929073723.139130-1-harini.t@amd.com> References: <20250929073723.139130-1-harini.t@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: None (SATLEXMB04.amd.com: harini.t@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE6:EE_|CY1PR12MB9650:EE_ X-MS-Office365-Filtering-Correlation-Id: e4ca2b92-7aaa-443d-4a1c-08ddff2b2bec X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|376014|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?S/w/C653G3o7Hr3ZTeEd/TMY7/zBVJe7/v5UNCG0+eI9WJzh9WmEobczEOk8?= =?us-ascii?Q?N1oDaqkqmX+rNr7vkGw9RsBlbSwHKN77kQPMEjNCbNNZVWUPWyR8MyaALVEy?= =?us-ascii?Q?PyEKa3WrMA2pwrL3S+Ay+t7iFdwD3s4Ou+cdjEI9BSpyU4LdrY9dZUBnkB1B?= =?us-ascii?Q?pShF5nSqhGtQSG75DFYVGoWEmgolb17bVSK1BcXMvzSkuEDfA0DOlt1Dq/gO?= =?us-ascii?Q?87Bq3fVyEmrOZWbEeb2eKxaRQy9/JlQVfNuS25ymVnQ1TljNnbkeFexZTZwC?= =?us-ascii?Q?+2K/qhhVL6FgRqQ2vpPQpWoe/TjqljoW2mPVCp0loaz0XRGAhlykh16L1/L3?= =?us-ascii?Q?MeLJ07Zm6uwWdSLFOijqeB9RndDW/jBV60DkmpCw9tKiEML96z5I84mtDlf9?= =?us-ascii?Q?QmHLxpM1xDND26dtkCjTfMkv1dr2aUGrE2f2hRgolRpyo1uq2BYY/a78kjEB?= =?us-ascii?Q?2dM5OK0+OEVxFn6PFkq6lPU778CghoSvBG+cSgxtmO/EEiN/D7+At+/yKTRE?= =?us-ascii?Q?oL/QLMhYX/3A2NaznpX/csFBKTFAdmWoAxwoRswLfwV/ZLp1IQA8P42dHU+c?= =?us-ascii?Q?8+e7/e5Sr1kRiq7zxhWy+hcMByHK5FJPGKEO/zxyaUNCftvR/MTYaqNWAwf7?= =?us-ascii?Q?adAU/56CJj4Qq/Igb6OiT7w/m6dPPhbl6ediQbC+cc0LeeOSJ4V16jkmD2/w?= =?us-ascii?Q?23ldmIBFJ4SCiXKJfn2+3qIBVvn2Avc7cRNvVlwwt+9/JlvidnxtzY7SZUH6?= =?us-ascii?Q?h5Srh35HodVzoy/LXx3j6Dld7uU45kfSk0RWs35u2WvWYK0roMyUulne6Iuo?= =?us-ascii?Q?l79xV2HIZTZEmmFnBgEXwwMdMZyyOaf3GPnFfJA2/gYXIDQC8Qhj+5nrqlps?= =?us-ascii?Q?mCtdt0rAT0L/Lt7+uLcTm7vCoa3UWmAlPVYay4VNtdXT2RFTiSUklhlKWkA+?= =?us-ascii?Q?CcSd14oZ4yssJs3TdR+H4Ke32ujjH+Kx8l16STBkPnIF5mtZxLhyPs80s64t?= =?us-ascii?Q?qyWYrcJVA6d9ZUBfEGVEefShcDJ1QZS9AU1q5CtGJTrH48tTnXDfX2pt/Klg?= =?us-ascii?Q?+pPLXbYDfA9q95lGckYjIpz7n5YavlnFjH5+FErDGcCH8ppg/uiIeq//ZEMn?= =?us-ascii?Q?gNOXUqTfQhfvV+cfjIJ9xWx03Meyh23dyt/mSZgOMIQDru7VbVRDWeBvjqg4?= =?us-ascii?Q?a/xkcAgbvoTLGm1iNhRGU1YGBkhQaQ2c8piWWWRTHvfmlx/evcbl5njnzkeR?= =?us-ascii?Q?jdv4zDufR5YHJJ7s7YVVV8zlf1qIR24hwMfYRFKSTg5gFWxF9ILgIq/UiDB2?= =?us-ascii?Q?QTZQor9gGNq6QiIZUIKQgO1Mk9AowWlrhHZdoQd26bVCue8ih3vv57dY8DsH?= =?us-ascii?Q?4VYUGcRAP1wUFxd9X9bKUigY5Uhq9ewxtzFa9Be/QYt7e4zhh2EpxUHqvQLC?= =?us-ascii?Q?6ua7zVKsJoG70FksLVo9mvzdpmuovOqicM5yVQFIxhJLYOjKZlQFHWJrWp4L?= =?us-ascii?Q?/7PGeNTXCzsDX4WmRfKdR5++uy5b/W5qlCx1nsRO3T5wqxhVYctBKjWIAu0+?= =?us-ascii?Q?FW1tI0v5Zkz9Sb/Mw9Q=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(376014)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2025 07:38:24.0802 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e4ca2b92-7aaa-443d-4a1c-08ddff2b2bec X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE6.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB9650 Content-Type: text/plain; charset="utf-8" The controller is registered using the device-managed function 'devm_mbox_controller_register()'. As documented in mailbox.c, this ensures the devres framework automatically calls mbox_controller_unregister() when device_unregister() is invoked, making the explicit call unnecessary. Remove redundant mbox_controller_unregister() call as device_unregister() handles controller cleanup. Fixes: 4981b82ba2ff ("mailbox: ZynqMP IPI mailbox controller") Signed-off-by: Harini T Reviewed-by: Peng Fan --- drivers/mailbox/zynqmp-ipi-mailbox.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-= ipi-mailbox.c index 0c143beaafda..263a3413a8c7 100644 --- a/drivers/mailbox/zynqmp-ipi-mailbox.c +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c @@ -894,7 +894,6 @@ static void zynqmp_ipi_free_mboxes(struct zynqmp_ipi_pd= ata *pdata) for (; i >=3D 0; i--) { ipi_mbox =3D &pdata->ipi_mboxes[i]; if (ipi_mbox->dev.parent) { - mbox_controller_unregister(&ipi_mbox->mbox); if (device_is_registered(&ipi_mbox->dev)) device_unregister(&ipi_mbox->dev); } --=20 2.43.0 From nobody Wed Oct 1 22:37:04 2025 Received: from MW6PR02CU001.outbound.protection.outlook.com (mail-westus2azon11012039.outbound.protection.outlook.com [52.101.48.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A30F82BEFF2 for ; Mon, 29 Sep 2025 07:38:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.48.39 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759131511; cv=fail; b=H2y9MjrkI7VMOjNwGGLh8pno5S35PrWoX3Fq4jNQHxiwVtD+1wU06RtrPtf+q8i5s1XMgDJlBOi4olzehKz+j7ssPFoVA/TVsRJgcqd4ecUJRZB7wigR+aJhJRQpQzZoU5Ay3092iZqzM1SLnFe2dlHSoRfgqGRfvYfQD4FixSc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759131511; c=relaxed/simple; bh=+TK8fi4FMmql5A5ThC5T9wJxxAIe+fGMXEf+V6U+N+s=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WjZv5h70df3P1eoPAw+qtlxWYHHAiFJpChUSN2Bn8T2Zw8VBVpietjDff0cjduNkixqDHcsdxq8rC+oBNLvd1NZHZzsMxzryHQkKjQUd50OUKVr5PVYGaYiRcRgnmTmi6Np/HL1ccuqQa0mRshRNTM+jUoUqPQu1QN13KC1/5uc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=Fxcr+NqW; arc=fail smtp.client-ip=52.101.48.39 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="Fxcr+NqW" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DLhdf+ypBqUkivfnOORGf7kSBRqX2vS/EumFsYdW/z7fmYuLuAII9avcgraaRXzKdPzyKnF/TEtbspwyVyv+1WN5TIDHhIjuy0H/j/+J3OjV9KuKblkcG5ZGBYVpZIPyKiOQDrUlXyF9C5WFUwliq3PQqDxiErUsdW/z68qoiZsrHjCpewBjzkOm7ILOqOThzsMHvI/g+eLCXgPk1x0RndJ+fnk82rwPMpVROGJSegRdEvFX9TdhkHvFF62ZKMvHD4MpYsw2FK5uUOFk3ikqU2rVzwcDgK8IpbWNTzm0FsqobdySydiW6ZcLBLBbYNBCyeqjeiKIJRec481jSENJvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rwcI28FOY4kN3OQcGrrreoo3w9LFqikCXLdja2G61WM=; b=QE51vCxFMo2R9uEn4ktdWA8IRngWFaQ5/c/hLqHNhBFVkEw29VFNEzXNGdFKpzvkElXIc7cYrOU4rdSDGJvAyBoliKXtwfeMHZT0mmQopDj4W59ilqpWWJy2DcUC4PCRI88Rs3bVCClmGDNx+FKSfClqAv/ykZic4F9QJqHuYHE0dGZzh2Ug7G2y0F+ZZCaKlvaKVLZNOyG4dUF50wJ9lrEfjEkMGiLipiJ3UOUUVbmC36IYWDU+ddGecj7UbpP53jN0NWWnF+oDzUeXW49/CU794w6RTrjgiH2Fq9Q9rugEA3UJx1JbSHAGbaz/OPJH5EGENeL91oSsoE04438IjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rwcI28FOY4kN3OQcGrrreoo3w9LFqikCXLdja2G61WM=; b=Fxcr+NqWNWa5znACdzC/u/NJ9tAzL0+HvIUZbCtf4bXlytsXpezodJES2DTmfCNJL80ekZPZYPU4LJPE9cF1b01v88654eJP5UKmzivpWsY89BsC6G0hgKlMsyXEBaxAnMhGzO7koyfgqT39Y02utk7gXPYcC9cRicd/WOGXZHA= Received: from BY3PR10CA0008.namprd10.prod.outlook.com (2603:10b6:a03:255::13) by CY5PR12MB6106.namprd12.prod.outlook.com (2603:10b6:930:29::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.15; Mon, 29 Sep 2025 07:38:25 +0000 Received: from SJ1PEPF00001CE6.namprd03.prod.outlook.com (2603:10b6:a03:255:cafe::27) by BY3PR10CA0008.outlook.office365.com (2603:10b6:a03:255::13) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9160.17 via Frontend Transport; Mon, 29 Sep 2025 07:38:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by SJ1PEPF00001CE6.mail.protection.outlook.com (10.167.242.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.9 via Frontend Transport; Mon, 29 Sep 2025 07:38:25 +0000 Received: from Satlexmb09.amd.com (10.181.42.218) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 29 Sep 2025 00:38:01 -0700 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb09.amd.com (10.181.42.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 29 Sep 2025 00:38:00 -0700 Received: from xhdharinit40.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Mon, 29 Sep 2025 00:37:58 -0700 From: Harini T To: , , CC: , , , Harini T Subject: [PATCH V2 2/4] mailbox: zynqmp-ipi: Remove dev.parent check in zynqmp_ipi_free_mboxes Date: Mon, 29 Sep 2025 13:07:21 +0530 Message-ID: <20250929073723.139130-3-harini.t@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250929073723.139130-1-harini.t@amd.com> References: <20250929073723.139130-1-harini.t@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE6:EE_|CY5PR12MB6106:EE_ X-MS-Office365-Filtering-Correlation-Id: 18ae417f-ecf4-437a-86fd-08ddff2b2ce4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|376014|1800799024|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?8PuEjr9wtL3hLwjAlQTMNZdvV+qEeyOt3iEmeTdwion++JNdc/PmSzXpSg4U?= =?us-ascii?Q?aa5yHTzTYjlqqLONgGr+L2nwxiXd6kAFOYNF+valIFHZyd4UiYWaBKNIL+F5?= =?us-ascii?Q?EbJNi1iyuaVSeDYhIHDruFmPl4j83A4uK7lY4Iroxq8oT36BTfUUtzrGx7Un?= =?us-ascii?Q?kJ7m0SOp6CHV7toRueoO8NmVZc47Tt6at4JASI0a2olZqRjSHiYvu8k/mKWv?= =?us-ascii?Q?lXkoZs4jPeIy3+6L2moKRrMe0GuQB2pgB829FdEPjO2Tu5bPMhT7csk9Sa7Y?= =?us-ascii?Q?hktwqBmerVLdOv8tKCXE6XgQTF/lwWGPX8d1hxr2Bt4Qwi0ALsC3gEqkqDmE?= =?us-ascii?Q?Tc9LxNe3r8JMPQfi3JHZp6j4qeIfsm9Z6qPWNEcwUV0AdtKLlJCXUHE5eGIs?= =?us-ascii?Q?t/CpQnqlbDIReQqUVhPXKDM17xlpH546LzhPpb3QpuLLU5Svnzj5gvc9jtyA?= =?us-ascii?Q?LS7+wrNXvG21UbLJXykR9oGto1CWNkWh0Vd45X4LwGGh8IzPE8VZZtPkyBBG?= =?us-ascii?Q?K7nBmvnmPJg/WzwNPuWuvZCzwfNyM3k4qHsEePGsO202/LBuBKp8wSlQB6a8?= =?us-ascii?Q?RcgXsk0KpNu8OsfVEN5pls/dzwkxJyk/2ZEh72ytZHmEhXT05iCy/uMJtj6I?= =?us-ascii?Q?DB4Vp8I+us1IBX0FDZd/UVLrg/uhpM9+Pooa0kwFCaETRzwAJPP4UhVm2rPq?= =?us-ascii?Q?sE4g3UJIBz1jqXI7HNGDcBCDMzMqM4HaxmU0VdOjSMjxkK092dbrj8WysOjz?= =?us-ascii?Q?QRfskMS8WBMcSYI5PB6F3+UMryXI5y5zWph5qqEq57LD2/DnMmf37X/sKqxH?= =?us-ascii?Q?5fQkhHoCoHrdn1AaY8qF5NgaUsc1cv+IQYGV+Vrdx9+PCW3ONSCp2aefY8Ac?= =?us-ascii?Q?hQjWTqdiKer39vjft0/M1nZYtglMyAbrJQVQPCBmSRyoKZTrLiv8bAcgneSM?= =?us-ascii?Q?Xph3iRBbCC2NJa+c0w7WGa8YSZCmJG0A0cFvFiRrR729gJmv08JqWO8ayOKD?= =?us-ascii?Q?Gsrzk2MlppMKQVNznMIues/JVCFXMLqlaEzA+l5vIE/iMofDK170zyem2JOe?= =?us-ascii?Q?91U7B353B8/pZbKgivexDiaKT7q6TSiD/wqO/Ni8y3Z0vJWocbPAklHkC5+b?= =?us-ascii?Q?jASeOzNKF8eti6R0nCYTkBmlm1swWVuhuF1d6sEU5ZfU9zZl2pePaWL/fA0I?= =?us-ascii?Q?/9l8A66EMBwx4cm/vjLA9zOkmTpLyBymVml8F3dWn4LCkWadFPwfddzhwCwC?= =?us-ascii?Q?Fq8aHSiTJx7QhITXnrVEs0PXkvOlycLjn9seR2Ix1xTGfOSHjtSObhz77460?= =?us-ascii?Q?kEZwH1e4s2+A/EzX8h1KdxdTMy7nnHMRDTJZ5gc+4+VHRBclfQZVlZCTxk99?= =?us-ascii?Q?sRxVqLD+G9W4ZSRuFeA2UPPexYvL4f34MNBu/dUa4C2JVlmPXlM0leg5qaLj?= =?us-ascii?Q?GnGga4sa9so5mjGLXpD5wrbLvrBjTdYYNfCunuaoGTlpHIq4Tc56L7G7s7AQ?= =?us-ascii?Q?6iquYi0TbN8EALUFS3RUvKW7dZcnSdzKGmk8/x0mXInaZLFO51NPJW8oiBDz?= =?us-ascii?Q?zDpjQ5cjuAtjjJq49gQ=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(376014)(1800799024)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2025 07:38:25.7053 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 18ae417f-ecf4-437a-86fd-08ddff2b2ce4 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE6.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6106 Content-Type: text/plain; charset="utf-8" The ipi_mbox->dev.parent check is unreliable proxy for registration status as it fails to protect against probe failures that occur after the parent is assigned but before device_register() completes. device_is_registered() is the canonical and robust method to verify the registration status. Remove ipi_mbox->dev.parent check in zynqmp_ipi_free_mboxes(). Fixes: 4981b82ba2ff ("mailbox: ZynqMP IPI mailbox controller") Signed-off-by: Harini T Reviewed-by: Peng Fan --- drivers/mailbox/zynqmp-ipi-mailbox.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-= ipi-mailbox.c index 263a3413a8c7..bdcc6937ee30 100644 --- a/drivers/mailbox/zynqmp-ipi-mailbox.c +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c @@ -893,10 +893,8 @@ static void zynqmp_ipi_free_mboxes(struct zynqmp_ipi_p= data *pdata) i =3D pdata->num_mboxes; for (; i >=3D 0; i--) { ipi_mbox =3D &pdata->ipi_mboxes[i]; - if (ipi_mbox->dev.parent) { - if (device_is_registered(&ipi_mbox->dev)) - device_unregister(&ipi_mbox->dev); - } + if (device_is_registered(&ipi_mbox->dev)) + device_unregister(&ipi_mbox->dev); } } =20 --=20 2.43.0 From nobody Wed Oct 1 22:37:04 2025 Received: from CY3PR05CU001.outbound.protection.outlook.com (mail-westcentralusazon11013002.outbound.protection.outlook.com [40.93.201.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A28F32C032E for ; Mon, 29 Sep 2025 07:38:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.201.2 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759131512; cv=fail; b=t8/Kge0nujfMzwmI0unIZsPb9Gk4nb8T+dQi5iSij86Vttd9qHWN7+L99vKhkxHXpGg/tJqs6U2klEVY4usKsxzziX1qSJXuelphQ482gbvVtoKKqKR+5+fPSsnfoXpc8wnSS4pd1L6ST2j+0JplqEEA0Q6Vduultf7GbG6bMwk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759131512; c=relaxed/simple; bh=BkdXyUXHj0vowZHacM5PXPkQSvlFO/Z+il459s9nTLc=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=tQLqmuUnfI4Rg6LCouwXf5UD62og9kr3wdSThEVMMrTI+QBfeofhzWq7RqCCNChXKg7kA7BSexLClisyPbuYH/9TiuakH0IaM1C70O27fqBYfFQoxfz2hiV0++5RD/FPZISxDbTyarPwM5/g7FVG+y41tW/jnWxJM6xLoh2Vfcw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=HUhzp34H; arc=fail smtp.client-ip=40.93.201.2 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="HUhzp34H" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xkF32uMccHDBnX8H56EJBhZJx7sHPp/OlLapXMO7fadPY0Z9ugwX1weFcpc+2I0250K3PuonygpYElKKwAYlX2sRw42SS6SZLKw6RtbIwkehRri583GwjwiRYlGsIp3JN4XmiYHBE3dAIHISCscb8ehzM+ydhUUmICChf9yLyvmSKcIF/gJtoIGSyPFQ9EPas+2EeXpDMYYEOV1STKFpKuD06e8IovcOJWv31JUIQSL4Z548LO1kUoo5SA+C/YI2HqEaL67qfLcOVMZrqwDOBCqhpFiye/2VIEB7JwisiA85uZ1e8PydISimgJyjeygkHFzQtbZswRDRIeCU53EQKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r8ajutcYdU3A3s4Lu8yEBHQTJL4VsFBpu5rcHyjIxQs=; b=d3FLq6F4n0NxlhhKUlgInxlHKlcpfUad7VW4WDrFCDvmWSjk16yqiqu0u501Gzo8Y3XxC30p3jHcTqOvh2BoOAKLcOJxpvHanOnw7AwMXbxSnsad/NrJbori2spr6/o+0VqYb3IBQ4QMlNI+870OegIBfIKZHJE43MCd41kZwG2eCcHyFe53CbuJViJNS9ZxVMAEIoVlJzuXI+9v/ik4SRSH0Nq2PtaU1uCC6xF6+oC6gZQ/5SAzvHr74LGsAfGP8YxxmcBuHPEL6sEA0eqWoUImdNKCwShqNibaash2T4QSGLtFM1lMBbH+flmjPu+HbV5bKL6usfHCtgwTZnxFzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r8ajutcYdU3A3s4Lu8yEBHQTJL4VsFBpu5rcHyjIxQs=; b=HUhzp34H3wzbcVuPY1oAFgx2DGWq4eeYJkLGjWwQIJaC9W703FOkHu64gdVUOIFNgXWZyDx/A118T198nAWMKz5bwcODrKGxVmTM4QFXo8PF2iae4vfOKHpO23AHqlJip9cP6wKr0VkWJYuVKSubuCDe56hjzda3+fECOTdJCeE= Received: from BY3PR10CA0027.namprd10.prod.outlook.com (2603:10b6:a03:255::32) by CH8PR12MB9816.namprd12.prod.outlook.com (2603:10b6:610:262::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.15; Mon, 29 Sep 2025 07:38:27 +0000 Received: from SJ1PEPF00001CE6.namprd03.prod.outlook.com (2603:10b6:a03:255:cafe::34) by BY3PR10CA0027.outlook.office365.com (2603:10b6:a03:255::32) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9160.16 via Frontend Transport; Mon, 29 Sep 2025 07:38:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by SJ1PEPF00001CE6.mail.protection.outlook.com (10.167.242.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.9 via Frontend Transport; Mon, 29 Sep 2025 07:38:27 +0000 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 29 Sep 2025 00:38:03 -0700 Received: from xhdharinit40.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Mon, 29 Sep 2025 00:38:01 -0700 From: Harini T To: , , CC: , , , Harini T Subject: [PATCH V2 3/4] mailbox: zynqmp-ipi: Fix out-of-bounds access in mailbox cleanup loop Date: Mon, 29 Sep 2025 13:07:22 +0530 Message-ID: <20250929073723.139130-4-harini.t@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250929073723.139130-1-harini.t@amd.com> References: <20250929073723.139130-1-harini.t@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE6:EE_|CH8PR12MB9816:EE_ X-MS-Office365-Filtering-Correlation-Id: cda656a3-0472-4b1f-9168-08ddff2b2dd9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|376014|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?iBCNMo1Uz6uH+KMQOo/kmDOH3RRWhGJpWX9GKQM46L2NSDx0TulbXYpksQbh?= =?us-ascii?Q?Yyj65ftTwyz5D2CS5Q2zDv6JaA/cmM56crFy6lfwbSg9uLCEweo32O4aY3jr?= =?us-ascii?Q?aKQkqrHj3ghiLN/vBvEzIi7XKNqBE3af/j3c5yvVWxCEb6Sm1Y+2aL/+4l+z?= =?us-ascii?Q?tGqpa0+lgu5LZkWFSoXqKKObiDXvj0RVp9Yfuu/rX++qRnWlVN20JrOLaZg3?= =?us-ascii?Q?LJnuxbEQSa9rZUkxUUeW7xnOnLj9tdl2xnSuHtqflHouQfN+LOTJdsHPGWD+?= =?us-ascii?Q?p2vUctBDKFIGa32AQvg2kbWf4E010ZtQTGS6RQvTWzF9Rwd0AD1F1C0VDKAU?= =?us-ascii?Q?pnFV9DBvT6GYZfb16U/HKTCAntW1/OOLrr35QfdA96LSHU8ylJDhfsU38j1X?= =?us-ascii?Q?HZPSQrnSw0Zc71v2zAPjaprDj+gYsyZ+CO4NSZwcHO5arfsHVsAsO+oMFaeV?= =?us-ascii?Q?OzmItfnHtlrKY7Ml2fU0UPlcbHWkgaVTkEWTfu9EwxxVabCZ/a87apE42E9a?= =?us-ascii?Q?1Vg5mUf3yjPYTjmRVQ33lA8tm6EFpfRunqoAvCQpv0uodYFFDL7NVJUimKyy?= =?us-ascii?Q?gk2AbLa+yZdOlIzqI9CnA/F3y2+Uu973xHaiaVzy92Z/M2NNCmWJTte9p8pp?= =?us-ascii?Q?4g9ZQ6SugSf9O0rBH1s+blDm4VhL1ehck3r7zW8aIJ9NoRd83NgQm4pTY6/Z?= =?us-ascii?Q?5NoO9Yy+vHUQnWzw+B2GXWZPAIc3XOY67w3hLiQGdFb8i8bxrFcirLifS42Z?= =?us-ascii?Q?+Uj56kd1X6mNmOq0CJG379ymxKKJ3JxQIhTSAzIVrhvRAMWAh/FjWRIL6ffa?= =?us-ascii?Q?kcHl/AOutG4fDtfEJZUf6Wjkv++03UDXMYzrra7axyMICkxn0gNIkNITTIZ/?= =?us-ascii?Q?q0ZFLgXqzxE65PMqk9JWVtFBF65n+s5ivZOBThxFTTvOcsyEHX+twbSha9Xi?= =?us-ascii?Q?kL+RAnxKFuWQ/Xs3PIQ91VAo3+50vN5gEpaS1CPnqXL5RoZX/t/l/zMdKG/i?= =?us-ascii?Q?EpkbUE2/b0WhTBCjiCgwbu/DCxZteo0SrFNazhWN209M7kOzIAnfg3rjN/lL?= =?us-ascii?Q?/4DaAikIPhQMonci6aFhuSTi7EKh149mTfM69Ls7pI6e0de49ghQFvDPi6SS?= =?us-ascii?Q?eB/KnXctSeV9lB6YiPi1Q8CJR2f1jtm0KE0viUHjMGsOM13wL7HyFVyiHCaw?= =?us-ascii?Q?AQpTb0OPGBK6asxqcoAMRaqpZ6+BSFnCJrRLxxj8cs49E9hCnW2BJcxys9R+?= =?us-ascii?Q?+JA+i/Qsqpce/uVCJl+//b67NH0BuCN14qljffpCSB18aHprVx7dymzv7w1f?= =?us-ascii?Q?M2my7Zddy/REDXKu/9n3whnDDo4gdqzjTOFlgkhPYTLQW3KLxJKi5SnEn//V?= =?us-ascii?Q?GYnpA+jjK9fxVjbUqzWWfIFimCSv0fL1faykzWBCA7XqsgrRTuETElA2EjE3?= =?us-ascii?Q?d8mSG8MWLi0pSDR7HZIe6JlwlqjsnasPOlkEIxAnQmsVYNSPX/y5cnCWXPy9?= =?us-ascii?Q?e8XVyjXfxDy0FfhRZEcCrGXFWRGTqT9tyB9CuHDT4+9/rjp2uQIgdsDT+ud0?= =?us-ascii?Q?Fedp9FeVbkO4ygDLMUI=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(376014)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2025 07:38:27.3136 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cda656a3-0472-4b1f-9168-08ddff2b2dd9 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE6.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH8PR12MB9816 Content-Type: text/plain; charset="utf-8" The cleanup loop was starting at the wrong array index, causing out-of-bounds access. Start the loop at the correct index for zero-indexed arrays to prevent accessing memory beyond the allocated array bounds. Fixes: 4981b82ba2ff ("mailbox: ZynqMP IPI mailbox controller") Signed-off-by: Harini T Reviewed-by: Peng Fan --- drivers/mailbox/zynqmp-ipi-mailbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-= ipi-mailbox.c index bdcc6937ee30..dddbef6b2cb8 100644 --- a/drivers/mailbox/zynqmp-ipi-mailbox.c +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c @@ -890,7 +890,7 @@ static void zynqmp_ipi_free_mboxes(struct zynqmp_ipi_pd= ata *pdata) if (pdata->irq < MAX_SGI) xlnx_mbox_cleanup_sgi(pdata); =20 - i =3D pdata->num_mboxes; + i =3D pdata->num_mboxes - 1; for (; i >=3D 0; i--) { ipi_mbox =3D &pdata->ipi_mboxes[i]; if (device_is_registered(&ipi_mbox->dev)) --=20 2.43.0 From nobody Wed Oct 1 22:37:04 2025 Received: from CO1PR03CU002.outbound.protection.outlook.com (mail-westus2azon11010001.outbound.protection.outlook.com [52.101.46.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 538982110E for ; Mon, 29 Sep 2025 07:38:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.46.1 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759131507; cv=fail; b=EF2B9jReh3b23oXV1F+Eduw/APUGjV+QyPkpxxOWJJywN66j1w4qpFVfcRqnx6PpyY1cxA1MDcVRPpNV1tMn53Um9550ZrXy6Yo+vBTUIjwYp4iGace0P5oKBB5kRGeyrY1krDVUZEaJ0OYSN8RARGEP7gnafK6L9hbueL00A60= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759131507; c=relaxed/simple; bh=9InhNtjHzPmcq5okkk9cVztk0AdyJI+GpjfOxGE7Dsw=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=NLA4Q6YZYDWq5jy36ycj381phtb1xg5vUap+wHKAK+m4bHtvhSyE8v2dckwiKeHBiVPNbFSkP5jAYmURIH9NdAr+tgU8ZnApVvmhVW4GiF0+xb/ki/TbrjgwKCoAOf86/pYe+a8C7n7fjpsVfMVgX5zUnxnkVEYcH+rg61i7vz4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=1iO/Av5u; arc=fail smtp.client-ip=52.101.46.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="1iO/Av5u" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=abTejoXL2iC2+gsY6mfdORfn+a6Sz0YfZVkZ052l+fD2x0WITiT2QTkhY4XGJXcyOjOIScVimB+vDh5u/0P9sOzXl5CxUvmhPihnF4vHwHKoS7cFGFSyl6K9jtuzAKymT+s5qO3OS3N1O9DxCyXIUNARnS9A1+EaLVjCHSmKD/WvvXrtFS51LckqbSEhMFgAqh3ikhflxlcEWkAx79bo8JBMBT2PFV0mBDGLJSSnVIHRxkdhDUoRaTraDhkOKm8g9GgN5Z43cUV1Q8dlS6YlqdcJCI5zmoP8wj+QBWFBorckwr6Nl/3TdDshPGMEn3Dcn+Pw/td7qUXa2Tb1cAcI4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CkFA7lZHHJ2lADLG9juKzzsOf7dBEPZqf85miPqn4EY=; b=KeLTs2/6pCKGTxg2mDcznwiXEYz1jDLblhyRakMdDydJq3PpLFkJFA4trc3VbXhOXT+hss/cEwqSKGFzDuaCzTg8vOXyxBBq04G+lLwzPy39yT+gzu1wZHTl/hmfYxkGHAllfjQ8msySBgDsZvh+bjUEIFnta6kPHRzhsGCB1VOImj0bLX3MLgHvebSgstb3s72wVHzuQK3Ch1MQIGaj7+MIMla63UHirdA/hIdE1XfNQQqSTbZIBXc+q1kg/nGL56eQZPlSpQxNKSmnuPJaF55lIn8o2CNEe/3DCy49TlaI3KG0BjvQcfb44AAD7rchaTLuRTaNJGxaiefVluJEaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CkFA7lZHHJ2lADLG9juKzzsOf7dBEPZqf85miPqn4EY=; b=1iO/Av5uTmSX3c/1UoOofCHTThORSv+0+P9ieW72MliEi/7XSlYZzga+lDlRNTXC9vX146cevEOUR89AN6z2oj1AIm4RheVZezEWQGCdkIP2bt1r4dfTHfEZLbCF16H/L0mOvlkNiadH8BoI+fRxgE0JmCqGxLVH86vQbQDT9mk= Received: from SA1P222CA0035.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:2d0::10) by IA0PR12MB8838.namprd12.prod.outlook.com (2603:10b6:208:483::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.15; Mon, 29 Sep 2025 07:38:22 +0000 Received: from SA2PEPF00003F63.namprd04.prod.outlook.com (2603:10b6:806:2d0:cafe::23) by SA1P222CA0035.outlook.office365.com (2603:10b6:806:2d0::10) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9160.17 via Frontend Transport; Mon, 29 Sep 2025 07:38:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by SA2PEPF00003F63.mail.protection.outlook.com (10.167.248.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.9 via Frontend Transport; Mon, 29 Sep 2025 07:38:21 +0000 Received: from Satlexmb09.amd.com (10.181.42.218) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 29 Sep 2025 00:38:06 -0700 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb09.amd.com (10.181.42.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 29 Sep 2025 00:38:05 -0700 Received: from xhdharinit40.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Mon, 29 Sep 2025 00:38:03 -0700 From: Harini T To: , , CC: , , , Harini T Subject: [PATCH V2 4/4] mailbox: zynqmp-ipi: Fix SGI cleanup on unbind Date: Mon, 29 Sep 2025 13:07:23 +0530 Message-ID: <20250929073723.139130-5-harini.t@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250929073723.139130-1-harini.t@amd.com> References: <20250929073723.139130-1-harini.t@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00003F63:EE_|IA0PR12MB8838:EE_ X-MS-Office365-Filtering-Correlation-Id: 35af5335-d517-4305-2217-08ddff2b2a77 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?AWdWXj/w6OAhwhVGG4kRIzzkgcrA/bQlaKn0fntRLLfJN0PkAqcPQSEsN+ed?= =?us-ascii?Q?7MMv6EClrIab27DMQneUC4uwLWX5mH+sfEygsdvtvTTcOoQWasH2YY6DyVMJ?= =?us-ascii?Q?BekE9AyKwU7zBOkjomRCCKi9yrsrCjWtZtbXC5bkFk4wk62/WIAkb4hQ75XW?= =?us-ascii?Q?hcfuF3yAiS09+TVbGIL/1IgqIidyevw33aJcaI9XkaIBPG1rm8WxaDnBHNcf?= =?us-ascii?Q?MyPugwUhzPaco5iH+zOmZkvf/ZDdGQ+9hjMndl6uwNUm+uBYphBOL3egiTDY?= =?us-ascii?Q?9yD9KfpbFhzasJdxHBp8AD7FyDr+wljK2eWP1llLkmzFoAFiGPEXraOyzUN/?= =?us-ascii?Q?u2/89RQpKeBAtRnkN4W+tcJNaI36AHY1KUmi74MNQ0KifAUYi75OkTQq6nhp?= =?us-ascii?Q?beNrgtmirmGbdV9fBJN02Qyegn/lB2lpUTHORUCNUVZzxofJj5CXesZgHsf1?= =?us-ascii?Q?8LCGKKFcDJQ+kDzKV6T+OEpJl1ZqvbXDAFMsvPCV9C+StF1tLeUQoC2EA1LH?= =?us-ascii?Q?M7y4FvkT05dmD4l17GVMxTXmQBbBgPBs8ua4BMhK3rofgV1klLGzMSEAPRm4?= =?us-ascii?Q?icMDTJa4IotJAAIdQa/wGsXVNFeyENemMVveBQgUmRycDNrcqPdNTr7VqSDY?= =?us-ascii?Q?imaeQvgyxqMCjURz6L8gwXa2aeuoUbjKiqSiTrA6WRNIDFKuiukWlhBqhVz2?= =?us-ascii?Q?htco8t5W5JTuiJMfMhsgJIfOl45D+jH5pLFSlaUXIPl+uJnp1hYklHqrGk2D?= =?us-ascii?Q?SlniO3Ulhnq/fTdJTERYdcRb+40LoLHmBGJ/S9Xl5l8VGoUov4Kih8jJrTQb?= =?us-ascii?Q?ZfoeyoDgWCntyC2gP/X5Uk5GDnmDz81zOUIJ2GJLmjmZE2LeqBWeDRmefAM5?= =?us-ascii?Q?uXCtP2kND1iEMXMh5NLDFA16jV2owLbR0WQF7mM/Jv/kl1jXkUqGSnPT95Ia?= =?us-ascii?Q?yZHgDgkzcvwFhBCHeD3dYCY9SBG1AzfJ5Xy2Fl2ZJVPnvyWNZFfHmQ//2jt/?= =?us-ascii?Q?fsy5t9pJYAaNqj4KSz7UC7mlfDLQ762/bH6JgmRHv3S7CeRIrTT79vL8wgXQ?= =?us-ascii?Q?eREZO21gnc+g264s8cpe5TtPGqnVW3v7XePYWlZLSLzx6fmIPgtq4ZIqxbrx?= =?us-ascii?Q?5+VATcVGyVbMoFe5mcx/7jvf0rHsV36QAXkDyLwZLE1slqOUxkBp+wAka0nL?= =?us-ascii?Q?kA0Og/miDyTZG6dqjK+4E9U/yeMm+pHOFOiKPZKvUj5XBquBcqyp49uml3d8?= =?us-ascii?Q?m/O/kirZP4qbIeKOlP+6uJYAg64mFTA5qhepGMUcqAhPYbnI9txsaOa5ZfzR?= =?us-ascii?Q?xrrQousaVp9I1Bp/GykcBnDFDceGZhIcMZaptqZC8E3etc3VU8mQnQuLHMc4?= =?us-ascii?Q?7cQN2X47CLVhKK65qXyWkBsRjmY54nXH8kLHSmLGYw1WDylJaDWd5eltasRU?= =?us-ascii?Q?OZFcb7EAD8uH5yVscu4gTCxYzRbC+CWVZ4QJYXLG293SnwU+6/jy3GQIaqfi?= =?us-ascii?Q?zhD04B48l94C+Rg1waqXE8nFiXZkZMKLWOVn2uZjdzJr2XKcoiO9sAUHnWE0?= =?us-ascii?Q?FDziPNk6qowYX9Xo8rg=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(1800799024)(36860700013)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2025 07:38:21.6827 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 35af5335-d517-4305-2217-08ddff2b2a77 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00003F63.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8838 Content-Type: text/plain; charset="utf-8" The driver incorrectly determines SGI vs SPI interrupts by checking IRQ number < 16, which fails with dynamic IRQ allocation. During unbind, this causes improper SGI cleanup leading to kernel crash. Add explicit irq_type field to pdata for reliable identification of SGI interrupts (type-2) and only clean up SGI resources when appropriate. Fixes: 6ffb1635341b ("mailbox: zynqmp: handle SGI for shared IPI") Signed-off-by: Harini T Reviewed-by: Peng Fan --- drivers/mailbox/zynqmp-ipi-mailbox.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-= ipi-mailbox.c index dddbef6b2cb8..967967b2b8a9 100644 --- a/drivers/mailbox/zynqmp-ipi-mailbox.c +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c @@ -62,7 +62,8 @@ #define DST_BIT_POS 9U #define SRC_BITMASK GENMASK(11, 8) =20 -#define MAX_SGI 16 +/* Macro to represent SGI type for IPI IRQs */ +#define IPI_IRQ_TYPE_SGI 2 =20 /* * Module parameters @@ -121,6 +122,7 @@ struct zynqmp_ipi_mbox { * @dev: device pointer corresponding to the Xilinx ZynqMP * IPI agent * @irq: IPI agent interrupt ID + * @irq_type: IPI SGI or SPI IRQ type * @method: IPI SMC or HVC is going to be used * @local_id: local IPI agent ID * @virq_sgi: IRQ number mapped to SGI @@ -130,6 +132,7 @@ struct zynqmp_ipi_mbox { struct zynqmp_ipi_pdata { struct device *dev; int irq; + unsigned int irq_type; unsigned int method; u32 local_id; int virq_sgi; @@ -887,7 +890,7 @@ static void zynqmp_ipi_free_mboxes(struct zynqmp_ipi_pd= ata *pdata) struct zynqmp_ipi_mbox *ipi_mbox; int i; =20 - if (pdata->irq < MAX_SGI) + if (pdata->irq_type =3D=3D IPI_IRQ_TYPE_SGI) xlnx_mbox_cleanup_sgi(pdata); =20 i =3D pdata->num_mboxes - 1; @@ -956,14 +959,16 @@ static int zynqmp_ipi_probe(struct platform_device *p= dev) dev_err(dev, "failed to parse interrupts\n"); goto free_mbox_dev; } - ret =3D out_irq.args[1]; + + /* Use interrupt type to distinguish SGI and SPI interrupts */ + pdata->irq_type =3D out_irq.args[0]; =20 /* * If Interrupt number is in SGI range, then request SGI else request * IPI system IRQ. */ - if (ret < MAX_SGI) { - pdata->irq =3D ret; + if (pdata->irq_type =3D=3D IPI_IRQ_TYPE_SGI) { + pdata->irq =3D out_irq.args[1]; ret =3D xlnx_mbox_init_sgi(pdev, pdata->irq, pdata); if (ret) goto free_mbox_dev; --=20 2.43.0