From nobody Wed Oct 1 21:27:12 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B026F2AD25 for ; Sat, 27 Sep 2025 11:33:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758972799; cv=none; b=LE26beByTcyWByn0kQ8N86wo8Q9doPskXULuANXmaHsA9CV9pRWm5FIMT8Lna6k4nd1nyTTLYRLEbcyEdgKDkY/PQLqwE91PvqyS5Lft5RGqJoLh3eAsVKZ5+EIjDTXz2kU2aGi8fIiq8MSsPIRmAfTwH7IqFEJkhxTZCNuyjTk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758972799; c=relaxed/simple; bh=EV6l4ssTVreRKgaeCwma3vj7I/H1BvBiXhlYjPP8VrU=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=iEqIdoFxR+RXpTfiZdI7aKg8ZGRDOybK2h1gq0/fh2AkH5SRsQ6oQXWYREVNV8W+tjv2Jqmmjy814yFUEoW8WRkvr15hyw0gW3lBoHYGVNT4TMz70NwCZcAAw0CjtB/rOwqtwYOQvHsfbaFLrn3DEwt8S7hq/NVfXNybTY+RpaE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=a8DaUhxX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="a8DaUhxX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55404C4CEF5; Sat, 27 Sep 2025 11:33:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1758972799; bh=EV6l4ssTVreRKgaeCwma3vj7I/H1BvBiXhlYjPP8VrU=; h=Date:From:To:Cc:Subject:References:From; b=a8DaUhxX04ICAaViM4kNaxJ/PycZRamUHTIwk+gdYgTBn9GKWgWd83AnrlnumSANX FA6AjcyEFeiblNPO/TnViUl/rR7qJoDIdhGaBCsUFnV7HZSnqK21Mh8ZmEfA8RBNvo GtAJmEGnEx+OBF3GW2zpEIck1dFnNdo6YwF3aQAplCjJd6qtSeB3xqeVDfAwdwHzII 3nC+KCn4FnQRERmcVblfI/OLCcLkMdzzAwiNb8Rbw9SSP2aih4vJ1kyluJwzCrTVpY xFxGCNGOFdRxJV5yYGj6DNrvOL0C11eCdMsAHiQ0hIbq5u1EG/iOfi+A5GcH2R5xZp 0mg+eT57YGBUg== Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1v2TCR-0000000D4N2-41kJ; Sat, 27 Sep 2025 07:34:47 -0400 Message-ID: <20250927113447.813602775@kernel.org> User-Agent: quilt/0.68 Date: Sat, 27 Sep 2025 07:34:19 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Tomas Glozar , John Kacur , Ivan Pravdin Subject: [for-linus][PATCH 1/2] rtla: Fix buffer overflow in actions_parse References: <20250927113418.080268096@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Ivan Pravdin Currently, tests 3 and 13-22 in tests/timerlat.t fail with error: *** buffer overflow detected ***: terminated timeout: the monitored command dumped core The result of running `sudo make check` is tests/timerlat.t (Wstat: 0 Tests: 22 Failed: 11) Failed tests: 3, 13-22 Files=3D3, Tests=3D34, 140 wallclock secs ( 0.07 usr 0.01 sys + 27.63 = cusr 27.96 csys =3D 55.67 CPU) Result: FAIL Fix buffer overflow in actions_parse to avoid this error. After this change, the tests results are tests/hwnoise.t ... ok tests/osnoise.t ... ok tests/timerlat.t .. ok All tests successful. Files=3D3, Tests=3D34, 186 wallclock secs ( 0.06 usr 0.01 sys + 41.10 = cusr 44.38 csys =3D 85.55 CPU) Result: PASS Link: https://lore.kernel.org/164ffc2ec8edacaf1295789dad82a07817b6263d.1757= 034919.git.ipravdin.official@gmail.com Fixes: 6ea082b171e0 ("rtla/timerlat: Add action on threshold feature") Signed-off-by: Ivan Pravdin Reviewed-by: Tomas Glozar Signed-off-by: Steven Rostedt (Google) --- tools/tracing/rtla/src/actions.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/tracing/rtla/src/actions.c b/tools/tracing/rtla/src/acti= ons.c index aaf0808125d7..eab51c0c0ce2 100644 --- a/tools/tracing/rtla/src/actions.c +++ b/tools/tracing/rtla/src/actions.c @@ -131,7 +131,7 @@ actions_parse(struct actions *self, const char *trigger) { enum action_type type =3D ACTION_NONE; char *token; - char trigger_c[strlen(trigger)]; + char trigger_c[strlen(trigger) + 1]; =20 /* For ACTION_SIGNAL */ int signal =3D 0, pid =3D 0; --=20 2.50.1 From nobody Wed Oct 1 21:27:12 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E07FA27A11A for ; Sat, 27 Sep 2025 11:33:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758972800; cv=none; b=Ls9uoBJjb9r6ZX4POavcSI/hws6PWXYDQXDCnbJh4Gv7KuAjDGagX5/izmSiAjytrVg2zg43ANfGr8eqA0D53rVQhZuwbbQDQLeNJgwK5LqsJzdvejc2ZFLOWSTlf6T8wy/ve19ELe5cXC6d0s7dPqTsZhLhTNkSDz3yZwhd3ms= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758972800; c=relaxed/simple; bh=g5K2fc+p1otK8OE0GTAix+46jLdstd86YFQIdSdInAQ=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=dJpe6+KltBqSUL3MRMr7lwCH3X5CpORp6uUXgN1frYgdoGP1wCHJ/I6d4vWifRan7O6HbmbicP/4RXp4Ax27PZDEdA8UPP1FzusxUsnDFCLEzSZqrrzCQ4hXISY9th4BSIq/E5ru7DU8cjjJ90AC7BMq5phEuVvkRmwfyNzr+ck= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jyRHngFo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jyRHngFo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69103C113D0; Sat, 27 Sep 2025 11:33:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1758972799; bh=g5K2fc+p1otK8OE0GTAix+46jLdstd86YFQIdSdInAQ=; h=Date:From:To:Cc:Subject:References:From; b=jyRHngFoN1TNKjrEP0eCuMcbr1gjPxsLsgMnd12zAj/w27fDjipOXVgFovhDYqKcU o1e3ihe562PI8SWn2ripnQ2og8Z0Ykud/GuYKEal2ccKX5tTap3KIMRyx9rJYjIsbY V1R3N3QUvwCBVla2dNCmk6bK3KC91I4Ropu2KydV7fHzOLTZIV8wHchpIlNvNeMDzV wy7BkmijFkY8qNA+5sTq7IkDOqPTiTmugWA8LQ4+zh1Wzyg5w1ptcYxzZ5Ql2PUEKw uGdofbHOravEzIREfESBypZtZpf2CQ0h69dxuThQjirCB0vylnC75M3ZyYAH+kvU5m 56Kt11zjmhc9A== Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1v2TCS-0000000D4NY-0Wbt; Sat, 27 Sep 2025 07:34:48 -0400 Message-ID: <20250927113447.981063678@kernel.org> User-Agent: quilt/0.68 Date: Sat, 27 Sep 2025 07:34:20 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Tomas Glozar , John Kacur , Luis Goncalves , Arnaldo Carvalho de Melo , Chang Yin , Costa Shulyupin , Crystal Wood , Gabriele Monaco , Wander Lairson Costa Subject: [for-linus][PATCH 2/2] rtla/actions: Fix condition for buffer reallocation References: <20250927113418.080268096@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Wander Lairson Costa The condition to check if the actions buffer needs to be resized was incorrect. The check `self->size >=3D self->len` would evaluate to true on almost every call to `actions_new()`, causing the buffer to be reallocated unnecessarily each time an action was added. Fix the condition to `self->len >=3D self.size`, ensuring that the buffer is only resized when it is actually full. Cc: John Kacur Cc: Luis Goncalves Cc: Arnaldo Carvalho de Melo Cc: Chang Yin Cc: Costa Shulyupin Cc: Crystal Wood Cc: Gabriele Monaco Link: https://lore.kernel.org/20250915181101.52513-1-wander@redhat.com Fixes: 6ea082b171e00 ("rtla/timerlat: Add action on threshold feature") Signed-off-by: Wander Lairson Costa Reviewed-by: Tomas Glozar Signed-off-by: Steven Rostedt (Google) --- tools/tracing/rtla/src/actions.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/tracing/rtla/src/actions.c b/tools/tracing/rtla/src/acti= ons.c index eab51c0c0ce2..13ff1934d47c 100644 --- a/tools/tracing/rtla/src/actions.c +++ b/tools/tracing/rtla/src/actions.c @@ -49,7 +49,7 @@ actions_destroy(struct actions *self) static struct action * actions_new(struct actions *self) { - if (self->size >=3D self->len) { + if (self->len >=3D self->size) { self->size *=3D 2; self->list =3D realloc(self->list, self->size * sizeof(struct action)); } --=20 2.50.1