From nobody Wed Oct 1 22:34:49 2025 Received: from mail.mainlining.org (mail.mainlining.org [5.75.144.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4E9422A4F4; Sat, 27 Sep 2025 05:02:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=5.75.144.95 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758949352; cv=none; b=f8LMBd8wEOGEPOefDOd1VpAlm/6+OLe0m+tGCKXA/sJI3F7QoRfNgs0aKBH4KTeJRRoNWzCtNvebEXbH96cLnwb5q6FMqMGCRs8cdSl8/pEOdtW6qwzHNofdhNyIhB1h8VRdurZUjYa2uv1vfu1zYTXC2sabj21j8a8cKAJ6Y+M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758949352; c=relaxed/simple; bh=2bdyJSmNfA84cD9RwcJK/nl1FiNGvBo/u1np6F84KKc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mbD3cx/HcC/YUj3nqb9Y8jILKwi4BzriZV352sW+zBk5hmvzMkGaJTqjipiY5+WRmjrjGQkzXW0tlC7w6T1vB4JEdgynG3idUndZgW5UhU4STopjmfwWzHTJ6xcuZeFeqHX527PoEzNbwpGxN+GxuR7kScXIJJ8eAzrs5QfoRWo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mainlining.org; spf=pass smtp.mailfrom=mainlining.org; dkim=pass (2048-bit key) header.d=mainlining.org header.i=@mainlining.org header.b=KU3bfiRD; dkim=permerror (0-bit key) header.d=mainlining.org header.i=@mainlining.org header.b=7CAWdH0n; arc=none smtp.client-ip=5.75.144.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mainlining.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mainlining.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mainlining.org header.i=@mainlining.org header.b="KU3bfiRD"; dkim=permerror (0-bit key) header.d=mainlining.org header.i=@mainlining.org header.b="7CAWdH0n" DKIM-Signature: v=1; a=rsa-sha256; s=202507r; d=mainlining.org; c=relaxed/relaxed; h=To:Message-Id:Subject:Date:From; t=1758949153; bh=c18qqKgWjk5aiDXdC9o8HGK jorA6BtduRucu/rNzeDw=; b=KU3bfiRDXJVcsJii/saVSictpZ2Uz2F8/TkU+jR6trsb6tu68B X6ho1FdRQh8hI+VonUi7b/9JcRoGNRtrDF2kbvTAKuNvTsnx5lnOEKTTBQv/wJZhfieIiOJugNC 2pEU0sN8evuGn581Nr59Y+B7s2K5Mqjd4dPjcmz0THy1F/L5uSYCzokfWgMSqfBZJ8ojOWplmem HcU9ksBzKAu/zU+Tym/8cR/9srpD3/mgppqu4Z0+XLS0GofsGmUTEf2Pdpz2BaV6f+qrh+uv+n6 7At3hPJJnwOxWOCJDi4OG+iWuTwiMD55SRZbH7LbV0rKpq19CZV6P/evRy65r7gclew==; DKIM-Signature: v=1; a=ed25519-sha256; s=202507e; d=mainlining.org; c=relaxed/relaxed; h=To:Message-Id:Subject:Date:From; t=1758949153; bh=c18qqKgWjk5aiDXdC9o8HGK jorA6BtduRucu/rNzeDw=; b=7CAWdH0n9zArBrqedy1Ccxmiay/4i7xMM/1GSS537Og2ARDj34 dYiWZUHJpzGq6kLrbcHE2stxG+uYUmcLXpCQ==; From: Dang Huynh Date: Sat, 27 Sep 2025 11:59:06 +0700 Subject: [PATCH v3 1/3] dt-bindings: gpio: rda: Make interrupts optional Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250927-rda8810pl-gpio-fix-v3-1-3641cdcf6c1e@mainlining.org> References: <20250927-rda8810pl-gpio-fix-v3-0-3641cdcf6c1e@mainlining.org> In-Reply-To: <20250927-rda8810pl-gpio-fix-v3-0-3641cdcf6c1e@mainlining.org> To: Manivannan Sadhasivam , Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-kernel@lists.infradead.org, linux-unisoc@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Dang Huynh , Conor Dooley X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1758949147; l=820; i=dang.huynh@mainlining.org; s=20250917; h=from:subject:message-id; bh=2bdyJSmNfA84cD9RwcJK/nl1FiNGvBo/u1np6F84KKc=; b=/pETpb90BR9sxZwYvfrWFybr1R2zT8RGeGRPqw3DI+yfzFsPZK7Z6Qe5ZOhhVDkT2izhuYnop WKcAw9HFDHQC9Xs6P47SEXF/2JWiS4/XEp4puuT6y72vjYeKEfXfT94 X-Developer-Key: i=dang.huynh@mainlining.org; a=ed25519; pk=RyzH4CL4YU/ItXYUurA51EVBidfx4lIy8/E4EKRJCUk= The GPIO controller from the modem does not have an interrupt. Acked-by: Conor Dooley Signed-off-by: Dang Huynh --- Documentation/devicetree/bindings/gpio/gpio-rda.yaml | 3 --- 1 file changed, 3 deletions(-) diff --git a/Documentation/devicetree/bindings/gpio/gpio-rda.yaml b/Documen= tation/devicetree/bindings/gpio/gpio-rda.yaml index 6ece555f074f84b396537917d7149d4061724dcc..dbb73b4d33ed39aa65024376b1a= f0c4e2fb896db 100644 --- a/Documentation/devicetree/bindings/gpio/gpio-rda.yaml +++ b/Documentation/devicetree/bindings/gpio/gpio-rda.yaml @@ -41,9 +41,6 @@ required: - gpio-controller - "#gpio-cells" - ngpios - - interrupt-controller - - "#interrupt-cells" - - interrupts =20 additionalProperties: false =20 --=20 2.51.0 From nobody Wed Oct 1 22:34:49 2025 Received: from mail.mainlining.org (mail.mainlining.org [5.75.144.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC8F218FDAF; Sat, 27 Sep 2025 05:02:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=5.75.144.95 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758949348; cv=none; b=izMw+vaYlvAZzvdPyeYlUTHQ/vs10SOxAUSyfLu5M6yi2WwYFz4ABEv7yATDq1sqwB9hBQP1pj/I5+OBPlkLEP02VF1AJQ6lIaTeq65F8ij0cnFav7T3zU2+XTPLLOCUR52r0Fj1aK/QQjW4YkdcVlslncDKtQnckuu5FmJ8rR4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758949348; c=relaxed/simple; bh=MpdOunzwRix8r+I6dz4W5XzomAmmpf9+SZqztmWlQWc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lmfMxv+8n7MDrgnCubG5I7EzSODp4CgmqFwFm55aOlgLiU91W1jfPIA1/5scO5QnVl0Z9hvdTote6qNu/9sqt81TfRsAQtfvaiAExNOlkQXWm9Zg4ZZ+xOx7/2YUjjQ8yElDzf2a8fr0L4UoOlVKOVeDQgFOvx4nhTJujGfVMwM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mainlining.org; spf=pass smtp.mailfrom=mainlining.org; dkim=pass (2048-bit key) header.d=mainlining.org header.i=@mainlining.org header.b=squFCJkG; dkim=permerror (0-bit key) header.d=mainlining.org header.i=@mainlining.org header.b=xE6S+r2y; arc=none smtp.client-ip=5.75.144.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mainlining.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mainlining.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mainlining.org header.i=@mainlining.org header.b="squFCJkG"; dkim=permerror (0-bit key) header.d=mainlining.org header.i=@mainlining.org header.b="xE6S+r2y" DKIM-Signature: v=1; a=rsa-sha256; s=202507r; d=mainlining.org; c=relaxed/relaxed; h=To:Message-Id:Subject:Date:From; t=1758949156; bh=DWdXLvFu30yYvjltQxnE0pJ 9kE3gyhS9Vq00c5VUKSU=; b=squFCJkGPyKQGu2syC4oXR3X0o5JP4wYYRdGY8WjUIK+wLQu5a b2fDD1QFZ1UMC2A18BjynkKrUh1VdG2Uo07QwUkW0zRQ/eHIQ+Z47jI3Z++HfY10XadHQB6NYwP FljSqk8MomKME7YYPOhPofg1XCr/dRVKhB3mUnj99OLU2KSuhO5qWlR6KoUoJmP3RGR3AkeSRMr ekDrI0/3urVjcj2PeMU0EC9lqybN2FNx7zLqpXdCP2QVLEhGIQ0donb3xfWP3B1t9KasZoP/8b1 x/NjqhabtuVcDNEYAtUDZIDQ3krNmLZqXvVwFcUuKCrifvLnvaFOfhS5lluSO6ldE6A==; DKIM-Signature: v=1; a=ed25519-sha256; s=202507e; d=mainlining.org; c=relaxed/relaxed; h=To:Message-Id:Subject:Date:From; t=1758949156; bh=DWdXLvFu30yYvjltQxnE0pJ 9kE3gyhS9Vq00c5VUKSU=; b=xE6S+r2yuMtthxGPUz48JuxFTe3Lc6QqhYjub/HRYdMGg7pIoT Z2aTXtfPzEkPlgL7L0TD03lIbCv30yTGuGBA==; From: Dang Huynh Date: Sat, 27 Sep 2025 11:59:07 +0700 Subject: [PATCH v3 2/3] gpio: rda: Make IRQ optional Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250927-rda8810pl-gpio-fix-v3-2-3641cdcf6c1e@mainlining.org> References: <20250927-rda8810pl-gpio-fix-v3-0-3641cdcf6c1e@mainlining.org> In-Reply-To: <20250927-rda8810pl-gpio-fix-v3-0-3641cdcf6c1e@mainlining.org> To: Manivannan Sadhasivam , Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-kernel@lists.infradead.org, linux-unisoc@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Dang Huynh X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1758949147; l=961; i=dang.huynh@mainlining.org; s=20250917; h=from:subject:message-id; bh=MpdOunzwRix8r+I6dz4W5XzomAmmpf9+SZqztmWlQWc=; b=FbBM848buke3ZFLTeEqaWSbtCt9iSjXfoKtgadZUBCbL0o6C85MggUTDyTusPlRHhTEWOI9Ub Ho0FsXs8vibAwBYtHPJGLAt7nm5TUJPRnjE5MKr3OpVE/Tvq+F9yrHj X-Developer-Key: i=dang.huynh@mainlining.org; a=ed25519; pk=RyzH4CL4YU/ItXYUurA51EVBidfx4lIy8/E4EKRJCUk= Not all GPIO have IRQ. When we use this driver with GPIOC (handled by modem) we get: rda-gpio 11a08000.gpioc: error -ENXIO: IRQ index 0 not found Let's mark IRQ as optional so this error doesn't show up. Signed-off-by: Dang Huynh --- drivers/gpio/gpio-rda.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-rda.c b/drivers/gpio/gpio-rda.c index fb479d13eb01a49218ad4229e7d4f70f096f5a2e..7d20dbbb6ec41149a1dbf4d9ef9= ac86449773c35 100644 --- a/drivers/gpio/gpio-rda.c +++ b/drivers/gpio/gpio-rda.c @@ -229,7 +229,7 @@ static int rda_gpio_probe(struct platform_device *pdev) * RDA8810PL, GPIOC doesn't support interrupt. So we must handle * those also. */ - rda_gpio->irq =3D platform_get_irq(pdev, 0); + rda_gpio->irq =3D platform_get_irq_optional(pdev, 0); =20 rda_gpio->base =3D devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(rda_gpio->base)) --=20 2.51.0 From nobody Wed Oct 1 22:34:49 2025 Received: from mail.mainlining.org (mail.mainlining.org [5.75.144.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC5FC229B36; Sat, 27 Sep 2025 05:02:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=5.75.144.95 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758949359; cv=none; b=bpTFtHqqtO/qKSqs49m7M7aWWRdVxerSo6/3hgkJxEgexw6vkCXgssXcUL6T2WdhYj8JfdGf/X8bQd6wgvnoEIMQpYv+sVoVmgkBjR3mNnx7scu3olqCqJJxq5QMsQqXW+dirFk4vWChd2qcFby6lX/32zajVSIK2PyBb7PEGd4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758949359; c=relaxed/simple; bh=plcpw2T9B0QjZiLTHHwxIiFvD6CVvF2W7wuatitb7c4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QP35NDQou8qqrVaXAw5d0qPXentTs3F1eRwn31keNBvkbCRKGtK7tN73tohHx8KEBfSWbPgIFiJmPFPqBqWKSSvna8+KcItzaKzHw/KZ2mztXiqsBfWaT72kIRbpPuL3jnclzc8xx/z93GU1kKABXOo6SOW70lWr3tN6i0r5hTQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mainlining.org; spf=pass smtp.mailfrom=mainlining.org; dkim=pass (2048-bit key) header.d=mainlining.org header.i=@mainlining.org header.b=I/IHR/ZB; dkim=permerror (0-bit key) header.d=mainlining.org header.i=@mainlining.org header.b=ScRC0d9u; arc=none smtp.client-ip=5.75.144.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mainlining.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mainlining.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mainlining.org header.i=@mainlining.org header.b="I/IHR/ZB"; dkim=permerror (0-bit key) header.d=mainlining.org header.i=@mainlining.org header.b="ScRC0d9u" DKIM-Signature: v=1; a=rsa-sha256; s=202507r; d=mainlining.org; c=relaxed/relaxed; h=To:Message-Id:Subject:Date:From; t=1758949158; bh=nZCMvyWJd/0l+d8DwDHIgR7 fMdp6Hhhxk/Ql0PW2G5o=; b=I/IHR/ZBehD1zCce6Zf+RIlfFIkv8B873wDBg96cWIrHduo557 /1MfQJV5GhPBhy6NILg8C4/q+OPQKKSQnsCAtNBFgUXq4mULRPZYifBeL20HoVB7fexWPcrljAq vQXJNue1Jv6QK18wdEmgvryymT5rr2NR48YVViFkkHfWHxJgTeat/RfySPINdbHQumPzhn3fVnZ sBW+p4X1ceV+61Hv9xRqZa9ciYAj59xVLca4KEIY+OA6JpES91hcNfkP4m4627/i/qElpC2wAbY Tl6xYxU6aNMJ3yLm2Dgy0UX9ZyVHmZG/6EYSUgKTqepNxbWBj2HRxd94Fl+Le05xAAw==; DKIM-Signature: v=1; a=ed25519-sha256; s=202507e; d=mainlining.org; c=relaxed/relaxed; h=To:Message-Id:Subject:Date:From; t=1758949158; bh=nZCMvyWJd/0l+d8DwDHIgR7 fMdp6Hhhxk/Ql0PW2G5o=; b=ScRC0d9urjAzTpmviEOOd2PNwtf09CsGN+AqdKAxtvTOTSevdk KoZN/RL4rrO3VsQZNk3QXhyMknEjX9DUkpDQ==; From: Dang Huynh Date: Sat, 27 Sep 2025 11:59:08 +0700 Subject: [PATCH v3 3/3] gpio: rda: Use bidirectional GPIO register for direction input Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250927-rda8810pl-gpio-fix-v3-3-3641cdcf6c1e@mainlining.org> References: <20250927-rda8810pl-gpio-fix-v3-0-3641cdcf6c1e@mainlining.org> In-Reply-To: <20250927-rda8810pl-gpio-fix-v3-0-3641cdcf6c1e@mainlining.org> To: Manivannan Sadhasivam , Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-kernel@lists.infradead.org, linux-unisoc@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Dang Huynh X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1758949147; l=1179; i=dang.huynh@mainlining.org; s=20250917; h=from:subject:message-id; bh=plcpw2T9B0QjZiLTHHwxIiFvD6CVvF2W7wuatitb7c4=; b=h8bm/jYJCPp076VvjNf3NuBUvvZXtwNyl/IgNI3unR8XASZV8DEetcampybSESkX8cdFR5EVp RVqpIB59SZDDr9w+ar/lPTXgEyhzNw+QVJ4JItIposuWH+DY3RRnq8c X-Developer-Key: i=dang.huynh@mainlining.org; a=ed25519; pk=RyzH4CL4YU/ItXYUurA51EVBidfx4lIy8/E4EKRJCUk= The current implementation uses both DIRIN and DIROUT registers, but the bgpio library expects 1 to be output direction, which on this IP is reversed (0 =3D output, 1 =3D input). To fix this, use GPIO_OEN_VAL for input direction register which expects 1 =3D input, 0 =3D output. This change should not affect any mainline users as none of them have any peripherals hooked up to a GPIO. Signed-off-by: Dang Huynh --- drivers/gpio/gpio-rda.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-rda.c b/drivers/gpio/gpio-rda.c index 7d20dbbb6ec41149a1dbf4d9ef9ac86449773c35..145b61fc83fb6eee2415e979a14= 4616d81595736 100644 --- a/drivers/gpio/gpio-rda.c +++ b/drivers/gpio/gpio-rda.c @@ -243,8 +243,7 @@ static int rda_gpio_probe(struct platform_device *pdev) .dat =3D rda_gpio->base + RDA_GPIO_VAL, .set =3D rda_gpio->base + RDA_GPIO_SET, .clr =3D rda_gpio->base + RDA_GPIO_CLR, - .dirout =3D rda_gpio->base + RDA_GPIO_OEN_SET_OUT, - .dirin =3D rda_gpio->base + RDA_GPIO_OEN_SET_IN, + .dirin =3D rda_gpio->base + RDA_GPIO_OEN_VAL, .flags =3D BGPIOF_READ_OUTPUT_REG_SET, }; =20 --=20 2.51.0