From nobody Wed Oct 1 23:35:38 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8ADF2236F2 for ; Sat, 27 Sep 2025 01:05:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758935122; cv=none; b=MqjaT4jU7wHz+DDbIhjBuT90LDUgLT6S7f7RHS9n1ClWsk5yd7ZNDA0lCH2HEKxarQ4zny9OwcrArl0EwyH/gjG32x+UWhAZoUbuUPOL8DMza2PXGkrFn8NHC9bQK3vkMCcWsYVSAumtnhwcbkOnw2h7qr2fPvtlUzX1bz7yTf8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758935122; c=relaxed/simple; bh=9CNqOjlTFRCCeiBZ+szAQcQNElv7Yqy1Tew0H4Yo4CU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=oeocb7JGUqA44ypBv2e97Czl3d2WWHyhy38ubbKmUSY0W7KtMiyq3dfzdheicOGCBcnJ7rE4DKtUwGTQdeOgSti3/N3igmoj9yeKvg0xxrKm9WwrqnhsYjrYFafK8fFNQHUpb7PsT+eAy/cpcpHKlTvEymiHXotxllxFv3XZuJU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VJXreUEW; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VJXreUEW" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58QEXoZ8001483 for ; Sat, 27 Sep 2025 01:05:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xAp39OMtIUlg6ggEgbLTpX/2Uyxk5maUiBvPyhN2y14=; b=VJXreUEWNkUkbxEW gNTa3rc5Q7CTeCx3Aq8DCW61iUOKIqsBNZXCpS3MEpp1dGi/zwBqdBb5dQUximaz 5JpKszi88v1jx9KJBibAug28ySUsa5uh0HhsW9mtfM6C/cxb3Oyg4CEzgEZ93Son lTi3wg/p3NCm7X60k3jBrMpnZ7Yg7+R9pCl4ssp4RvrIFTzt89vHr+NzOuL6Gtfe dAXqM/3K44sOKHDsEM9z8vEMSoCiExr0dXPzTg3tnChU+zoik/bL3Wce4FO5ZNQK xjcRGmXO2fpRAJy6HFEcRIdOAd0uTo+F/reFoWHLPlo/vyQh+zh3TA5n1pYXQJsu 0jSE1w== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49db0rmhb5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 27 Sep 2025 01:05:20 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4d7f90350f3so58686121cf.0 for ; Fri, 26 Sep 2025 18:05:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758935112; x=1759539912; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xAp39OMtIUlg6ggEgbLTpX/2Uyxk5maUiBvPyhN2y14=; b=bGsF8ixVJe+6Ju1RCYM3JR6igdPbBnBAAZ88hWDE69Y+tNigqTqsK7oY4yUJ0aSygc QIdcFxh5iUoGV6hVoosoquHu3GlIJvWxpVWaDDrURkuTQlcE0FXcjD14OhdEG2lF1rbj wCwCjojILT8nt27SChJvDJdosIMFoWdl9RYs0rKswz395fRoUxKje9Njt77+/S3fVvg8 7l1PFe6WO27log8qLCQ7nWD6CvC/0ftYxa6h3Lp1YfCblBCkQg38fKbPtRc3+nFDjWxy 001BdOGT0bfTEv8DIN7A77sXLzHtRwZY/N2iT9uTnBqCEJTtmk4KkP/QpMyiu4NfRpBO dSwg== X-Forwarded-Encrypted: i=1; AJvYcCUoexrh3ipmibREDyYSRhTA/kE5U3kNAsp68fmkY7YLtDgDVhYB3phQGe/u0rz+gb/Mv/vOKTR3qMe+fJs=@vger.kernel.org X-Gm-Message-State: AOJu0YwN6HeJv5OOVFP5AQn/CVDzg6ULSyUu5TWO9SXimPrshapMbF5q H0/qxJ6vB7oy3YgNYFTJw5MqnQkmVIe0vxlqXjarTeWeL0kpoUoILnhyWgsh8NMPIoj03BYZFCq 77p59/YZSuASO+gJLIkJQ6HMwNrZzt25vp53BTIbAMsLIR8ZZG59vMDtlBfXe5GeQTBQ= X-Gm-Gg: ASbGncs4L8lGJvh5ArPiCplNtgpe/NAjJqE9mpMiKL7PsLVyscOw6hJEMnzz5ubtzUe 7Hh/5MI3+hhOG+s9Q1QK/hsUsXwZUmjPdiq+ka4gew2Vryq6p/cFSBbGs3BDRyherxHEs2HC901 BF3W6QOIi0FGH0ib+oOfSBkaVcJHR08mk5baasiX2B8yMZ7oUtFc29vo+Mc83hInJffOKgEDxPl zGuX40ZVpPrmU05HpkowFBeCI6V6YYYdXh7xoGZDbUDO5pNivYmAH7zr4GacLrRQMeiZPSrZ7Vw leXcym2KfjtH23lmaqVj4fpbUpxjFk2G8eCX/BWh6BR20hYCNkFeE3fwePUsEW/mV7MedSfKDrX +LxIgKHvjVzzLzadwqUXmXbliQJk1s+DjqxWboXnaEUQpEgR3K6MA X-Received: by 2002:a05:622a:164f:b0:4b4:95ec:c830 with SMTP id d75a77b69052e-4ded642c212mr20148201cf.42.1758935112288; Fri, 26 Sep 2025 18:05:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFDCP6BId/iczHUn0V/ClnhswRFso/twuHTYrKNlDcNcH1xOXlUNtsKYlqWIiCEk6/tz5NBGQ== X-Received: by 2002:a05:622a:164f:b0:4b4:95ec:c830 with SMTP id d75a77b69052e-4ded642c212mr20147801cf.42.1758935111756; Fri, 26 Sep 2025 18:05:11 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-583139f99c1sm2156143e87.35.2025.09.26.18.05.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Sep 2025 18:05:09 -0700 (PDT) From: Dmitry Baryshkov Date: Sat, 27 Sep 2025 04:04:38 +0300 Subject: [PATCH 9/9] drm/sun4i: hdmi: handle unsupported InfoFrames Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250927-limit-infoframes-2-v1-9-697511bd050b@oss.qualcomm.com> References: <20250927-limit-infoframes-2-v1-0-697511bd050b@oss.qualcomm.com> In-Reply-To: <20250927-limit-infoframes-2-v1-0-697511bd050b@oss.qualcomm.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Liu Ying , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Andy Yan , Chen-Yu Tsai , Samuel Holland Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-sunxi@lists.linux.dev X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3103; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=9CNqOjlTFRCCeiBZ+szAQcQNElv7Yqy1Tew0H4Yo4CU=; b=owGbwMvMwMXYbdNlx6SpcZXxtFoSQ8Z1C0UxHct0YeW9rVGvqo/s5dsq/C+fqclwuc3P1ASLR tOG+g+djMYsDIxcDLJiiiw+BS1TYzYlh33YMbUeZhArE8gUBi5OAZhIUCIHQ89JLquMpq2R5rUP pSeJawi84tGYrTyvZ/16fZaXs4/rxs3Qe+qwzlvwotEPe+erErdqpzDGi/UqxwjNvt6jw7320ot J19Vy1KUSzG82FL3+Knwkv/CF8hKm3c3m2UyOsmHxGs/3VyeubNmkyBwadXC9rsXpbXGVFsz887 qPXm0zy67jOr5rd3LmroviXxdoNJTmzf/9e8N/D43VmjxM+RPmrfi07pAZU6C0uJWZ9jM9lTsPd LN7Mr/+cZGf+S7h9b+MDyV+eZsvsW/zWOKx987W6XsVWN0eHO2OC0hoPh75xGv675dHf0bIKDAo X1nLZLx9U53A7//+S7zuirZX5R/tUH27u8293XN1meluAA== X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=dP+rWeZb c=1 sm=1 tr=0 ts=68d73850 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=EUspDBNiAAAA:8 a=Uj443JZPoyhSIAxeSSAA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-ORIG-GUID: 4vnvjSyGdE1tuizKrUM2geE14Gyqq1ua X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTI1MDE3MSBTYWx0ZWRfX/sg44mI9NNrL xbvnXDqzop7lrKU9wYqTkt8wD+Esna1ZJmuw/Lbph35OD2R5BCNYF+CuBmiEfBHDP47sOHU2HTk ArcjMHPMb4NZYYNDkk9KAyR+hooHO5oVgzJZ+aqzvxjEMtdP5IEa2JF22wmzphuk5EYgqAWx3nQ /lPVoZYENN3UfICJx+4Gidt1elDNw/lSBWCO33vX0jl/xwQNubSR6r+mKMZL3svcuqc5DRroi19 tz1tOp+IuTT/7ZA+KcPbL2Zz2YmpDdWqJbvxk0FUADeZS630X94lH+ZLomtI4SHzM8qDyuorCIj 0bkkfHdz6aAqc0dQHcxsCVIl15hIe7B6hKWQX79WhkQKcSJKyMsTgR4bV9L35v1pnwEmbYKDERy dnzskMR6yFrfFHdRyot4GpS53MPntg== X-Proofpoint-GUID: 4vnvjSyGdE1tuizKrUM2geE14Gyqq1ua X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-26_08,2025-09-26_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 phishscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 suspectscore=0 adultscore=0 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2509150000 definitions=main-2509250171 Make write_hdmi_infoframe() and clear_infoframe() callbacks return -EOPNOTSUPP for unsupported InfoFrames and make sure that atomic_check() callback doesn't allow unsupported InfoFrames to be enabled. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 49 +++++++++++++++++++++++++++++-= ---- 1 file changed, 43 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c b/drivers/gpu/drm/sun4i= /sun4i_hdmi_enc.c index ab0938ba61f7d75dd0bec473807a04a20e1cffbd..219d826d535eb82328260c631e8= b41f33a2f4c2f 100644 --- a/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c +++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c @@ -47,11 +47,8 @@ static int sun4i_hdmi_write_infoframe(struct drm_connect= or *connector, struct sun4i_hdmi *hdmi =3D drm_connector_to_sun4i_hdmi(connector); int i; =20 - if (type !=3D HDMI_INFOFRAME_TYPE_AVI) { - drm_err(connector->dev, - "Unsupported infoframe type: %u\n", type); - return 0; - } + if (type !=3D HDMI_INFOFRAME_TYPE_AVI) + return -EOPNOTSUPP; =20 for (i =3D 0; i < len; i++) writeb(buffer[i], hdmi->base + SUN4I_HDMI_AVI_INFOFRAME_REG(i)); @@ -60,6 +57,45 @@ static int sun4i_hdmi_write_infoframe(struct drm_connect= or *connector, =20 } =20 +static int sun4i_hdmi_clear_infoframe(struct drm_connector *connector, + enum hdmi_infoframe_type type) +{ + if (type !=3D HDMI_INFOFRAME_TYPE_AVI) + return -EOPNOTSUPP; + + return 0; +} + +static int sun4i_hdmi_atomic_check(struct drm_connector *connector, + struct drm_atomic_state *state) +{ + struct drm_connector_state *conn_state =3D + drm_atomic_get_new_connector_state(state, connector); + int ret; + + ret =3D drm_atomic_helper_connector_hdmi_check(connector, state); + if (ret) + return ret; + + /* not supported by the driver */ + conn_state->hdmi.infoframes.spd.set =3D false; + + /* FIXME: not supported by the driver */ + conn_state->hdmi.infoframes.hdmi.set =3D false; + + /* should not happen, HDR support not enabled */ + if (drm_WARN_ON_ONCE(connector->dev, + connector->hdmi.infoframes.audio.set)) + return -EOPNOTSUPP; + + /* should not happen, audio support not enabled */ + if (drm_WARN_ON_ONCE(connector->dev, + conn_state->hdmi.infoframes.hdr_drm.set)) + return -EOPNOTSUPP; + + return 0; +} + static void sun4i_hdmi_disable(struct drm_encoder *encoder, struct drm_atomic_state *state) { @@ -237,10 +273,11 @@ static struct i2c_adapter *sun4i_hdmi_get_ddc(struct = device *dev) static const struct drm_connector_hdmi_funcs sun4i_hdmi_hdmi_connector_fun= cs =3D { .tmds_char_rate_valid =3D sun4i_hdmi_connector_clock_valid, .write_infoframe =3D sun4i_hdmi_write_infoframe, + .clear_infoframe =3D sun4i_hdmi_clear_infoframe, }; =20 static const struct drm_connector_helper_funcs sun4i_hdmi_connector_helper= _funcs =3D { - .atomic_check =3D drm_atomic_helper_connector_hdmi_check, + .atomic_check =3D sun4i_hdmi_atomic_check, .mode_valid =3D drm_hdmi_connector_mode_valid, .get_modes =3D sun4i_hdmi_get_modes, }; --=20 2.47.3