From nobody Wed Oct 1 23:35:34 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 874D92F60C0 for ; Fri, 26 Sep 2025 13:30:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758893459; cv=none; b=Hco+Xr/uyi2QOT7bGOSE0CsMf9hKo/ibtZkStHQJEWNxPggLGUOuTWICDTS9vsbrXGMm62cfkEmH1BCy42moLzKizNYjeM2a9bXQSna3j9zeqEl6wJltO7VbN2eIcb++Y/pa+nrsezm9V1Pnqwh7aZ+RkPOtMDQeTPKRVyQnPBU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758893459; c=relaxed/simple; bh=SPcf++Iyi3zzKsVUVveR11UfhJHrrII0re5TSa0X8Qg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=JAB7FnvlnGIHuxw5O+LO8X/Mqym5riRja8MTpzxr+3wFL4EN1kvnx/XGIh0nXZpHJwXb/Am3PqBtgLQAxRjRT9ZcUw6bAC5v/vKxZa4fggfz3+V9VZWU2kuLIyBfb9rr6fc9uxdtKgz3GVeUe4ePttmEQXx2sotkaeCovuci1ZU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MC+bQKDk; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MC+bQKDk" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58Q8vqMJ021014 for ; Fri, 26 Sep 2025 13:30:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=eea5gCv3xnM ebaukW35PefSTb9gPNWDUanvxJnODS38=; b=MC+bQKDk4wyDBUvmXgizRPOTMxt nZWr7zATaqUCW+DF3odBbkelhk3agWH3cyl08JSzxHDuGHUMfLlFLlr9MsPN53N/ QxNBBMuq0DG7i4kEpbN6o9dltx7yNeQG+cElHWaVrEHVfBR9G6jfuOOeubH6PzSh tKr/FK1YuYoTcV2uZSwMq9Nc/2L1PqwWKPzD9ggMmW4vdcJQxcN+VhC/WFu629tT B0gQJLGwyc/D/ltoV+7uMZBW3b7HAcu7VsYxXONnqi7rnfFMSkyrfsIVHQ1Qixvs GlCvi6KGzksPwatspZyPw3Uq82OjbqK2AR8xK8hZ3vqsKyv1P9isG6UAZxg== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49db0qu0g8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 26 Sep 2025 13:30:56 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-77f3998c607so3721431b3a.1 for ; Fri, 26 Sep 2025 06:30:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758893456; x=1759498256; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eea5gCv3xnMebaukW35PefSTb9gPNWDUanvxJnODS38=; b=X3X4RElaa07DKNiw5fOuQS2KMwkoJBht2jzFQVjw4yx4iZptzs+7tgMo8AJrTewIIZ v/DvXbOzRkYnc/wc0wWdVpfBTsrhiJthwBng+b4+esYi2AHrxsHPLnS54r34bcxEdSAt 6T0hHhXDyKpKTzKO9/jOgRoZk0ebtQ7+CBOCKz5CQLxvgeO3tfwBNYkfI1q3Vv1tJpzj 9ScsbxRvdzBTsHh1j2mOtGSr+BLah52ALfoKw3beIJ3fkpvMy023fdgqptuMeBR/7PT6 igD7lYsB7UFgEEHlDy/seSWk8QcM9jBywYZb666oJGWX6eEylhYRLBCgUPsANB0pQmbN +YXw== X-Forwarded-Encrypted: i=1; AJvYcCXPk7D9Nt5yoWkgj60CwFNrBbY0tMQPoM3BU32CzXxs0QtJ/f2HeQ65LJdBSqViueXkriBEbXtTFeNZjco=@vger.kernel.org X-Gm-Message-State: AOJu0YyZ3QhxWvT+lYmt8DLh8eZopmo4I0OPZVUSD4gR/DuwisMPKhb9 5hp7xC3pdXIgBmAKjxCeOFrfixIOoHsZEZstoHvz2zrHDOvdi1RAs9Bu6dLSagZXNED94TFKskh D2Cmn5obZ/p6BxElKdmJwZcSyePUtzI+OPnTnTqv78+dfGAiBsl0hWR0nr4TOWwRnJYc= X-Gm-Gg: ASbGncsoh5W8uEiMsTaPBXtJR0GTKXGiJHgx/G4Q8edZCu0WddQsOe0jrScA0jom8vs LXUzNBu6wt9jQJwgQ/2uyVN4chpgFXnHGDOzagDqZFq9IN867aLf32ENLG09Vnf/OeCtfQIVngo aAegrM9pjyEuZQZWSuL2eYYwY/CsowuocUWBVLsV12nKfCVDT+jW8neH/eIc6CtkK66dbTHw8Lk /h5OQGmLpiutrzVhS7nSCr0m3HjZII1T+zpdTOBTK8ZqmugwPebel51DQal4syJvw3+QX5nNS89 d992DHw3nVSvPmeId1/fnHe2lDn7ThKxZOhd1DO5aFs2zf3DqcvYhIuoMhXH4KzHX5Vo9mAjXwk V X-Received: by 2002:a05:6a00:8c0e:b0:781:18dd:31de with SMTP id d2e1a72fcca58-78118dd369dmr1549234b3a.12.1758893455708; Fri, 26 Sep 2025 06:30:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFDMsJY/jOHSQBSRpAM1bJg3jREXLQMB/BlA11EqBoG9fchJG9k3mAKRt0sQomWwVSy1TLp2g== X-Received: by 2002:a05:6a00:8c0e:b0:781:18dd:31de with SMTP id d2e1a72fcca58-78118dd369dmr1549190b3a.12.1758893455134; Fri, 26 Sep 2025 06:30:55 -0700 (PDT) Received: from hu-vdadhani-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7810238d321sm4504174b3a.17.2025.09.26.06.30.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Sep 2025 06:30:54 -0700 (PDT) From: Viken Dadhaniya To: mkl@pengutronix.de, mani@kernel.org, thomas.kopp@microchip.com, mailhol.vincent@wanadoo.fr, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linus.walleij@linaro.org, brgl@bgdev.pl, linux-can@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: mukesh.savaliya@oss.qualcomm.com, anup.kulkarni@oss.qualcomm.com, Gregor Herburger , Viken Dadhaniya Subject: [PATCH v5 5/6] can: mcp251xfd: add gpio functionality Date: Fri, 26 Sep 2025 19:00:17 +0530 Message-Id: <20250926133018.3071446-6-viken.dadhaniya@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250926133018.3071446-1-viken.dadhaniya@oss.qualcomm.com> References: <20250926133018.3071446-1-viken.dadhaniya@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: ggtGiXiwIf_gsjCOCDSsfMfrqwvXPIL5 X-Proofpoint-ORIG-GUID: ggtGiXiwIf_gsjCOCDSsfMfrqwvXPIL5 X-Authority-Analysis: v=2.4 cv=api/yCZV c=1 sm=1 tr=0 ts=68d69590 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=yJojWOMRYYMA:10 a=8f9FM25-AAAA:8 a=EUspDBNiAAAA:8 a=tLDx1KCooYQGmN993QAA:9 a=zc0IvFSfCIW2DFIPzwfm:22 a=uSNRK0Bqq4PXrUp6LDpb:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTI1MDE3MSBTYWx0ZWRfX5mvIKVgZbdoM tMPc0blsSxzwnUgy7DTRVLJ8q+5KM5qE8gg5jUat3TXTgyBbnYOlDILSE6uH99i4/zOz3795cf8 e6IuBiMp8hHGn/BtX9povp9rwOym1tsRzHVLvJlK1R8UQ/86DcXua1BkcwNhUomtQJ3NiZHuIMK kUvLnYQWnEF18yUU29WXSbDd2T/Cl1USpymFq45b2efVkmr7Kra2eHwsziFX/NZJu7BTNC0ppy9 /U5Z41s52NRWYfoAUNNaGtxPSI005Mpj2xLiSTuBeiQ1gf2+QJ0fZEzW36e/fMWiSkGJmGQcOeD g6U3786qfAtiZkqyXwbp5uuzoHPNegEw43u05tckxYA05Uyizuw62332Aj2vDXPQZb+Axi6Mo6y rZOpe/koP9c2OghGF72ioZv+x02FHg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-26_04,2025-09-26_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 adultscore=0 spamscore=0 priorityscore=1501 bulkscore=0 phishscore=0 impostorscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2509150000 definitions=main-2509250171 Content-Type: text/plain; charset="utf-8" From: Gregor Herburger The mcp251xfd devices allow two pins to be configured as gpio. Add this functionality to driver. Signed-off-by: Gregor Herburger Tested-by: Viken Dadhaniya Signed-off-by: Viken Dadhaniya Acked-by: Bartosz Golaszewski --- drivers/net/can/spi/mcp251xfd/Kconfig | 1 + .../net/can/spi/mcp251xfd/mcp251xfd-core.c | 172 ++++++++++++++++++ drivers/net/can/spi/mcp251xfd/mcp251xfd.h | 2 + 3 files changed, 175 insertions(+) diff --git a/drivers/net/can/spi/mcp251xfd/Kconfig b/drivers/net/can/spi/mc= p251xfd/Kconfig index 877e4356010d..7c29846e6051 100644 --- a/drivers/net/can/spi/mcp251xfd/Kconfig +++ b/drivers/net/can/spi/mcp251xfd/Kconfig @@ -5,6 +5,7 @@ config CAN_MCP251XFD select CAN_RX_OFFLOAD select REGMAP select WANT_DEV_COREDUMP + select GPIOLIB help Driver for the Microchip MCP251XFD SPI FD-CAN controller family. diff --git a/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c b/drivers/net/c= an/spi/mcp251xfd/mcp251xfd-core.c index ea41f04ae1a6..88035d4404b5 100644 --- a/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c +++ b/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c @@ -1797,6 +1797,172 @@ static int mcp251xfd_register_check_rx_int(struct m= cp251xfd_priv *priv) return 0; } =20 +static const char * const mcp251xfd_gpio_names[] =3D { "GPIO0", "GPIO1" }; + +static int mcp251xfd_gpio_request(struct gpio_chip *chip, unsigned int off= set) +{ + struct mcp251xfd_priv *priv =3D gpiochip_get_data(chip); + u32 pin_mask =3D MCP251XFD_REG_IOCON_PM(offset); + int ret; + + if (priv->rx_int && offset =3D=3D 1) { + netdev_err(priv->ndev, "Can't use GPIO 1 with RX-INT!\n"); + return -EINVAL; + } + + ret =3D pm_runtime_resume_and_get(priv->ndev->dev.parent); + if (ret) + return ret; + + return regmap_update_bits(priv->map_reg, MCP251XFD_REG_IOCON, + pin_mask, pin_mask); +} + +static void mcp251xfd_gpio_free(struct gpio_chip *chip, unsigned int offse= t) +{ + struct mcp251xfd_priv *priv =3D gpiochip_get_data(chip); + + pm_runtime_put(priv->ndev->dev.parent); +} + +static int mcp251xfd_gpio_get_direction(struct gpio_chip *chip, + unsigned int offset) +{ + struct mcp251xfd_priv *priv =3D gpiochip_get_data(chip); + u32 mask =3D MCP251XFD_REG_IOCON_TRIS(offset); + u32 val; + int ret; + + ret =3D regmap_read(priv->map_reg, MCP251XFD_REG_IOCON, &val); + if (ret) + return ret; + + if (mask & val) + return GPIO_LINE_DIRECTION_IN; + + return GPIO_LINE_DIRECTION_OUT; +} + +static int mcp251xfd_gpio_get(struct gpio_chip *chip, unsigned int offset) +{ + struct mcp251xfd_priv *priv =3D gpiochip_get_data(chip); + u32 mask =3D MCP251XFD_REG_IOCON_GPIO(offset); + u32 val; + int ret; + + ret =3D regmap_read(priv->map_reg, MCP251XFD_REG_IOCON, &val); + if (ret) + return ret; + + return !!(mask & val); +} + +static int mcp251xfd_gpio_get_multiple(struct gpio_chip *chip, unsigned lo= ng *mask, + unsigned long *bit) +{ + struct mcp251xfd_priv *priv =3D gpiochip_get_data(chip); + u32 val; + int ret; + + ret =3D regmap_read(priv->map_reg, MCP251XFD_REG_IOCON, &val); + if (ret) + return ret; + + *bit =3D FIELD_GET(MCP251XFD_REG_IOCON_GPIO_MASK, val) & *mask; + + return 0; +} + +static int mcp251xfd_gpio_direction_output(struct gpio_chip *chip, + unsigned int offset, int value) +{ + struct mcp251xfd_priv *priv =3D gpiochip_get_data(chip); + u32 dir_mask =3D MCP251XFD_REG_IOCON_TRIS(offset); + u32 val_mask =3D MCP251XFD_REG_IOCON_LAT(offset); + u32 val; + + if (value) + val =3D val_mask; + else + val =3D 0; + + return regmap_update_bits(priv->map_reg, MCP251XFD_REG_IOCON, + dir_mask | val_mask, val); +} + +static int mcp251xfd_gpio_direction_input(struct gpio_chip *chip, + unsigned int offset) +{ + struct mcp251xfd_priv *priv =3D gpiochip_get_data(chip); + u32 dir_mask =3D MCP251XFD_REG_IOCON_TRIS(offset); + + return regmap_update_bits(priv->map_reg, MCP251XFD_REG_IOCON, + dir_mask, dir_mask); +} + +static int mcp251xfd_gpio_set(struct gpio_chip *chip, unsigned int offset,= int value) +{ + struct mcp251xfd_priv *priv =3D gpiochip_get_data(chip); + u32 val_mask =3D MCP251XFD_REG_IOCON_LAT(offset); + u32 val; + int ret; + + if (value) + val =3D val_mask; + else + val =3D 0; + + ret =3D regmap_update_bits(priv->map_reg, MCP251XFD_REG_IOCON, val_mask, = val); + if (ret) + dev_err(&priv->spi->dev, "Failed to set GPIO %u: %d\n", offset, ret); + + return ret; +} + +static int mcp251xfd_gpio_set_multiple(struct gpio_chip *chip, unsigned lo= ng *mask, + unsigned long *bits) +{ + struct mcp251xfd_priv *priv =3D gpiochip_get_data(chip); + u32 val; + int ret; + + val =3D FIELD_PREP(MCP251XFD_REG_IOCON_LAT_MASK, *bits); + + ret =3D regmap_update_bits(priv->map_reg, MCP251XFD_REG_IOCON, + MCP251XFD_REG_IOCON_LAT_MASK, val); + if (ret) + dev_err(&priv->spi->dev, "Failed to set GPIOs %d\n", ret); + + return ret; +} + +static int mcp251fdx_gpio_setup(struct mcp251xfd_priv *priv) +{ + struct gpio_chip *gc =3D &priv->gc; + + if (!device_property_present(&priv->spi->dev, "gpio-controller")) + return 0; + + gc->label =3D dev_name(&priv->spi->dev); + gc->parent =3D &priv->spi->dev; + gc->owner =3D THIS_MODULE; + gc->request =3D mcp251xfd_gpio_request; + gc->free =3D mcp251xfd_gpio_free; + gc->get_direction =3D mcp251xfd_gpio_get_direction; + gc->direction_output =3D mcp251xfd_gpio_direction_output; + gc->direction_input =3D mcp251xfd_gpio_direction_input; + gc->get =3D mcp251xfd_gpio_get; + gc->get_multiple =3D mcp251xfd_gpio_get_multiple; + gc->set =3D mcp251xfd_gpio_set; + gc->set_multiple =3D mcp251xfd_gpio_set_multiple; + gc->base =3D -1; + gc->can_sleep =3D true; + gc->ngpio =3D ARRAY_SIZE(mcp251xfd_gpio_names); + gc->names =3D mcp251xfd_gpio_names; + + return devm_gpiochip_add_data(&priv->spi->dev, gc, priv); +} + static int mcp251xfd_register_get_dev_id(const struct mcp251xfd_priv *priv, u32 *dev_= id, u32 *effective_speed_hz_slow, @@ -1930,6 +2096,12 @@ static int mcp251xfd_register(struct mcp251xfd_priv = *priv) =20 mcp251xfd_ethtool_init(priv); =20 + err =3D mcp251fdx_gpio_setup(priv); + if (err) { + dev_err_probe(&priv->spi->dev, err, "Failed to register gpio-controller.= \n"); + goto out_runtime_disable; + } + err =3D register_candev(ndev); if (err) goto out_runtime_disable; diff --git a/drivers/net/can/spi/mcp251xfd/mcp251xfd.h b/drivers/net/can/sp= i/mcp251xfd/mcp251xfd.h index bd28510a6583..085d7101e595 100644 --- a/drivers/net/can/spi/mcp251xfd/mcp251xfd.h +++ b/drivers/net/can/spi/mcp251xfd/mcp251xfd.h @@ -15,6 +15,7 @@ #include #include #include +#include #include #include #include @@ -676,6 +677,7 @@ struct mcp251xfd_priv { =20 struct mcp251xfd_devtype_data devtype_data; struct can_berr_counter bec; + struct gpio_chip gc; }; =20 #define MCP251XFD_IS(_model) \ --=20 2.34.1