From nobody Wed Oct 1 23:35:35 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CDC028BA83 for ; Fri, 26 Sep 2025 13:30:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758893437; cv=none; b=LAP5++H1QoYOvQVE52itxkf0YbemtBczY2i5yAZ1zvRCZV1Wi6Je9iIIOLiIUYJVnuXPrPahtCmYDSwH0e+GTPajFVUSYcsYDHW0T5uns+a60HauCPl7lPY2eR3G8jTMpgMbBGR/a+Kr1rPcx4FgVF5y8uJiKxrUJRMdWAshO3s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758893437; c=relaxed/simple; bh=9tMx3D8608utTcEpPMnkdtIuK+d8YCm/4QGWcLPlEvU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=mVMcWdw1GhQD9/NnJyAAGYdkBDhz30HF6GqgnrkNmuj283TwQIKLj9vFWCHM/VFuwnwngV3uCVA6E/hYjptWtnCJCWqKicY8IWMqpq/+I7Oz/KwXSTinyhsAhUYpl084/5DUkcdQ8hVv/7k9fNHheUDywnSN8Ky1JpNlayZ679E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dy5OA5S5; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dy5OA5S5" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58Q8vZ4u018152 for ; Fri, 26 Sep 2025 13:30:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=52JKwdjjF6T 43Z0oK2sV6asg8JQDNCAzfJwR0DaXYts=; b=dy5OA5S5m4cdg8N7uMETnSuDF/p UIHx5SPVG7wfSCzYB7qDX4NGGy3Bt9Foyv5ls1YhMQEoUTefpgYfWKUzI8KrNlRv /zCUbUychw0qfqTlyN6xaaHE9EfDtsx5aR22TBIVKom26DCTn/aEF7LfSqTyn9Ox 83EORVcQFkJYSVfMn07VLJcajgusjaJ+BSblsJPBkud5lPfwfrFeyKZCk41D3TTj b9uOFhMoAp3MLBG3NN3OXlUFmFawOTu4uI8qgpFMQtYinu3bhPstsi5r/xpQDgJB k+/lf41PTiGfMAwTSY8AUvyRp1lQEBZ23SxPUSjtpTTsb9yVVRbKD29+R6g== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49db0tb0em-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 26 Sep 2025 13:30:34 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-b557abaad02so3117226a12.3 for ; Fri, 26 Sep 2025 06:30:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758893433; x=1759498233; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=52JKwdjjF6T43Z0oK2sV6asg8JQDNCAzfJwR0DaXYts=; b=pPsR/882Qsgr8HV9th4IJDPnVV9uBjPZIbGPPQW7g6/ulFhx2j8YvZYLVTO1WhD9V9 SxgO0xT7DBn7aa+k2XTi6ulL++CJnrwSFVrimVxtqUorX8ZLa04fneb6DjmVUlZuZWb4 2IWlYw38LERvUQWwL9lBxCqiSWsiV5M/LA5J7Xjbx+5HrWzd8x7sv31DGn8x+33VLWXC lTCejpnzOgZMC6NTg92aNuhUM+uKk2NvfSNk3zxmtxeEMFbxpqxD9gb6wSuwBWmqT5Qy I3DQP4t2tLDCtwzjBM0rUywQ+jmA6/U3K1M6scnowi7FVSvmQPPeXQGQxjUVMwi6Dy9c 4RtA== X-Forwarded-Encrypted: i=1; AJvYcCUEHeUMgjx0ig6uKT2iS+wTiZyzeMJS6F8Fv5dKHEAW8TF+O/eCGbOq6c/KRCCVLf++XeWSeGqZVbJnH24=@vger.kernel.org X-Gm-Message-State: AOJu0YxrPwo3V0JSIycllMCw+e13uw4GNYb6vc1n2Z/+4Hj7ZelbaoHY 9o0jSDIz3F90vdNXQ4F3CD4l+ItBWaWOuUBeLtPv028xOvqyzTvmkDi8c4chKGbqQ+/W4t5CMij LJZEtANy14SJdo8fSgMFNDk//pKsAX5w9qzrVGfFLd89TuM4AyKhZv11se6QV0NfUAVs= X-Gm-Gg: ASbGncvEapILlM/y7RCGb2Xe8QfXPBM3v3icVLVgD+r8hzqA3JWjdECrapvWsIMoGOS BMaIqXZ5zA0Pa3AR1ge89uQEr7lg09JVaBSOTCq0E2sfOYs/Z6+Cm2KLdgyccmf7mYpYGysPA/Q fTPVZOLD6Q5DKWmAHq6IokLBekJr7Ssq0rlmgnRvauJ68VFhhGdmZPsepD6BYkwq3j156uHzyyC rROJeXF61QPz47r9/s2aVXQ6tNCRQuvKcoMje+DzW6gmi6PjzLaqqAtjB4Tj5YS1+hda6Hn7Y9X dosYCMvgmJ5lESqR3qTdyFrUTJx3uCB6cSY3LZ472ZGaOQ15EvYF+JiQOOn2hFiWfHHsC5hM8Wh 3 X-Received: by 2002:a05:6a20:6a11:b0:2b8:5f2d:933d with SMTP id adf61e73a8af0-2e7c44125d5mr9295215637.12.1758893433323; Fri, 26 Sep 2025 06:30:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE9vJ7dSnobiw0gNzFaPZhNDl0sU+RMma/SjzJVzdYzcFJ5zLjBs4955Ly/ZUBsj/+Bq19zoA== X-Received: by 2002:a05:6a20:6a11:b0:2b8:5f2d:933d with SMTP id adf61e73a8af0-2e7c44125d5mr9295173637.12.1758893432713; Fri, 26 Sep 2025 06:30:32 -0700 (PDT) Received: from hu-vdadhani-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7810238d321sm4504174b3a.17.2025.09.26.06.30.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Sep 2025 06:30:32 -0700 (PDT) From: Viken Dadhaniya To: mkl@pengutronix.de, mani@kernel.org, thomas.kopp@microchip.com, mailhol.vincent@wanadoo.fr, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linus.walleij@linaro.org, brgl@bgdev.pl, linux-can@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: mukesh.savaliya@oss.qualcomm.com, anup.kulkarni@oss.qualcomm.com, Gregor Herburger , Viken Dadhaniya Subject: [PATCH v5 1/6] can: mcp251xfd: move chip sleep mode into runtime pm Date: Fri, 26 Sep 2025 19:00:13 +0530 Message-Id: <20250926133018.3071446-2-viken.dadhaniya@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250926133018.3071446-1-viken.dadhaniya@oss.qualcomm.com> References: <20250926133018.3071446-1-viken.dadhaniya@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: 38gyDVo4B5-19dyqhizjPpyiKaKLuT5O X-Proofpoint-GUID: 38gyDVo4B5-19dyqhizjPpyiKaKLuT5O X-Authority-Analysis: v=2.4 cv=Jvz8bc4C c=1 sm=1 tr=0 ts=68d6957a cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=yJojWOMRYYMA:10 a=8f9FM25-AAAA:8 a=EUspDBNiAAAA:8 a=6KGlMJUpO0AhJANn3KQA:9 a=x9snwWr2DeNwDh03kgHS:22 a=uSNRK0Bqq4PXrUp6LDpb:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTI1MDE3MSBTYWx0ZWRfX/3X56sf1tgMi 0AX9dOOqk67JbQk9JjVWDfpVlwzGSv9a8dPZujwopzvNKi0UoFgk0tpJozrdV+TXfWeF8v2EqdB hu73a1TRjDXFJwd2lT17C8l7AAAS4RHzf0LOIKL82p6KEtdzbSEH6zN8YdeZltzO5DkDH/To5iV GmYRovLZBx7oCFqc0SmbfrAwPXkmACPhc5PJtBwrowJMy+s5415qymT1CsmTe++w+aZ3GP+E3Ci qYhiYW1ToEmCtWtF940itydpz6gbdgQnUJkakeO6wQ9/JJnuimLjPRFpMQH4+4ADZKzEjW5A/Qe ayVyyRhAA6oU9uFdFUbx7yD/lAQBd9g9nfBEZjSpFAHReWDtq2evBCbFKVywxUDoncPyaM9kSRS gXwM4ftDQoGUSVM4iAnAQo7M9+kxjw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-26_04,2025-09-26_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 spamscore=0 priorityscore=1501 adultscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2509150000 definitions=main-2509250171 Content-Type: text/plain; charset="utf-8" From: Marc Kleine-Budde This is a preparation patch to add GPIO support. Up to now, the Vdd regulator and the clocks have been managed by Runtime-PM (on systems without CONFIG_PM these remain permanently switched on). During the mcp251xfd_open() callback the mcp251xfd is powered, soft-reset and configured. In mcp251xfd_stop() the chip is shut down again. To support the on-chip GPIOs, the chip must be supplied with power while GPIOs are being requested, even if the networking interface is down. To support this, move the functions mcp251xfd_chip_softreset() and mcp251xfd_chip_clock_init() from mcp251xfd_chip_start() to mcp251xfd_runtime_resume(). Instead of setting the controller to sleep mode in mcp251xfd_chip_stop(), bring it into configuration mode. This way it doesn't take part in bus activity and doesn't enter sleep mode. Signed-off-by: Marc Kleine-Budde Signed-off-by: Gregor Herburger Tested-by: Viken Dadhaniya Signed-off-by: Viken Dadhaniya --- .../net/can/spi/mcp251xfd/mcp251xfd-core.c | 91 ++++++++++++------- 1 file changed, 57 insertions(+), 34 deletions(-) diff --git a/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c b/drivers/net/c= an/spi/mcp251xfd/mcp251xfd-core.c index 7450ea42c1ea..f9eabb1810cf 100644 --- a/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c +++ b/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c @@ -767,21 +767,13 @@ static void mcp251xfd_chip_stop(struct mcp251xfd_priv= *priv, mcp251xfd_chip_interrupts_disable(priv); mcp251xfd_chip_rx_int_disable(priv); mcp251xfd_timestamp_stop(priv); - mcp251xfd_chip_sleep(priv); + mcp251xfd_chip_set_mode(priv, MCP251XFD_REG_CON_MODE_CONFIG); } =20 static int mcp251xfd_chip_start(struct mcp251xfd_priv *priv) { int err; =20 - err =3D mcp251xfd_chip_softreset(priv); - if (err) - goto out_chip_stop; - - err =3D mcp251xfd_chip_clock_init(priv); - if (err) - goto out_chip_stop; - err =3D mcp251xfd_chip_timestamp_init(priv); if (err) goto out_chip_stop; @@ -1625,8 +1617,11 @@ static int mcp251xfd_open(struct net_device *ndev) return err; =20 err =3D pm_runtime_resume_and_get(ndev->dev.parent); - if (err) + if (err) { + if (err =3D=3D -ETIMEDOUT || err =3D=3D -ENODEV) + pm_runtime_set_suspended(ndev->dev.parent); goto out_close_candev; + } =20 err =3D mcp251xfd_ring_alloc(priv); if (err) @@ -1907,53 +1902,53 @@ static int mcp251xfd_register(struct mcp251xfd_priv= *priv) struct net_device *ndev =3D priv->ndev; int err; =20 + mcp251xfd_register_quirks(priv); + err =3D mcp251xfd_clks_and_vdd_enable(priv); if (err) return err; =20 - pm_runtime_get_noresume(ndev->dev.parent); - err =3D pm_runtime_set_active(ndev->dev.parent); - if (err) - goto out_runtime_put_noidle; - pm_runtime_enable(ndev->dev.parent); - - mcp251xfd_register_quirks(priv); - err =3D mcp251xfd_chip_softreset(priv); if (err =3D=3D -ENODEV) - goto out_runtime_disable; + goto out_clks_and_vdd_disable; if (err) goto out_chip_sleep; =20 err =3D mcp251xfd_chip_clock_init(priv); if (err =3D=3D -ENODEV) - goto out_runtime_disable; + goto out_clks_and_vdd_disable; if (err) goto out_chip_sleep; =20 + pm_runtime_get_noresume(ndev->dev.parent); + err =3D pm_runtime_set_active(ndev->dev.parent); + if (err) + goto out_runtime_put_noidle; + pm_runtime_enable(ndev->dev.parent); + err =3D mcp251xfd_register_chip_detect(priv); if (err) - goto out_chip_sleep; + goto out_runtime_disable; =20 err =3D mcp251xfd_register_check_rx_int(priv); if (err) - goto out_chip_sleep; + goto out_runtime_disable; =20 mcp251xfd_ethtool_init(priv); =20 err =3D register_candev(ndev); if (err) - goto out_chip_sleep; + goto out_runtime_disable; =20 err =3D mcp251xfd_register_done(priv); if (err) goto out_unregister_candev; =20 - /* Put controller into sleep mode and let pm_runtime_put() - * disable the clocks and vdd. If CONFIG_PM is not enabled, - * the clocks and vdd will stay powered. + /* Put controller into Config mode and let pm_runtime_put() + * put in sleep mode, disable the clocks and vdd. If CONFIG_PM + * is not enabled, the clocks and vdd will stay powered. */ - err =3D mcp251xfd_chip_sleep(priv); + err =3D mcp251xfd_chip_set_mode(priv, MCP251XFD_REG_CON_MODE_CONFIG); if (err) goto out_unregister_candev; =20 @@ -1963,12 +1958,13 @@ static int mcp251xfd_register(struct mcp251xfd_priv= *priv) =20 out_unregister_candev: unregister_candev(ndev); -out_chip_sleep: - mcp251xfd_chip_sleep(priv); out_runtime_disable: pm_runtime_disable(ndev->dev.parent); out_runtime_put_noidle: pm_runtime_put_noidle(ndev->dev.parent); +out_chip_sleep: + mcp251xfd_chip_sleep(priv); +out_clks_and_vdd_disable: mcp251xfd_clks_and_vdd_disable(priv); =20 return err; @@ -1980,10 +1976,12 @@ static inline void mcp251xfd_unregister(struct mcp2= 51xfd_priv *priv) =20 unregister_candev(ndev); =20 - if (pm_runtime_enabled(ndev->dev.parent)) + if (pm_runtime_enabled(ndev->dev.parent)) { pm_runtime_disable(ndev->dev.parent); - else + } else { + mcp251xfd_chip_sleep(priv); mcp251xfd_clks_and_vdd_disable(priv); + } } =20 static const struct of_device_id mcp251xfd_of_match[] =3D { @@ -2206,16 +2204,41 @@ static void mcp251xfd_remove(struct spi_device *spi) =20 static int __maybe_unused mcp251xfd_runtime_suspend(struct device *device) { - const struct mcp251xfd_priv *priv =3D dev_get_drvdata(device); + struct mcp251xfd_priv *priv =3D dev_get_drvdata(device); =20 + mcp251xfd_chip_sleep(priv); return mcp251xfd_clks_and_vdd_disable(priv); } =20 static int __maybe_unused mcp251xfd_runtime_resume(struct device *device) { - const struct mcp251xfd_priv *priv =3D dev_get_drvdata(device); + struct mcp251xfd_priv *priv =3D dev_get_drvdata(device); + int err; + + err =3D mcp251xfd_clks_and_vdd_enable(priv); + if (err) + return err; =20 - return mcp251xfd_clks_and_vdd_enable(priv); + err =3D mcp251xfd_chip_softreset(priv); + if (err =3D=3D -ENODEV) + goto out_clks_and_vdd_disable; + if (err) + goto out_chip_sleep; + + err =3D mcp251xfd_chip_clock_init(priv); + if (err =3D=3D -ENODEV) + goto out_clks_and_vdd_disable; + if (err) + goto out_chip_sleep; + + return 0; + +out_chip_sleep: + mcp251xfd_chip_sleep(priv); +out_clks_and_vdd_disable: + mcp251xfd_clks_and_vdd_disable(priv); + + return err; } =20 static const struct dev_pm_ops mcp251xfd_pm_ops =3D { --=20 2.34.1