From nobody Wed Oct 1 23:30:05 2025 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AFF72F9D91 for ; Fri, 26 Sep 2025 13:11:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758892306; cv=none; b=tjwwse3mcq66y075JbNFFcL7G3noMyKD5M62nMhvywRda0b3NUTfKFmYdyEToaghFjC9HPORSrQkgL30kV+Df7tH2t7grAxzTo8vqZVK2qmWMwXouuoX7SV7UiKBn5IBHXBCj8a6Ltrb/MRU/wvcRRaYX5D9265umfSvInfn2h0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758892306; c=relaxed/simple; bh=K3KdMz7C2S+sjjhpcJ2VrrH58ALa5ic8heuJ7M4ymXs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=n/uGYJYGJpAK1YsTlz6iGc0j1VgSYWKFfuU3JnxMxOeS/VNU9ngXFLvnH53rS0OxnBEFox7glIxEYWfSTVPZnraZMuglX3TI2Sl1T/teVkq5xeT4eu0KAX5qbFw74g2CawPDE16b2R7JYos8tA8OQq/PbEgca173DNPecdIWGI0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=mSIAMbl3; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="mSIAMbl3" Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-57d8ff3944dso2221608e87.3 for ; Fri, 26 Sep 2025 06:11:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1758892295; x=1759497095; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=yK5cgdjGWBYF8FS7tGEMMwrGVxWyiTSoe6v1uuSmXRU=; b=mSIAMbl3eTr+7VxRl3P0MNZWVUQCXmyAjlkt5xOkpMbeNLAm9uAl2J4pO453MmOiyC eR5BMfA+XUNGxAiTsSzXwXqHSZzFU9i+OYryqN1Jl1ZL6RtN9qcT+nxc2ooHY/hse2s3 ulTqMpeG3GcGMWldTAcmsbyQxrV4t+Q/9ig48= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758892295; x=1759497095; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yK5cgdjGWBYF8FS7tGEMMwrGVxWyiTSoe6v1uuSmXRU=; b=k08a8tfJ1xYrRgmTpDJBmnZtQ2OW/ExBfmdvDv2D/w8+lVpz0R59gi1OZhZsir3xh7 jSV0Iz6rtcU69jbyDvfy1vQVKD3FS0aCaW1Entglnix4n/Y0Gt62jfrSQGRVTj15Uv4+ dn82/0Bd4tGeL8i5EEvc/r7CCvayfNtzlvCuSJDJ/N7lLts6MByXEg8fFYoej01rMnwa qAKc29WikdB/NZQwJZc8lNBX/hZ7C3nBb3Tu1v682GqM+GH+gv5AgpcwstuXotk44Hjj +6DeKU2PVrK5u+oDYsDtTwFmBW+sl/64PMR3ryffBH1eQpfygs4PWTmB2/aaLI5pxbax erUg== X-Forwarded-Encrypted: i=1; AJvYcCUGWzdxilIvLRNjecM+1p+G6mOnSwYQlwJjaD+4tEE3zYHdySGtDz57OElF8KpukPhthfRa4AX/W86+abo=@vger.kernel.org X-Gm-Message-State: AOJu0YykkwE6tHJL38bvjRcCdzDEtp+/GH+GrfOLssN3l6YCh+YHgMDU Q9xbuKYfpTISVvr+B89+hzv8QM8vOzVTxfMmmuMzzuxNPSsmyRLzsJh4zGeynf4OoA== X-Gm-Gg: ASbGnctMJk2Q25QWrIwihdb7EKhKykhfDJ21X40lvGGUd1czCgNPyZMXlIwONjwGcWo ZQn20VhEfnl+SvDBA+NpWKYBElyEVvczFSLtf6zk1/BQwasBHTyRzBsLCf1vOBJWCoRTeceeV37 iZMjZhI2cbyiB/oz+oju/DKt2DnAciuxJ2PklMXO1cHDJhVpQo6f1DcXZMo1k+LZLg1JEQqBpmx rjwYbzgm4l5h8ldcf4L0wL3WG7imgi81FI4OeiNZSHY8Ln5kS2xZQelkTJ7QgDt+tbJ226SFcX4 yr9Fd0a40yn2I28h1+U1jyRmykh+HjHMKbVXzb5l/GlAMFA7PbjVudvDIIarcNT20J4Z2YKV04e T2kNTkkEUvzm9OkQ/v/rTT6aCaWS0SF1QzyYyf476jPy4LTS6x5DlMqH8BiUYn+Jh65Zb32Zqap 1RqoNZCZYkYN+e X-Google-Smtp-Source: AGHT+IGFsjXQDMDVCJ1rn/evMz3fd3PTtDOlV/BZM7pcfvKWARbqj04ku2ig/REcBSICwb5/1B/aQQ== X-Received: by 2002:a05:6512:23a8:b0:57b:3600:8b4b with SMTP id 2adb3069b0e04-582d092964emr2268576e87.7.1758892295046; Fri, 26 Sep 2025 06:11:35 -0700 (PDT) Received: from ribalda.c.googlers.com (64.153.228.35.bc.googleusercontent.com. [35.228.153.64]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-58527c6b014sm123872e87.43.2025.09.26.06.11.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Sep 2025 06:11:34 -0700 (PDT) From: Ricardo Ribalda Date: Fri, 26 Sep 2025 13:11:33 +0000 Subject: [PATCH v3 09/12] media: uvcvideo: Fill ctrl->info.selector earlier Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250926-uvc-orientation-v3-9-6dc2fa5b4220@chromium.org> References: <20250926-uvc-orientation-v3-0-6dc2fa5b4220@chromium.org> In-Reply-To: <20250926-uvc-orientation-v3-0-6dc2fa5b4220@chromium.org> To: Hans de Goede , Laurent Pinchart , Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Bartosz Golaszewski , "Rafael J. Wysocki" , Len Brown , Robert Moore , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org, acpica-devel@lists.linux.dev, Ricardo Ribalda X-Mailer: b4 0.14.2 This is a preparation patch. A future helper will remove the selector argument and use the information embedded in the uvc_control structure. Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uvc/uvc_ctrl.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_c= trl.c index aa9de84de9236540c46ee78fb8458873d503786e..98e454fcdeb2ee36d334068fd75= 0e6203931699d 100644 --- a/drivers/media/usb/uvc/uvc_ctrl.c +++ b/drivers/media/usb/uvc/uvc_ctrl.c @@ -2720,7 +2720,8 @@ static void uvc_ctrl_fixup_xu_info(struct uvc_device = *dev, * Query control information (size and flags) for XU controls. */ static int uvc_ctrl_fill_xu_info(struct uvc_device *dev, - const struct uvc_control *ctrl, struct uvc_control_info *info) + struct uvc_control *ctrl, + struct uvc_control_info *info) { u8 *data; int ret; @@ -2733,6 +2734,9 @@ static int uvc_ctrl_fill_xu_info(struct uvc_device *d= ev, info->index =3D ctrl->index; info->selector =3D ctrl->index + 1; =20 + /* We need to fill info.selector to get the flags and the length. */ + ctrl->info.selector =3D info->selector; + /* Query and verify the control length (GET_LEN) */ ret =3D uvc_query_ctrl(dev, UVC_GET_LEN, ctrl->entity->id, dev->intfnum, info->selector, data, 2); --=20 2.51.0.536.g15c5d4f767-goog