From nobody Wed Oct 1 23:30:06 2025 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14EA12F6590 for ; Fri, 26 Sep 2025 13:11:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758892301; cv=none; b=j3vlckvZ0BuMk/CeA7bNVOSyHFtyTj1d/gYf1SzV94fxTBLHTanOPKag6oMDo686bIR6EXeAsAYfWPq3HLY6hRuSh6ox4MyUENpXnKcA0ZMW0iYyJHthwEO1Vl6HrkW+LNx4CKzci8AtIheDtyT1KsZemUwRSr8XGv/necrKPAE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758892301; c=relaxed/simple; bh=uQKx1xhIU5eIYcqCEj+wgLYNzIbICgNjQdDV8Jtr5o0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TfulOl1rZzkRjGQWJr/VIAqvF91TlfeF6aFVOOv36RgBtR/Tzomw+x3eK+Jjz3fpXxaMLicrVerhczfHm6y+AOoX0PYzx9YGSsTneFmx+m9GHx8qYOdWFHu7CsBkUmCIqVRZrTwUmDBFYSkuRwFl35/qDuvEMRcb6qJ706gugW4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=WIUId/8i; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="WIUId/8i" Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-57a604fecb4so2646058e87.1 for ; Fri, 26 Sep 2025 06:11:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1758892293; x=1759497093; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=LZ2xc23cnAfVOxiaEtcKmtjDZaiDvCUR7nAT9mLWhLU=; b=WIUId/8iT+6SwyIGvX3TRYP4VupuoS0vQG83UY55JuPAK4lj/4jhPJMhCIp7cHPIwh s+ru4i3wDIGi/NSn+UJ7TJF0Rw23gsui1BQL9MqgyJk2o1FPGQQrEgKR8dWyYzzr4JGf bn+VDC1rE7OFfTOIIzoMOZLZeGqSNlDIaX6SY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758892293; x=1759497093; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LZ2xc23cnAfVOxiaEtcKmtjDZaiDvCUR7nAT9mLWhLU=; b=tzyq6Gc1MoYe1mq1FaIIi9qZoX+yZq7ru45IzsU1tEZHrP1N9MXMRBJmebWuGORCTu iDvTZ5WZywMrzQJ2eloPtWgs7wrCMlv8mJjlEQSE00plu8KqZK6wshXLfQDjqPin3O51 h8iSbHKxHZky3F25FUmognXvzRmhbEYTI48+ggCfMqNTd8ha8Ag1PIAb5arXynpkBCEw YLv5lDy46IOHLZ09t9OxiKKCAzQEz6Abu66frTWlmUbkA6RBndFwvEwzBfzXBhKRVm6B bnPPE84sVtif4B/D1jH8u5NYs8W+ThdX8ed8N3w5i8HkpHnX9r3PR6MoW6N7G+tPE2hv /bvQ== X-Forwarded-Encrypted: i=1; AJvYcCVD9cTVcwSYuYZUTifn2k8fN1lNpXtPldG87vj1tMzOy/Q58MgN6YF1WV0+LFiYB9eqhPkxB9luMVp3tCU=@vger.kernel.org X-Gm-Message-State: AOJu0YzlbwGDqn6N7ZhM9sp5bDx8/qA6z1MTIxO+9lPzjaTfP0KbFyQs pNTLMW5I7TBZ91Rop9v9FAAtK1SPeeRX5f8S+PH7SS6YEMWqNU9M3cwr7WAPxU6lQQ== X-Gm-Gg: ASbGncuk9w2+RFuk1EFvoi75bHgukFeWwIzzEa8zetURaNgEseSSPPQr8cWgoboNQcY G0IS4Wkl9daC0gcu3gLe4XfhG046ioO1zSB8rIt5R+VHqm6LnIl+SR2fzaDkNErvYbv+INWslIV owq4JoVTsDwCL+5zu1AEftgsRr4Ms8R4ZjoEXKYXq47EcobKQd/yrkUTRC4UUC778AVgCFexV3m WRccvbIUGOapzwErCJCnn/Z8QHAdhAfReoU7kTP8Y6D2iNxcqwpSzTTNBPHWhL1ItRK9/qLCc87 tmsAVybguEqk38S5DEc+srDDQSLM8kB9WUIGFDbS4cL0uinc+qgdToJ/5uB7gIO70nGRZ+eUoRh vfpsvWK3dKUQWu8eD3tFlFglnYfXTNAQNWNEKPBWe8ho1zUodtcrLP2PE+uqlz65VPhOCLwxQkM iMk+gWi9UtwNtH+7CXBDN4jA8= X-Google-Smtp-Source: AGHT+IEc/rDB1XIEkZ7T9M5CIKlYJn+bt+sf74IR95Ks98OS/SI0N6MNxqx7nWfz1ihO3nPV6De8mw== X-Received: by 2002:ac2:4183:0:b0:584:2ad8:7ce3 with SMTP id 2adb3069b0e04-5842ad87e22mr755887e87.22.1758892292551; Fri, 26 Sep 2025 06:11:32 -0700 (PDT) Received: from ribalda.c.googlers.com (64.153.228.35.bc.googleusercontent.com. [35.228.153.64]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-58527c6b014sm123872e87.43.2025.09.26.06.11.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Sep 2025 06:11:32 -0700 (PDT) From: Ricardo Ribalda Date: Fri, 26 Sep 2025 13:11:29 +0000 Subject: [PATCH v3 05/12] media: ipu-bridge: Use v4l2_fwnode_device_parse helper Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250926-uvc-orientation-v3-5-6dc2fa5b4220@chromium.org> References: <20250926-uvc-orientation-v3-0-6dc2fa5b4220@chromium.org> In-Reply-To: <20250926-uvc-orientation-v3-0-6dc2fa5b4220@chromium.org> To: Hans de Goede , Laurent Pinchart , Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Bartosz Golaszewski , "Rafael J. Wysocki" , Len Brown , Robert Moore , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org, acpica-devel@lists.linux.dev, Ricardo Ribalda X-Mailer: b4 0.14.2 v4l2_fwnode_device_parse now supports ACPI devices as well. Use the helper instead of re-implement the logic. Signed-off-by: Ricardo Ribalda --- drivers/media/pci/intel/Kconfig | 1 + drivers/media/pci/intel/ipu-bridge.c | 42 +++++++++++---------------------= ---- 2 files changed, 14 insertions(+), 29 deletions(-) diff --git a/drivers/media/pci/intel/Kconfig b/drivers/media/pci/intel/Kcon= fig index d9fcddce028bf736557e2c6c289d4f8056d80756..69e3108ba02c4f0bc56b0e26ddc= e9f86775099f6 100644 --- a/drivers/media/pci/intel/Kconfig +++ b/drivers/media/pci/intel/Kconfig @@ -8,6 +8,7 @@ config IPU_BRIDGE tristate "Intel IPU Bridge" depends on ACPI || COMPILE_TEST depends on I2C + select V4L2_FWNODE help The IPU bridge is a helper library for Intel IPU drivers to function on systems shipped with Windows. diff --git a/drivers/media/pci/intel/ipu-bridge.c b/drivers/media/pci/intel= /ipu-bridge.c index 4e579352ab2c0be656576fa223429432940747d8..441d1a5979fe94bee4738da68e1= 85a44dbd411d4 100644 --- a/drivers/media/pci/intel/ipu-bridge.c +++ b/drivers/media/pci/intel/ipu-bridge.c @@ -257,42 +257,22 @@ static u32 ipu_bridge_parse_rotation(struct acpi_devi= ce *adev, } } =20 -static enum v4l2_fwnode_orientation ipu_bridge_parse_orientation(struct ac= pi_device *adev) +static enum v4l2_fwnode_orientation +ipu_bridge_parse_orientation(struct acpi_device *adev, + struct v4l2_fwnode_device_properties *props) { - enum v4l2_fwnode_orientation orientation; - struct acpi_pld_info *pld =3D NULL; - - if (!acpi_get_physical_device_location(ACPI_PTR(adev->handle), &pld)) { - dev_warn(ADEV_DEV(adev), "_PLD call failed, using default orientation\n"= ); + if (props->orientation =3D=3D V4L2_FWNODE_PROPERTY_UNSET) { + acpi_handle_warn(acpi_device_handle(adev), + "Using default orientation\n"); return V4L2_FWNODE_ORIENTATION_EXTERNAL; } =20 - switch (pld->panel) { - case ACPI_PLD_PANEL_FRONT: - orientation =3D V4L2_FWNODE_ORIENTATION_FRONT; - break; - case ACPI_PLD_PANEL_BACK: - orientation =3D V4L2_FWNODE_ORIENTATION_BACK; - break; - case ACPI_PLD_PANEL_TOP: - case ACPI_PLD_PANEL_LEFT: - case ACPI_PLD_PANEL_RIGHT: - case ACPI_PLD_PANEL_UNKNOWN: - orientation =3D V4L2_FWNODE_ORIENTATION_EXTERNAL; - break; - default: - dev_warn(ADEV_DEV(adev), "Unknown _PLD panel val %d\n", - pld->panel); - orientation =3D V4L2_FWNODE_ORIENTATION_EXTERNAL; - break; - } - - ACPI_FREE(pld); - return orientation; + return props->orientation; } =20 int ipu_bridge_parse_ssdb(struct acpi_device *adev, struct ipu_sensor *sen= sor) { + struct v4l2_fwnode_device_properties props; struct ipu_sensor_ssdb ssdb =3D {}; int ret; =20 @@ -300,6 +280,10 @@ int ipu_bridge_parse_ssdb(struct acpi_device *adev, st= ruct ipu_sensor *sensor) if (ret) return ret; =20 + ret =3D v4l2_fwnode_device_parse(ADEV_DEV(adev), &props); + if (ret) + return ret; + if (ssdb.vcmtype > ARRAY_SIZE(ipu_vcm_types)) { dev_warn(ADEV_DEV(adev), "Unknown VCM type %d\n", ssdb.vcmtype); ssdb.vcmtype =3D 0; @@ -314,7 +298,7 @@ int ipu_bridge_parse_ssdb(struct acpi_device *adev, str= uct ipu_sensor *sensor) sensor->lanes =3D ssdb.lanes; sensor->mclkspeed =3D ssdb.mclkspeed; sensor->rotation =3D ipu_bridge_parse_rotation(adev, &ssdb); - sensor->orientation =3D ipu_bridge_parse_orientation(adev); + sensor->orientation =3D ipu_bridge_parse_orientation(adev, &props); =20 if (ssdb.vcmtype) sensor->vcm_type =3D ipu_vcm_types[ssdb.vcmtype - 1]; --=20 2.51.0.536.g15c5d4f767-goog