From nobody Wed Oct 1 23:30:08 2025 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 276EE2F616D for ; Fri, 26 Sep 2025 13:11:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758892297; cv=none; b=KeYRpLy4zMzbEgy0EYHsM5vuKpGYsE6Qll35p37WwPPDLsgLiEhPIOyuqEeBDT0Sc2vt5ZdxbKX/TdY6EBvzNxrypc1CJIlpOdmT9Rtdq1TMYsVUYRYInRDrDvdBTflMo1CRHPLs5v0A93OzeRcIz4/j8qu90e3sFQmpyYd1/6o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758892297; c=relaxed/simple; bh=80G8sSF8+f0UAG0XdkLdvNrCi6HOOZflBRDxb6bYpC4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cB/QtPixRjS1d1+tS7aBaPE9TteXmbJmWVJnpkDjXlcoOXjA/HFzv8cvVedZ1MZJdLfcgFJJk9mTq42nnTOixFxgqO3CN1lNJBGZ3vF9gM9M9MnH1N7yT8dqcoLc+12FPr0tgEQP+xUQlA7+L5jxb2HWpVD1nP/4EPhwQEz3XqY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Ek5B5R6n; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Ek5B5R6n" Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-57edfeaa05aso2333740e87.0 for ; Fri, 26 Sep 2025 06:11:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1758892292; x=1759497092; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=LO+ZRHeTAK51LRbge1abR5CWq6P2opiI+XHVYGi/IpE=; b=Ek5B5R6n55TSnFKW0GuBypFweQw8X4sOVkixEjA4uyqhsvIn6ccW6DzZmT/t1ZxIpq KV4V0Le5Yd95VxYU1TIFCUhpW5v7iogHPO1YvW182Iee7j/QfExD7vmseSG/CWTsRX+7 g6EV2uP4aswmFDEfn316QTgEvYGOIMVCsu7bg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758892292; x=1759497092; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LO+ZRHeTAK51LRbge1abR5CWq6P2opiI+XHVYGi/IpE=; b=tPUGKZNZ0tmIWnZTRvdjL61OqAvs97SK+pybqvZwIASzyso8LRawMmJ9e+LNK2D74I XhXfC6aSOYYFc4ny3xTYS55h912IWmwLuMegZKnkbdDl/ivRgWQqLKAK3bCTswbgjz2z YePLrjb6S7kxRHaNORJiJeFfKUs/0wzChULRMNuE5w5uQJhP/9bx8tLlHli21TSsHy/E GzJRUoBFY/PVbVWoSPqp7xUD2lLw4fpM0HSZgxJNX6HeqVeaZr6trIKk+7+rb4f+3u8P k0yTtTj8RBAOhKFZ04xQRHQ8oaUQvjnw73Wpcvxw/gP6WvpZbpsg3TTvho6LckrmS/s1 eykA== X-Forwarded-Encrypted: i=1; AJvYcCUELlnqc3sChyLe3om1qrLN3gXULbL/xWw1IaSg5vjmnlWAorEP+EDZ38qf9FQ7TryeC3tyW9/ta5Xv1jc=@vger.kernel.org X-Gm-Message-State: AOJu0Yz6GlCa9avD4CNhXmOXDEOIVTRsBx58rTrnMU0rp8F0dBUa6Q4b OnAi3+a7eWgChBGA0YYz/gWM13E+SCSN043FoUHi/X2t+uHYgyY8YwdXpD9d+KpRwV8dcJzY0r9 o2JGdFw== X-Gm-Gg: ASbGncukpbb+9ZKIFmsDa/Gq0X7GVKqNotvwkGxs4rJIR1FzQWVqvy9Mf8ReoOvqUoX XNNxBmDMPDYSiK+QJUkT6OF5lVdKC8Nx7nQiZBDGpBpK1jWvRSlGQ/OcqB3lmDMt1t8obEbkKBU PVqyjis+Tmw4UJoFwL6C9xIZnOePwoCbJevA07uL0ImolFgm49ym4LyCKd/qgqLC+45oTFl9/JE c9FdK46CDbdkK7I2NCl+agFFow1FHewdfzZBioFNASIheaGHH9u0xze1VbAM4baqq+HuzQE2f5+ EtrPOYYwjKwrNoZ71GD+atca+sRqtVnZkEN77U1XQJyNjL5AOeRS7SxjMdoEv9OIeqQ8MM3snXI SEXW33xJjI85BPYqloEfbyyvfsegRe6FoXiBT/JMO8LQdoP0m5iOplmDdH30WhZ/pQdYE3iFN1D NyGg== X-Google-Smtp-Source: AGHT+IEKOz9hLF8FHkWrsyP0/Z6mTRW5uekYu6y0CaJ96qJRiudQJlAsNVVlhQMiizZElwgvlCzXEQ== X-Received: by 2002:a05:6512:b12:b0:57a:310:66a8 with SMTP id 2adb3069b0e04-582d35df2d7mr2404401e87.55.1758892291516; Fri, 26 Sep 2025 06:11:31 -0700 (PDT) Received: from ribalda.c.googlers.com (64.153.228.35.bc.googleusercontent.com. [35.228.153.64]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-58527c6b014sm123872e87.43.2025.09.26.06.11.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Sep 2025 06:11:30 -0700 (PDT) From: Ricardo Ribalda Date: Fri, 26 Sep 2025 13:11:27 +0000 Subject: [PATCH v3 03/12] media: v4l: fwnode: Support ACPI's _PLD for v4l2_fwnode_device_parse Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250926-uvc-orientation-v3-3-6dc2fa5b4220@chromium.org> References: <20250926-uvc-orientation-v3-0-6dc2fa5b4220@chromium.org> In-Reply-To: <20250926-uvc-orientation-v3-0-6dc2fa5b4220@chromium.org> To: Hans de Goede , Laurent Pinchart , Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Bartosz Golaszewski , "Rafael J. Wysocki" , Len Brown , Robert Moore , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org, acpica-devel@lists.linux.dev, Ricardo Ribalda X-Mailer: b4 0.14.2 Currently v4l2_fwnode_device_parse() obtains the orientation and rotation via fwnode properties. Extend the function to support as well ACPI devices with _PLD info. We give a higher priority to fwnode, because it might contain quirks injected via swnodes. Reviewed-by: Hans de Goede Signed-off-by: Ricardo Ribalda --- drivers/media/v4l2-core/v4l2-fwnode.c | 84 +++++++++++++++++++++++++++++++= +--- 1 file changed, 78 insertions(+), 6 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-fwnode.c b/drivers/media/v4l2-cor= e/v4l2-fwnode.c index cb153ce42c45d69600a3ec4e59a5584d7e791a2a..4110f64d3277e652473f991fb58= d191862f98eb0 100644 --- a/drivers/media/v4l2-core/v4l2-fwnode.c +++ b/drivers/media/v4l2-core/v4l2-fwnode.c @@ -15,6 +15,7 @@ * Author: Guennadi Liakhovetski */ #include +#include #include #include #include @@ -807,16 +808,69 @@ int v4l2_fwnode_connector_add_link(struct fwnode_hand= le *fwnode, } EXPORT_SYMBOL_GPL(v4l2_fwnode_connector_add_link); =20 -int v4l2_fwnode_device_parse(struct device *dev, - struct v4l2_fwnode_device_properties *props) +static int v4l2_fwnode_device_parse_acpi(struct device *dev, + struct v4l2_fwnode_device_properties *props) +{ + struct acpi_pld_info *pld; + int ret =3D 0; + + if (!is_acpi_device_node(dev_fwnode(dev))) + return 0; + + if (!acpi_get_physical_device_location(ACPI_HANDLE(dev), &pld)) { + acpi_handle_debug(ACPI_HANDLE(dev), "cannot obtain _PLD\n"); + return 0; + } + + if (props->orientation =3D=3D V4L2_FWNODE_PROPERTY_UNSET) { + switch (pld->panel) { + case ACPI_PLD_PANEL_FRONT: + props->orientation =3D V4L2_FWNODE_ORIENTATION_FRONT; + break; + case ACPI_PLD_PANEL_BACK: + props->orientation =3D V4L2_FWNODE_ORIENTATION_BACK; + break; + case ACPI_PLD_PANEL_TOP: + case ACPI_PLD_PANEL_LEFT: + case ACPI_PLD_PANEL_RIGHT: + case ACPI_PLD_PANEL_UNKNOWN: + props->orientation =3D V4L2_FWNODE_ORIENTATION_EXTERNAL; + break; + default: + acpi_handle_warn(ACPI_HANDLE(dev), + "invalid panel %u in _PLD\n", + pld->panel); + ret =3D -EINVAL; + goto done; + } + } + + if (props->rotation =3D=3D V4L2_FWNODE_PROPERTY_UNSET) { + switch (pld->rotation) { + case 0 ... 7: + props->rotation =3D pld->rotation * 45; + break; + default: + acpi_handle_warn(ACPI_HANDLE(dev), + "invalid rotation %u in _PLD\n", + pld->rotation); + ret =3D -EINVAL; + goto done; + } + } + +done: + ACPI_FREE(pld); + return ret; +} + +static int v4l2_fwnode_device_parse_of(struct device *dev, + struct v4l2_fwnode_device_properties *props) { struct fwnode_handle *fwnode =3D dev_fwnode(dev); u32 val; int ret; =20 - memset(props, 0, sizeof(*props)); - - props->orientation =3D V4L2_FWNODE_PROPERTY_UNSET; ret =3D fwnode_property_read_u32(fwnode, "orientation", &val); if (!ret) { switch (val) { @@ -833,7 +887,6 @@ int v4l2_fwnode_device_parse(struct device *dev, dev_dbg(dev, "device orientation: %u\n", val); } =20 - props->rotation =3D V4L2_FWNODE_PROPERTY_UNSET; ret =3D fwnode_property_read_u32(fwnode, "rotation", &val); if (!ret) { if (val >=3D 360) { @@ -847,6 +900,25 @@ int v4l2_fwnode_device_parse(struct device *dev, =20 return 0; } + +int v4l2_fwnode_device_parse(struct device *dev, + struct v4l2_fwnode_device_properties *props) +{ + int ret; + + memset(props, 0, sizeof(*props)); + + props->orientation =3D V4L2_FWNODE_PROPERTY_UNSET; + props->rotation =3D V4L2_FWNODE_PROPERTY_UNSET; + + /* Start by looking into swnodes and DT. */ + ret =3D v4l2_fwnode_device_parse_of(dev, props); + if (ret) + return ret; + + /* Let's check the ACPI table. */ + return v4l2_fwnode_device_parse_acpi(dev, props); +} EXPORT_SYMBOL_GPL(v4l2_fwnode_device_parse); =20 /* --=20 2.51.0.536.g15c5d4f767-goog