From nobody Wed Oct 1 23:30:09 2025 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BA382F5A3E for ; Fri, 26 Sep 2025 13:11:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758892295; cv=none; b=AzyruEHf1yMTf7tsT5a9XsOmvKuJV1lzL7tUI9bRuzbDuxWvAR75CEJbB0lBdX91fEt0kkIVrRhhTrl3mpxXOpJCV+1SeN2Ag+AcazE6zvHPg44vLX+Ka/kS6SBrznFbeuNStyITHOOBhrLdtXnbunSzgJIeZGHMcKTUBGbzUfM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758892295; c=relaxed/simple; bh=fN1yQSZa9dGNYApiBN9DJ0yzGqYY3io2zaEeifTv+AY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NsLt8+1qVmptgBUhQDUYKlPNjplwAvgYdui+N9Suvy4P6PI7VanYpkPkAgpcSVSKLU56M1KsAR7iaRU3ZrOUPaBzvhaJry0DcA5DR3JWCsDCd6HDSr/eKfsxq4cD+ruk/2mL/CQ9aX9GgGNx4IcrWFk9e88QQiR0KLU464/vLmk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=fbfy3VJj; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="fbfy3VJj" Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-57f0aa38aadso2716014e87.2 for ; Fri, 26 Sep 2025 06:11:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1758892290; x=1759497090; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=nuHd6eGYommvO3UskpqEqtJdP8+N3udV7UPBSp5lsjc=; b=fbfy3VJjC1yaYytPKZzTYRVoy+OCnUkOEtEIUZ3x3cYqigUyyXha5Va4UzDiOILmAI z/9bf24ITk1PxUsoK1WCTsDg7wY0GXAeUPCKIViGPcEP9BCiaDJ+LwEYvb6cDV8LIwkb D5w2rHp5jiXapkSCe1hEBuefH3fRV5/UiEHiY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758892290; x=1759497090; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nuHd6eGYommvO3UskpqEqtJdP8+N3udV7UPBSp5lsjc=; b=HtpQbs28CMM+7+uVDTRv6yWmVGMmj5PGZydFmwqCd9MlDgfOduvWDJl8b35obr4a16 WYO8PVNVSSILWI3GmDDfUJyz0yT0F+RfiFRY9130LnkPVhaOFQAk1aTLTaXzjhQkxozX s/9cZfxC36WnUw1G3rrDI44a3yYJpM/3o95vKkRZ1FaUs5P4Mg0FPzbDLqHYD7IuC50d fiTfRC+hVRSUKvkcOoRDN5bgJeU8WR38nvyiQdgGsC0D+MtFX2rDFNkZCjyOjyCq4f2a w/7mWd1ysgQFRejDPUnvAS/2rkLMcM6bUYkBjHv7LTU7dA6In6sjQK/jWAOXbPtR5UHo 7E1g== X-Forwarded-Encrypted: i=1; AJvYcCV+9gEIDOnC46ju3cNbY3AdMntAK1z5x9k4ls5UzAhB4toQuX60Cemg8/c+rTn2Cf/MqJRDnXmHhOqcT00=@vger.kernel.org X-Gm-Message-State: AOJu0YxYZmItkgdJGmxLB6pmBdxj8mMIKnli6YEAXaLC3/qhPcmUgjY5 v9JVo4NK23OQaOv7TVpwULyeMl/+Yxr/ucDSU8vuWfpr3PWpoM2yEeWCE4+kiRy+qQ== X-Gm-Gg: ASbGncupFPm6mQgHCgfiRIvNFq/hzgaEHrPL3FeWoJ5Su/vQZ+SaxHpJ5kh8I1Czrze oYvj88qnMUSGVTK9ys6fj21kI71fQmtE2uFBEvFVJUer1jFKWd817ZJdp83k4Sagn/R1YYo/6U0 b1qp38ji03T+NR1jK4AWeoU3aaNyyw4fDALd/fgimnhdJW+mbAq7DDPGlMffbxCE7B2T4wq4O5W lbLo6OtfdZp9uRSXa5mUnxoecN5/dANbxwDRkhQ1aY7oD+0Gcs1PF9EY1sjZj9fdOfgFotBYE/T FBkRig5Z7DJDQj7W0kiLgKnLJMW+FXR2CrYfaIFm3XrfBVJ0uq9Y15QuNZCMRNLD6C39UGVYABu opWZvXmNNqv1qoPWOD0sgHclgNAQor+fn1099lgIVUMhdrSQpJ7y9HyxnWo0S8iBn7pECVSkpv5 uTwEOUeBjbO5JASyUbkrz+cJs= X-Google-Smtp-Source: AGHT+IGBibbMbWnp4wsYYpcAZc4iOvKmHvOhd0/KxBOtu8sk83ypjF+oQ0w3P1LE9KQVYZ/8hnbPDg== X-Received: by 2002:a05:6512:61b1:b0:57c:2474:3743 with SMTP id 2adb3069b0e04-582d2f24dbfmr2344139e87.32.1758892290146; Fri, 26 Sep 2025 06:11:30 -0700 (PDT) Received: from ribalda.c.googlers.com (64.153.228.35.bc.googleusercontent.com. [35.228.153.64]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-58527c6b014sm123872e87.43.2025.09.26.06.11.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Sep 2025 06:11:29 -0700 (PDT) From: Ricardo Ribalda Date: Fri, 26 Sep 2025 13:11:25 +0000 Subject: [PATCH v3 01/12] media: uvcvideo: Always set default_value Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250926-uvc-orientation-v3-1-6dc2fa5b4220@chromium.org> References: <20250926-uvc-orientation-v3-0-6dc2fa5b4220@chromium.org> In-Reply-To: <20250926-uvc-orientation-v3-0-6dc2fa5b4220@chromium.org> To: Hans de Goede , Laurent Pinchart , Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Bartosz Golaszewski , "Rafael J. Wysocki" , Len Brown , Robert Moore , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org, acpica-devel@lists.linux.dev, Ricardo Ribalda , stable@vger.kernel.org X-Mailer: b4 0.14.2 If the control does not support GET_DEF, the field default_value will be left uninitialized during queryctrl. Fixes: c0efd232929c ("V4L/DVB (8145a): USB Video Class driver") Cc: stable@vger.kernel.org Reviewed-by: Laurent Pinchart Reviewed-by: Hans de Goede Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uvc/uvc_ctrl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_c= trl.c index 2905505c240c060e5034ea12d33b59d5702f2e1f..a869257e9b7c07eaa7d725d107b= d1cb57d3c7377 100644 --- a/drivers/media/usb/uvc/uvc_ctrl.c +++ b/drivers/media/usb/uvc/uvc_ctrl.c @@ -1542,10 +1542,11 @@ static int __uvc_queryctrl_boundaries(struct uvc_vi= deo_chain *chain, return ret; } =20 - if (ctrl->info.flags & UVC_CTRL_FLAG_GET_DEF) { + if (ctrl->info.flags & UVC_CTRL_FLAG_GET_DEF) v4l2_ctrl->default_value =3D uvc_mapping_get_s32(mapping, UVC_GET_DEF, uvc_ctrl_data(ctrl, UVC_CTRL_DATA_DEF)); - } + else + v4l2_ctrl->default_value =3D 0; =20 switch (mapping->v4l2_type) { case V4L2_CTRL_TYPE_MENU: --=20 2.51.0.536.g15c5d4f767-goog