From nobody Wed Oct 1 23:35:13 2025 Received: from srv01.abscue.de (abscue.de [89.58.28.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C5C323506F; Fri, 26 Sep 2025 16:34:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=89.58.28.240 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758904476; cv=none; b=s1TyUQy/x/tgPFGsw2oDvkoxbyqto5XJIKwN4tDWXJXY4zY6UxnfRltY6h0xkz3MlUGsUKbGFicsFjEkuTnd6ONvCXO6dLkGZ+xnV/9tcnJnyUlxtW5kROqYamFCX20SYdUbKcgNBaf64Yt8XMEMVpJ38znPkO6HhlkRt8P2trE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758904476; c=relaxed/simple; bh=AZlUcOk3yWypTJbdqtn01NgPo10tnHCQOEM37R4XTQw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fS6KWBDIKYtOD3oRHyozOAa60OFLpDD9n/DF5Ys2ucqaqmnpiiDhaWTEFzDAY0aNR0xj1WlCJSeWCDr/uU2W6MN3d9ikOTZ1J17roKRGXp6DvA5UOsTeWTCXQTUaz5iuhQByFlb+FncdsuuiYQn/GsFvdsqpt2iPAr8BfU04uX0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=abscue.de; spf=pass smtp.mailfrom=abscue.de; arc=none smtp.client-ip=89.58.28.240 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=abscue.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=abscue.de Received: from srv01.abscue.de (localhost [127.0.0.1]) by spamfilter.srv.local (Postfix) with ESMTP id C1BF61C24F2; Fri, 26 Sep 2025 18:27:08 +0200 (CEST) X-Spam-Level: Received: from fluffy-mammal.metal.fwg-cag.de (unknown [IPv6:2001:9e8:cdf8:0:ec51:b786:a581:3dd1]) by srv01.abscue.de (Postfix) with ESMTPSA id A85EB1C2509; Fri, 26 Sep 2025 18:27:07 +0200 (CEST) From: =?utf-8?q?Otto_Pfl=C3=BCger?= Date: Fri, 26 Sep 2025 18:23:26 +0200 Subject: [PATCH 4/5] power: reset: sc27xx: Add support for SC2730 and OF match table Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250926-sc2730-reboot-v1-4-62ebfd3d31bb@abscue.de> References: <20250926-sc2730-reboot-v1-0-62ebfd3d31bb@abscue.de> In-Reply-To: <20250926-sc2730-reboot-v1-0-62ebfd3d31bb@abscue.de> To: Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Orson Zhai , Baolin Wang , Chunyan Zhang , Lee Jones Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?Otto_Pfl=C3=BCger?= X-Mailer: b4 0.14.2 Add register definitions for the SC2730 PMIC. Introduce a new struct sc27xx_poweroff_data for passing register information to the poweroff handler. Implement device tree matching to distinguish between SC2730 and SC2731 and to probe the driver automatically. Signed-off-by: Otto Pfl=C3=BCger --- drivers/power/reset/sc27xx-poweroff.c | 67 +++++++++++++++++++++++++++++--= ---- 1 file changed, 57 insertions(+), 10 deletions(-) diff --git a/drivers/power/reset/sc27xx-poweroff.c b/drivers/power/reset/sc= 27xx-poweroff.c index 20eb9f32cb2b99adeb16502172adf9d6257cd05f..5937f40021817ea38453705fcef= 6485ce79ac14c 100644 --- a/drivers/power/reset/sc27xx-poweroff.c +++ b/drivers/power/reset/sc27xx-poweroff.c @@ -7,16 +7,33 @@ #include #include #include +#include #include #include #include #include #include =20 -#define SC27XX_PWR_PD_HW 0xc2c +#define SC2730_PWR_PD_HW 0x1820 +#define SC2730_SLP_CTRL 0x1a48 +#define SC2730_LDO_XTL_EN BIT(2) + +#define SC2731_PWR_PD_HW 0xc2c +#define SC2731_SLP_CTRL 0xdf0 +#define SC2731_LDO_XTL_EN BIT(3) + #define SC27XX_PWR_OFF_EN BIT(0) -#define SC27XX_SLP_CTRL 0xdf0 -#define SC27XX_LDO_XTL_EN BIT(3) + +struct sc27xx_poweroff_reg_info { + u32 poweroff_reg; + u32 slp_ctrl_reg; + u32 ldo_xtl_en; +}; + +struct sc27xx_poweroff_data { + struct regmap *regmap; + const struct sc27xx_poweroff_reg_info *regs; +}; =20 /* * On Spreadtrum platform, we need power off system through external SC27xx @@ -45,12 +62,14 @@ static struct syscore_ops poweroff_syscore_ops =3D { =20 static int sc27xx_poweroff_do_poweroff(struct sys_off_data *off_data) { - struct regmap *regmap =3D off_data->cb_data; + struct sc27xx_poweroff_data *data =3D off_data->cb_data; =20 /* Disable the external subsys connection's power firstly */ - regmap_write(regmap, SC27XX_SLP_CTRL, SC27XX_LDO_XTL_EN); + regmap_write(data->regmap, data->regs->slp_ctrl_reg, + data->regs->ldo_xtl_en); =20 - regmap_write(regmap, SC27XX_PWR_PD_HW, SC27XX_PWR_OFF_EN); + regmap_write(data->regmap, data->regs->poweroff_reg, + SC27XX_PWR_OFF_EN); =20 mdelay(1000); =20 @@ -61,10 +80,18 @@ static int sc27xx_poweroff_do_poweroff(struct sys_off_d= ata *off_data) =20 static int sc27xx_poweroff_probe(struct platform_device *pdev) { - struct regmap *regmap; + struct sc27xx_poweroff_data *data; =20 - regmap =3D dev_get_regmap(pdev->dev.parent, NULL); - if (!regmap) + data =3D devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL); + if (!data) + return -ENOMEM; + + data->regs =3D of_device_get_match_data(&pdev->dev); + if (!data->regs) + return -EINVAL; + + data->regmap =3D dev_get_regmap(pdev->dev.parent, NULL); + if (!data->regmap) return -ENODEV; =20 register_syscore_ops(&poweroff_syscore_ops); @@ -73,13 +100,33 @@ static int sc27xx_poweroff_probe(struct platform_devic= e *pdev) SYS_OFF_MODE_POWER_OFF, SYS_OFF_PRIO_DEFAULT, sc27xx_poweroff_do_poweroff, - regmap); + data); } =20 +static const struct sc27xx_poweroff_reg_info sc2730_pwr_regs =3D { + .poweroff_reg =3D SC2730_PWR_PD_HW, + .slp_ctrl_reg =3D SC2730_SLP_CTRL, + .ldo_xtl_en =3D SC2730_LDO_XTL_EN, +}; + +static const struct sc27xx_poweroff_reg_info sc2731_pwr_regs =3D { + .poweroff_reg =3D SC2731_PWR_PD_HW, + .slp_ctrl_reg =3D SC2731_SLP_CTRL, + .ldo_xtl_en =3D SC2731_LDO_XTL_EN, +}; + +static const struct of_device_id sc27xx_poweroff_of_match[] =3D { + { .compatible =3D "sprd,sc2730-poweroff", .data =3D &sc2730_pwr_regs }, + { .compatible =3D "sprd,sc2731-poweroff", .data =3D &sc2731_pwr_regs }, + { } +}; +MODULE_DEVICE_TABLE(of, sc27xx_poweroff_of_match); + static struct platform_driver sc27xx_poweroff_driver =3D { .probe =3D sc27xx_poweroff_probe, .driver =3D { .name =3D "sc27xx-poweroff", + .of_match_table =3D sc27xx_poweroff_of_match, }, }; module_platform_driver(sc27xx_poweroff_driver); --=20 2.50.0