From nobody Wed Oct 1 22:35:16 2025 Received: from srv01.abscue.de (abscue.de [89.58.28.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C63025FA13; Fri, 26 Sep 2025 16:34:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=89.58.28.240 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758904476; cv=none; b=sgqpZJzW3reyXZhvBL0zMvYAP/gwOCkej3ffYIvLZ5GEZPNy1rCdzjbskH4nj/Js+afyXGKddBbsLd9TIShMc1B62GgwbodgZqT/S1+kbXye/bmHJEkadEbAxrYKSHSLl/ttOLvEW/Q1qC8eWhKLq18Yn5qmGoTAnOkKjI4C4rw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758904476; c=relaxed/simple; bh=oXkc1mfL4g8qM9nxD4BWhq+wPzuIHLgEwoVPEI/0SdE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=laLACBB9fOCMcJocd6NepHeItYJYIDkNjMKDZDv2v+Cn2QFV35tp4I3QC//79E5Xq9QwIkKlDYUzb7Jd3lFeeqhyj47WA47wJ72fI7nRwqc7gCr6q8VyuBcErkIOJv6mboM8avDk80xi6JvVTRYES2n3a11QC2UfWJCi2V9U5Y4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=abscue.de; spf=pass smtp.mailfrom=abscue.de; arc=none smtp.client-ip=89.58.28.240 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=abscue.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=abscue.de Received: from srv01.abscue.de (localhost [127.0.0.1]) by spamfilter.srv.local (Postfix) with ESMTP id D88CA1C2506; Fri, 26 Sep 2025 18:27:06 +0200 (CEST) X-Spam-Level: Received: from fluffy-mammal.metal.fwg-cag.de (unknown [IPv6:2001:9e8:cdf8:0:ec51:b786:a581:3dd1]) by srv01.abscue.de (Postfix) with ESMTPSA id 3544E1C24F2; Fri, 26 Sep 2025 18:27:06 +0200 (CEST) From: =?utf-8?q?Otto_Pfl=C3=BCger?= Date: Fri, 26 Sep 2025 18:23:23 +0200 Subject: [PATCH 1/5] dt-bindings: power: reset: Add SC27xx series PMIC poweroff Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250926-sc2730-reboot-v1-1-62ebfd3d31bb@abscue.de> References: <20250926-sc2730-reboot-v1-0-62ebfd3d31bb@abscue.de> In-Reply-To: <20250926-sc2730-reboot-v1-0-62ebfd3d31bb@abscue.de> To: Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Orson Zhai , Baolin Wang , Chunyan Zhang , Lee Jones Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?Otto_Pfl=C3=BCger?= X-Mailer: b4 0.14.2 Add power off bindings for the Unisoc SC27xx series PMICs, such as SC2731 and SC2730. Signed-off-by: Otto Pfl=C3=BCger --- .../bindings/power/reset/sprd,sc2731-poweroff.yaml | 22 ++++++++++++++++++= ++++ 1 file changed, 22 insertions(+) diff --git a/Documentation/devicetree/bindings/power/reset/sprd,sc2731-powe= roff.yaml b/Documentation/devicetree/bindings/power/reset/sprd,sc2731-power= off.yaml new file mode 100644 index 0000000000000000000000000000000000000000..2db8bee47e17863b9a0d7af4945= d3c32e67122ce --- /dev/null +++ b/Documentation/devicetree/bindings/power/reset/sprd,sc2731-poweroff.ya= ml @@ -0,0 +1,22 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/power/reset/sprd,sc2731-poweroff.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Unisoc SC27xx series PMIC power off + +maintainers: + - Otto Pfl=C3=BCger + +properties: + compatible: + enum: + - sprd,sc2730-poweroff + - sprd,sc2731-poweroff + +required: + - compatible + +additionalProperties: false +... --=20 2.50.0 From nobody Wed Oct 1 22:35:16 2025 Received: from srv01.abscue.de (abscue.de [89.58.28.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C55A202F7B; Fri, 26 Sep 2025 16:34:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=89.58.28.240 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758904474; cv=none; b=qgdk+zKPwnG4JuK0f42xPlZjuabZNdkunEjD+A+iDq6nEDXUqaeZWJRcygUcaH954MJYzGT5gyx/X47HAxBprN+IibZ7158QlWDwfeMp2Shw4VA0T5wIYdY9oE2KJfU/PaLWy/zDDPHv5Jt9yeLuTk/UycynJ4Gfxf7t5PeWKNs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758904474; c=relaxed/simple; bh=tgqsf4Ecr3URSbxtzrxUja8Hphhy7XTQA2zzZlWR61k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PaSg3Z+cyhtFBfggRQb9dH2cMlg5VgWicyz2maZ2Z0MhGNNgUc5m2/B3B7zj+jxNEqtUj0TGt4bFwcANig+Ts6UD4ox1zkzCIomFcyiyK94atgtqXnuaCr7vZ4RKamm2rs6wMB+ejessJG0/+76Ar7kwdbqieplStf0imW/dxdM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=abscue.de; spf=pass smtp.mailfrom=abscue.de; arc=none smtp.client-ip=89.58.28.240 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=abscue.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=abscue.de Received: from srv01.abscue.de (localhost [127.0.0.1]) by spamfilter.srv.local (Postfix) with ESMTP id 42A1F1C2508; Fri, 26 Sep 2025 18:27:07 +0200 (CEST) X-Spam-Level: Received: from fluffy-mammal.metal.fwg-cag.de (unknown [IPv6:2001:9e8:cdf8:0:ec51:b786:a581:3dd1]) by srv01.abscue.de (Postfix) with ESMTPSA id A47B91C2505; Fri, 26 Sep 2025 18:27:06 +0200 (CEST) From: =?utf-8?q?Otto_Pfl=C3=BCger?= Date: Fri, 26 Sep 2025 18:23:24 +0200 Subject: [PATCH 2/5] dt-bindings: mfd: sc2731: Reference sprd,sc2731-poweroff Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250926-sc2730-reboot-v1-2-62ebfd3d31bb@abscue.de> References: <20250926-sc2730-reboot-v1-0-62ebfd3d31bb@abscue.de> In-Reply-To: <20250926-sc2730-reboot-v1-0-62ebfd3d31bb@abscue.de> To: Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Orson Zhai , Baolin Wang , Chunyan Zhang , Lee Jones Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?Otto_Pfl=C3=BCger?= X-Mailer: b4 0.14.2 Reference the new sprd,sc2731-poweroff bindings and add an example. Signed-off-by: Otto Pfl=C3=BCger --- Documentation/devicetree/bindings/mfd/sprd,sc2731.yaml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/mfd/sprd,sc2731.yaml b/Docum= entation/devicetree/bindings/mfd/sprd,sc2731.yaml index b023e1ef8d3ccdb1d82d64ed1a60d5a712a1b910..a78d7e26b3a2c77b84da84fc23e= 52f3a22ab14df 100644 --- a/Documentation/devicetree/bindings/mfd/sprd,sc2731.yaml +++ b/Documentation/devicetree/bindings/mfd/sprd,sc2731.yaml @@ -52,6 +52,10 @@ properties: '#size-cells': const: 0 =20 + poweroff: + type: object + $ref: /schemas/power/reset/sprd,sc2731-poweroff.yaml# + regulators: type: object $ref: /schemas/regulator/sprd,sc2731-regulator.yaml# @@ -221,6 +225,10 @@ examples: reg =3D <0xec8>; }; =20 + poweroff { + compatible =3D "sprd,sc2731-poweroff"; + }; + regulators { compatible =3D "sprd,sc2731-regulator"; =20 --=20 2.50.0 From nobody Wed Oct 1 22:35:16 2025 Received: from srv01.abscue.de (abscue.de [89.58.28.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C6FE2BE7A0; Fri, 26 Sep 2025 16:34:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=89.58.28.240 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758904475; cv=none; b=JY6OqOnRGrbxKNID5FQawRYJzOOMLmoo6tpiq1tUV/KuAyrBcgipDOoCK1nplElLtfP91MbVKW9fanRxvwuCIaQ/BDy8qtjqdNV1KHYnFk9VTbcxZYyO8jDYz55rUN9jmeRRj7+9GGImlZwrLKb2rXM5f6qaQ2bRECtUV2GyPYg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758904475; c=relaxed/simple; bh=FtRZJ7yjU3jMPC+zB+Ol2wV3rFXTZyfaPut+5IasyA4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=W6TWs/qN0DA0qEuN19f8lwoNSz7hGOe/HQEdnYMS0dbun96RYQMrovbyUgHklovmIpSFP4a6LOqZuBJx3rg2rF1Kjz6ZHjwRglZtOAOJFY3vBfH6AX6Af4i7OzGuA53blh186alRheD7z838HL8yOyGI4t826DN5Y0tu5lzFTA0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=abscue.de; spf=pass smtp.mailfrom=abscue.de; arc=none smtp.client-ip=89.58.28.240 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=abscue.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=abscue.de Received: from srv01.abscue.de (localhost [127.0.0.1]) by spamfilter.srv.local (Postfix) with ESMTP id 863DC1C250B; Fri, 26 Sep 2025 18:27:08 +0200 (CEST) X-Spam-Level: Received: from fluffy-mammal.metal.fwg-cag.de (unknown [IPv6:2001:9e8:cdf8:0:ec51:b786:a581:3dd1]) by srv01.abscue.de (Postfix) with ESMTPSA id 29CD31C2507; Fri, 26 Sep 2025 18:27:07 +0200 (CEST) From: =?utf-8?q?Otto_Pfl=C3=BCger?= Date: Fri, 26 Sep 2025 18:23:25 +0200 Subject: [PATCH 3/5] power: reset: sc27xx: Use devm_register_sys_off_handler Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250926-sc2730-reboot-v1-3-62ebfd3d31bb@abscue.de> References: <20250926-sc2730-reboot-v1-0-62ebfd3d31bb@abscue.de> In-Reply-To: <20250926-sc2730-reboot-v1-0-62ebfd3d31bb@abscue.de> To: Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Orson Zhai , Baolin Wang , Chunyan Zhang , Lee Jones Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?Otto_Pfl=C3=BCger?= X-Mailer: b4 0.14.2 Use the new device life-cycle managed register function to remove the need for global variables in the driver. Signed-off-by: Otto Pfl=C3=BCger Reviewed-by: Baolin Wang --- drivers/power/reset/sc27xx-poweroff.c | 24 +++++++++++++++++------- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/drivers/power/reset/sc27xx-poweroff.c b/drivers/power/reset/sc= 27xx-poweroff.c index 90287c31992c4889f9241e82a21a1949ecca7702..20eb9f32cb2b99adeb16502172a= df9d6257cd05f 100644 --- a/drivers/power/reset/sc27xx-poweroff.c +++ b/drivers/power/reset/sc27xx-poweroff.c @@ -9,6 +9,7 @@ #include #include #include +#include #include #include =20 @@ -17,8 +18,6 @@ #define SC27XX_SLP_CTRL 0xdf0 #define SC27XX_LDO_XTL_EN BIT(3) =20 -static struct regmap *regmap; - /* * On Spreadtrum platform, we need power off system through external SC27xx * series PMICs, and it is one similar SPI bus mapped by regmap to access = PMIC, @@ -44,26 +43,37 @@ static struct syscore_ops poweroff_syscore_ops =3D { .shutdown =3D sc27xx_poweroff_shutdown, }; =20 -static void sc27xx_poweroff_do_poweroff(void) +static int sc27xx_poweroff_do_poweroff(struct sys_off_data *off_data) { + struct regmap *regmap =3D off_data->cb_data; + /* Disable the external subsys connection's power firstly */ regmap_write(regmap, SC27XX_SLP_CTRL, SC27XX_LDO_XTL_EN); =20 regmap_write(regmap, SC27XX_PWR_PD_HW, SC27XX_PWR_OFF_EN); + + mdelay(1000); + + pr_emerg("Unable to poweroff system\n"); + + return NOTIFY_DONE; } =20 static int sc27xx_poweroff_probe(struct platform_device *pdev) { - if (regmap) - return -EINVAL; + struct regmap *regmap; =20 regmap =3D dev_get_regmap(pdev->dev.parent, NULL); if (!regmap) return -ENODEV; =20 - pm_power_off =3D sc27xx_poweroff_do_poweroff; register_syscore_ops(&poweroff_syscore_ops); - return 0; + + return devm_register_sys_off_handler(&pdev->dev, + SYS_OFF_MODE_POWER_OFF, + SYS_OFF_PRIO_DEFAULT, + sc27xx_poweroff_do_poweroff, + regmap); } =20 static struct platform_driver sc27xx_poweroff_driver =3D { --=20 2.50.0 From nobody Wed Oct 1 22:35:16 2025 Received: from srv01.abscue.de (abscue.de [89.58.28.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C5C323506F; Fri, 26 Sep 2025 16:34:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=89.58.28.240 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758904476; cv=none; b=s1TyUQy/x/tgPFGsw2oDvkoxbyqto5XJIKwN4tDWXJXY4zY6UxnfRltY6h0xkz3MlUGsUKbGFicsFjEkuTnd6ONvCXO6dLkGZ+xnV/9tcnJnyUlxtW5kROqYamFCX20SYdUbKcgNBaf64Yt8XMEMVpJ38znPkO6HhlkRt8P2trE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758904476; c=relaxed/simple; bh=AZlUcOk3yWypTJbdqtn01NgPo10tnHCQOEM37R4XTQw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fS6KWBDIKYtOD3oRHyozOAa60OFLpDD9n/DF5Ys2ucqaqmnpiiDhaWTEFzDAY0aNR0xj1WlCJSeWCDr/uU2W6MN3d9ikOTZ1J17roKRGXp6DvA5UOsTeWTCXQTUaz5iuhQByFlb+FncdsuuiYQn/GsFvdsqpt2iPAr8BfU04uX0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=abscue.de; spf=pass smtp.mailfrom=abscue.de; arc=none smtp.client-ip=89.58.28.240 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=abscue.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=abscue.de Received: from srv01.abscue.de (localhost [127.0.0.1]) by spamfilter.srv.local (Postfix) with ESMTP id C1BF61C24F2; Fri, 26 Sep 2025 18:27:08 +0200 (CEST) X-Spam-Level: Received: from fluffy-mammal.metal.fwg-cag.de (unknown [IPv6:2001:9e8:cdf8:0:ec51:b786:a581:3dd1]) by srv01.abscue.de (Postfix) with ESMTPSA id A85EB1C2509; Fri, 26 Sep 2025 18:27:07 +0200 (CEST) From: =?utf-8?q?Otto_Pfl=C3=BCger?= Date: Fri, 26 Sep 2025 18:23:26 +0200 Subject: [PATCH 4/5] power: reset: sc27xx: Add support for SC2730 and OF match table Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250926-sc2730-reboot-v1-4-62ebfd3d31bb@abscue.de> References: <20250926-sc2730-reboot-v1-0-62ebfd3d31bb@abscue.de> In-Reply-To: <20250926-sc2730-reboot-v1-0-62ebfd3d31bb@abscue.de> To: Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Orson Zhai , Baolin Wang , Chunyan Zhang , Lee Jones Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?Otto_Pfl=C3=BCger?= X-Mailer: b4 0.14.2 Add register definitions for the SC2730 PMIC. Introduce a new struct sc27xx_poweroff_data for passing register information to the poweroff handler. Implement device tree matching to distinguish between SC2730 and SC2731 and to probe the driver automatically. Signed-off-by: Otto Pfl=C3=BCger --- drivers/power/reset/sc27xx-poweroff.c | 67 +++++++++++++++++++++++++++++--= ---- 1 file changed, 57 insertions(+), 10 deletions(-) diff --git a/drivers/power/reset/sc27xx-poweroff.c b/drivers/power/reset/sc= 27xx-poweroff.c index 20eb9f32cb2b99adeb16502172adf9d6257cd05f..5937f40021817ea38453705fcef= 6485ce79ac14c 100644 --- a/drivers/power/reset/sc27xx-poweroff.c +++ b/drivers/power/reset/sc27xx-poweroff.c @@ -7,16 +7,33 @@ #include #include #include +#include #include #include #include #include #include =20 -#define SC27XX_PWR_PD_HW 0xc2c +#define SC2730_PWR_PD_HW 0x1820 +#define SC2730_SLP_CTRL 0x1a48 +#define SC2730_LDO_XTL_EN BIT(2) + +#define SC2731_PWR_PD_HW 0xc2c +#define SC2731_SLP_CTRL 0xdf0 +#define SC2731_LDO_XTL_EN BIT(3) + #define SC27XX_PWR_OFF_EN BIT(0) -#define SC27XX_SLP_CTRL 0xdf0 -#define SC27XX_LDO_XTL_EN BIT(3) + +struct sc27xx_poweroff_reg_info { + u32 poweroff_reg; + u32 slp_ctrl_reg; + u32 ldo_xtl_en; +}; + +struct sc27xx_poweroff_data { + struct regmap *regmap; + const struct sc27xx_poweroff_reg_info *regs; +}; =20 /* * On Spreadtrum platform, we need power off system through external SC27xx @@ -45,12 +62,14 @@ static struct syscore_ops poweroff_syscore_ops =3D { =20 static int sc27xx_poweroff_do_poweroff(struct sys_off_data *off_data) { - struct regmap *regmap =3D off_data->cb_data; + struct sc27xx_poweroff_data *data =3D off_data->cb_data; =20 /* Disable the external subsys connection's power firstly */ - regmap_write(regmap, SC27XX_SLP_CTRL, SC27XX_LDO_XTL_EN); + regmap_write(data->regmap, data->regs->slp_ctrl_reg, + data->regs->ldo_xtl_en); =20 - regmap_write(regmap, SC27XX_PWR_PD_HW, SC27XX_PWR_OFF_EN); + regmap_write(data->regmap, data->regs->poweroff_reg, + SC27XX_PWR_OFF_EN); =20 mdelay(1000); =20 @@ -61,10 +80,18 @@ static int sc27xx_poweroff_do_poweroff(struct sys_off_d= ata *off_data) =20 static int sc27xx_poweroff_probe(struct platform_device *pdev) { - struct regmap *regmap; + struct sc27xx_poweroff_data *data; =20 - regmap =3D dev_get_regmap(pdev->dev.parent, NULL); - if (!regmap) + data =3D devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL); + if (!data) + return -ENOMEM; + + data->regs =3D of_device_get_match_data(&pdev->dev); + if (!data->regs) + return -EINVAL; + + data->regmap =3D dev_get_regmap(pdev->dev.parent, NULL); + if (!data->regmap) return -ENODEV; =20 register_syscore_ops(&poweroff_syscore_ops); @@ -73,13 +100,33 @@ static int sc27xx_poweroff_probe(struct platform_devic= e *pdev) SYS_OFF_MODE_POWER_OFF, SYS_OFF_PRIO_DEFAULT, sc27xx_poweroff_do_poweroff, - regmap); + data); } =20 +static const struct sc27xx_poweroff_reg_info sc2730_pwr_regs =3D { + .poweroff_reg =3D SC2730_PWR_PD_HW, + .slp_ctrl_reg =3D SC2730_SLP_CTRL, + .ldo_xtl_en =3D SC2730_LDO_XTL_EN, +}; + +static const struct sc27xx_poweroff_reg_info sc2731_pwr_regs =3D { + .poweroff_reg =3D SC2731_PWR_PD_HW, + .slp_ctrl_reg =3D SC2731_SLP_CTRL, + .ldo_xtl_en =3D SC2731_LDO_XTL_EN, +}; + +static const struct of_device_id sc27xx_poweroff_of_match[] =3D { + { .compatible =3D "sprd,sc2730-poweroff", .data =3D &sc2730_pwr_regs }, + { .compatible =3D "sprd,sc2731-poweroff", .data =3D &sc2731_pwr_regs }, + { } +}; +MODULE_DEVICE_TABLE(of, sc27xx_poweroff_of_match); + static struct platform_driver sc27xx_poweroff_driver =3D { .probe =3D sc27xx_poweroff_probe, .driver =3D { .name =3D "sc27xx-poweroff", + .of_match_table =3D sc27xx_poweroff_of_match, }, }; module_platform_driver(sc27xx_poweroff_driver); --=20 2.50.0 From nobody Wed Oct 1 22:35:16 2025 Received: from srv01.abscue.de (abscue.de [89.58.28.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C69626CE0C; Fri, 26 Sep 2025 16:34:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=89.58.28.240 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758904475; cv=none; b=AxnjINWSzOjMs2uozQI4jbm6moWspPsPs2q4G6GwcHY4z7UEtBa2GTjN44eNnLYbIQMrbGHwrLKzcxofrY3arJRBoX9xQa0tciVLBrNgSe7cxea6eoaxwPJgJ8r1/xuEL8e5amKwG9js9AylTSwoQBeT7gkNmPj/gircnP7mpng= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758904475; c=relaxed/simple; bh=O5aJKIVrAbTQR2ETxQmeGB5vf+e0C6aBqzUs+KBSS5M=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Sq4JwTPtnhIjPPnieI4IcT6rXfBgf1FAaK1GvqTdr8nScNUbReXGmCsyj6hndtX7lAoKJyMJYXB/5i+4TgVx/svHdhdovG3r4V2Ij3MApTZ7IX/BnIJbQZhocNYof2hg1rcleMnQIOjg2VA36ASmFfLrSvATpGqoIBgBCohMK0k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=abscue.de; spf=pass smtp.mailfrom=abscue.de; arc=none smtp.client-ip=89.58.28.240 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=abscue.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=abscue.de Received: from srv01.abscue.de (localhost [127.0.0.1]) by spamfilter.srv.local (Postfix) with ESMTP id 1D4761C2505; Fri, 26 Sep 2025 18:27:09 +0200 (CEST) X-Spam-Level: Received: from fluffy-mammal.metal.fwg-cag.de (unknown [IPv6:2001:9e8:cdf8:0:ec51:b786:a581:3dd1]) by srv01.abscue.de (Postfix) with ESMTPSA id 4AB671C250A; Fri, 26 Sep 2025 18:27:08 +0200 (CEST) From: =?utf-8?q?Otto_Pfl=C3=BCger?= Date: Fri, 26 Sep 2025 18:23:27 +0200 Subject: [PATCH 5/5] power: reset: sc27xx: Add reboot support for SC2730 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250926-sc2730-reboot-v1-5-62ebfd3d31bb@abscue.de> References: <20250926-sc2730-reboot-v1-0-62ebfd3d31bb@abscue.de> In-Reply-To: <20250926-sc2730-reboot-v1-0-62ebfd3d31bb@abscue.de> To: Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Orson Zhai , Baolin Wang , Chunyan Zhang , Lee Jones Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?Otto_Pfl=C3=BCger?= X-Mailer: b4 0.14.2 Unlike SC2731, the SC2730 PMIC also provides dedicated registers for resetting the hardware. Use them to implement reboot support. Signed-off-by: Otto Pfl=C3=BCger --- drivers/power/reset/sc27xx-poweroff.c | 89 +++++++++++++++++++++++++++++++= ++++ 1 file changed, 89 insertions(+) diff --git a/drivers/power/reset/sc27xx-poweroff.c b/drivers/power/reset/sc= 27xx-poweroff.c index 5937f40021817ea38453705fcef6485ce79ac14c..1dfa54675b3e7b8b79212dc9950= d97b726dd5acc 100644 --- a/drivers/power/reset/sc27xx-poweroff.c +++ b/drivers/power/reset/sc27xx-poweroff.c @@ -18,16 +18,42 @@ #define SC2730_SLP_CTRL 0x1a48 #define SC2730_LDO_XTL_EN BIT(2) =20 +#define SC2730_SOFT_RST_HW 0x1824 +#define SC2730_RST_STATUS 0x1bac +#define SC2730_SWRST_CTRL0 0x1bf8 + #define SC2731_PWR_PD_HW 0xc2c #define SC2731_SLP_CTRL 0xdf0 #define SC2731_LDO_XTL_EN BIT(3) =20 #define SC27XX_PWR_OFF_EN BIT(0) +#define SC27XX_SOFT_RST_EN BIT(4) +#define SC27XX_RESET BIT(0) + +#define HWRST_STATUS_SECURITY 0x02 +#define HWRST_STATUS_RECOVERY 0x20 +#define HWRST_STATUS_NORMAL 0x40 +#define HWRST_STATUS_ALARM 0x50 +#define HWRST_STATUS_SLEEP 0x60 +#define HWRST_STATUS_FASTBOOT 0x30 +#define HWRST_STATUS_SPECIAL 0x70 +#define HWRST_STATUS_PANIC 0x80 +#define HWRST_STATUS_CFTREBOOT 0x90 +#define HWRST_STATUS_AUTODLOADER 0xa0 +#define HWRST_STATUS_IQMODE 0xb0 +#define HWRST_STATUS_SPRDISK 0xc0 +#define HWRST_STATUS_FACTORYTEST 0xe0 +#define HWRST_STATUS_WATCHDOG 0xf0 +#define HWRST_STATUS_MASK 0xf0 =20 struct sc27xx_poweroff_reg_info { u32 poweroff_reg; u32 slp_ctrl_reg; u32 ldo_xtl_en; + + u32 reset_reg; + u32 rst_sts_reg; + u32 swrst_ctrl_reg; }; =20 struct sc27xx_poweroff_data { @@ -78,9 +104,59 @@ static int sc27xx_poweroff_do_poweroff(struct sys_off_d= ata *off_data) return NOTIFY_DONE; } =20 +static int sc27xx_restart(struct sys_off_data *off_data) +{ + struct sc27xx_poweroff_data *data =3D off_data->cb_data; + u32 reboot_mode =3D 0; + + if (!off_data->cmd) + reboot_mode =3D HWRST_STATUS_NORMAL; + else if (!strcmp(off_data->cmd, "recovery")) + reboot_mode =3D HWRST_STATUS_RECOVERY; + else if (!strcmp(off_data->cmd, "alarm")) + reboot_mode =3D HWRST_STATUS_ALARM; + else if (!strcmp(off_data->cmd, "fastsleep")) + reboot_mode =3D HWRST_STATUS_SLEEP; + else if (!strcmp(off_data->cmd, "bootloader")) + reboot_mode =3D HWRST_STATUS_FASTBOOT; + else if (!strcmp(off_data->cmd, "panic")) + reboot_mode =3D HWRST_STATUS_PANIC; + else if (!strcmp(off_data->cmd, "special")) + reboot_mode =3D HWRST_STATUS_SPECIAL; + else if (!strcmp(off_data->cmd, "cftreboot")) + reboot_mode =3D HWRST_STATUS_CFTREBOOT; + else if (!strcmp(off_data->cmd, "autodloader")) + reboot_mode =3D HWRST_STATUS_AUTODLOADER; + else if (!strcmp(off_data->cmd, "iqmode")) + reboot_mode =3D HWRST_STATUS_IQMODE; + else if (!strcmp(off_data->cmd, "sprdisk")) + reboot_mode =3D HWRST_STATUS_SPRDISK; + else if (!strcmp(off_data->cmd, "tospanic")) + reboot_mode =3D HWRST_STATUS_SECURITY; + else if (!strcmp(off_data->cmd, "factorytest")) + reboot_mode =3D HWRST_STATUS_FACTORYTEST; + else + reboot_mode =3D HWRST_STATUS_NORMAL; + + regmap_update_bits(data->regmap, data->regs->rst_sts_reg, + HWRST_STATUS_MASK, reboot_mode); + + regmap_set_bits(data->regmap, data->regs->swrst_ctrl_reg, + SC27XX_SOFT_RST_EN); + + regmap_write(data->regmap, data->regs->reset_reg, SC27XX_RESET); + + mdelay(1000); + + pr_emerg("Unable to restart system\n"); + + return NOTIFY_DONE; +} + static int sc27xx_poweroff_probe(struct platform_device *pdev) { struct sc27xx_poweroff_data *data; + int ret; =20 data =3D devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL); if (!data) @@ -96,6 +172,15 @@ static int sc27xx_poweroff_probe(struct platform_device= *pdev) =20 register_syscore_ops(&poweroff_syscore_ops); =20 + if (data->regs->reset_reg) { + ret =3D devm_register_sys_off_handler(&pdev->dev, + SYS_OFF_MODE_RESTART, + 192, sc27xx_restart, + data); + if (ret) + return ret; + } + return devm_register_sys_off_handler(&pdev->dev, SYS_OFF_MODE_POWER_OFF, SYS_OFF_PRIO_DEFAULT, @@ -107,6 +192,10 @@ static const struct sc27xx_poweroff_reg_info sc2730_pw= r_regs =3D { .poweroff_reg =3D SC2730_PWR_PD_HW, .slp_ctrl_reg =3D SC2730_SLP_CTRL, .ldo_xtl_en =3D SC2730_LDO_XTL_EN, + + .reset_reg =3D SC2730_SOFT_RST_HW, + .rst_sts_reg =3D SC2730_RST_STATUS, + .swrst_ctrl_reg =3D SC2730_SWRST_CTRL0, }; =20 static const struct sc27xx_poweroff_reg_info sc2731_pwr_regs =3D { --=20 2.50.0