From nobody Wed Oct 1 23:34:14 2025 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11010052.outbound.protection.outlook.com [52.101.84.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 428B32AD3D; Fri, 26 Sep 2025 12:33:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.52 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758890029; cv=fail; b=buqrZqHmRecXdhtdgLJc9esxXE/Od5KjC8HlpnoTaKLDF9JRgnyLXtw2MhTBRZL2hrcIrODfgN88fKtcPgKsq9PUOTJFj/cES9jC/RkG7kRAV7mSW3W831qzC4Sx5mdzdCXTmAyE/ydU+oBdXzSSrQVrNcwgxkDqtobE9ErAxZ8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758890029; c=relaxed/simple; bh=ZpPFDG1/y8MbnfU9AnA/p0Y3iMPD9WKPsAGyJPHCRlY=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=HEvvrejEBD8O9teEBfZdsAi02NhIDnZDBVTPtw3DBXlxXugumZEsD+cNqQ9wgw8ojjnOwRaSNuW9DzctPsSp9jQIAaKcJ04RiDfOD06WUZOw48IwZ0iCEQyDhJYuDTDexNNvoa9xlfNNcEyBvyF476nflm7OClweuD8t3dERF0E= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=PCzBhtJQ; arc=fail smtp.client-ip=52.101.84.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="PCzBhtJQ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sFQ1CpUpzM7rlOqEaGZA2Wgw1nLPHnIjZdu/9hnIISO6MtTFU1k8Z0Gd4lKeJqyekmfg+IO4HGBk5aS8qU3ES0Z+x3ufjOPWrauEY5RYPv+o6xAugUNap03qrgxq65WKF9BJtd/i6NuCgHFuhd1/zWrFieQgDKyStXZ6jhyrTHcuAR0dHgoBaHjoqTLgP+iPle33GIkYS2UAmNqpwxMdtK6+QRCpDhF7krSLKUAGCk0lItsXg4NmfcdGFO5qHGALx9DAQ8TC1EjmfnIMvWNLRPUqyHZNxALhOmDV4fJsGQjcgcvekg+yjd+xj7xRKIYUdDR6rSGle0n6UOc6VDQPjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CyCCG6M9xq1Uqgji8WiDBeWdiBBxwmqHoO1yDEj8cdA=; b=skuflkzAddouuPFpOzgrDRhWq8MM801BXWmJIDEi3vKe6LNYx0v48zhOcHet5JeoMOaKywZRk4EdZaeMApiRhZP/3M4sVGlJxws7Spk6VVHsqZPZNzH6ItK7TcFYMY4/NkPYnI8dZo7R1f7jmiS07YYjnlnaHXnjkrvRL/nHcpvul1vvbv/G1krSKqHMc4AHb7+SXxZJZGEq2Lk7Bn0+M5JkrjL+zodl4VX4tUx5bVxEMc1oKm6MvarJgkmd4RAL8k3lMLk7ObcmsjlXp/rUPZq9Gav6ZRfXnz2n94Wk8R2qs7VSU9VU5GZMJTuFqjQeHFq3WVNHs5YIGI775QHnhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CyCCG6M9xq1Uqgji8WiDBeWdiBBxwmqHoO1yDEj8cdA=; b=PCzBhtJQiHsUPD+OOsdpt2BaDTtputKDwC0kVe2OBY/qv9pR+ZNWJhifJEt4TSHbWtJnvTkTvi1JtUwrljSWBJLg3GTmsZUAhpjRT4sR3BIZh0ykX8D0nu19CQMkHodt3MRewfk2QcNCuEgB3HA9hgktKIoIt7yiLLXMqdF5UzYZF83b/eSr2nJZF+OYKoXQsYN7oCKJASmJ266aigtsU9K6IepnO09nMqjWNznyRTMDUjAiCqv7UAeDcS3QHGPWKejAGK3fgldMchInt4zH5wPDZ9omuYVmGOPNV8AHNH63nNMhEYQcKZqboxeD1juEV7F6uMNpf5/nuCZoP80Aew== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by DB9PR04MB9646.eurprd04.prod.outlook.com (2603:10a6:10:30a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.13; Fri, 26 Sep 2025 12:33:43 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9160.010; Fri, 26 Sep 2025 12:33:42 +0000 From: Peng Fan Date: Fri, 26 Sep 2025 20:33:15 +0800 Subject: [PATCH v3 1/6] remoteproc: imx_rproc: Fix runtime PM cleanup and improve remove path Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250926-imx_rproc_v3-v3-1-4c0ec279cc5f@nxp.com> References: <20250926-imx_rproc_v3-v3-0-4c0ec279cc5f@nxp.com> In-Reply-To: <20250926-imx_rproc_v3-v3-0-4c0ec279cc5f@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Ulf Hansson , Hiago De Franco , Frank Li , Daniel Baluta Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1758890010; l=1807; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=ZpPFDG1/y8MbnfU9AnA/p0Y3iMPD9WKPsAGyJPHCRlY=; b=mmrCmeIVmfQxSTKLTR1sYsDoq+FLX0++hnytM6B6IShRxhc5ZOgp1rvsakqwON+DC8myDVWcr lgVgRRMCMTZBI4FKftMXh2uojRbgBDN9MguGNmTeNOEPPxukbAfWRSs X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR03CA0115.apcprd03.prod.outlook.com (2603:1096:4:91::19) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|DB9PR04MB9646:EE_ X-MS-Office365-Filtering-Correlation-Id: 8655cd34-430e-4c6d-cd07-08ddfcf8eda8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|19092799006|52116014|7416014|376014|1800799024|7053199007|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dHcyQ0ZFZGxpT1J2RVZDYUxKMGViOFg2RnQ1dFZHOVAvNGVqMUFSRTVkOG0w?= =?utf-8?B?UmhOU3JSRkN1dUNZcHpac1ptZy82SExmeDJSb0VKK1BqUzhuVVE5cXBaRk13?= =?utf-8?B?SS8xWE44NDc0L1NoanU0Wkl0TXJZVjJoV2ZhRWhmNExwSm8vbGNFaHFpYzFF?= =?utf-8?B?aG13eU9oWW56SlA1cHpWdDlWMmtGREhCVmY1aWZqWVcxLzJTWHdRNUhaTDIy?= =?utf-8?B?QTgvaDRza01lMTlSclZ4TmhRNkhGaDZnT1R6UUlUT3RnMUdxTUloMDAvK2lv?= =?utf-8?B?VDJuelNJUWZ2YjRkdFVNd3dCNzFaVUMzTVpJUVI3amh1U3d6TXo2NDVHZ1Rh?= =?utf-8?B?NEt1ZGM3ckxtcy9FaFdBWUxkQVJvUE43Yk16OWp4RVIwSjZLTmpTakNwWmpY?= =?utf-8?B?b0Jtb0tNa2pSd0RPNGRtM0dzWWg1RW81NDYwcmhlT2tHcmUwMnE0Z0M1MUxC?= =?utf-8?B?VjJrWFRiQTBIU21IdlNaVFkwdUJBOE0va3ZNbW5qdjVneUdUN1FTK3FjU2Jw?= =?utf-8?B?NFV0QTA1SllvUm5HakVUNERCZWRVWlBlOThURnpCZHN0eE5nMEJGVFJoMEJa?= =?utf-8?B?VHBHVitHbkMzQk8rSVZ2eVpWNzJPTUN0aGQvS2tyZWhlWFlkSFBGUVNTVFdj?= =?utf-8?B?NFhGLzhRTmZkZEVKbU9nQ1R1MFhkUEtpdlNZcWRDR3VwcjFKUGZSdFdVWTVj?= =?utf-8?B?RkZLSWJDbVZVWjk2ZndTSFdJY1c5Snl5UitNTERYVk1rWiszK1N6TlZJV1VG?= =?utf-8?B?bnlBK25KdTlWRVhGNjhIR1RFSFVUY3FFMGlydHllTTlRSGVjRUl4YjdLd0hH?= =?utf-8?B?b3RXcHVzdVRzblB5WFhYcXdudGlFNnVWWVlkTWRKaEI1ODl3Y25jQlI4NmxC?= =?utf-8?B?S1BRSTUzS0c4MElYVTJkR0llcHRZWTNwd3NHc2prWllCVFdhaFIrQ2svQlph?= =?utf-8?B?UklsUmx2a3hkbjhpcmZOQ1Y2TzNuMFhxT3kzbUJQb2hycEczZklranhqYnhs?= =?utf-8?B?Z2RGK3UwNGJHTWxYSzMrS1BXVjBVL1JpalpsNWtScDk5NHJmc3V5d3VSLzkw?= =?utf-8?B?WVg0a0FMZE9tdC9EY1lKc2R1RXZ0UzZKSTJXVnpKNzA5djNKOVhWbExGOTRQ?= =?utf-8?B?WjZHcm5QaFhLYXZMVlFGTGFpRU9RMUtZVk1OMTVhbUpOT2JENWNZSzdYQ2JW?= =?utf-8?B?T0hLTldhOE1uZEFVZzRkWjFQMnlzNSs5eGNvTGw4RStEeFNoaS9YLzJHbFd0?= =?utf-8?B?bGJISStnS0RwL0dHLy8xV0V3N0NielkzdGs2azdFWmtxQkV1d1ZVQ01xR3V1?= =?utf-8?B?cWE4NFkrNk5YRk9OZUVob0NVeGJVQzBHV1JzWURDRjZwNGY4RU11OTJhT1lK?= =?utf-8?B?Nk1TV2xZZHRFS3JZOGVzd1RZNUFXbyt1Z2tLSVU0bFFiS2hjeDdPZ1J1K0pH?= =?utf-8?B?UWZmd0NVQTdNNndaTVNIT2NscXNpNVdpT0hEWHBhS21rVGRxL1JhclIrcTM1?= =?utf-8?B?Uk1VZ3ZUblVJQkdHaGpFUFlMcFNFNXpsVHAybUJraHVJQmZXYnM0cjI2am4v?= =?utf-8?B?dEpqUzg0c1JvdnAxa0owYXlHNFF6bVB2NGFoOVBpcWVjNWdPVzc2WHVNeFdZ?= =?utf-8?B?WEFrTmE2S01wZHFDRU9vZzVKS3BEdlFGZUpEZ0xMYk8vbE83TUZCMHREYmxj?= =?utf-8?B?ZmlRNERZa2tUV09PMTV4ckdyVUJ4UWUvR1R0azJtUUVLNzdsQ0MrRVFIM0ZG?= =?utf-8?B?REZPYXQxVjZyaHYxY00xOCt2OThtMW5rNjRNbHBvMkZsMU13ZnJ0N2FseWFu?= =?utf-8?B?NUZRUlZnTGNOckZ4ZitkUjYvck1KaG8wQ1AvSXRFayt3Zklud3pOcGpjYjdX?= =?utf-8?B?QUFCKzZMQVVJQmFKeFRQcTRlNnpNVXQxbVFReGZsWHVock9aVTFBL3A4TWZu?= =?utf-8?B?ZEprZy9MemU3Y2VyRnpBbkdsSDF2WUVqanJieldTWkNVMHBBTWN1bTlsVHc5?= =?utf-8?B?N1JIYnA4TkVsOG5wNXoxSXhPakRPbjJ4c3E2NXBBZE96ZFNzUFljbk1zN2FQ?= =?utf-8?B?SVhVWTVtZWJUd3krajM1SHZKa1dMWmlBNmFkUT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(19092799006)(52116014)(7416014)(376014)(1800799024)(7053199007)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dHhLaFRsdlMzaGZSY2dpMGw4OHBGandoRUZDcStDK0VocDdvOU10WFRVWGFz?= =?utf-8?B?ZG5LZGNMeldQRUZnb2I4TVp1ejlsRllMNjYzOFk4QXROM0RvY3RJcjN2QXRi?= =?utf-8?B?aGFNTEJuZFYxWDVsaVRndW96TFNTV2ovYkNYZDE5QURscEc2OXdPeVBscjdO?= =?utf-8?B?YVg2Mm5xS2NpWXVMb2xHNDlaU2xhaTZyT3EzeVk5YUNDOUYyNFozNi83OG1B?= =?utf-8?B?MitBdkZpTDZpbjM5RkxUUnVFZDdDZlVqT3hCTDZ6Q2JsTFNoWkdJblpjQVRi?= =?utf-8?B?SXIyNVBGSkg5aUlnYjlPTTRKZVlJTGhGTVVTVVM2VGlWWmZaMVNLVHByUG1h?= =?utf-8?B?dStjZTFuUG1OQUVoOVE1RnVLQlVIclNMRkxPMktGVHB6MUxWUEpMUWdhWnZH?= =?utf-8?B?ZjNDemtneDViS0M2dHBBcnJhOEVrMVBrMEZjTnJveGwrNVBLRHFNMTZTQWFu?= =?utf-8?B?M2lTcXJyTit1THJ1RTZ5Y01NNm9nc2RpSWUwYWNjeGx3N2V6NWszeXQycjlN?= =?utf-8?B?STh0ZWgxOWVUMmcvbkJpT2tDKzk0azEvZ2U2VlBXdEVBU2tyd3JCYzI0a2NS?= =?utf-8?B?SlJvbnM1Z1hyTmtjVnF4bmJ4TUlpQ3E0S3kzUkhyTjlYUStFenVTMnpxSlJt?= =?utf-8?B?UzVteE1LRE9OZWwrSUdrVFY0OWU1NmlNUkRLQlAzbjU4NDUyK2dkK2cvYk5Q?= =?utf-8?B?YUJ3dDNQSjFBcDhtbEtlaHZiTHNySE5KTm1aS1pTaDFRa2szd1U3eXg1WVdF?= =?utf-8?B?VFNKejMwcGFsQ2x0WWhVYmhuZjVWQmZ1UG1NMTA4bVFjYWxsbGVFWTlPWVVn?= =?utf-8?B?ZFIxaWR5bXBuRUE4a1l0RzJZbWRpMWZmazM1bnBpYmhzbitQdjJxelZZQldk?= =?utf-8?B?UFpHUitjYVRaaFNCd0UrencvWk4vVnZRbUZ1amxic3RkVDVaWkRKKzZGclpK?= =?utf-8?B?SGU4TFJaRVdOWnFlRkM5c3REbkV0WmxmRkdwYXl2d0NxUlpDWFJ5aG91OHF6?= =?utf-8?B?TzI0Z0pVTEZpT1hFcDhuL09XV2prazhoRy93SjdGTjlqTW1EM0hNdlRTejla?= =?utf-8?B?MGF5bjVEUG1DVkkzV2FBMHllS2tXV25DUDFpQ2FhVnFkTHlaNHVRNXVuYWtZ?= =?utf-8?B?MHk1d3M1aktBZVNxNmV4YUcrKzdXL2FjZ2Z6enVGZmkrMzI5dmNYK011S0tj?= =?utf-8?B?bjhac2o0OVAza3FOaUlkbEJLeDBwNVNUSlZEY0J6UnlxZXJ6RlRDRGY3WnQr?= =?utf-8?B?SDdqU2t1aXBUeDJ2SWdDWWxHTGRBbTVlWDNZdUk3YVdsSzV0bjZPa3M3V3h5?= =?utf-8?B?alpXZmJDOHFoTThjTmRvSEVmNjRxc215VElFUmpvUHZLZTRhalVBT1FsNjJS?= =?utf-8?B?aWVCYS9vanFIYzhwYVdHWnZhL3Nabks1VEkxS1hvL0FpWGdCUnlQcFNJTGxy?= =?utf-8?B?Nkw2emZZajg5NEVhYzlpd3VEbVpyb2Z5cm13dTBwbVZwbFRacGIyY2tmNDMy?= =?utf-8?B?dXBxaS9nb3BtYUt1VThsSkVvRitqV3hsdFM2b2xLNVpLdmFhSkhZbDZSK3V3?= =?utf-8?B?c2lwT1VOMk9pM3YwQVNtNUNqUEQwRFBTQkNGQUxvM0cwbzV3ODk2d2JxR1hK?= =?utf-8?B?dXRYVFE3T0VwYnBrMnZveXRWbUZ4Z0NrZDBSKyt1VWJvYmRCMnBoNG1xK0tw?= =?utf-8?B?V3JqQU1BQW5BRldQTlR5cmwya21RcGRWOG4rS0E4UThzRTlyWjlnb0pZQ1B0?= =?utf-8?B?N2hCMkpvREVZWGVRbFo0YzAwVnhYaHNwNXhybTR5MzdOdmthSnNZUG1FM0c4?= =?utf-8?B?ZWtOcmQrTEFZS2s0MFhMaExSWXRqRHQzM1h0Y3gzTFpoZHU5NE1NbkVlaGt3?= =?utf-8?B?NTFFSWtWYWhWOFFEbm9aRDFpWmU4cnZrcjZFZDA5RzZSZ05sVnE1VWU3ZWgy?= =?utf-8?B?N2x2STBiN3dzSjdKc1RXQVg2N1JRQ0JFaExFcEd2WXYyZXp5RGhKTERFVTli?= =?utf-8?B?aHZuSkxWNmJFQjRudDREZUJ5MjFBVGFKSG1HWjcyenpyZHVxVXFHcUd4Si95?= =?utf-8?B?L0ZMczhDZjR1RXF0My94OXlXc0JYT2JtL2dyT1VOcEFDT1p2ckFyQUU2bm8x?= =?utf-8?Q?6iNomlMj8+fumNzrZ26OipYe1?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8655cd34-430e-4c6d-cd07-08ddfcf8eda8 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2025 12:33:42.8306 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ecGHehWNIsASsYp5f2pCEe28m+lkvxy0pjplCrIcGYqAGm9zR0fjfuW1ma6BJjPW7m9+ouwsURpW+f5qdnQBLw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9646 Proper cleanup should be done when rproc_add() fails by invoking both pm_runtime_disable() and pm_runtime_put_noidle() to avoid leaving the device in an inconsistent power state. Fix it by adding pm_runtime_put_noidle() and pm_runtime_disable() in the error path. Also Update the remove() callback to use pm_runtime_put_noidle() instead of pm_runtime_put(), to clearly indicate that only need to restore the usage count. Fixes: a876a3aacc43 ("remoteproc: imx_rproc: detect and attach to pre-boote= d remote cores") Cc: Ulf Hansson Cc: Hiago De Franco Suggested-by: Ulf Hansson Signed-off-by: Peng Fan Reviewed-by: Ulf Hansson --- drivers/remoteproc/imx_rproc.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c index bb25221a4a8987ff427d68e2a5535f0e156b0097..8424e6ea5569b9ba6b07525643c= e795faaeb2898 100644 --- a/drivers/remoteproc/imx_rproc.c +++ b/drivers/remoteproc/imx_rproc.c @@ -1136,11 +1136,16 @@ static int imx_rproc_probe(struct platform_device *= pdev) ret =3D rproc_add(rproc); if (ret) { dev_err(dev, "rproc_add failed\n"); - goto err_put_clk; + goto err_put_pm; } =20 return 0; =20 +err_put_pm: + if (dcfg->method =3D=3D IMX_RPROC_SCU_API) { + pm_runtime_disable(dev); + pm_runtime_put_noidle(dev); + } err_put_clk: clk_disable_unprepare(priv->clk); err_put_scu: @@ -1160,7 +1165,7 @@ static void imx_rproc_remove(struct platform_device *= pdev) =20 if (priv->dcfg->method =3D=3D IMX_RPROC_SCU_API) { pm_runtime_disable(priv->dev); - pm_runtime_put(priv->dev); + pm_runtime_put_noidle(priv->dev); } clk_disable_unprepare(priv->clk); rproc_del(rproc); --=20 2.37.1 From nobody Wed Oct 1 23:34:14 2025 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11010052.outbound.protection.outlook.com [52.101.84.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 415542EDD44; Fri, 26 Sep 2025 12:33:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.52 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758890031; cv=fail; b=CqeLLkFqpWOa7s/ZIuEERHaMcwSHIZj4hyORtR+ADBA2+AGGZ3ACnxbqpDttSsM1ESytwkuObnAbTNsL/L7IIRCKWvx+cETBaps/icBmqhWiErgR/rGPOvXTcw7AC4YTdiVMUoaBQp4Wdq+5sZTfk76O5cNee2kkv33ZvLel1y4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758890031; c=relaxed/simple; bh=DWo+F7eXklLy8taAu1Ps4GKjzVE10wW8RHF+0r9U11g=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=b4iG42ixrfphe/dfE1awuuoCC3fYnqZp9DJrXOFAIJJ6QhLhR4zRZUCNXLLnmMkXmPajD1hFTQFd/5LsQXKfi524+qjFzC5BkuQzD7gkTRD1iABcLEtdg+wFXhdU6EqO0vocP43o1aEgd1rODvODq4UUp5bs1J0o2k9lI14hltM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=MzhKyAN7; arc=fail smtp.client-ip=52.101.84.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="MzhKyAN7" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GRN39ev/MAewZ9gKI1IBCSfaw17jC2/2iE/QCntECJ0YDdbXzNLoKGMnU/lbsEGMLLjiCYEAZCVIwkK7TocGNjszmRcYllxOtConQCKK9THjJuDrXGSgJctHHP4+Q5CyUr6f9UNclpj0pcWyfwiyZbJqKDT6OoI2K9lRfev4YNMi/IHp/35g9we2O6cZG3Ypo8PU9wE6O7MnhjCzu+Kb3YeyyjXPR302yhJxwLgsa8Crz3Lado6m9PjPe0ZJt6lZtSAjuzWzvd9bUWADtLK8xZDRuBl6DAtgoUWDsxVjwC1Pzbkby5tZKp7YUaXAexyG5jYBq/K7sBs/ID9jRNBY9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XKFbKc/q+tHJVO8SxloqO4qgJzHGKoTOydIrsIqaA4U=; b=SJjDxXBjhzdzzd7VtwYeevpggBh5iF2Bp8Bl4AwnA0CQAElv+yghwHgdgr1NVpUpoaJsIJSiwlUyztyBeVed8dtox6w88bmdtjW9XyFumU2FxDALescalM3ii/sobRMDoYrtW7i6fr5G1UqUzLVnaT7Sf1+NbPEVbpe7IOibTBwEqS5TxjiT0E2yB/lR9vKxh+x+NLbIIsRQz+GokcCLf1UubNjNXN4V3t7v3z9TcFrNri9JRHUutXAfYQ63cXrz3k1rf5nWSnuYeWaQRIaMJD4XEtqbz7kXv5wplRQOBTofPZeRzMrKIwTiW1wnnlj5hxekXTZoBTL6Lc50nSZDOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XKFbKc/q+tHJVO8SxloqO4qgJzHGKoTOydIrsIqaA4U=; b=MzhKyAN7PZGbfWO/IeJLTjDhZ7hAiIELLRaSikOIkS5itI5zexC/DTahXIPP0obEYr1tFGTZc5T6cfMaQOYeDx1iPvA9BJ+BKk8KIkO+MQ/jxPx1mvUzU7FWyuTuMBW4mBM4XlvXy9DZz4Bj3ob/C/FdbORukmGmeQ/8jxdb5V+aLc6/HaQYzqTO/bY12h8vjANb+2Jsq+500fdEFMB0niworP1DFrU68eerao0fMedVNmbZIxwNy6WZivi8gBqt8cuSBywJGMs0IzFao9/QXERY7mVQSF2mjTiTaNUNMA76j3hoGzUtu5RSonG9PqZM2FBX1VG13ktAHYtujZQvPQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by DB9PR04MB9646.eurprd04.prod.outlook.com (2603:10a6:10:30a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.13; Fri, 26 Sep 2025 12:33:47 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9160.010; Fri, 26 Sep 2025 12:33:47 +0000 From: Peng Fan Date: Fri, 26 Sep 2025 20:33:16 +0800 Subject: [PATCH v3 2/6] remoteproc: imx_rproc: Use devm_add_action_or_reset() for workqueue cleanup Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250926-imx_rproc_v3-v3-2-4c0ec279cc5f@nxp.com> References: <20250926-imx_rproc_v3-v3-0-4c0ec279cc5f@nxp.com> In-Reply-To: <20250926-imx_rproc_v3-v3-0-4c0ec279cc5f@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Ulf Hansson , Hiago De Franco , Frank Li , Daniel Baluta Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1758890010; l=2199; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=DWo+F7eXklLy8taAu1Ps4GKjzVE10wW8RHF+0r9U11g=; b=7mbAE6ce0u+8sFK9WWdoJVpjPG1uu8aQFemAn4Wg9LIgEz6EN0LSanocenpUIa3t22bgPi4h6 doWbyuEBYA/CfD2gUi53PGzEDDhxv/2zsso5ivTJDD8RmONO04b9B/+ X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR03CA0115.apcprd03.prod.outlook.com (2603:1096:4:91::19) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|DB9PR04MB9646:EE_ X-MS-Office365-Filtering-Correlation-Id: b1cac4fc-cc8a-42f7-a8b7-08ddfcf8f080 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|19092799006|52116014|7416014|376014|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Rlk1L0FzTXN3WDFDcFBkNnlSS25vc0hyZEs2aWZMSEQ2S3ZiZ3BkbzdxTGhN?= =?utf-8?B?aWhZRXZpdFNJYjlkWHI2dFlyQU5CMVBwNUJLOUxBMitKK3JhOFBuYk9hWjNI?= =?utf-8?B?R3pwT1VjYnJKMnBGVmdkZGszcVNVRjdQRUdJdVlVOFRKTVpVYmc3NzBCNjg5?= =?utf-8?B?ZXN2TXhJMXV0VXpyZ2NMMVFlS3F2dHlXaGlBMUZZZXoxL3kxd0F0bFdEV2JC?= =?utf-8?B?VWpMdlVwd1ZLbEROeFRpeWMwTDFMNDRtNElobGZObmo5b3luOSsrTlpvOHlS?= =?utf-8?B?Z0krR1RnRi9hV0xxUHEwL09jRVc2TzY4cE44cHBHM0NqVEJVWmhhNTRuQkYz?= =?utf-8?B?b2hPZnZQZmFqMG1ncm95QzFFQWdDUXYvZVowZVp2WEZaSHVud0U4SHBaaTlq?= =?utf-8?B?SVk5WkdhS1V1RzNsRUtqY0k4anQwSXMxMTRGZEJwZ3lOOC9DOUF6NVdZWDJ2?= =?utf-8?B?UUJEeWVnSkpqOGRjMXVzNkRUdVhGYzFaZStiY3hCMzRvVEFpM3N3b3k3VmFB?= =?utf-8?B?SFFhS0xhbVVVaXRwSm9NaE5JYjFyQjZXZjd5OGdGaDFYQWJCRXd3eURLYWQz?= =?utf-8?B?MTJuS29Ha3ZOcFE5TENKVFZ1ZUI3QWVEYk81ZGNnbkZFaVRZU0tPejlzM1dt?= =?utf-8?B?aHV2V0NDVXRxcGdwdmRLbDBlYTd4ZTBVdmtHRHdxU3ZNL2FKcHpGdlFaMW4y?= =?utf-8?B?OVRLbDhWQjduNDRtaXZDY042NmcvcHlwZ2dDUHNJeWhTbWZLMy9RbmljendC?= =?utf-8?B?VG50WVM5SFBnei9NMDFjMkZnamN3dmlCdmQ0eXdPWGd3TXZFL3ZSc3ptT2wz?= =?utf-8?B?SGNEWEx6L0dnOXIySWtjWFE0cktrc0RQSzlZZUNFdXdVbnpnV01OUWNBMHVZ?= =?utf-8?B?YnpqNFp2V1FNbWZqR1JDMkxZUllQOVcwQzdRK1R1eEpPUnJUbkVKaTQzUFYr?= =?utf-8?B?UXZ5eEU0MEYrSVhoOFB4ZzhDODUzREIwcEw1amdLYlJLRlBQaEZQaFhRLzNL?= =?utf-8?B?OTU5VFpRSWhId0UzRmFSc08rcFVaL1FJVXhEL2lKUDNvckZGc1NiQ1JOSEg5?= =?utf-8?B?S3RnVzB4ZW9Ob3NGRnRhRmhKU1UxZDl6QWZhSG5nMUZ3L2FZWExzUGxZR1R4?= =?utf-8?B?TzVERWNncytqOEluWWUxd0NDVklaYnZkb28ra0syZzNVelB5TzI5Y0RXaytL?= =?utf-8?B?NWxqRWRFOGFVdnNMUitvUVY2Y2dhNGpNZk44bFoxUVJwbHNLbWw2SUxEY296?= =?utf-8?B?QkZ6MW84b0E4aWtzS09Id1k3Zmk4S1JFaVFnMzN5aVdWVThnM0doNXlJaG1v?= =?utf-8?B?L0t5Ym10Y055UStuZWp4TXpVMk5rVllxbTdxdEdZUDR5bVhBK3VkbmdXZ2tt?= =?utf-8?B?bkVyOUFiYkFlVVdDM29PSWx0b2s1Y2t0cjlhTCtIK0tYeWN3UVo3bUcyV2NZ?= =?utf-8?B?TnVJN3pFcU52WCsrclRRb1Y0QlA5Wm8rc0lpdXZ2TnFPTnN2TzBrYmZmVEhW?= =?utf-8?B?SVl1NVZsQm9Ramo2WTRZV3kxQXJvWnNzblkrY09uRWZTanZ6NGgzbG02djJR?= =?utf-8?B?NDRKNFlYYUc4c0dnZDVPQ3l2Qlg0cjIxK01aSXhROXAvZDdmK3hBVXRuYk50?= =?utf-8?B?elpGWm1nQXorbzZUTnVrLzlHOVB2ajZmNXEza3hEVGc1VUowdGRaRVRGV25R?= =?utf-8?B?L3dwQTNIKzgrZWNPemV6RC92aWlXQ3FabzVMMXVDaWNraXQxVzcyUUR6NTZM?= =?utf-8?B?MnlFRlJlQ0hIZTlSRjBtdjR2NTZhZ1dQNmhuS2w1MG5LM0k0ZDhuUTk4YjJw?= =?utf-8?B?T3I5VS9vb1hCWjJibjdCRkhzUUdMeGhzVnVTS09CQ1VuOHhsWm1wMHplVUU3?= =?utf-8?B?dGxON3N6VGhSK05Fa3VleEczTjVmQStGWUtqWDhXcWROSFRCVmV0WVZpd29Q?= =?utf-8?B?SDhTSW1EZGh3czlBL1pSWEJZSXpQcUFsSy85aytFZW9BaGVCV21rdVJ6SVNr?= =?utf-8?B?N25kWWxPMmpNZmkwVzhQeHFzYzkrQml6UHRxNG4rUXdjdUdKRG9QMW9uaWdG?= =?utf-8?B?cDhHZ1hTQ3NCd0I3N2UvcWFrRVY1alUwakd5Zz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(19092799006)(52116014)(7416014)(376014)(1800799024)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y29OUmRLZ2pqT0l5T1ovOGd4cnhHWjJyZ0Z4WXZPZFNaSENMakVDKzR1by9z?= =?utf-8?B?R0ZMbWNPTCtlTlM4aVdESElSRVoxR2FwTmI3bVphZXZIOTlxc1M1YStwaXVP?= =?utf-8?B?Qy9XTmhLbFVIVHIwN0FvSlI3QVlETi9PWXc2WVpFUTFFMDlKQVdoQ25VQmFI?= =?utf-8?B?WWUrVVk0ZmVVL3pxZWpxT2dYbkh0ajF0Z3dxWEpCL1VoOEJnOWZaQ1ZDeUhP?= =?utf-8?B?U2V5SGRpaEtYb1I5aXozWDlCdklVc1FnRUdkRS94ekMyQWswSndYekk1Nyty?= =?utf-8?B?VHV6aVE5Z2xReFpKUDA3QitQUkhBL3lIQ2NHdnU4TEZWMFE5YTNzNWdnWlBu?= =?utf-8?B?TjZNa1dvd3UydjV4cnNQUDlGTjVZOFdUdW5GQzBWR3FtY2pCUEllc2dHOVR6?= =?utf-8?B?bjRSWlpSQXNxVXppcjdQQnlzenNFOVZHWDNadmpQQnBLZk1iWCtrTWtlNUg3?= =?utf-8?B?OHQ1VDRmd3FwZm9IRVZUeGRrMkxZYno0V053M0J4bWtITTZRcXB5YVZnMDhF?= =?utf-8?B?TnY4ejdpTVlkUEg4VEM3VWNCdkxCb0dOZk9CWmNzYktraERITk9xVUw1OHJQ?= =?utf-8?B?MVFweDZUdndpQm1NS0psWnNpaUVDa3NWbWlIL0hqNW94QlNhdGxUQnAwY2pl?= =?utf-8?B?NWFVK2pTWk85WFVQKytBQ1ZhYTBGeG9xdnZTMEdrM1RWM2tOV0oycEVUNmVF?= =?utf-8?B?UEVzK0NBUjJMWGZrUmJoOXV6aExxdnFCdEVreDU3YjlVK2xVQ3pjeTJoUEV2?= =?utf-8?B?clFTYWtwMlRadStwUm56TjA0eW55VXRpQm1DR2NpN1VPMlV6d2RrMENIRWhK?= =?utf-8?B?SFQ2NFJpa0dpYmdpalJEUWhvdmxyRUxzRTJUQUp2L2tqbGRJZ1EzWVU4d2Qy?= =?utf-8?B?OUhNcjBmb1Rwekt1aitBTVZ3NDVGWVlOMysxVFZUMXVDNW1tWHlvZ1lpUFd6?= =?utf-8?B?cEh1SitpdTZBUDYveGJIbFFJeDVXMno4cnlRbXJ1eEVVbWFPOEhsazREQmhL?= =?utf-8?B?SExudmFKOHFiOVc5R1E3bWd3QWFmYnZvUk5xZmM2ZE5tS1p6b3FSRmlmdW41?= =?utf-8?B?anJPS09FS3VXb1kvaktibVFodkNzZG1NOVJzSXNFb1pLVTUzdG1wQzRoYi9V?= =?utf-8?B?MDVvRTAzdnh5LzhiZGMydklLTGRHMWtieEV2K0NBdmFEeHlPcUcvRTAzSDhx?= =?utf-8?B?YnRxSFR2NzM1all3aUNsQ01Uemw0WmpnL0RJOTR0ejk3TDBPQVBTNEk0U2FL?= =?utf-8?B?N3QwK3FZclVDTlpMQlVwU2tFOFQ0WEY2a0MyZFo4VU4xenFxNjVCQkVpUW1Q?= =?utf-8?B?citTZ1FLM2FEMjB5eU5FcWxOc3JKSGxXV1ZTSDFqdzBRTlcxakZpS3VpRlRu?= =?utf-8?B?T2tmdWllekRBMTM5LzRJYmJCb3g2THNaRG9DTG1Rby9DbEI0cHExWUU5MXMr?= =?utf-8?B?eUpkUjgySERxeER5czdNVTdCUkF0R2E3aEZoV1plcFBtWHBSSjF3dWNSWjMr?= =?utf-8?B?MVU5RVViWjFHV0xiRzh3TlducXdRMVcweVNsQWtjdGYrV203Szl4UXRMRkJz?= =?utf-8?B?QlRZaUs3VFZ3RFZGbHN4V1ZaU3JEOEJNTG1IN3lteE16NDU1S21Tc1l2and2?= =?utf-8?B?dkgySzk1dDNtanZLT1Z1WVlnUXdTWm5TVXBqRnVHUHdEQTkyMjIrOWpPbDNC?= =?utf-8?B?Zi9vazVwcCtCL2djTDQxcys4MkZpb0tzUUFEaFphZUpFN1NyazFYb1BPUDhz?= =?utf-8?B?UFFIeFA0dEhMTzZZUVhEVEUyWk9zQlJMNk1VTnlHdWoxcFh4OXlCemRFZ2Jt?= =?utf-8?B?ZGFITDBsdGdkVEFldDgyeCtDNUE0U3JmZnhrbkNXSWM1SnRCT3lVRnN6WDFU?= =?utf-8?B?NTl1a0h3QjJsa092UlgybkszSWR6OFg1L2J0V2t2VklQTkJjcmFEbXR2WHJX?= =?utf-8?B?cHVMWGNvTUlVejAvOTRDd2RQM284V0dySXpjMFJYMkQ2ZkdjY3lqNWxHM1Vl?= =?utf-8?B?WVM5ak5ORElKS3FYTnJYdlFyMFRSUU1XSTR5dzVCUjZSV2Vjd21tNFJNWWZj?= =?utf-8?B?dHpyaVVIZFJlUlkvVEg2dCtMNkwxSmxPcDgza2x6VU9NdXJlZHkwbXRMZzNC?= =?utf-8?Q?hMMAoqh/htIwKKz9lCkIpLiA0?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1cac4fc-cc8a-42f7-a8b7-08ddfcf8f080 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2025 12:33:47.5387 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PFyS1n/pb5nu0NAvYa/i6Fdpp6CCN1pKjgSjYB81aRd4W2DfKh62qKYrr2jXPRUKaN+5NOnJnNR8xdLN9c/kdg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9646 Replace manual destroy_workqueue() calls in error and remove paths with a devm_add_action_or_reset() helper. Ensure the workqueue is properly cleaned up with the device lifecycle, and simplify error handling in probe by removing now-unnecessary labels and cleanup steps. No functional changes. Reviewed-by: Frank Li Reviewed-by: Daniel Baluta Signed-off-by: Peng Fan --- drivers/remoteproc/imx_rproc.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c index 8424e6ea5569b9ba6b07525643ce795faaeb2898..9c44ce56f1ab044ca5dccfeb0aa= a0f7cd810aab1 100644 --- a/drivers/remoteproc/imx_rproc.c +++ b/drivers/remoteproc/imx_rproc.c @@ -1046,6 +1046,13 @@ static int imx_rproc_sys_off_handler(struct sys_off_= data *data) return NOTIFY_DONE; } =20 +static void imx_rproc_destroy_workqueue(void *data) +{ + struct workqueue_struct *workqueue =3D data; + + destroy_workqueue(workqueue); +} + static int imx_rproc_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; @@ -1077,11 +1084,15 @@ static int imx_rproc_probe(struct platform_device *= pdev) return -ENOMEM; } =20 + ret =3D devm_add_action_or_reset(dev, imx_rproc_destroy_workqueue, priv->= workqueue); + if (ret) + return dev_err_probe(dev, ret, "Failed to add devm destroy workqueue act= ion\n"); + INIT_WORK(&priv->rproc_work, imx_rproc_vq_work); =20 ret =3D imx_rproc_xtr_mbox_init(rproc, true); if (ret) - goto err_put_wkq; + return ret; =20 ret =3D imx_rproc_addr_init(priv, pdev); if (ret) { @@ -1152,8 +1163,6 @@ static int imx_rproc_probe(struct platform_device *pd= ev) imx_rproc_put_scu(rproc); err_put_mbox: imx_rproc_free_mbox(rproc); -err_put_wkq: - destroy_workqueue(priv->workqueue); =20 return ret; } @@ -1171,7 +1180,6 @@ static void imx_rproc_remove(struct platform_device *= pdev) rproc_del(rproc); imx_rproc_put_scu(rproc); imx_rproc_free_mbox(rproc); - destroy_workqueue(priv->workqueue); } =20 static const struct imx_rproc_plat_ops imx_rproc_ops_arm_smc =3D { --=20 2.37.1 From nobody Wed Oct 1 23:34:14 2025 Received: from GVXPR05CU001.outbound.protection.outlook.com (mail-swedencentralazon11013017.outbound.protection.outlook.com [52.101.83.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E3572F5A03; Fri, 26 Sep 2025 12:33:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.83.17 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758890037; cv=fail; b=YCi7r1pprQtw6vFVk1BXbQMOEkR0KyGhm0hjLA2BCw2xPskAHuM72Aci4wzlE959z3q0DxQFdREIr09mibqLhKeaEHVllAGksyEvF+CK4K2iSUtvyzB8CPiwExBQD8MeCDAu5yYs0nVlRlPhwvX0/d3spqc+sMQr87zpWd8tU1o= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758890037; c=relaxed/simple; bh=HGRoXF5rCPTqdVyUeinAVxy9RQq1ivPMHHpYdBWKdWk=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=PZaLC9NcVks3tOdDS5QEai9KLuhP2Xymg6FMP0HnMeyNY337jek7R5v52KiaeHF9/2LlLNqJ/npVV+6TIAN0p0mt/nJSSfG/pksS0fjgafYIGdiWPPXbkPniLsF2eDimTv9PkJ8/97Xsr8eMoF9t2nIBr9utFj4D5mq9Tr4yF8I= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=lxjYJHaU; arc=fail smtp.client-ip=52.101.83.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="lxjYJHaU" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fTR2pWXz9ED7tqrQ4tbTU+0fNmyipbgGGX2hRmwV3PM9sU5mX10dVIySwx8Xc1DyL4X7QXNvMeoKTSD2XVMqfDJsBae/Cy3n0q5ntH6pHNYLViIZe/lz+IQ73iVv/kL3nz40ILek3dIyettr1eoxdaJdg/dGNcY1uuBGUoiqV5T1CxwTHuthlGWUxXYFAFj4ZP5H9jGZ+HzprqUFGj2WIDkYumAxOY/qNgR/C9s7KKsxqXClevQHJ5jBEVt3Fo7jFdn5C6ptS1qpzP+S+4bgHP9atN8c8QZJbK/Fp5X4X/OrSMdEIUkJ0zXRZmPrwO+KkSQEfJBkWcp6crNFGX8LuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z9p6nRFQGuwCDYaeQstZN0roNkaUzL8JRDVtY3HKgRA=; b=cruIxDkGUqitNUDRsOpBBgq8t3OsTqXsmnNvhWmL6qLzFNN+B8QpIW3yUi6AG6xvyEXFSTbKupsRHa+gM4iu7TbZybsgWEpw2lVC049M4zEuS5LRl+oGZjyFF6A60CqAYTsTGBrLBwcl4c4R6z5qNI8JNkw1r1ISbck0eduEo9I530/lD3HTz1ifqgl12lWjEz/5yaKEDkXbKcgMb7b3YJhTvaoG5jqNHJ3sfyT5/oTB+2Bd5hVvgj6k0brpULEo30tNGg9XJZzvqQWeo5aQ1FSEjjhX44XL//DF25D7+DOrEKfb9JfytKq3mwetUiImqRSHAo71S2dqBLh7hY+p5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z9p6nRFQGuwCDYaeQstZN0roNkaUzL8JRDVtY3HKgRA=; b=lxjYJHaUKsvTLv+6wD/xF/cVGmKxIWWslfDmPwhR3itmo+zHZJG3pfPDIfwIRsWiiDJQYtlX/lWYdIkmKxjjQOHGLZfjtp2IZz+VumHr9Rpdcw7K8lfxQbCJYzNQNABS4dR3AtZrbPGwjfF0OvU4s7Qv/GGsH+diA9qWU6Tc4Tl/U+fnGGCpmkCLVc7pLW+doUv65l+AYQMeukNBdJO2v6pYxurJ4uuw5cw67ikCcomsbQ0u8ySyrDeH0/F2ulkRDkW1OqZihewFeRqkdqvy+nbhtv3eH41GiEoboclDIIEjEa8H4anhGPYyHTqzgCdfGYnZmNP9/dA1PvdYGcNZ6w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by DB9PR04MB9646.eurprd04.prod.outlook.com (2603:10a6:10:30a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.13; Fri, 26 Sep 2025 12:33:52 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9160.010; Fri, 26 Sep 2025 12:33:52 +0000 From: Peng Fan Date: Fri, 26 Sep 2025 20:33:17 +0800 Subject: [PATCH v3 3/6] remoteproc: imx_rproc: Use devm_add_action_or_reset() for mailbox cleanup Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250926-imx_rproc_v3-v3-3-4c0ec279cc5f@nxp.com> References: <20250926-imx_rproc_v3-v3-0-4c0ec279cc5f@nxp.com> In-Reply-To: <20250926-imx_rproc_v3-v3-0-4c0ec279cc5f@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Ulf Hansson , Hiago De Franco , Frank Li , Daniel Baluta Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1758890010; l=2739; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=HGRoXF5rCPTqdVyUeinAVxy9RQq1ivPMHHpYdBWKdWk=; b=2SnB8qT5ctt+Cve86v9MYl1ilmw5ClivcKCyLb6xf1f+I0opq8Bpw81ie9bs9o25xmzwIBqxe BMS8jvfdFuxCIgYZ38/CskiU3D5HIt2TGfUlmhVz8OrxN5MTxwy4OXQ X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR03CA0115.apcprd03.prod.outlook.com (2603:1096:4:91::19) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|DB9PR04MB9646:EE_ X-MS-Office365-Filtering-Correlation-Id: d45ae1b4-66ca-4215-c246-08ddfcf8f342 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|19092799006|52116014|7416014|376014|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?WGJIK09qcDdmaHhrWkx4QkpLa0dKS3NPUWFhNVh2L2srcjIycWp2VCtYZHhm?= =?utf-8?B?d0d4dVJuZkp4VXVwYlVzOHRqN0tYeld4cUtNYzV0ODZhVG85cDRmTmp0Yldr?= =?utf-8?B?czdwSyt5Qi9XKzFlcXVVMHF3K0V2U29Wc3BNZkQzNGlYUEtuZi9LaGtNZXZB?= =?utf-8?B?aUhkN09hdFBPQk01cG5UVHJib0taN1h4Y2JtOXRxbWJ4UGxNS1BJeVVHZVRY?= =?utf-8?B?Z0tOVFprejVmNXZNMytobW54VHA1YUEwamMwRjR5dmw1c1JJbXJjbGRCYjY3?= =?utf-8?B?WEJ4elhPdi9VMWZ0ZGpyWWs5dmV5V2ZvQnlqRGpucVI1aEN2ME1icXVLSlV4?= =?utf-8?B?TFlxREx3TFloalRXVHI0NDFUdHQ3dm5xU2picmxIUGpRdkVhYXFVZElZQ2Vh?= =?utf-8?B?TVZmUnNrRkV4cHpQaWM4cWpOcXpSQm1seGNETklhc3JOVlBnRXIreWgxSFRZ?= =?utf-8?B?QnQ2QklEUTZFb293RkszSGRtK1EwSHVpQTFFT3dDcFRhQVJvTEJkVmszQzh5?= =?utf-8?B?YTQ0cFZpdmRNSnpVUXdHTzlmRjl3eVRvelNEMzBLbEk2TW9RUFZnT2RGVFc1?= =?utf-8?B?eFBKT2ZSSHdqL2VyRURXQ01WZC9MUmpXN3FPVzdabEk0N0Z0QzZqZU4zUHdH?= =?utf-8?B?V1lvZVhENHE5cWxUcU1BSWZKWXMrOG1TK0RKaWF4NXByWnE3TzV5WlJBUUVQ?= =?utf-8?B?cVZRRlJlSUJrcjNTK0dzeWY0TjhLL1Y5R0xVa25FZjNLaDZndFpjdDl1SS9J?= =?utf-8?B?UktNZUxtS3I0bmZTaXRlVjNxTlVOcDFZTFN4cE4wczFYUHl4VzdNeXZXWXp2?= =?utf-8?B?WUE1eXUwWnowdlZhYSs5dmdnNWJpOVY5QzlqR3dINUdMMnJZMXdtZjRtclhD?= =?utf-8?B?WjczYWpHQkY2YkJLUFduOUt4dndsR0V1VHpvS3hkN3NiLyt1cE1uR09UUXR3?= =?utf-8?B?NWFPQUlaeVZSWFQ2ZzFJQmJYRFNHR2ZkWU1aNnFacmJJbHJrOVdRUEs3TjlK?= =?utf-8?B?SndPWjNsYWxkbUJlWmxiWFRCSjlUK0ZGTmhYTWo0SisrbUl6aWVKNlRxbGs2?= =?utf-8?B?bWlkWXg3VkNtc1Iyd0o1c0FwWkdYV2JObXByV1dlVXlDWXlMajBuZHQyUTNN?= =?utf-8?B?SVNMbGY4VVFZOHVObG5nNGdya3JKYXNRQ0p2TjFrZHl3T2Rxd3pKMENDc2VH?= =?utf-8?B?emxmN3JYUHFqbzhWcU5reC9wdmtvNFRNb0xXb2dpdHpYK3JRcVZRQmNFcDN1?= =?utf-8?B?Tlp5cklmZXl4UFVYUnA5anQ0TS9jQXF6NGtaM2NTaVgxVlhOdDgxMUFmZkVV?= =?utf-8?B?NjErZ2xGOGpsa1ZISHZ3RW0xcFVyTlFrenVaeWFxUzdaWkdUS3M2bFNrKzc0?= =?utf-8?B?TFBzNVg1cEVhZXdZWEt0ekFDanVzTDc1cS8reUxsODJLVkRQaEZ6RG9Xbm5T?= =?utf-8?B?aUlWUTJJVWhPZXJ5dVhoRXBLdG5pdWZaSW9sVjRDTHIwTDNCeUtuVW5pVlZp?= =?utf-8?B?dU5XUzRTOGFjVTd2eStCdnVuWVdVZlZDWXdVd1JINFFEci8vYitveHNNSmZy?= =?utf-8?B?ZFhtSDYrVXBFTEZIdXZhWHIvT0xkVm5nWFBwcDRyWEtTSm1aYUovSG55bXlU?= =?utf-8?B?QkJkbitBRmFtWGY3WUpVUnpHdFlQYS84eW9PQTVHRWJwWWUyY2dpNTZzSDEw?= =?utf-8?B?UHRsU1JHREE3b2UzYWM4V3JwYXcyVmxZS1lzeGRtMjh4THRJb1VxaWNFdS83?= =?utf-8?B?Ym81N0JDeWxCTWNQVzVncW5nTkNEelNpek9NV2dxWGM4WDRWQWxjbjBnL2Ns?= =?utf-8?B?Yk90cVVWTGZxM25LM29kY01UU3ZXR2t4SWpHOXdGWjJXV21NcWNQWHJGaE5s?= =?utf-8?B?Wm9hSFBWSktHczhoSDRsMU82dm9iWXMyS2UwTVNtQWd2R1lVaUxCRml0aVJq?= =?utf-8?B?WUNnaTZGRDMxTlA1ZkVqV3ZRKzE0ZVRCSTcrZlBZbWQ2UEYyaEVOM0NMb05D?= =?utf-8?B?bmg1VzVtOGx5WXJUdGduQXMvN1dYZzFXYzdMOFJlVHkwZEtiYkdiWmc5Q2Q5?= =?utf-8?B?TFFyM0ovVml5ejNaQzRNS01PM0VNdUJ2OXZWZz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(19092799006)(52116014)(7416014)(376014)(1800799024)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q3YwWFcyc21udk1SSWtJd1NOdmRNUGdVcnNlYXVvMVZhcE0rYVR5NUdqbUph?= =?utf-8?B?YzhYUWRFdDQrRnNnMHBFaWh0L1lweVpkdy9MVTJILzF3dlVnd3dHdHZ6THF6?= =?utf-8?B?UFByZFZ5dlgwSGc4dmF4eVA4cmNjbUlWT3c5eXF3Q21TU3gzKzF0bW81ZHg1?= =?utf-8?B?ck95THNQRVBZTkVFSlhpNCtmaGRGa3RFYm1WVlBBTysvZG1GZGhRbXJtL1FQ?= =?utf-8?B?b0VzSUYxenRld0k5UG5xa1FmbmNpcmxKQWIzc0FTcmVYWnhwTzJoNVNwVVpv?= =?utf-8?B?TWRhbFQvMTNUTm1xNmUvZVVnMWFiQk9sUmp0cGpvbXdCN3AwQWVFRlVjTWlB?= =?utf-8?B?M0tHZ2hhWjJWVXBjcEpGM1JQckZZMTZ2YmwrZlczRFp5RHF6bmZLL3FkaHF0?= =?utf-8?B?VUFYRUl3WGx4SkN5elJQWisxT0xrbEZrVkZjRXhtWFQxRjBvYWRuMitubGtq?= =?utf-8?B?S2FLd1VXSHlZdElHcjVJa3U3VStWaHNjdUhsVFFNemFhQ3poYTdxZmlTbWFZ?= =?utf-8?B?TTUyWm9yR216UE1aeW5KS0pFVG5QT1llZklaV3h2Vkk2YzhUWlNGM2lQNjBL?= =?utf-8?B?cEV5Z1ZTZlhQVm5yNTZxajREYmp3MnlmdS92MVRVT2U0SnR3c3VhT3hpbXFE?= =?utf-8?B?bS9JWVlINVJDdWdpaVBGcGJZS2s0UWdIVHpDcVJLK0drajRSVGF5Ty94c0pK?= =?utf-8?B?dUlGM3BIMWhaNmNHSGkrcW96UHEvc0dFbmZxN2RyVHpXaFE4dTFYYk9ZbjlP?= =?utf-8?B?MGxkYVJjY2lzcVZiZ0xQZkJhenJwRVcwRXkyZ2ZJbzN6aDVscEdUTmxYL2t0?= =?utf-8?B?b1U3bkdMbjRkZ2lZckxueU1LV1p6YWd3eEdITThuMzRmbUlrQ00vN3ZBS294?= =?utf-8?B?VVdZemZVRUNndGR5RmRHQ1hiMEVQc1dPSDMxandwQUtVZm1OQ3Q4RkJkV1cw?= =?utf-8?B?VXR2UHRzWWpWeEZrTVdaRkpMakZIQVFjYjBnUmJGdEJzeHQ0eXpRd2hMemtD?= =?utf-8?B?djNWRkFrYTNxeUhONFh4Yzc1VVJ1RUwrYUVUaHI2cXFUakd1TWVVZDJWTkxk?= =?utf-8?B?bVRGS00wbzlWUTk2Smg4d2pRWWU5R1FxVmNxc2w0T3FwZUUyU0tMQktucHpS?= =?utf-8?B?WEN4Tk5aci9mZ2FLVERjaGR5cG9QcmlyWVlwdVlKUVQrZzhieTJudWUxclJL?= =?utf-8?B?Z3cxd3krWEIzdWUva0ZrZHBybTRmejJoOHdVc0VZN1NoRTRoTHY4K3NnenBZ?= =?utf-8?B?OWpYcUFIZllJWXhCZ0I4Z2NuUjl1N3p2RVJNVUJ0YXNlRVpxNnp3RU00TUxS?= =?utf-8?B?U0dYeVpVT1drNEhGRTArQmF6UkFadGk4cUk0by9mNmdaUjlaZGhzTDZZVXUy?= =?utf-8?B?R1V3NkhadTN0Ym5PazNrUlU2WndQV05pOUVzSkk4TmhnL0cybkhCMDlWNi9K?= =?utf-8?B?dnh6b1BxcFZvWm90TEsybWdKSUMvamswZUE3ZldVdGlpWmxhdS8wSCtWc1R0?= =?utf-8?B?OFpRSlJIL0l5NitRaFB2cloxZ2xRSGdiWjRJaVE0YVF6czhkVTNGRVZ1c1hm?= =?utf-8?B?S3BPUis1dTFldHJ0SWptekl6YksycWdEMW1TM21UT3NaVEx6cVcySitkNTky?= =?utf-8?B?T1hvKzQvL2ZFZmwxQjFJVHJIeXhpOEhVWnFVdWJoenVwbGNWd2lBbmVIYi9O?= =?utf-8?B?bnY2Rk5xMVdHdnRWMmJ6eGNsZkhBVjJ6WTY5UHNGT0kwYks1ZDk2ODdGczNY?= =?utf-8?B?elAvZExVVVgzUFBhTS9nY0tVQURjcXpZM0czMEVrOG9wVGdOSzA5aVczK1VP?= =?utf-8?B?eFZ2MENDWW9Nbnh2dzJOZnVzNTVMemI2Q2dDSE5BRHpuTElvSWszaXBjU3pv?= =?utf-8?B?YXFtczl4eCtsQS9oUEM0cmc3R0FTSEsza3hGUjNZK2YzNXFCWldUWEoybmVT?= =?utf-8?B?M1FWWm9zK3dQUlJOMzdERG1WWFdHblB2OGtray9pMXB1OGR2QXpGMURLVXIz?= =?utf-8?B?cDhwczhnVlZlOVY0NjJsMXEwTXkwckZlbTRrVVhqalVlcUZRU1RsZEh2RzRH?= =?utf-8?B?TXBQVUlUMnFrRm54MjdRUTM5RWY2bVBySm45YWJyOW5mbEpxeHhSc2o1RXVH?= =?utf-8?Q?wz2VJ2PPdYt2QN2LLZnG9AoZc?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d45ae1b4-66ca-4215-c246-08ddfcf8f342 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2025 12:33:52.1903 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: V6Ahdth0glS1ssoe+RQK0qUDbre5ETGDfMQP68yBklJ3KFpfe1PDWOX7j8ldiBztRZaHhQGaSPuojovK+i1a6A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9646 Convert imx_rproc_free_mbox() to a devm-managed cleanup action using devm_add_action_or_reset(). Ensure the mailbox resources are freed automatically with the device lifecycle, simplify error handling and removing the need for manual cleanup in probe and remove paths. Also improve error reporting by using dev_err_probe() for consistency and clarity. No functional changes. Reviewed-by: Frank Li Reviewed-by: Daniel Baluta Signed-off-by: Peng Fan --- drivers/remoteproc/imx_rproc.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c index 9c44ce56f1ab044ca5dccfeb0aaa0f7cd810aab1..3260fd55a713994e1d39cdf6772= 65edd4192ae45 100644 --- a/drivers/remoteproc/imx_rproc.c +++ b/drivers/remoteproc/imx_rproc.c @@ -93,7 +93,7 @@ struct imx_rproc_mem { #define ATT_CORE(I) BIT((I)) =20 static int imx_rproc_xtr_mbox_init(struct rproc *rproc, bool tx_block); -static void imx_rproc_free_mbox(struct rproc *rproc); +static void imx_rproc_free_mbox(void *data); =20 struct imx_rproc { struct device *dev; @@ -780,8 +780,9 @@ static int imx_rproc_xtr_mbox_init(struct rproc *rproc,= bool tx_block) return 0; } =20 -static void imx_rproc_free_mbox(struct rproc *rproc) +static void imx_rproc_free_mbox(void *data) { + struct rproc *rproc =3D data; struct imx_rproc *priv =3D rproc->priv; =20 if (priv->tx_ch) { @@ -1094,15 +1095,18 @@ static int imx_rproc_probe(struct platform_device *= pdev) if (ret) return ret; =20 + ret =3D devm_add_action_or_reset(dev, imx_rproc_free_mbox, rproc); + if (ret) + return dev_err_probe(dev, ret, + "Failed to add devm free mbox action: %d\n", ret); + ret =3D imx_rproc_addr_init(priv, pdev); - if (ret) { - dev_err(dev, "failed on imx_rproc_addr_init\n"); - goto err_put_mbox; - } + if (ret) + return dev_err_probe(dev, ret, "failed on imx_rproc_addr_init\n"); =20 ret =3D imx_rproc_detect_mode(priv); if (ret) - goto err_put_mbox; + return dev_err_probe(dev, ret, "failed on detect mode\n"); =20 ret =3D imx_rproc_clk_enable(priv); if (ret) @@ -1161,8 +1165,6 @@ static int imx_rproc_probe(struct platform_device *pd= ev) clk_disable_unprepare(priv->clk); err_put_scu: imx_rproc_put_scu(rproc); -err_put_mbox: - imx_rproc_free_mbox(rproc); =20 return ret; } @@ -1179,7 +1181,6 @@ static void imx_rproc_remove(struct platform_device *= pdev) clk_disable_unprepare(priv->clk); rproc_del(rproc); imx_rproc_put_scu(rproc); - imx_rproc_free_mbox(rproc); } =20 static const struct imx_rproc_plat_ops imx_rproc_ops_arm_smc =3D { --=20 2.37.1 From nobody Wed Oct 1 23:34:14 2025 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11010052.outbound.protection.outlook.com [52.101.84.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D346123E347; Fri, 26 Sep 2025 12:33:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.52 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758890041; cv=fail; b=S9njhgYptX68Ucmo53UsdoB08MYYCXobhq7n/vaYE/D6wRzEgAm0ZEeQuIso2xFgvXxHPBqqOD3tH6GeKcPA2tLQ388E16YvdBc2TsOubrVMSAtg6fEVzkIJM+FkED49Uq+pkCPClJac1qA+9Usvb2RQx637JrvLAMozejDLnKg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758890041; c=relaxed/simple; bh=/+qAXachW8UJdl7xjt5l3dl4HFy2UlQ+gsMiBYhAO+Q=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=jJHCXNeC4N/Otgxt/c0/ghQequXJz88vSsN2DnKl5EEopxcJUB4CFDsGxXjxIqcqJ4HrZhtT5Cg94BXW6LGFZkBQSsXEpjL91Kte+a1fvZDdPPXpuHzQ/ZNi8S8uSCsUz6B65SOqv/cp/A0GFgt3x7sAHGlC9bl/nEux8NyC4wA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=X85zikLe; arc=fail smtp.client-ip=52.101.84.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="X85zikLe" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MEn+qYiJrQquwLxpxdpx22Q5KnsGVt/FgyItpx1eWrGuoMA0sbGPZcefDvA4cjQMh2bnG71aF8Q7Z2hr8IRsQUI79XPee8k8vUPo4gv4mEkhIsmz2L4TvAI0gtyZ8PKUcG62MtJmBE6cf/eQgqyGKZY+2R63I4ht0GIDZX+Kj6FVbLd/tZ6kcMpqSag+/Sdmnd6Fva7hJl760W3Xs6wF5Xa7M+CT1YrLF+cZK8yAk0ddd6UpRdt0MT4jvOZigZK4RKHCleLxj+CFc0oZNc7hnE0ZUEOg3EmmldJnpMAapFmDJ/wXmCWDU7xp1of66pmPj4LPjz/NzmTatyXQA9Wn2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dHetD7b0iANOwxLEzIIhmux9Ix3UYv40GAapoXweAUA=; b=DQ+9aF9H52652gWNZQBFvM3d8/QBBhrjtT8RTwAvPDAJUyZl/N20+BIdtIr4BqikkxrCEyd/jDrpUDMxKjOmKbnglVQa8+k2V4soLJl4xptd23uQQvkWB7IxrklGrYZzZRWsFckJty+ghzzty3+pyz0HgwvgV7Q308qvDevGYjzkbSoRtxnT7sfWYl6ZV3H/+4+NQDJHGQ87vts5tXVRWVIyWELiyh0OJmsUO6bma5mGJHvIWfOujRoR7S0vBZJXSyuDEBzDGnb4KrYQYD1LzficKdFa00pvXlX9JYgwFH4+THre5avfZFN4ShIPBRRSeF5Fb9aAr9r40/wbloyXoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dHetD7b0iANOwxLEzIIhmux9Ix3UYv40GAapoXweAUA=; b=X85zikLeey9526W3Rn9npbcAUrgs9y2QFMcxgoj9Q4cZ0C6FqykpqOxtM8Jmtzcda/8IvGv990AKLhD8BG50oYdhpfF8qQhG4+0lU3s8GPqlvI5ZCzd+pWjd3DQTJAm45vkmDvpB+1iFiP4nRWdfQl3lxuzX4nKeN2nv/b78Q5ksFDYMQ/JMLAofkEmzlF1R7yR/+gDoovGbw5M3nsbP7Kp1gJfjylkJXQNKQuHbdP0P2FKjpVUX2UQzyIFwJmN+GIuS99fI4xQqArBYq1NxtU2hFAacvU0KOfUbPgxq9ZyqLuY/Bej8I9r4BhSl7Y9vf4cHpHVpgX9tJVpyT1pK5g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PR3PR04MB7403.eurprd04.prod.outlook.com (2603:10a6:102:8b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.11; Fri, 26 Sep 2025 12:33:57 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9160.010; Fri, 26 Sep 2025 12:33:57 +0000 From: Peng Fan Date: Fri, 26 Sep 2025 20:33:18 +0800 Subject: [PATCH v3 4/6] remoteproc: imx_rproc: Use devm_clk_get_enabled() and simplify cleanup Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250926-imx_rproc_v3-v3-4-4c0ec279cc5f@nxp.com> References: <20250926-imx_rproc_v3-v3-0-4c0ec279cc5f@nxp.com> In-Reply-To: <20250926-imx_rproc_v3-v3-0-4c0ec279cc5f@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Ulf Hansson , Hiago De Franco , Frank Li , Daniel Baluta Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1758890010; l=3249; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=/+qAXachW8UJdl7xjt5l3dl4HFy2UlQ+gsMiBYhAO+Q=; b=c4Qfm2VghJX2Bp6kNCepsfk1iUuOwFObhjD06oCpcwnrceqw9/KCwvrK9G66Op8VyXt8ub+rt et8QAk7kDUTCNietqegXDDdTUSkgAmi/6LNuOSRWE6txu1i5sVesDok X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR03CA0115.apcprd03.prod.outlook.com (2603:1096:4:91::19) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PR3PR04MB7403:EE_ X-MS-Office365-Filtering-Correlation-Id: 3c821b91-c917-4c62-c347-08ddfcf8f638 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|19092799006|1800799024|366016|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?SFEwNmRUOGNjcjJhY1NteFJmTjU3MVFvUlRyQnk5VmVyQ1h0aDB2VWcyVWh0?= =?utf-8?B?aWxkRjdjVml1RkxGTytXTXMwSVZOTndBOEcwQ3d6d2RVSVdidDUwczJHZGFJ?= =?utf-8?B?UTJmMDloTUxSOVRQMkdFZG01OVVyRU1qSHNFc0hmYjByc3JxeEZFcDcvekMr?= =?utf-8?B?N09sTmhkSk1SVndjZkxtUEJPRlU5M25TOVQvRjFDdSsydm9kZUNlWkFRQjht?= =?utf-8?B?bSt3ZGVIQjdueVpXNzhDeGorUUMrN3MrNHNFM3Y4NUJBQVBwSW12My82UnVZ?= =?utf-8?B?TlNwVlMvbUpPZmU2VFJPbmhPQVU2SmhiS25Ndmh1TUpPenNqMmtPaEF2RjUx?= =?utf-8?B?RnpSV2M4dG1nUTZFZ2hqUm5JMHpwTGZLS2RJQXl6ZDJrYmRPSkNORkFaZWNm?= =?utf-8?B?TEhXdnRTNmxtOG10a3BlbGV3RWp1aXdqQUQ1RC9rVXJ2MUtBZTV0cFh6RXQ0?= =?utf-8?B?bTdydkRBWVFJZUNXblZuVGZrNkMwR1ZCZ3dDZmtOdmhqZjFTK2NDaWQwUEcv?= =?utf-8?B?TTVBMnQ0UjFHWUVRQk81dWszT1NHZWNZMkxDWGlMQXJUV1MyZkg5a0ZuWHNB?= =?utf-8?B?dWJqeGFhelo0ak4xbnlWSk15U2xqOWZWVVcyblFzOHFrbHd5MUpTdWhqV0xy?= =?utf-8?B?YXo4dnZ3b1ZlSjVZWUNmamkwazFwUVZQbmJGRitsNzNLcFd1dFRrWWUzRUtO?= =?utf-8?B?aXdCNEp0WlJkUDVqdGhKdVZoeTZQU002ei9iSVBvQ1p1U1JpK3JuOGgyMjB6?= =?utf-8?B?TUdSNVhVTEhzRllzdSsybm1HRy9uSWc0akJya2R1UUN0VStPUEcwUDgwaUFt?= =?utf-8?B?VGxJaFlQK3JqMDRJRG1jYXg2T1BNNHh2bU51Tk94MjY2eVF1Mm9PQ3hKZlV0?= =?utf-8?B?VU02VEJ5RnNSamFOVTYyVE1VK25tUXFta2Q0SGtBV3dLUTFBZUJjb0NwRk5O?= =?utf-8?B?ckNpclVnb3pKZ1hwei9PVGdscnZHS2lPY043NUpQMWR4VllzZHFZbld2c3NT?= =?utf-8?B?V0kxdkpNWEhDZ0d3ZXV3VjYybVdac0hiSUpqUHdEYXdkRC9yOHErRmwxV2Nk?= =?utf-8?B?SWVQbXp2Q2lKTjFWL28zaGpROXRFbkFvaEZveGM5YlFtcFY5enJ4NklSbWg4?= =?utf-8?B?N2t2S3JhcFJtaGErNEZ2b29qWWlUYnoxV2VabUxvVTNVRUVEWjJGVFpEMHNO?= =?utf-8?B?QW9CNUx4bmRoZGttRTVCdGs2RVN6Qk9vYzdrejJiM3VnUWFlbEhKNVgrVlVs?= =?utf-8?B?NGVOWE96RVZreWtCbWNvcmhUMExMM3BRUWRvWnozT1FKWjZUekxhSVV0UXF3?= =?utf-8?B?WnRVYSthUjZOdS9hN3FBWXd3YjFWRFN1UWNSaGI1U2hQSUYyeGVOR2xNS3kw?= =?utf-8?B?eForYUpWK2pFQ2lkWHJpdTJJYWg2SVFZQWdWZVBKbHZkYzBnUnd4VVUvSktR?= =?utf-8?B?Y3ltTGY1WHNRUlVaYW9tcC9ZTm1nUjR1MzR5ZmhQN0dyemFsMi9yMHQ4TTV1?= =?utf-8?B?R0VucnVKTGcwQWV4ZU9BdkEvcG1Kbm1wdWQ1MVBUSEdLZmhPUkc1N2dhV2NJ?= =?utf-8?B?dTM4L2M0UWJ1eEIybUJzNzZBdU1jV1BPeEhhY3dLTWdRNFU4L1hWWXJlZnd6?= =?utf-8?B?U0pNb0tyeTg3Qjl6dWZNYWNjOFZTeEdZblYycHBpRU80ZTNDelZPM1VsRjB3?= =?utf-8?B?K1VDNXpxVGkzQS9sdnJ0MHRVN3hISUEzL0xJcS95OEJKVWloWTlsUFNjT2dp?= =?utf-8?B?TnlYNkVDaWFVTVVnMjRVTlV0eE81dXpHRU01Wkg3dlZROGowMnUzYzhXMU54?= =?utf-8?B?ZVh0bkN2amRGMzhxcFZXNExBV3gyd0pmQ3lBTFlvY1pDa01QZ2hNMUJTVklG?= =?utf-8?B?WVFHU09rYnd5ek56Ny96RWo2VlEwd05ITWJZRWpwdFhmU0tqS1hDbnFvbWha?= =?utf-8?B?amdjQzNqcjlybzhUVEp5a2lVdDFqdnRUYnBMbGRic2wrL2N4cWpSOXRYU0w2?= =?utf-8?B?TGV3OTBLckpNZHJTZHNnc05pUlpoTnNLLzZyMEV4Yi8wMmpVWjJ0Z0xic1oy?= =?utf-8?B?ZURjQTRxK3h3elZhMnZGTng3eTYvTzZaRnlMZz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(19092799006)(1800799024)(366016)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eE92VFJWblRMN0lWbFNWNWM2STd2N0hVcjg0dlhEY1YyY25tTGJCc3N4RFE1?= =?utf-8?B?djF3WldOdTMzZW53RjBTUGRLdlZXV1hzeVZyUmxUdU9USFZ6R0tVNDFjVGE1?= =?utf-8?B?UXNlUHdnNy9CTUdaTXoxdzVrWlhIakZhTkNtSU1sTmVvZTlmT2tGWCtzaUE5?= =?utf-8?B?RkMxR0E4VGljckpSYkZ0UHdoUmgrM3BKSVo4S3l5eVl3U09RaUVEbkR0VGpv?= =?utf-8?B?Y1pDOVFSd1oxQXFWRDIzT2g2czE4M2JmSTRCaXE4R0srbThyYVNSM1lHRWNR?= =?utf-8?B?QkNocjJ2UWtRNFk3TmhHMmw2aU9GaXJKWG9JcmhoVERFbDMxemo1bml3MUt2?= =?utf-8?B?TW0zSk1wVENlN1NBZndpRXlWcXZkalMvSy9zYTZJSW04UWhpbFdmV1ZSN1Nk?= =?utf-8?B?WmtJeDZ3Y3NIYWhYcGJLMVArZXp5eStpRloyR0NLLzJJVis2L3dUS3BzR0RI?= =?utf-8?B?dWhRMHgvalRTWVBwdkhvY3doQmVsNHNabjJLU0ZJYjI4MUpGRmxRKzF2RGdk?= =?utf-8?B?Z24xc0NiTFhML3dnQjNOWlRMaVhWSTZtV1AycjFoL1hDd054TVo0My8xZlNq?= =?utf-8?B?V3Q3WHZQNi81Sm56alZHeHRMTlE3d0JuT1pqNDhsLzBVek9walNGYzF0Qklx?= =?utf-8?B?OFUyWG03cHYyRlY4alVjMWpuSll4dSttSlNWVVF6ekNQbDB0VzFOWElkRXcv?= =?utf-8?B?S0EvcVRtRVZDRWU5Ri81SUplNkN6enluUzlRWTN0ZVBoaXp4M2xTN1BKdVc1?= =?utf-8?B?ampYVDlrSUZHQStmZTg5Ujl1b1B5cFJEK0xqMXFSa3cwVlZ5TWNRR1VnWkFC?= =?utf-8?B?ZHkxRGtMY0RmZTgvY2hsVmxaQ2d3d2tWditjNlgrcURaSU85dlFHcE1SWDRW?= =?utf-8?B?Q2VoOHZkbGNibE1tc1E1VHNtRko3WDZzTmhrTklWSmtUZGRzd1paQ0U0bm51?= =?utf-8?B?bHBRQlozbDRFVXpkNWJjektzcUo3ZHBaRUhlR1lHdk9sL2Nvd1Zxczl0Umhp?= =?utf-8?B?QzlOWmJmS0RydE1UWmIxdkkzNmVJclZPcng2d29lWGtGa2ZkM3M4eE9DTyt0?= =?utf-8?B?bjZHTEZkZHJmKy9QQmVtQnVodFFiZTRwZisxbnB2K0hXWkxIVmU5L3M2Rm02?= =?utf-8?B?bjMyVVREZXNqZXAydmQ3ZFBxVU9RYXhJQlZFTUo2RVc4SFgvL1FmVWEwR3Rw?= =?utf-8?B?bnpRN3pjUCttcU1yTG85UWpVREZqZitWMzdXUTB3Zk84SVhxUElXTTZ0VFVa?= =?utf-8?B?ejBUUVBqSTBaUmluNnVvTUVFV1R5MHc4ZlJ0djRWZ0xwR2ZlRCtWbVhjNS83?= =?utf-8?B?dGkxUEw2WEo3WDlLQzFXT21yZzVlL2M3bDZPN29ZSXNRWHBDRGtEdkk3UmFR?= =?utf-8?B?c1d5MzE3QWlEdm0zZ21kRnBZdXkveDhmaEl4RjVzOGs0elkrbm1PdmoweHNK?= =?utf-8?B?VzlsdUYrdkh1VDRxQ214YURyOWQ2T3ptd0kzZVBGTENJWEJ1aU1ZalN0WE1v?= =?utf-8?B?L0RzYjluWksxM0lLWkFuaTdFRXZZNURPRWFidTBYL09pUjVOTWlLN0x5OHRo?= =?utf-8?B?aytNU3dLTXU4Wmh0STRTMUJERFhxT05IVHpEZVFVb2ZzZ05rUS90bFQ2NWh5?= =?utf-8?B?eXRhNVhCcFpZbzFSN2NuRGluMkNhZGFmeXdORGRsbmplMXVVd2NlVDFZa3Vh?= =?utf-8?B?djdrWTFKRW5vTHAvYzArQTJxTGxvN2FqbnJIT3g0S2xxYzgzdnlyK05NanYw?= =?utf-8?B?S3BjQXZZUU43d1h1eHVuODVsRFFDaEhNMXJJMGhDd3I5djMrM2dyaVNQdzQz?= =?utf-8?B?M1V6NnQxM3B6SEJZZ0RKNzIxZE42YXZ3UEVkck5NNDdhSExSWGVjZGZHUXlE?= =?utf-8?B?QTJtV1VqZEpMLy9mNzlOd0w3cWZVQzhsT3huREl5M09uK2lGVmJ6aFcwMlcy?= =?utf-8?B?bmY1RVZHRlp1SVJjRldlRk5EK1VBSExKOWdZRlJ6MHRmV3hBK3RlT2I2U3V1?= =?utf-8?B?RXNObDJVVHhmOENTSkZOMTJ1TGV3OUJ4dkRDUkY3Y21TWDBPdzR3ZXhzRmRG?= =?utf-8?B?eWtPWXJmeXNDSnBYS250dlVQVTAvVjk5dTl2cFNINWJZbWFnOEtmMUFOMmM3?= =?utf-8?Q?y9iszI6G0oNKXW0bzHLbxZW3d?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3c821b91-c917-4c62-c347-08ddfcf8f638 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2025 12:33:57.3912 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fV94ZqlEZQuYzvslwAW1XFmjOUlN8qJvS/ihp4Qj4qdx+yV8eZl5XTaLvMJaPXqYdnqcmmjJ+H1Zw8i0p+0bIg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7403 Replace separate calls to devm_clk_get() and clk_prepare_enable() with devm_clk_get_enabled(), which combines clock acquisition and enabling into a single managed step. Simplify the probe logic and remove the need for manual clock disable in error and remove paths. Also, update error handling to eliminate redundant cleanup steps and use return-based error propagation where appropriate. Improve code clarity and reduce the chance of resource leaks or incorrect ordering in cleanup paths. No functional changes. Reviewed-by: Frank Li Reviewed-by: Daniel Baluta Signed-off-by: Peng Fan --- drivers/remoteproc/imx_rproc.c | 22 ++++++---------------- 1 file changed, 6 insertions(+), 16 deletions(-) diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c index 3260fd55a713994e1d39cdf677265edd4192ae45..f353a680ba993dbe3dd7866ca72= 5d18aa58303a1 100644 --- a/drivers/remoteproc/imx_rproc.c +++ b/drivers/remoteproc/imx_rproc.c @@ -1006,26 +1006,19 @@ static int imx_rproc_clk_enable(struct imx_rproc *p= riv) { const struct imx_rproc_dcfg *dcfg =3D priv->dcfg; struct device *dev =3D priv->dev; - int ret; =20 /* Remote core is not under control of Linux or it is managed by SCU API = */ if (dcfg->method =3D=3D IMX_RPROC_NONE || dcfg->method =3D=3D IMX_RPROC_S= CU_API) return 0; =20 - priv->clk =3D devm_clk_get(dev, NULL); - if (IS_ERR(priv->clk)) { - dev_err(dev, "Failed to get clock\n"); - return PTR_ERR(priv->clk); - } - /* * clk for M4 block including memory. Should be * enabled before .start for FW transfer. */ - ret =3D clk_prepare_enable(priv->clk); - if (ret) { + priv->clk =3D devm_clk_get_enabled(dev, NULL); + if (IS_ERR(priv->clk)) { dev_err(dev, "Failed to enable clock\n"); - return ret; + return PTR_ERR(priv->clk); } =20 return 0; @@ -1127,7 +1120,7 @@ static int imx_rproc_probe(struct platform_device *pd= ev) imx_rproc_sys_off_handler, rproc); if (ret) { dev_err(dev, "register power off handler failure\n"); - goto err_put_clk; + goto err_put_scu; } =20 ret =3D devm_register_sys_off_handler(dev, SYS_OFF_MODE_RESTART_PREPARE, @@ -1135,7 +1128,7 @@ static int imx_rproc_probe(struct platform_device *pd= ev) imx_rproc_sys_off_handler, rproc); if (ret) { dev_err(dev, "register restart handler failure\n"); - goto err_put_clk; + goto err_put_scu; } } =20 @@ -1144,7 +1137,7 @@ static int imx_rproc_probe(struct platform_device *pd= ev) ret =3D pm_runtime_resume_and_get(dev); if (ret) { dev_err(dev, "pm_runtime get failed: %d\n", ret); - goto err_put_clk; + goto err_put_scu; } } =20 @@ -1161,8 +1154,6 @@ static int imx_rproc_probe(struct platform_device *pd= ev) pm_runtime_disable(dev); pm_runtime_put_noidle(dev); } -err_put_clk: - clk_disable_unprepare(priv->clk); err_put_scu: imx_rproc_put_scu(rproc); =20 @@ -1178,7 +1169,6 @@ static void imx_rproc_remove(struct platform_device *= pdev) pm_runtime_disable(priv->dev); pm_runtime_put_noidle(priv->dev); } - clk_disable_unprepare(priv->clk); rproc_del(rproc); imx_rproc_put_scu(rproc); } --=20 2.37.1 From nobody Wed Oct 1 23:34:14 2025 Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11013032.outbound.protection.outlook.com [40.107.162.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A06102F60CC; Fri, 26 Sep 2025 12:34:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.162.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758890047; cv=fail; b=vGIztrAcyngnAY7QoN1A+ACEeXQyjTNqryvPB1kFwJ5uOXy2OJDhk18fpjHShcfzCQ1qq2hCAImaCy75jXbJ4tyhLSMZZONCA55r5g9AJgsNuKlS/6LyYcQZMuxsKUUb4L9ppWFlsiUHiCuXkYI1q7wbPRPBrMn1UQeImCAVoLo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758890047; c=relaxed/simple; bh=ThVM9QQ0Qk3OFoF3y+fb9ELiyROMhLoYGG+/CisjIVc=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=FfAarT2To+3JRn41offwqW2z9bRx+QZGnx3w1RfIqpikqlFWYnF/DvRLzSaLsVjBAUuWbOGF8bp5fjyxYNii+DC9zERA/MZFJ9xhc/A890+lvgyl9DQGPYdNdrgvXt5N2QLtFDagci9EFnO+Gy0gVGYYrfsaKMt1wYT254idEVM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=ZeFqTC1V; arc=fail smtp.client-ip=40.107.162.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="ZeFqTC1V" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KJqK35l4QD3EAoHnJM77XVhpduwkHCvIMVhnf91Fyd0V3P9fARNpZp2g8dHPmxpEKDgVmW14Svg/BQWU6Gta5Y82qmfeTrEOmprq1351NxQO8ElUPN6Zx6nBoGbant/cBePku31J3fF6Z0lCEQCFkF1cgQIGwnBZfmmJl2wUZHQjWxjCbdT3mGmtjwIs2EDT6Phx63nhlVJzjfma6+RugLrdB/0wDtCsglzxRgdOUVewV00MpN6b1MlOavgJsFiI187VUvKAGwyT6X1nOq8Yg+hEZnbiaHXYaCGkYrpsTW5xUIoUJV+5XnlgHXY63onKadhdtvOpby8vguG3cP1Lpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OjjqCc4dXJ+KKSx4yMVaROt0kY/ipC4qW9omWUasLJA=; b=mmLiC6ntj+pICqRg8yRa36xHiq/UKfsyUT1zH+i9bhNEUTsF7YywJAk21V6IRWNRFcfLFJ/PSMyiqTOM+VfQLMdaUwt7aQuQhLYw0oTwyRNQWPOq+OPKYjCRbVeTmgiyzyobFCdCGlpYVLvEJbeZmXomef/+1o7h8+RhKGPQOquRVZyZiEwnQaalV10hiPNkOEVUamFP4pQsny8W9Aw4ImO7S9dWsTAqp3D9Px8gPc8z6K+WqL2em8Ovm8IxtaQKw6pBe8i4aJsXbB1YSY6NT4hlWUiansH5kC1Us0h6N2a698mlql+qIjRAzAQuBVLUwj6hQ4ABI+N3YSZU1qFxkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OjjqCc4dXJ+KKSx4yMVaROt0kY/ipC4qW9omWUasLJA=; b=ZeFqTC1VQ9NOmXQSUDzWrlxYduJ34IBl919GNsAnhhPW3s+Uo2FuGGGFwZck4K3+gflR4MYmIsiWB2TsucmRmMIy8uqaQhzv8gPNi8zc3n9rB5E23JOwqVi2DMU1ByQ4A47LqIq4CfKymL7LLX6PcOrMInUapfn66as3iCTiqc5kajbuCnc8Nio3ZrI2/l2/2INoGkj1mWUg8FMqStLlyKuHQ7fRdTvg6LQOmFfnbknr+mLPu4vDaDJ1AoSOmyJqxlsYxojlu/FbfgJBtEsmBtyHAcVVPNKELTERHunruH0E3ZJpgsv00eyLp7kXvqLy5b4oWSr0Yb0zyueUT5qOAA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by DB9PR04MB9646.eurprd04.prod.outlook.com (2603:10a6:10:30a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.13; Fri, 26 Sep 2025 12:34:03 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9160.010; Fri, 26 Sep 2025 12:34:03 +0000 From: Peng Fan Date: Fri, 26 Sep 2025 20:33:19 +0800 Subject: [PATCH v3 5/6] remoteproc: imx_rproc: Use devm_add_action_or_reset() for scu cleanup Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250926-imx_rproc_v3-v3-5-4c0ec279cc5f@nxp.com> References: <20250926-imx_rproc_v3-v3-0-4c0ec279cc5f@nxp.com> In-Reply-To: <20250926-imx_rproc_v3-v3-0-4c0ec279cc5f@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Ulf Hansson , Hiago De Franco , Frank Li , Daniel Baluta Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1758890010; l=3930; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=ThVM9QQ0Qk3OFoF3y+fb9ELiyROMhLoYGG+/CisjIVc=; b=y2okUzfaLYR2XbAr8NyFCVZdIv3i5LKp/NPSnuePQptJHyMugr+KPzyx/dvekYngzbqBOSmde q0geQfpc+ZkClk0n9kWsMZI6si5vzqTeIP93Iyfcrsg4Cb1GEY75BY8 X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR03CA0115.apcprd03.prod.outlook.com (2603:1096:4:91::19) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|DB9PR04MB9646:EE_ X-MS-Office365-Filtering-Correlation-Id: 439f5555-d915-4148-d257-08ddfcf8f95e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|19092799006|52116014|7416014|376014|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ZVFZYS9BcDBoekJtZXM5NGFiWUZNODNrVkpKZmlncXJoT3lQZjF6Q1dodmZK?= =?utf-8?B?aDNIbjluRXZocHV6Q3lLN3hHNHRZeFhobi9XSlBRalB6NXlqeWNRaG5pSWhN?= =?utf-8?B?djVZV3JJREwwcGV4RGZHOFB1OFhSeXdzbjVOWFlOakU2RXZMU3ZPRWkxWlFE?= =?utf-8?B?M2NFbXZ4WFZ2S0NkdjlkR1ZHV1BiaWs3M0xYMm1VT0lCT0tGUktlVHVDTXh2?= =?utf-8?B?L3p0ZERobUVqNy9TWk93RXB3WkwvbDhyMFY1eUdJbUxRQUlRc3VOZ2Q2dElL?= =?utf-8?B?a2p6UHN5T2YxdEk2L0Y1U2ErMitoNDRaOXhIdFRnZEtrU0hnSXhVRzVsRW9Z?= =?utf-8?B?VVltd0ZsZXc4R0lYZEMvWjNYY3JycUltL280NWlXa3IwSldyVWx5WUMxWU9S?= =?utf-8?B?OHdjdHV1eDdjRHcwQTRvdnBRZjQrZnA4dkJ4eEhKRU1MdHhKalBuOWZVN2lQ?= =?utf-8?B?c0Rnbkk4U3JhVStVTHhzRVQreHMwSkpXUWZqRGtFcU5NajgyMDJNQTlPQzcx?= =?utf-8?B?cElJUGtESEZoMDUwa2kwRi9qNkNwZktEd2E3OThsdjVPV1huMTU3ZGZvdUY4?= =?utf-8?B?T1ZmRWt5RWpxR29mMWFweThOOFdiT1ZQTmhLbVVCK0pCSER5VnJRUnZzV1Zz?= =?utf-8?B?MmJyTWtpeS92clJIMjNab2d2eE5LY0VpbWlNdDdGMUNaVlNnZ2Z5YWd1SURS?= =?utf-8?B?dHdPUDNHUzVFOTYrbExncGtTb2IwR2pTVm95RTRBWHQrc3FES3NQYVV3NzRX?= =?utf-8?B?TUc4b2Y4V0RtZ1pHMjdscnBieFdOMSs0L0hKTFQ5ckk2cm5zNG5RWUlMTmpX?= =?utf-8?B?aXFzdXM2di9jRHNleWppMkpVM0VXTHJ4cW9MUTVESjM3YmFjN0xiV1VCenJn?= =?utf-8?B?UlJ4YTRVMXkxRGpqS3Q5Tm9YdlBmdDN5V01tWU9ZaGd2bDVLVHd1cWtxNkF1?= =?utf-8?B?Zkw0aXR1eTNDUFZMZ2pMb0RVYU5vdFdkalhKMDBKY21UaGpsSVZLQjVLcjcr?= =?utf-8?B?ekliWTNNazZxZWpHQTZzUFNXVEpzckFnOVpiZStCN3liSWFxM2MyVXVJd1pT?= =?utf-8?B?YjF2L3Nqb2IyQVUwSDNwd2dtdmZoMWFkMG5DRCtkdS90enp6dnd5dUhOdUQv?= =?utf-8?B?RDh6aFMxRWFRRENyU2RkNEt6bTUvcXN5YjhSdVlFcUtkUVpnSlhhQW5ZSUt0?= =?utf-8?B?bmhENEU2RmJDS3hJRkE0Y0QvNVkzZkdVRFg0REtHb0xvVExnWEJzckd5ellH?= =?utf-8?B?N1QzQ2lTSmZhaHZxL3lzQVhCOHJ5Qm1VQTA5bm8xMlVBM3EvOUNlaGdZeWll?= =?utf-8?B?VzI0azYrdzJkSXVhdStIaGRNOVpEN2lRazUzVEpzTGtyZ3BpSlpueHdBcGVU?= =?utf-8?B?eXY3WHhRUWVyQXV5N2VDT1FWL3ZtOGxQaVp3WFQ3YmxoZEtsTS9wZWMvRktQ?= =?utf-8?B?eWxEYlNvaWkyaHJzQ2NTanFlZmNqVzd1ejl3OExLcVFlZUx2cHMwcHZxUk52?= =?utf-8?B?b0ZlNm9ObXRjVHI2S0tXa09WclZIaXdkaWw4UVROdWo1bzE1eFJYV1NaSnpU?= =?utf-8?B?U1c0Q2NaM3JuUStMdUZCMFdiUVo0eDlTY09yc2k5TTdlTk4rS2pBdlQrajFz?= =?utf-8?B?OFJ1UGJ5dTRmekpxMm1CNkFISG9CclA5RENXb2NydDRDd0VOeDUwTXFWWmgx?= =?utf-8?B?a0ZFYjdOV2JiZlBFTHRZL3hNYTEvT0FVbUJNNmJqYVVDb3VpRmMrQjJtZjJo?= =?utf-8?B?a3A4dWVSZjlNNTlhMjJ2Uy9NeUJYWGRuby93dzRQZzRPVEhFM21RcXo0VEN6?= =?utf-8?B?MXFTL0tKVE1relZJSnhKMFpDM2QrL2tHeWZKemZ0bjF6aWlPblRpdFZWU0ZM?= =?utf-8?B?NjBrZ0hESkhqbUlId0ZaZWpNVGg2WVZvR2EzZHRIaktqVUUreG1XdmdMb2hH?= =?utf-8?B?N1pPeHNHTDVHTERPUk8rd3dTKytRT2lXY1NMY1ZkRnZlUmhKbUJUNWwyYnVr?= =?utf-8?B?K3RXVU84TzBlTkorcVBJU21TdG51aWI3M1BEU2NkUUExYTJobVhhYTlTbGxn?= =?utf-8?B?UW5FREFETXU4RVZqRG5lQUNqM3dMUnlkV1B0Zz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(19092799006)(52116014)(7416014)(376014)(1800799024)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NWR6bnNxNFdmM1pnV3ZPL1F1bU0xZGFXcU1aZUptZU5vK0tRWUdiT3NkK2t0?= =?utf-8?B?R1F4MVBYVThpaE9XOGg2OEU0aDZsRDNhVmVGZkkvbG5DNURRQ2hsQVZBRkJm?= =?utf-8?B?TU5GWDRNSGV0eXN2Q0FmWHpuWkpsdUlvUXlNNEt4VE9EeTdlOGdaU043NEZu?= =?utf-8?B?Ylg1T1p1M0xkazluaTJRUnErUUZkWnpqRlV6ZWt5elpzUHcvYnR4WGxUdnM4?= =?utf-8?B?UGxvMTR3N05TeXRGMDh3ajYyRXg1RFR6ZkVPQWxSZCs2OW1paGx6RXkyS1Bv?= =?utf-8?B?U3Y1NVlwV2xGQUllNUVnWG9qaTB3L3p3ekE2RU1DKzJ3ZWVMYW80TG5obzFk?= =?utf-8?B?anA0UVRsR3l4dE5ZUXBlSzQ4UEwxRmtXeFJ4ZEZKUWJmNmZlVm04VnRaZHJk?= =?utf-8?B?VnBxYzlFZ3N4UWxJQ2NrRjR4VnlHRVdvWDF6akZlZ0cwaXNuWitFMXN3a3Rz?= =?utf-8?B?emVsNFJHYlFud2huTFVJTXJOenlmR3B0L2hVMjdReklIQ05uMWpmYzloNDJT?= =?utf-8?B?UnBadXM0RU1NWHlobWlxNDM4bGpzSEhlQVo5Sll2eVFOcG9HTjkxS0NhRTA5?= =?utf-8?B?cHBhVG9uKzJVZkJDRlZ5WGllOC95UCtlNTJlbjBXYklpbFhwY1duZEhuQWQy?= =?utf-8?B?N1hCa2x5VVkvbzdNQWxPRDVHbTI3NmR2ZDcxd3htL2hxU0NuWG5sSUtHRHgy?= =?utf-8?B?MnRlbFo1bUNCQmpKY1ZlM3llK3ozaXlvV3BFSThDNUNac3FhSElCVHAxUmRm?= =?utf-8?B?R2U4NGk3bzJ6a0VVS0dxRFhJRmhmQmFQU1VVRVVwQStrMkJhcHVFN3dkczgr?= =?utf-8?B?cUk5dkxld2dXbHgvc05sM2FUM3RwMzV2OWRMcUtPMFMxc0RGL3JXcWQ1dmNO?= =?utf-8?B?cWo5ankvTHJHeHg4cE9TbVYxY2VnNkMvU3VGRnhBai9RSi82WlVhS2x0OUZz?= =?utf-8?B?Qm5lMkhDN0pZSEkxMHIxWS9IQUNla2N3UW1LVnlBNTYrdkJKSEdWTDlIT0x0?= =?utf-8?B?dXlFb3hJeDR4TkY5WEx3SHg4S0JEelNlakFjMVZWcUJCMUU1WlZINXZyNnJZ?= =?utf-8?B?dXMvN2NQSzRMQ3F2TWlOY3FSazMrY2R5MFFvVHhWZmZtRzRld29LUHZyTVpw?= =?utf-8?B?ZGxNN0d4ZHA1cUQyODlNdGZxZklVMVc2bE96Ni9PTmR2c2xLaUo5OFFtUC9Y?= =?utf-8?B?UW04T3gxZnY2MnZTSDhZb2hHenBzdklETm9FWDI1ZVlTSkFob2ZLMURNUXg2?= =?utf-8?B?REZFa0ZEUVZWd2QwcWpMU1VTcTIxc1FoWUVRU2FKTnhnOWtHM0tzN1FITUU2?= =?utf-8?B?UEpBOXo5MGNhRWtKWFB4czJmMlEyekJBS3BiS2paOG10eFlUTy91d2w0K3dF?= =?utf-8?B?NWQ3SWhJdEt1YU1RZms5Q2RoaXdheEZldjRvdnBkVGl5V1U2L3FRa0l2QlYz?= =?utf-8?B?TnlKU2hSbG0wN3VlYnR2Z05hdmRnTW9TVHYrSzhrcFNRT09ySHV4R21FYldI?= =?utf-8?B?U2VONFRnQkZzSWlmeTVLNEV1OTFxTDZPaU1Fbnpxdm5GSGtUOHhqODV0RlJj?= =?utf-8?B?RlNmZzd4K3JKMVVXMVdwOXNhL3ZJSW80bTBJUWRkUWxPS0YwMEZWK3ZPcjNy?= =?utf-8?B?ZGR1Nm44dnI5T3NoVHlxVllIeG9jNjRqV29PTmhoMGFGbjJIL25RMGpWSjBJ?= =?utf-8?B?L3llTTRQdDZ2eDVvUDdQdWsyMWk5SFVoZ3RFRlVVQjZEdEx6YjY4cEx6Ymlu?= =?utf-8?B?Z2NkcFlvajJkYXlHNjhqMVJnRzdwaThRcmlsUjZTbjJhY3lNVzRGbmhUR3M0?= =?utf-8?B?U2FyVWYxRWlsYVZaQU43RTJKcTlVTFlSRERkZXFuZ0Z6NjFkSUUwZXpGTXFy?= =?utf-8?B?UTBESFU2SDYzMUFoSGk1U1FFRGRJYTFpOFI1U3NUSVNpcVBXSFBIMFpFMUg3?= =?utf-8?B?TjBkV1JteVdlNUpIcFF6Zkh6cGl3YVd4bmtjbzNlTDJaQlJWdDhaaFhIcERn?= =?utf-8?B?aVRXMDB0SzBEYjgxbHF6MSt5U1lFTXY0N1BMV3JqNHJrUjdrRW5kN3NWUG42?= =?utf-8?B?eFB1NjhqZS9vcVpFbURWOFdMeWQxbE0zMUxINmdObGVjRTFSNHZ0Z3pJRnND?= =?utf-8?Q?okmyhCEpzWvJ9kzFw2dvb5QIF?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 439f5555-d915-4148-d257-08ddfcf8f95e X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2025 12:34:02.5210 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DQWQ541eNBKJ54ZbCMjCpTAl/7R4NKQRR+hc02UQpN+eClhNVAzanfHCnkLnnylnMN3BaSD2so+QWFGyJPT0ww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9646 Replace the explicit call to imx_rproc_put_scu() in the remove path with devm_add_action_or_reset(). Ensure proper cleanup of scu resources and simplify the code by leveraging the device-managed resource framework. Additionally: - Remove the IMX_RPROC_SCU_API check from imx_rproc_put_scu(), as devm_add_action_or_reset() now exclusively handles SCU cleanup. - Improve error reporting by using dev_err_probe() for consistency and clarity. - Drop the err_put_scu label, as it is now redundant due to the updated error handling approach. No functional changes. Reviewed-by: Frank Li Reviewed-by: Daniel Baluta Signed-off-by: Peng Fan --- drivers/remoteproc/imx_rproc.c | 35 +++++++++++++---------------------- 1 file changed, 13 insertions(+), 22 deletions(-) diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c index f353a680ba993dbe3dd7866ca725d18aa58303a1..76feda868cb619b79922bcee4c6= fdb3e16fc81e3 100644 --- a/drivers/remoteproc/imx_rproc.c +++ b/drivers/remoteproc/imx_rproc.c @@ -796,13 +796,9 @@ static void imx_rproc_free_mbox(void *data) } } =20 -static void imx_rproc_put_scu(struct rproc *rproc) +static void imx_rproc_put_scu(void *data) { - struct imx_rproc *priv =3D rproc->priv; - const struct imx_rproc_dcfg *dcfg =3D priv->dcfg; - - if (dcfg->method !=3D IMX_RPROC_SCU_API) - return; + struct imx_rproc *priv =3D data; =20 if (imx_sc_rm_is_resource_owned(priv->ipc_handle, priv->rsrc_id)) { dev_pm_domain_detach_list(priv->pd_list); @@ -944,6 +940,10 @@ static int imx_rproc_scu_api_detect_mode(struct rproc = *rproc) else priv->core_index =3D 0; =20 + ret =3D devm_add_action_or_reset(dev, imx_rproc_put_scu, priv); + if (ret) + return dev_err_probe(dev, ret, "Failed to add action for put scu\n"); + /* * If Mcore resource is not owned by Acore partition, It is kicked by ROM, * and Linux could only do IPC with Mcore and nothing else. @@ -1103,7 +1103,7 @@ static int imx_rproc_probe(struct platform_device *pd= ev) =20 ret =3D imx_rproc_clk_enable(priv); if (ret) - goto err_put_scu; + return dev_err_probe(dev, ret, "failed to enable clks\n"); =20 if (rproc->state !=3D RPROC_DETACHED) rproc->auto_boot =3D of_property_read_bool(np, "fsl,auto-boot"); @@ -1118,27 +1118,21 @@ static int imx_rproc_probe(struct platform_device *= pdev) ret =3D devm_register_sys_off_handler(dev, SYS_OFF_MODE_POWER_OFF_PREPAR= E, SYS_OFF_PRIO_DEFAULT, imx_rproc_sys_off_handler, rproc); - if (ret) { - dev_err(dev, "register power off handler failure\n"); - goto err_put_scu; - } + if (ret) + return dev_err_probe(dev, ret, "register power off handler failure\n"); =20 ret =3D devm_register_sys_off_handler(dev, SYS_OFF_MODE_RESTART_PREPARE, SYS_OFF_PRIO_DEFAULT, imx_rproc_sys_off_handler, rproc); - if (ret) { - dev_err(dev, "register restart handler failure\n"); - goto err_put_scu; - } + if (ret) + return dev_err_probe(dev, ret, "register restart handler failure\n"); } =20 if (dcfg->method =3D=3D IMX_RPROC_SCU_API) { pm_runtime_enable(dev); ret =3D pm_runtime_resume_and_get(dev); - if (ret) { - dev_err(dev, "pm_runtime get failed: %d\n", ret); - goto err_put_scu; - } + if (ret) + return dev_err_probe(dev, ret, "pm_runtime get failed\n"); } =20 ret =3D rproc_add(rproc); @@ -1154,8 +1148,6 @@ static int imx_rproc_probe(struct platform_device *pd= ev) pm_runtime_disable(dev); pm_runtime_put_noidle(dev); } -err_put_scu: - imx_rproc_put_scu(rproc); =20 return ret; } @@ -1170,7 +1162,6 @@ static void imx_rproc_remove(struct platform_device *= pdev) pm_runtime_put_noidle(priv->dev); } rproc_del(rproc); - imx_rproc_put_scu(rproc); } =20 static const struct imx_rproc_plat_ops imx_rproc_ops_arm_smc =3D { --=20 2.37.1 From nobody Wed Oct 1 23:34:14 2025 Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11011068.outbound.protection.outlook.com [52.101.70.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D98312ECD13; Fri, 26 Sep 2025 12:34:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.70.68 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758890052; cv=fail; b=XIASoQWIHHGSHmNTnf2ezX4C+ZuFZ7J/b9rdQxg57/IGcAWDEj1sYthFwHO9sPSILEySOiAjLajmNRQOo+5oCwtpLt66OvrhFDxQRZBnO1LB6ervRMj1K6cLR8WoaDltPdtuHnuPwHhWTDJeamYHCuUj+pIA+QENHJbS/CRIH0o= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758890052; c=relaxed/simple; bh=T3yV4D5WDQGzqryCNC4B8NU4PrZDdZgkt6+KEo4gt9M=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=oQa7Hjw/f9B0fZlreeTggWuJDmJL645VAL+zr1ZdpBGHSEM3gI94yKE1eezyjrY8RYd3pd1mhKd5AsNA19k/nYQADITKgQfTplAygiMUoj15oLY+CE+MsRDXKCibn+jGfBW9rMc2OYPrS/CDLfRIPfpfU4JIwK1MWCY1DHrBfZE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=jnBhhHrT; arc=fail smtp.client-ip=52.101.70.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="jnBhhHrT" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XBrE2Bgh6/ChI9DpJG4+wyPGpaIL/CmgJz3Ec79X+H7GRema3dJqJcXjP4UKju1iOjnCfFXXdKfIAoG9/ZKXwKTzL1YeTYMTtF1wks1OQY0/MfPYLvFg+pV4FT9H08O6SfJ01xmR51z3y7VmdZhS9AvG+NSkz/7xjISLrv3AJMsgky9N9fOZ1cdgSqVN/P9WeWCOUQRsCZyTGOTZtqlYBwZMDdbjvG9SL2iTUxOhnng2srwaBSjiZXs/OS0/0571oj4Wu6VLeE31YyNtn7jgJlewsCBtyLS4tXv+aNOE5TimF6hnleV1iJTyqchDygL/WFWxK7jkZGSndrmhED393Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JVkK3LV9sVyjvekRsIOBE/54F2PgxKOpYxxesSxfaUo=; b=GjZqp13lnuL0iLvgoEDbbNy2ESmwMHNz0Bo9Ud01lzb3oM43HJW4wYEfkM3+rJqbtTRiHyXF/lYLcogty+JG153Rglvp6Mx8gIiQDfTfFIMaK7xcX/jompOsPzMTy2ncR9MQJVfkh71bddKeVYQlHSq+9fsC0wvkI4xJBZ3cv/6QepSWujuMS0zKydivbKm5KMWYsy9xYaNpadkfNLK+1jviZcyQWkHk91Prqvl60TliulU6EGYaK7NS0n3hmuBTmg55mFgItLcQfDLxPj470ukT3P+Uhu+3OjVtXqQRsz5gjgq4Aqe0pckiXruBA+nLfYRof0xp5c1ovJxFNQ7CKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JVkK3LV9sVyjvekRsIOBE/54F2PgxKOpYxxesSxfaUo=; b=jnBhhHrTOqYKaOBmFVB7TTfjQOdn3n06iXTiaGeZRH1Qj/z3T6Idin0wwjX2aquJaQ1jBCkFmeWmSYXcOPvxaIuCJ4PqRim76aTnmV5ExIEfE6YyAj+AUwApMEtzl6lXJMynNwdnKLDWJVpjvH0/1slLPCB6YMlW5VJZ6XsIfWXpTG1I6ox7YdhFs1psWvcuz5i+A3DkfkQV47O98jE5eAnXM98bIAk4o+NuLEHDixTlbLqS7NxumoUqhsrCvJSkyyl9v8qFTlQd+yWNylgpifbJeyjPyDdwOJleMtkPxO9FwQjZv/xye9U+d5zqtK3KtZY0A81RVxCGu9BYRkZGrQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by DB9PR04MB9646.eurprd04.prod.outlook.com (2603:10a6:10:30a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.13; Fri, 26 Sep 2025 12:34:08 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9160.010; Fri, 26 Sep 2025 12:34:08 +0000 From: Peng Fan Date: Fri, 26 Sep 2025 20:33:20 +0800 Subject: [PATCH v3 6/6] remoteproc: imx_rproc: Use devm_rproc_add() helper Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250926-imx_rproc_v3-v3-6-4c0ec279cc5f@nxp.com> References: <20250926-imx_rproc_v3-v3-0-4c0ec279cc5f@nxp.com> In-Reply-To: <20250926-imx_rproc_v3-v3-0-4c0ec279cc5f@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Ulf Hansson , Hiago De Franco , Frank Li , Daniel Baluta Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1758890010; l=1342; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=T3yV4D5WDQGzqryCNC4B8NU4PrZDdZgkt6+KEo4gt9M=; b=4pRAoluDJixQLoot2L3KBMqEqQYxsXajlGaB65PvaT2QqXKJhrHIYqtSagU4cPSZ+Hhyk1sIB eeoXkSybMpuB54klQrB+HanskJ6Dd0YZV8PQSo/+EnyFgIkjt4SFU6m X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR03CA0115.apcprd03.prod.outlook.com (2603:1096:4:91::19) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|DB9PR04MB9646:EE_ X-MS-Office365-Filtering-Correlation-Id: 933e23a4-d885-41c3-ff22-08ddfcf8fcb0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|19092799006|52116014|7416014|376014|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?NXNSR2JDZGRDeXBXR3MxWHVRQysvNlVGQTdVenJxN0tuanBsR0JlZVBBaWtC?= =?utf-8?B?YXVNTGRYNFZKMlRvaGRNMlluc2FQcmo2dGJrUjVlc0JOSU4wLzlISkw0MzNF?= =?utf-8?B?Q3kyZy9STnRodUpteFRLREhmU3Y1N3NhcEorc3FrTEJ3RzdIbW9GY2hBeUJq?= =?utf-8?B?cFY5QmdnRituVUhiVVN2TkFOV1hPcTdkSTRRU3lsbWlGR2Q0Sm1XOFFYSjJC?= =?utf-8?B?N0djSG5LUS9Kam1ONVN0cFpNWlRkVFdMU1BWRmxpRkRuUDRyRHhIK1lJcTNa?= =?utf-8?B?RG1ZUy9xdWZRQTZuSlBEOTQraDdmL2xtdjFwVU5lSURFZ3RGazFHSGdWWnQv?= =?utf-8?B?amd3cFV5Nk1lME9GRmZhWnFNT2E4SWdWMWdFMFJOdDVBa1pUOCtSTzhGdG5L?= =?utf-8?B?VUJ5RmRNWUdiRERxc2dsdDgrVXB5cERUYXp2Zi9Sby9iUjhVYVp1L2poRnBz?= =?utf-8?B?UENVMzF5L0wzMW1JN25jQzlheVBiN1hZYThUVmZ6ZFBoTm5NVXYzK0FLZEJZ?= =?utf-8?B?VDV0SW81K0RQbVRycGk5bFFSMHB3Yk5XVEI2aGlCMmJrWFFBWmlQSjFtTWp2?= =?utf-8?B?MXpBVlVHK09hZGJiV3o0d0Y0ek1vZjlnZEhFTW5FY1lOWHRxNHpoeUZCZkJP?= =?utf-8?B?c041NWI5OEttc2t0bEhJa1lFZ0t2VGgwcFR0d1VTY3BBanc2NkFkWGkzTjMw?= =?utf-8?B?RURMZ3M4U0RXTnNqblhLaWF2czFsSnozTlFmWktDNmhwcTBQSllHVmZ0b0dk?= =?utf-8?B?aHpSUTY2VHE4U1FNOWdnay9JOVAxV1ZBQ3lKMWJDS1RScXlTa0s3SGFpSDEr?= =?utf-8?B?TTV5RnFjTnpFYUtscmF2Sm5wc3A1aWZSYVVQN0IxKzc2QmNncXM3OGJreXRi?= =?utf-8?B?bE1NdWswOFc2b0hSMVltL3MyKys2N0xvOVloZ2NWR1VYTC9Vc3pYa05KbGds?= =?utf-8?B?QnlqeWtiSElqUk9tYTk5dTlWd0c1ZzBKb0tzbEY3TjcyNkJOaE12OXFZZ2Zh?= =?utf-8?B?SldobmVOcHpueWlOWDY1Qy84SEJsdWRuU2xmektwN2d1Zi9SZUFYNzkyd0c5?= =?utf-8?B?SDdZR1owRXppZXpyYzVSWDJVUFVDQVRod1M5VE5vRmVmWXhwR3IzQmpybmp2?= =?utf-8?B?MnNMTnNOTkRGQlhRY0NZUFdjc1dxK2NPcGlaTnhBZmRSbk1jS3YwVlJZY0RE?= =?utf-8?B?NldiVjliSzlVaEVnWGJLR3prdnU3ZzFRcVBESGQzWGhFTWx2ODVRc3Z5bUtu?= =?utf-8?B?Mnk0cFNQdkxPVktlSDkxaGg5VmY4Z25xTDNZR3R2bDhuZXV1ajVXVUNTWWYr?= =?utf-8?B?anZ6VEpGVEFnWnlUUU1jT3hpRnRuK3Rnb1hGUnF4bzl4cCtXU1dUN2dmaWRo?= =?utf-8?B?eEpmRGVXaThqLy8rQ0JQWTRDSUZJSlpxZU1VUGt1NlRxR0dhMUpQZGhwMjhv?= =?utf-8?B?cm5HOTRxRzdiZDZNeStiUEltYlYyZisrSDFhMytFKzNsZVNPRitDRDN3elhK?= =?utf-8?B?bHdhQkJWTXNTUmQ4T3JZYytQVzlUVWZoVVc0UlBUSDUxUFVDVUNuUFdYMlBQ?= =?utf-8?B?bDc3d3QvQkNFUXlBN1U5UTFuTmZaK0QyNnNPb1JjeDIzMWpVR0FxWUQweDlP?= =?utf-8?B?MDBRRjZVc0FBbmtsZTN2VkxKeTNKVnBzOFBuTU1STUlCajhUWW9UZ0xlb3pJ?= =?utf-8?B?YWlVMk16NkZsenFhci9tYlB0NnhCSGQyNXNKQW00dFVtcTRGVXNzS0hUWnRt?= =?utf-8?B?ZEJBbE1jWGwybFY0djVWdWpJQXR3SDZRMmJjRTNsSW5aWUNxNzIrNkg3dUM2?= =?utf-8?B?cFlybEJYVzJsK0VScUhMV1NTZmJiaDE3QUNtVXBDcHFXb3JPdCt5VzBRTm1q?= =?utf-8?B?Q0hHcXdGby9kdE9qKzFiSTljdlIyNXFwR3htNzNHMlVzVFFLZDlBTVVsbnJv?= =?utf-8?B?QXJxRUlZVmx6b1VUa0FoRVF6dnRGZ1lyUDB6TFFsNGtybkdVcmIyZ3lYeEJy?= =?utf-8?B?YlMyN2NtWWlwdTB6V055djdUNlFsQytaQlVSa0gzSzBkMFZZMWZrZHAwOERi?= =?utf-8?B?dllzcks2MmJsYTRqR3l4VVdsZEloREduZ3FhZz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(19092799006)(52116014)(7416014)(376014)(1800799024)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NGpHa1dTdEJTVUU4TGNjQjFHV1VEcHFtdVoxRTFnWS9haVhiYUhOU0VEL2t0?= =?utf-8?B?cjdSOTV2cVlMVUYzaDV4dmxOdUhvY0x0bDREZzEwTEpLL0RBTHc3MnFXdTAx?= =?utf-8?B?RWhPOUdNMElQQjdmSm40TFJwdjZjZC9DY2k0dTNKN2tGR3JhamZKcld0Wk9x?= =?utf-8?B?RTVTUXc2RDJ1aWU5TlFIbUJaT21mZ3MxVmJzbzhndUhOR3gwb2x0bGR1YkxN?= =?utf-8?B?QTFLcStxeEEwRWhMa0liTGM3Mjh6cWtKZllEWGJ1TGVNeWhrcER1WGxPL3Y2?= =?utf-8?B?SVg2NzZ6TFlXS1lBYjdndzNCSU9hWVlEbnc3U2w4THE0RHVjSkgvbmRuREsr?= =?utf-8?B?WE53NTZQN0RWelNDR3AyZ3NIaXNROGZLRitoVmZJcEpnenkyVnZuanhkVkZR?= =?utf-8?B?QjViakVFdjJscHFUWXdZSmFjQmFQUnlqRVBVL1dPd1JNK0tJdlZmNWp2OUtp?= =?utf-8?B?REZuaVNFbTRkNU1ZS2taTHk5T25iaDljT1J5aEdac1NrTkhNWXdUVW9VejlW?= =?utf-8?B?ZEtlbE1vcWhwZXc4SWFCaDl6bmRVSUdtZ3ZneGJOTThjWEoxcDZGbFVGajhl?= =?utf-8?B?b0lKUUk0TXNEdlNZTmlqSDFqM0hXZmh5UDRoQU9sQkw1dW5lN2FxNk9Ga1JE?= =?utf-8?B?Y1I0dnpTSUI1UVlQdjVpZjlpWEYrbCt2bWtTVndkTzBpc0hZNVZQVnNFd2tE?= =?utf-8?B?MGV5RXNtT2M2c3lmMWN6aldWOW5ac1d4LzZLUStycW14cTE0TGNFRGxQWUpH?= =?utf-8?B?Y1FpcUE2L2V2c3l5aW50TThWZEFkS2orcEhxdGZ4ak5PZ24wMnNWUkdJRjRH?= =?utf-8?B?MHdMb2FjdFNvOHlnR3kxbjU5R0huWmpOUXRlSTFEWXdaNWpHWDhxTzVhalEw?= =?utf-8?B?M1REeTEzd0lWRlYraS9kNGtRSVlYbWlkdEUvOVYrZ1B3THpES1cvamxyUEJS?= =?utf-8?B?UlJFcnRJdU8vZElhQ3g5Z3lmbVRLbVFJWFpTT2JrbHJZU21Wc0JmRnUzc1J2?= =?utf-8?B?VHhWNVlUQnE5MjAwYzZWTE9BUUZxUDVlL1NnMUtQS0xZaHNsZ3V0OUlpSmd6?= =?utf-8?B?NFhJTVM5YW5MYXU1T3prTnFrdHFsdnFkdHZtL2tIUllIV2xCQUZJQW83d0Yv?= =?utf-8?B?SVhVdkFiVlhnTTQ0aHlqOUUzUmZvZUxuVWE4TmJuNy9oQVphTFlOY0d3VktE?= =?utf-8?B?bUJDQjJTNldGTDVsenZjV29KMy9QRks5NklVL3lhaE5WUlN2STlEVUhTMHFO?= =?utf-8?B?c3R0WUpLTU9ERDlWUkErVFJPM2VyVFF0T2RnZVE2V1VDaEM5L2p6YVFKdGNB?= =?utf-8?B?cEl4Mnh6dzY5Qk9XY2xLMUtjdTdsdFM3eC9WeWN0SEJUbHVuYnlWaFZ6SHRX?= =?utf-8?B?U2NsMk5TZGNCSSs2UEhvbW13cEFqT1JYZngvcVNtaFdQTitpME5JMTJjQlZr?= =?utf-8?B?OFRxZkZiK2ZmbFlQTnc1d1h3YXVucjRwbTlWd3N0RlR0Y0F5eXRPVHZ5Y0tH?= =?utf-8?B?ZFAyVWlrdTQyNnVEYmxVZlpwR2E2eVl6R1VESDFCdTZZbVExUjArclo1OGRi?= =?utf-8?B?bytSNTVURExTRjJkWktlaUdHaVd5YkozZVFxdzM2TVh6S1NrRkdHL01nVS9q?= =?utf-8?B?aTZzZitqSUR6ZTVQTDl5YjNCVm4wUW55MnBCVm9wU1IvNGltZzVLV0g4UWFU?= =?utf-8?B?YmkrUnF0K3l3SytORXk5Szg1NC9ZeVg2YXA3RzRYUTdFV1dncTVvS01kZ2o3?= =?utf-8?B?Rm45NVJFcGNIbkdwOW9wZk5lYUpsZ1ZuM3V3eENmendYRjZMd0tidjd3U2Qz?= =?utf-8?B?aWhUMjBFSkx2WDBHeDhSYWFYL1liVHF1d2QrbjZsTXZEbjE1alRIMFdOemJP?= =?utf-8?B?SnZKK1k1d3FZNGxMWFF1Mm9vRkc2VkxWaTdnQ1hxSForYUducGhuak5SSDVC?= =?utf-8?B?WUxOdXVzUW1OdENLVDFMajZ0RlpiekV2ZlYwdTFPMHI2TEVId2F5WXFLekFz?= =?utf-8?B?RnJDbFNGajFlMGxCMXBkcmJteGEvM0dkZ1BKbHNSMXVodk4vc1hUeHNnNXRh?= =?utf-8?B?VEhiblAyYU10WlltK21NdUsxOFM0alM3TVdZSERGbUxJV3E1Q0l0dzBiaUhY?= =?utf-8?Q?W/MzDEgsATVj0/AMwlYE0diqU?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 933e23a4-d885-41c3-ff22-08ddfcf8fcb0 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2025 12:34:08.2677 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uJkPQ3EyAtDx3UhWnoruXU/MGUASre1aYJCxQQ/msb9FstBlsVW02JOdKZUgyp26LORpcqhe+sqsdCTyk3EXyA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9646 Replace manual rproc_add() and cleanup logic with devm_rproc_add(), which ties the remoteproc lifecycle to the device's lifecycle. This simplifies error handling and ensures proper cleanup. With no need to invoke rproc_del(), the remove() ops could be removed. No functional changes. Reviewed-by: Frank Li Reviewed-by: Daniel Baluta Signed-off-by: Peng Fan --- drivers/remoteproc/imx_rproc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c index 76feda868cb619b79922bcee4c6fdb3e16fc81e3..68e01b647b66910627fb2256c96= c152f3c22c83b 100644 --- a/drivers/remoteproc/imx_rproc.c +++ b/drivers/remoteproc/imx_rproc.c @@ -1135,7 +1135,7 @@ static int imx_rproc_probe(struct platform_device *pd= ev) return dev_err_probe(dev, ret, "pm_runtime get failed\n"); } =20 - ret =3D rproc_add(rproc); + ret =3D devm_rproc_add(dev, rproc); if (ret) { dev_err(dev, "rproc_add failed\n"); goto err_put_pm; @@ -1161,7 +1161,6 @@ static void imx_rproc_remove(struct platform_device *= pdev) pm_runtime_disable(priv->dev); pm_runtime_put_noidle(priv->dev); } - rproc_del(rproc); } =20 static const struct imx_rproc_plat_ops imx_rproc_ops_arm_smc =3D { --=20 2.37.1