From nobody Wed Oct 1 23:30:11 2025 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4888C18C02E for ; Thu, 25 Sep 2025 18:10:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758823844; cv=none; b=ccxx+HpiQGpBp1XMqWyJrS34QDxeigrtEoTSEylSsG1hz9gG6INIDXxhbMkd/ThNFOc8Foft76RkALn0QJPfWtJoXuxVsCeD/J0vwZprp4D4DbAU3LU4tZvwaxZJiK0BYPbE8+y3T5VH8ZPi4wC39PSDm0trFp8JHuTr7nzA/hs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758823844; c=relaxed/simple; bh=3u2Z1Pc8D3oNqINJbtnWAt49YQPsAhRBwY5G2ZGbttA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=KTcXT7/7A6LqigGhnOOLS0baIw9COqNu3ouSMLLISKGWgoT1LEgvxnZFdAjHxgG1ibBaAgmfD2RCe1nmJRjnXbRKDOzUhokyXUzkUWNg9uU/k6XHZ8egdh3bBM5rlxLDa/TlTN7LLU+9yDw0z0XWQmaxgRRwzLsobDOkYo7dZOE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZwbB+lDF; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZwbB+lDF" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-3305c08d9f6so986017a91.1 for ; Thu, 25 Sep 2025 11:10:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758823842; x=1759428642; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=3D+6J5+0iW5mAwUnARNGWccQaDqo6C5S8jNBMNLkLcM=; b=ZwbB+lDF0wj/an2rJyB4tNAywaRK3XJNM7TRYKfG/Ax8nPmCrG732RO0tL00Rqkegt SRz15X3Q3vvwJpADywwwymU/WayUZM+b8QncXCHeix3Uc/ZiGThiCkW8UDLxP2CSsvcU DG8y6lnI2Z9OApBeILVhjfmM41/e2/RVEHoS05ALMbjRv5JfeaExNOxiYFLfq9Y7np8R M5dAihIEb8SEwhj1cVpjOZT59B5Q2WQZzAgwA7t1EofYP7fs+k6uaJRTztjSgOq0fMhY odK57gHPlt5qUhmbOnmQUFJNGRysrOEd1X6Qy5fq4HgWcGp4hw5mvLoEZBp8XX6QZOHF 5qag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758823842; x=1759428642; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3D+6J5+0iW5mAwUnARNGWccQaDqo6C5S8jNBMNLkLcM=; b=B0YgOT0x7gYxZBi103KC+WRPItmHRfeHO8vayZYsCGHCzsiD2xWSpKEtNnZM1KORld 8mQVwSnduduhkoosRV9sxUIKMYUmTAULwVBtVoUdhIqAyhmL3XNCMVPHDt1qA1ab2WN2 tLVlTFz7uuom0C7JtjfK3fKL/9m9v7QhuSt1rLR2X5Mt4JmoevGqWDLRmbKx7E4yDKDc kkPIIZBDBwUJVEU7CNWY2Rzcf4n6adF8fIfbQwc8y3Dhjjnn/AGpX76Yz9Ygz1UejOQ4 Kr6lWZ9MwzK16VNQV20E+QCRM7BnAiVWaeIvLdgUHyLOdcqjTR3RBotAho+apcWYmSko fExA== X-Forwarded-Encrypted: i=1; AJvYcCWQRv89yLtiDnnjIKczgChffjrxdgGgBoYQz9R//6OhsZGA1D5kzGem5LDzrhm1heUG4CwdiXiKPe3Aeiw=@vger.kernel.org X-Gm-Message-State: AOJu0YwnmeE419t1Ay8i6xUaICi5Qy+bLLJ89CgsFdowlmGI7MGmdpun yQNxTl6p7oVvBdGzBz4rgyUrbYGtMdYAMV+wQebefWdN6Kco2pocC9vc X-Gm-Gg: ASbGnctyIXNt/bTur/SNdqwrNuhbuLsiSFsuALUnzhJBAyfierFefXVU2+Etw3i6DIb 4zPtcttNld5bTy9glcItlSFX2gpXXifuS1kV95ZgRZUwsI94a9fM1VoPRPNyAv+tTBCR+7pMJkV 8/rYfCrw0NBfX+QXy7Mo7PTFXrBwVRSQF2KRs8zgZDY9ylsh5W0B9ZgacD9vBjA4CJ8JUq97a0s hqPMSMoOL4UCENWB2lOveIa1RsJvWppM8sdG0e5ot/+fsRNcIx1rBaa0xzah6AUeWZq4/h5yWLi 4f+Tvm3+bmHsDnal/HlDqF0IL5aIi5phadX9l36SRhmSaGdgHTb6q5FuPaM0uaGrEm9ebQ9WoC+ beNHMDYZeQa6/jtF/dkh7pqCq9R54n020hWnaL5R3O6accv2aFDeAuiiTqg== X-Google-Smtp-Source: AGHT+IEvI/Zn0/bwZ03S8X+dYp1EKKmZPn61r8TgfpwHOcE6n4vYwztpEi25wZ270KfumXzxyfsgsQ== X-Received: by 2002:a17:90b:3d0b:b0:32e:dcc6:cd3f with SMTP id 98e67ed59e1d1-33456f55426mr4017199a91.14.1758823842519; Thu, 25 Sep 2025 11:10:42 -0700 (PDT) Received: from nikhil-s-Swift-SFG14-73.. ([101.0.63.224]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3347254dd4fsm3059574a91.12.2025.09.25.11.10.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Sep 2025 11:10:41 -0700 (PDT) From: Nikhil S To: mchehab@kernel.org Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Nikhil S Subject: [PATCH v2] media: dvbringbuffer : fix space issues Date: Thu, 25 Sep 2025 23:40:27 +0530 Message-ID: <20250925181032.7862-1-nikhilsunilkumar@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix the space issues detected by the checkpatch tool Changes in v2: - Split multiple assignments into separate lines Signed-off-by: Nikhil S --- drivers/media/dvb-core/dvb_ringbuffer.c | 34 +++++++++++++++---------- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/drivers/media/dvb-core/dvb_ringbuffer.c b/drivers/media/dvb-co= re/dvb_ringbuffer.c index 7d4558de8..99c2d700c 100644 --- a/drivers/media/dvb-core/dvb_ringbuffer.c +++ b/drivers/media/dvb-core/dvb_ringbuffer.c @@ -37,10 +37,11 @@ =20 void dvb_ringbuffer_init(struct dvb_ringbuffer *rbuf, void *data, size_t l= en) { - rbuf->pread=3Drbuf->pwrite=3D0; - rbuf->data=3Ddata; - rbuf->size=3Dlen; - rbuf->error=3D0; + rbuf->pread =3D 0; + rbuf->pwrite =3D 0; + rbuf->data =3D data; + rbuf->size =3D len; + rbuf->error =3D 0; =20 init_waitqueue_head(&rbuf->queue); =20 @@ -235,7 +236,7 @@ ssize_t dvb_ringbuffer_write_user(struct dvb_ringbuffer= *rbuf, return len; } =20 -ssize_t dvb_ringbuffer_pkt_write(struct dvb_ringbuffer *rbuf, u8* buf, siz= e_t len) +ssize_t dvb_ringbuffer_pkt_write(struct dvb_ringbuffer *rbuf, u8 *buf, siz= e_t len) { int status; ssize_t oldpwrite =3D rbuf->pwrite; @@ -245,7 +246,8 @@ ssize_t dvb_ringbuffer_pkt_write(struct dvb_ringbuffer = *rbuf, u8* buf, size_t le DVB_RINGBUFFER_WRITE_BYTE(rbuf, PKT_READY); status =3D dvb_ringbuffer_write(rbuf, buf, len); =20 - if (status < 0) rbuf->pwrite =3D oldpwrite; + if (status < 0) + rbuf->pwrite =3D oldpwrite; return status; } =20 @@ -258,8 +260,10 @@ ssize_t dvb_ringbuffer_pkt_read_user(struct dvb_ringbu= ffer *rbuf, size_t idx, =20 pktlen =3D rbuf->data[idx] << 8; pktlen |=3D rbuf->data[(idx + 1) % rbuf->size]; - if (offset > pktlen) return -EINVAL; - if ((offset + len) > pktlen) len =3D pktlen - offset; + if (offset > pktlen) + return -EINVAL; + if ((offset + len) > pktlen) + len =3D pktlen - offset; =20 idx =3D (idx + DVB_RINGBUFFER_PKTHDRSIZE + offset) % rbuf->size; todo =3D len; @@ -278,7 +282,7 @@ ssize_t dvb_ringbuffer_pkt_read_user(struct dvb_ringbuf= fer *rbuf, size_t idx, } =20 ssize_t dvb_ringbuffer_pkt_read(struct dvb_ringbuffer *rbuf, size_t idx, - int offset, u8* buf, size_t len) + int offset, u8 *buf, size_t len) { size_t todo; size_t split; @@ -286,8 +290,10 @@ ssize_t dvb_ringbuffer_pkt_read(struct dvb_ringbuffer = *rbuf, size_t idx, =20 pktlen =3D rbuf->data[idx] << 8; pktlen |=3D rbuf->data[(idx + 1) % rbuf->size]; - if (offset > pktlen) return -EINVAL; - if ((offset + len) > pktlen) len =3D pktlen - offset; + if (offset > pktlen) + return -EINVAL; + if ((offset + len) > pktlen) + len =3D pktlen - offset; =20 idx =3D (idx + DVB_RINGBUFFER_PKTHDRSIZE + offset) % rbuf->size; todo =3D len; @@ -309,7 +315,7 @@ void dvb_ringbuffer_pkt_dispose(struct dvb_ringbuffer *= rbuf, size_t idx) rbuf->data[(idx + 2) % rbuf->size] =3D PKT_DISPOSED; =20 // clean up disposed packets - while(dvb_ringbuffer_avail(rbuf) > DVB_RINGBUFFER_PKTHDRSIZE) { + while (dvb_ringbuffer_avail(rbuf) > DVB_RINGBUFFER_PKTHDRSIZE) { if (DVB_RINGBUFFER_PEEK(rbuf, 2) =3D=3D PKT_DISPOSED) { pktlen =3D DVB_RINGBUFFER_PEEK(rbuf, 0) << 8; pktlen |=3D DVB_RINGBUFFER_PEEK(rbuf, 1); @@ -321,7 +327,7 @@ void dvb_ringbuffer_pkt_dispose(struct dvb_ringbuffer *= rbuf, size_t idx) } } =20 -ssize_t dvb_ringbuffer_pkt_next(struct dvb_ringbuffer *rbuf, size_t idx, s= ize_t* pktlen) +ssize_t dvb_ringbuffer_pkt_next(struct dvb_ringbuffer *rbuf, size_t idx, s= ize_t *pktlen) { int consumed; int curpktlen; @@ -339,7 +345,7 @@ ssize_t dvb_ringbuffer_pkt_next(struct dvb_ringbuffer *= rbuf, size_t idx, size_t* if (consumed < 0) consumed +=3D rbuf->size; =20 - while((dvb_ringbuffer_avail(rbuf) - consumed) > DVB_RINGBUFFER_PKTHDRSIZE= ) { + while ((dvb_ringbuffer_avail(rbuf) - consumed) > DVB_RINGBUFFER_PKTHDRSIZ= E) { =20 curpktlen =3D rbuf->data[idx] << 8; curpktlen |=3D rbuf->data[(idx + 1) % rbuf->size]; --=20 2.43.0