From nobody Thu Oct 2 02:13:27 2025 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52BE6306D26 for ; Thu, 25 Sep 2025 15:17:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758813453; cv=none; b=q+iEfa4k4iIiG7rJdaGwUCIHaQARWhywDr3ZDuxbT76uN9UjLNQ1Lo+sPlbqACpWk8kFjjjW9Ml+ukDHu9yIc4SsFc5HTuSGTIoGCPkG+aMMHJ7zloXBkUXqWjbktmWqNxqIcnMo/felBad6jdlx4+p0ZhfAWQJ4LGTQwskWdFE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758813453; c=relaxed/simple; bh=PeHm1wrR0AAPSTDMxiNgwUZQ4BKQBSCJMUznSgFPtDg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KuBzZJqlAhrdRtS40NrjFmxU/wuz0zUNhht4j8Fajr0gBnF1sCU82rG5Vh7FHAyGMSRO0VIGQ1ssZK8kkVGbOoq4K83qjV4GBhYPkUL1RkWP9f8Zlye58aA++JgOqJ3iM5VteqQKjntISJHXzeq8IqNUIZKnr2PgA/5splsG+B0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AuCwawbh; arc=none smtp.client-ip=209.85.167.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AuCwawbh" Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-578ecc56235so1057262e87.0 for ; Thu, 25 Sep 2025 08:17:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758813449; x=1759418249; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GxcQ3SZL/bX2w7ws13Plp9aplxV6uyygzePW373+H0o=; b=AuCwawbhRtZV71jWeHmlH94Gb8pbThQbmDXt4vUEfYGY7WrPvgEGuE170iOp6USlo5 zzQMn/hylFJmv9fOOK4X2FHpNYRSrabIVT77WalF0vlEW0qlcoEZAoqGozYiOSEi/E2z YcHuIkPOcLBwptpYl5dZXAg+hUsZOwxXsaM+sLV07NbPDHDWBSLP2JX+zBFM3E5ZtPZ7 vw1REY7l355u9ASKYx4lom8N5uyvfG3LajqTI00RXIf1cDsNKry3g40SXreXMDnZFrsE lusRhQmT0wv7FrA9vr6JfbmDAEBpTnKRGEA1suqdzLaa9wjSMwa+IFcnYsmNM3SwvGSQ nZ1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758813449; x=1759418249; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GxcQ3SZL/bX2w7ws13Plp9aplxV6uyygzePW373+H0o=; b=Z97rS2ROocBHn2iGHdRnJvn7Svk250jVPGwxEGtZmuQrLEkc2askFbRPLmCYo3H+fg 8spqh0LVhzQnjkodD/onFwTF9FIJj976wtCvfi0a4pdRkhS6zviSIYtl8vN08G/LfCXu gLBjgFkxCLVsxsrZHBkz46Ptu9WwqYBroyICWm4BEu5qHCeBenf4ZgtxQbAxC9enQIfO B3Ep1v6BGrvtGmtbIUezcWDBBjZnLPtXcZMyUEfBpkOSJQta76AUkFinWF4tFZI5ZH62 Od+RkD1Ku9dZXh6S70Zp9HzIfqwy7oYbC2YpMiNJtn+JO2G8/NBrqL0OweGGwRYhxCtL Fq8A== X-Forwarded-Encrypted: i=1; AJvYcCXUS1jlF3O2gbH4thhlFEr92f8a4nTZ0qVGXtWXiZU8ScRNC/7dYMUu4+J1Pn5FisFhN9ce40dpgYY3pYs=@vger.kernel.org X-Gm-Message-State: AOJu0YzdS8FE8s4O+RMl1fbhZs+v3ozkxTMBQadz6qAMlPiQEr5DeOrs m+VVc5qSzs+Nkx8C7TcjZiNLCkwVSgRyz+GrXkAj9oJz416lmowCCmxC X-Gm-Gg: ASbGncsGO73yUzlVFy0tHQclEGG/2staOaHBIBcZguZcsbbEc2wY+FmkIkV9aWVu4Cd +7TV41r1hdu9jWA6Vw2lqpP/19bBo6n9fxgY7GMZW4Y8sjMKkUpd9mQsP8L4KnQUJd3sazMZYu5 Nkws/i+3eRJyMu8TtSt8oE6dhjlCfVQKg14jAXwmwR63Ht2Mg203eL2hrQe+6H8u6TlwuPLYouI CeTvRxYjKWG08DpNOFNUsLzhf2NUDelLeGNSXt7QhvUMjeJSbeVe5zlrvr6NNP4uH4xUVoRVDBT RW3OsQQ4V9D08JwGCUZFYiM2T0VHTssEN0Z24egRfWJzZlt7Mu797PXyYYJISdEk3iij0+pM+vx krLV3IU3/pu/pHA== X-Google-Smtp-Source: AGHT+IEpmsCgXoe+pHNnDNycPilUYF9YFAYkKb7YBcFS/w6Rr+i+BRLl5E2waSe2wlPmiZ/s/OW9iQ== X-Received: by 2002:a05:6512:2213:b0:57e:ad46:b0a0 with SMTP id 2adb3069b0e04-582d092f19amr1131015e87.6.1758813449054; Thu, 25 Sep 2025 08:17:29 -0700 (PDT) Received: from xeon.. ([188.163.112.70]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-58313430496sm870084e87.27.2025.09.25.08.17.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Sep 2025 08:17:28 -0700 (PDT) From: Svyatoslav Ryhel To: David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Prashant Gaikwad , Michael Turquette , Stephen Boyd , Mikko Perttunen , Linus Walleij , Mauro Carvalho Chehab , Greg Kroah-Hartman , Svyatoslav Ryhel , =?UTF-8?q?Jonas=20Schw=C3=B6bel?= , Dmitry Osipenko , Charan Pedumuru , Diogo Ivo , Aaron Kling , Arnd Bergmann Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-staging@lists.linux.dev Subject: [PATCH v3 10/22] staging: media: tegra-video: vi: improve logic of source requesting Date: Thu, 25 Sep 2025 18:16:36 +0300 Message-ID: <20250925151648.79510-11-clamor95@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250925151648.79510-1-clamor95@gmail.com> References: <20250925151648.79510-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" By default tegra_channel_get_remote_csi_subdev returns next device in pipe assuming it is CSI but in case of Tegra20 and Tegra30 it can also be VIP or even HOST. Define tegra_channel_get_remote_csi_subdev within CSI and add check if returned device is actually CSI by comparing subdevice operations. Previous tegra_channel_get_remote_csi_subdev definition in VI rename to tegra_channel_get_remote_bridge_subdev and use it only in VI driver since core VI driver does not care about source and does not call any specific functions. Signed-off-by: Svyatoslav Ryhel --- drivers/staging/media/tegra-video/csi.c | 16 ++++++++++++++++ drivers/staging/media/tegra-video/vi.c | 14 +++++++------- 2 files changed, 23 insertions(+), 7 deletions(-) diff --git a/drivers/staging/media/tegra-video/csi.c b/drivers/staging/medi= a/tegra-video/csi.c index 9e3bd6109781..ef5f054b6d49 100644 --- a/drivers/staging/media/tegra-video/csi.c +++ b/drivers/staging/media/tegra-video/csi.c @@ -445,6 +445,22 @@ static const struct v4l2_subdev_ops tegra_csi_ops =3D { .pad =3D &tegra_csi_pad_ops, }; =20 +struct v4l2_subdev *tegra_channel_get_remote_csi_subdev(struct tegra_vi_ch= annel *chan) +{ + struct media_pad *pad; + struct v4l2_subdev *subdev; + + pad =3D media_pad_remote_pad_first(&chan->pad); + if (!pad) + return NULL; + + subdev =3D media_entity_to_v4l2_subdev(pad->entity); + if (!subdev) + return NULL; + + return subdev->ops =3D=3D &tegra_csi_ops ? subdev : NULL; +} + static int tegra_csi_channel_alloc(struct tegra_csi *csi, struct device_node *node, unsigned int port_num, unsigned int lanes, diff --git a/drivers/staging/media/tegra-video/vi.c b/drivers/staging/media= /tegra-video/vi.c index 90473729b546..04b538e8b514 100644 --- a/drivers/staging/media/tegra-video/vi.c +++ b/drivers/staging/media/tegra-video/vi.c @@ -160,8 +160,8 @@ static void tegra_channel_buffer_queue(struct vb2_buffe= r *vb) wake_up_interruptible(&chan->start_wait); } =20 -struct v4l2_subdev * -tegra_channel_get_remote_csi_subdev(struct tegra_vi_channel *chan) +static struct v4l2_subdev * +tegra_channel_get_remote_bridge_subdev(struct tegra_vi_channel *chan) { struct media_pad *pad; =20 @@ -182,7 +182,7 @@ tegra_channel_get_remote_source_subdev(struct tegra_vi_= channel *chan) struct v4l2_subdev *subdev; struct media_entity *entity; =20 - subdev =3D tegra_channel_get_remote_csi_subdev(chan); + subdev =3D tegra_channel_get_remote_bridge_subdev(chan); if (!subdev) return NULL; =20 @@ -204,7 +204,7 @@ static int tegra_channel_enable_stream(struct tegra_vi_= channel *chan) struct v4l2_subdev *subdev; int ret; =20 - subdev =3D tegra_channel_get_remote_csi_subdev(chan); + subdev =3D tegra_channel_get_remote_bridge_subdev(chan); ret =3D v4l2_subdev_call(subdev, video, s_stream, true); if (ret < 0 && ret !=3D -ENOIOCTLCMD) return ret; @@ -217,7 +217,7 @@ static int tegra_channel_disable_stream(struct tegra_vi= _channel *chan) struct v4l2_subdev *subdev; int ret; =20 - subdev =3D tegra_channel_get_remote_csi_subdev(chan); + subdev =3D tegra_channel_get_remote_bridge_subdev(chan); ret =3D v4l2_subdev_call(subdev, video, s_stream, false); if (ret < 0 && ret !=3D -ENOIOCTLCMD) return ret; @@ -1630,11 +1630,11 @@ static int tegra_vi_graph_notify_complete(struct v4= l2_async_notifier *notifier) goto unregister_video; } =20 - subdev =3D tegra_channel_get_remote_csi_subdev(chan); + subdev =3D tegra_channel_get_remote_bridge_subdev(chan); if (!subdev) { ret =3D -ENODEV; dev_err(vi->dev, - "failed to get remote csi subdev: %d\n", ret); + "failed to get remote bridge subdev: %d\n", ret); goto unregister_video; } =20 --=20 2.48.1