From nobody Thu Oct 2 00:46:14 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 204FF2ECD36; Thu, 25 Sep 2025 15:02:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758812577; cv=none; b=SMeWqMPYE1gUoKCdyKfRU2TJHJDpa1O7eEgCfVV/ZnkjTliB6drCpOFDSyADp94AgBbGS5yrphUNXrC1A0xzcCNgpsVzA/3D6XzkmS5qk7VKHSzZiGRzU99l4OXm9MMYSOL2WFbz1aDleQm2VByj5cn3JLXCYHq/R5+rLjU1c6w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758812577; c=relaxed/simple; bh=f96Akqi91wDUkb2jbBfRZORuWKfC1sS/5pzaMZxecxw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=XDPh6nyP5dEfjhk20m5JmDZyEGyjxJYuc+p27WKDH4kWK1fMEXvZ+kFgV2FoWE6J28TE1jJ5uGQOQwzxyZI5xrrn+nuXDjLlxhyNP1EZRB3qI2LddLkjMxa46CFelWKoOksVFX3KXMYOLJ3Mya2mk31oJQum3csM3hbnWrZTyMo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jAEhzFjJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jAEhzFjJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7FDC9C113D0; Thu, 25 Sep 2025 15:02:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1758812576; bh=f96Akqi91wDUkb2jbBfRZORuWKfC1sS/5pzaMZxecxw=; h=From:To:Cc:Subject:Date:From; b=jAEhzFjJoMqIFHLF21veHHWE4VMd7nyVqJdDMQd47s/NYfV0joRS2ifMuhCYSkypn RI6HgN9oxFjGSH+8AE92X4m9fTCzcUOd1UOFE0fw1Fbr7T+EYJU1y6rAhilPPpBsw7 PS+fsNsT6gp3q9hIIpLx4YBm23Qq8TRF68rOcmaQEkDcrGnpnauN6vDLJRrc+X9SDq 0K2Ed5ivzZ9bTn5+HhqnGRFVJdkMfMxwgRnZIaLHQmeW14YAsK4j4Ea6fFi8Ov3y8i ds78tncbbnJxGVEhkDXzLM+RA3Hw10ofrRG6kINqebrR3hEJAjhIx8t8SNPhNt/wGd I81y/5hmv4uAA== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1v1nUf-000000006Lc-0Tb4; Thu, 25 Sep 2025 17:02:49 +0200 From: Johan Hovold To: Lee Jones Cc: linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH] mfd: altera-sysmgr: fix device leak on sysmgr regmap lookup Date: Thu, 25 Sep 2025 17:02:19 +0200 Message-ID: <20250925150219.24361-1-johan@kernel.org> X-Mailer: git-send-email 2.49.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sure to drop the reference taken to the sysmgr platform device when retrieving its driver data. Note that holding a reference to a device does not prevent its driver data from going away. Fixes: f36e789a1f8d ("mfd: altera-sysmgr: Add SOCFPGA System Manager") Cc: stable@vger.kernel.org # 5.2 Signed-off-by: Johan Hovold --- drivers/mfd/altera-sysmgr.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mfd/altera-sysmgr.c b/drivers/mfd/altera-sysmgr.c index fb5f988e61f3..90c6902d537d 100644 --- a/drivers/mfd/altera-sysmgr.c +++ b/drivers/mfd/altera-sysmgr.c @@ -117,6 +117,8 @@ struct regmap *altr_sysmgr_regmap_lookup_by_phandle(str= uct device_node *np, =20 sysmgr =3D dev_get_drvdata(dev); =20 + put_device(dev); + return sysmgr->regmap; } EXPORT_SYMBOL_GPL(altr_sysmgr_regmap_lookup_by_phandle); --=20 2.49.1