From nobody Thu Oct 2 00:46:10 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52B9C1DE4EF; Thu, 25 Sep 2025 15:01:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758812496; cv=none; b=kuaEyM4ItGjHB8Wj5n2yBPYjOpH34NBApWKxXAwvPMDhukDrz3RJz6bw2KYKVrSQ0VVwD4kVhxoy3kGYzs74r3j8iwuottmYZd8VEesix/3PEVciY7WR9RuDlSewOttl5o73b94/13qUWB2pO49SLIAPx4fcRXCPbYH9+9IFE9M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758812496; c=relaxed/simple; bh=HBMKAro78ZNFv7LCJEgpDLhewdaAREFXTDxX6fc0Jhs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=iIr0yjD3wLTnoM8kbRKCTNMLzgmJWdth9EbOVm9MYA9UvSaMrTWxTQPRfNcUcmHZE3j67EIWcqXJ8rPoMGmjdkrYnXhyGAKGKLSdkVP7Ufqbz3dFmImSu1UXif4j3NJ9NZ6mPAISYpfLRZvkUlkvgQZb52hoJNITZm1SqdQHl9Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=p9eZagnl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="p9eZagnl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF5E9C4CEF0; Thu, 25 Sep 2025 15:01:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1758812495; bh=HBMKAro78ZNFv7LCJEgpDLhewdaAREFXTDxX6fc0Jhs=; h=From:To:Cc:Subject:Date:From; b=p9eZagnlb2exRZ2TXxx1d+IN8AQ9UQQV0/BCt/ggJaBfaroEU1/1ZuvHZMSg4eaYd LKlBmZuLlu2Ws+UmQFmxbPZNzbtMpQ3URJtJBSo58Ofi3m222QQvISk10f+w4UAi7N foNhjRRTZRgEoorRWw29WG85c2bumHhhQ2J9QBG1SPceJ74C4fXTNCw1VmuvDXTBp8 X/n1mmnYRLUw43do55pprykU9rV7Ll+3aC+SjuN5XslGg7r+fyJ4+KOTkpx6OtGeXW UwbpISMl1uHvTSHDNn4TPw2SXNOAO/MLiOeQbW943gdtqCqss+JCAoYVCWbBNXObEN dPBrwS2W8c74A== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1v1nTM-000000006Jh-3Oke; Thu, 25 Sep 2025 17:01:28 +0200 From: Johan Hovold To: Russell King , Thierry Reding , Jonathan Hunter Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH] amba: tegra-ahb: fix device leak on smmu enable Date: Thu, 25 Sep 2025 17:00:07 +0200 Message-ID: <20250925150007.24173-1-johan@kernel.org> X-Mailer: git-send-email 2.49.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sure to drop the reference taken to the ahb platform device when looking up its driver data while enabling the smmu. Note that holding a reference to a device does not prevent its driver data from going away. Fixes: 89c788bab1f0 ("ARM: tegra: Add SMMU enabler in AHB") Cc: stable@vger.kernel.org # 3.5 Signed-off-by: Johan Hovold --- drivers/amba/tegra-ahb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/amba/tegra-ahb.c b/drivers/amba/tegra-ahb.c index c0e8b765522d..f23c3ed01810 100644 --- a/drivers/amba/tegra-ahb.c +++ b/drivers/amba/tegra-ahb.c @@ -144,6 +144,7 @@ int tegra_ahb_enable_smmu(struct device_node *dn) if (!dev) return -EPROBE_DEFER; ahb =3D dev_get_drvdata(dev); + put_device(dev); val =3D gizmo_readl(ahb, AHB_ARBITRATION_XBAR_CTRL); val |=3D AHB_ARBITRATION_XBAR_CTRL_SMMU_INIT_DONE; gizmo_writel(ahb, val, AHB_ARBITRATION_XBAR_CTRL); --=20 2.49.1