From nobody Thu Oct 2 02:04:52 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8761D2FFFBC; Thu, 25 Sep 2025 12:29:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758803350; cv=none; b=YH/BPUMTXZyAxjxwt28jMKB/+bke/jIPKV2YxRSMNgfF3oi8zCoGYsOjKEq2eQLHSCg9IugeyyogRTINZRyu5JoT3IjRIfgRa2ylkncKwQ0e4a9cVJBLp6XUEUHv8rUr79SJnqdCSNPnkssaYpbR5dTg4WE/WDN0UuFJRIPhCLA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758803350; c=relaxed/simple; bh=I2uuCriRflVqgvU8CtAnGXErcoFYIBf/4993czMBu4A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iEmrsrVpnX+Wj64GHZy0RV84hIypKFUfgpD2Fd4KIphF4v8r5nGFKdy0Kt5MVHRpiY0jeAF4RtWgKJSTg0g4DQYSfoMx+PzelcEmL0WCv5wgJFB8U2puqTtzE3fsi5xI3q7lNl+uiE/k3OZR6sTl6IqSqegtl8vJMUS2DfWJYVc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=csWs0Buy; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="csWs0Buy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 40F81C19423; Thu, 25 Sep 2025 12:29:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1758803350; bh=I2uuCriRflVqgvU8CtAnGXErcoFYIBf/4993czMBu4A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=csWs0BuyxNNhkbWIrSqp2//obeC2K8qMFRJN2Lw/QXKsl5DEF0ueDq3Xv1BfpR/GV hIv36MU7b9j+Cv7FnEQQZ7Jf4GmUqy2Jxamw0lE5OGpaFpfwlZAGFTG25ekancdaqo DyhjkZ/IGuEg+yoWj4kbfYsebADvpROuCFZxYwfZkmkldioLQIToGtEOqo1uAq7+h1 I7b1o4JnQGKARIpxaUZKIwAbgLtum1e2PBMZXdy5wGKvH/HKsSBClWjVbkV4JsyJ4b gjs+Ix34C0eYkJozzyZbK0lxV01xZHpWU6+YTw5trmxEbgzaIa0IcZD8QJAOZwCjIm NzYlZ8xut3viw== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1v1l5q-000000002rb-2a5G; Thu, 25 Sep 2025 14:29:02 +0200 From: Johan Hovold To: Joerg Roedel , Will Deacon Cc: Robin Murphy , Sven Peter , Janne Grunau , Rob Clark , Marek Szyprowski , Yong Wu , Matthias Brugger , AngeloGioacchino Del Regno , Chen-Yu Tsai , Thierry Reding , Krishna Reddy , iommu@lists.linux.dev, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH 05/14] iommu/mediatek: fix device leak on of_xlate() Date: Thu, 25 Sep 2025 14:27:47 +0200 Message-ID: <20250925122756.10910-6-johan@kernel.org> X-Mailer: git-send-email 2.49.1 In-Reply-To: <20250925122756.10910-1-johan@kernel.org> References: <20250925122756.10910-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sure to drop the reference taken to the iommu platform device when looking up its driver data during of_xlate(). Fixes: 0df4fabe208d ("iommu/mediatek: Add mt8173 IOMMU driver") Cc: stable@vger.kernel.org # 4.6 Cc: Yong Wu Signed-off-by: Johan Hovold --- drivers/iommu/mtk_iommu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c index 0e0285348d2b..8d8e85186188 100644 --- a/drivers/iommu/mtk_iommu.c +++ b/drivers/iommu/mtk_iommu.c @@ -974,6 +974,8 @@ static int mtk_iommu_of_xlate(struct device *dev, return -EINVAL; =20 dev_iommu_priv_set(dev, platform_get_drvdata(m4updev)); + + put_device(&m4updev->dev); } =20 return iommu_fwspec_add_ids(dev, args->args, 1); --=20 2.49.1