From nobody Thu Oct 2 02:04:52 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67DBD304BB5; Thu, 25 Sep 2025 12:29:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758803351; cv=none; b=iBxpE6dwlvylBcfr7kI+JlpLbjnCh/bv1FvevX08IvPoo1EsKar5dAaIi4ia1mfgsNL9U5MXZvErcdGfxTe2f6pLCqiWfRKcMjODm8M4yboj7hw8olRN3LAtYJJpjumJPmivEojaskjVsR1N8KU9KDQ1RIaazbA7ooVA/EfV4S8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758803351; c=relaxed/simple; bh=L5PM1JGtNBoMwBhCEkKEi183OrEgxCfculTTkWkh4Wo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tSfIfvmxDYIXvTn0hw/ShX5g2xpbZ2QxvSwt/t1GvRBAqREd6UcNKlsVVItLDQoGAiopA7nhOUHAhdkguu9oiKeFAYkG2YcT84XSRC7F+89+7vA1UMcTDQL8BbHMJ/thJdD7nW5K1RCFz5x0VLCveoaqhMJTtijYGDGEiDTQYGE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mtZZu4nz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mtZZu4nz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 07077C116D0; Thu, 25 Sep 2025 12:29:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1758803351; bh=L5PM1JGtNBoMwBhCEkKEi183OrEgxCfculTTkWkh4Wo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mtZZu4nzTmBz+00n+ie+LSNro7doTRLyp0zDgEUZlyv5VQO2l+MLGOPOMSmt9gB8q VjZ7M9lN2VtCJdpGzDNchHvP7VijCXVu+Yf8QZUZvdmnsdpMmj7SYpG0uU1lh6QxVG lkWAj2x/nnVg5yrTIMc39ppu+exzgL8ORruOIT2Q0CLVt7JuJtymPRcnr1eUDv17pg RjaVqN0d/yQppUNd2fNNcyqe9Zsb8TT4P/eMBUNxf69nRWH19mSR8bw/mbhJNtffl3 SzlJ5mBT53PdA6gjI90snc1VwEaFlEmt6hwqNw/PvUaI0uC2/3XbzSGHdim2pmqgFt Jez/9qb1Hkltg== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1v1l5r-000000002s4-1r7Y; Thu, 25 Sep 2025 14:29:03 +0200 From: Johan Hovold To: Joerg Roedel , Will Deacon Cc: Robin Murphy , Sven Peter , Janne Grunau , Rob Clark , Marek Szyprowski , Yong Wu , Matthias Brugger , AngeloGioacchino Del Regno , Chen-Yu Tsai , Thierry Reding , Krishna Reddy , iommu@lists.linux.dev, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org, Thierry Reding Subject: [PATCH 14/14] iommu/tegra: fix device leak on probe_device() Date: Thu, 25 Sep 2025 14:27:56 +0200 Message-ID: <20250925122756.10910-15-johan@kernel.org> X-Mailer: git-send-email 2.49.1 In-Reply-To: <20250925122756.10910-1-johan@kernel.org> References: <20250925122756.10910-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sure to drop the reference taken to the iommu platform device when looking up its driver data during probe_device(). Fixes: 891846516317 ("memory: Add NVIDIA Tegra memory controller support") Cc: stable@vger.kernel.org # 3.19 Cc: Thierry Reding Signed-off-by: Johan Hovold --- drivers/iommu/tegra-smmu.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c index 36cdd5fbab07..f6f26a072820 100644 --- a/drivers/iommu/tegra-smmu.c +++ b/drivers/iommu/tegra-smmu.c @@ -830,10 +830,9 @@ static struct tegra_smmu *tegra_smmu_find(struct devic= e_node *np) return NULL; =20 mc =3D platform_get_drvdata(pdev); - if (!mc) { - put_device(&pdev->dev); + put_device(&pdev->dev); + if (!mc) return NULL; - } =20 return mc->smmu; } --=20 2.49.1