From nobody Thu Oct 2 02:16:52 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22CD43009DC for ; Thu, 25 Sep 2025 12:01:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758801671; cv=none; b=Hhhuuofb3Mqr5MdHEkSbB0pEznN7p86FEPFqhu0R6nj/oD5d0p6SQkpdsolf/0tNu+CEjMDvyBZaHAhTAhFqpsKVFvWoier1+q6sfAoErCG9CgskxPBT+X7ixrA7laVWNsSLj6hiDgkV8w3sIfduGcXUKsvjtNShYVxVgEQiX6o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758801671; c=relaxed/simple; bh=kC/yVveCilSBPp6hlDQx2LgjfgqnNgwryalEGynvTXw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=kB3yBwOo1IfWG5YAe2CcNMbNV4B0GvwLFxe/qzUrtOorkFjiq5gy/YPXI2x8oXhsMad84Hzp/C4UK6Tcwv0ZwuCirkdJ6wNJkQmtPq12MHJPni3iurSFQhUqVHZDS2bcGTbB737WQBgt+nso/RN+OHyxJpjZBDydrJeaFkgHRpw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KQd5RTU0; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KQd5RTU0" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58P9VAAc023770 for ; Thu, 25 Sep 2025 12:01:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=V5Y/1hDv/kk whStoArQzbwxZMpsCaPsP3PcuweIKGKM=; b=KQd5RTU0OCqSYbA43dZVLV3JTs4 jPaYCGg+CdtSPzBqIUsysFroSkKtfrv4OQIcUYd9dy4eoLMVeGqkzOdjd7jb5Wan /dQ3lsiu1T3Tqm0eIuVf1iKQCGphZ0qVgVNvO6SOkWV5JC2f4dQkqOwumUJbNeii aK52A+q297HKtLA6xY8pAI/R3i2T4n0JCxMmwEFTg6eaRa1dZkIOa5tXll/ZTbCL 0eegsQ6es0OVUQC6kuaynoKwg+4KNyMxNHcfv9ugIdiYcdYTL4VX6jS1YQ7ryHxV VYkmsUEUhw+2Yorkej22OcJQ7upJkJIDtoeseTvZc9Z7ZIp3LCbMhmrTc9Q== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49bwp0f0r9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 25 Sep 2025 12:01:07 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-244570600a1so11355995ad.1 for ; Thu, 25 Sep 2025 05:01:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758801666; x=1759406466; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V5Y/1hDv/kkwhStoArQzbwxZMpsCaPsP3PcuweIKGKM=; b=QC5vswL3u7cav7IX6e/9HtXQc+9WmQwagyIYxbcionm4X4vXsNi7/DbJGx5T/QWFgD wGGoBD8Z2ma+nEtMS1UfE4D4rLdgil0WYO3JFnhRUmVzNYphw84agS7BKphDglaqdl2/ oQjZnMN8hQsUnnlZzPNIBvccvgGTvgtQDVlQ0p3mf0P3sCR9GivsV3YOrilfm9uRdArr xz/Lb6EaWcrb3aY4RzACgixk6s3aLXhNt1dXjVfsUrbYJNFK4JFMiabg1rruwkf4LUF3 J0TI2dMWqF8q3nYCJvSO3++ZvlPK69WNIOPgvCGjMXjs9AvTmiLTZel+0QCQ4Ca7pnZ5 Bpvg== X-Forwarded-Encrypted: i=1; AJvYcCVql6lX9M2duM7elr3mELp6ihKnGEzdDkBpXSE+RvjbzeCaxbkhS+xhctPxqsGqZTjCRWMjp6QBLuE8X+k=@vger.kernel.org X-Gm-Message-State: AOJu0YwLUAH/qQYUlk0W+J3V55QPCorAeAK99TlcbqcnjmovZwdpzWJS PSrBO5l4u+wiKeYZVXMH6wsO760J3+Q8BrmrzuS2mVwMnsGlITHO5flxPW8rsBtba/Wr0c/5aaf gWPedVmtBdEHf26Bm7y58uLWvsgyfrJWSHrvmI4JoIm0SgN17fs9p1DxgzanWTbAU9Yo= X-Gm-Gg: ASbGncuNvukfWPuuFbgmPyYF/PGDCCUbROcCWpx54SMzsmit4wkktxY4k5BRe9EKcgP v8jKtHfXYsvAhvzElDek1E2r4EQsJ5cdS1MAVJAN/yOAnnSTUwEbwXeDWE/ZOdx2lLlBFAjRL7F e9FCJN07sklziSHwWhtUES7DLgVzgJptTLPTPtjV6tF17Yj/dLrtNs6R3eXQVdIwtq0UV2KV+Mw 24+W4yeOmuLkG6xWQJdY5pHYvVgUuAiZx8etrwPbOAmE83H8qBtmlDVa0O0ppkTcKZfNdmmSukx GHdR09w24PiVeHa0mpZJTKOZgaQ2whwlVNHmpImtN8+E2V6HdQ+XNvv7OxzmutvDoEWC0qkNRUM = X-Received: by 2002:a17:903:41ca:b0:265:e815:fcdf with SMTP id d9443c01a7336-27ed722bb4amr25789025ad.17.1758801663759; Thu, 25 Sep 2025 05:01:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFEJvZUQFeB94qKQ4oxw3IjetCCgf2TPwA7CQNnsNMgmh4dfmt6RK+z1AGXQJSv6/UtlX0GfA== X-Received: by 2002:a17:903:41ca:b0:265:e815:fcdf with SMTP id d9443c01a7336-27ed722bb4amr25787385ad.17.1758801661502; Thu, 25 Sep 2025 05:01:01 -0700 (PDT) Received: from hu-jseerapu-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-27ed69a9668sm22266585ad.112.2025.09.25.05.00.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Sep 2025 05:01:01 -0700 (PDT) From: Jyothi Kumar Seerapu To: Vinod Koul , Mukesh Kumar Savaliya , Viken Dadhaniya , Andi Shyti , Sumit Semwal , =?UTF-8?q?Christian=20K=C3=B6nig?= Cc: linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, quic_vtanuku@quicinc.com Subject: [PATCH v8 2/2] i2c: i2c-qcom-geni: Add Block event interrupt support Date: Thu, 25 Sep 2025 17:30:35 +0530 Message-Id: <20250925120035.2844283-3-jyothi.seerapu@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250925120035.2844283-1-jyothi.seerapu@oss.qualcomm.com> References: <20250925120035.2844283-1-jyothi.seerapu@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=KNxaDEFo c=1 sm=1 tr=0 ts=68d52f03 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=yJojWOMRYYMA:10 a=COk6AnOGAAAA:8 a=B7k2eyGBTX8o-6-HIN8A:9 a=324X-CrmTo6CU4MGRt3R:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: quLKxsPZCmelcp_6aWN_fzBeyVs6LHW0 X-Proofpoint-ORIG-GUID: quLKxsPZCmelcp_6aWN_fzBeyVs6LHW0 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTIzMDEzOCBTYWx0ZWRfX3A5MNpDQm2ZH Bq6VcLQ/M+x8ITp+wiNnAMzP71CJWR7+TntWEzO/BBLEcbBToZH27ULWI2V9AkTLWA3EBESrd65 iXWsLcER3GSI8jKyMGzR6nS98vGeHFS46OZ0Kgs5o/BWMtJk4Vg/52emU63o9bBW/ChRNqeFiVu GcQYRLq/0YdDTTpWpSkFfMluTIodZnhrh4xlvk1tm2n6WfoFEf2RKP2LHqU/rEbjIUfJb8cHdeE mc8atrlt/bOyWPWzqY2tz7U1rfAZx1lpdUbU19BrOjb3qcWZO1pmjFFc95rE0Zvuqd/OOIOwDvl cm7v8Skqqs+4M2J1QSjamRwLfDl95tYaVYaB903J8QVR7PxOi5FSTBEGi2I21F5KB+NNaY0/34J 6m+sO5Fs X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-25_01,2025-09-24_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 clxscore=1015 phishscore=0 suspectscore=0 adultscore=0 bulkscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2509230138 Content-Type: text/plain; charset="utf-8" From: Jyothi Kumar Seerapu The I2C driver gets an interrupt upon transfer completion. When handling multiple messages in a single transfer, this results in N interrupts for N messages, leading to significant software interrupt latency. To mitigate this latency, utilize Block Event Interrupt (BEI) mechanism. Enabling BEI instructs the hardware to prevent interrupt generation and BEI is disabled when an interrupt is necessary. Large I2C transfer can be divided into chunks of messages internally. Interrupts are not expected for the messages for which BEI bit set, only the last message triggers an interrupt, indicating the completion of N messages. This BEI mechanism enhances overall transfer efficiency. BEI optimizations are currently implemented for I2C write transfers only, as there is no use case for multiple I2C read messages in a single transfer at this time. Signed-off-by: Jyothi Kumar Seerapu Acked-by: Mukesh Savaliya Reviewed-by: Dmitry Baryshkov Reviewed-by: Mukesh Savaliya --- v7 -> v8: - Updated with proper types when calling geni_i2c_gpi_unmap() inside geni_i2c_gpi_multi_desc_unmap(). v6 -> v7: - The design has been modified to configure BEI for interrupt generation either: After the last I2C message, if sufficient TREs are available, or After a specific I2C message, when no further TREs are available. - dma_buf and dma_addr for multi descriptor support is changed from static allocation to dynmic allocation. - In i2c_gpi_cb_result function, for multi descriptor case, instead of i= nvoking complete for everry 8 messages completions, changed the logic to Invok= e 'complete' for every I2C callback (for submitted I2C messages). - For I2C multi descriptor case, updated 'gi2c_gpi_xfer->dma_buf' and 'gi2c_gpi_xfer->dma_addr' for unmappping in geni_i2c_gpi_multi_desc_un= map. - Updated documentation removed for "struct geni_i2c_dev" as per the rev= iew comments. v5 -> v6: - Instead of using bei_flag, moved the logic to use with DMA supported flags like DMA_PREP_INTERRUPT. - Additional parameter comments removed from geni_i2c_gpi_multi_desc_unmap function documentation. v4 -> v5: - Block event interrupt flag naming changed from flags to bei_flag. - Documentation added for "struct geni_i2c_dev". v3 -> v4: - API's added for Block event interrupt with multi descriptor support for I2C is moved from qcom-gpi-dma.h file to I2C geni qcom driver file. - gpi_multi_xfer_timeout_handler function is moved from GPI driver to I2C driver. - geni_i2c_gpi_multi_desc_xfer structure is added as a member of struct geni_i2c_dev. v2 -> v3: - In i2c_gpi_cb_result function, moved the logic of "!is_tx_multi_xfer" to else. - MIN_NUM_OF_MSGS_MULTI_DESC changed from 4 to 2 - Updated commit description v1 -> v2: - Moved gi2c_gpi_xfer->msg_idx_cnt to separate local variable. - Updated goto labels for error scenarios in geni_i2c_gpi function - memset tx_multi_xfer to 0. - Removed passing current msg index to geni_i2c_gpi - Fixed kernel test robot reported compilation issues. drivers/i2c/busses/i2c-qcom-geni.c | 248 ++++++++++++++++++++++++++--- 1 file changed, 224 insertions(+), 24 deletions(-) diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qc= om-geni.c index ff2289b52c84..ddddf9530ace 100644 --- a/drivers/i2c/busses/i2c-qcom-geni.c +++ b/drivers/i2c/busses/i2c-qcom-geni.c @@ -77,6 +77,25 @@ enum geni_i2c_err_code { #define XFER_TIMEOUT HZ #define RST_TIMEOUT HZ =20 +#define QCOM_I2C_MIN_NUM_OF_MSGS_MULTI_DESC 2 + +/** + * struct geni_i2c_gpi_multi_desc_xfer - Structure for multi transfer supp= ort + * + * @msg_idx_cnt: Current message index being processed in the transfer + * @unmap_msg_cnt: Number of messages that have been unmapped + * @irq_cnt: Number of transfer completion interrupts received + * @dma_buf: Array of virtual addresses for DMA-safe buffers + * @dma_addr: Array of DMA addresses corresponding to the buffers + */ +struct geni_i2c_gpi_multi_desc_xfer { + u32 msg_idx_cnt; + u32 unmap_msg_cnt; + u32 irq_cnt; + void **dma_buf; + dma_addr_t *dma_addr; +}; + struct geni_i2c_dev { struct geni_se se; u32 tx_wm; @@ -99,6 +118,9 @@ struct geni_i2c_dev { struct dma_chan *rx_c; bool gpi_mode; bool abort_done; + bool is_tx_multi_desc_xfer; + u32 num_msgs; + struct geni_i2c_gpi_multi_desc_xfer i2c_multi_desc_config; }; =20 struct geni_i2c_desc { @@ -499,6 +521,7 @@ static int geni_i2c_tx_one_msg(struct geni_i2c_dev *gi2= c, struct i2c_msg *msg, static void i2c_gpi_cb_result(void *cb, const struct dmaengine_result *res= ult) { struct geni_i2c_dev *gi2c =3D cb; + struct geni_i2c_gpi_multi_desc_xfer *tx_multi_xfer; =20 if (result->result !=3D DMA_TRANS_NOERROR) { dev_err(gi2c->se.dev, "DMA txn failed:%d\n", result->result); @@ -507,6 +530,11 @@ static void i2c_gpi_cb_result(void *cb, const struct d= maengine_result *result) dev_dbg(gi2c->se.dev, "DMA xfer has pending: %d\n", result->residue); } =20 + if (gi2c->is_tx_multi_desc_xfer) { + tx_multi_xfer =3D &gi2c->i2c_multi_desc_config; + tx_multi_xfer->irq_cnt++; + } + complete(&gi2c->done); } =20 @@ -525,7 +553,72 @@ static void geni_i2c_gpi_unmap(struct geni_i2c_dev *gi= 2c, struct i2c_msg *msg, } } =20 -static int geni_i2c_gpi(struct geni_i2c_dev *gi2c, struct i2c_msg *msg, +/** + * geni_i2c_gpi_multi_desc_unmap() - Unmaps DMA buffers post multi message= TX transfers + * @gi2c: I2C dev handle + * @msgs: Array of I2C messages + * @peripheral: Pointer to gpi_i2c_config + */ +static void geni_i2c_gpi_multi_desc_unmap(struct geni_i2c_dev *gi2c, struc= t i2c_msg msgs[], + struct gpi_i2c_config *peripheral) +{ + u32 msg_xfer_cnt, wr_idx =3D 0; + struct geni_i2c_gpi_multi_desc_xfer *tx_multi_xfer =3D &gi2c->i2c_multi_d= esc_config; + + msg_xfer_cnt =3D gi2c->err ? tx_multi_xfer->msg_idx_cnt : tx_multi_xfer->= irq_cnt; + + /* Unmap the processed DMA buffers based on the received interrupt count = */ + for (; tx_multi_xfer->unmap_msg_cnt < msg_xfer_cnt; tx_multi_xfer->unmap_= msg_cnt++) { + wr_idx =3D tx_multi_xfer->unmap_msg_cnt; + geni_i2c_gpi_unmap(gi2c, &msgs[wr_idx], + tx_multi_xfer->dma_buf[wr_idx], + tx_multi_xfer->dma_addr[wr_idx], + NULL, 0); + + if (tx_multi_xfer->unmap_msg_cnt =3D=3D gi2c->num_msgs - 1) { + kfree(tx_multi_xfer->dma_buf); + kfree(tx_multi_xfer->dma_addr); + break; + } + } +} + +/** + * geni_i2c_gpi_multi_xfer_timeout_handler() - Handles multi message trans= fer timeout + * @dev: Pointer to the corresponding dev node + * @multi_xfer: Pointer to the geni_i2c_gpi_multi_desc_xfer + * @transfer_timeout_msecs: Timeout value in milliseconds + * @transfer_comp: Completion object of the transfer + * + * This function waits for the completion of each processed transfer messa= ges + * based on the interrupts generated upon transfer completion. + * + * Return: On success returns 0, -ETIMEDOUT on timeout. + */ +static int geni_i2c_gpi_multi_xfer_timeout_handler(struct device *dev, + struct geni_i2c_gpi_multi_desc_xfer *multi_xfer, + u32 transfer_timeout_msecs, + struct completion *transfer_comp) +{ + int i; + u32 time_left; + + for (i =3D 0; i < multi_xfer->msg_idx_cnt - 1; i++) { + reinit_completion(transfer_comp); + + if (multi_xfer->msg_idx_cnt !=3D multi_xfer->irq_cnt) { + time_left =3D wait_for_completion_timeout(transfer_comp, + transfer_timeout_msecs); + if (!time_left) { + dev_err(dev, "%s: Transfer timeout\n", __func__); + return -ETIMEDOUT; + } + } + } + return 0; +} + +static int geni_i2c_gpi(struct geni_i2c_dev *gi2c, struct i2c_msg msgs[], struct dma_slave_config *config, dma_addr_t *dma_addr_p, void **buf, unsigned int op, struct dma_chan *dma_chan) { @@ -537,26 +630,45 @@ static int geni_i2c_gpi(struct geni_i2c_dev *gi2c, st= ruct i2c_msg *msg, enum dma_transfer_direction dma_dirn; struct dma_async_tx_descriptor *desc; int ret; + struct geni_i2c_gpi_multi_desc_xfer *gi2c_gpi_xfer; + dma_cookie_t cookie; + u32 msg_idx; =20 peripheral =3D config->peripheral_config; + gi2c_gpi_xfer =3D &gi2c->i2c_multi_desc_config; + msg_idx =3D gi2c_gpi_xfer->msg_idx_cnt; =20 - dma_buf =3D i2c_get_dma_safe_msg_buf(msg, 1); - if (!dma_buf) - return -ENOMEM; + dma_buf =3D i2c_get_dma_safe_msg_buf(&msgs[msg_idx], 1); + if (!dma_buf) { + ret =3D -ENOMEM; + goto out; + } =20 if (op =3D=3D I2C_WRITE) map_dirn =3D DMA_TO_DEVICE; else map_dirn =3D DMA_FROM_DEVICE; =20 - addr =3D dma_map_single(gi2c->se.dev->parent, dma_buf, msg->len, map_dirn= ); + addr =3D dma_map_single(gi2c->se.dev->parent, dma_buf, + msgs[msg_idx].len, map_dirn); if (dma_mapping_error(gi2c->se.dev->parent, addr)) { - i2c_put_dma_safe_msg_buf(dma_buf, msg, false); - return -ENOMEM; + i2c_put_dma_safe_msg_buf(dma_buf, &msgs[msg_idx], false); + ret =3D -ENOMEM; + goto out; + } + + if (gi2c->is_tx_multi_desc_xfer) { + flags =3D DMA_CTRL_ACK; + + /* BEI bit to be cleared for last TRE */ + if (msg_idx =3D=3D gi2c->num_msgs - 1) + flags |=3D DMA_PREP_INTERRUPT; + } else { + flags =3D DMA_PREP_INTERRUPT | DMA_CTRL_ACK; } =20 /* set the length as message for rx txn */ - peripheral->rx_len =3D msg->len; + peripheral->rx_len =3D msgs[msg_idx].len; peripheral->op =3D op; =20 ret =3D dmaengine_slave_config(dma_chan, config); @@ -567,14 +679,21 @@ static int geni_i2c_gpi(struct geni_i2c_dev *gi2c, st= ruct i2c_msg *msg, =20 peripheral->set_config =3D 0; peripheral->multi_msg =3D true; - flags =3D DMA_PREP_INTERRUPT | DMA_CTRL_ACK; =20 if (op =3D=3D I2C_WRITE) dma_dirn =3D DMA_MEM_TO_DEV; else dma_dirn =3D DMA_DEV_TO_MEM; =20 - desc =3D dmaengine_prep_slave_single(dma_chan, addr, msg->len, dma_dirn, = flags); + desc =3D dmaengine_prep_slave_single(dma_chan, addr, msgs[msg_idx].len, + dma_dirn, flags); + if (!desc && !(flags & DMA_PREP_INTERRUPT)) { + /* Retry with interrupt if not enough TREs */ + flags |=3D DMA_PREP_INTERRUPT; + desc =3D dmaengine_prep_slave_single(dma_chan, addr, msgs[msg_idx].len, + dma_dirn, flags); + } + if (!desc) { dev_err(gi2c->se.dev, "prep_slave_sg failed\n"); ret =3D -EIO; @@ -584,15 +703,48 @@ static int geni_i2c_gpi(struct geni_i2c_dev *gi2c, st= ruct i2c_msg *msg, desc->callback_result =3D i2c_gpi_cb_result; desc->callback_param =3D gi2c; =20 - dmaengine_submit(desc); - *buf =3D dma_buf; - *dma_addr_p =3D addr; + if (!((msgs[msg_idx].flags & I2C_M_RD) && op =3D=3D I2C_WRITE)) + gi2c_gpi_xfer->msg_idx_cnt++; =20 + cookie =3D dmaengine_submit(desc); + if (dma_submit_error(cookie)) { + dev_err(gi2c->se.dev, + "%s: dmaengine_submit failed (%d)\n", __func__, cookie); + ret =3D -EINVAL; + goto err_config; + } + + if (gi2c->is_tx_multi_desc_xfer) { + gi2c_gpi_xfer->dma_buf[msg_idx] =3D dma_buf; + gi2c_gpi_xfer->dma_addr[msg_idx] =3D addr; + + dma_async_issue_pending(gi2c->tx_c); + + if ((msg_idx =3D=3D (gi2c->num_msgs - 1)) || flags & DMA_PREP_INTERRUPT)= { + ret =3D geni_i2c_gpi_multi_xfer_timeout_handler(gi2c->se.dev, gi2c_gpi_= xfer, + XFER_TIMEOUT, &gi2c->done); + if (ret) { + dev_err(gi2c->se.dev, + "I2C multi write msg transfer timeout: %d\n", + ret); + gi2c->err =3D ret; + return ret; + } + } + } else { + /* Non multi descriptor message transfer */ + *buf =3D dma_buf; + *dma_addr_p =3D addr; + } return 0; =20 err_config: - dma_unmap_single(gi2c->se.dev->parent, addr, msg->len, map_dirn); - i2c_put_dma_safe_msg_buf(dma_buf, msg, false); + dma_unmap_single(gi2c->se.dev->parent, addr, + msgs[msg_idx].len, map_dirn); + i2c_put_dma_safe_msg_buf(dma_buf, &msgs[msg_idx], false); + +out: + gi2c->err =3D ret; return ret; } =20 @@ -604,6 +756,7 @@ static int geni_i2c_gpi_xfer(struct geni_i2c_dev *gi2c,= struct i2c_msg msgs[], i unsigned long time_left; dma_addr_t tx_addr, rx_addr; void *tx_buf =3D NULL, *rx_buf =3D NULL; + struct geni_i2c_gpi_multi_desc_xfer *tx_multi_xfer; const struct geni_i2c_clk_fld *itr =3D gi2c->clk_fld; =20 config.peripheral_config =3D &peripheral; @@ -617,6 +770,41 @@ static int geni_i2c_gpi_xfer(struct geni_i2c_dev *gi2c= , struct i2c_msg msgs[], i peripheral.set_config =3D 1; peripheral.multi_msg =3D false; =20 + gi2c->num_msgs =3D num; + gi2c->is_tx_multi_desc_xfer =3D false; + + tx_multi_xfer =3D &gi2c->i2c_multi_desc_config; + memset(tx_multi_xfer, 0, sizeof(struct geni_i2c_gpi_multi_desc_xfer)); + + /* + * If number of write messages are two and higher then + * configure hardware for multi descriptor transfers with BEI. + */ + if (num >=3D QCOM_I2C_MIN_NUM_OF_MSGS_MULTI_DESC) { + gi2c->is_tx_multi_desc_xfer =3D true; + for (i =3D 0; i < num; i++) { + if (msgs[i].flags & I2C_M_RD) { + /* + * Multi descriptor transfer with BEI + * support is enabled for write transfers. + * TODO: Add BEI optimization support for + * read transfers later. + */ + gi2c->is_tx_multi_desc_xfer =3D false; + break; + } + } + } + + if (gi2c->is_tx_multi_desc_xfer) { + tx_multi_xfer->dma_buf =3D kcalloc(num, sizeof(void *), GFP_KERNEL); + tx_multi_xfer->dma_addr =3D kcalloc(num, sizeof(dma_addr_t), GFP_KERNEL); + if (!tx_multi_xfer->dma_buf || !tx_multi_xfer->dma_addr) { + ret =3D -ENOMEM; + goto err; + } + } + for (i =3D 0; i < num; i++) { gi2c->cur =3D &msgs[i]; gi2c->err =3D 0; @@ -627,14 +815,16 @@ static int geni_i2c_gpi_xfer(struct geni_i2c_dev *gi2= c, struct i2c_msg msgs[], i peripheral.stretch =3D 1; =20 peripheral.addr =3D msgs[i].addr; + if (i > 0 && (!(msgs[i].flags & I2C_M_RD))) + peripheral.multi_msg =3D false; =20 - ret =3D geni_i2c_gpi(gi2c, &msgs[i], &config, + ret =3D geni_i2c_gpi(gi2c, msgs, &config, &tx_addr, &tx_buf, I2C_WRITE, gi2c->tx_c); if (ret) goto err; =20 if (msgs[i].flags & I2C_M_RD) { - ret =3D geni_i2c_gpi(gi2c, &msgs[i], &config, + ret =3D geni_i2c_gpi(gi2c, msgs, &config, &rx_addr, &rx_buf, I2C_READ, gi2c->rx_c); if (ret) goto err; @@ -642,18 +832,24 @@ static int geni_i2c_gpi_xfer(struct geni_i2c_dev *gi2= c, struct i2c_msg msgs[], i dma_async_issue_pending(gi2c->rx_c); } =20 - dma_async_issue_pending(gi2c->tx_c); - - time_left =3D wait_for_completion_timeout(&gi2c->done, XFER_TIMEOUT); - if (!time_left) - gi2c->err =3D -ETIMEDOUT; + if (!gi2c->is_tx_multi_desc_xfer) { + dma_async_issue_pending(gi2c->tx_c); + time_left =3D wait_for_completion_timeout(&gi2c->done, XFER_TIMEOUT); + if (!time_left) { + dev_err(gi2c->se.dev, "%s:I2C timeout\n", __func__); + gi2c->err =3D -ETIMEDOUT; + } + } =20 if (gi2c->err) { ret =3D gi2c->err; goto err; } =20 - geni_i2c_gpi_unmap(gi2c, &msgs[i], tx_buf, tx_addr, rx_buf, rx_addr); + if (!gi2c->is_tx_multi_desc_xfer) + geni_i2c_gpi_unmap(gi2c, &msgs[i], tx_buf, tx_addr, rx_buf, rx_addr); + else if (tx_multi_xfer->unmap_msg_cnt !=3D tx_multi_xfer->irq_cnt) + geni_i2c_gpi_multi_desc_unmap(gi2c, msgs, &peripheral); } =20 return num; @@ -662,7 +858,11 @@ static int geni_i2c_gpi_xfer(struct geni_i2c_dev *gi2c= , struct i2c_msg msgs[], i dev_err(gi2c->se.dev, "GPI transfer failed: %d\n", ret); dmaengine_terminate_sync(gi2c->rx_c); dmaengine_terminate_sync(gi2c->tx_c); - geni_i2c_gpi_unmap(gi2c, &msgs[i], tx_buf, tx_addr, rx_buf, rx_addr); + if (gi2c->is_tx_multi_desc_xfer) + geni_i2c_gpi_multi_desc_unmap(gi2c, msgs, &peripheral); + else + geni_i2c_gpi_unmap(gi2c, &msgs[i], tx_buf, tx_addr, rx_buf, rx_addr); + return ret; } =20 --=20 2.34.1