From nobody Thu Oct 2 02:12:39 2025 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2D5B311C21 for ; Wed, 24 Sep 2025 15:27:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758727653; cv=none; b=IpiXYQihDcdYRcTBIqcuheWAZm5bCDNSqanapmLkOtO0WhXEH3Gx1a+/gdFpKohhorx4f+1/vfT4H6EiSHKrTrf9dBCzJXHWhB596ErDZzITUPKp+UG0SeYiM4Xffv4C5QomilFC4iE7YE/8E/7UVeTIz/It70BWQInuYrOvIww= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758727653; c=relaxed/simple; bh=syY4SH9VeSO9lmfTJssqeO04+Z2PZYj5pDZKhxS0law=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Xp32Mo8s3EYRC7/jsW4q7eZFOD2tfQhL3iNmI3ibn3ANDtjNUyL6Fnsj2Za6OGIj6nt/ZqNHOjcZWcGP6RWgOburz3VLAsWwB9k0xRoJmh54xYQGBNGyyRZ3KiYiP/MFhGQ5JgOsErQDZDLlVYzxUWf7Mb1s/vKvsbwOl6vDBeM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--ardb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=y6fMygO+; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--ardb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="y6fMygO+" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-45de27bf706so38638555e9.0 for ; Wed, 24 Sep 2025 08:27:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1758727650; x=1759332450; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Ln86/emlRW++8jlfCD8OhBzg2NppL+NIQ42e5m1YOIw=; b=y6fMygO+VDgmmchm8ixtjXtX2FBlqK9fgW8NREVTumcaliwHM8aYU4VkBkoMwGlEh6 5jPjeSFV9ss+nVojUcwjaC1mCzJm8+aRuTaWQhDcvtzl9vDolGgZ4367C/xBAwY0tznQ J3RkB7nQhWfVkgc8wXLwSICnks1UW7ZYaJYjfTdB8XOKFM1IBI6wz1iAgWXbuJw/JAoT b/AA0LLKOHie5rvgUnuWwgW5f1vAXFZQBVqcN9JCxqsfLzzNBq6PByTpXreNChpYEZTE 52/oyEEJ3sc4YgPWaA/fO2zFiRyItjg6oQsYkmhawjOaSocuoKvuHHDHH7b7zqmawpQR z+PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758727650; x=1759332450; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ln86/emlRW++8jlfCD8OhBzg2NppL+NIQ42e5m1YOIw=; b=f19r7b0mUYyAzgrvnSvLd9/DHvpMdqz/siEGonlrxSFAx55fkBCoIyqhHXR5phm/f5 lml952+Kwta7TGZMLGxFp4jaIBwp8AncM9i7RRtH6jbdeXtJiySkp1gk9yeYwbRa4jMZ 3WjPfPgHexMAGk/ODu5x6SXTBwwmVglrToFWL53idMPJnqMMbWzHmMpX3HSQ6dAN7MBo 4WdcKsMsXrcyYoZAbx21FL1ib1gX+yUh3pGoFqvOtw3JoiNeYqteYPO8IMl9L2M0+1He PHpYVavOaeCIp8rUHqdpvu+DyjtA+9vwl3aq5+lB58vqYxIkguhAFYP51HfkMrSBKzN3 zMhw== X-Gm-Message-State: AOJu0YxW5grn7gwVUl03zQTGpPuzX6ygWQeWTWbFIUILb/5qZ9YBF16B 9DSqP75BsQLK8ptkDHknfLy2N/CkCt19JFImMxpSK5cEEcj0GLRq6V6IP7Ki1nBCBuof0w4RTA= = X-Google-Smtp-Source: AGHT+IGr/1cFTXgZdf6e+4nFNkNXF1/DJFBlumid+5SATHB0yGSyBfu3Vnrf7sHmr+Jznes2hE6aM/Tb X-Received: from wmbdp9.prod.google.com ([2002:a05:600c:6489:b0:46c:aed0:23f3]) (user=ardb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:181c:b0:46d:996b:826f with SMTP id 5b1f17b1804b1-46e32a02d46mr1753225e9.25.1758727650446; Wed, 24 Sep 2025 08:27:30 -0700 (PDT) Date: Wed, 24 Sep 2025 17:26:57 +0200 In-Reply-To: <20250924152651.3328941-9-ardb+git@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250924152651.3328941-9-ardb+git@google.com> X-Developer-Key: i=ardb@kernel.org; a=openpgp; fpr=F43D03328115A198C90016883D200E9CA6329909 X-Developer-Signature: v=1; a=openpgp-sha256; l=1252; i=ardb@kernel.org; h=from:subject; bh=7GLyY2hmHXPr1fnp3jZiXNoyuiFGpy/XlEGtkndi7cg=; b=owGbwMvMwCVmkMcZplerG8N4Wi2JIeMK77F5kmrJ6gpp09KjLf7kCq57KHzvnUQ6ly6DaarJ4 dkMqvIdpSwMYlwMsmKKLAKz/77beXqiVK3zLFmYOaxMIEMYuDgFYCJX0xj+cLs+DtS2evBhqtKS ToszsruDvl5fGmZ+fYaHWNzEvrSWK4wMPZHRT7eHcv+1bu1WnOzmLvZxjqFf/JqNdr9/twpE7az nAgA= X-Mailer: git-send-email 2.51.0.534.gc79095c0ca-goog Message-ID: <20250924152651.3328941-14-ardb+git@google.com> Subject: [PATCH v4 5/7] arm64/efi: Drop efi_rt_lock spinlock from EFI arch wrapper From: Ard Biesheuvel To: linux-efi@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ard Biesheuvel , Will Deacon , Mark Rutland , Sebastian Andrzej Siewior , Peter Zijlstra , Catalin Marinas , Mark Brown Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Ard Biesheuvel Since commit 5894cf571e14 ("acpi/prmt: Use EFI runtime sandbox to invoke PRM handlers") all EFI runtime calls on arm64 are routed via the EFI runtime wrappers, which are serialized using the efi_runtime_lock semaphore. This means the efi_rt_lock spinlock in the arm64 arch wrapper code has become redundant, and can be dropped. For robustness, replace it with an assert that the EFI runtime lock is in fact held by 'current'. Signed-off-by: Ard Biesheuvel --- arch/arm64/kernel/efi.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/arch/arm64/kernel/efi.c b/arch/arm64/kernel/efi.c index 6c371b158b99..0094f5938ba6 100644 --- a/arch/arm64/kernel/efi.c +++ b/arch/arm64/kernel/efi.c @@ -165,19 +165,16 @@ asmlinkage efi_status_t efi_handle_corrupted_x18(efi_= status_t s, const char *f) return s; } =20 -static DEFINE_RAW_SPINLOCK(efi_rt_lock); - void arch_efi_call_virt_setup(void) { + efi_runtime_assert_lock_held(); efi_virtmap_load(); - raw_spin_lock(&efi_rt_lock); __efi_fpsimd_begin(); } =20 void arch_efi_call_virt_teardown(void) { __efi_fpsimd_end(); - raw_spin_unlock(&efi_rt_lock); efi_virtmap_unload(); } =20 --=20 2.51.0.534.gc79095c0ca-goog