From nobody Thu Oct 2 02:12:36 2025 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4A67309EEC for ; Wed, 24 Sep 2025 11:52:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758714753; cv=none; b=Xvwrl0d2pER+2DAS1jFU9JkcoJiBUOqGHvX0hhpCzgQaOqcv5gbdhCNdZCIMrPlw1kr7UIgPgLHwygGBi026njU83DTXCnoU6NjaqSQM6MLB+z+4zwZHWsUwQZaMt+2H3faRNeKh+HFyPB1ON04kqDj4simzuqLAFdXHuCKhvts= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758714753; c=relaxed/simple; bh=iAqT9ehP+7na6p9OmCJ4sZ82YPBCnKZ9ZITAqnPBA1U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aIpAwdiF6+jkG4ERIo6YN0xCvz12KYdcOGlrNHgei8i6NIFYWvpLKj6OXnh8q9gTYByFT0xIZtuaDUPqOtt89uEQlJCO72SchuL2YCaAufLvYzteTYNSud+v5eLr9Txcgm6J7Ggub33BSrY14PfalC84h8pTzfzSiH7TgO1hoEk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MHTYa/k+; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MHTYa/k+" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-3306d93e562so6010381a91.1 for ; Wed, 24 Sep 2025 04:52:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758714750; x=1759319550; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CDvSRov2FamkqE0fpRbb1mATCdcadu0+ybcKu6XxB6c=; b=MHTYa/k+6ECs357AhrvtLv3+d+73xCHlewJANdPDeVVBs4baqSQks4VcCRT3od2KlD TGstrAuMWBc3jmmoZFx+oae35ZAvAYvywhAtWk2ZbtXMVzz47auOqwqvix62PsKZ5HDB 36hB/dC9CSViXW+tHKbePe2QIXG4dOi9JiVZHJz9MWiaHSfgRFPGEcCDVSXoiXS71Byt r6tXUrrdi1JcuS+HfNnQjpWww13adXmfdXFef4q0uSE58I3Y/7SFYC6nzS6TZRqHcj3M kN3ZI6v9QgwY2aUnn4LLb4CoIyCcZIaiHzajCEybkKvMhUz+XWRcCQoiYetvmzfu6JcM 4uzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758714750; x=1759319550; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CDvSRov2FamkqE0fpRbb1mATCdcadu0+ybcKu6XxB6c=; b=c/QWq+DmMpXzaV5iJVX0qAohMFmd+VwFuxKhXm+e9pU19jXdpoBXRLNbWrYtd98LwY a1QdtVrlsa3J3oEvQ1ycVrpwBRcmd5YBUDTs0xNtwU51UR8WE7w3RrBYD2c3nXlb6tOB YtBY46om2YSC3vl+NLx6ZK5li+vNvS+QDBQnrS/FbJPwcIe0215DYHIb9XK71m55pot7 UCrk2Dh7llzogsu8vsLWTbYuY6BcZMvt0Yoq2ar4DErvr12rXSYhbxFPjztzj92w1roU HaDl5M6i5EBUv3i8ZB7/Y+VqQ1fMeEQ6we+KpoEq12wMJ96dfc3GdN+STOkZohktuGuR ZkVg== X-Forwarded-Encrypted: i=1; AJvYcCXRcmUuwA/4/EcJncZvk17bY2aMAxjd4LWrwVsu4Zh0yFB1uKMSa83jxBf/4jEfDnFBMviaLA1MvghPb+c=@vger.kernel.org X-Gm-Message-State: AOJu0YwaTbj+RPGtDfhHjMgXhEYH9Fkm5N5mLCaihf4Xqx4pOSHleWDY yFxA7YXimlDsPwCVuGClR8NmJ8IVyzsLK1TV/ejeYA9RlI+J5rz01VVp X-Gm-Gg: ASbGnctRStbKve7CGXT9Oru82y8wl7QHFcj+OnrJKB6e7HC3oPFV/Rjp2mJ4Ehts8aQ 99Odz5ZHviJghf6+R/pYBLW4ySwVZbxf4W3sdAhCknsMhlid+8scS4Los6LUszs74IGNhxLP4d4 nVz4AKHVZn677y+87vT3G+2T2G9rbIfXgXNhJkLKXyNZnq92S6Kp5LpQGzE5osB/+vpFHR5yp3q KFxjk+1iVLyJ4zPOT2h3eCnxCPtKIT8L3Z2kp4Xz/IEir2PS6qq4o97H0uCzUno/abdq1szn81p pCJwwSZ2NUeZSL328eY57nc1TyOLtw8xCncagQv/d7cL+zrDFLrBQXC1GpwE0FH5vShbEfKKZND f6ESdCadB7gdSJB7wUSGhXpT+zg== X-Google-Smtp-Source: AGHT+IF5ZwoBk0ceUXLZjQvXdKYyDk7CfR+Or0oVbNtL2fgYtH3GTtcS1SuTeoBLjpovsRj6PgtdCw== X-Received: by 2002:a17:90b:1844:b0:32e:87fa:d95f with SMTP id 98e67ed59e1d1-332a98f6f1fmr6851528a91.32.1758714749765; Wed, 24 Sep 2025 04:52:29 -0700 (PDT) Received: from localhost ([23.142.224.65]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3341bd90587sm2190418a91.6.2025.09.24.04.52.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Sep 2025 04:52:29 -0700 (PDT) From: Jinchao Wang To: Andrew Morton , Masami Hiramatsu , Peter Zijlstra , Mike Rapoport , Alexander Potapenko , Randy Dunlap , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Kees Cook , Alice Ryhl , Sami Tolvanen , Miguel Ojeda , Masahiro Yamada , Rong Xu , Naveen N Rao , David Kaplan , Andrii Nakryiko , Jinjie Ruan , Nam Cao , workflows@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-mm@kvack.org, llvm@lists.linux.dev, Andrey Ryabinin , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , kasan-dev@googlegroups.com, "David S. Miller" , Mathieu Desnoyers , linux-trace-kernel@vger.kernel.org Cc: Jinchao Wang Subject: [PATCH v5 15/23] mm/ksw: manage probe and HWBP lifecycle via procfs Date: Wed, 24 Sep 2025 19:50:58 +0800 Message-ID: <20250924115124.194940-16-wangjinchao600@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250924115124.194940-1-wangjinchao600@gmail.com> References: <20250924115124.194940-1-wangjinchao600@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Allow dynamic enabling/disabling of KStackWatch through user input of proc. With this patch, the entire system becomes functional. Signed-off-by: Jinchao Wang --- mm/kstackwatch/kernel.c | 55 ++++++++++++++++++++++++++++++++++++++++- 1 file changed, 54 insertions(+), 1 deletion(-) diff --git a/mm/kstackwatch/kernel.c b/mm/kstackwatch/kernel.c index 4a06ddadd9c7..11aa06908ff1 100644 --- a/mm/kstackwatch/kernel.c +++ b/mm/kstackwatch/kernel.c @@ -13,6 +13,43 @@ static struct ksw_config *ksw_config; static atomic_t config_file_busy =3D ATOMIC_INIT(0); =20 +static bool watching_active; + +static int ksw_start_watching(void) +{ + int ret; + + /* + * Watch init will preallocate the HWBP, + * so it must happen before stack init + */ + ret =3D ksw_watch_init(); + if (ret) { + pr_err("ksw_watch_init ret: %d\n", ret); + return ret; + } + + ret =3D ksw_stack_init(); + if (ret) { + pr_err("ksw_stack_init ret: %d\n", ret); + ksw_watch_exit(); + return ret; + } + watching_active =3D true; + + pr_info("start watching: %s\n", ksw_config->user_input); + return 0; +} + +static void ksw_stop_watching(void) +{ + ksw_stack_exit(); + ksw_watch_exit(); + watching_active =3D false; + + pr_info("stop watching: %s\n", ksw_config->user_input); +} + struct param_map { const char *name; /* long name */ const char *short_name; /* short name (2 letters) */ @@ -126,6 +163,9 @@ static ssize_t kstackwatch_proc_write(struct file *file, if (copy_from_user(input, buffer, count)) return -EFAULT; =20 + if (watching_active) + ksw_stop_watching(); + input[count] =3D '\0'; strim(input); =20 @@ -140,12 +180,22 @@ static ssize_t kstackwatch_proc_write(struct file *fi= le, return ret; } =20 + ret =3D ksw_start_watching(); + if (ret) { + pr_err("Failed to start watching with %d\n", ret); + return ret; + } + return count; } =20 static int kstackwatch_proc_show(struct seq_file *m, void *v) { - seq_printf(m, "%s\n", ksw_config->user_input); + if (watching_active) + seq_printf(m, "%s\n", ksw_config->user_input); + else + seq_puts(m, "not watching\n"); + return 0; } =20 @@ -193,6 +243,9 @@ static int __init kstackwatch_init(void) =20 static void __exit kstackwatch_exit(void) { + if (watching_active) + ksw_stop_watching(); + remove_proc_entry("kstackwatch", NULL); kfree(ksw_config->func_name); kfree(ksw_config->user_input); --=20 2.43.0