From nobody Thu Oct 2 02:16:38 2025 Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11013063.outbound.protection.outlook.com [52.101.72.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F6F7275AE6; Wed, 24 Sep 2025 07:23:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.72.63 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758698641; cv=fail; b=Ydx/ciF2EPq+GHi2nucj5koFnguUzZX4tNrSsZnHa5ln0pbhwoF+J7ab0syQu+4H54BGrepcSzbquqwWkk9xnpUv8PCGn1wLv+6bXfTWOrUkiktVTzqnagEU5MrThVmvdhfPxTQW7gpRw0liI5cW3gL1UNbVDfh9URpjwYiEh9A= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758698641; c=relaxed/simple; bh=aTbMZ6BOGwoC23CvOTdbOYg0iQyRiTykvU0YdeYlbnc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=THw4FBWUKPMF+sqmHWlpCYbm7OqKZPNaptRV2TA/guEDdbUpUhorhdQGcT1h/KTm+O1iUnXZVL26QQiPnH+t1Xt6F9/RDkQ6JQUVsjzfuw8R4CIUf6zPdf72T4Tr8SRdXVmeFSvqZnew6WTBA8fXhvFvNwlm7VmBmSiIco7jxyM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=l9ttxSpR; arc=fail smtp.client-ip=52.101.72.63 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="l9ttxSpR" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yI+/LxBs52jjYilFa5XAHfxKXuJwZWeot4yoGJkRNcAP9fFfNJZaLOwa7nIAa+yDKtUKIi2g4XOVxTeJCLRBy1aSuSlYUKWnxil7jritoI9mJXOTzT3KxJlxrYT4AFoqDLaDGFPveRxAszeu8pgEgeVxFku5i1V5RzTh4pssyMDqle1eAEN2G44OpCqtIzNCi2mhzu9nkVUeJ3jiJ6djygtvov19kbM6V4oFxYgXcHI2grfhxe4m/lHtRDwiA7xv0mr2SCFM7ZVPMjlaqYerugjZ6UCCi9b4Y/0puWYRNKf4eEDXWCpk6gTU6IIsUOhsWDNCugJdbgsd8P8R/ac1/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9JtoF6g9Hd9MdQlalTHgjrAKTd14dRApYJm6mbwHmMM=; b=SP4dabrOk0we0+E7yKoK7QnIKdz++6IPvtxeL3j2BEgCumGtzeTi5/T/WjTBM6sUs29/lBim0g215B9nrGTN5X/zg7Q3S2XBkCkfQzD7sUv8J3+/eTXNb5jRczNH6rY/5nc+jR45VOvF1yWrTYvkwO0eq1vWvnrAhPsua6hozikuQJEJDLPkpHxb9BSB4KUX1r54J6YrANwXsJh2n+9iKGEaRWDvCNq4zmHrRQDJje3siDZooULajb1zuZjS5KgtJF9A4S/BBxZx2qwuUtikvCtQ25Zz18teDl4jjq1dn7wvPDxD5mU6hrXvxJkIo1o3Av27LLThQtwU5GHtSkMAEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9JtoF6g9Hd9MdQlalTHgjrAKTd14dRApYJm6mbwHmMM=; b=l9ttxSpRFQsfpVGOe2dokIsyZB4lb662Ywt9dJnX+4mIkWR0fkdg+qQSQp4flZV39bxKCbRcR+04+dTiNLJVU1XaLfTabX857gzp+hTKoyJc2sPF1Willv/9+L4uoffxJsksskrToU0zK+VajybgyTGl3OBt7nrkw6qG+i2WgqcG4s9o+NnD0oO02f+do3B3s/Z1F86j25qosbbYEYgFi+qB+lrhFC+sisAXlQofDG458GUs6KLEH39WyLFHMSpXgXgSkcc9HgAYSY65e2jcDUz1kMvFkYJ5hV11+Ir5ubJBYLpwiZoTWT+oPRqzBKnzTjwmTuGhMuLrWuB2B9jr1w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8833.eurprd04.prod.outlook.com (2603:10a6:20b:42c::19) by PAXPR04MB8271.eurprd04.prod.outlook.com (2603:10a6:102:1ca::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.9; Wed, 24 Sep 2025 07:23:55 +0000 Received: from AS8PR04MB8833.eurprd04.prod.outlook.com ([fe80::209c:44e4:a205:8e86]) by AS8PR04MB8833.eurprd04.prod.outlook.com ([fe80::209c:44e4:a205:8e86%3]) with mapi id 15.20.9160.008; Wed, 24 Sep 2025 07:23:55 +0000 From: Richard Zhu To: frank.li@nxp.com, jingoohan1@gmail.com, l.stach@pengutronix.de, lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org, robh@kernel.org, bhelgaas@google.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, Richard Zhu , stable@vger.kernel.org, Bjorn Helgaas Subject: [PATCH v6 1/4] PCI: dwc: Remove the L1SS check before putting the link into L2 Date: Wed, 24 Sep 2025 15:23:21 +0800 Message-Id: <20250924072324.3046687-2-hongxing.zhu@nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20250924072324.3046687-1-hongxing.zhu@nxp.com> References: <20250924072324.3046687-1-hongxing.zhu@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI2PR01CA0019.apcprd01.prod.exchangelabs.com (2603:1096:4:192::12) To AS8PR04MB8833.eurprd04.prod.outlook.com (2603:10a6:20b:42c::19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8833:EE_|PAXPR04MB8271:EE_ X-MS-Office365-Filtering-Correlation-Id: a8ebb9bf-1faa-4bda-6f74-08ddfb3b51c0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|19092799006|52116014|7416014|376014|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?cvegUCYzrflSSQhkiyBF6UwOqUqbx4FYhmhAUoBCQETazQtK+u7Tu6dfvItk?= =?us-ascii?Q?pcGm14lIB7gJ7110njaSSGP7xoqtOIAr6wPl5c2YwhQJefQGMyaQxCVYuFeX?= =?us-ascii?Q?uZB2U9ngquSKBaNFZPWjHMbwyrZAaVyZacMgZ3EDY+USU7MFSNgVScp2rkNS?= =?us-ascii?Q?qvnqVu1RZ0ga1kIcK3vwVti2H9TZ8AkYOK6edLJxPTRYllOw00YOZ/Eb9nyh?= =?us-ascii?Q?30C7mt1T77AZvTWSnGKMny94tX1XJV5BlNJxtmyArU67Ta37a+ahB1tpKLhA?= =?us-ascii?Q?M2ACHi+ic7mdnYHDbOR2epCLlUYK24o1b5ONGwDtJK77ZWur8UhxEqSicNWG?= =?us-ascii?Q?pAUpwEUGVzcYBfVfdrRBcw+nmLIz3juDsUOpAusafCDmxpiPumdQIAH4Gy7D?= =?us-ascii?Q?IpcjmEdhvtttrTE5ih99tswrOz3dNY6usGYq/m0VDAQq8Ju9wjJ67kDKT3V5?= =?us-ascii?Q?s3gHqUE/s2QelG/rSdHLUR89X/TQxXs6lPJRQXikNKLEw90EanWj6eJEpBge?= =?us-ascii?Q?sYBkVdpifGxWgaIzsQG3YRW89rRzSgj85nWbimLQsJAKm1A/EkVArl/JWPf0?= =?us-ascii?Q?TG2Vqj6klsqEYp5cwfbKJ7ALCmMEeKKe6mdsRwjO49VY3UOO3sMh34d0n7eZ?= =?us-ascii?Q?PZiv9tlRPz89U+dwolAr4SPdoWgGTy3k2lCWZgoi9o+qlWxISkw2Drx+tUXx?= =?us-ascii?Q?ezVAcf/Ds4vNVB9X+2ETFe7WGd6rVGzx9AVVYMZG6fn7dhy2I2f+dMZ1ESfy?= =?us-ascii?Q?NbXtnB/01OFqLi+/vOdpVLAbce1qOyV0WX9VTCW5OcpfsVnHuFOuJcXJNB2k?= =?us-ascii?Q?/dq/tvu/3094OTS9BwNuX17q6fjxAYIpPoyLKQdAjOoSoR0ujJwD09XzeU53?= =?us-ascii?Q?eHhpuR5bYHpEyOBBr6oEmQ+1krkqvJFtN36JA+fOZ3pIQRVdGEoDfzbO+zBe?= =?us-ascii?Q?x+cZTjpjTs6jcjimg+2eUoT9knjZgYDLJUbTlCafnb/QZP6Ik2LgK/o1VTes?= =?us-ascii?Q?L8xcJMbkhzzHi647ga3TgGLXMLx1+Lj9+bdLTyswa+/Ob09hTFxHmkiG1aKi?= =?us-ascii?Q?P1KzfgXIXYnOUI+ijAEW7a56KRMq78jq9q7Q2uD8Yz0gbxFosSob+Q0KpBm8?= =?us-ascii?Q?NEKj3M0j5+hxlGG6oMxeLw8Cay7WFECSuUO9bdjqWzsvaSV3amtPN+nEd2eh?= =?us-ascii?Q?lLXu/4pY79hqQ/BfsxO9KaSGNhwA2Yqv5ZTAh0AeLRxxZvgQ476TXunn0Gx+?= =?us-ascii?Q?zUMGYyHTIZuW/RKseO6VmAfQ5jrVkizvqfp6pGA7x5rZsmsLzwpNrJ0u7zQw?= =?us-ascii?Q?ihIpKmM79+hEmq0l2fmx9c+DQnU3FpsvPlomHVxxDcFn+C5OFK/op6T/gSR6?= =?us-ascii?Q?tn8uuG0iObmFxsdK4bLUkm54yNZcdM8k3dw1crr11n1XDkWA+GDpppVAAHoy?= =?us-ascii?Q?VlUdz2mIoQCC7v2uxaCrin7Q027/HgqQbfey+dtZryQlnO73130/NERr7UCF?= =?us-ascii?Q?A9vTbdqUPNuyX7Q=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8833.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(19092799006)(52116014)(7416014)(376014)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tu+IuKnvX6SZQYwR2tX0proxHkVuguBScL0WE+1cJRcrM6b3CmvfPYPT8l1j?= =?us-ascii?Q?5zM1elAHxycS/hW8lkF52j57eSH5vRQ9hmo4a/zj8uMNK4vajikVXk8o7tgm?= =?us-ascii?Q?v5Cn/SPm91ujvRg56+iDitirGPurP+dCuX8Tcx27P4lnBQeqVUG5gjkOqSLa?= =?us-ascii?Q?YmsQ89bdXmu4V3cP25UDZSPDl0fkFGGLx3ySPoh40GXRmBwdaWOsnMWN/coU?= =?us-ascii?Q?Vc4QPCYGFm7D3xl1k0smTKJCVe4JonqDxv5i9/RsBfBgATnbDAuKk8XClUGq?= =?us-ascii?Q?UKDw+sr+zE4yzBQt+H/7D2SGNcvIx+KNlA+9MK6e2JuKhCCjvrWZ4KberA4V?= =?us-ascii?Q?UzWHGj03n4rKR7BkClUDTzCVsAHsQ5c6YX7NTSzRAiRZF7/VG/cOSLDEws2Y?= =?us-ascii?Q?phHAbt+gsv5MLUFNKUeJy9YHdsahdUGNJ45AjGSOaQyWQpbRou9bJGprh2uW?= =?us-ascii?Q?F2jWBdnjuqqGb7EkU+CprIhlcaY4fibv+QioA0wtcReTLgFujEa2GvdZp8F1?= =?us-ascii?Q?XKlXD8ZqULMJ/tH6xAXlaJiNp37xuKpAhP4EmlcCKKH5IQ1ou7NSlST8krwZ?= =?us-ascii?Q?ru/NJZl0snZugbYb5w4yekEfDDiATa/NShF+IuSUajM0MCk86PpxGBA8/gmX?= =?us-ascii?Q?zaPnRcnwYTwkgat0xNxd4xstGKVOi4TOynyUYggR+A9hIKCpcGT1DFuWhdzm?= =?us-ascii?Q?+R2lWIEy/B59je85GLr0sbXsY+3uLSHdIr33hhd+Fqhm61PcWRlx8HsxEyqJ?= =?us-ascii?Q?dagzRWVcVVYjV+zMd5PSAG5Wnvou42wHfK78dWduXhEwOeFSai7AzhmCCang?= =?us-ascii?Q?M2AG2VvpY0FsU83Cr3lMX3WzAlTkGT/Kz4eRVBhhE21Iebk+txZNkKGu82x8?= =?us-ascii?Q?ewkTSX1bE+kTIpccvSNf18PcI7HwKIm0PJtBt1pI5Bt2KaTwJ4JsST+XiUmp?= =?us-ascii?Q?4yZcwF0Klob1FJ8PBrwzK4ml9hMaNN9c1u9HKluGeFlxkxgSQTcjnWGHWQVW?= =?us-ascii?Q?LO56VT2lYK0cPIuGY9A7gHorg720ya/KEbLSY4FjpMcNFxhGtVW7Hm3Zn70d?= =?us-ascii?Q?1Ck8n5LSU7jJh6HS9w0RCbyAvfH+0RVrmtvcT7oF3MUuoKj44Iz4ROQwmhMl?= =?us-ascii?Q?qUIi4bOvUGzixeIIep4pa42yGCL/8xzQxfi6GkvJ+46pIZtmwO72epeEMJOd?= =?us-ascii?Q?4XdkbMOZHVGAfQlZztTXLItXuvrwQa6jQAelUwcY02Fe8/DdwSZYWaU7zrkO?= =?us-ascii?Q?lxRNdK5i5ci9DXHmlI4Y6Dr3uaa4JFDYVF2DJYBOu7/AEfmFkTMJB96n6LOF?= =?us-ascii?Q?iQb6NALUWJMvztMQUodEg9JIdm+Z6QOLa1iqxU3Al7V0sIB2By+YkpqREWen?= =?us-ascii?Q?KSXQiiGYdjqmqYpciQCXF4vuDPH8YtCGL9u3xHcbvgzitWp+nbaF1gnzhw4t?= =?us-ascii?Q?sQuNX2um3VzsBGOVc4KGviAqhaOIfU8rW1ey8Z2HuBC3sOSrMkMx5ixuCCx8?= =?us-ascii?Q?3XNEiQDpv+VnjVCDeCQLNhbMelflgcPo9on2VxHRwAuQ9Q/NBRCy4OxR9bA2?= =?us-ascii?Q?Gumg7wpmM4wU5TY2yDdSxHT8cUcwJtCVDPWwU3Rc?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: a8ebb9bf-1faa-4bda-6f74-08ddfb3b51c0 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8833.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Sep 2025 07:23:55.3304 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: f0yIl0jpUpNjbqLY4CdQIKB9+/j7B3Di/pWe6DLcsTe6UI8YCCBUFeoBbdczxinm3XfacdS07AMd2TdXkp/NgQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8271 Content-Type: text/plain; charset="utf-8" The ASPM configuration shouldn't leak out here. Remove the L1SS check during L2 entry. Cc: stable@vger.kernel.org Fixes: 4774faf854f5 ("PCI: dwc: Implement generic suspend/resume functional= ity") Suggested-by: Bjorn Helgaas Signed-off-by: Richard Zhu --- drivers/pci/controller/dwc/pcie-designware-host.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pc= i/controller/dwc/pcie-designware-host.c index 952f8594b501..9d46d1f0334b 100644 --- a/drivers/pci/controller/dwc/pcie-designware-host.c +++ b/drivers/pci/controller/dwc/pcie-designware-host.c @@ -1005,17 +1005,9 @@ static int dw_pcie_pme_turn_off(struct dw_pcie *pci) =20 int dw_pcie_suspend_noirq(struct dw_pcie *pci) { - u8 offset =3D dw_pcie_find_capability(pci, PCI_CAP_ID_EXP); u32 val; int ret; =20 - /* - * If L1SS is supported, then do not put the link into L2 as some - * devices such as NVMe expect low resume latency. - */ - if (dw_pcie_readw_dbi(pci, offset + PCI_EXP_LNKCTL) & PCI_EXP_LNKCTL_ASPM= _L1) - return 0; - if (pci->pp.ops->pme_turn_off) { pci->pp.ops->pme_turn_off(&pci->pp); } else { --=20 2.37.1 From nobody Thu Oct 2 02:16:38 2025 Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazon11013071.outbound.protection.outlook.com [40.107.159.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 827122765D4; Wed, 24 Sep 2025 07:24:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.159.71 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758698646; cv=fail; b=N76YdSL7UiX9gEOkJNnubfiB7C09hE3b8zAK5z+SiGDO2cTyHteeoBgXT68nnBTmrNQxqB98CAyHt1DREHFkeFuKGxiGYW+d1t8NGJLoYzdPF/DIVYLbyBqtFbIVJPcMmW3rPe0T8w/Jrzwj+me4UZVZaREoUAif49rN+exRdo4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758698646; c=relaxed/simple; bh=w2n8ksJIaP0fhqG03nhWey9GFp93qgqDxQ0roMEHdF0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=qGN/P6J+vHWdoeGbFU3rSIvjiXJy4DCyoDRc9jCsqxHsepmcgscluJmitavVwAIofAIIUINARqSNHmHw1URabi73J+CiLbb/ST4Jq90hwDribvtRXGZaRlStwsMd7VG7TSxGQvyRNQM5nBTgtd+sCjVxCnxrOT3ddxB7bhQpA+s= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=Z6IUKZnm; arc=fail smtp.client-ip=40.107.159.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="Z6IUKZnm" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OqR3hHdi4REhsiA0DRLAAR72MbuRzmzAnJECu4NuP+tHLUvmv+h3z0sImD9yInMFJIz9YezbUPPEESLcPtXDJiwz2qAcM0Gb+MbOkEbn4d6yefJUpUWcgWC/nQA/0iiWnGesrUY9lIVEMVjUTyJ3Kpt3F3uvpPH2R5WDEdebx76pUjMJjx5YTB9y3q+58DQ72cOn4R77RBnWm/IBwqp1u6LvHzd7x0I9R7LEnN0qQQ9Pz4w2iHdIfG4g7d85PsogIJWYreidWd4XzESyHtRCuubH+kBaQ2kbd/aZRbOWBY8DSv38XWzP22N8RCVRayv3Q445D6U2eWR1fYxSoy2xjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H8M5LuVs5p+JSSG/ML4HHpQPLvl2gRSCJw8ohmYY9KM=; b=Nz/C1ziZk9WTYGixkI+C6pk4t3ga87DbtMGR4LBHlRgXczo8oRGCakN7GItKZrbjdzYv96hBVC9oDDNKlWd7a0FSNOyBBlIK7Vho4Il7ZLzjPk5OhCh1qDgUSMudJQYcHeQWtYbGyWn4YL/C5h2TshtXiV0djlpti4ngLPO4rkiuetqBCOgEjMXdF7Qfr2uWjoLqB1dBCa+BHCDSR5HmE1HlX8SvazAf6HxT1nUO/7eK81sCJzPI53Ap5Ps3rDglnKS8afvO3n3wxxUo3unegnY2I6vINQDO+fs9IjefUqrdalZ0ulVAMFNW6C+P6ZH98NHUI8yFFolXmD8PspYkSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H8M5LuVs5p+JSSG/ML4HHpQPLvl2gRSCJw8ohmYY9KM=; b=Z6IUKZnmA3k+jBq741J1ZOdgqALaC6U2qrCfL+eJ2L8LTNkFwqhvo0qR2TqSevIVldpn4wcRYEfcUafSjRUCvUIiih4HL9WGw36AwnN0aJt8r0wFxF5Jl326zH6rCAaNzk0OiK2oCApRRW+wOpAqdreqWNJKOI4lyNZCNuiKpby9GAm9ztPcnBnqO3P4zJbTqlvuQ+cJ6ymHLra2cX1dzxPbGRSVjeU7s+m82ovY9sRDr4DNLW8vuM3VHXcNm1WHrdTGgNVq1Osc+1KbkWfX83OBLHduzRpzoWNZwanM64Ss+Xrumrt1Bni1Bh/kwHk0mFRuzbTDrBlyJEOBzvV8HA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8833.eurprd04.prod.outlook.com (2603:10a6:20b:42c::19) by PAXPR04MB8271.eurprd04.prod.outlook.com (2603:10a6:102:1ca::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.9; Wed, 24 Sep 2025 07:24:01 +0000 Received: from AS8PR04MB8833.eurprd04.prod.outlook.com ([fe80::209c:44e4:a205:8e86]) by AS8PR04MB8833.eurprd04.prod.outlook.com ([fe80::209c:44e4:a205:8e86%3]) with mapi id 15.20.9160.008; Wed, 24 Sep 2025 07:24:01 +0000 From: Richard Zhu To: frank.li@nxp.com, jingoohan1@gmail.com, l.stach@pengutronix.de, lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org, robh@kernel.org, bhelgaas@google.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, Richard Zhu , stable@vger.kernel.org, Frank Li Subject: [PATCH v6 2/4] PCI: dwc: Don't poll L2 if QUIRK_NOL2POLL_IN_PM is existing in suspend Date: Wed, 24 Sep 2025 15:23:22 +0800 Message-Id: <20250924072324.3046687-3-hongxing.zhu@nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20250924072324.3046687-1-hongxing.zhu@nxp.com> References: <20250924072324.3046687-1-hongxing.zhu@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI2PR01CA0019.apcprd01.prod.exchangelabs.com (2603:1096:4:192::12) To AS8PR04MB8833.eurprd04.prod.outlook.com (2603:10a6:20b:42c::19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8833:EE_|PAXPR04MB8271:EE_ X-MS-Office365-Filtering-Correlation-Id: 07d882ea-19c9-479b-9e5f-08ddfb3b553f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|19092799006|52116014|7416014|376014|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?bn8LH+ATBXxX6H0ScENSOEcHi5pN70oz31gOdRxeqYDoE5IHvNkMo5qkPRsj?= =?us-ascii?Q?jmlk5pB0+4GQ4ykiHqe3PrebHvINIj5/TMF6n8zGQa5nl085v9FqLT8Hzhd6?= =?us-ascii?Q?QaafOyFHBTM7wgs2mC9q3FMmI7aNeFSAglaQAENsBstV7dkSQ9JqoCVnpd1p?= =?us-ascii?Q?LjLQSqlrN0OtBSandpFzpKfFm3cMBiYfku7cmpMTG5tUPZdevXeMtQw+FQGj?= =?us-ascii?Q?NTq5lgSH/QFEwzOvu81DZVNQ8FGX6sJ1L8zPKmTI5PjqNnS92xnUi7VzSIxY?= =?us-ascii?Q?W9JDj+qiw3eIPzZT7Jutdg7wXK/wJ+9cYjbHF+I3mm1Y79inTCORPD+vJzKZ?= =?us-ascii?Q?I3T+eGIOa/PTvh7zzsnFGdye0UKfEcq2lNK0NkyICh+yy5WdItCHPXkFgFwO?= =?us-ascii?Q?DpgmuNdlzxha2HDKFStKmgLibCkrqj6MOi4XpW8XJtxyX9uDwFkSTINmvOZc?= =?us-ascii?Q?7gGnkyun2WQGwApk7GjuzEQKN28hHJXTEUkVue3zVDsohKnPdOZe3jgAQeLx?= =?us-ascii?Q?STwjMVojzPzXID4ygOqrLOADOYUyj7M4FUI5Q4eVg4k9x8zKXlJXunek/J0K?= =?us-ascii?Q?7adT/vHa7tqD/Q5un60UNp/q6GUfuRzH0aDK4BpEoAX8HWVo6uiHUf7iiTH6?= =?us-ascii?Q?E5k/Nk4yvM6gFOQou4HGZ11sysEVh7dA1DzwU+kaK1AQi5308tasLy68xIBM?= =?us-ascii?Q?/20KP2q6HB6gCgw/6lm+CDKTdHEBDwh0UkBBaAqqh0NRYsigndUKEd4dtOiw?= =?us-ascii?Q?u6vRNOV1NxAfgtr+eKVeFLgUPG4cmFax/Ewe9NLHuXIkor0PUTjxgZxL5aCz?= =?us-ascii?Q?KjuB38OoAbn0TG3hf1DfCs4Mo/YVmkL0qJW38FLni1us/GsVErWVRmqQStNv?= =?us-ascii?Q?+Ml5Agc3XiVPC4oE0E28wT+6E47doFKFzfJ9UAZ8XxKerinrY3atjOgMb4Gy?= =?us-ascii?Q?KEW43kN5ZLcGmDGEia/xD5qBVmbuOT6I0ZmBW8wbpQZK5VzOTWsuAQAW62ZU?= =?us-ascii?Q?pvjuTGT+ZX7zR8r7LCpQFvuw3RxQGhu/Sc6kP26lPhvIq/zwnV1NJAM3yiaP?= =?us-ascii?Q?TCImrkdDzFdEH1lTyjuLyO/KmkuOsI1riVnNRDSlB3DbTsIxn11EJYUS7XSg?= =?us-ascii?Q?o3i7WxgkJA+f9KuA3oAW08UqftoFKrxjgHrW3EBtsPE4uWBTrFLguJtMCO8C?= =?us-ascii?Q?3dbl2BUGi6mK3yYWAGwBRoVN8EP7qT2+ZPT2msyXbXPW0UPOfahbrJAboPNw?= =?us-ascii?Q?4yMiMf2odFtboL3uQi5jrmsvA/aSndbeJvc0pGNTXRqnp/Y6uZeQAJvSf/ct?= =?us-ascii?Q?VtfQw9TeUCy1GkhIGKQ1Wt+B1rSJNu2lTTUMvb+hyKlNipJDnHeyD9CHiDzu?= =?us-ascii?Q?onUd8H64uYkrUUSB5FQ1WaFtQROFf0EpDLiuAZ/Sr0OkTqaR6sNeiimL9E6p?= =?us-ascii?Q?Jz6KY7KN8Y7HxiwMEShXhJ9vO8YF7a+eO18eiorV0tj9VPElr6Fsl/PBtw8e?= =?us-ascii?Q?AEeWmXfo7sFg+A4=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8833.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(19092799006)(52116014)(7416014)(376014)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fpunF2X5PzxvxgdEt+q8Hnrdd0bP4GE1GCh09OLJD26J3csfm1KJ4trbk3To?= =?us-ascii?Q?rsh8FPb0EULE7rzoK/0Vd8+gZRooqJZ6hxvg7xSZVNBkgxT8aQcCDYTZ4cgf?= =?us-ascii?Q?d+q+SMdXKKsXuw6zqDp3ZjpekQ7MV40/mSAzYxMZY8xo3QPlpEw43yIEsMCB?= =?us-ascii?Q?+3n0qzkKxgmhpCvssDy/iWM3pmEL5hZlDLxe3lYpU/XlmwvpqJ0eZ+8tK1bp?= =?us-ascii?Q?BMolaViADAoTroJYV3vQ1dSCnnLEOs4DN7egfhd3j/UwCx75nfA4nH2N1ZMV?= =?us-ascii?Q?WPLCx2FMOISgp6yEjEEH7z3y44Qc+CcZa4jfpUfxRS5i9xTZat7PHlHS+ZZE?= =?us-ascii?Q?e9BMB6nhnen9EOGIp7z4ILcFGMVpIURKvXK4X9V/vcrq3l9K69IB0kiglUx0?= =?us-ascii?Q?jxPrRw8em0T2kOehhsjMBsrMeyvhYheLJc3/QgYnO/a/laXxwQhJVRXzw8Kr?= =?us-ascii?Q?Q1cMighs1ld+GlBDsh9M6v+BgJ5A982ZenwO5UitySil5H6bgRvI5XZzGF8Y?= =?us-ascii?Q?zOXBg53Ld48BH2LuE3otp3zwvAIaei9wFVIE6z5XpUm6YbHNlrEXFwN8/1Ge?= =?us-ascii?Q?rMcSvtq2+jzZ1Yu9856S4rhAdqyLQIGlbsuF2QMqFZwl1LGJA+8H7RZCU4s2?= =?us-ascii?Q?8YVluKdk7dJ6L+Yog1Hkri65cR1sUgJVBaZKHMLHtk9pDSoz20/fHW7I+1AN?= =?us-ascii?Q?2pEspbYhJNFa9Aj8PZQLZGStoWFaOTh/YwnOff4VcsUvhkxT1EAQgAAeQWRG?= =?us-ascii?Q?twyWeLuQSHHvdCs71zqTEFyxTiBENdNmTP0MqEj6jDscubzAn8qOT6Y3kPmN?= =?us-ascii?Q?YqlX3AAOkKGiNirir+d3XHHfixnWZXpu+tI579J/a9kDzoc9d0oFwuWhiMsU?= =?us-ascii?Q?J5BhNRW2FwhWZ3kMVYgBW9aQmWRdEdmjYbyxp/KFoe81WF+bgTAxllqyHNfH?= =?us-ascii?Q?PkzN3mGVETJXut7nrdxBSSoiKKAuPnqophZQfEmZJ56va4+8iNx2ihk+/ltq?= =?us-ascii?Q?vT43czkTWZfgjGJhejhJPkrl5S4+w5DmrZCeydAb7twhJ/wjhzUrCpKlDpT9?= =?us-ascii?Q?csBDD+ZtDkCJA1u6yIPmgIab7ZeT1BZgR4VJD64GrUAZeqyYLOMVut/g4Giv?= =?us-ascii?Q?W9yvREUvzG/Gdw2xrRAO/OHEPFAbWCM759FLsWZWEXdJqtrW1THOADMQyhcf?= =?us-ascii?Q?Ak/4SzC6MUUCp0s71VMJ1p2Bh9Sp+PFcQeqDo74rpDkuBl/DIi2wTpGeljys?= =?us-ascii?Q?og3SVhwd6y2Bd8PwspexOFsTg6WgL++PNzWuJVCr23eo5PbcYKnJ49heOF5W?= =?us-ascii?Q?orH9Xg74/1DSaEe8FmxTNAF/hzqN7eCXaCFi+brTdF0g+abx3xwwTuXT50oi?= =?us-ascii?Q?wBwNBB+F1BCqyPsZn1G69Vq6wUYUUcBswuMoUrejqXoGtEUzsRg3njcRenu+?= =?us-ascii?Q?6FCu8AoyqEnyMQ8Y4IjZJt1fLxQ8VmChKYMnIXteq/7kUUh4EEtxBxbSJRdF?= =?us-ascii?Q?v4XbQQzLiuG5pHao1HDmhWA4mYopvhDiaqQwDeGG3ekH6b3N/RuUaMFMXe7V?= =?us-ascii?Q?tsXMZjn7WCItQTeCZ6ViPS8chBBgl4rXD0o8q+PZ?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 07d882ea-19c9-479b-9e5f-08ddfb3b553f X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8833.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Sep 2025 07:24:01.0391 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3QtpIn8awK9tx7S6YDfvSkok9F23X0sW7f4VukUJMYHI60sDZHXwIrGP9LwROTFDRaAKwgpjUK2g8OlECJ6hTQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8271 Content-Type: text/plain; charset="utf-8" Refer to PCIe r6.0, sec 5.2, fig 5-1 Link Power Management State Flow Diagram. Both L0 and L2/L3 Ready can be transferred to LDn directly. It's harmless to let dw_pcie_suspend_noirq() proceed suspend after the PME_Turn_Off is sent out, whatever the LTSSM state is in L2 or L3 after a recommended 10ms max wait refer to PCIe r6.0, sec 5.3.3.2.1 PME Synchronization. The LTSSM states are inaccessible on i.MX6QP and i.MX7D after the PME_Turn_Off is sent out. To support this case, don't poll L2 state and apply a simple delay of PCIE_PME_TO_L2_TIMEOUT_US(10ms) if the QUIRK_NOL2POLL_IN_PM flag is set in suspend. Cc: stable@vger.kernel.org Fixes: 4774faf854f5 ("PCI: dwc: Implement generic suspend/resume functional= ity") Fixes: a528d1a72597 ("PCI: imx6: Use DWC common suspend resume method") Signed-off-by: Richard Zhu Reviewed-by: Frank Li --- drivers/pci/controller/dwc/pci-imx6.c | 4 +++ .../pci/controller/dwc/pcie-designware-host.c | 34 +++++++++++++------ drivers/pci/controller/dwc/pcie-designware.h | 4 +++ 3 files changed, 32 insertions(+), 10 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller= /dwc/pci-imx6.c index 80e48746bbaf..a59b5282c3cc 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -125,6 +125,7 @@ struct imx_pcie_drvdata { enum imx_pcie_variants variant; enum dw_pcie_device_mode mode; u32 flags; + u32 quirk; int dbi_length; const char *gpr; const u32 ltssm_off; @@ -1765,6 +1766,7 @@ static int imx_pcie_probe(struct platform_device *pde= v) if (ret) return ret; =20 + pci->quirk_flag =3D imx_pcie->drvdata->quirk; pci->use_parent_dt_ranges =3D true; if (imx_pcie->drvdata->mode =3D=3D DW_PCIE_EP_TYPE) { ret =3D imx_add_pcie_ep(imx_pcie, pdev); @@ -1849,6 +1851,7 @@ static const struct imx_pcie_drvdata drvdata[] =3D { .enable_ref_clk =3D imx6q_pcie_enable_ref_clk, .core_reset =3D imx6qp_pcie_core_reset, .ops =3D &imx_pcie_host_ops, + .quirk =3D QUIRK_NOL2POLL_IN_PM, }, [IMX7D] =3D { .variant =3D IMX7D, @@ -1860,6 +1863,7 @@ static const struct imx_pcie_drvdata drvdata[] =3D { .mode_mask[0] =3D IMX6Q_GPR12_DEVICE_TYPE, .enable_ref_clk =3D imx7d_pcie_enable_ref_clk, .core_reset =3D imx7d_pcie_core_reset, + .quirk =3D QUIRK_NOL2POLL_IN_PM, }, [IMX8MQ] =3D { .variant =3D IMX8MQ, diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pc= i/controller/dwc/pcie-designware-host.c index 9d46d1f0334b..57a1ba08c427 100644 --- a/drivers/pci/controller/dwc/pcie-designware-host.c +++ b/drivers/pci/controller/dwc/pcie-designware-host.c @@ -1016,15 +1016,29 @@ int dw_pcie_suspend_noirq(struct dw_pcie *pci) return ret; } =20 - ret =3D read_poll_timeout(dw_pcie_get_ltssm, val, - val =3D=3D DW_PCIE_LTSSM_L2_IDLE || - val <=3D DW_PCIE_LTSSM_DETECT_WAIT, - PCIE_PME_TO_L2_TIMEOUT_US/10, - PCIE_PME_TO_L2_TIMEOUT_US, false, pci); - if (ret) { - /* Only log message when LTSSM isn't in DETECT or POLL */ - dev_err(pci->dev, "Timeout waiting for L2 entry! LTSSM: 0x%x\n", val); - return ret; + if (dwc_quirk(pci, QUIRK_NOL2POLL_IN_PM)) { + /* + * Add the QUIRK_NOL2_POLL_IN_PM case to avoid the read hang, + * when LTSSM is not powered in L2/L3/LDn properly. + * + * Refer to PCIe r6.0, sec 5.2, fig 5-1 Link Power Management + * State Flow Diagram. Both L0 and L2/L3 Ready can be + * transferred to LDn directly. On the LTSSM states poll broken + * platforms, add a max 10ms delay refer to PCIe r6.0, + * sec 5.3.3.2.1 PME Synchronization. + */ + mdelay(PCIE_PME_TO_L2_TIMEOUT_US/1000); + } else { + ret =3D read_poll_timeout(dw_pcie_get_ltssm, val, + val =3D=3D DW_PCIE_LTSSM_L2_IDLE || + val <=3D DW_PCIE_LTSSM_DETECT_WAIT, + PCIE_PME_TO_L2_TIMEOUT_US/10, + PCIE_PME_TO_L2_TIMEOUT_US, false, pci); + if (ret) { + /* Only log message when LTSSM isn't in DETECT or POLL */ + dev_err(pci->dev, "Timeout waiting for L2 entry! LTSSM: 0x%x\n", val); + return ret; + } } =20 /* @@ -1040,7 +1054,7 @@ int dw_pcie_suspend_noirq(struct dw_pcie *pci) =20 pci->suspended =3D true; =20 - return ret; + return 0; } EXPORT_SYMBOL_GPL(dw_pcie_suspend_noirq); =20 diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/con= troller/dwc/pcie-designware.h index 00f52d472dcd..4e5bf6cb6ce8 100644 --- a/drivers/pci/controller/dwc/pcie-designware.h +++ b/drivers/pci/controller/dwc/pcie-designware.h @@ -295,6 +295,9 @@ /* Default eDMA LLP memory size */ #define DMA_LLP_MEM_SIZE PAGE_SIZE =20 +#define QUIRK_NOL2POLL_IN_PM BIT(0) +#define dwc_quirk(pci, val) (pci->quirk_flag & val) + struct dw_pcie; struct dw_pcie_rp; struct dw_pcie_ep; @@ -504,6 +507,7 @@ struct dw_pcie { const struct dw_pcie_ops *ops; u32 version; u32 type; + u32 quirk_flag; unsigned long caps; int num_lanes; int max_link_speed; --=20 2.37.1 From nobody Thu Oct 2 02:16:38 2025 Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11013022.outbound.protection.outlook.com [52.101.72.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BD52274B23; Wed, 24 Sep 2025 07:24:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.72.22 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758698652; cv=fail; b=FhNzEfvJwj1SOXR0xhnYVh2YOi8mpfrP8NhIuCNYnsV9b3jo478otgW07MQbQsLujgzLWLncuIj9G0l8f1BzowmhIHFLHPhN95SGf/ty5SaDiiIIqZPelXcNYrwuCQsjcxIhm+xHI5tMFbq4erRaZ7mh+pNvl3DgOel7BwrNLWM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758698652; c=relaxed/simple; bh=7HAu+0iz6I0fk6YjWQPvKw8lTqjS/LEzmQxbfoda0G4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=hGLKloayQMlYSLvh5jMlecOI1qdZlCjBe0yrcVKbtKBDY6HpziHKFBIt6L//EmJ/AcRLSDRRu1OuMejE+Ag8ahcZ+aJKErM+XnG/Siyt8ZtRJJB4HoYnngjvAwB6WY5Ykx7/cYqvr+iTi/nE4uXojaLIU3nmGZ7SVPA+XZFmxqQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=mZxgrNqP; arc=fail smtp.client-ip=52.101.72.22 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="mZxgrNqP" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mI6w9hlrCmNaasxAH6hY5W/2J77y/lfuttuzGuekHq5pq7KWvDyUv1fBa14jmI0Y1MlX2gTY3odn/S9koDPIHB1n3SSKPxL+OShJXB1LM4KBRAYaZi/OvXAju6D0GIA7sI1Tm6s6kTQ0+NnAjawYTptykSTlqn/+W4A6w6YSxswfdj2DeHWAnb6r30hyo4caY8SnfAkikno6pZ3MCe7E74WBVP55DI5f8v8Xxh/3xAV2/WBVoLB32mx2k/EziXaHJiN5LsfRKnlhB4JMqc4TFRiTGebcBIb4ED3j/SYtu1fEASOzDdwJdKqrtIynLTZ3KGQeuAF+BIX7/TN++ehXbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=koNm1Wvf7AYgnnGhRSlUQo39+fYd9F7f2/jyF/oILUM=; b=kcjC+YLF26jT/2C2uTZpHDEUEGf9hKyyYaKZRiUZ6B8o94d6NMggh5A7DfRoyFPhSbiXcka+tLfnOYb9SIcuZd1o016rkLYnFzy6DA+tZCpbZSpgb3Dl8xoDx+m4RgcX6D3zxcGh9+pViIj1brXOi7X2eVT5aeQzS4x92qipwKQJNI27srgdbgx6tM+tbUrKamn/d6Go2tUIfN0tB9QXaz8EXfGNF67GQGUbNAYSeeeS7vxqUw+0MHMgUNjpW3nflGq4qvQ3+lAd6Cfq2luXDq4ZBcU/5FRaYCBITvONGJZ6KGAVhdLd1oa8HGuQHbzS6pOD/NGrnxEvtVTyVIhE3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=koNm1Wvf7AYgnnGhRSlUQo39+fYd9F7f2/jyF/oILUM=; b=mZxgrNqPdWyWAt6JPOV5JVVrw8QsW66/TEJVZOxGXPp+0W5u4uxkTxWSpQf2Pwvm18SroalESknM7S9g37ToG3CDhkMSmHOp5m563PhPJ4AZUn44VBaerKSWbYPIIkcxrQwoiSYRz8VHc89lGLSwjRC9S7xrz8R1npXtG3yCZjvc08Ks5hD76QJcQrMyiQhafhFycsiSkd4sYFD8iI+DpOJVUqUESqWbzGF9Wje7b1HCqV91mFivQSYZV2TZlcivM63t9AvkA/3soePc/HlTcTOJPQTuYVy2FVOosq7iHXwZZ/tV1Hs1yFXWRmM/x8dGcWY9ov2cQmeD0J6EaJ78YQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8833.eurprd04.prod.outlook.com (2603:10a6:20b:42c::19) by PAXPR04MB8271.eurprd04.prod.outlook.com (2603:10a6:102:1ca::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.9; Wed, 24 Sep 2025 07:24:07 +0000 Received: from AS8PR04MB8833.eurprd04.prod.outlook.com ([fe80::209c:44e4:a205:8e86]) by AS8PR04MB8833.eurprd04.prod.outlook.com ([fe80::209c:44e4:a205:8e86%3]) with mapi id 15.20.9160.008; Wed, 24 Sep 2025 07:24:06 +0000 From: Richard Zhu To: frank.li@nxp.com, jingoohan1@gmail.com, l.stach@pengutronix.de, lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org, robh@kernel.org, bhelgaas@google.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, Richard Zhu , stable@vger.kernel.org, Frank Li Subject: [PATCH v6 3/4] PCI: dwc: Skip PME_Turn_Off message if there is no endpoint connected Date: Wed, 24 Sep 2025 15:23:23 +0800 Message-Id: <20250924072324.3046687-4-hongxing.zhu@nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20250924072324.3046687-1-hongxing.zhu@nxp.com> References: <20250924072324.3046687-1-hongxing.zhu@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI2PR01CA0019.apcprd01.prod.exchangelabs.com (2603:1096:4:192::12) To AS8PR04MB8833.eurprd04.prod.outlook.com (2603:10a6:20b:42c::19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8833:EE_|PAXPR04MB8271:EE_ X-MS-Office365-Filtering-Correlation-Id: 9dce475b-0466-4f63-0a8d-08ddfb3b58a8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|19092799006|52116014|7416014|376014|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?p5EGFqP25a7lC9BSI5OfkKzTRgbeRtyUu6L2zLYPQU57DffQw2N9WiFTLjjr?= =?us-ascii?Q?GotBWMnBSkPOSPclnplMhmcEd7qPf4Zldx6CywV5hxYRkw/QyqC9YDs/muaX?= =?us-ascii?Q?APn5FavXkqHYW2WyZpe1mNLy1URxb9rKoAs8lWeIU1bCo7yzTQQD+RRprX55?= =?us-ascii?Q?hzr13i/aKyzzWZ+Hm1RlrfgQQqVhukdOfEw4oOdQkC779DZFQsAi6mNliVnK?= =?us-ascii?Q?w8KB6+UcYhy+Mj674+OhFv4STCCNbJcNHogD3XLvRMENjSO0McsDdHE3w2vh?= =?us-ascii?Q?HGLI7sd9oMgAOuw5Xm8U1sydLm6Y1kLIw0K9vIRBYrdHjQYfMFAr6aBwvg/H?= =?us-ascii?Q?CrHvAY5u8PS2PtioJHZPAoVL1DvWbCywzPnv2RHBdM+iaeQXefs6B2AOiB8X?= =?us-ascii?Q?9wf0SaXVxKUOcgnOuwzyvZ1rGYAJEPuhKgKNvh3Zpc3axs77q8bEc2wwV7EQ?= =?us-ascii?Q?B+DboxBgoxo8XzWCSTDFvNxwo3Q4LU2kjfVUkHrsQNpaHSSWY8yo/X8uhvhB?= =?us-ascii?Q?4yUTxMc3eOoO/aLDVEZWcQ7UKr4vjn+J6Nx05o/Eu3/vDd4Z2QB2ISXyNXFk?= =?us-ascii?Q?6IzsEglfotMKsr1/xpdDRaNLfhe3jhZKmZ5e/cSGK1DCm3MxHr8ZvRytERqF?= =?us-ascii?Q?UAnaI/XbVxNrAZXZS9aimqopQgGmTYtLqnMps5UZgj92nf1PmckNR1XWwtqR?= =?us-ascii?Q?vGtxPnjrh7QXVWyjKb0k0KLeHXZisqL/EGQ9cuSiNVCay2e2TA7xSic73QWL?= =?us-ascii?Q?JSaCIAk0PVpNrhXQ5XmUhPLtF1kMhV4UOo8BwtyW4qt2sF6cs+jPQLR73Fhl?= =?us-ascii?Q?ZSHV+kdjs0rYRcpEcPWEbe5FfdiR24MXAHDqWHkGweQ2WfNKgTxK2q0jd0aP?= =?us-ascii?Q?sTvI8T22ii4Mz1Pooa3Omj1+4CYRu4YcQ0yZ7NDc9Nr+TEsk8gSvZ9h7WRVx?= =?us-ascii?Q?t6lXaC4pg0CPdAb6pOVsIlNQTVUGVgR/NxN9yCYQFKnJfUJ4mOPpDHLGcPVo?= =?us-ascii?Q?6DprOkkHhRoZGG6t8IB01Tpr0uhpXPvpT4VzKybpxU+loYLbVAjlsxqXKTZB?= =?us-ascii?Q?W5G6qz7r6TXivdRw62m7hd56R0eAadGbUO86I4TJW3foUmkZiQKzYzRAeFrF?= =?us-ascii?Q?Ia6ZPzU9R6t+VWnfbd0s8Vncdqn0t83Wu2kczXG7rpI2qSSYE5ejlDcC+1Ts?= =?us-ascii?Q?P7vGcqBQ8XQZOZdIOHJSeagP8tJn8Y10wZk13cJWg3K1CSlG4nBzvU4nQpX7?= =?us-ascii?Q?WjRZA/En+gWNikeQXWH3Bb/qQzwHF5WSG6cK8S93gn5nNbAs+h9ctOUacBJO?= =?us-ascii?Q?I6byKTLA0w0edZyWkTNWWyR+pW21C7n+nsrTmXm1NLc+CIXCnyhsENCgUSEe?= =?us-ascii?Q?y6/VWdQptHg5Fch57EaCl3PTOeW6y2zwQ9qg5+AXQToBN/4j/ZIBBvrhHUDb?= =?us-ascii?Q?qKLWpXOVOiX9GoODfD6p0bJylHjkxkF+dZaleWwBvR532EJ8gDLVoljQioUb?= =?us-ascii?Q?nZswRf7y6LMiLng=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8833.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(19092799006)(52116014)(7416014)(376014)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wCVr6p39ete9mvStsGoFNP9+LB0j2xVH3w0KSKlzfkNs61czVWtYbLLMbMyT?= =?us-ascii?Q?H1UuA6j0k4C7tXFxUDfnDcU6wsDpgCWa5yMOjiRSOPvQZXryOulmDnH94thT?= =?us-ascii?Q?S/ieEzerYplNiA6XF7H2qy1p4O6K00iI/fRjpf5g/tZFaou39ld86DNoF07D?= =?us-ascii?Q?TqgQ7HwT7NCwF0e+KKq250iEjlPsexNA8KkHlil6UdFzOT1tFiD2m2yOk8+r?= =?us-ascii?Q?ijtXbNrRWtluTWVjXmLpP7N9LvCbZA/Omx7BHvz5Sh+eLwoz0sHIymvp9Mgb?= =?us-ascii?Q?IMf2tT/9RZfMCGotyEdZ4HdUFhV6msFsKD/qYs3QAI6tunYqeBOyoa8nrAZX?= =?us-ascii?Q?dkUJJpM+9KkAEdYzqLSBR+SY7mr+XhfI1mQjf30vv26ErowBw2zNQCjINXUx?= =?us-ascii?Q?y3MrgP+qVlp6GoIVzvKkuteejRhp0cZRLwCwh7udMgYm46t6I04Yh5DKEgg2?= =?us-ascii?Q?putJmtUIFtzJMODN83Ir192cATJ6ZSTnFhL2YfFh29VYT6BdswMpE2PkPuQC?= =?us-ascii?Q?lB9k9d4GwVvHymKWtok+pB4sodVrNFZRlsbNZoZrV19Ja4vw7NBhMcqTwozb?= =?us-ascii?Q?Mr4mQmcwe2kkEAQ5iKkc/4bZR/w+2HFlVgSl1kYgkJD4DwoJM9MOSQM3ITqZ?= =?us-ascii?Q?cIwu+rGamxodr0w3jfQUh3vrLnZboqQxmKn6fZeL5OE78xJuZBcBPDypN/ak?= =?us-ascii?Q?2yx93T9QxByLnxO9qdY/k9sR2NDeNTtEVEfP74ZizS33884pKH4tNBRs5W2l?= =?us-ascii?Q?jkXmGUVcjuBDeIWa3ESL8QJU/KnD8WIrwfVDzF39iTNz8Zr0x0QUcc3ETN45?= =?us-ascii?Q?6TXGvWjUHtERbHGRALVcyqLjLaeyK1eGqA/WuCclHwJxYj+iVucwvz+kUFfF?= =?us-ascii?Q?6Q6gQnKjXgA64GWs3fSJ/yrsNIcxm9ndRtLaIC/OfRXN7F1zmjFKe46yUTSI?= =?us-ascii?Q?90DZReb+6jwiV7hmkw3I3iVaHMChTSn9lK857aQeTMk7ppc+8alHnd5Mo9tZ?= =?us-ascii?Q?oCSksLGnEGyVyuh6J0d1qKr0CKZRUf1x5rQ8my2bhWeuF/XP6gOrBE4hGW+d?= =?us-ascii?Q?oKwqOecvw+dLUriO90VNqD1hsU5iqI/Y6S4I67BrQGWsc3vswid2iZM1Cy/I?= =?us-ascii?Q?n0JQ5yDoUqSY22jqo+eNkURr8bDA6BB0y5oivmucE9+iY/ZGSh8EGibRTRLY?= =?us-ascii?Q?tNanYjlfJmcxR4Sm+mc7/J9emX61/ZsSyRc2KVEXRHW0xA1mKYykt4dpJwMD?= =?us-ascii?Q?KOjDpRlhDRkDAMeCOFomRuDthWkilM3DLoYt4YuVlTSV461yztKEdUvFJuSb?= =?us-ascii?Q?wOhC2w3wiNwdd9mUaPcPv61Ri70HOMwTJS3HqhU2La3mQkkNIu8q2Ge+6Mds?= =?us-ascii?Q?AP/lDo+jVhv7qoGNWpmAfCArc3UFIHLU/1MbSw0eqtsvm9cazjAqjk4ghNrb?= =?us-ascii?Q?qQEDKt54cHYPgEwFzO4Wmx8zAc7YHtrwoCKDDxQoaN1di4evezrn06VDjwx1?= =?us-ascii?Q?jBN4ODQSChVS5puf7dzYqSlKUrKk6LUgaJDBcROz+XkTmdoyvIvI9VH/gLBd?= =?us-ascii?Q?Jm1Fgestm8GnnXDp1pu0BcPS5Rt05yayFda5CPZ8?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9dce475b-0466-4f63-0a8d-08ddfb3b58a8 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8833.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Sep 2025 07:24:06.8508 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: apamTG/RhAACb+kae2x8prII3Lxg5+AzCYX7v1+xvbfYdwBteoWNR2SX6b3oF+lyQAyZx/yss7NQrMlMfFODFw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8271 Content-Type: text/plain; charset="utf-8" A chip freeze is observed on i.MX7D when PCIe RC kicks off the PM_PME message and no any devices are connected on the port. To workaroud such kind of issue, skip PME_Turn_Off message if there is no endpoint connected. Cc: stable@vger.kernel.org Fixes: 4774faf854f5 ("PCI: dwc: Implement generic suspend/resume functional= ity") Fixes: a528d1a72597 ("PCI: imx6: Use DWC common suspend resume method") Signed-off-by: Richard Zhu Reviewed-by: Frank Li --- drivers/pci/controller/dwc/pcie-designware-host.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pc= i/controller/dwc/pcie-designware-host.c index 57a1ba08c427..b303a74b0fd7 100644 --- a/drivers/pci/controller/dwc/pcie-designware-host.c +++ b/drivers/pci/controller/dwc/pcie-designware-host.c @@ -1008,12 +1008,15 @@ int dw_pcie_suspend_noirq(struct dw_pcie *pci) u32 val; int ret; =20 - if (pci->pp.ops->pme_turn_off) { - pci->pp.ops->pme_turn_off(&pci->pp); - } else { - ret =3D dw_pcie_pme_turn_off(pci); - if (ret) - return ret; + /* Skip PME_Turn_Off message if there is no endpoint connected */ + if (dw_pcie_get_ltssm(pci) > DW_PCIE_LTSSM_DETECT_WAIT) { + if (pci->pp.ops->pme_turn_off) { + pci->pp.ops->pme_turn_off(&pci->pp); + } else { + ret =3D dw_pcie_pme_turn_off(pci); + if (ret) + return ret; + } } =20 if (dwc_quirk(pci, QUIRK_NOL2POLL_IN_PM)) { --=20 2.37.1 From nobody Thu Oct 2 02:16:38 2025 Received: from GVXPR05CU001.outbound.protection.outlook.com (mail-swedencentralazon11013032.outbound.protection.outlook.com [52.101.83.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B196F277C87; Wed, 24 Sep 2025 07:24:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.83.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758698658; cv=fail; b=fANirxVWF6ua40XPpNbQdHTuDuGkFeBCLiOpgsoqheQ2cJVAngG0FBkHal+av+Nf6cXImrPR/JHu4W7RdcB8JX0Z9B2wPhOGfPi6961hG4FY8sbSmaTrKnr3esPTnDsu5WaksSlWFnVUXusgRRqxxdoGZmlAgHaAl67xnZUl48w= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758698658; c=relaxed/simple; bh=UlaCrmPOng2Ex32GctbCL+S+SMwvOwg0PX3qpc4JhX4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=DX65mgpf8QWezf+OOb+Pv3VAfJDhNcpEzyBoCU02Wf0iq0R/+IgFoGH383aXAhmvlsJa1uniGliE/T4rGIuD62jBaXwqAhrIBQVNIxuudkspAFA5LBim6LsHEaHloOR7Yecotd2+dV/VbMMZKr8mtYArInkCQDO1pMxTxEPdORM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=CligES47; arc=fail smtp.client-ip=52.101.83.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="CligES47" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yQvDfZnL8x0fH5bYZT9mjgeqkc1gBr/wzl9ABp4nWKESWZx0oDvxNi9keRewap5mvAFUj/anSyF4MIHwcpIYohv1WBL6+FtKM1m1yX5sGRYopucihjQ+zdVT3K42i6EtD1zkgFs3pIzoRfKMp+7bK4IsyLySpb8oD+oX5Ahqap8AzyZ9kfCb73stYD3uksbiX49F59s+rHXshifzI9W5AdjVOmWmR7dLGKrtg8Y0iLYtKCDSY2/h32sqIhCwLLFr/bgmqDjM+BVEhg3HYeJGB5COOjbnS525+zqa7KSZCRhzq45hLUpthfP0ZStMl0Q4mPUQ4arde78RA0TySSZhJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xbj7KMFOecHJ2qDwJCN87Tph+T0NsVu1XNu/Fp76H+s=; b=CAeEdyf13r5oGK9UhNrRY/EFV4ok+JoiOSPxA/IlwswqSKTe5sF8sf1rccS61jsATo+8N2QWXNw8AMoZFPTtpAjWLhK//4vfp/g8akireLZn46B6Xrr15IGDgSDZvqMNe2tJRcAwpzOJs9PO90/ocYVs3yi6bcCLuynNn8YSpVEHXlelPVwKRM7CIe2UITTmObOJ1D4Rv3QI3n4lPt34GikU0gUlIEgm1CUiDSOa7m4d6DBDB9I4WcOl7cygC4qROcOH+uwVsNSmtaTJSdfLv9gtxIfm/eNcRbaCpWjeamHthZYP+UkrRzYyIYngVw6Qc6lUeoa4I494F4l2oihkeg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xbj7KMFOecHJ2qDwJCN87Tph+T0NsVu1XNu/Fp76H+s=; b=CligES47uGwR3g9ZwhZGzNc3RM1gyQBabiBC9ksQbnHodoi9ck+7PnevOQ1I2ZA5+xUvAB73vgtgbfzdZJ5mnwFLveMQmlmDHOBk2D/eocYiYr3VIUWAiewhYUq4YTbYMCt3RsBMf6flh5f8iD1dbBm7lZOAUrrLQLULxs2g+SVKc6n328gRT7BMzvJ1wiois3sFEd3DngVicbTCqHUmGcDyrnLgWY3lD+iXQVd1B4dFPbFUa4WnpwObnsmqUDpJtBzWU1Qma+Iu0Hh1GfO+VlIV99ubYHja85+InZikgTlbQT9+9Twc5LokzwWK08FVqpcqZ7GEiYIuHrs/yQ/X4Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8833.eurprd04.prod.outlook.com (2603:10a6:20b:42c::19) by PAXPR04MB8271.eurprd04.prod.outlook.com (2603:10a6:102:1ca::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.9; Wed, 24 Sep 2025 07:24:12 +0000 Received: from AS8PR04MB8833.eurprd04.prod.outlook.com ([fe80::209c:44e4:a205:8e86]) by AS8PR04MB8833.eurprd04.prod.outlook.com ([fe80::209c:44e4:a205:8e86%3]) with mapi id 15.20.9160.008; Wed, 24 Sep 2025 07:24:12 +0000 From: Richard Zhu To: frank.li@nxp.com, jingoohan1@gmail.com, l.stach@pengutronix.de, lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org, robh@kernel.org, bhelgaas@google.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, Richard Zhu , stable@vger.kernel.org, Frank Li Subject: [PATCH v6 4/4] PCI: dwc: Don't return error when wait for link up in dw_pcie_resume_noirq() Date: Wed, 24 Sep 2025 15:23:24 +0800 Message-Id: <20250924072324.3046687-5-hongxing.zhu@nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20250924072324.3046687-1-hongxing.zhu@nxp.com> References: <20250924072324.3046687-1-hongxing.zhu@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI2PR01CA0019.apcprd01.prod.exchangelabs.com (2603:1096:4:192::12) To AS8PR04MB8833.eurprd04.prod.outlook.com (2603:10a6:20b:42c::19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8833:EE_|PAXPR04MB8271:EE_ X-MS-Office365-Filtering-Correlation-Id: 1fa8be6a-da01-4281-4515-08ddfb3b5bfb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|19092799006|52116014|7416014|376014|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?YFus7Z3q7kv3DgusTzJEkXdQXH/sz6ke20+E5T6oKPbbFmK6NdIAnuAiMgRm?= =?us-ascii?Q?mmv0DP4rQ0QRqFd9uQS0lyZY+tBex1e9x2VR5OzoXaeut2QInLs0fgLIZRbI?= =?us-ascii?Q?qnUv04/Fh8qvWYrW6Kwlc8R1BuJqXSeQMpPsCl9jWaIE51QB/N5lsm4i9+h2?= =?us-ascii?Q?yKvPEiHbK5XmYyy+J4dli3zXg7jNaSrV2WuZRvHjPNFvmaPhTYa4x7wjJ+PP?= =?us-ascii?Q?L7wM8bUxIabR67OT0bPTFhf6X0Km9xLYPl8jqK6Ay4d+mg7YqI4mi0GU8RJR?= =?us-ascii?Q?3OIPgU0qPEvFuZgN+KkB1sywQ+o37mJyJIibyQVzMGfOGiuL55ZWALxiEH8j?= =?us-ascii?Q?/bVDPUgqwT+WzZj6WaQgXtuc3Mf00rDxULWMevLbRjixQqjimc/170GQHbz4?= =?us-ascii?Q?uPR+sM/IZd/omJ5v7xvPXcVvCXKjjH3NUT1zYlcR5QTcfFkZY+Fhx4jplG7/?= =?us-ascii?Q?5W9QPV1yvHMxdiLE2zE81HBDHLsy54SvJGYFESrbBgK7kiO98j2ShTSK7TMb?= =?us-ascii?Q?K4Zz+Dl13GuLhL4zahCmIEg1DnWE5I4asY5relp6oco/xN4ZIjKxwYeiDAiH?= =?us-ascii?Q?uyTdQ0Zg8yzYaCYH6PilDhGPfB0onO3B2wAXsCrNqT46wapxzXz7MbuD3RWc?= =?us-ascii?Q?i45proV4uhwYHJ0VyJwIVKr4N9qyrKBpmNuRjU17tr9EzOPLpLgFK/funoQk?= =?us-ascii?Q?mkq2jeMo/XFkTjSe2S+eKOeUIpMY0L46mGq+0/TmskoCN0MhgPpYI3xMVvok?= =?us-ascii?Q?KdFzmKfuARKkH8zAy8XGzNCQKT0NwiidVxdoRtC72ETFsPUDGT0Vipougdy3?= =?us-ascii?Q?7Z8P4/L5SI3JVT8SAUdquV2CEzZpe68ojbsYSqqmNXKDN0iWvEkgflRQK6d1?= =?us-ascii?Q?PrVQPFBMp76MNF+EB7nwkWMeD8zmvGw+0JDuFqN6pdZDshpAkwHb5WrU+gxd?= =?us-ascii?Q?3CZlBmuGT1y9qHqcN2wYgtNN9SQJp302rKw86h1PSs/5p4VuUlN8JDvUUoh1?= =?us-ascii?Q?lKHEnpJ0vO3Ff3k6CYovE5lcjXCIlU5zaK0B4NLsQsqcBYBeW0Zfz8mj8K7E?= =?us-ascii?Q?gyfQz7t3LrVCl0qv+VtwPTk0fQfDDOvnmwASEh0B29R4I1hmqDFElgLMXFv4?= =?us-ascii?Q?FpArumRtknJKslZ/nI2BLWgHv6RDB/FE8LtKvePK14ZqCOryc7wrTZL6eFKL?= =?us-ascii?Q?jKHi2im2A/LTX9Yfoi8EOOTbffJsgx5lH1OyujhWhszkzAYds9YzwVutUV3U?= =?us-ascii?Q?F/Qgq8KohLUKN+MLIWdIvqdPiXtFWzgCa+AdHpiX6qbQ9oHd5kESL50iCRcX?= =?us-ascii?Q?s54jNvVkGe+eP0VWiflW44pGtKazubkRlN0vA2tgxkH/rzxiLkDSoSmbcptW?= =?us-ascii?Q?T8Za1MQ7Glbjy+j4nSg6GWChCVD6FZ8q+KuRrvSYoaIkKwuH1FwjM1DZ2huA?= =?us-ascii?Q?J/PeIrW328WBnlV4wugNnx2OjpajaO4sugYQdS9nWpOEKKr4nnw+C8NJFI/T?= =?us-ascii?Q?rX2tHByY/o2Gzr0=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8833.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(19092799006)(52116014)(7416014)(376014)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VK8Bwi4y8oZ5GYOfL63j2GiYI7e6L21VqKTUYjOr2VXbxtfGz9G8Bp4vpdvs?= =?us-ascii?Q?sBC7AoMq0UaKhf/PO0YZmAYSKsNN5zUoQR3jm6+FGhofYzl++u2I1JFszBNj?= =?us-ascii?Q?UP8VfB/4rQiOz4d+J4f3FaqfzP7kOijkOCSipTacvsjh2SU2/Z3l1e90XVkD?= =?us-ascii?Q?WWB9P2nZ01nfeFsUKBwEmSAJNe+oRnIXwFSh0OwzUsCds+vLBIZCbsdhtsB+?= =?us-ascii?Q?NPTj4PPwJKz5jNGVFld0c3Hli7nW48v1638+4vUZPxMNRuJRp4DCxdKBXO5e?= =?us-ascii?Q?KGjhkgVPnNZ20/8ajv3hMrayqPTN49kWFs8mrPvid8v5ZpLCuD2JvZ7MAb6m?= =?us-ascii?Q?q9lCRDQ3WpuYtllXGpfM1vg/jOdAwLj8JWQloEUTcJ0ZOKCtt+f8vPvps7dz?= =?us-ascii?Q?N9qI8RcWI70mr52LHwdCQHeSph5p7wxJqeMLmjWlwiuVXnt0wK9wRL+SWrfq?= =?us-ascii?Q?+YuAa9e3nYh7dxhjh02TyaTOCUjNGilaSm0xuDo9JujMnE0A/7MIWpzBAVF3?= =?us-ascii?Q?s3PR8IIniFEZa4X9V/8jiaoAhAvE6VJeE9N4TCDuguOrq25zkmwK/qtXIfIs?= =?us-ascii?Q?NPVdVGDlzj5OjcSESgfynqsoVvkRYiZeA9YD+N3j3NccLwq2hazRDKD85hRl?= =?us-ascii?Q?EA/Stb6goQVo2gRhCJS2umhhRV79Q5Kgg+caMn9cBgbGZvjqsKt4zSNoFIfo?= =?us-ascii?Q?o2zYb9PoBOSBYyd1kAcoGkjJyI5vUcVsNHxByPXTFKFHCyVMXUfl+t0c85Eh?= =?us-ascii?Q?YeKJTzZvGxzjWi+CZmi4qhDvPGMov35AY9vcgFcLckQHf+vmp9J/BRVyiBWn?= =?us-ascii?Q?1V9p5tkQyoQQ83s09sA4JdK2KiAXhmO08LTW3WxXVbrXWRjVA2sy9WaraFcW?= =?us-ascii?Q?wskD5xn6Cn9xHTSMuekSjaE1wawIq7EUJr0zMxv31fOI2ccRmW6nJnfvJh32?= =?us-ascii?Q?3Qztr3u/8a/qDpbQvdqBtnYSe7SwExntcCQhFQ3xLbAubPgsPsNN463JSZ4c?= =?us-ascii?Q?MUwTZXYH3YhCIKVLjQnbWqk8USuavzwcOWGH3fFvTs62QeN4zND2dPJLlYOx?= =?us-ascii?Q?LCenZuuoNmM+8T4hpWXqbSM7hYPO94SZ+5Arx3f3wCN8HPUc1Q9nOVlCqOYG?= =?us-ascii?Q?0lIqfgnBqOwoc/2jhh8gUl8QVaYpzFB4ISWS2qeQjRHKqwoRLNeX2yfJFHfZ?= =?us-ascii?Q?Z0EIrgue+xRp817q29Y6kIEN9BYssculX0RP7IMv7HgriKUbe4pwseVNasIw?= =?us-ascii?Q?mcORgOozL+BCczN0zjWKbqslsvslZGQScUP+/xcbBmb+ge5yn2iZ5VMTEDKE?= =?us-ascii?Q?hy8kJrGivXwsZcVAycoIsUPN94HXUROquNBk0tJbK3zAseSDoPipmhdeN4cp?= =?us-ascii?Q?QhEHKzj+kTNTRlo78G/HTqb6okOEHZeeW0FpZJSYEHJWY8FuSl3/iBe0lO/E?= =?us-ascii?Q?2t0sY58LsRG06NDd5n6QKbdJ+YXWBESRHwrsske/y7BlNzf5KVKjjff0YJNS?= =?us-ascii?Q?LF5MAg82YupvFk4y7KMt/T/he2LNtY/fSWB9z2j4Sq7rbPK7sUqLsnra83JQ?= =?us-ascii?Q?HZyIJ/0CL9cTz8PlUotdeQ8oXxxWHmJ6k546aBXN?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1fa8be6a-da01-4281-4515-08ddfb3b5bfb X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8833.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Sep 2025 07:24:12.6781 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FEVHPRTxnnhFYQQODp4jUo+weiZ83yf40Mk+Xi3rGtztUnRQKkappe1sO92GGHRKIiBjE7pzmMw+LNZp2ZzLhw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8271 Content-Type: text/plain; charset="utf-8" When waiting for the PCIe link to come up, both link up and link down are valid results depending on the device state. Since the link may come up later and to get rid of the following mis-reported PM errors. Do not return an -ETIMEDOUT error, as the outcome has already been reported in dw_pcie_wait_for_link(). PM error logs introduced by the -ETIMEDOUT error return. imx6q-pcie 33800000.pcie: Phy link never came up imx6q-pcie 33800000.pcie: PM: dpm_run_callback(): genpd_resume_noirq return= s -110 imx6q-pcie 33800000.pcie: PM: failed to resume noirq: error -110 Cc: stable@vger.kernel.org Fixes: 4774faf854f5 ("PCI: dwc: Implement generic suspend/resume functional= ity") Signed-off-by: Richard Zhu Reviewed-by: Frank Li --- drivers/pci/controller/dwc/pcie-designware-host.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pc= i/controller/dwc/pcie-designware-host.c index b303a74b0fd7..c4386be38a07 100644 --- a/drivers/pci/controller/dwc/pcie-designware-host.c +++ b/drivers/pci/controller/dwc/pcie-designware-host.c @@ -1084,10 +1084,9 @@ int dw_pcie_resume_noirq(struct dw_pcie *pci) if (ret) return ret; =20 - ret =3D dw_pcie_wait_for_link(pci); - if (ret) - return ret; + /* Ignore errors, the link may come up later */ + dw_pcie_wait_for_link(pci); =20 - return ret; + return 0; } EXPORT_SYMBOL_GPL(dw_pcie_resume_noirq); --=20 2.37.1