From nobody Thu Oct 2 02:12:30 2025 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADAEA30B516 for ; Wed, 24 Sep 2025 15:08:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758726518; cv=none; b=ewiDieFZoZzpX018ceibYCTY3FfJJExa3SnnBmfaLi044/odBekHtc6u7Xl4NRzHpMk/xGxFxPrfjSbd+pmLB1j+d4ZJr4z7GkHAGVXckRuGHhvtMHVaj3EL2weZ7tUeey1pfKsybKS5brFznXeiO4PzRPsq3YTzyT9Xlstntg8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758726518; c=relaxed/simple; bh=PTADnA0LADRWGW6ihK0MzVzHyCbS7FLm6geROUlYFeE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rrlyMfheBNrYKIkhfRIBIxE3asU0xuIAaTNVdzwW9dStdm5jtwD6a29SGGAosO4rwIa6/InDDrPX5BOz80UMIpSbiCsMESoxz3kq751eWIfu3ZbPw9GKGr8kSrFK5EsPtGxyvEbj+5oIN778uSyWm6mQjoFo8qgPm/MB+CQXKts= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Kgt+g+y1; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Kgt+g+y1" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2445806e03cso90837085ad.1 for ; Wed, 24 Sep 2025 08:08:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1758726515; x=1759331315; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=B+m5vlhNwunXS3NJ6FmDWyfCPUSXUtwy+/7tRflWyDU=; b=Kgt+g+y1ew1nE2FhjHDP1/SbRn52z2SCBYPgmBAl/idMuWXNtS91vt1aw1svT6vpPl oKd4heW0CssB0Fcs3sm+yYg04TvZ5MOl914ewKky46Jl82P0M9+x7O/NHJcxh7R0xZNY 1eComMG8aQaOXvU+5CigCTHKOodXPQbyW/iBbtwGrMO7jhUCYl3GdBUp88bUhLRQxbAg 3tLOhMLCGzgIRrD7GC0BYsa1pKNtNa4Ivk4yZJCULdPkLY5PLUDHs3LYyPq3KH+58qV3 IsWKwu1MyhqzKrFHggiHOPgGQwussiwIaSc9bpTX7ao3LF+D/cKxqDtUuSIjd4S7vjOb kgkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758726515; x=1759331315; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B+m5vlhNwunXS3NJ6FmDWyfCPUSXUtwy+/7tRflWyDU=; b=neZhYaWyxh+qzzblHQ2aMOLT68/zLtZIR0vx6RLvjyyzpupBtTYg2ywkIhx7te3CLh YY483TvtIntAF3A3HelAoyZJzpkRQTW/vbtcaqNKQ3gzFA3CYaHmlJ4gl/CzgdFQdvOf gl/XvGvkOYKOpG/zwCyAv59526S1Y0n2uoS8x9HOV5lIXOzVf/QiQHDfFjN8GajjtOEs bm0WmS/nc4i/4LzF3NiFeoAUz1M6DDV9GphjXyLct0CD0CQlOh1yAXqb73dCs23BXpLo Aaqft+ZkuPXsN8Tnii0SBypY4dhYi7om5po92G3ODbKGA78ni+9KgDuQGesIG6x9XeH6 +ItQ== X-Forwarded-Encrypted: i=1; AJvYcCWTcbf09rX8xlSRkE6qMd6kSNqcSM98tIl8o3hrkcS/qFvtSEepDUQWFQ4nY+H+l3X71fBouubh1+jNqmc=@vger.kernel.org X-Gm-Message-State: AOJu0YwFrms//d79qbPoxJjtyQtazfokK2x2hi2D82os80me0Kk8O0jO Vni0spbNrEYq/Zne4n5eIB3oKS1MseVBryIE/7OeY4DZilS91nokffS+oevxb0lRzBQ= X-Gm-Gg: ASbGncuZot3+rfRdnL/rXhy26Mia1+WCVVIiywK8xz/MUFvu4GTHKExeDcYA8ZcPZdb OWAy/zYN8oFB7zn/zzfx/dZ/hT5kOvAlrfiQ9w3LJshSun29/WndGt9OV3j46OlRW9hxXpq0+Ds 8Ls/EcyuO63j+inIhT0X0rsWyLZR6+5QtOQY8s2vJwuwKQ1Ocf4rH/jhl7GP0G6zRLSANXHydl2 +Mo5eiXNmjGRNhR/FM1DkTjul4B3VxqVrECxK5/Td/UCpTrhfC0RNcEPspT8RYIGZhuZXu/Z2X4 ZruWepUrGduMmnFcZMjOkGBb4kNdPXJAeOFKl7VdMU2D/eF8+c2wpsc8lvAR885C7sCM95xkFSl HWOtFOPlHkG9877S2 X-Google-Smtp-Source: AGHT+IFiyjrTclsNn9tPuvEEVJ9Cj7y7SUK7Sjpx8qt64CmQ70ylZm8IikptBEeoSu7N0IEZVVDOqQ== X-Received: by 2002:a17:903:1a85:b0:273:31fb:a86d with SMTP id d9443c01a7336-27ed4a4929amr602205ad.48.1758726514821; Wed, 24 Sep 2025 08:08:34 -0700 (PDT) Received: from [127.0.1.1] ([112.64.61.5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-26b59d6538bsm158717445ad.82.2025.09.24.08.08.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Sep 2025 08:08:34 -0700 (PDT) From: Jun Nie Date: Wed, 24 Sep 2025 23:08:10 +0800 Subject: [PATCH v3 1/3] drm/msm/dsi: support DSC configurations with slice_per_pkt > 1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250924-dsi-dual-panel-upstream-v3-1-6927284f1098@linaro.org> References: <20250924-dsi-dual-panel-upstream-v3-0-6927284f1098@linaro.org> In-Reply-To: <20250924-dsi-dual-panel-upstream-v3-0-6927284f1098@linaro.org> To: Rob Clark , Abhinav Kumar , Jessica Zhang , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Krishna Manikandan Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Jun Nie , Jonathan Marek X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1758726499; l=3811; i=jun.nie@linaro.org; s=20240403; h=from:subject:message-id; bh=PTADnA0LADRWGW6ihK0MzVzHyCbS7FLm6geROUlYFeE=; b=9s1hagBRl2nfojsoIc6t6lqJydaDeozos2jpTYSSwNCUNLBec91ZvR3LGnrNT6lUKs4WYT/LZ a20IkJSHHkVBu8BCcLR3NOHM6tq4Wvzn2IMIkZ+TjdI+cFbNqlSdun+ X-Developer-Key: i=jun.nie@linaro.org; a=ed25519; pk=MNiBt/faLPvo+iJoP1hodyY2x6ozVXL8QMptmsKg3cc= Some panels support multiple slice to be sent in a single DSC packet. And this feature is a must for specific panels, such as JDI LPM026M648C. Add a dsc_slice_per_pkt member into struct mipi_dsi_device and support the feature in msm mdss driver. Co-developed-by: Jonathan Marek Signed-off-by: Jonathan Marek Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/dsi/dsi_host.c | 25 ++++++++++--------------- include/drm/drm_mipi_dsi.h | 2 ++ 2 files changed, 12 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/d= si_host.c index f297e3de8c3dc4e1326e70c78c046b5a19568cef..de51cb02f267205320c5a94fc41= 88413e05907e6 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_host.c +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c @@ -157,6 +157,7 @@ struct msm_dsi_host { =20 struct drm_display_mode *mode; struct drm_dsc_config *dsc; + unsigned int dsc_slice_per_pkt; =20 /* connected device info */ unsigned int channel; @@ -849,17 +850,10 @@ static void dsi_update_dsc_timing(struct msm_dsi_host= *msm_host, bool is_cmd_mod slice_per_intf =3D dsc->slice_count; =20 total_bytes_per_intf =3D dsc->slice_chunk_size * slice_per_intf; - bytes_per_pkt =3D dsc->slice_chunk_size; /* * slice_per_pkt; */ + bytes_per_pkt =3D dsc->slice_chunk_size * msm_host->dsc_slice_per_pkt; =20 eol_byte_num =3D total_bytes_per_intf % 3; - - /* - * Typically, pkt_per_line =3D slice_per_intf * slice_per_pkt. - * - * Since the current driver only supports slice_per_pkt =3D 1, - * pkt_per_line will be equal to slice per intf for now. - */ - pkt_per_line =3D slice_per_intf; + pkt_per_line =3D slice_per_intf / msm_host->dsc_slice_per_pkt; =20 if (is_cmd_mode) /* packet data type */ reg =3D DSI_COMMAND_COMPRESSION_MODE_CTRL_STREAM0_DATATYPE(MIPI_DSI_DCS_= LONG_WRITE); @@ -1008,12 +1002,8 @@ static void dsi_timing_setup(struct msm_dsi_host *ms= m_host, bool is_bonded_dsi) else /* * When DSC is enabled, WC =3D slice_chunk_size * slice_per_pkt + 1. - * Currently, the driver only supports default value of slice_per_pkt = =3D 1 - * - * TODO: Expand mipi_dsi_device struct to hold slice_per_pkt info - * and adjust DSC math to account for slice_per_pkt. */ - wc =3D msm_host->dsc->slice_chunk_size + 1; + wc =3D msm_host->dsc->slice_chunk_size * msm_host->dsc_slice_per_pkt + = 1; =20 dsi_write(msm_host, REG_DSI_CMD_MDP_STREAM0_CTRL, DSI_CMD_MDP_STREAM0_CTRL_WORD_COUNT(wc) | @@ -1623,8 +1613,13 @@ static int dsi_host_attach(struct mipi_dsi_host *hos= t, msm_host->lanes =3D dsi->lanes; msm_host->format =3D dsi->format; msm_host->mode_flags =3D dsi->mode_flags; - if (dsi->dsc) + if (dsi->dsc) { msm_host->dsc =3D dsi->dsc; + msm_host->dsc_slice_per_pkt =3D dsi->dsc_slice_per_pkt; + /* for backwards compatibility, assume 1 if not set */ + if (!msm_host->dsc_slice_per_pkt) + msm_host->dsc_slice_per_pkt =3D 1; + } =20 ret =3D dsi_dev_attach(msm_host->pdev); if (ret) diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h index 6d2c08e8110151a97620389197f1ef79c058329d..5a85ba01f402a3866b70828391b= b417bb8dd5956 100644 --- a/include/drm/drm_mipi_dsi.h +++ b/include/drm/drm_mipi_dsi.h @@ -182,6 +182,7 @@ struct mipi_dsi_device_info { * be set to the real limits of the hardware, zero is only accepted for * legacy drivers * @dsc: panel/bridge DSC pps payload to be sent + * @dsc_slice_per_pkt: number of DSC slices to be sent as in a single pack= et */ struct mipi_dsi_device { struct mipi_dsi_host *host; @@ -196,6 +197,7 @@ struct mipi_dsi_device { unsigned long hs_rate; unsigned long lp_rate; struct drm_dsc_config *dsc; + unsigned int dsc_slice_per_pkt; }; =20 /** --=20 2.34.1