From nobody Thu Oct 2 02:05:48 2025 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 530692E336E for ; Tue, 23 Sep 2025 16:06:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758643605; cv=none; b=szJa8qcgLX5aOOLphJTjWJzaUiSdLnOT7clwc/n5WhbpS9TAJ44LdP1KbnYABaEeuBh1zDzUeNp0w9rI9TjP61dehon6Af++258DVtcAkrZUYhPicSTNZ62/ON/Nj+hj+kI8hIn3l5W7ORY9QMyoCRjVmM+75imMYC4y9ZNgtO0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758643605; c=relaxed/simple; bh=yRZBREAJTaU8sSOhttVeLwSntMyFmzNWX36Gn0HWzTs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=UrqriRe03DpWB2yqfpGaL3fXyV3NdPrW+KecpMeJGKIxpFktJNl1jAm/D61CCG14z6Dn6w55IcLWGgQkS28EU+mF6yiNLjdkPHuY2pjMJeP5veJ2Rql5hU7Rnc/VsObk0l5832xY2hMcJFeFw1qflhrz06DZx8bJh6EmDlzQ/oQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KHTTlYNn; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KHTTlYNn" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-b5515eaefceso4360431a12.2 for ; Tue, 23 Sep 2025 09:06:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758643603; x=1759248403; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=t309JLGTHyrQ93SF2bmZLkppAVP5+5xihRdA8pDsPLU=; b=KHTTlYNnAIQNuqe1lUUQzBojbUFsRc47g6kYMQEW+QXL4DC7XEF7C+8Ym9YB+XlhWh ELPPA64yorVIMxjb8sKcdolAlOQvbnBfNUaCcS4V8zp/o5z+UxKyTx5q+mlTYHxhjfqG 0dk1fMG4Jt3wzc0HzOe8flQa8oW6KfRIkHnp884aABSFOOBve3b9S9pFAMxhLZQIrMFx g0aVGlkBht2HLaInaFL7FGhClg5sbZSJ0i/HjJqHJyIMERJuUbTryTsXRbwlZ6DjmdWc 7o8xVenyxUUMjhZaemd30XDUfrmom3Jd27g8Cu7Z8H16rFWHThnBCxWM73UezRsgod4a 7kXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758643603; x=1759248403; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=t309JLGTHyrQ93SF2bmZLkppAVP5+5xihRdA8pDsPLU=; b=DAo/kWWdup9jzt45zBTRHFb2J26JmyaXwf6SppcM2F+hJV5lcygtooWQDxHekzRd1x H5Qu1rfO34UImpuErNKmuyGcddKB85hHq7j2tI4TK2sl1p57v+WEvhnanWQ5aotA/VBB mgEkdsVaqKwdVXAic5qMcbgPkqev3s0bzQWATfMz9LHP7JvxdjodCf9Tzh7SKmDrZF1w w/hNnHNSxvNxyH1Sq4ZfASn1qMEMZjNZuUtIlFd5U5ClKGRaRNRpdiDX7EYdG6GuHjKJ Yp+OwK7vxLeAB1iX41U5lHjZ7eemw8fmlAP7PM0pTX4YukcdI8Qs/8ZNVL1Rz8/wa+g+ HXlA== X-Forwarded-Encrypted: i=1; AJvYcCVs7WVRhv11rYDiof2zzNeHpe/+BnFRd6tlVBgPT0J481F9s7A3CRZrMpZ9165sxK50Lu3G4rr0HpUO2xQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxRGIyCF9bWcbe77ZPUfcYLqPy2gu+AYfyuZGZSQnWUFyyOJ5gC hSOvFFZ/STij56GtCy8Fw9Fgh6v0j9N+o90tkCNWt4wAoKWCzW/bHQN3 X-Gm-Gg: ASbGnctt1w/PY5XCNcoPTE1SaziNNWzR58RvG8oXHZsRK91SE0mQ5pn2g7MbIllsLFJ 5oGt9OPGqVUukdMIJ5DRYAKuxmci/YCxbxeszl96otTnGTavqLmVN6UYwQxnePXjz2SQKnqICQz y2feOwSm1t3mnS3UUJ9mncBmUjesgAYyDnXVUfehlwcWA8y7OPWn7T7/tsdKuClIbh+RyNP6jpR ifjfMtqhfwIVbFPY8u3RwS+N5GsMXRnKh95vBVYAqlt4XjlAVkzX+GyChSFl1BKx5aewiNCMVhU Ew8uQ61d9poF04PoyZRn8Hn+0bxlWUdaLH4Gmcs1m47YIPDHMsFURM/WmICmkxz8J/02btTn7KD i5gBby991neTq5COgxkRdvjcnq3WepB5RE1WSOws43rglFK/BlUllENJCzPyPbmJgFItSTylees qB+5BQsiFmpV/e X-Google-Smtp-Source: AGHT+IFkkB+3aFbUYjMbYAr5CaGup6768qgAaVamVl9anvKViE9FgNGhY1HvWcu+9yfaeLkmeqZekw== X-Received: by 2002:a17:903:2b10:b0:271:49f:eaf5 with SMTP id d9443c01a7336-27cc696e9efmr39277455ad.30.1758643603090; Tue, 23 Sep 2025 09:06:43 -0700 (PDT) Received: from debian.domain.name ([223.181.105.44]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-269802df8aesm167167395ad.89.2025.09.23.09.06.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Sep 2025 09:06:42 -0700 (PDT) From: I Viswanath To: richardcochran@gmail.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev, david.hunter.linux@gmail.com, I Viswanath , syzbot+94d20db923b9f51be0df@syzkaller.appspotmail.com Subject: [RFC PATCH net v2] ptp: Add a hard upper bound on max_vclocks Date: Tue, 23 Sep 2025 21:36:22 +0530 Message-ID: <20250923160622.8096-1-viswanathiyyappan@gmail.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" syzbot reported WARNING in max_vclocks_store. This occurs when the argument max is too large for kcalloc to handle. Extend the guard to guard against values that are too large for kcalloc What would be a reasonable value for PTP_MAX_VCLOCKS_LIMIT? KMALLOC_MAX_SIZE/(sizeof(int)) is the absolute max value for which the=20 memory allocation wouldn't fail Reported-by: syzbot+94d20db923b9f51be0df@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=3D94d20db923b9f51be0df Tested-by: syzbot+94d20db923b9f51be0df@syzkaller.appspotmail.com Fixes: 73f37068d540 ("ptp: support ptp physical/virtual clocks conversion") Signed-off-by: I Viswanath --- v1: Link: https://lore.kernel.org/linux-mm/20250922170357.148588-1-viswanathiyy= appan@gmail.com/T/#u v2: - Moved the validation to max_vclocks_store drivers/ptp/ptp_private.h | 1 + drivers/ptp/ptp_sysfs.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/ptp/ptp_private.h b/drivers/ptp/ptp_private.h index b352df4cd3f9..f329263f33aa 100644 --- a/drivers/ptp/ptp_private.h +++ b/drivers/ptp/ptp_private.h @@ -22,6 +22,7 @@ #define PTP_MAX_TIMESTAMPS 128 #define PTP_BUF_TIMESTAMPS 30 #define PTP_DEFAULT_MAX_VCLOCKS 20 +#define PTP_MAX_VCLOCKS_LIMIT (KMALLOC_MAX_SIZE/(sizeof(int))) #define PTP_MAX_CHANNELS 2048 =20 enum { diff --git a/drivers/ptp/ptp_sysfs.c b/drivers/ptp/ptp_sysfs.c index 6b1b8f57cd95..200eaf500696 100644 --- a/drivers/ptp/ptp_sysfs.c +++ b/drivers/ptp/ptp_sysfs.c @@ -284,7 +284,7 @@ static ssize_t max_vclocks_store(struct device *dev, size_t size; u32 max; =20 - if (kstrtou32(buf, 0, &max) || max =3D=3D 0) + if (kstrtou32(buf, 0, &max) || max =3D=3D 0 || max > PTP_MAX_VCLOCKS_LIMI= T) return -EINVAL; =20 if (max =3D=3D ptp->max_vclocks) --=20 2.47.3