From nobody Thu Oct 2 02:05:50 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2240A19C546; Tue, 23 Sep 2025 15:17:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758640675; cv=none; b=fNQtuwPvJufeT+IQW/XVuYzUUg0h3FCf/Ks46VcCyXgfJNHG/8yZYOM9tF2472HFzc7qvL95aByU5kG9FCctnzWTqxlTePpFPw1EB0RqX3qT6+OzvAEi3PQ63IqxNd7v8v8d1luOMAEFNF4g+5PT37UGAvcXEM5nW+L0J8wunwA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758640675; c=relaxed/simple; bh=UFPxW4Y2NJQeuRCiFarspaMwrcVrI/dZULviR01E5sY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=XYmv7V/CGfeZmKR+suNmtFWFWb6Y+Z81zwYNg2Xip7e/sa79twiYRrSsylU1x0xlGlwEA94bd4YjFeE2x5Z4RNntLpFS7S0TEAClFGWbgDBqKPYeqZtVbgaPayyPIEuMBRxtgodl6Bx6FBAEz+4e+QCDENr9lrWmL3H9WL3ekIM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Af9SaynH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Af9SaynH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A20F5C4CEF5; Tue, 23 Sep 2025 15:17:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1758640673; bh=UFPxW4Y2NJQeuRCiFarspaMwrcVrI/dZULviR01E5sY=; h=From:To:Cc:Subject:Date:From; b=Af9SaynH0+wjATv7oBYHi8v/1/MPfIG+4y8SGmhZqB9Hg38JIj4qaNI+82B94rTDs zs53RRHIZi0709jrDtyWzvobdyUo15d9apHBubumn9FxNOHCcpaHig9b4cIAwD4gKq d88r1HdedaeNmVsLDFzsTYof8lkmVchwsrX53BeXurgWJzp0iMx3ewGvfCL2yw9QJA nDAx2b+dkpBkj98ynfKG0G7RF8EpcDlvUEYGKf3m6qIfHizSgJT+MMwAYa2otcfygU +XhiRzwuf6wtnup/adnjlA2iJ6XLiI9kswAMZQpKV9Wh4YlZUsKnJ4y7qex0Aqssh4 a41Va00ZHWayw== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1v14m3-000000004dQ-30pG; Tue, 23 Sep 2025 17:17:47 +0200 From: Johan Hovold To: Patrice Chotard , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org, Peter Griffin Subject: [PATCH] media: c8sectpfe: fix probe device leaks Date: Tue, 23 Sep 2025 17:16:05 +0200 Message-ID: <20250923151605.17689-1-johan@kernel.org> X-Mailer: git-send-email 2.49.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sure to drop the references taken to the I2C adapters during probe on probe failure (e.g. probe deferral) and on driver unbind. Fixes: c5f5d0f99794 ("[media] c8sectpfe: STiH407/10 Linux DVB demux support= ") Cc: stable@vger.kernel.org # 4.3 Cc: Peter Griffin Signed-off-by: Johan Hovold --- .../media/platform/st/sti/c8sectpfe/c8sectpfe-core.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c b/dri= vers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c index 89bd15a4d26a..3f94d9b4ef1e 100644 --- a/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c +++ b/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c @@ -655,6 +655,13 @@ static irqreturn_t c8sectpfe_error_irq_handler(int irq= , void *priv) return IRQ_HANDLED; } =20 +static void c8sectpfe_put_device(void *_dev) +{ + struct device *dev =3D _dev; + + put_device(dev); +} + static int c8sectpfe_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; @@ -799,6 +806,11 @@ static int c8sectpfe_probe(struct platform_device *pde= v) return -ENODEV; } =20 + ret =3D devm_add_action_or_reset(dev, c8sectpfe_put_device, + &tsin->i2c_adapter->dev); + if (ret) + return ret; + /* Acquire reset GPIO and activate it */ tsin->rst_gpio =3D devm_fwnode_gpiod_get(dev, of_fwnode_handle(child), --=20 2.49.1