From nobody Thu Oct 2 02:05:50 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B9BFDDAB; Tue, 23 Sep 2025 15:15:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758640517; cv=none; b=m9xHtRGHpGhKmjAvf6oh1aIuchBPPselCTXzxXDi8HstOEgSjG99wgn3OItwimWl3bN2reh0KaoKPYM5aHtfgjoELdCossxWCzBzVrGsYlkS03tKEHg06Z4cWwLF50L7iu+pe8SD/qZOHEmjnUDPa3HKsU1lKd5anMQmvGDsYfo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758640517; c=relaxed/simple; bh=DpWHQGigTbPm8gcTYl8TZGOSyPPjUZHRqNSp0PuxL5I=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=JIsDEbd/0dOcS7NyjyIsxiBzYpp4IkLLSwbm2YwF6peLA9aJNv+Mi5CbH1enFHIWKnumCWNFZxsj1TMXfaqF39Uc6B1MZ4LVrUaIC6gg89SfwBYDHnOmHGPkEJx3IDj1icI+HsHPXkmKzUeCKrUfjVjeHfOHLe3zlMkMdwmTKto= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JoG6UHcc; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JoG6UHcc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5AC5C4CEF5; Tue, 23 Sep 2025 15:15:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1758640516; bh=DpWHQGigTbPm8gcTYl8TZGOSyPPjUZHRqNSp0PuxL5I=; h=From:To:Cc:Subject:Date:From; b=JoG6UHccek/HejhsWYNCG4U9q5yKyuDXrXW4Kf5fYXiWWW5RoPw0Dy7BDvBYKXbc8 Bm/+jxAExEylddeRevAIff9IgNSO6mE8aLFuCXY4EUsTv/B4AsixuyP7k7pKv5t5xZ cnnOIEq1H1MWRiybjp7Iene2c3lPLKA22HAbz3PgIwGfhQNiAi4Jd7AFIF3p7xIuyv jevnnKRQ7PBhcBDhPkmrQwfd6YvLTPXzZEBewsGyoIzS8fLZgNaZoWGANT1fh87iFZ XbuaGV04X+SfqNndHPhZn+iUhvj/MXmbhhLJijjdaP/29s67470YpAxznys1sZ5r5e trhNn6nok0OTA== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1v14jW-000000004a8-2ula; Tue, 23 Sep 2025 17:15:10 +0200 From: Johan Hovold To: Philipp Zabel Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH] drm/imx/tve: fix probe device leak Date: Tue, 23 Sep 2025 17:13:46 +0200 Message-ID: <20250923151346.17512-1-johan@kernel.org> X-Mailer: git-send-email 2.49.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sure to drop the reference taken to the DDC device during probe on probe failure (e.g. probe deferral) and on driver unbind. Fixes: fcbc51e54d2a ("staging: drm/imx: Add support for Television Encoder = (TVEv2)") Cc: stable@vger.kernel.org # 3.10 Cc: Philipp Zabel Signed-off-by: Johan Hovold Reviewed-by: Frank Li --- drivers/gpu/drm/imx/ipuv3/imx-tve.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/imx/ipuv3/imx-tve.c b/drivers/gpu/drm/imx/ipuv= 3/imx-tve.c index c5629e155d25..895413d26113 100644 --- a/drivers/gpu/drm/imx/ipuv3/imx-tve.c +++ b/drivers/gpu/drm/imx/ipuv3/imx-tve.c @@ -525,6 +525,13 @@ static const struct component_ops imx_tve_ops =3D { .bind =3D imx_tve_bind, }; =20 +static void imx_tve_put_device(void *_dev) +{ + struct device *dev =3D _dev; + + put_device(dev); +} + static int imx_tve_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; @@ -546,6 +553,11 @@ static int imx_tve_probe(struct platform_device *pdev) if (ddc_node) { tve->ddc =3D of_find_i2c_adapter_by_node(ddc_node); of_node_put(ddc_node); + + ret =3D devm_add_action_or_reset(dev, imx_tve_put_device, + &tve->ddc->dev); + if (ret) + return ret; } =20 tve->mode =3D of_get_tve_mode(np); --=20 2.49.1