From nobody Thu Oct 2 02:16:37 2025 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49764257842 for ; Tue, 23 Sep 2025 14:37:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758638275; cv=none; b=uKj5uEK38mv4hrSlFcntga/okUnmjhUdhk3TsxBQoYQ/YhRocdqZupGU/YHrz07SwnUNC+RQAD6xq9IzvhW6l0Z2oB/bhBOfA8mbBlfV6p7ei4YIv+OfhV19BszW+xwt+fYoTu9gjPBsIU9f2HLoPpXLqXC+BU4AaK+HYTXSGVU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758638275; c=relaxed/simple; bh=BRys3ZutdevswohgMnBrm5EhSN86iKLozXVmHM3NKNw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=F6P6D6Ew5qIZcpfM9B0xVBWRkRUtvVDTZy5U81K7Qb0ZT/e0wyOBIbAMtM0SUxOHQ1Lg9+PfIQ25eOvbvxv3esAylOGsx/9ZHODfVXN8VvgdVrE3WFVsqTlBrXpbP9jZOhYgoStdjEmZPs6VDAgUTsSxqmLOKKVB6fAMEdL2gxo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com; spf=pass smtp.mailfrom=amarulasolutions.com; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b=gkROpMAa; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="gkROpMAa" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-b2ac72dbf48so424355366b.0 for ; Tue, 23 Sep 2025 07:37:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1758638271; x=1759243071; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JAYdvSVQgA1h0haeD8J+mH93pNUjVxDxBFzkQXHtMmU=; b=gkROpMAaLs9OSrFAFeLRr5cRX7rM+lFYiu5PoCgSovgC7NVDfIrvIv/PQQrr9PcrsK N+FHhKAcf8m9meZwYNIeAb9z9bqOmTHwY2RnTlmQwW9lnyI2vKSTkVp+Ndx67Fx6po1O q3is+TT3wpwbAS5HLfcydQGAuIBo/38Ope0NA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758638271; x=1759243071; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JAYdvSVQgA1h0haeD8J+mH93pNUjVxDxBFzkQXHtMmU=; b=UkIVT0K8WFpfHDMUpPJK1mVmlb+cT0ybDu5aFZaKv0Hy3C/ke2TXNRjl7JstOREzAO O+w1NIS1uHOurxgAW+kFuS/NvSuUMgemh0NpKl95HYm5xYw6+6dHMFTpWalSM8smFt8h ZIt6jgNn96R1YMyUVd/ekvaEjwSznJWeZOhMgHN0ozUGEP+I+JcNwalrfNjkf+C7bkfR 5mzwpj3A35JMgEPJNI+xXEAxgIjqrndPrG6kQduQrmqBn1HntI/ql0LztcJhlnJ6ecv+ h9JfT8peEbmq9WXYi/yyrFsqhgmqc7HdlSQn/pD1AyLapjapDZouj/L99AB2d3ZI68O0 VLGw== X-Gm-Message-State: AOJu0Yw+bYr78EeAmVTdHKRx5Zxkx8nrmT6eOIG+FojqsTXme28CN4Au txwTDVrh47fM6I/mdTGDHQaYvICGeOZNhmatnjucUX2jmkB+g5IUkjDelvVxgUrnLAyv+iSwmcN tDJCg X-Gm-Gg: ASbGncu/nBABDt+6ztcBvBkQ7hPXBCVr5lnuhtJ6Ly5frLtNG1qt1cYwK4Wp9l6KAs4 5qRh7sO7R3J9M6qP46pwrytP2rxDBpachY6SN8gO0IbFGU1b+e8fKK62BnW1W7Y6tpN1tiyx8X+ uDEqZMzLVm+Rdiqas1ZTQ7OP6svJu/STb2EtfoOPWXb/QBQ1I7P4kxXXpD2dCsYTbHARuySEvcy Qfh0J6uMBYJsAoUnHV0bFf+wVe4GcBkctb31mbo0sEz3SHL5JbIGU/oHno3PYVId0jkzqCBr6XV e6SDCLYzW+wVndvxd9CV8nhGDvncdmPtzr0eVf5GRsJS7raHgRQzQ77No9Quufn4Wa6Bad9BZuR OlKgsNYof/7ccIOMzd79LgiXCZcb8zvoPJFktE9OmfLBeoY4IUJeW1qd8uQ8M4HhS7cxwmlbZL0 SrPse6PC1ClEIBkiJ6L+KLNynuv0cURviq7AfREiZSa3PnodN6IHsYlJvm02E6L/Jg X-Google-Smtp-Source: AGHT+IHaqS5GNeMUhn9N2QSUvjss8/1xeAtf3qXgVO60HOyrcSqyn/pZRNK3lgknrBEjEWoU4iqXeg== X-Received: by 2002:a17:907:6d22:b0:aeb:3df1:2e75 with SMTP id a640c23a62f3a-b302af24e64mr265873166b.46.1758638271431; Tue, 23 Sep 2025 07:37:51 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-56-38-125.retail.telecomitalia.it. [82.56.38.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b2a2a5f6c7asm665204666b.28.2025.09.23.07.37.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Sep 2025 07:37:51 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Frank Li , Michael Trimarchi , Dario Binacchi , Dmitry Torokhov , Fabio Estevam , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH v6 1/6] Input: imx6ul_tsc - fix typo in register name Date: Tue, 23 Sep 2025 16:37:32 +0200 Message-ID: <20250923143746.2857292-2-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250923143746.2857292-1-dario.binacchi@amarulasolutions.com> References: <20250923143746.2857292-1-dario.binacchi@amarulasolutions.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Michael Trimarchi Replace 'SETING' with 'SETTING'. Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi Reviewed-by: Frank Li --- (no changes since v2) Changes in v2: - Add Reviewed-by tag of Frank Li. drivers/input/touchscreen/imx6ul_tsc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/imx6ul_tsc.c b/drivers/input/touchsc= reen/imx6ul_tsc.c index 6ac8fa84ed9f..c2c6e50efc54 100644 --- a/drivers/input/touchscreen/imx6ul_tsc.c +++ b/drivers/input/touchscreen/imx6ul_tsc.c @@ -55,7 +55,7 @@ #define ADC_TIMEOUT msecs_to_jiffies(100) =20 /* TSC registers */ -#define REG_TSC_BASIC_SETING 0x00 +#define REG_TSC_BASIC_SETTING 0x00 #define REG_TSC_PRE_CHARGE_TIME 0x10 #define REG_TSC_FLOW_CONTROL 0x20 #define REG_TSC_MEASURE_VALUE 0x30 @@ -192,7 +192,7 @@ static void imx6ul_tsc_set(struct imx6ul_tsc *tsc) =20 basic_setting |=3D tsc->measure_delay_time << 8; basic_setting |=3D DETECT_4_WIRE_MODE | AUTO_MEASURE; - writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETING); + writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETTING); =20 writel(DE_GLITCH_2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); =20 --=20 2.43.0 From nobody Thu Oct 2 02:16:37 2025 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB483231C91 for ; Tue, 23 Sep 2025 14:37:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758638277; cv=none; b=GiX6pP6h095rEt3VHYU+onOTo0cI4kpYESOibALrzYQWLBAZ0GGqy5DRIWon1nphx4zN1qfIa+9ra2XDYQIdAY1J+Seq5ntQlzY2DG6Cdbi8A/NSFc9KQmXeBxIQfNbMlVC7SP+IMLr5lo1/0ur6uBJvvbt/dd4M+K3D8Gpbe+M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758638277; c=relaxed/simple; bh=SWFqSXFx87fpKeGP6WN4l1K7YHQdzfNtqBr/fu+vOFA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YweTR6mj+HeJKl03mYyCG1+gGi/23op1xMb8H7i7FgA2vQmuX3A6dYs8Rt/+Z3luX445hDi8foEljlVgJkj1543mp8/meq2d9MZ7ht6FKLm4sUvB2SLjGLxs1mhmwAwRYZ0TlGiDF2s0V8vfBmQpBJuWgc3jDYt+6zg040NnjkY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com; spf=pass smtp.mailfrom=amarulasolutions.com; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b=HPBI9mTW; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="HPBI9mTW" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-b3164978f11so76377366b.3 for ; Tue, 23 Sep 2025 07:37:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1758638273; x=1759243073; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kDNPkG1BJO1AhX7f67y0O0jm17yTyZBB5A5XJjEod98=; b=HPBI9mTWObQROGKFLmfgFiWZWs26ZsZaAB65rmYvSMoGhBSBSRK2EukArOuigPo4li XOJZd2NCBEyfSI5LUcSR8aURBgKeVcb8TvP0vyr6ie1APQn/ekdCsmWadZ59m1GKpV+C qR+Gsey3UqDNRhdqoOCvKTHJtAa1E6b5vOw7w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758638273; x=1759243073; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kDNPkG1BJO1AhX7f67y0O0jm17yTyZBB5A5XJjEod98=; b=lLkhWqJZRmpYtkHSppJwHzaKWkldCf8FCZw/o6a8zrobaPEMkPm5m+/6Q+Cv9rURIF 2HcoiAo9kWYRxmrq8Lty3HLKrwBIVhS/xtKIWwiLf3USju6tNI/STfwyGkO2WxbOp5WK X5B6yrtl4bTVp3/n2QhKEpr/J9unwqeYJq5Zo9jQgMSWa35prwmEOZ9N5SwnDxU0uulN D3lX64E9/ouoVkuGf/wBzN6ghTli+CjLBJoSdGw6m0eRh1LC1KTZ4SBV/ELn/hrZFYUM kvaoaPbuANUujUZ/5EeqmAZNgQZ6vsNO9Bc/gnYL5wTPhdPi/XS7lpY2yoTXhP7e2fOk ecAg== X-Gm-Message-State: AOJu0YwBhEHnSFCGfP6sjGEl/OuLwtMjNOgTvXy0NV16enpZCYw/Q+Ke 0Hp+5r5LnO3MC6/r7lwNyEdsYnhpJDKW1pKGi3k69D5Rax8PnXCtwVn/ZqSDP4kljkXpgZDa0g3 2ViFo X-Gm-Gg: ASbGncuj6mLDHQtpaEJE2eXYrEyosfOPXs58Ko02yILpvNmVnjYNIyhTMjr+q0wFR7F a5scourqx4WSK7MdJ2O/S0cekgHlX8L0Li4KiHleB9oVms6ypv7+Wa2cXxmzan/+YveI2vAS+Lf 9vRvpt8wbI6B1bb+nIe+5OgmWYQRwmecqCOk2vI/3+/qgSq7iqJF+H5OSbetQA3NIBmJGLzKtON 6uDb4C3PoZMPm9n/o7AaPvZ3Is8brpKMKxkt0UW8Aw+oeA3eoBZ7sjUfpioUe5damTifvlfDfAs q08+hViVTacZDIa6gMCHDCJAV3sL3Dp5px4YHdx49uDLu0v7Hy5RBUz19jSYAd1EbltH8wyvpJ2 hxl3DRTfUvzzXcMyqkyXRKW+csCbTcM7suwMenXFwkvW8j9XsIE1Z2eh9mtV7PLciybfIDW8TFx PTlncSR3omeY/w0vxb9LzkO9lBAsZZWZi2bRoMWTUOTjLffwQnnZ8KqllFAfVToV8a X-Google-Smtp-Source: AGHT+IFJDM1Ud9gq7T8KPgfmRD15dasPME8CaUoxppMBegCDAFRVY/1Yr/iEsJz9G8dZnYYATmDnmA== X-Received: by 2002:a17:907:3d91:b0:b07:e212:4bf0 with SMTP id a640c23a62f3a-b3027262001mr277390666b.20.1758638272754; Tue, 23 Sep 2025 07:37:52 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-56-38-125.retail.telecomitalia.it. [82.56.38.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b2a2a5f6c7asm665204666b.28.2025.09.23.07.37.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Sep 2025 07:37:52 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Frank Li , Dario Binacchi , Dmitry Torokhov , Fabio Estevam , Michael Trimarchi , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH v6 2/6] Input: imx6ul_tsc - use BIT, FIELD_{GET,PREP} and GENMASK macros Date: Tue, 23 Sep 2025 16:37:33 +0200 Message-ID: <20250923143746.2857292-3-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250923143746.2857292-1-dario.binacchi@amarulasolutions.com> References: <20250923143746.2857292-1-dario.binacchi@amarulasolutions.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace opencoded masking and shifting, with BIT(), GENMASK(), FIELD_GET() and FIELD_PREP() macros. Signed-off-by: Dario Binacchi Reviewed-by: Frank Li --- (no changes since v2) Changes in v2: - Add Reviewed-by tag of Frank Li. - Move the patch right after the one fixing the typo according to Frank Li's suggestions. drivers/input/touchscreen/imx6ul_tsc.c | 96 +++++++++++++++----------- 1 file changed, 54 insertions(+), 42 deletions(-) diff --git a/drivers/input/touchscreen/imx6ul_tsc.c b/drivers/input/touchsc= reen/imx6ul_tsc.c index c2c6e50efc54..e2c59cc7c82c 100644 --- a/drivers/input/touchscreen/imx6ul_tsc.c +++ b/drivers/input/touchscreen/imx6ul_tsc.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include @@ -20,25 +21,23 @@ #include =20 /* ADC configuration registers field define */ -#define ADC_AIEN (0x1 << 7) +#define ADC_AIEN BIT(7) +#define ADC_ADCH_MASK GENMASK(4, 0) #define ADC_CONV_DISABLE 0x1F -#define ADC_AVGE (0x1 << 5) -#define ADC_CAL (0x1 << 7) -#define ADC_CALF 0x2 -#define ADC_12BIT_MODE (0x2 << 2) -#define ADC_CONV_MODE_MASK (0x3 << 2) +#define ADC_AVGE BIT(5) +#define ADC_CAL BIT(7) +#define ADC_CALF BIT(1) +#define ADC_CONV_MODE_MASK GENMASK(3, 2) +#define ADC_12BIT_MODE 0x2 #define ADC_IPG_CLK 0x00 -#define ADC_INPUT_CLK_MASK 0x3 -#define ADC_CLK_DIV_8 (0x03 << 5) -#define ADC_CLK_DIV_MASK (0x3 << 5) -#define ADC_SHORT_SAMPLE_MODE (0x0 << 4) -#define ADC_SAMPLE_MODE_MASK (0x1 << 4) -#define ADC_HARDWARE_TRIGGER (0x1 << 13) -#define ADC_AVGS_SHIFT 14 -#define ADC_AVGS_MASK (0x3 << 14) +#define ADC_INPUT_CLK_MASK GENMASK(1, 0) +#define ADC_CLK_DIV_8 0x03 +#define ADC_CLK_DIV_MASK GENMASK(6, 5) +#define ADC_SAMPLE_MODE BIT(4) +#define ADC_HARDWARE_TRIGGER BIT(13) +#define ADC_AVGS_MASK GENMASK(15, 14) #define SELECT_CHANNEL_4 0x04 #define SELECT_CHANNEL_1 0x01 -#define DISABLE_CONVERSION_INT (0x0 << 7) =20 /* ADC registers */ #define REG_ADC_HC0 0x00 @@ -65,19 +64,26 @@ #define REG_TSC_DEBUG_MODE 0x70 #define REG_TSC_DEBUG_MODE2 0x80 =20 +/* TSC_MEASURE_VALUE register field define */ +#define X_VALUE_MASK GENMASK(27, 16) +#define Y_VALUE_MASK GENMASK(11, 0) + /* TSC configuration registers field define */ -#define DETECT_4_WIRE_MODE (0x0 << 4) -#define AUTO_MEASURE 0x1 -#define MEASURE_SIGNAL 0x1 -#define DETECT_SIGNAL (0x1 << 4) -#define VALID_SIGNAL (0x1 << 8) -#define MEASURE_INT_EN 0x1 -#define MEASURE_SIG_EN 0x1 -#define VALID_SIG_EN (0x1 << 8) -#define DE_GLITCH_2 (0x2 << 29) -#define START_SENSE (0x1 << 12) -#define TSC_DISABLE (0x1 << 16) +#define MEASURE_DELAY_TIME_MASK GENMASK(31, 8) +#define DETECT_5_WIRE_MODE BIT(4) +#define AUTO_MEASURE BIT(0) +#define MEASURE_SIGNAL BIT(0) +#define DETECT_SIGNAL BIT(4) +#define VALID_SIGNAL BIT(8) +#define MEASURE_INT_EN BIT(0) +#define MEASURE_SIG_EN BIT(0) +#define VALID_SIG_EN BIT(8) +#define DE_GLITCH_MASK GENMASK(30, 29) +#define DE_GLITCH_2 0x02 +#define START_SENSE BIT(12) +#define TSC_DISABLE BIT(16) #define DETECT_MODE 0x2 +#define STATE_MACHINE_MASK GENMASK(22, 20) =20 struct imx6ul_tsc { struct device *dev; @@ -112,19 +118,20 @@ static int imx6ul_adc_init(struct imx6ul_tsc *tsc) =20 adc_cfg =3D readl(tsc->adc_regs + REG_ADC_CFG); adc_cfg &=3D ~(ADC_CONV_MODE_MASK | ADC_INPUT_CLK_MASK); - adc_cfg |=3D ADC_12BIT_MODE | ADC_IPG_CLK; - adc_cfg &=3D ~(ADC_CLK_DIV_MASK | ADC_SAMPLE_MODE_MASK); - adc_cfg |=3D ADC_CLK_DIV_8 | ADC_SHORT_SAMPLE_MODE; + adc_cfg |=3D FIELD_PREP(ADC_CONV_MODE_MASK, ADC_12BIT_MODE) | + FIELD_PREP(ADC_INPUT_CLK_MASK, ADC_IPG_CLK); + adc_cfg &=3D ~(ADC_CLK_DIV_MASK | ADC_SAMPLE_MODE); + adc_cfg |=3D FIELD_PREP(ADC_CLK_DIV_MASK, ADC_CLK_DIV_8); if (tsc->average_enable) { adc_cfg &=3D ~ADC_AVGS_MASK; - adc_cfg |=3D (tsc->average_select) << ADC_AVGS_SHIFT; + adc_cfg |=3D FIELD_PREP(ADC_AVGS_MASK, tsc->average_select); } adc_cfg &=3D ~ADC_HARDWARE_TRIGGER; writel(adc_cfg, tsc->adc_regs + REG_ADC_CFG); =20 /* enable calibration interrupt */ adc_hc |=3D ADC_AIEN; - adc_hc |=3D ADC_CONV_DISABLE; + adc_hc |=3D FIELD_PREP(ADC_ADCH_MASK, ADC_CONV_DISABLE); writel(adc_hc, tsc->adc_regs + REG_ADC_HC0); =20 /* start ADC calibration */ @@ -164,19 +171,21 @@ static void imx6ul_tsc_channel_config(struct imx6ul_t= sc *tsc) { u32 adc_hc0, adc_hc1, adc_hc2, adc_hc3, adc_hc4; =20 - adc_hc0 =3D DISABLE_CONVERSION_INT; + adc_hc0 =3D FIELD_PREP(ADC_AIEN, 0); writel(adc_hc0, tsc->adc_regs + REG_ADC_HC0); =20 - adc_hc1 =3D DISABLE_CONVERSION_INT | SELECT_CHANNEL_4; + adc_hc1 =3D FIELD_PREP(ADC_AIEN, 0) | + FIELD_PREP(ADC_ADCH_MASK, SELECT_CHANNEL_4); writel(adc_hc1, tsc->adc_regs + REG_ADC_HC1); =20 - adc_hc2 =3D DISABLE_CONVERSION_INT; + adc_hc2 =3D FIELD_PREP(ADC_AIEN, 0); writel(adc_hc2, tsc->adc_regs + REG_ADC_HC2); =20 - adc_hc3 =3D DISABLE_CONVERSION_INT | SELECT_CHANNEL_1; + adc_hc3 =3D FIELD_PREP(ADC_AIEN, 0) | + FIELD_PREP(ADC_ADCH_MASK, SELECT_CHANNEL_1); writel(adc_hc3, tsc->adc_regs + REG_ADC_HC3); =20 - adc_hc4 =3D DISABLE_CONVERSION_INT; + adc_hc4 =3D FIELD_PREP(ADC_AIEN, 0); writel(adc_hc4, tsc->adc_regs + REG_ADC_HC4); } =20 @@ -188,13 +197,16 @@ static void imx6ul_tsc_channel_config(struct imx6ul_t= sc *tsc) static void imx6ul_tsc_set(struct imx6ul_tsc *tsc) { u32 basic_setting =3D 0; + u32 debug_mode2; u32 start; =20 - basic_setting |=3D tsc->measure_delay_time << 8; - basic_setting |=3D DETECT_4_WIRE_MODE | AUTO_MEASURE; + basic_setting |=3D FIELD_PREP(MEASURE_DELAY_TIME_MASK, + tsc->measure_delay_time); + basic_setting |=3D AUTO_MEASURE; writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETTING); =20 - writel(DE_GLITCH_2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); + debug_mode2 =3D FIELD_PREP(DE_GLITCH_MASK, DE_GLITCH_2); + writel(debug_mode2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); =20 writel(tsc->pre_charge_time, tsc->tsc_regs + REG_TSC_PRE_CHARGE_TIME); writel(MEASURE_INT_EN, tsc->tsc_regs + REG_TSC_INT_EN); @@ -250,7 +262,7 @@ static bool tsc_wait_detect_mode(struct imx6ul_tsc *tsc) =20 usleep_range(200, 400); debug_mode2 =3D readl(tsc->tsc_regs + REG_TSC_DEBUG_MODE2); - state_machine =3D (debug_mode2 >> 20) & 0x7; + state_machine =3D FIELD_GET(STATE_MACHINE_MASK, debug_mode2); } while (state_machine !=3D DETECT_MODE); =20 usleep_range(200, 400); @@ -278,8 +290,8 @@ static irqreturn_t tsc_irq_fn(int irq, void *dev_id) =20 if (status & MEASURE_SIGNAL) { value =3D readl(tsc->tsc_regs + REG_TSC_MEASURE_VALUE); - x =3D (value >> 16) & 0x0fff; - y =3D value & 0x0fff; + x =3D FIELD_GET(X_VALUE_MASK, value); + y =3D FIELD_GET(Y_VALUE_MASK, value); =20 /* * In detect mode, we can get the xnur gpio value, --=20 2.43.0 From nobody Thu Oct 2 02:16:37 2025 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DE1D23C8D5 for ; Tue, 23 Sep 2025 14:37:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758638278; cv=none; b=bpvg0RI+bQvlfFaJUXse/GB9RQsatPOX4kiomjVTyNsTjthsnw56VmiUrJrcWLsJKQ9W825hHwZ9QP7z7YJhIUF7VvPIyBALjiEFhFAzqvgmFbLhgE+ETWclZWKECGbzS4RMm8Q6/nCNstY55qPLaeWJfdSuWhM1+mcEzWC/+4U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758638278; c=relaxed/simple; bh=3buR37RHWH5jCD3qcphvLVRnK0S9wHhdzCbVgwoftyA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=qM6jexI02xpsaRXW3DBgvRRdi+32bC7aCikgMawfOgGYHjXq8k1Df4q0xQcDzqsEJucDO/qXZAjJUpfhDHcR4SUvgt9JskXhQeyog++BzW8H0ep1W50ZPHVT3FOSdgamZ+82duY4IBwLyOKAMTE8LgKMia1x+mvRQ0ai9I9fXFM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com; spf=pass smtp.mailfrom=amarulasolutions.com; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b=HXcs6ix/; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="HXcs6ix/" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-b07c28f390eso1035746166b.2 for ; Tue, 23 Sep 2025 07:37:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1758638274; x=1759243074; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LqtR7I2mLZ8IDYwsm1m36JqptxBkiaofBPM08P2A3KM=; b=HXcs6ix/9x8Ds8D/JbXCnefYVM73sP9Ixs49M55Egz2qqgzv6u8x/dsYYoOp99zX7s ZJHyGtGIz5JHEdzT3O/2wXv9ELsfXb7Z30L44LhPmIvIGc9Ka9s4/FSw2W/p5mj9gZHG IkFUI/U1y0ncXNHM53laZ8XGZuuStqZb9HJ+s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758638274; x=1759243074; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LqtR7I2mLZ8IDYwsm1m36JqptxBkiaofBPM08P2A3KM=; b=Fa//bt+5dYph6C8xWYmhLqVJfQ9exjFO9caAUmCBQ/dsuLXfEfi3tgt6QiPqxLjKZs lea9Krre9WeQgSIWt5zelR3x1UW+FSdKbj6FyH3JmeBo71V9dyHs3EYfl1YPc68WN9pT S2kfUgSEBynDIsIpCjsGas9wpd0WIrexTkJTyMKU4sGhnB/GuYLhQKCp9ySmkpH0j1Es UkCOmixOpFEgWRn9D/AaGjHRrB4JLvjeVEtMu3OPHrgwztREYbb2Jn/SIxe4c14Iv4BW RjfgFKZUG7RnS0YmQo3hmdV5C0qM94ewmzCVyV8GvxrHi/Naxj7gwdcPDBR6NfS//tnV eCHg== X-Gm-Message-State: AOJu0Yx7fRcVBUTDdVP/wbOTb0l/0BF6zB9UK9o+F0fTNjr4DU6cgmMg 2i6b+kTVITd0GB/h+VvDxr6FihvgYoe3hxLNUSaESccCPz+Qj8uTmsZk8ZwnVCpqc+Ad7CkVbeQ 5jPuw X-Gm-Gg: ASbGncs1lNodn2ZEd3bRQ9NIFSTn9zXtwOV6U1Pxd6n8EbthX9vGiHPct1SlFKWp4Mi DHzLvrSmmFa0hI0YHxHaVPajA64qNpWbWLJlVI47+vfjyNszSP1exNwOPaWFQg4yEw07E9aGeT8 LJfRhhVe4AiO11I0JF4SQUu4UOh++cV/bg8JuXavFon8u66ua4niHktmaROAOiFxA4uUHUpbQwC q+JBAyET+m4jBKMasJkwufrWTavQcKzP0wH0dO9yIAsF5v/8C4/+cYWrSA15XzQRwOUTgMlS/UN 6tLAWgAnJfBfH1DgG6k/6v1dnzKktKC93VB1Qw8vpLoudZ5rKi7200N1xhiyBHs5T+1lr18kaMD 7h61AJj6Xy5nvyJUdG+1U7mMZl2xKTjcEagCWn7yF9nR/Y6pvMeaaY45EytRL4Snf6MLsN3DgnS YhJqjTyEDIgvINpStTOlPG6iRwrkfi5gcSJwkO78M6jQlKkQizOP8mdou817pK3FzL X-Google-Smtp-Source: AGHT+IE9RNVNWhfVu5pqINRm6zp/ZDRtUIbE5h4ZceOxySmsxSTDc7+ivdeXCI0Sc/ctW+qK1d4qXA== X-Received: by 2002:a17:907:980c:b0:b04:760d:1162 with SMTP id a640c23a62f3a-b302ac40ba3mr251539866b.47.1758638274273; Tue, 23 Sep 2025 07:37:54 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-56-38-125.retail.telecomitalia.it. [82.56.38.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b2a2a5f6c7asm665204666b.28.2025.09.23.07.37.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Sep 2025 07:37:53 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Frank Li , Dario Binacchi , Conor Dooley , Conor Dooley , Dmitry Torokhov , Javier Carrasco , Jeff LaBundy , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-input@vger.kernel.org Subject: [PATCH v6 3/6] dt-bindings: touchscreen: add debounce-delay-us property Date: Tue, 23 Sep 2025 16:37:34 +0200 Message-ID: <20250923143746.2857292-4-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250923143746.2857292-1-dario.binacchi@amarulasolutions.com> References: <20250923143746.2857292-1-dario.binacchi@amarulasolutions.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Add support for glitch delay configuration. A detected signal is valid only if it remains stable longer than the configured delay; otherwise, it is considered a glitch. This property was introduced for the i.MX6UL touchscreen controller (TSC), which provides a hardware deglitch filter with four thresholds depending on the IPG clock frequency. In this use case, the IPG clock rate is 66 MHz, resulting in thresholds of 124 =C2=B5s, 62 =C2=B5s, 31 =C2=B5s, and 15 =C2= =B5s, which requires a property with microsecond-level resolution. Signed-off-by: Dario Binacchi Acked-by: Conor Dooley --- Changes in v6: - Rename touchscreen-glitch-threshold-ns to debounce-delay-us. - Update and improve the commit message Changes in v5: - Add Acked-by tag of Conor Dooley Changes in v2: - Added in v2. .../devicetree/bindings/input/touchscreen/touchscreen.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/input/touchscreen/touchscree= n.yaml b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.ya= ml index 3e3572aa483a..7023e8c73a7b 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml +++ b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml @@ -206,6 +206,10 @@ properties: =20 unevaluatedProperties: false =20 + debounce-delay-us: + description: Minimum duration in microseconds a signal must remain sta= ble + to be considered valid. + dependencies: touchscreen-size-x: [ touchscreen-size-y ] touchscreen-size-y: [ touchscreen-size-x ] --=20 2.43.0 From nobody Thu Oct 2 02:16:37 2025 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8AF51EE7B7 for ; Tue, 23 Sep 2025 14:37:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758638280; cv=none; b=OHO8WDueolQMc2yi3MKpfQW2zz59P2KYHmDIjLAhT5MeSbBrBIuS5mIDUKJPcUSLIt25z+sCHdZvbagdZNqaINwMeRYbgKqzpkACn0mv5sb8bRx3A9AvuV2pWYWmxT/di464UQpvHx7QgjY02hU2Ix3Vj+CNpLDSfi1PQa+XEXc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758638280; c=relaxed/simple; bh=IAi/8O8/rULM+WO/P3gj9Rt/deukKZIeTgVaOnY7B+0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=U0hkIOID/aRcBAG9ELKGPfQHpQnCkkR/5UhgSHdXfRsDXToFQCUq1PDKriO5fLEMGOIRgbE0zS6vgQn5oUzXAgo8BC1ayTi4XrM36Z0i6xX0qmZkIW0vdR1kSfgsyrjr7EthEFxr2eFnFOIwNdf82rmOk+yvS0jqhwnPOMsax5o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com; spf=pass smtp.mailfrom=amarulasolutions.com; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b=O8TbWdkV; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="O8TbWdkV" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-b3164978f11so76387966b.3 for ; Tue, 23 Sep 2025 07:37:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1758638276; x=1759243076; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OUcTQ2up2eOa5np9juHes8kBZBD61IeSVgwAmot8YUQ=; b=O8TbWdkV7XA9I12YiAcfwvbRarhww+y0EKzGH1gqzy2lyynkFi5ckxJ+Bn6bUTP5MV tOtaPawLMgAnYO+31lC/XpfNwyNhJV4M04b7wa3pwUOj5IcWDiWgCfJbvi+y/3/j33QL 7jWyufzgkCEEz1pGociINjv5egzsHShdH2DzM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758638276; x=1759243076; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OUcTQ2up2eOa5np9juHes8kBZBD61IeSVgwAmot8YUQ=; b=m1sV1Dv5Ah948cL1yuOI+piavPjWcpU9DK/X84e6iiHJWyeM7P27PAqfpdFZYk0tmq njpaGp4RmgSrot7y5iE3ZQCLbxf5SEbK0Jvrb/8VX4zij3TQxwmwBwavPhDo/PMulq/7 M8Xz9t5dgYUhAL1Sv/ec3RYUoAh4Rl1eZusQNmj9a/xKLLjUmr7sdr0MGksRnPbjq2Ki I/KHnttG9AbAUMCrWv9GPlvhwMq1PZkvCdRMSND3uH1PZj5GA62d8rRu52i5I7EkcY5J q1TNX7J7eMB8fa/sZFkqsUZyo9myeISIj7R1mMsoHnHfLRZck+KzWk+7SCqDWM7ydMdQ asJw== X-Gm-Message-State: AOJu0YyZog+i7LvcUlsduCi+nIRKgFnmkccWOThDW8fLeJ4sNnKOTWa9 dQjPcolRfO5wyH9gbZdQtcTdTxX5nWCKRSoS9B/DtwWub542/HafF5j5wVHQ/YxWaSfencNSwOM JXw/V X-Gm-Gg: ASbGnctOkdj8KY+yCX8M2xl990UxFDJfOXhXgPuOi7BOqzZwTwhTAo6XRr5Cij5KOHj LT6KZfiAiaikWVwXAUinOBctUW8kyJXh3NFBMqDuRxR9a043MebGtdNjCiorKBzu/jWLyJdgMI7 QXqsx5gkeNv8nXQ872F5V28XIm6mYmn025ybfD+KeSaknJwMZiDSu2/MVpPDjAlF+z6uOdmYcwi P986dxlnRSpFze0MeRFmpPDjtl+yoIGcTpT/0xPted5J/pwklFGtiluZT/RFOcKLFuPGUSbYmN6 2/zZSQfX0OHmFB5zoOFJLrUA48J/YglaJSwvxXaWd2PlZ0s+DpcSEKTs8ExiQsPgcYnf3wg8mvt zdhbkaM1hkNDWIaUdGBFalemi0AVMJNw+LWrycZEHTpn1yRAFNk7fZPB/E6EXzxvin76oAYcHVi dCv2it3gKU4iFuWZHdM7SJzZtno0j0TDWcOqntR59gsVFenFP40MR5IgJ1YfnO0cGx X-Google-Smtp-Source: AGHT+IGDPnG7HtZZOzHzDzOnTvQCbphPIOssxaWdLijuYXdOKqbHAb1gXG6TbG+I7cy+yOigXJi2Ww== X-Received: by 2002:a17:906:f58a:b0:b2a:dc08:5914 with SMTP id a640c23a62f3a-b302ad3922bmr273199066b.45.1758638275808; Tue, 23 Sep 2025 07:37:55 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-56-38-125.retail.telecomitalia.it. [82.56.38.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b2a2a5f6c7asm665204666b.28.2025.09.23.07.37.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Sep 2025 07:37:55 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Frank Li , Dario Binacchi , Conor Dooley , Dmitry Torokhov , Fabio Estevam , Haibo Chen , Krzysztof Kozlowski , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH v6 4/6] dt-bindings: touchscreen: fsl,imx6ul-tsc: support glitch thresold Date: Tue, 23 Sep 2025 16:37:35 +0200 Message-ID: <20250923143746.2857292-5-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250923143746.2857292-1-dario.binacchi@amarulasolutions.com> References: <20250923143746.2857292-1-dario.binacchi@amarulasolutions.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Support the debounce-delay-us property. Drivers must convert this value to IPG clock cycles and map it to one of the four discrete thresholds exposed by the TSC_DEBUG_MODE2 register: 0: 8191 IPG cycles 1: 4095 IPG cycles 2: 2047 IPG cycles 3: 1023 IPG cycles Signed-off-by: Dario Binacchi --- Changes in v6: - Rename the property to debounce-delay-us. - Update the commit message Changes in v4: - Adjust property description following the suggestions of Conor Dooley and Frank Li. - Update the commit description. Changes in v3: - Remove the final part of the description that refers to implementation details. .../bindings/input/touchscreen/fsl,imx6ul-tsc.yaml | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul= -tsc.yaml b/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-= tsc.yaml index 678756ad0f92..a99280aefcbe 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.ya= ml +++ b/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.ya= ml @@ -62,6 +62,20 @@ properties: description: Number of data samples which are averaged for each read. enum: [ 1, 4, 8, 16, 32 ] =20 + debounce-delay-us: + description: | + Minimum duration in microseconds a signal must remain stable + to be considered valid. + + Drivers must convert this value to IPG clock cycles and map + it to one of the four discrete thresholds exposed by the + TSC_DEBUG_MODE2 register: + + 0: 8191 IPG cycles + 1: 4095 IPG cycles + 2: 2047 IPG cycles + 3: 1023 IPG cycles + required: - compatible - reg --=20 2.43.0 From nobody Thu Oct 2 02:16:37 2025 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07C26264F8A for ; Tue, 23 Sep 2025 14:37:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758638281; cv=none; b=mFiYZOkiYr6BmNGymyIbRacSGGqYx93L9Ly8w1p0+SEvlq4k+24MDO6/uKn6L7DNEgDlGHl+EyOkuKoYRrJL+OIFn/d55ZbtAFWWagQYL0DvJ6XiwTC1UrDeF0So6pP0Vt6Qf0Bc7Svnr/YwcDtWeSSCcR5LGvAUtu8X2UXnA6s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758638281; c=relaxed/simple; bh=vk6FwPi++rlEIdnq7B8swuH4Hfip4zJuCa4DgVBSD4Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=rBI8btimg8amQxUeC+kZ0m4aAvZUl4vEbWg+QKq0GivsQaTHleif9s/BrbRiSb9vm3tUWnYmmblVRM+RYUZgnau7N5JHcHt/CApE4zA1a3MOhmBrJuLhykKkC6SZGzN9BsnAK/6YkULHSxrEnQXs8TvfP/3HQuwvgwnifB0FjxY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com; spf=pass smtp.mailfrom=amarulasolutions.com; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b=l7yKRojH; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="l7yKRojH" Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-b2b4096539fso377036566b.1 for ; Tue, 23 Sep 2025 07:37:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1758638277; x=1759243077; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BIxVfZFoAEsIwCtiKpIw9ltXsqh5nL/d8yl3mBu/8Nc=; b=l7yKRojHmr/mJZmd8M7gn3XgCqz4rF3PUCd8ePCsDIKrimpRXTgxyU6WwH/hgGOQAu +JsHV+tdhDuMrTpAFLD0kg/t1hm021kTodDASdsG1Kl4xPSnyFvsUXWxX279Mt3JLCFJ v955NI+12GkDBNoOaXxHGAa0FSy2zPiDiMXbM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758638277; x=1759243077; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BIxVfZFoAEsIwCtiKpIw9ltXsqh5nL/d8yl3mBu/8Nc=; b=H+W7ZMfNrnDQrl2/hMU1ILgFkCr4KQ4R6k18k7moBuyGoRTqknD7+JKiFSt4QaCA4/ GV0yBo9rkcjg0QPNuqWBl4qQLzKjjbJgTxubYWIeNCk4SM5yD5N24eQ8UngbYMbS5xA9 08q4C8qB9bEdw/43YusN6fB5wo1MR8DwU0L6VbyeyqbXiAFKAiImns98eKFTcNo76liR DOM3Hov2FR+NgOhf9ufnvipvTmkaOzAC/1cL3L3t6SHEIH8dQCgqwLYGgpLH+xUHAH0O CsIzoo2hzg5XCsMJwofoze6nQKByBdGYbm4Jfw7MutJHzpnuGy/L3WfDFu8mf8j9WmZV qDcw== X-Gm-Message-State: AOJu0YyQQQrQjrcXMEERqewb921ODpr+s2WYYEasJVR79txASFQye+tZ mJL7u7MDwHZogaXJlMzCcumsXvhMl+zN9vFQXHS4OGNJ5ydw+/BKz7xMItN52qq9CZyxTAvaV7s AYSzg X-Gm-Gg: ASbGncsAb2lKn0PjPAk0jJz1LRHdtW1lMg3UWiOOC8wG0mWr0li/mNc6s2uKTm4LKux JvVFrjIriicv2sMdT7NAI5r8W96eKSoUviK+aWTi3EMRVTqao75RRx/k9G51kO9bYxIFlOzSKfz BZHJamS0jhfVnNKlslsOCRM1xQ84NAWepjNCiy1ZypTtEZf0Z0CdqWgS7DXRf2B6Z5c72Aakan6 BH7o3mLEKLMbxr6wEIHNQg5f/Mx90jr2Jwo7qla91HLzm7xAPWON96ZXgJzn3MR48+M8OrUITDX 67m5wveaynVUd0/vBs8A1mainDx+5MXMx/gYaldmlb8NgS3JIu0ARaXA/g1jv6/AHLIZToH9NTt 0ZfXoWe6MQV7Inqt8uZ13M4maobNJJ3ngTyntlPbWpcTOvfZcPXlXH0r7ieOhXCPN1IStRvdDC8 x6bD+D2EuIuX28cwChaEyBrlIblNYiwaJ8g8IxXkLorr1ZifSZ+NIqzatdtmnnfswL+kS7hVu5s y8= X-Google-Smtp-Source: AGHT+IH9SMkFkR71Kx+KKn5T55TYlat8HlxhxiB+GViGIA9Vt0hQfUrdnZ3e8AKspkcyGYH3r9r1+A== X-Received: by 2002:a17:907:3d8d:b0:afa:1d2c:bbd1 with SMTP id a640c23a62f3a-b301e5ad661mr314613866b.30.1758638277092; Tue, 23 Sep 2025 07:37:57 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-56-38-125.retail.telecomitalia.it. [82.56.38.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b2a2a5f6c7asm665204666b.28.2025.09.23.07.37.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Sep 2025 07:37:56 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Frank Li , Dario Binacchi , Conor Dooley , Fabio Estevam , Krzysztof Kozlowski , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: [PATCH v6 5/6] ARM: dts: imx6ull-engicam-microgea-bmm: set touchscreen glitch threshold Date: Tue, 23 Sep 2025 16:37:36 +0200 Message-ID: <20250923143746.2857292-6-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250923143746.2857292-1-dario.binacchi@amarulasolutions.com> References: <20250923143746.2857292-1-dario.binacchi@amarulasolutions.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable This way the detected signal is valid only if it lasts longer than 62 =C2=B5s, otherwise it is not sampled. Signed-off-by: Dario Binacchi Reviewed-by: Frank Li --- Changes in v6: - Rename touchscreen-glitch-threshold-ns to debounce-delay-us and update the value. Changes in v5: - Add Reviewed-by tag of Frank Li arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea-bmm.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea-bmm.dts b/a= rch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea-bmm.dts index 279d46c22cd7..f251a1028355 100644 --- a/arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea-bmm.dts +++ b/arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea-bmm.dts @@ -154,6 +154,7 @@ &tsc { pinctrl-0 =3D <&pinctrl_tsc>; measure-delay-time =3D <0x9ffff>; pre-charge-time =3D <0xfff>; + debounce-delay-us =3D <62>; xnur-gpios =3D <&gpio1 3 GPIO_ACTIVE_LOW>; status =3D "okay"; }; --=20 2.43.0 From nobody Thu Oct 2 02:16:37 2025 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 923772459E5 for ; Tue, 23 Sep 2025 14:38:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758638283; cv=none; b=IwY0aD5NJgLF6CbLi/5tosDAgFmHnBOzyt8dxEaQHKdVGGi8/LeirtDocuj6/s79/FCb4ODTFyXOYFIET9BF+Jg7Ge00b9xRXFjYE0ZtC8jmbRfwJZ2Z9emF7aKpVKuFwE9cHhHSpDpjJWC0+7J1/dTMQt/zm5+si5hcqp4mflo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758638283; c=relaxed/simple; bh=cVdvKFAidRA798hHdWHXhbSX4GS5WDwzy360IlmoSTE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QsbiYiYb2FdkyZmPASESVXbM38lDopRxKCwJnsDHNI2DFYmja2B2mmJc9Q2g60VJP4uumKMmF92KPnQr/1EQYcEiE5R1WtPTwZELQtMIdp+4CZqh6ubaDWocvLwMBieqPt4EODCbk6z6JYDOLMloKtlmoOSYSW7B/yzcbyHOvA4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com; spf=pass smtp.mailfrom=amarulasolutions.com; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b=at2RdAaO; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="at2RdAaO" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-b0787fa12e2so805654566b.2 for ; Tue, 23 Sep 2025 07:38:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1758638278; x=1759243078; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=s1NZM4v8G7kVFRobZkkcSJXgVxob1GWmO5LhOiwNAgs=; b=at2RdAaO493br7CLtqAGzJucOw+OYmLFLVbhked+iMNsITm0rH6mRvhs1krmmDzZJg ihD5nl+9v+tIfBSCJGKQ3fQljI5S9i9m758aqhY3bLxgGL5VVwwdOEnalvxA9wAGbXbq hwXyHtObCVlqiqhsgB0vQcMNUOl6Ah03mSq6I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758638278; x=1759243078; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s1NZM4v8G7kVFRobZkkcSJXgVxob1GWmO5LhOiwNAgs=; b=XEyuW9lakh2yWpf/H4ga3CX8CJFbUD63qLzKbaxywz8OweXN8BYSzfY/G04k2Sha3y +wM7w/8cbz4iSfT0ACWTkwaKyzs5YZL4S3AMFa78FND4q3QbCgvNhwekyfCJCoywsRPu etw4xeiMF/jIAsPXGLey8SStApDQq06vqmNWlQI+qa7JaGzIj+CmcYSW2jC2GnS+o6Gj 2J9TB+1ODBkrFWv1Woc5Ei0V1PhbiLVOuEKZ9GEsj6AxEaE/9BHhavVEypVBaRe7bSGz uB9WfYY9dJYWHsz9zEnVMk5Cq+zh985FY4O3PhmVPXQQQr6v/f6XccicNjommeWEBRM8 6v9A== X-Gm-Message-State: AOJu0Yx6AuoAOWheMr9hJ+Mgcqff6SYswB6i5lQzBHwyRACvo1MSAVAz wkbT4PD6svMqqXXeyWSp/2QR0uvhL11Hq8ufnCWCgVc/BeE8zGuDuAk5oSevBIKas5ewD94m0a3 UtsDa X-Gm-Gg: ASbGnctdka9dfB8yrvDfqAa0v85XsCnwzoA1qmG4D3B1EtHrZ8YrOc61iJVsLm8ap3X kIhLGeontqTD39oa4AXISnxwuEovM3SUs4l5QKvLI5JeIxy0VCgmyTJZhlRE9QOt5j/sPhhwmcc br1qvJvWA9TFshYEMutqJpAYrlrq27McZLpauvEHB5lFdS/3yusJ8o1DtcQDtKianymfgOJHvDE nsVyv1cRzgIyNc1Tf/5bpSP+UeW+u5BMyJVFLuBXgpqoTDOfPmFsm7rdxdZdXQV65xEcpF0VVfX kztsU2DWO0ESq6bzn4iCKrEdlS55/nnRfN0OdwG7/rG1IBGRgoO5dmVgyAGO4G0wJ2lRskeSKty ctMs9DMwm6AHhARwUAAH0bGhzQ2TSEAWKeLM+8VgcWOe1U+YV8ryaQlE0w2nVJlrnm87iCsRA75 OYvyQjF6FSDISITLj5wlKnmnlkplHnZk3LhpVXhYCzjO+CfZ839GKwaH8hRcKcJlcZ X-Google-Smtp-Source: AGHT+IEUmE6xkdZeJdkLL9TsBhYJubk/EzndUqe5eNZwoBqgNfIIOlpziTlRhmGHtKqRgY6aB2HfsQ== X-Received: by 2002:a17:907:7b91:b0:b2c:3967:eb71 with SMTP id a640c23a62f3a-b30268949e6mr298598066b.3.1758638278355; Tue, 23 Sep 2025 07:37:58 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-56-38-125.retail.telecomitalia.it. [82.56.38.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b2a2a5f6c7asm665204666b.28.2025.09.23.07.37.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Sep 2025 07:37:58 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Frank Li , Dario Binacchi , Dmitry Torokhov , Fabio Estevam , Michael Trimarchi , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH v6 6/6] Input: imx6ul_tsc - set glitch threshold by DTS property Date: Tue, 23 Sep 2025 16:37:37 +0200 Message-ID: <20250923143746.2857292-7-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250923143746.2857292-1-dario.binacchi@amarulasolutions.com> References: <20250923143746.2857292-1-dario.binacchi@amarulasolutions.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Set the glitch threshold by DTS property and keep the existing default behavior if the 'debounce-delay-us' is not present. Signed-off-by: Dario Binacchi Reviewed-by: Frank Li --- Changes in v6: - Rename the deglitch property from touchscreen-glitch-threshold-ns to debounce-delay-us. - Read the DTS debounce-delay-us instead of touchscreen-glitch-threshold-ns. - Udpate the cycles calculation. Changes in v5: - I didn=E2=80=99t remove patches: - 2/6 Input: imx6ul_tsc - use BIT, FIELD_{GET,PREP} and GENMASK macros - 1/6 Input: imx6ul_tsc - fix typo in register name even though they were accepted, to avoid generating conflicts detected by the kernel test robot. - Re-work the commit message - Add Reviewed-by tag of Frank Li Changes in v4: - Adjust property description fsl,imx6ul-tsc.yaml following the suggestions of Conor Dooley and Frank Li. Changes in v3: - Remove the final part of the description that refers to implementation details in fsl,imx6ul-tsc.yaml. Changes in v2: - Replace patch ("dt-bindings: input: touchscreen: fsl,imx6ul-tsc: add fsl,glitch-threshold") with ("dt-bindings: touchscreen: add touchscreen-glitch-threshold-ns property"), making the previous property general by moving it to touchscreen.yaml. - Rework "Input: imx6ul_tsc - set glitch threshold by DTS property" patch to match changes made to the DTS property. - Move "Input: imx6ul_tsc - use BIT, FIELD_{GET,PREP} and GENMASK macros" patch right after the patch fixing the typo. - Rework to match changes made to the DTS property. drivers/input/touchscreen/imx6ul_tsc.c | 25 +++++++++++++++++++++++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/imx6ul_tsc.c b/drivers/input/touchsc= reen/imx6ul_tsc.c index e2c59cc7c82c..85f697de2b7e 100644 --- a/drivers/input/touchscreen/imx6ul_tsc.c +++ b/drivers/input/touchscreen/imx6ul_tsc.c @@ -79,7 +79,7 @@ #define MEASURE_SIG_EN BIT(0) #define VALID_SIG_EN BIT(8) #define DE_GLITCH_MASK GENMASK(30, 29) -#define DE_GLITCH_2 0x02 +#define DE_GLITCH_DEF 0x02 #define START_SENSE BIT(12) #define TSC_DISABLE BIT(16) #define DETECT_MODE 0x2 @@ -98,6 +98,7 @@ struct imx6ul_tsc { u32 pre_charge_time; bool average_enable; u32 average_select; + u32 de_glitch; =20 struct completion completion; }; @@ -205,7 +206,7 @@ static void imx6ul_tsc_set(struct imx6ul_tsc *tsc) basic_setting |=3D AUTO_MEASURE; writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETTING); =20 - debug_mode2 =3D FIELD_PREP(DE_GLITCH_MASK, DE_GLITCH_2); + debug_mode2 =3D FIELD_PREP(DE_GLITCH_MASK, tsc->de_glitch); writel(debug_mode2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); =20 writel(tsc->pre_charge_time, tsc->tsc_regs + REG_TSC_PRE_CHARGE_TIME); @@ -391,6 +392,7 @@ static int imx6ul_tsc_probe(struct platform_device *pde= v) int tsc_irq; int adc_irq; u32 average_samples; + u32 de_glitch; =20 tsc =3D devm_kzalloc(&pdev->dev, sizeof(*tsc), GFP_KERNEL); if (!tsc) @@ -513,6 +515,25 @@ static int imx6ul_tsc_probe(struct platform_device *pd= ev) return -EINVAL; } =20 + err =3D of_property_read_u32(np, "debounce-delay-us", &de_glitch); + if (err) { + tsc->de_glitch =3D DE_GLITCH_DEF; + } else { + u64 cycles; + unsigned long rate =3D clk_get_rate(tsc->tsc_clk); + + cycles =3D DIV64_U64_ROUND_UP((u64)de_glitch * rate, USEC_PER_SEC); + + if (cycles <=3D 0x3ff) + tsc->de_glitch =3D 3; + else if (cycles <=3D 0x7ff) + tsc->de_glitch =3D 2; + else if (cycles <=3D 0xfff) + tsc->de_glitch =3D 1; + else + tsc->de_glitch =3D 0; + } + err =3D input_register_device(tsc->input); if (err) { dev_err(&pdev->dev, --=20 2.43.0