From nobody Thu Oct 2 03:27:32 2025 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B967B32142A for ; Tue, 23 Sep 2025 13:18:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.11.138.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758633521; cv=none; b=hNTKKiP25rmXBMyLj1Wc7GzRqevS8338JE4BNp6AWI0ian7WZtrvDCQirvb4C8/afGewDzTOOuPdWHT3E9vlyDjAhOR/DxhIpz6yS+3PbXK/wldPUq5qwdnowjbM46SQNa845RkqEZLkv1wUID1q+OkD8IG3PDdWYahv0S4znoM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758633521; c=relaxed/simple; bh=lnyZRDQnPA3/y4FFb13MzYtrNhLgeZLEExvORbkVxMw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jKPpzzjtF7y4Wiclo0IS4ogGoF+a3xV4pYeJ/PT+KAXs8t11SV7nEJF2/R3POvsF9FRWhnobxVXUMyyLCYtIl65x2mBt9HRoTG/9vd+lnp7Z7xJ7Gg++aP8wnGfEriX/QcxdkrdNDYl+7Muc/qf2HxO7yusGQRUgKFweY6kypfc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b=xNQsRyFu; arc=none smtp.client-ip=185.11.138.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b="xNQsRyFu" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type; bh=mxoxkr95Mj8TsVazLrSMH1VSjnOHH/Kwt2jD+ghaghY=; b=xNQsRyFu9U1hLq5ZCXoKjPBgRB RFO7k1KLpkNebwKxENHCDPY0hRWQcMA4wDPQlmDqAU9o1uo3SYhNDnswUqasRphezNZMvsGvOtn1k mZ6L47ssUZ50ww46VE7D4o9K1B0ZuiNcmepRNa7QjGTwwDtGGqA4tsUtotR+KqOmA1xg5U4rHRvGI D5XbHiTdz79U/3xOASULYs8hFggoqc0+J5vXuuWjCH/Xj1dVVk2orPIQtIqXjQGOa5GJ0HQfLVC0p gI2m17FEHzXGl3pFggPWviirtu8j/u9HiEFNBBQfF5UvrC2C812AyAbcqr26i0PDxEhUPSGpYjw8D 8pasuKRw==; Received: from i53875a1e.versanet.de ([83.135.90.30] helo=localhost.localdomain) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1v12uc-0003yq-SF; Tue, 23 Sep 2025 15:18:30 +0200 From: Heiko Stuebner To: lee@kernel.org, srini@kernel.org Cc: linux-kernel@vger.kernel.org, heiko@sntech.de Subject: [PATCH v2 1/2] nvmem: Add driver for the eeprom in qnap-mcu controllers Date: Tue, 23 Sep 2025 15:18:14 +0200 Message-ID: <20250923131815.1898332-2-heiko@sntech.de> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250923131815.1898332-1-heiko@sntech.de> References: <20250923131815.1898332-1-heiko@sntech.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The qnap-mcu also has an eeprom connected to it, that contains some specific product-information like the mac addresses for the network interfaces. Add a nvmem driver for it. Signed-off-by: Heiko Stuebner Acked-by: Srinivas Kandagatla --- drivers/nvmem/Kconfig | 9 +++ drivers/nvmem/Makefile | 2 + drivers/nvmem/qnap-mcu-eeprom.c | 110 ++++++++++++++++++++++++++++++++ 3 files changed, 121 insertions(+) create mode 100644 drivers/nvmem/qnap-mcu-eeprom.c diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig index edd811444ce5..41c814eb90b5 100644 --- a/drivers/nvmem/Kconfig +++ b/drivers/nvmem/Kconfig @@ -264,6 +264,15 @@ config NVMEM_QCOM_SEC_QFPROM This driver can also be built as a module. If so, the module wil= l be called nvmem_sec_qfprom. =20 +config NVMEM_QNAP_MCU_EEPROM + tristate "QNAP MCU EEPROM Support" + depends on MFD_QNAP_MCU + help + Say y here to enable support for accessing the EEPROM attached to + QNAP MCU devices. This EEPROM contains additional runtime device + information, like MAC addresses for ethernet devices that do not + contain their own mac storage. + config NVMEM_RAVE_SP_EEPROM tristate "Rave SP EEPROM Support" depends on RAVE_SP_CORE diff --git a/drivers/nvmem/Makefile b/drivers/nvmem/Makefile index 2021d59688db..21b3ae1c57e8 100644 --- a/drivers/nvmem/Makefile +++ b/drivers/nvmem/Makefile @@ -54,6 +54,8 @@ obj-$(CONFIG_NVMEM_QCOM_QFPROM) +=3D nvmem_qfprom.o nvmem_qfprom-y :=3D qfprom.o obj-$(CONFIG_NVMEM_QCOM_SEC_QFPROM) +=3D nvmem_sec_qfprom.o nvmem_sec_qfprom-y :=3D sec-qfprom.o +obj-$(CONFIG_NVMEM_QNAP_MCU_EEPROM) +=3D nvmem-qnap-mcu-eeprom.o +nvmem-qnap-mcu-eeprom-y :=3D qnap-mcu-eeprom.o obj-$(CONFIG_NVMEM_RAVE_SP_EEPROM) +=3D nvmem-rave-sp-eeprom.o nvmem-rave-sp-eeprom-y :=3D rave-sp-eeprom.o obj-$(CONFIG_NVMEM_RCAR_EFUSE) +=3D nvmem-rcar-efuse.o diff --git a/drivers/nvmem/qnap-mcu-eeprom.c b/drivers/nvmem/qnap-mcu-eepro= m.c new file mode 100644 index 000000000000..fea1e7b91764 --- /dev/null +++ b/drivers/nvmem/qnap-mcu-eeprom.c @@ -0,0 +1,110 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * ee1004 - driver for DDR4 SPD EEPROMs + * + * Copyright (C) 2017-2019 Jean Delvare + * + * Based on the at24 driver: + * Copyright (C) 2005-2007 David Brownell + * Copyright (C) 2008 Wolfram Sang, Pengutronix + */ + +#include +#include +#include +#include + +/* Determined by trial and error until read anomalies appeared */ +#define QNAP_MCU_EEPROM_SIZE 256 +#define QNAP_MCU_EEPROM_BLOCK_SIZE 32 + +static int qnap_mcu_eeprom_read_block(struct qnap_mcu *mcu, unsigned int o= ffset, + void *val, size_t bytes) +{ + const u8 cmd[] =3D { 0xf7, 0xa1, offset, bytes }; + u8 *reply; + int ret =3D 0; + + reply =3D kzalloc(bytes + sizeof(cmd), GFP_KERNEL); + if (!reply) + return -ENOMEM; + + ret =3D qnap_mcu_exec(mcu, cmd, sizeof(cmd), reply, bytes + sizeof(cmd)); + if (ret) + goto out; + + /* First bytes must mirror the sent command */ + if (memcmp(cmd, reply, sizeof(cmd))) { + ret =3D -EIO; + goto out; + } + + memcpy(val, reply + sizeof(cmd), bytes); + +out: + kfree(reply); + return ret; +} + +static int qnap_mcu_eeprom_read(void *priv, unsigned int offset, void *val= , size_t bytes) +{ + struct qnap_mcu *mcu =3D priv; + int pos =3D 0, ret; + u8 *buf =3D val; + + if (unlikely(!bytes)) + return 0; + + while (bytes > 0) { + size_t to_read =3D (bytes > QNAP_MCU_EEPROM_BLOCK_SIZE) ? + QNAP_MCU_EEPROM_BLOCK_SIZE : bytes; + + ret =3D qnap_mcu_eeprom_read_block(mcu, offset + pos, &buf[pos], to_read= ); + if (ret < 0) + return ret; + + pos +=3D to_read; + bytes -=3D to_read; + } + + return 0; +} + +static int qnap_mcu_eeprom_probe(struct platform_device *pdev) +{ + struct qnap_mcu *mcu =3D dev_get_drvdata(pdev->dev.parent); + struct nvmem_config nvcfg =3D {}; + struct nvmem_device *ndev; + + nvcfg.dev =3D &pdev->dev; + nvcfg.of_node =3D pdev->dev.parent->of_node; + nvcfg.name =3D dev_name(&pdev->dev); + nvcfg.id =3D NVMEM_DEVID_NONE; + nvcfg.owner =3D THIS_MODULE; + nvcfg.type =3D NVMEM_TYPE_EEPROM; + nvcfg.read_only =3D true; + nvcfg.root_only =3D false; + nvcfg.reg_read =3D qnap_mcu_eeprom_read; + nvcfg.size =3D QNAP_MCU_EEPROM_SIZE, + nvcfg.word_size =3D 1, + nvcfg.stride =3D 1, + nvcfg.priv =3D mcu, + + ndev =3D devm_nvmem_register(&pdev->dev, &nvcfg); + if (IS_ERR(ndev)) + return PTR_ERR(ndev); + + return 0; +} + +static struct platform_driver qnap_mcu_eeprom_driver =3D { + .probe =3D qnap_mcu_eeprom_probe, + .driver =3D { + .name =3D "qnap-mcu-eeprom", + }, +}; +module_platform_driver(qnap_mcu_eeprom_driver); + +MODULE_AUTHOR("Heiko Stuebner "); +MODULE_DESCRIPTION("QNAP MCU EEPROM driver"); +MODULE_LICENSE("GPL"); --=20 2.47.2 From nobody Thu Oct 2 03:27:32 2025 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B95F9318141 for ; Tue, 23 Sep 2025 13:18:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.11.138.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758633522; cv=none; b=sJQs/BvOHU1tVKRFtf6r36LJMNAsBn8y6LhyKjFYo8cJA9lYSWOIiRAAPVxXZA7X5Rcx2JdFyra1th5GxUqwuRsgnnsVf7Nqe02zJWzG4VenLaR+YjXDjcVU1MGtLQKELwBOULTsb/eu9jfTNqeAiIzmFpsYqFmM9eLlT3hLIFI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758633522; c=relaxed/simple; bh=7e8bhWKRVDtf8aKVV0+AAUPqW42KeeIQqV6I3K53e8k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BWCaJM0dRNM1/k35okvg5FKVF8CwYjHBjmNzBhvQnGS+fFxKWRe19nY65f04Dw3LUetCHqPH+o8uEZvoxQj7z7an1uyz3Lp+cU2q6xx+1tvO9gZC038VK1lcSp4Ypv4OyKB1ZOI+ZR/M6Drjz3dD2Q/p8vIDwhTZaaNTCfwNi8Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b=WIjRcKzn; arc=none smtp.client-ip=185.11.138.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b="WIjRcKzn" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type; bh=FXGH735qWrvmiJLs+utyhLgjj/KKbRgYW73cH1TeOdo=; b=WIjRcKzn43mkDOXPxw5qPAvqoO f56GnwgxgTynW+2ULQK4zMByFzOyp6Gda1ec0gavlS6jQf+Q4nEyLD1VYwprFa/cMgg/BFBygc2SH w+LVMeBeaaIss6FF8EY8cxNNM8/VxK8nKOIimdwkTFHKFueqE+ohbOtvY6K7m13pd6hW+Zkwj+fGP Ol89ObEcWmLnZQ1ymNR6f9Yh6akQUnGeT4puJMDyS7t5QXRAjURSqPk3pY+IGI8sl7Zj2E5PWxSFT amxjYxPdvM5zJl2gQOQ53e6UARuyP8jtqnQWwn1xodBo2NEsdZSJWwMv/hknYH5jP2XPoGxiu4KCD 4XQakMWg==; Received: from i53875a1e.versanet.de ([83.135.90.30] helo=localhost.localdomain) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1v12ud-0003yq-3g; Tue, 23 Sep 2025 15:18:31 +0200 From: Heiko Stuebner To: lee@kernel.org, srini@kernel.org Cc: linux-kernel@vger.kernel.org, heiko@sntech.de Subject: [PATCH v2 2/2] mfd: qnap-mcu: Hook up the eeprom sub-device Date: Tue, 23 Sep 2025 15:18:15 +0200 Message-ID: <20250923131815.1898332-3-heiko@sntech.de> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250923131815.1898332-1-heiko@sntech.de> References: <20250923131815.1898332-1-heiko@sntech.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add the qnap-mcu-eeprom platform-driver as sub-device for the MCU. Signed-off-by: Heiko Stuebner --- drivers/mfd/qnap-mcu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/qnap-mcu.c b/drivers/mfd/qnap-mcu.c index 4ec1f4cf902f..2be429a50611 100644 --- a/drivers/mfd/qnap-mcu.c +++ b/drivers/mfd/qnap-mcu.c @@ -264,6 +264,7 @@ static const struct qnap_mcu_variant qnap_ts433_mcu =3D= { }; =20 static struct mfd_cell qnap_mcu_cells[] =3D { + { .name =3D "qnap-mcu-eeprom", }, { .name =3D "qnap-mcu-input", }, { .name =3D "qnap-mcu-leds", }, { .name =3D "qnap-mcu-hwmon", } --=20 2.47.2