From nobody Thu Oct 2 03:30:45 2025 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 725F83168EC for ; Tue, 23 Sep 2025 08:14:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758615248; cv=none; b=RIp+U067O/H40ckY88LvoTnbCXThrtBlTJGY08Q5xIIv4HobSjYIyRg6aFXPCn568H1kylM4keaU5pjEqml/M1CnK+lV2iF6pJ6vnUwi4sag7iE1DSGKMq7k3y4g53JHKjYVWT/hfAbyZHPo306y40Es26W6Epk9XzpNrcdquMQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758615248; c=relaxed/simple; bh=QDvnj6fh+ODknLGOSNnz4hKVoYTOdLHSrUupxVTo67Q=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=ADYwi7iUzr7AC9I+YWre6JgXydYvk7Ctu/eT/ib5Y/iF570xRIuM7HQpLOBwOVAnhA/iIMYewjHHCuEVX/kq8nj6vue5rL1vkrfCsjTGJafqLTvR+JSvQoXZzmdWTE6UdNZ2w3MWF46zbzTNNA0PveuQ28vvXSVr+j5ui708Wrk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--gprocida.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=f9dOI/jO; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--gprocida.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="f9dOI/jO" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-46b15e6f227so8884385e9.1 for ; Tue, 23 Sep 2025 01:14:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1758615245; x=1759220045; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=nZEs14HFxkMeOy3Dt9XfbOyW5vve1fjK1o1XLyd0jzg=; b=f9dOI/jOr12vSFIfwMTtSu5YZNiIRMm0X/jQQjSrXsI9zFCqKJp8eiZ0YIL3qzmTtq /EMw71fBiVyiiT/bD0Eg5pt07mvJRkrvrIK7c3Yk3nAe9BtgWCNYHsQ+PpJkSep0j/W2 p046HTUCjS0TyJr/ZzDeuQnP26UOihkXEIOoa/tRY7Y8el5Ze7gEX0OrANzCoff2axhm SP3lxBmQ1woSd1gu8CfK9gD1rly0zIdkZnWNs4KQVNRPwMpbbAftDTn5fzxl5W/jxIKT Fqa4/wk5B7X2w/7YFrnKcO/WtHmvMtP5HUcJyGpryrrquPUUjxe6B7CBCfgn+/qEoBdS +v0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758615245; x=1759220045; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nZEs14HFxkMeOy3Dt9XfbOyW5vve1fjK1o1XLyd0jzg=; b=fWYYS3QxScA9zNabQ8Jp6bzTKnmQQ5ShSt0izb1ESUx+AYMa64Aq7CPpk3PaSo9Vld hmJ6gLCIcIO/f9t1V3Rfl5oC9shRhCKjvQakHXCT9gXo/CeSPyCxeBofS0mZn+aeno2T Nq8oA4DRW+UIf0VdfHFBUb6ycj/KAw84D9L7SMyng6a6gbt9BkocVP+SfM4B8SkRVXWS chdDs2lPN9+UvMwxjOWinoO7AhQa2vwzIDo5qd5L3OQd1BnTvXh4SWWGcEYNnl5fp2ix kU3iJ7QELLZ0WclXYaBlaQFTWJQocxH/F4wmcsqmYty78LoyyzUtnO1JBYvRnuBCGoNv Ts3w== X-Forwarded-Encrypted: i=1; AJvYcCVMV5P7t2m6fHOSkHmZ1gkA58UNYxz8x7Yuk66UFENJyxwvry5Td/ZdQdUtgs4FtFZaBDmrBEbRzJzzSF8=@vger.kernel.org X-Gm-Message-State: AOJu0YyepskxLHcglZLJcg6bEHkcdhcd93xExUyj/j3gz8aVhocjN/ls QCgtFkyAbDKMStu5rd5MT5oEPr+aotgZZw1/IFj7njdZHOw7vAa3lTre+u1KDnkJhLGK6fAvGGf nK8mpI/xijYkDIQ== X-Google-Smtp-Source: AGHT+IETXAufy5rC37WgUvjNJhJuvlT1ZCiSimNBELDAoA4V3HzxARk1cjs4fD+l+3YUgJdmCLNu1c6fXuVhZg== X-Received: from wmbdr20.prod.google.com ([2002:a05:600c:6094:b0:45c:b62f:ca0d]) (user=gprocida job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6000:2511:b0:3ee:ff1:d627 with SMTP id ffacd0b85a97d-405c6efa3f4mr1424841f8f.28.1758615244929; Tue, 23 Sep 2025 01:14:04 -0700 (PDT) Date: Tue, 23 Sep 2025 09:13:42 +0100 In-Reply-To: <20250912100015.1267643-1-gprocida@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250912100015.1267643-1-gprocida@google.com> X-Mailer: git-send-email 2.51.0.534.gc79095c0ca-goog Message-ID: <20250923081344.1657783-1-gprocida@google.com> Subject: [PATCH v2] certs: specify byte alignment From: Giuliano Procida To: dhowells@redhat.com, dwmw2@infradead.org Cc: Giuliano Procida , gregkh@linuxfoundation.org, keyrings@vger.kernel.org, linux-kernel@vger.kernel.org, will@kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The alignments specified in system_certificates.S and revocation_certificates.S are intended to be byte quantities. However, the .align macro is architecture dependent and on arm64 it behaves as .p2align. So use the .balign macro to avoid unnecessary padding due to over-alignment. Signed-off-by: Giuliano Procida Acked-by: Will Deacon --- certs/revocation_certificates.S | 4 ++-- certs/system_certificates.S | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/certs/revocation_certificates.S b/certs/revocation_certificate= s.S index f21aae8a8f0e..a53b49d49931 100644 --- a/certs/revocation_certificates.S +++ b/certs/revocation_certificates.S @@ -4,14 +4,14 @@ =20 __INITRODATA =20 - .align 8 + .balign 8 .globl revocation_certificate_list revocation_certificate_list: __revocation_list_start: .incbin "certs/x509_revocation_list" __revocation_list_end: =20 - .align 8 + .balign 8 .globl revocation_certificate_list_size revocation_certificate_list_size: #ifdef CONFIG_64BIT diff --git a/certs/system_certificates.S b/certs/system_certificates.S index 003e25d4a17e..ea6984b427c9 100644 --- a/certs/system_certificates.S +++ b/certs/system_certificates.S @@ -4,7 +4,7 @@ =20 __INITRODATA =20 - .align 8 + .balign 8 .globl system_certificate_list system_certificate_list: __cert_list_start: @@ -20,14 +20,14 @@ __cert_list_end: system_extra_cert: .fill CONFIG_SYSTEM_EXTRA_CERTIFICATE_SIZE, 1, 0 =20 - .align 4 + .balign 4 .globl system_extra_cert_used system_extra_cert_used: .int 0 =20 #endif /* CONFIG_SYSTEM_EXTRA_CERTIFICATE */ =20 - .align 8 + .balign 8 .globl system_certificate_list_size system_certificate_list_size: #ifdef CONFIG_64BIT @@ -36,7 +36,7 @@ system_certificate_list_size: .long __cert_list_end - __cert_list_start #endif =20 - .align 8 + .balign 8 .globl module_cert_size module_cert_size: #ifdef CONFIG_64BIT --=20 2.51.0.534.gc79095c0ca-goog