From nobody Thu Oct 2 05:06:29 2025 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 723BD2EAB78 for ; Mon, 22 Sep 2025 15:35:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758555312; cv=none; b=EYC04jTu9m3Mi/SNwp7+wotJYUmoJAyOopyUpSJ7SjVOPTVPhkZbZxc3WMAKJn5SonaInw6WIOk48hqEQPgTp6WVVLofsdFZA/xzEyc+BRp6oHMmSInOiRdWu3hHQcCKeYI9bZX4mcF7pVSNY9cgsMkaobJSCwbKV7URtRUrQuM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758555312; c=relaxed/simple; bh=ReQ2IHxDCCNVodf5BraXx3b8aV6M2m2LvnKjckwRCHE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=da4ObOYIF9NSfgg/plxmKMxW3eJvF5QXJOqJYlYxpXpjuk4ZWXU3RzQAVx8H3gsQIHpfauHXkijFlIRcnbR5/plSVTnBsTDuRNsAvOk4DDpjSxY4njz/z/sQYQtSVJkNMNbPn5+xZ4HJ3T26S3k1FGu7ZCIuNU2hQTRwWbRge7Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=czXoeN9Z; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="czXoeN9Z" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-77f35113821so984707b3a.0 for ; Mon, 22 Sep 2025 08:35:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758555311; x=1759160111; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=QPqBcezv8xW5mApCdOc1gSfedv0YvcKSgG7urTdN4Vw=; b=czXoeN9ZUeRabyHS5FZFdl6XhtGWYsV9IZpQjMiNC0EDZt2qSH5CH+ZHcODLpKbwPp aDhY55r3paugXZVodlmqHZ6sg/SaLlOG6dXtFWSCS0ehBdlvuBrjq15ZUQNH3L6i22/j xtuUCsUH6i424MeIXl7Y7V045MrvyqzYL38+F1fU9TueNeW97ZIPFPkG+OsgdGxX9ozl Y8/0zoZi+vdxTUwepbyTYtw78lrzykZRRR2ZTMCZM/P6a6bRXsv0di4gn0x73HEfe48J aEUe7lv0ENgdz2SEmDk6MIIq1NUcEO6Gur/nAzcuqb0ePpgF+goYraaayWRonU2Anpr0 M8XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758555311; x=1759160111; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QPqBcezv8xW5mApCdOc1gSfedv0YvcKSgG7urTdN4Vw=; b=MHroj7fPf5tMwe3Ib29x1fAZmSf2JogoFnentKd1O2uKhyooiV7qIEYMQwBbLE0Cd9 9EQ82vk4lOI0BJfM5+WqjdA/TksaMZtj9dRc7i/ohGqE1VgCvZxto7ntAVFR9iiIug1Q PkBYpObaoVKwWKfPNipegdhtRTQD/9gYEnPz7GugQL0kbrgeykw9XTztMi9C6+5b1M25 HGGvB0siKuRkyDwACUlgs/SQXT9z63v0Vt6oaei/60/LIYoZ/e4a8g+TqPKQrhHpn42i pEor7sYej5QC7othLvY4eyQy3IbAyLCpYmJR4xaDgeSuP5SkDAbReU6ctiwe62HE460D 8TkA== X-Forwarded-Encrypted: i=1; AJvYcCWwBVEhgk+vOPFGVOuN07uAUc3IKXDeeVtU9XjmRqKQw/umBGQFQ18xR+m9qiN3PlrCcbbxwZdaB12MWdA=@vger.kernel.org X-Gm-Message-State: AOJu0YyMkSBJcB1Z2ZNHAZeeqLZKQFGLLEzCc3fPwTSj8GtqpFmhGUYh v/fx4DoBgOyQQLzGIt2djgZw2hYhWoh4CDv7czk2yhskhsoVeGFQM7CN X-Gm-Gg: ASbGncvQnVCwaAu8CFsjpQPuN1a444b2wFWHWtW7x/akBDMLu/zdE4aKzSIveiF46vx vJLwh/gf9VlhwVnl2ZkQ3WcyQ3A+FsKxHmZ10a97t7Op/ap/ePQyfNkznNNIJWcxtnK8vc+3nDa 6o7SSijmWvPBOzYWiwoxWh1mrjf6mS8DgLjO+Ollzct349FoLtHoxLvxqeDysALaG34tLWC5DuA Y5doe0ejURJ3S59y//KPtdelbXhisxD4wPF54GWrLsmL6FQNKa3AvVqbjNENSvherIby/Hy5OBc bHRVAJznk2Rx/JIXZiefGB1sHWY9/ZFhU3UZukNqSIulhkAIddUhVqWksqqQmISi/s8PcR8tjim CkljmZtvv5DzZKpJhT5h0/u8/ X-Google-Smtp-Source: AGHT+IH18SVWKRivLhs8wCCIP9cmJ9yWScaF5ZUPDSrGGLbbr6gElS8sRBQwR6sHGpWLBmjI6JFxRg== X-Received: by 2002:a05:6a00:929f:b0:772:4226:13b2 with SMTP id d2e1a72fcca58-77e4ecc36cemr14924105b3a.25.1758555310572; Mon, 22 Sep 2025 08:35:10 -0700 (PDT) Received: from lgs.. ([2408:8418:1100:9530:3d9f:679e:4ddb:a104]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-77dfbab0d7dsm11069712b3a.60.2025.09.22.08.35.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Sep 2025 08:35:10 -0700 (PDT) From: Guangshuo Li To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Matthias Brugger , AngeloGioacchino Del Regno , Guangshuo Li , Charles Keepax , Alexandre Mergnat , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Cc: stable@vger.kernel.org Subject: [PATCH v2] ASoC: mediatek: mt8365: Add check for devm_kcalloc() in mt8365_afe_suspend() Date: Mon, 22 Sep 2025 23:34:48 +0800 Message-ID: <20250922153448.1824447-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_kcalloc() may fail. mt8365_afe_suspend() uses afe->reg_back_up unconditionally after allocation and writes afe->reg_back_up[i], which can lead to a NULL pointer dereference under low-memory conditions. Add a NULL check and bail out with -ENOMEM, making sure to disable the main clock via the existing error path to keep clock state balanced. Fixes: e1991d102bc2 ("ASoC: mediatek: mt8365: Add the AFE driver support") Cc: stable@vger.kernel.org --- changelog: v2: - Return -ENOMEM directly on allocation failure without goto/label. - Disable the main clock before returning to keep clock state balanced. Signed-off-by: Guangshuo Li --- sound/soc/mediatek/mt8365/mt8365-afe-pcm.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/sound/soc/mediatek/mt8365/mt8365-afe-pcm.c b/sound/soc/mediate= k/mt8365/mt8365-afe-pcm.c index 10793bbe9275..55d832e05072 100644 --- a/sound/soc/mediatek/mt8365/mt8365-afe-pcm.c +++ b/sound/soc/mediatek/mt8365/mt8365-afe-pcm.c @@ -1975,11 +1975,15 @@ static int mt8365_afe_suspend(struct device *dev) =20 mt8365_afe_enable_main_clk(afe); =20 - if (!afe->reg_back_up) + if (!afe->reg_back_up) { afe->reg_back_up =3D devm_kcalloc(dev, afe->reg_back_up_list_num, - sizeof(unsigned int), GFP_KERNEL); - + sizeof(unsigned int), GFP_KERNEL); + if (!afe->reg_back_up) { + mt8365_afe_disable_main_clk(afe); + return -ENOMEM; + } + } for (i =3D 0; i < afe->reg_back_up_list_num; i++) regmap_read(regmap, afe->reg_back_up_list[i], &afe->reg_back_up[i]); --=20 2.43.0