From nobody Thu Oct 2 06:16:50 2025 Received: from fra-out-006.esa.eu-central-1.outbound.mail-perimeter.amazon.com (fra-out-006.esa.eu-central-1.outbound.mail-perimeter.amazon.com [18.197.217.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73DC02FFFB4; Mon, 22 Sep 2025 10:32:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=18.197.217.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758537142; cv=none; b=UAVGVaOvmoPPeFsirT+2UWyAGuuLNZQ2Sj1shplWvzck9dZoVRVPP24u8VGGTeAButMmV6AXwMv3wkMQhpEyU8LypivKeWErEv+dO1nH3JcGlUcpcCEOfII0iHgMr9tfXFiqm7FNZmPugUSpE6yF1kheb1PcH3ulQ3WV72jf2GA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758537142; c=relaxed/simple; bh=bSiDtvnimcgo6Y3knq8+w917eJDspbmoX3a4FcQGX4g=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ihfFGMbbCfhq9B3wcngn8ahb18PjYh7lsMHaJYwPOHMBIRI9p6CbdYOwhTL5QlKeuib+p8jjP9FN8SeSvzPzl3Dp9o+kkNBpHS+wAwydFctUHevkhIxD5GVY+VUfcJ5Cm9KVhpN+o/UDzCoN14nnfeEhvPvvkIqPDene3+doNQ0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com; spf=pass smtp.mailfrom=amazon.com; dkim=pass (2048-bit key) header.d=amazon.com header.i=@amazon.com header.b=JSl5B5Hp; arc=none smtp.client-ip=18.197.217.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amazon.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=amazon.com header.i=@amazon.com header.b="JSl5B5Hp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazoncorp2; t=1758537140; x=1790073140; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=U4cCFbpHvYq8yWCMIbT6T5sZXi6GGX+iNVIOVWCWFxY=; b=JSl5B5HpfNV9H3maZgxTygWCyLvKiU7hfu2hd4d46Fk3CohxK4FqLyD7 T7+3AfZirjij40wgP8nkSj2YZF3DSOcyXoDeKhQ1y4T+ktblijTCIvGL7 ZvcgN3FzBU2JR2KopuLeYuexPC9FLofQnwilYJjJ7YXNy4t4hnJ5m+0uA 1Ztk+ruMTNcsA/P/HHQG3nWX+6NXT7ILY3HAY/iOL5/dd3mrthtRu86Xv QjMOTr0WWxcEEX7DWFyvkgyaTkAMqLeIF4gatc975zahbd+2jtwkGfyL6 HRiIJWBcr0Q82rmTOLVHo49mfugxyaBjwACl19tKdnfSbXz1DSjjSNoAZ g==; X-CSE-ConnectionGUID: 1jI5RAn4TXWyYVbpj1/Yxw== X-CSE-MsgGUID: 0PqpIIYnTxuQ2H3tEdmKHg== X-IronPort-AV: E=Sophos;i="6.18,284,1751241600"; d="scan'208";a="2476012" Received: from ip-10-6-6-97.eu-central-1.compute.internal (HELO smtpout.naws.eu-central-1.prod.farcaster.email.amazon.dev) ([10.6.6.97]) by internal-fra-out-006.esa.eu-central-1.outbound.mail-perimeter.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2025 10:32:10 +0000 Received: from EX19MTAEUC002.ant.amazon.com [54.240.197.228:30313] by smtpin.naws.eu-central-1.prod.farcaster.email.amazon.dev [10.0.10.226:2525] with esmtp (Farcaster) id 5aac5fa6-1fc8-4a9e-b95c-8bcb740c89e6; Mon, 22 Sep 2025 10:32:10 +0000 (UTC) X-Farcaster-Flow-ID: 5aac5fa6-1fc8-4a9e-b95c-8bcb740c89e6 Received: from EX19D018EUA004.ant.amazon.com (10.252.50.85) by EX19MTAEUC002.ant.amazon.com (10.252.51.245) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.20; Mon, 22 Sep 2025 10:32:09 +0000 Received: from dev-dsk-farbere-1a-46ecabed.eu-west-1.amazon.com (172.19.116.181) by EX19D018EUA004.ant.amazon.com (10.252.50.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.20; Mon, 22 Sep 2025 10:32:05 +0000 From: Eliav Farber To: , , , , , CC: Andy Shevchenko , Christoph Hellwig , Dan Carpenter , "Jason A. Donenfeld" , Jens Axboe , Lorenzo Stoakes , Mateusz Guzik , "Matthew Wilcox" , Pedro Falcato Subject: [PATCH 4/7 6.12.y] minmax.h: use BUILD_BUG_ON_MSG() for the lo < hi test in clamp() Date: Mon, 22 Sep 2025 10:31:20 +0000 Message-ID: <20250922103123.14538-5-farbere@amazon.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20250922103123.14538-1-farbere@amazon.com> References: <20250922103123.14538-1-farbere@amazon.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: EX19D044UWB003.ant.amazon.com (10.13.139.168) To EX19D018EUA004.ant.amazon.com (10.252.50.85) Content-Type: text/plain; charset="utf-8" From: David Laight [ Upstream commit a5743f32baec4728711bbc01d6ac2b33d4c67040 ] Use BUILD_BUG_ON_MSG(statically_true(ulo > uhi), ...) for the sanity check of the bounds in clamp(). Gives better error coverage and one less expansion of the arguments. Link: https://lkml.kernel.org/r/34d53778977747f19cce2abb287bb3e6@AcuMS.acul= ab.com Signed-off-by: David Laight Cc: Andy Shevchenko Cc: Arnd Bergmann Cc: Christoph Hellwig Cc: Dan Carpenter Cc: Jason A. Donenfeld Cc: Jens Axboe Cc: Lorenzo Stoakes Cc: Mateusz Guzik Cc: Matthew Wilcox Cc: Pedro Falcato Signed-off-by: Andrew Morton Signed-off-by: Eliav Farber --- include/linux/minmax.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/linux/minmax.h b/include/linux/minmax.h index 6f7ea669d305..91aa1b90c1bb 100644 --- a/include/linux/minmax.h +++ b/include/linux/minmax.h @@ -106,8 +106,7 @@ __auto_type uval =3D (val); \ __auto_type ulo =3D (lo); \ __auto_type uhi =3D (hi); \ - static_assert(__builtin_choose_expr(__is_constexpr((lo) > (hi)), \ - (lo) <=3D (hi), true), \ + BUILD_BUG_ON_MSG(statically_true(ulo > uhi), \ "clamp() low limit " #lo " greater than high limit " #hi); \ BUILD_BUG_ON_MSG(!__types_ok3(uval, ulo, uhi), \ "clamp("#val", "#lo", "#hi") signedness error"); \ --=20 2.47.3