From nobody Thu Oct 2 05:08:11 2025 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7D9E285065 for ; Mon, 22 Sep 2025 10:24:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758536662; cv=none; b=u3SpI9aKlx7xWsZL2DiV7uESlXzoWi4SI2yLLlOxaERl0cVN0aYdQB4JJoH2wfBeIF8qRzmOtKSNtjvldxW6FqoHhZLYLqaQixoOZ39ocUSAfPW5Z34a93YxCPTnPrImPASyCnVa5frSm5EHj7WQ+ysCOxM1hQn7q9mBLGAuvXk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758536662; c=relaxed/simple; bh=mjmDxeFm4ivEKtiuc70Fa2u1N2lU2/4nYzKVIqzkgks=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=uzyyhkJATZJXES0yMWEvk0CwmoWfQs9P7RejohU9KB63a7IRuakdJM9vj6Ykrky96wRKvDzeRYjzm+zzFnNy5nyGuvunAhm9Q9Rf+uHqOtEda8OdA3pLNSb9+7zmil8R7e/oAyfWpYN1ql7fMXA3BnzzVJaafOMQPETiPTepr2g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=ZFR+mn7/; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="ZFR+mn7/" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-3f99ac9acc4so1031339f8f.3 for ; Mon, 22 Sep 2025 03:24:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1758536658; x=1759141458; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=umA1vIerCRk0pXVnB2+DctUQUhZAfzJTqLbmXpMD4bU=; b=ZFR+mn7/nzgyeV/hTzn2zjFPUvN3/JmMwbiw3oKpg5ry+XlJ9zW8rGxq7YTNzwji4S VHcr+71LviHEBw06VA/RIQ65xqOnnQQOxAjSuS9x2U8zCMfEG6UXXOPWYQeU9FayasK5 3TNpfL1xQyNAn6qoxh6l7EubRgv74yiUr6dDd5JPcT8mK4mUOg3Ng4idYtPYjTH8Z65W XMTRNqaRSxxu203IPLPveN+iuNvt+mkZcv3hCraS7MEDp9SsY6nH97LfCyVIifIhUS8G XnL46ys4skY7lZI0gnrtaBMqE18cYnq2Ce+uFmMZDE86FD1M/pefC+geyIDL9HK6lu22 punA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758536658; x=1759141458; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=umA1vIerCRk0pXVnB2+DctUQUhZAfzJTqLbmXpMD4bU=; b=af7G9M31WWrw6ZJfUDfU8uzYBj/AwSHSYzOKaI2xB/raXGcgx4N5uzjhU911CdN0lC XXZPBt4leuSNSKckeKXWr195nv+ACZaPXK5bnTHzia+TBVereTMFr7xTS9XMHxL/luoz vSUUSuJxDhu6YW1XDJ5rpeJIIUxxSU2xwa95Box6WknxVvmYOm4QPKaxsd+CCJnnNUYk xpWDM9IiLQ4yvpK0oT93mMZlIlqdpd91TSYF9TyI/RijDC++sH0bWM1gcCSlYgg8Q6YS 1z/FE04KPc6hiC+cvTWgll1IN5qTlzPD7+il8oU6I71gmWDtoFUZxsrH+uJidYnkHopg 5znw== X-Gm-Message-State: AOJu0Ywrl+2q1PaErFmpWTc+0BYM4tfIb2L0CZbBiiL2ClLDO3ywIIW1 4eZmyKWI4Mn3UJMHgodt4WqGSGkdmY1V3udXuCHhD6925G7SgCZmyLQpypcQhhLYesIYRRqcsxl Kka1LaDE= X-Gm-Gg: ASbGnctx8fp8DELKEQk00O/c/cIY0fZGIUqYw962r6cvdt8Qr8+ogWBD2dQ/bgh2VBr pr0xqZhHkPrmtYKa3+ux2DLKUPQE+VCbVL48WrsyS/z1G8MKalWFA18vuysC8yUmUtkVLox5BK9 F6p9gmXJjFCOL3sHiKJ+WvDxgi8EYJWScdr7DMaF3AW4clgmMgtaYl9leYKvdvMOcEJFo2jWBH4 JdfO+1utmq8kpJmKx8QDprhKN5ffwqCs8oI56B18klpF3qfLauJFzIuuH6hGFqLOIHIRopl+CU6 f16yT6Z53QppJYgG9EwoGZtYv0ew3Fc1q+DUqjge/MgwqusYtdR8GI9luq+bHd0YruvHXMU+wvZ uoNBvufsIoxY8yu/smUBARwMZQ6JaRoEhDGFZYoImyFmutTA= X-Google-Smtp-Source: AGHT+IErikI5V8i9nOdU/HqH+vwUjdrAqRhxahFz4j7FUkqJbloiiigdONdwoWf0lQ4Vrh8/CHc7OQ== X-Received: by 2002:a5d:5f95:0:b0:3ea:71c4:8e1b with SMTP id ffacd0b85a97d-3ee86d6cf37mr9253783f8f.63.1758536657829; Mon, 22 Sep 2025 03:24:17 -0700 (PDT) Received: from localhost.localdomain ([2a00:6d43:105:c401:e307:1a37:2e76:ce91]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-464f4f9f41csm218613625e9.15.2025.09.22.03.24.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Sep 2025 03:24:17 -0700 (PDT) From: Marco Crivellari To: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org Cc: Tejun Heo , Lai Jiangshan , Frederic Weisbecker , Sebastian Andrzej Siewior , Marco Crivellari , Michal Hocko , Johannes Berg , Francesco Dolcini , Brian Norris , Sascha Hauer , Kalle Valo , "Dr . David Alan Gilbert" , Jeff Chen , Stefan Kerkmann Subject: [PATCH 1/1] wifi: libertas: WQ_PERCPU added to alloc_workqueue users Date: Mon, 22 Sep 2025 12:24:07 +0200 Message-ID: <20250922102407.186660-2-marco.crivellari@suse.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250922102407.186660-1-marco.crivellari@suse.com> References: <20250922102407.186660-1-marco.crivellari@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Currently if a user enqueue a work item using schedule_delayed_work() the used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to schedule_work() that is using system_wq and queue_work(), that makes use again of WORK_CPU_UNBOUND. This lack of consistentcy cannot be addressed without refactoring the API. alloc_workqueue() treats all queues as per-CPU by default, while unbound workqueues must opt-in via WQ_UNBOUND. This default is suboptimal: most workloads benefit from unbound queues, allowing the scheduler to place worker threads where they=E2=80=99re needed= and reducing noise when CPUs are isolated. This change add a new WQ_PERCPU flag, to explicitly request the use of the per-CPU behavior. Both flags coexist for one release cycle to allow callers to transition their calls. Once migration is complete, WQ_UNBOUND can be removed and unbound will become the implicit default. With the introduction of the WQ_PERCPU flag (equivalent to !WQ_UNBOUND), any alloc_workqueue() caller that doesn=E2=80=99t explicitly specify WQ_UNB= OUND must now use WQ_PERCPU. All existing users have been updated accordingly. Suggested-by: Tejun Heo Signed-off-by: Marco Crivellari --- drivers/net/wireless/marvell/libertas/if_sdio.c | 3 ++- drivers/net/wireless/marvell/libertas/if_spi.c | 3 ++- drivers/net/wireless/marvell/libertas_tf/main.c | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/marvell/libertas/if_sdio.c b/drivers/net/= wireless/marvell/libertas/if_sdio.c index 524034699972..1e29e80cad61 100644 --- a/drivers/net/wireless/marvell/libertas/if_sdio.c +++ b/drivers/net/wireless/marvell/libertas/if_sdio.c @@ -1181,7 +1181,8 @@ static int if_sdio_probe(struct sdio_func *func, spin_lock_init(&card->lock); INIT_LIST_HEAD(&card->packets); =20 - card->workqueue =3D alloc_workqueue("libertas_sdio", WQ_MEM_RECLAIM, 0); + card->workqueue =3D alloc_workqueue("libertas_sdio", + WQ_MEM_RECLAIM | WQ_PERCPU, 0); if (unlikely(!card->workqueue)) { ret =3D -ENOMEM; goto err_queue; diff --git a/drivers/net/wireless/marvell/libertas/if_spi.c b/drivers/net/w= ireless/marvell/libertas/if_spi.c index b722a6587fd3..699bae8971f8 100644 --- a/drivers/net/wireless/marvell/libertas/if_spi.c +++ b/drivers/net/wireless/marvell/libertas/if_spi.c @@ -1153,7 +1153,8 @@ static int if_spi_probe(struct spi_device *spi) priv->fw_ready =3D 1; =20 /* Initialize interrupt handling stuff. */ - card->workqueue =3D alloc_workqueue("libertas_spi", WQ_MEM_RECLAIM, 0); + card->workqueue =3D alloc_workqueue("libertas_spi", + WQ_MEM_RECLAIM | WQ_PERCPU, 0); if (!card->workqueue) { err =3D -ENOMEM; goto remove_card; diff --git a/drivers/net/wireless/marvell/libertas_tf/main.c b/drivers/net/= wireless/marvell/libertas_tf/main.c index d1067874428f..c51091e7c6c6 100644 --- a/drivers/net/wireless/marvell/libertas_tf/main.c +++ b/drivers/net/wireless/marvell/libertas_tf/main.c @@ -708,7 +708,7 @@ EXPORT_SYMBOL_GPL(lbtf_bcn_sent); static int __init lbtf_init_module(void) { lbtf_deb_enter(LBTF_DEB_MAIN); - lbtf_wq =3D alloc_workqueue("libertastf", WQ_MEM_RECLAIM, 0); + lbtf_wq =3D alloc_workqueue("libertastf", WQ_MEM_RECLAIM | WQ_PERCPU, 0); if (lbtf_wq =3D=3D NULL) { printk(KERN_ERR "libertastf: couldn't create workqueue\n"); return -ENOMEM; --=20 2.51.0