From nobody Thu Oct 2 06:21:37 2025 Received: from mail-io1-f46.google.com (mail-io1-f46.google.com [209.85.166.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B853231E88A for ; Fri, 19 Sep 2025 15:59:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758297564; cv=none; b=lN7KL6n1LyKI7cu+BPcAHsS8wxlHq3imYZF9cGOj4bJqghpfM1GideD8QB2tWO6zXwaUF6qgZcFUkZ6yFDR9MDJBcQVo5fBNIZjMpy4aPAHF1CAhcKxEEu71Y1HphAF3KYE3TCpoy3Cxy9j4VespAYKKCr7Vka4CkuSuNv1cHaE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758297564; c=relaxed/simple; bh=Tu1m4SIRyMkNsGkWApazWOavfNUwGLJRvb/wyPROHUs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rW8UJoXW1RwbKItFPBIsm9qUgKqZQMr5dfLJRRgPmpLCD3fO7VumtOmluv0ZhdFrINp8dNeiwr/Xfc5Ocq9fb+oXYkFpddLCVUMxV2FtCHCEpfxTFeURcKNVfYstADiDXMKrL5cdB6PCdS8u4slIDQg1V4i9UfzlmoEsxsUA620= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=Zu18OeFk; arc=none smtp.client-ip=209.85.166.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="Zu18OeFk" Received: by mail-io1-f46.google.com with SMTP id ca18e2360f4ac-88428b19ea9so111444939f.0 for ; Fri, 19 Sep 2025 08:59:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1758297560; x=1758902360; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vWnIy3h9DqFi8hL/FxVYtOO+Zhw2LnLXlA055wp2jTg=; b=Zu18OeFkPlFFZybfRIkOfkJjbmxFVzmmgbgxYEb5iPVVJc4AoiO9PNl7GJ9HpfkzGn j0PD+rvdyFdlZRqq5Jhatvw0UnhGKtIMfJGYUz1vq7fvcIWQisjIegKrMmmyHWwMKPB7 Cw2lZJa89MLNmC+TMHetXXFrSPp+UlFelvH7SO5l/1HyfyDzim/DB9zmca9/ZhNhQhs1 PpRvq5v0HibR6YbtUd//vrfFpchj+9t+MtGZutgsna7T0+NXJut49S5fDj+XHExs9Wn2 D3dw4RtDcknWSEHUC8Awb5zzE+R3iNp2/RrQuZuw7umK8ns1eKKkwncaKvyaFxYJ9XKX rS+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758297560; x=1758902360; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vWnIy3h9DqFi8hL/FxVYtOO+Zhw2LnLXlA055wp2jTg=; b=bDHr2xcP78av0LivpEP0co8UhoJCK6Fa+JlGf5HYf4FVRAfyRl81ctA+/6yfwb2aET 6fQXfw3kO79oGarcOy5SHp5Qox0B7NBn/HnwF7L3VwVkzJa2p5TJzAJkmDqPGi/oLnQq b4HDYpbJU6TVeT1g8yEutJ2nvR4C4U5TTyOIlGXdspK2OPhHosCG4pilzPfm0zIxPQC0 7B2bUydQXdVimoFGje+A+Gvt//5h0nQByvyC1HQ96y7tgePJYCHy0QsKkDaW05060I+9 itA/QkyPeZlhudf0ruJTeHjyrW2xMq5B0hoL7Yg+JVlQBO9vz6ScXQkZpxtvzyUY6IE2 yCNA== X-Forwarded-Encrypted: i=1; AJvYcCVjmgy8RYZHF33K2DuZgrECtlWElypJD0ugWAiKbcraEoZW+wOY0DMRFKxaBjxrltHsJxG7sdsXQ2ylsl4=@vger.kernel.org X-Gm-Message-State: AOJu0Yyes0Dnu6I3vdDmRWn+zSJ0FR7kX0LkCWzcjpqOXrFbX5/dZhNM qq9CaF+ccE/7+hY6WAyNHHJ6QNuavj9D1pnOhvWQPvLExWZhD9kkt0Giu/oVpOWowtI= X-Gm-Gg: ASbGncsMNNCxiElG7gTl4IBztmGm232sJCYxA86k797IbVJ9qYy3zASbhVb4uXThR7p T1TKzO1eewZ4/ZPbcf389lNOyKPvNAoMXdERmA5Mly+iuvshC/vvPbj6/aevyphmXcjpQYsTbau WaXpy7vuO2wKO4bWJckshPQEHPDOJwcQbL7Ym9tBXa139Al6wMjM0I/szCjnA+adG1VhZgTUb8+ 7g0qYFxCLtHEMBi5DwftQZl84V2RhsTpQq03/D0z3gNbmi/4HAd6joUrD8NEI9bbqa45eQ2ShvC TivytJTcBrAw1wOKAlIeU97AbZAv6dO+a3LjhoZMA/xAlasZ29FKG3imbGm8Cqe0YYgVPRj9apC 3y82nXBKQsvUi+lZDkV/EFG7N4KgAXWR01YBu85RiyV5NkTIUpDLcHTTamvlwbHDFLzBpc/0P9I Is X-Google-Smtp-Source: AGHT+IFmv81oG4pNPO8796J1c2ykEr19sbWYjJP5tljzK54z44hQ4+akVUbqKVCyKhhKtpuWSkCbWw== X-Received: by 2002:a05:6e02:ef4:b0:423:4ff6:aad3 with SMTP id e9e14a558f8ab-424416da9fdmr93720785ab.7.1758297559632; Fri, 19 Sep 2025 08:59:19 -0700 (PDT) Received: from zippy.localdomain (c-75-72-117-212.hsd1.mn.comcast.net. [75.72.117.212]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-53d50aa460bsm2250898173.52.2025.09.19.08.59.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Sep 2025 08:59:19 -0700 (PDT) From: Alex Elder To: broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: dlan@gentoo.org, ziyao@disroot.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, p.zabel@pengutronix.de, spacemit@lists.linux.dev, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/3] dt-bindings: spi: add SpacemiT K1 SPI support Date: Fri, 19 Sep 2025 10:59:11 -0500 Message-ID: <20250919155914.935608-2-elder@riscstar.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250919155914.935608-1-elder@riscstar.com> References: <20250919155914.935608-1-elder@riscstar.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add support for the SPI controller implemented by the SpacemiT K1 SoC. Signed-off-by: Alex Elder Acked-by: Conor Dooley Reviewed-by: Rob Herring (Arm) --- v2: - Use enum rather than const for the binding compatible string - Omit the label and status property in the binding example - No more spacemit,k1-ssp-id property - Interrupts no longer specified with interrupts-extended .../bindings/spi/spacemit,k1-spi.yaml | 87 +++++++++++++++++++ 1 file changed, 87 insertions(+) create mode 100644 Documentation/devicetree/bindings/spi/spacemit,k1-spi.y= aml diff --git a/Documentation/devicetree/bindings/spi/spacemit,k1-spi.yaml b/D= ocumentation/devicetree/bindings/spi/spacemit,k1-spi.yaml new file mode 100644 index 0000000000000..a6978212ff570 --- /dev/null +++ b/Documentation/devicetree/bindings/spi/spacemit,k1-spi.yaml @@ -0,0 +1,87 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/spi/spacemit,k1-spi.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: SpacemiT K1 SoC Serial Peripheral Interface (SPI) + +maintainers: + - Alex Elder + +description: + The SpacemiT K1 SoC implements a SPI controller that has two 32-entry + FIFOs, for transmit and receive. Details are currently available in + section 18.2.1 of the K1 User Manual, found in the SpacemiT Keystone + K1 Documentation[1]. The controller transfers words using PIO. DMA + transfers are supported as well, if both TX and RX DMA channels are + specified, + + [1] https://developer.spacemit.com/documentation + +allOf: + - $ref: /schemas/spi/spi-controller.yaml# + +properties: + compatible: + const: spacemit,k1-spi + + reg: + maxItems: 1 + + clocks: + items: + - description: Core clock + - description: Bus clock + + clock-names: + items: + - const: core + - const: bus + + resets: + maxItems: 1 + + interrupts: + maxItems: 1 + + dmas: + items: + - description: RX DMA channel + - description: TX DMA channel + + dma-names: + items: + - const: rx + - const: tx + +required: + - compatible + - reg + - clocks + - clock-names + - resets + - interrupts + +unevaluatedProperties: false + +examples: + - | + + #include + spi@d401c000 { + compatible =3D "spacemit,k1-spi"; + reg =3D <0xd401c000 0x30>; + #address-cells =3D <1>; + #size-cells =3D <0>; + clocks =3D <&syscon_apbc CLK_SSP3>, + <&syscon_apbc CLK_SSP3_BUS>; + clock-names =3D "core", + "bus"; + resets =3D <&syscon_apbc RESET_SSP3>; + interrupts =3D <55>; + dmas =3D <&pdma 20>, + <&pdma 19>; + dma-names =3D "rx", + "tx"; + }; --=20 2.48.1 From nobody Thu Oct 2 06:21:37 2025 Received: from mail-il1-f176.google.com (mail-il1-f176.google.com [209.85.166.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69D9931E8BB for ; Fri, 19 Sep 2025 15:59:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758297566; cv=none; b=kvxFhT+TOT5uYrD/9S94SAcsi7UWAp2OHFfIRqj9OSCLzo5pjaM0WMvVNjHGHOJJUeIhhi5ysVxrcL2OCmB/S3JGxLRqNJxuh4E51/YtwhX1T2PMeYgOOgkcZytK2ZTPnhvWnX6rR7qUXDCWVM6eyjUr24sjWQYTEIF8M9/w+gI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758297566; c=relaxed/simple; bh=8gvsCtXKJOeUWoyFmpXrXwlu7LQ2+kf1inWr138xtso=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eFj2CXrN8OvIpns5NzZldrRoxKzk71uVSrjglNYPB2ApU3ahRxoB1x0olyNAMhqiIpNBAsOp/FCmiWNDa2/j2XwiKbXaiGdh0Udv2axbQTpzJ/bXxxx1kFRHmPce5Rhcc3qgLRlCIoyj5MCdpZW+ohzab5DCDPSccOofplVsj+k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=Gc+K6za+; arc=none smtp.client-ip=209.85.166.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="Gc+K6za+" Received: by mail-il1-f176.google.com with SMTP id e9e14a558f8ab-4248a97504bso2254595ab.1 for ; Fri, 19 Sep 2025 08:59:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1758297561; x=1758902361; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Jtur5e1KnlFAnXMPBeet3Wb0Ewcou8V0UmCrthQqw5Y=; b=Gc+K6za+DrREYwq2coTBH68a34qugjDDPYgWv2SpKV0VeQMl3e3dp3txGKeMV+c7QQ DRBkkmqCGgz9wLIddbz0K0olZgVt6tRx3FZmZLlMqZw2aQ1pHl/WQNgyWWCsyAnPGIvX kmBDJabpr09yRnm9auofyPuWHNJx6g+9B3ua7HMZjOtxDM5xuAKhhoII2wQYV45/WqbJ yPXc8yRq4nh+dVOJqGCUaxZZRzFMXKv8IVNevkf11k8PpHD0OUIbvbycaPu1fnKQTkkh KTTBjZBu7taNRNrm1N2idI5Obc052iwdERgtdScZglFj70O31zPMDdGwiB02QxOuaQfV wiOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758297561; x=1758902361; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Jtur5e1KnlFAnXMPBeet3Wb0Ewcou8V0UmCrthQqw5Y=; b=dIfiqmssrkNs9BM/HTt1Z+4VLrGs3MoPcdlqCANFhzTr0c5DVisKs4Q4SrMOiQK1L3 1z8dsc5IT2ZMwD4n+lvNvHvc8zqVp2lDsLle1chd4zxcFeV6B1Yx68icUkGTY2AyiZCN IJ3iBXT0qJp4tNKurBjTiyO9aQmkOu1wB4cAYgp5E+KleFsmq0zspAliYgrrxsy5a8I7 xuU/QgdIQuEzOLvp01c20EwTtYXUHQWPAYWhA99hlqKtJsuGqlCVZWQpNYAs+JSyxqs1 mAJHTOMN29rljoPKIahpUy2RtciKmcjPHwpwJI7/7hT9VAaSBHqPpurnzITD86oR/9Fi 5ldQ== X-Forwarded-Encrypted: i=1; AJvYcCXBil7lBAsSmGGFDg6ZPSvRM5qhoCpEB2zqmIM8EthH8raDgbOUrurvFATRro4QHIvb8Yh7eGqL6hTtzTQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyjeyfTU6SYxOVsRLgVVJLYdRXFDVqnR5actfds2FU448ZdYKe2 FBsJxwrN8sxwpgGrebbsjia24uKoXaj2Mcia2MDv2YY1oij+JfwfpAu0voOxdMBzsdA= X-Gm-Gg: ASbGncsTpqcQVUQMH9ZuFSJie0hQvz1893ASVK0hfpyNCSQf59ZSo0bSMciSKbEeBJy 9XchQiKpR0Z0CR4drb9/c9K8G4ZerwXx4RLHZylHzM8ez2tcCLyQCTcniGrqkHOqD5P0eWKxnWz 8XqO7Tv6p0kGcPWcr92YV1AFVZBLntpVvqF+di66j11Qq6Ki4goPK5ifr0rtbMCkSN2Qg1DYp1C Xnc7V1ZRadmUD+e5427M/UKF5OdKmgNUqYHSFK0b2JIWybgCaINzM6HjEEbQ+qO2upO7Fxp0blR ZuzswlRfWC2AvXEfXkDGjtfEgaAvSsAj2qu1Dck+BjYAA1JgkH4qwP6+uDIruQR9xcT1CfbNoR4 zB5nSb0wWMae/z5iGmenGf9346AiIYSofsTUT7jfNDei82PzutZiFrKwUbygiGxO89Yk/f0X7gN V7 X-Google-Smtp-Source: AGHT+IGcEDbP0VoLz3gp39G6Csisv+jwQf1lNDL+ZuWJeCwTrimMY0C2iCsLWNAoFexmM33Z+Tfafg== X-Received: by 2002:a05:6e02:c65:b0:424:8af2:8f81 with SMTP id e9e14a558f8ab-4248af2905amr4479795ab.19.1758297561157; Fri, 19 Sep 2025 08:59:21 -0700 (PDT) Received: from zippy.localdomain (c-75-72-117-212.hsd1.mn.comcast.net. [75.72.117.212]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-53d50aa460bsm2250898173.52.2025.09.19.08.59.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Sep 2025 08:59:20 -0700 (PDT) From: Alex Elder To: broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: dlan@gentoo.org, ziyao@disroot.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, p.zabel@pengutronix.de, spacemit@lists.linux.dev, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/3] spi: spacemit: introduce SpacemiT K1 SPI controller driver Date: Fri, 19 Sep 2025 10:59:12 -0500 Message-ID: <20250919155914.935608-3-elder@riscstar.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250919155914.935608-1-elder@riscstar.com> References: <20250919155914.935608-1-elder@riscstar.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This patch introduces the driver for the SPI controller found in the SpacemiT K1 SoC. Currently the driver supports master mode only. The SPI hardware implements RX and TX FIFOs, 32 entries each, and supports both PIO and DMA mode transfers. Signed-off-by: Alex Elder --- v2: - The SPI_SPACEMIT_K1 config option is added in sorted order - The spi-spacemit-k1.o make target is now added in sorted order - Read/modify/writes of registers no longer use an additional "virt" variable to hold the address accessed - The k1_spi_driver_data->ioaddr field has been renamed base - The DMA address for the base address is maintained, rather than saving the DMA address of the data register - CONFIG_MMP_PDMA is checked at runtime, and if it is not enabled, DMA will not be used - The spi-max-frequency property value is now bounds checked - A local variable is now initialized to 0 in k1_spi_write_word() - The driver name is now "k1-spi" drivers/spi/Kconfig | 8 + drivers/spi/Makefile | 1 + drivers/spi/spi-spacemit-k1.c | 968 ++++++++++++++++++++++++++++++++++ 3 files changed, 977 insertions(+) create mode 100644 drivers/spi/spi-spacemit-k1.c diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index 82fa5eb3b8684..4f6c446c6bc16 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -1071,6 +1071,14 @@ config SPI_SG2044_NOR also supporting 3Byte address devices and 4Byte address devices. =20 +config SPI_SPACEMIT_K1 + tristate "K1 SPI Controller" + depends on ARCH_SPACEMIT || COMPILE_TEST + depends on OF + default ARCH_SPACEMIT + help + Enable support for the SpacemiT K1 SPI controller. + config SPI_SPRD tristate "Spreadtrum SPI controller" depends on ARCH_SPRD || COMPILE_TEST diff --git a/drivers/spi/Makefile b/drivers/spi/Makefile index eefaeca097456..637d750ead996 100644 --- a/drivers/spi/Makefile +++ b/drivers/spi/Makefile @@ -140,6 +140,7 @@ obj-$(CONFIG_SPI_SIFIVE) +=3D spi-sifive.o obj-$(CONFIG_SPI_SLAVE_MT27XX) +=3D spi-slave-mt27xx.o obj-$(CONFIG_SPI_SN_F_OSPI) +=3D spi-sn-f-ospi.o obj-$(CONFIG_SPI_SG2044_NOR) +=3D spi-sg2044-nor.o +obj-$(CONFIG_SPI_SPACEMIT_K1) +=3D spi-spacemit-k1.o obj-$(CONFIG_SPI_SPRD) +=3D spi-sprd.o obj-$(CONFIG_SPI_SPRD_ADI) +=3D spi-sprd-adi.o obj-$(CONFIG_SPI_STM32) +=3D spi-stm32.o diff --git a/drivers/spi/spi-spacemit-k1.c b/drivers/spi/spi-spacemit-k1.c new file mode 100644 index 0000000000000..8d564fe6c4303 --- /dev/null +++ b/drivers/spi/spi-spacemit-k1.c @@ -0,0 +1,968 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Support for SpacemiT K1 SPI controller + * + * Copyright (C) 2025 by RISCstar Solutions Corporation. All rights reser= ved. + * Copyright (c) 2023, spacemit Corporation. + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "internals.h" + +/* This is the range of transfer rates supported by the K1 SoC */ +#define K1_SPI_MIN_SPEED_HZ 6250 +#define K1_SPI_MAX_SPEED_HZ 51200000 + +/* Default speed used if spi-max-frequency is invalid or not present */ +#define K1_SPI_DEFAULT_MAX_SPEED_HZ 25600000 + +/* DMA constraints */ +#define K1_SPI_DMA_ALIGNMENT 64 +#define K1_SPI_MAX_DMA_LEN SZ_512K + +/* SpacemiT K1 SPI Registers */ + +/* SSP Top Control Register */ +#define SSP_TOP_CTRL 0x00 +#define TOP_SSE BIT(0) /* Enable port */ +#define TOP_FRF_MASK GENMASK(2, 1) /* Frame format */ +#define TOP_FRF_MOTOROLA 0 /* Motorola SPI */ +#define TOP_DSS_MASK GENMASK(9, 5) /* Data size (1-32) */ +#define TOP_SPO BIT(10) /* Polarity: 0=3Dlow */ +#define TOP_SPH BIT(11) /* Half-cycle phase */ +#define TOP_LBM BIT(12) /* Loopback mode */ +#define TOP_TRAIL BIT(13) /* Trailing bytes */ +#define TOP_HOLD_FRAME_LOW BIT(14) /* Master mode */ + +/* SSP FIFO Control Register */ +#define SSP_FIFO_CTRL 0x04 +#define FIFO_TFT_MASK GENMASK(4, 0) /* TX FIFO threshold */ +#define FIFO_RFT_MASK GENMASK(9, 5) /* RX FIFO threshold */ +#define FIFO_TSRE BIT(10) /* TX service request */ +#define FIFO_RSRE BIT(11) /* RX service request */ + +/* SSP Interrupt Enable Register */ +#define SSP_INT_EN 0x08 +#define SSP_INT_EN_TINTE BIT(1) /* RX timeout */ +#define SSP_INT_EN_RIE BIT(2) /* RX FIFO */ +#define SSP_INT_EN_TIE BIT(3) /* TX FIFO */ +#define SSP_INT_EN_RIM BIT(4) /* RX FIFO overrun */ +#define SSP_INT_EN_TIM BIT(5) /* TX FIFO underrun */ + +/* SSP Time Out Register */ +#define SSP_TIMEOUT 0x0c +#define SSP_TIMEOUT_MASK GENMASK(23, 0) + +/* SSP Data Register */ +#define SSP_DATAR 0x10 + +/* SSP Status Register */ +#define SSP_STATUS 0x14 +#define SSP_STATUS_BSY BIT(0) /* SPI/I2S busy */ +#define SSP_STATUS_TNF BIT(6) /* TX FIFO not full */ +#define SSP_STATUS_TFL GENMASK(11, 7) /* TX FIFO level */ +#define SSP_STATUS_TUR BIT(12) /* TX FIFO underrun */ +#define SSP_STATUS_RNE BIT(14) /* RX FIFO not empty */ +#define SSP_STATUS_RFL GENMASK(19, 15) /* RX FIFO level */ +#define SSP_STATUS_ROR BIT(20) /* RX FIFO overrun */ + +/* The FIFO sizes and thresholds are the same for RX and TX */ +#define K1_SPI_FIFO_SIZE 32 +#define K1_SPI_THRESH (K1_SPI_FIFO_SIZE / 2) + +struct k1_spi_io { + enum dma_data_direction dir; + struct dma_chan *chan; + void *buf; + unsigned int resid; + u32 nents; + struct sg_table sgt; +}; + +struct k1_spi_driver_data { + struct spi_controller *controller; + struct device *dev; + void __iomem *base; + unsigned long bus_rate; + struct clk *clk; + unsigned long rate; + u32 rx_timeout; + int irq; + + struct k1_spi_io rx; + struct k1_spi_io tx; + + void *dummy; /* DMA disabled if NULL */ + u32 base_addr; /* DMA address corresponding to base */ + + struct spi_message *message; /* Current message */ + + /* Current transfer information; not valid if message is null */ + unsigned int len; + u32 bytes; /* Bytes used for bits_per_word */ + bool dma_mapped; + struct completion completion; /* Transfer completion */ +}; + +static bool k1_spi_dma_enabled(struct k1_spi_driver_data *drv_data) +{ + return !!drv_data->dummy; +} + +static bool k1_spi_map_dma_buffer(struct k1_spi_io *io, size_t len, void *= dummy) +{ + struct device *dmadev =3D io->chan->device->dev; + unsigned int nents =3D DIV_ROUND_UP(len, SZ_2K); + struct sg_table *sgt =3D &io->sgt; + void *bufp =3D io->buf ? : dummy; + struct scatterlist *sg; + unsigned int i; + + if (nents !=3D sgt->nents) { + sg_free_table(sgt); + if (sg_alloc_table(sgt, nents, GFP_KERNEL)) + return false; + } + + for_each_sg(sgt->sgl, sg, nents, i) { + size_t bytes =3D min_t(size_t, len, SZ_2K); + + sg_set_buf(sg, bufp, bytes); + if (bufp !=3D dummy) + bufp +=3D bytes; + len -=3D bytes; + } + io->nents =3D dma_map_sg(dmadev, sgt->sgl, nents, io->dir); + + return !!io->nents; +} + +static void k1_spi_unmap_dma_buffer(struct k1_spi_io *io) +{ + struct sg_table *sgt =3D &io->sgt; + + dma_unmap_sg(io->chan->device->dev, sgt->sgl, io->nents, io->dir); + io->nents =3D 0; +} + +static bool k1_spi_map_dma_buffers(struct k1_spi_driver_data *drv_data) +{ + u32 dma_burst_size; + void *dummy; + + if (!k1_spi_dma_enabled(drv_data)) + return false; + + dma_burst_size =3D K1_SPI_THRESH * drv_data->bytes; + + /* Don't bother with DMA if we can't do even a single burst */ + if (drv_data->len < dma_burst_size) + return false; + + /* We won't use DMA if the transfer is too big, either */ + if (drv_data->len > K1_SPI_MAX_DMA_LEN) + return false; + + /* Map both directions for DMA; if either fails, we'll use PIO */ + dummy =3D drv_data->dummy; + if (!k1_spi_map_dma_buffer(&drv_data->rx, drv_data->len, dummy)) + return false; + + if (k1_spi_map_dma_buffer(&drv_data->tx, drv_data->len, dummy)) + return true; /* Success! */ + + /* Failed to map the RX buffer; undo the TX mapping */ + k1_spi_unmap_dma_buffer(&drv_data->rx); + + return false; +} + +static struct dma_async_tx_descriptor * +k1_spi_prepare_dma_io(struct k1_spi_driver_data *drv_data, struct k1_spi_i= o *io) +{ + u32 addr =3D drv_data->base_addr + SSP_DATAR; + struct dma_slave_config cfg =3D { }; + enum dma_transfer_direction dir; + enum dma_slave_buswidth width; + u32 dma_burst_size; + int ret; + + dir =3D io->dir =3D=3D DMA_TO_DEVICE ? DMA_MEM_TO_DEV + : DMA_DEV_TO_MEM; + + width =3D drv_data->bytes =3D=3D 1 ? DMA_SLAVE_BUSWIDTH_1_BYTE : + drv_data->bytes =3D=3D 2 ? DMA_SLAVE_BUSWIDTH_2_BYTES + : DMA_SLAVE_BUSWIDTH_4_BYTES; + + dma_burst_size =3D K1_SPI_THRESH * drv_data->bytes; + + cfg.direction =3D dir; + if (dir =3D=3D DMA_MEM_TO_DEV) { + cfg.dst_addr =3D addr; + cfg.dst_addr_width =3D width; + cfg.dst_maxburst =3D dma_burst_size; + } else { + cfg.src_addr =3D addr; + cfg.src_addr_width =3D width; + cfg.src_maxburst =3D dma_burst_size; + } + + ret =3D dmaengine_slave_config(io->chan, &cfg); + if (ret) + return NULL; + + return dmaengine_prep_slave_sg(io->chan, io->sgt.sgl, io->nents, dir, + DMA_PREP_INTERRUPT | DMA_CTRL_ACK); +} + +/* DMA completion callback */ +static void k1_spi_callback(void *data) +{ + complete(data); +} + +static bool k1_spi_transfer_start_dma(struct k1_spi_driver_data *drv_data) +{ + struct dma_async_tx_descriptor *rx_desc; + struct dma_async_tx_descriptor *tx_desc; + struct device *dev =3D drv_data->dev; + u32 val; + + rx_desc =3D k1_spi_prepare_dma_io(drv_data, &drv_data->rx); + if (!rx_desc) { + dev_err(dev, "failed to get DMA RX descriptor\n"); + return false; + } + + tx_desc =3D k1_spi_prepare_dma_io(drv_data, &drv_data->tx); + if (!tx_desc) { + dev_err(dev, "failed to get DMA TX descriptor\n"); + return false; + } + + val =3D readl(drv_data->base + SSP_TOP_CTRL); + val |=3D TOP_TRAIL; /* Trailing bytes handled by DMA */ + writel(val, drv_data->base + SSP_TOP_CTRL); + + val =3D readl(drv_data->base + SSP_FIFO_CTRL); + val |=3D FIFO_TSRE | FIFO_RSRE; + writel(val, drv_data->base + SSP_FIFO_CTRL); + + /* When RX is complete we also know TX has completed */ + rx_desc->callback =3D k1_spi_callback; + rx_desc->callback_param =3D &drv_data->completion; + + dmaengine_submit(rx_desc); + dmaengine_submit(tx_desc); + + dma_async_issue_pending(drv_data->rx.chan); + dma_async_issue_pending(drv_data->tx.chan); + + return true; +} + +static void k1_spi_transfer_end_dma(struct k1_spi_driver_data *drv_data) +{ + u32 val; + + val =3D readl(drv_data->base + SSP_FIFO_CTRL); + val &=3D ~(FIFO_TSRE | FIFO_RSRE); + writel(val, drv_data->base + SSP_FIFO_CTRL); + + val =3D readl(drv_data->base + SSP_TOP_CTRL); + val &=3D ~TOP_TRAIL; /* Trailing bytes handled by the CPU */ + writel(val, drv_data->base + SSP_TOP_CTRL); + + /* Signal an error if an RX overflow or TX underflow occurred */ + val =3D readl(drv_data->base + SSP_STATUS); + if (val & (SSP_STATUS_TUR | SSP_STATUS_ROR)) + drv_data->message->status =3D -EIO; +} + +/* Discard any data in the RX FIFO */ +static void k1_spi_flush(struct k1_spi_driver_data *drv_data) +{ + u32 val =3D readl(drv_data->base + SSP_STATUS); + u32 count; + + /* If there's nothing in the FIFO, we're done */ + if (!(val & SSP_STATUS_RNE)) + return; + + /* Read and discard what's there (one more than what the field says) */ + count =3D FIELD_GET(SSP_STATUS_RFL, val) + 1; + do + (void)readl(drv_data->base + SSP_DATAR); + while (--count); +} + +/* Set the transfer speed; the SPI core code ensures it is supported */ +static bool k1_spi_set_speed(struct k1_spi_driver_data *drv_data, u32 rate) +{ + struct clk *clk =3D drv_data->clk; + u64 nsec_per_word; + u64 bus_ticks; + + if (clk_set_rate(clk, rate)) + return false; + + drv_data->rate =3D clk_get_rate(clk); + + /* + * Compute the RX FIFO inactivity timeout value that should be used. + * The inactivity timer restarts with each word that lands in the + * FIFO. If two or more "word transfer times" pass without any new + * data in the RX FIFO, we might as well read what's there. + * + * The rate at which words land in the FIFO is determined by the + * word size and the transfer rate. One bit is transferred per + * clock tick, and 8 (or 16 or 32) bits are transferred per word. + * + * So we can get word transfer time (in nanoseconds) from: + * nsec_per_tick =3D NANOHZ_PER_HZ / drv_data->rate; + * ticks_per_word =3D BITS_PER_BYTE * drv_data->bytes; + * We do the divide last for better accuracy. + */ + nsec_per_word =3D NANOHZ_PER_HZ * BITS_PER_BYTE * drv_data->bytes; + nsec_per_word =3D DIV_ROUND_UP(nsec_per_word, drv_data->rate); + + /* + * The timeout (which we'll set to three word transfer times) is + * expressed as a number of APB clock ticks. + * bus_ticks =3D 3 * nsec * (drv_data->bus_rate / NANOHZ_PER_HZ) + */ + bus_ticks =3D 3 * nsec_per_word * drv_data->bus_rate; + drv_data->rx_timeout =3D DIV_ROUND_UP(bus_ticks, NANOHZ_PER_HZ); + + return true; +} + +static void k1_spi_read_word(struct k1_spi_driver_data *drv_data) +{ + struct k1_spi_io *rx =3D &drv_data->rx; + u32 bytes =3D drv_data->bytes; + u32 val; + + val =3D readl(drv_data->base + SSP_DATAR); + rx->resid -=3D bytes; + + if (!rx->buf) + return; /* Null reader: discard the data */ + + if (bytes =3D=3D 1) + *(u8 *)rx->buf =3D val; + else if (bytes =3D=3D 1) + *(u16 *)rx->buf =3D val; + else + *(u32 *)rx->buf =3D val; + + rx->buf +=3D bytes; +} + +static bool k1_spi_read(struct k1_spi_driver_data *drv_data) +{ + struct k1_spi_io *rx =3D &drv_data->rx; + unsigned int count; + u32 val; + + if (!rx->resid) + return true; /* Nothing more to receive */ + + /* We'll read as many slots in the FIFO as there are available */ + val =3D readl(drv_data->base + SSP_STATUS); + /* The number of open slots is one more than what's in the field */ + count =3D FIELD_GET(SSP_STATUS_RFL, val) + 1; + + /* A full FIFO count means the FIFO is either full or empty */ + + if (count =3D=3D K1_SPI_FIFO_SIZE) + if (!(val & SSP_STATUS_RNE)) + return false; /* Nothing available to read */ + + count =3D min(count, rx->resid); + while (count--) + k1_spi_read_word(drv_data); + + return !rx->resid; +} + +static void k1_spi_write_word(struct k1_spi_driver_data *drv_data) +{ + struct k1_spi_io *tx =3D &drv_data->tx; + u32 val =3D 0; + u32 bytes; + + bytes =3D drv_data->bytes; + if (tx->buf) { + if (bytes =3D=3D 1) + val =3D *(u8 *)tx->buf; + else if (bytes =3D=3D 2) + val =3D *(u16 *)tx->buf; + else if (bytes =3D=3D 4) + val =3D *(u32 *)tx->buf; + tx->buf +=3D bytes; + } /* Otherwise null writer; write 1, 2, or 4 zero bytes */ + + tx->resid -=3D bytes; + writel(val, drv_data->base + SSP_DATAR); +} + +static bool k1_spi_write(struct k1_spi_driver_data *drv_data) +{ + struct k1_spi_io *tx =3D &drv_data->tx; + unsigned int count; + u32 val; + + if (!tx->resid) + return true; /* Nothing more to send */ + + /* See how many slots in the TX FIFO are available */ + val =3D readl(drv_data->base + SSP_STATUS); + count =3D FIELD_GET(SSP_STATUS_TFL, val); + + /* A zero count means the FIFO is either full or empty */ + if (!count) { + if (val & SSP_STATUS_TNF) + count =3D K1_SPI_FIFO_SIZE; + else + return false; /* No room in the FIFO */ + } + + /* + * Limit how much we try to send at a time, to reduce the + * chance the other side can overrun our RX FIFO. + */ + count =3D min3(count, K1_SPI_THRESH, tx->resid); + while (count--) + k1_spi_write_word(drv_data); + + return !tx->resid; +} + +static bool k1_spi_transfer_start(struct k1_spi_driver_data *drv_data, + struct spi_transfer *transfer) +{ + u32 val; + + /* Bits per word can change on a per-transfer basis */ + drv_data->bytes =3D spi_bpw_to_bytes(transfer->bits_per_word); + + /* Each transfer can also specify a different rate */ + if (!k1_spi_set_speed(drv_data, transfer->speed_hz)) { + dev_err(drv_data->dev, "failed to set transfer speed\n"); + return false; + } + + k1_spi_flush(drv_data); + + /* Record the current transfer information */ + drv_data->rx.buf =3D transfer->rx_buf; + drv_data->rx.resid =3D transfer->len; + drv_data->tx.buf =3D (void *)transfer->tx_buf; + drv_data->tx.resid =3D transfer->len; + drv_data->len =3D transfer->len; + + drv_data->dma_mapped =3D k1_spi_map_dma_buffers(drv_data); + + /* Set the RX timeout period (required for both DMA and PIO) */ + val =3D FIELD_PREP(SSP_TIMEOUT_MASK, drv_data->rx_timeout); + writel(val, drv_data->base + SSP_TIMEOUT); + + /* Clear any existing interrupt conditions */ + val =3D readl(drv_data->base + SSP_STATUS); + writel(val, drv_data->base + SSP_STATUS); + + /* Set the data size and enable the hardware */ + val =3D readl(drv_data->base + SSP_TOP_CTRL); + val |=3D FIELD_PREP(TOP_DSS_MASK, transfer->bits_per_word - 1); + val |=3D TOP_SSE; + writel(val, drv_data->base + SSP_TOP_CTRL); + + /* DMA transfers are programmmed, then initiated */ + if (drv_data->dma_mapped) + return k1_spi_transfer_start_dma(drv_data); + + /* + * For PIO transfers, interrupts will cause words to get + * transferred. The interrupts will get disabled as the + * transfer completes. We'll write what we can to get + * things started. + */ + (void)k1_spi_write(drv_data); + + val =3D SSP_INT_EN_RIM | SSP_INT_EN_TIM; + val |=3D SSP_INT_EN_TINTE | SSP_INT_EN_RIE | SSP_INT_EN_TIE; + writel(val, drv_data->base + SSP_INT_EN); + + return true; +} + +static void k1_spi_transfer_end(struct k1_spi_driver_data *drv_data, + struct spi_transfer *transfer) +{ + struct spi_message *message =3D drv_data->message; + u32 val; + + if (drv_data->dma_mapped) + k1_spi_transfer_end_dma(drv_data); + + val =3D readl(drv_data->base + SSP_TOP_CTRL); + val &=3D ~TOP_SSE; + val &=3D ~TOP_DSS_MASK; + writel(val, drv_data->base + SSP_TOP_CTRL); + + writel(0, drv_data->base + SSP_TIMEOUT); + + if (drv_data->dma_mapped) { + k1_spi_unmap_dma_buffer(&drv_data->tx); + k1_spi_unmap_dma_buffer(&drv_data->rx); + } + + spi_transfer_delay_exec(transfer); + + if (!message->status) + message->actual_length +=3D drv_data->len; +} + +static void k1_spi_transfer_wait(struct k1_spi_driver_data *drv_data) +{ + struct completion *completion =3D &drv_data->completion; + struct spi_message *message =3D drv_data->message; + unsigned long timeout; + int ret; + + /* Length in bits to be transferred */ + timeout =3D BITS_PER_BYTE * drv_data->bytes * drv_data->len; + /* Time (usec) to transfer that many bits at the current bit rate */ + timeout =3D DIV_ROUND_UP(timeout * MICROHZ_PER_HZ, drv_data->rate); + /* Convert that (+ 25%) to jiffies for the wait call */ + timeout =3D usecs_to_jiffies(5 * timeout / 4); + + ret =3D wait_for_completion_interruptible_timeout(completion, timeout); + if (ret > 0) + return; + + message->status =3D -EIO; + if (ret && drv_data->dma_mapped) { + dmaengine_terminate_sync(drv_data->tx.chan); + dmaengine_terminate_sync(drv_data->rx.chan); + } +} + +static int k1_spi_transfer_one_message(struct spi_controller *host, + struct spi_message *message) +{ + struct k1_spi_driver_data *drv_data =3D spi_controller_get_devdata(host); + struct completion *completion =3D &drv_data->completion; + struct spi_transfer *transfer; + u32 val; + + drv_data->message =3D message; + + /* Message status starts out successful; set to -EIO on error */ + message->status =3D 0; + + /* Hold frame low to avoid losing transferred data */ + val =3D readl(drv_data->base + SSP_TOP_CTRL); + val |=3D TOP_HOLD_FRAME_LOW; + writel(val, drv_data->base + SSP_TOP_CTRL); + + list_for_each_entry(transfer, &message->transfers, transfer_list) { + reinit_completion(completion); + + /* Issue the next transfer */ + if (!k1_spi_transfer_start(drv_data, transfer)) { + message->status =3D -EIO; + break; + } + + k1_spi_transfer_wait(drv_data); + + k1_spi_transfer_end(drv_data, transfer); + + /* If an error has occurred, we're done */ + if (message->status) + break; + } + + drv_data->message =3D NULL; + + spi_finalize_current_message(drv_data->controller); + + val =3D readl(drv_data->base + SSP_TOP_CTRL); + val &=3D ~TOP_HOLD_FRAME_LOW; + writel(val, drv_data->base + SSP_TOP_CTRL); + + return 0; +} + +/* + * The client can call the setup function multiple times, and each call + * can specify a different SPI mode (and transfer speed). Each transfer + * can specify its own speed though, and the core code ensures each + * transfer's speed is set to something nonzero and supported by both + * the controller and the device). We just set the speed for each + * transfer. + */ +static int k1_spi_setup(struct spi_device *spi) +{ + struct k1_spi_driver_data *drv_data; + u32 val; + + drv_data =3D spi_controller_get_devdata(spi->controller); + + /* + * Configure the message format for this device. We only + * support Motorola SPI format in master mode. + */ + val =3D FIELD_PREP(TOP_FRF_MASK, TOP_FRF_MOTOROLA); + val |=3D TOP_HOLD_FRAME_LOW; /* Master mode */ + + /* Translate the mode into the value used to program the hardware. */ + if (spi->mode & SPI_CPHA) + val |=3D TOP_SPH; /* 1/2 cycle */ + if (spi->mode & SPI_CPOL) + val |=3D TOP_SPO; /* active low */ + if (spi->mode & SPI_LOOP) + val |=3D TOP_LBM; /* enable loopback */ + writel(val, drv_data->base + SSP_TOP_CTRL); + + return 0; +} + +static void k1_spi_cleanup(struct spi_device *spi) +{ + struct k1_spi_driver_data *drv_data; + + drv_data =3D spi_controller_get_devdata(spi->controller); + + writel(0, drv_data->base + SSP_TOP_CTRL); +} + +static int k1_spi_dma_setup_io(struct k1_spi_driver_data *drv_data, bool r= x) +{ + const char *name =3D rx ? "rx" : "tx"; + struct device *dev =3D drv_data->dev; + struct dma_chan *chan; + struct k1_spi_io *io; + + chan =3D devm_dma_request_chan(dev, name); + if (IS_ERR(chan)) + return PTR_ERR(chan); + + io =3D rx ? &drv_data->rx : &drv_data->tx; + io->dir =3D rx ? DMA_FROM_DEVICE : DMA_TO_DEVICE; + io->chan =3D chan; + + return 0; +} + +static void k1_spi_dma_cleanup_io(struct k1_spi_driver_data *drv_data, boo= l rx) +{ + struct k1_spi_io *io =3D rx ? &drv_data->rx : &drv_data->tx; + + dmaengine_terminate_sync(io->chan); + sg_free_table(&io->sgt); +} + +static int k1_spi_dma_setup(struct k1_spi_driver_data *drv_data) +{ + struct device *dev =3D drv_data->dev; + int rx_ret; + int tx_ret; + + /* We must get both DMA channels, or neither of them */ + rx_ret =3D k1_spi_dma_setup_io(drv_data, true); + if (rx_ret =3D=3D -EPROBE_DEFER) + return -EPROBE_DEFER; + + tx_ret =3D k1_spi_dma_setup_io(drv_data, false); + + /* If neither is specified, we don't use DMA */ + if (rx_ret =3D=3D -ENODEV && tx_ret =3D=3D -ENODEV) + return 0; + + if (rx_ret || tx_ret) + goto err_cleanup; + + drv_data->dummy =3D devm_kzalloc(dev, SZ_2K, GFP_KERNEL); + if (drv_data->dummy) + return 0; /* Success! */ + + dev_warn(dev, "error allocating DMA dummy buffer; DMA disabled\n"); +err_cleanup: + if (tx_ret) { + if (tx_ret !=3D -EPROBE_DEFER) + dev_err(dev, "error requesting DMA TX DMA channel\n"); + } else { + k1_spi_dma_cleanup_io(drv_data, false); + } + + if (rx_ret) + dev_err(dev, "error requesting DMA RX DMA channel\n"); + else + k1_spi_dma_cleanup_io(drv_data, true); + + if (tx_ret =3D=3D -EPROBE_DEFER) + return -EPROBE_DEFER; + + /* Return success if we don't get the dummy buffer; PIO will be used */ + + return rx_ret ? : tx_ret ? : 0; +} + +static void k1_spi_dma_cleanup(struct device *dev, void *res) +{ + struct k1_spi_driver_data *drv_data =3D res; + + if (k1_spi_dma_enabled(drv_data)) { + k1_spi_dma_cleanup_io(drv_data, false); + k1_spi_dma_cleanup_io(drv_data, true); + } +} + +static int devm_k1_spi_dma_setup(struct k1_spi_driver_data *drv_data) +{ + struct k1_spi_driver_data **ptr; + int ret; + + if (!IS_ENABLED(CONFIG_MMP_PDMA)) { + dev_warn(drv_data->dev, "DMA not available; using PIO\n"); + return 0; + } + + ptr =3D devres_alloc(k1_spi_dma_cleanup, sizeof(*ptr), GFP_KERNEL); + if (!ptr) + return -ENOMEM; + + ret =3D k1_spi_dma_setup(drv_data); + if (ret) { + devres_free(ptr); + return ret; + } + + *ptr =3D drv_data; + devres_add(drv_data->dev, ptr); + + return 0; +} + +static const struct of_device_id k1_spi_dt_ids[] =3D { + { .compatible =3D "spacemit,k1-spi", }, + {} +}; +MODULE_DEVICE_TABLE(of, k1_spi_dt_ids); + +static void k1_spi_host_init(struct k1_spi_driver_data *drv_data) +{ + struct device_node *np =3D dev_of_node(drv_data->dev); + struct spi_controller *host =3D drv_data->controller; + struct device *dev =3D drv_data->dev; + u32 max_speed_hz; + int ret; + + host->dev.of_node =3D np; + host->dev.parent =3D drv_data->dev; + host->mode_bits =3D SPI_CPOL | SPI_CPHA | SPI_LOOP; + host->bits_per_word_mask =3D SPI_BPW_RANGE_MASK(4, 32); + host->num_chipselect =3D 1; + + if (k1_spi_dma_enabled(drv_data)) + host->dma_alignment =3D K1_SPI_DMA_ALIGNMENT; + host->cleanup =3D k1_spi_cleanup; + host->setup =3D k1_spi_setup; + host->transfer_one_message =3D k1_spi_transfer_one_message; + + ret =3D of_property_read_u32(np, "spi-max-frequency", &max_speed_hz); + if (!ret) { + host->max_speed_hz =3D clamp(max_speed_hz, K1_SPI_MIN_SPEED_HZ, + K1_SPI_MAX_SPEED_HZ); + if (host->max_speed_hz !=3D max_speed_hz) + dev_warn(dev, "spi-max-frequency %u out of range, using %u\n", + max_speed_hz, host->max_speed_hz); + } else { + if (ret !=3D -EINVAL) + dev_warn(dev, "bad spi-max-frequency, using %u\n", + K1_SPI_DEFAULT_MAX_SPEED_HZ); + host->max_speed_hz =3D K1_SPI_DEFAULT_MAX_SPEED_HZ; + } +} + +/* Set our registers to a known initial state */ +static void +k1_spi_register_reset(struct k1_spi_driver_data *drv_data, bool initial) +{ + u32 val =3D 0; + + writel(0, drv_data->base + SSP_TOP_CTRL); + + if (initial) { + /* + * The TX and RX FIFO thresholds are the same no matter + * what the speed or bits per word, so we can just set + * them once. The thresholds are one more than the values + * in the register. + */ + val =3D FIELD_PREP(FIFO_RFT_MASK, K1_SPI_THRESH - 1); + val |=3D FIELD_PREP(FIFO_TFT_MASK, K1_SPI_THRESH - 1); + } + writel(val, drv_data->base + SSP_FIFO_CTRL); + + writel(0, drv_data->base + SSP_INT_EN); + writel(0, drv_data->base + SSP_TIMEOUT); + + /* Clear any pending interrupt conditions */ + val =3D readl(drv_data->base + SSP_STATUS); + writel(val, drv_data->base + SSP_STATUS); +} + +static irqreturn_t k1_spi_ssp_isr(int irq, void *dev_id) +{ + struct k1_spi_driver_data *drv_data =3D dev_id; + bool rx_done; + bool tx_done; + u32 val; + + /* Get status and clear pending interrupts */ + val =3D readl(drv_data->base + SSP_STATUS); + writel(val, drv_data->base + SSP_STATUS); + + if (!drv_data->message) + return IRQ_NONE; + + /* Check for a TX underrun or RX underrun first */ + if (val & (SSP_STATUS_TUR | SSP_STATUS_ROR)) { + /* Disable all interrupts on error */ + writel(0, drv_data->base + SSP_INT_EN); + + drv_data->message->status =3D -EIO; + complete(&drv_data->completion); + + return IRQ_HANDLED; + } + + /* Drain the RX FIFO first, then transmit what we can */ + rx_done =3D k1_spi_read(drv_data); + tx_done =3D k1_spi_write(drv_data); + + /* Disable interrupts if we're done transferring either direction */ + if (rx_done || tx_done) { + /* If both are done, disable all interrupts */ + if (rx_done && tx_done) { + val =3D 0; + } else { + val =3D readl(drv_data->base + SSP_INT_EN); + if (rx_done) + val &=3D ~(SSP_INT_EN_TINTE | SSP_INT_EN_RIE); + if (tx_done) + val &=3D ~SSP_INT_EN_TIE; + } + writel(val, drv_data->base + SSP_INT_EN); + } + + if (rx_done && tx_done) + complete(&drv_data->completion); + + return IRQ_HANDLED; +} + +static int k1_spi_probe(struct platform_device *pdev) +{ + struct k1_spi_driver_data *drv_data; + struct device *dev =3D &pdev->dev; + struct reset_control *reset; + struct spi_controller *host; + struct resource *iores; + struct clk *clk_bus; + int ret; + + host =3D devm_spi_alloc_host(dev, sizeof(*drv_data)); + if (!host) + return -ENOMEM; + drv_data =3D spi_controller_get_devdata(host); + drv_data->controller =3D host; + platform_set_drvdata(pdev, drv_data); + drv_data->dev =3D dev; + init_completion(&drv_data->completion); + + drv_data->base =3D devm_platform_get_and_ioremap_resource(pdev, 0, + &iores); + if (IS_ERR(drv_data->base)) + return dev_err_probe(dev, PTR_ERR(drv_data->base), + "error mapping memory\n"); + drv_data->base_addr =3D iores->start; + + ret =3D devm_k1_spi_dma_setup(drv_data); + if (ret) + return dev_err_probe(dev, ret, "error setting up DMA\n"); + + k1_spi_host_init(drv_data); + + clk_bus =3D devm_clk_get_enabled(dev, "bus"); + if (IS_ERR(clk_bus)) + return dev_err_probe(dev, PTR_ERR(clk_bus), + "error getting/enabling bus clock\n"); + drv_data->bus_rate =3D clk_get_rate(clk_bus); + + drv_data->clk =3D devm_clk_get_enabled(dev, "core"); + if (IS_ERR(drv_data->clk)) + return dev_err_probe(dev, PTR_ERR(drv_data->clk), + "error getting/enabling core clock\n"); + + reset =3D devm_reset_control_get_exclusive_deasserted(dev, NULL); + if (IS_ERR(reset)) + return dev_err_probe(dev, PTR_ERR(reset), + "error getting/deasserting reset\n"); + + k1_spi_register_reset(drv_data, true); + + drv_data->irq =3D platform_get_irq(pdev, 0); + if (drv_data->irq < 0) + return dev_err_probe(dev, drv_data->irq, "error getting IRQ\n"); + + ret =3D devm_request_irq(dev, drv_data->irq, k1_spi_ssp_isr, + IRQF_SHARED, dev_name(dev), drv_data); + if (ret < 0) + return dev_err_probe(dev, ret, "error requesting IRQ\n"); + + ret =3D devm_spi_register_controller(dev, host); + if (ret) + dev_err(dev, "error registering controller\n"); + + return ret; +} + +static void k1_spi_remove(struct platform_device *pdev) +{ + struct k1_spi_driver_data *drv_data =3D platform_get_drvdata(pdev); + + k1_spi_register_reset(drv_data, false); +} + +static struct platform_driver k1_spi_driver =3D { + .driver =3D { + .name =3D "k1-spi", + .of_match_table =3D k1_spi_dt_ids, + }, + .probe =3D k1_spi_probe, + .remove =3D k1_spi_remove, +}; + +module_platform_driver(k1_spi_driver); + +MODULE_DESCRIPTION("SpacemiT K1 SPI controller driver"); +MODULE_LICENSE("GPL"); --=20 2.48.1 From nobody Thu Oct 2 06:21:37 2025 Received: from mail-io1-f43.google.com (mail-io1-f43.google.com [209.85.166.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC08431FEDB for ; Fri, 19 Sep 2025 15:59:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758297566; cv=none; b=ui/XI2wcMT28W5lyXn2A5CCtW9HxRHJIiA5+psHdm53yfTMpqe2JoenA8dqUTH73ZLvaxouryd+6Rf6Yfr6IwKI8h1t5BAFQiZgAex4FXt1nbqbALCXM/l+MBzW43w3FxviqeGtCbc+ftDlXNZYycEnOpOoPnJpvrBBRzYZ87os= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758297566; c=relaxed/simple; bh=NlMkLdvD64IRA/MwFZvIoBYriU4Nid/OitYs5+FRBUQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cOHYNetWrFRhpXr7s9o/wIYT1/Jy3DZ8rpMiGY2s3fKqoR1vKxrhEfpU37fGe4g/O1eSg4j4r3z5Us4lmM/CvsLAwQlMQibGtB2az/zts6HLf2zy0JECtk/9x/1GesYkrEkdixS+f++cPrSXQcIa/LQ6wmJ0qkeNDx8PcGp/HD8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=hIba/qvU; arc=none smtp.client-ip=209.85.166.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="hIba/qvU" Received: by mail-io1-f43.google.com with SMTP id ca18e2360f4ac-89737fcb219so172579039f.3 for ; Fri, 19 Sep 2025 08:59:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1758297563; x=1758902363; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Oo7s49MWiPP0XpbU9jJjL7SpuVNC45j91Je82FzACGw=; b=hIba/qvU9jPG2mLC86wu4sLVoK7VbCJibIkixSqa6F6tzSbpIyq0ZR8A6svQzqFQnC GNN/aijr3a26oe9k/JIaldh8tW+ENCK/cbJVgDGCzp0V7f64qpELN7KFMlnIO0frmf7c khWz40qeAYc/W8Db8KcS4KQpYBjSyJmzycXw2S3Eb6DRgR76RdwVG9L2t7fYBX8itstE H3op3/V+iOv4CrMZtwstDlPwVeVyi/oICgjChjqiWo6NNXzBSp2k6m0Gz7uRaiNkN3j8 utPs70cZGC5dX7yhXyeRtVYW+WHxeZT+FQdNIHbXhTiCLfCLSeE3Fz2bOV9iXkpIHP3E aJSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758297563; x=1758902363; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Oo7s49MWiPP0XpbU9jJjL7SpuVNC45j91Je82FzACGw=; b=mE2q7CigtaWmp2xGQG+b4ihWQLi07p3EzjCwFRMo33+h372DYfe3+EuANp55i14j/V rmTqQ+Z0ekvCL+OG+B4Ba4K5+fbAhBolh5oB04WJIRod6Z97cNmA5hg9ZKwgBjYmNVgz QBz0vImOdQaZDE/JyECDoxuSdOvbovdUVV+5s4kmGZneL0qj7KVAYUj5xisr+bjrN8KP Nr9r1z3tZ5FWk1jQy+GdDYuSSz8id2Hg3KxT58/fXYx8lrEe3vvat2nyRdLeecknbw0Z YkhNcWdC86Mh2WQ/YPTcUhJSthRG+YPWf9synDv/1udOu3Mn5WG2+ECOFp9GPW/qsbsE IAvQ== X-Forwarded-Encrypted: i=1; AJvYcCUfvmvoxtBYZfmUoCO/hA+XpdVWAzUSJUY4T0+vbJK1RbX4nixUlzF4pwMP2SJZuIGGvjHT6i0mNzlfVJg=@vger.kernel.org X-Gm-Message-State: AOJu0YyHUR4la+L7CjgXVFCB0C5q4n2LbVo8yPauincS4LMwOqjGaPyr U4uoyGLzf6FvyH6gR0dL1CCrOs88zSuYQeCm531lU2f4vocofKGKkr8TTUa5EUIA+Xg= X-Gm-Gg: ASbGncu3YXLMX2rmxh7dTTYD886z7RWdwfWlOeakOnp7EcHnq0QxE4l3x+Infx0nPQj f/Zbp9VvFGvXQmfvKOT072eLrXTLmQqaq0fRLb8/aWN2IwXaG9NXe/g/+bcx4XKa5tUWEwvbGND 30JtAWMgGJJmR9R3rFjdK9+f4U9XLhiMmItSNPDt7/LIdSxOMiqrux1PXF29X5J3uZSdO81kcQt RF+kEPET0OywT920uQvh4a3ZnxkUMElC1cq4gATqy/n8YKUhcvjZK5ry4Qj2p/h9fnfO4GfHyn6 JsBdS45zP5VhHWV04rVRNPYo/DqLjxMb4VC4L4MYRckCIA8kd8bec9tCv6VURYixBeTlKgtcGEp g/lo5z8Y/DDWxQu9U603A5WpT4KyK+Q2YhN/mQ5Sw14l7dXcBDAHAgyCZECGjqoFiVQ== X-Google-Smtp-Source: AGHT+IGv8Gt7EaPcdotr9gY5Yd6METFFETdEj+xRnRLa13tdcKb2eRmmBl1GTwt/NGaaW1sg3ZmbBQ== X-Received: by 2002:a05:6e02:258a:b0:423:fdc4:4e35 with SMTP id e9e14a558f8ab-4248197e1b4mr55249165ab.24.1758297562539; Fri, 19 Sep 2025 08:59:22 -0700 (PDT) Received: from zippy.localdomain (c-75-72-117-212.hsd1.mn.comcast.net. [75.72.117.212]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-53d50aa460bsm2250898173.52.2025.09.19.08.59.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Sep 2025 08:59:22 -0700 (PDT) From: Alex Elder To: broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: dlan@gentoo.org, ziyao@disroot.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, p.zabel@pengutronix.de, spacemit@lists.linux.dev, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/3] riscv: dts: spacemit: define a SPI controller node Date: Fri, 19 Sep 2025 10:59:13 -0500 Message-ID: <20250919155914.935608-4-elder@riscstar.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250919155914.935608-1-elder@riscstar.com> References: <20250919155914.935608-1-elder@riscstar.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Define a node for the fourth SoC SPI controller (number 3) on the SpacemiT K1 SoC. Enable it on the Banana Pi BPI-F3 board, which exposes this feature via its GPIO block: GPIO PIN 19: MOSI GPIO PIN 21: MISO GPIO PIN 23: SCLK GPIO PIN 24: SS (inverted) Define pincontrol configurations for the pins as used on that board. (This was tested using a GigaDevice GD25Q64E SPI NOR chip.) Signed-off-by: Alex Elder --- v2: - DT aliases are used rather than spacemit,k1-ssp-id for bus number - The order of two pin control properties was changed as requested - Clock names and DMA names are now on one line in the "k1.dtsi" - The interrupts property is used rather than interrupts-extended .../boot/dts/spacemit/k1-bananapi-f3.dts | 7 +++++++ arch/riscv/boot/dts/spacemit/k1-pinctrl.dtsi | 20 +++++++++++++++++++ arch/riscv/boot/dts/spacemit/k1.dtsi | 16 +++++++++++++++ 3 files changed, 43 insertions(+) diff --git a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts b/arch/riscv/b= oot/dts/spacemit/k1-bananapi-f3.dts index 2aaaff77831e1..d9d865fbe320e 100644 --- a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts +++ b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts @@ -14,6 +14,7 @@ aliases { ethernet0 =3D ð0; ethernet1 =3D ð1; serial0 =3D &uart0; + spi3 =3D &spi3; }; =20 chosen { @@ -92,6 +93,12 @@ &pdma { status =3D "okay"; }; =20 +&spi3 { + pinctrl-0 =3D <&ssp3_0_cfg>; + pinctrl-names =3D "default"; + status =3D "okay"; +}; + &uart0 { pinctrl-names =3D "default"; pinctrl-0 =3D <&uart0_2_cfg>; diff --git a/arch/riscv/boot/dts/spacemit/k1-pinctrl.dtsi b/arch/riscv/boot= /dts/spacemit/k1-pinctrl.dtsi index aff19c86d5ff3..205c201a3005c 100644 --- a/arch/riscv/boot/dts/spacemit/k1-pinctrl.dtsi +++ b/arch/riscv/boot/dts/spacemit/k1-pinctrl.dtsi @@ -76,4 +76,24 @@ pwm14-1-pins { drive-strength =3D <32>; }; }; + + ssp3_0_cfg: ssp3-0-cfg { + ssp3-0-no-pull-pins { + pinmux =3D , /* SCLK */ + , /* MOSI */ + ; /* MISO */ + + bias-disable; + drive-strength =3D <19>; + power-source =3D <3300>; + }; + + ssp3-0-frm-pins { + pinmux =3D ; /* FRM (frame) */ + + bias-pull-up =3D <0>; + drive-strength =3D <19>; + power-source =3D <3300>; + }; + }; }; diff --git a/arch/riscv/boot/dts/spacemit/k1.dtsi b/arch/riscv/boot/dts/spa= cemit/k1.dtsi index 6cdcd80a7c83b..f8c37d16968e4 100644 --- a/arch/riscv/boot/dts/spacemit/k1.dtsi +++ b/arch/riscv/boot/dts/spacemit/k1.dtsi @@ -856,6 +856,22 @@ storage-bus { #size-cells =3D <2>; dma-ranges =3D <0x0 0x00000000 0x0 0x00000000 0x0 0x80000000>; =20 + spi3: spi@d401c000 { + compatible =3D "spacemit,k1-spi"; + reg =3D <0x0 0xd401c000 0x0 0x30>; + #address-cells =3D <1>; + #size-cells =3D <0>; + clocks =3D <&syscon_apbc CLK_SSP3>, + <&syscon_apbc CLK_SSP3_BUS>; + clock-names =3D "core", "bus"; + resets =3D <&syscon_apbc RESET_SSP3>; + interrupts =3D <55>; + dmas =3D <&pdma 20>, + <&pdma 19>; + dma-names =3D "rx", "tx"; + status =3D "disabled"; + }; + emmc: mmc@d4281000 { compatible =3D "spacemit,k1-sdhci"; reg =3D <0x0 0xd4281000 0x0 0x200>; --=20 2.48.1