From nobody Thu Oct 2 07:45:19 2025 Received: from sipsolutions.net (s3.sipsolutions.net [168.119.38.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43A3C31A7E8; Fri, 19 Sep 2025 15:36:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=168.119.38.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758296169; cv=none; b=NFraDxmlNccg5Qyd2m9tbZm65kdSCsQ53QQ9957nY3gd5pQO4rtJrxvsaWU2MFDhP7yl7doBpIxfnLXw1PzfA4ndnMQahvqIPhW7qCiEeI7KcaHdX20b5QTVUj0STLCJh3Pe9/L3l8ID2S0X7ho1U/Y1v/mPRjL3LU48NzQ6rXU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758296169; c=relaxed/simple; bh=VzHe7plOCC4IM2A9hgSWmbnT6yiWBw5g/7UEoOBTe0U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=EGPMb3Etm8AtkoIH0rwz7Gc1cOVbUWXca09020teK6CDoxoiTBpu6dJYj9/QFH1jhzauP59t7ETzKfQXYkv7X/5QFECPIlJKkeA7Dt0WRadsCQpV43mO6H+hIm716KFQf3xMkYbpDH9vKym+wtl3IFvsqXQe2BKS2gKKK1OJWtw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sipsolutions.net; spf=pass smtp.mailfrom=sipsolutions.net; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b=K39nyr+6; arc=none smtp.client-ip=168.119.38.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sipsolutions.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sipsolutions.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b="K39nyr+6" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=z10b0FVwCq0i5SVTTgonk/hnK8AmJrJFJmxu+fzz9NI=; t=1758296168; x=1759505768; b=K39nyr+6c67lkUBMzkmpT4/whmJ5N6xeAFrR/1rCtJLznMF kSdgRLNwztGRhetRpSQz9TpmFpDNT/igHOfJQ0phM4O4EWTEGmJU8xJ5fJL2p0di8s4uk7nTY2qJy BovrOQ6JeMcLlCyWG+5352me+NVvpAQAYPu/r96cUM9DfxnUXdsipEbOT5Ep72locheA7oLWZz+6r NWmXHrmWlASMK/mHS+O9EM7i30QrxtUMmD2ixpOAefpESsvcVIQpOkVN6bbbZbl1LVcJ9V9TXKbkm BNOxIVPuCmJErsxAuUGbumn2YeyZNHHVEuKOiZly4nTvTcUHy3ZtOydAGEkzFGYA==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.98.2) (envelope-from ) id 1uzd9W-0000000G6O6-3qcL; Fri, 19 Sep 2025 17:36:04 +0200 From: Benjamin Berg To: linux-um@lists.infradead.org, Willy Tarreau , =?UTF-8?q?Thomas=20Wei=C3=9Fschuh?= , linux-kselftest@vger.kernel.org, Arnaldo Carvalho de Melo Cc: linux-kernel@vger.kernel.org, Benjamin Berg Subject: [PATCH v2 04/11] tools/nolibc/dirent: avoid errno in readdir_r Date: Fri, 19 Sep 2025 17:34:13 +0200 Message-ID: <20250919153420.727385-5-benjamin@sipsolutions.net> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250919153420.727385-1-benjamin@sipsolutions.net> References: <20250919153420.727385-1-benjamin@sipsolutions.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-malware-bazaar: not-scanned From: Benjamin Berg Using errno is not possible when NOLIBC_IGNORE_ERRNO is set. Use sys_lseek instead of lseek as that avoids using errno. Fixes: 665fa8dea90d ("tools/nolibc: add support for directory access") Signed-off-by: Benjamin Berg Acked-by: Thomas Wei=C3=9Fschuh --- tools/include/nolibc/dirent.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/include/nolibc/dirent.h b/tools/include/nolibc/dirent.h index 758b95c48e7a..61a122a60327 100644 --- a/tools/include/nolibc/dirent.h +++ b/tools/include/nolibc/dirent.h @@ -86,9 +86,9 @@ int readdir_r(DIR *dirp, struct dirent *entry, struct dir= ent **result) * readdir() can only return one entry at a time. * Make sure the non-returned ones are not skipped. */ - ret =3D lseek(fd, ldir->d_off, SEEK_SET); - if (ret =3D=3D -1) - return errno; + ret =3D sys_lseek(fd, ldir->d_off, SEEK_SET); + if (ret < 0) + return -ret; =20 entry->d_ino =3D ldir->d_ino; /* the destination should always be big enough */ --=20 2.51.0