From nobody Thu Oct 2 09:21:27 2025 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAE9E30FC0F for ; Thu, 18 Sep 2025 15:52:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758210768; cv=none; b=R2RHNLJYe+U4j/UcRZfN37wMCz+NECVrs2aJHLZZbZFbzNZ+xG6T9Z6Vc761H3RcL/1s41DD0CSKmigEMm611tta8VlG0m3MugTZiHtlG4Be/FW4k9Ln92IRUnUKmUMKt+B0cmSPUX2hLp7vLLC8nqzgB0t+qPaW8V83knz9sQI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758210768; c=relaxed/simple; bh=BRys3ZutdevswohgMnBrm5EhSN86iKLozXVmHM3NKNw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=U+7rk/WnOhfkhd8BZd6rTLjWiJtrjNngi4oQeJHSSrVsnzX+LHlcV5Qstdhijw+IOJQpp5rplPHMZzzCU4jtOeYMp+N0H/fxCLQQ+LlbbMYlftboAPfz/YEV4o7+0MQoOGvsiLlrSBNYWLXQFb580lfzzzgcVCFV6vFqZLYt0Tg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com; spf=pass smtp.mailfrom=amarulasolutions.com; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b=iqN/mNId; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="iqN/mNId" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-b00a9989633so234433266b.0 for ; Thu, 18 Sep 2025 08:52:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1758210765; x=1758815565; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JAYdvSVQgA1h0haeD8J+mH93pNUjVxDxBFzkQXHtMmU=; b=iqN/mNIdBHsoxt7W9k3jvewSWUqoFL0ktOmTmaOOjQusami66i3lq1kwP603ckpzpu 7RX+/P2tb7QRWQZ134CL4nBFE6JEmPWgYlETKE2HETZk88iRUdmZDxBNbLLnXIit7fVZ q92S62sEIrpWtKoW7ADIDKpDaDWfsNIYA+THc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758210765; x=1758815565; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JAYdvSVQgA1h0haeD8J+mH93pNUjVxDxBFzkQXHtMmU=; b=xKE2nDGrm3ToCZQFG6aL3qH+khw7U/Q4vTZgE1KbnabglDWFyh4wBpGc8j8Je0wazj dUG1DbJjSlyWdxPP//fkPZrCZSoHF60A9aTcJ/thz2HPYGX/vHDoykE2LUoBTwn7BHZE 9T3+H7ATzs47veuEOQ21joaafDszVednd5w0jPkWAXLP08EUWqDP9L3Ih2XfcAEoAR/W ngIJt2TxlTE+1jKmQrTv/upifmNIk889iCPSKjRb2syK1qbqlM3/Aab3niyymQR8IztM OdFO7QJ1P6b5ud3TXFYBmnvUfCLqF5LSY2icDkamEbSwdYvpLya0wNWeMdmYkOQIIvTT 07mQ== X-Gm-Message-State: AOJu0YzmXYVzCobOU00IuB2ziou2EwRsiF76yO69a6hPXbCfOSriQQh5 HvsoFmLbGbWeOim6xnMVCdE+3Y+2GkhkA/aTGetwr7/xYPD0d1YySP4CmN23vF33DAxHa00mDVK aBA+o X-Gm-Gg: ASbGncvFyzw+VvEiq/EEWmlQDNEFWk3SDghyJVf0CF6NS+mw82cPkPd13orj4KDA3wk pFKSrMgkTjUQqiEYIPutQwUIdMZBRHUUJL78Shdfs9RXC23Mb8+8cNxOCgEGKoI5n2rren8Xumv E6l9FiQJteRNiSCfyDv323BJXnFxXTIlTuctu+78pxG+sbyCkvwT87GmN7qE8c7U6PueV6/4M8X ndCE2Kqxf5Q2lukT8eV0gSOfCPmK7KDJOmpJd61HkBEiKWurOpsLZcmghXlTPoRnHs+TwhgUZDM OnRPuFxNHHnLBnqx8TjNENDfUfxTFE7dg+0OclGc5UoWY1nJK5xMJbhiLN3H8KaQ5vQBF7iRYEO mX/LA3hr4fFTzfWpB9GYkHhz+KVTwLqFpZEbGLuiq9OfqNlamH4RS1Z95PpnXbx5Sv6eD1GAiXG p0XYLa7/Zl3Hlz+U1u50BkhQX3acMY9r2A61xJMWJGU20nX6P8L446n88SZ1AqKtvHTaO1EClDR xgWAYQSQZc= X-Google-Smtp-Source: AGHT+IG+gvq9vJTCt+5pyWxiCzEcIfQz6BO4MhPzenmoiqj/1PmPt6GDmC6QwRXxUKbRTif4JvBq0A== X-Received: by 2002:a17:907:d7cb:b0:b04:1d85:7106 with SMTP id a640c23a62f3a-b1fab24299cmr333418466b.21.1758210764801; Thu, 18 Sep 2025 08:52:44 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-56-38-125.retail.telecomitalia.it. [82.56.38.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b23a1227bacsm60449766b.41.2025.09.18.08.52.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Sep 2025 08:52:44 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Frank Li , linux-amarula@amarulasolutions.com, Michael Trimarchi , Dario Binacchi , Dmitry Torokhov , Fabio Estevam , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH v5 1/6] Input: imx6ul_tsc - fix typo in register name Date: Thu, 18 Sep 2025 17:52:29 +0200 Message-ID: <20250918155240.2536852-2-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250918155240.2536852-1-dario.binacchi@amarulasolutions.com> References: <20250918155240.2536852-1-dario.binacchi@amarulasolutions.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Michael Trimarchi Replace 'SETING' with 'SETTING'. Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi Reviewed-by: Frank Li --- (no changes since v2) Changes in v2: - Add Reviewed-by tag of Frank Li. drivers/input/touchscreen/imx6ul_tsc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/imx6ul_tsc.c b/drivers/input/touchsc= reen/imx6ul_tsc.c index 6ac8fa84ed9f..c2c6e50efc54 100644 --- a/drivers/input/touchscreen/imx6ul_tsc.c +++ b/drivers/input/touchscreen/imx6ul_tsc.c @@ -55,7 +55,7 @@ #define ADC_TIMEOUT msecs_to_jiffies(100) =20 /* TSC registers */ -#define REG_TSC_BASIC_SETING 0x00 +#define REG_TSC_BASIC_SETTING 0x00 #define REG_TSC_PRE_CHARGE_TIME 0x10 #define REG_TSC_FLOW_CONTROL 0x20 #define REG_TSC_MEASURE_VALUE 0x30 @@ -192,7 +192,7 @@ static void imx6ul_tsc_set(struct imx6ul_tsc *tsc) =20 basic_setting |=3D tsc->measure_delay_time << 8; basic_setting |=3D DETECT_4_WIRE_MODE | AUTO_MEASURE; - writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETING); + writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETTING); =20 writel(DE_GLITCH_2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); =20 --=20 2.43.0 From nobody Thu Oct 2 09:21:27 2025 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41DF831355D for ; Thu, 18 Sep 2025 15:52:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758210770; cv=none; b=pJINz2acWL0eu03+BB/6GwebMOoBNq1FKIlXh2G0CJayNn3/5R1ksVjrkCiCeSHPVDIGz1KD7F5yO+CZzMlFztSxfHAYryXmEa5Xg/XF65X/hOjXQzHwNiPuz864zMRfWCOM7Gnl39Tg0qXsmWXzYh4hf/h7s86+ujv6grGs+G8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758210770; c=relaxed/simple; bh=SWFqSXFx87fpKeGP6WN4l1K7YHQdzfNtqBr/fu+vOFA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=D50Odeo8SX1YpbMdOJ2k40cT0f15VbkTvHqadKLC+8JLHGQwyfID3D1PDZamxJSXseXEFtvhSWwVKaujNzNknzW+rCw/8pE+iAPmpvqaB+BbsywBAhpwRmRkG1kLFijGV9sZ8s9LAc/TjsPJAdd+DtLeE27gPsVpmQM29M94uEk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com; spf=pass smtp.mailfrom=amarulasolutions.com; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b=g/7yyi8z; arc=none smtp.client-ip=209.85.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="g/7yyi8z" Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-62f2b27a751so2009468a12.3 for ; Thu, 18 Sep 2025 08:52:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1758210766; x=1758815566; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kDNPkG1BJO1AhX7f67y0O0jm17yTyZBB5A5XJjEod98=; b=g/7yyi8zItAhiKQ0MOr/aT4MDQMiZL0/UhrRO6bItoNGI8WX7KeLJCnC2FKOEgjPZJ 0qLEtxrnQPYyPhaVhem+wko9NdCm7kMd3HzwIJe9HoEqGk+pRcO+Qrh99SfnRe9IWIbj PiL5ao3Jk3nKdvPE1cUPJK+mSVV69XNJ7cZa4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758210766; x=1758815566; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kDNPkG1BJO1AhX7f67y0O0jm17yTyZBB5A5XJjEod98=; b=U9Ecq+HXpfAYFAsDZDNxq0V/LUBSZEZNmntgJK3hbrWmkQrjSELFFBCbMNpxrX9uF+ G177myzWLxW3XnKMJdrHDEQvKHUx2HpAyZ1dA1hePEu755AwZaRKnC0KtXaBiPT55DRg QApdsg5oyvEaHjRM9o7vhWvH5W8U56DLiBL8Wjt5WfZUXGB8TlSo44iPbVneyhSZGRwr 2z8M2h+i9OOhF6wB4/F6SYeyMRJxfl6MFH39/MVL1olIAi9grnptAA7GqwqVSH+CpWRs yQ2HX7xt6ixAsF2FMr1vtKUF1i6WhdoIAUbWR5ySdd64pqH2EJvsUdxxF/LBmDhVvOpM KUCw== X-Gm-Message-State: AOJu0YyPHD6nX+lc/YshZ/HE+Rgumzve//IHIIwjZ78ZlqXbBiX0bzOh ustfycTigPkN5HpBCy8kFh1BEFFMFGknqI5KhlFZb/Vqizxt7l4TdpMGAcGD82rXyOIemynYqhl UIchr X-Gm-Gg: ASbGncuTw35i1jP7QfNrNg3hzUFOb7lz1WPnJstI7GS7a3mXdx1tETVLAkInpbQr8Pb 3MHaq2MRvjdS/UnGADSJ4pCNUuPE8nvJQcZO4s3MCy6WOetLYZZ+znXTWpe+2eslQTs9ijyTWni KiV05kPGiXmNBDMHI8/e3WGZiSXFVCO2kyGkX1lAo/EMUFO5o4k8OIMAu5F8bwFzS7/9wZnTyzx lV8v6w6t8BFm4ahEYa6i4FH9IWEwi0Kd7XIZaHU25z8S48Sbky9XfURlTMJnEEo/sWz8+i+Oc9h eqkyJO2pADMChQ0BVTq7OzzZciuQN3KIlrFAfwIKSfXGIAmGYi0bsA8z1juud4AA9FuTj/t6u75 LNpUU9GathO4pus3i1TnFqQdxeypMQmqfViDNHSS0hLCXdxXEtSt70tIQdt2wv3VKQMZBdOQIpU l3698FwTZ0uVS8l3hh/eI4uH5CI4Nxpp/ynQ0oyKkP52TuD6couvu0VpoUC2Ro+bOmi4N19iULO LI6XhBsqTY= X-Google-Smtp-Source: AGHT+IHfByKCEQ3wXjxPDrS204MSTmaRffllVRG/pKI5I9mIjBBATM973yHN3Wh9zKsqGRddu5ncPA== X-Received: by 2002:a17:906:6a1e:b0:afe:ffb6:bfaf with SMTP id a640c23a62f3a-b1bb50c4058mr757196066b.3.1758210766182; Thu, 18 Sep 2025 08:52:46 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-56-38-125.retail.telecomitalia.it. [82.56.38.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b23a1227bacsm60449766b.41.2025.09.18.08.52.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Sep 2025 08:52:45 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Frank Li , linux-amarula@amarulasolutions.com, Dario Binacchi , Dmitry Torokhov , Fabio Estevam , Michael Trimarchi , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH v5 2/6] Input: imx6ul_tsc - use BIT, FIELD_{GET,PREP} and GENMASK macros Date: Thu, 18 Sep 2025 17:52:30 +0200 Message-ID: <20250918155240.2536852-3-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250918155240.2536852-1-dario.binacchi@amarulasolutions.com> References: <20250918155240.2536852-1-dario.binacchi@amarulasolutions.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace opencoded masking and shifting, with BIT(), GENMASK(), FIELD_GET() and FIELD_PREP() macros. Signed-off-by: Dario Binacchi Reviewed-by: Frank Li --- (no changes since v2) Changes in v2: - Add Reviewed-by tag of Frank Li. - Move the patch right after the one fixing the typo according to Frank Li's suggestions. drivers/input/touchscreen/imx6ul_tsc.c | 96 +++++++++++++++----------- 1 file changed, 54 insertions(+), 42 deletions(-) diff --git a/drivers/input/touchscreen/imx6ul_tsc.c b/drivers/input/touchsc= reen/imx6ul_tsc.c index c2c6e50efc54..e2c59cc7c82c 100644 --- a/drivers/input/touchscreen/imx6ul_tsc.c +++ b/drivers/input/touchscreen/imx6ul_tsc.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include @@ -20,25 +21,23 @@ #include =20 /* ADC configuration registers field define */ -#define ADC_AIEN (0x1 << 7) +#define ADC_AIEN BIT(7) +#define ADC_ADCH_MASK GENMASK(4, 0) #define ADC_CONV_DISABLE 0x1F -#define ADC_AVGE (0x1 << 5) -#define ADC_CAL (0x1 << 7) -#define ADC_CALF 0x2 -#define ADC_12BIT_MODE (0x2 << 2) -#define ADC_CONV_MODE_MASK (0x3 << 2) +#define ADC_AVGE BIT(5) +#define ADC_CAL BIT(7) +#define ADC_CALF BIT(1) +#define ADC_CONV_MODE_MASK GENMASK(3, 2) +#define ADC_12BIT_MODE 0x2 #define ADC_IPG_CLK 0x00 -#define ADC_INPUT_CLK_MASK 0x3 -#define ADC_CLK_DIV_8 (0x03 << 5) -#define ADC_CLK_DIV_MASK (0x3 << 5) -#define ADC_SHORT_SAMPLE_MODE (0x0 << 4) -#define ADC_SAMPLE_MODE_MASK (0x1 << 4) -#define ADC_HARDWARE_TRIGGER (0x1 << 13) -#define ADC_AVGS_SHIFT 14 -#define ADC_AVGS_MASK (0x3 << 14) +#define ADC_INPUT_CLK_MASK GENMASK(1, 0) +#define ADC_CLK_DIV_8 0x03 +#define ADC_CLK_DIV_MASK GENMASK(6, 5) +#define ADC_SAMPLE_MODE BIT(4) +#define ADC_HARDWARE_TRIGGER BIT(13) +#define ADC_AVGS_MASK GENMASK(15, 14) #define SELECT_CHANNEL_4 0x04 #define SELECT_CHANNEL_1 0x01 -#define DISABLE_CONVERSION_INT (0x0 << 7) =20 /* ADC registers */ #define REG_ADC_HC0 0x00 @@ -65,19 +64,26 @@ #define REG_TSC_DEBUG_MODE 0x70 #define REG_TSC_DEBUG_MODE2 0x80 =20 +/* TSC_MEASURE_VALUE register field define */ +#define X_VALUE_MASK GENMASK(27, 16) +#define Y_VALUE_MASK GENMASK(11, 0) + /* TSC configuration registers field define */ -#define DETECT_4_WIRE_MODE (0x0 << 4) -#define AUTO_MEASURE 0x1 -#define MEASURE_SIGNAL 0x1 -#define DETECT_SIGNAL (0x1 << 4) -#define VALID_SIGNAL (0x1 << 8) -#define MEASURE_INT_EN 0x1 -#define MEASURE_SIG_EN 0x1 -#define VALID_SIG_EN (0x1 << 8) -#define DE_GLITCH_2 (0x2 << 29) -#define START_SENSE (0x1 << 12) -#define TSC_DISABLE (0x1 << 16) +#define MEASURE_DELAY_TIME_MASK GENMASK(31, 8) +#define DETECT_5_WIRE_MODE BIT(4) +#define AUTO_MEASURE BIT(0) +#define MEASURE_SIGNAL BIT(0) +#define DETECT_SIGNAL BIT(4) +#define VALID_SIGNAL BIT(8) +#define MEASURE_INT_EN BIT(0) +#define MEASURE_SIG_EN BIT(0) +#define VALID_SIG_EN BIT(8) +#define DE_GLITCH_MASK GENMASK(30, 29) +#define DE_GLITCH_2 0x02 +#define START_SENSE BIT(12) +#define TSC_DISABLE BIT(16) #define DETECT_MODE 0x2 +#define STATE_MACHINE_MASK GENMASK(22, 20) =20 struct imx6ul_tsc { struct device *dev; @@ -112,19 +118,20 @@ static int imx6ul_adc_init(struct imx6ul_tsc *tsc) =20 adc_cfg =3D readl(tsc->adc_regs + REG_ADC_CFG); adc_cfg &=3D ~(ADC_CONV_MODE_MASK | ADC_INPUT_CLK_MASK); - adc_cfg |=3D ADC_12BIT_MODE | ADC_IPG_CLK; - adc_cfg &=3D ~(ADC_CLK_DIV_MASK | ADC_SAMPLE_MODE_MASK); - adc_cfg |=3D ADC_CLK_DIV_8 | ADC_SHORT_SAMPLE_MODE; + adc_cfg |=3D FIELD_PREP(ADC_CONV_MODE_MASK, ADC_12BIT_MODE) | + FIELD_PREP(ADC_INPUT_CLK_MASK, ADC_IPG_CLK); + adc_cfg &=3D ~(ADC_CLK_DIV_MASK | ADC_SAMPLE_MODE); + adc_cfg |=3D FIELD_PREP(ADC_CLK_DIV_MASK, ADC_CLK_DIV_8); if (tsc->average_enable) { adc_cfg &=3D ~ADC_AVGS_MASK; - adc_cfg |=3D (tsc->average_select) << ADC_AVGS_SHIFT; + adc_cfg |=3D FIELD_PREP(ADC_AVGS_MASK, tsc->average_select); } adc_cfg &=3D ~ADC_HARDWARE_TRIGGER; writel(adc_cfg, tsc->adc_regs + REG_ADC_CFG); =20 /* enable calibration interrupt */ adc_hc |=3D ADC_AIEN; - adc_hc |=3D ADC_CONV_DISABLE; + adc_hc |=3D FIELD_PREP(ADC_ADCH_MASK, ADC_CONV_DISABLE); writel(adc_hc, tsc->adc_regs + REG_ADC_HC0); =20 /* start ADC calibration */ @@ -164,19 +171,21 @@ static void imx6ul_tsc_channel_config(struct imx6ul_t= sc *tsc) { u32 adc_hc0, adc_hc1, adc_hc2, adc_hc3, adc_hc4; =20 - adc_hc0 =3D DISABLE_CONVERSION_INT; + adc_hc0 =3D FIELD_PREP(ADC_AIEN, 0); writel(adc_hc0, tsc->adc_regs + REG_ADC_HC0); =20 - adc_hc1 =3D DISABLE_CONVERSION_INT | SELECT_CHANNEL_4; + adc_hc1 =3D FIELD_PREP(ADC_AIEN, 0) | + FIELD_PREP(ADC_ADCH_MASK, SELECT_CHANNEL_4); writel(adc_hc1, tsc->adc_regs + REG_ADC_HC1); =20 - adc_hc2 =3D DISABLE_CONVERSION_INT; + adc_hc2 =3D FIELD_PREP(ADC_AIEN, 0); writel(adc_hc2, tsc->adc_regs + REG_ADC_HC2); =20 - adc_hc3 =3D DISABLE_CONVERSION_INT | SELECT_CHANNEL_1; + adc_hc3 =3D FIELD_PREP(ADC_AIEN, 0) | + FIELD_PREP(ADC_ADCH_MASK, SELECT_CHANNEL_1); writel(adc_hc3, tsc->adc_regs + REG_ADC_HC3); =20 - adc_hc4 =3D DISABLE_CONVERSION_INT; + adc_hc4 =3D FIELD_PREP(ADC_AIEN, 0); writel(adc_hc4, tsc->adc_regs + REG_ADC_HC4); } =20 @@ -188,13 +197,16 @@ static void imx6ul_tsc_channel_config(struct imx6ul_t= sc *tsc) static void imx6ul_tsc_set(struct imx6ul_tsc *tsc) { u32 basic_setting =3D 0; + u32 debug_mode2; u32 start; =20 - basic_setting |=3D tsc->measure_delay_time << 8; - basic_setting |=3D DETECT_4_WIRE_MODE | AUTO_MEASURE; + basic_setting |=3D FIELD_PREP(MEASURE_DELAY_TIME_MASK, + tsc->measure_delay_time); + basic_setting |=3D AUTO_MEASURE; writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETTING); =20 - writel(DE_GLITCH_2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); + debug_mode2 =3D FIELD_PREP(DE_GLITCH_MASK, DE_GLITCH_2); + writel(debug_mode2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); =20 writel(tsc->pre_charge_time, tsc->tsc_regs + REG_TSC_PRE_CHARGE_TIME); writel(MEASURE_INT_EN, tsc->tsc_regs + REG_TSC_INT_EN); @@ -250,7 +262,7 @@ static bool tsc_wait_detect_mode(struct imx6ul_tsc *tsc) =20 usleep_range(200, 400); debug_mode2 =3D readl(tsc->tsc_regs + REG_TSC_DEBUG_MODE2); - state_machine =3D (debug_mode2 >> 20) & 0x7; + state_machine =3D FIELD_GET(STATE_MACHINE_MASK, debug_mode2); } while (state_machine !=3D DETECT_MODE); =20 usleep_range(200, 400); @@ -278,8 +290,8 @@ static irqreturn_t tsc_irq_fn(int irq, void *dev_id) =20 if (status & MEASURE_SIGNAL) { value =3D readl(tsc->tsc_regs + REG_TSC_MEASURE_VALUE); - x =3D (value >> 16) & 0x0fff; - y =3D value & 0x0fff; + x =3D FIELD_GET(X_VALUE_MASK, value); + y =3D FIELD_GET(Y_VALUE_MASK, value); =20 /* * In detect mode, we can get the xnur gpio value, --=20 2.43.0 From nobody Thu Oct 2 09:21:27 2025 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A1F2315D2C for ; Thu, 18 Sep 2025 15:52:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758210771; cv=none; b=RcnG5h5qNJViWz+Q1FXIJk2MZhowTGL4R1A+45EElGV90gaQTxi5kPlObqn3Nua9U43pkwgiltC6+DgmGUI1kIuRrsWbn+W4ePNC9iufOPlRRTswmB/n118jfZQwje40oel8p3QqDipj4eZt1dnRPdQPutG+RIDehbEe4W0vUkA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758210771; c=relaxed/simple; bh=8mMtSR0zIoDa6Wg3t6T/sqjlCahjaYeUdlrfsHSDYXE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gDJYKYGZqG3mJpbGzUEtSYp1GUCDS5Sg7u3DPi5mWVfByErf4dvaoCGnaT3PyWhIFUPtt9glhzfeZfd+jz4lY/M2lbwfDwyFOlCThvJHf9UdQMeyNkQpiWPBMp3w9DafiYF1iwjW/LMsL2CzxccM3AOq4R+2CQcbNJXOXfZalRI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com; spf=pass smtp.mailfrom=amarulasolutions.com; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b=O2fP5ZOV; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="O2fP5ZOV" Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-b07ba1c3df4so206495466b.3 for ; Thu, 18 Sep 2025 08:52:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1758210767; x=1758815567; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=b+LIVzIwJpub6PF+1VXdSXGpljd8+6HMYi55fOiXUgs=; b=O2fP5ZOVvraMWDob0IyqegXKkV0ZhEJ1OspLVmq+Gf30ys1M0M7g+LaSivVlNNAaAy 3eMrSzzRXYVWeSBmNMrWeLXDslGtrmWhzoLE2wWlEAsmBaxBTAjM72lXnoYgj7Zzc+jW x4WZN6CUFKWe5MJU8S62ehiNMV/qZH68ETUNU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758210767; x=1758815567; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b+LIVzIwJpub6PF+1VXdSXGpljd8+6HMYi55fOiXUgs=; b=ShSGSMByxrpY9MXCvzC+iYwEV5D3lQ7kahgYYruyVm7OlZEQcgzg2TaL7961d+yXfk ei4kb0+2O9W9eKY38tvRJ41khizJ1Slj3xDqgPAXrnjlx+O4jFeWIDplf+L5AVh7PPYN RLZPY1OrhG3UhnmwOU/HxGsfw0LQCacZRc2LNOJT9SCC4bOAowtFBictD/BQ6qo2s9OK /weq4HeT2q0dQiQSQFpopW6bfHsMrmvvnFKHxpkzCaVGtwmukwK/IRxXqwCDqtjAwhjq y370l4kRRoDGfkxRsbHqligAxBZoqgvIROoya+5jtnM6GMuesJ+D7z441944Agcn8zOC 9TRA== X-Gm-Message-State: AOJu0YwCBOUc2gzdmkdJvyjh/oyBS3pC9rG5+JLMDDS2F7X2aAY2xWFL 5TIKOvovg4iFFb4gLt99VosJ5U08K8L7cqAio+nSXpp6iNLj2DaRaneG96r74FxACE7vDK5A4eQ nK0yo X-Gm-Gg: ASbGncuLwHx72rrlIBOC8LXUjx9NggRF0wLvNk7A4XDdzKGrJg2m4AAuGTzpOQFHUhB s9bUAzXdqc7G7jlUo7TuGKeRj2yk+0GUfXOA0qs+anloCjTQ3UTrONUPn2RXgyccZiBqaRikyRF 0ZHImdXsIhCcwb3Xc77h4jhhLc4H6aeNwXzE/lAS+MMEJhdIvOj2CqNW06voSD1iVYM9XAGUuYN pkDyUn9lTT8NWcKFFctb4dJWFnusVaosas09a9r4WaP6bo9oHsgz6gN+bIzKjWoscbN2JviueRF 5br5Hh0HbFDDVM/iLDulH27vdspgzISerLp55SdsxkmQD/4yUdc+FGgV5ZfRXKVS53TNVlXqCER VxB4rzKOtniIq3VusJYBHfjBRS9dehho8vAJtpKUAtkmgglte0ZKMUyYqHusscg7Pg5aK7gNE39 svhn0MRlsz+gK9izVD2q8fuV8keeGXoVW5gsd8L2LVUshaAbSsjII1lDo8TT0NNpeTdwtswhoT5 pU3tX26qE4= X-Google-Smtp-Source: AGHT+IExLNGGOMPxlFZBucMiTx7Li0FQ+LMi3DGtr6XS4648VroCdhrT9sO8/o8KnNnNbpm4wLXwXw== X-Received: by 2002:a17:907:7e88:b0:b04:97a2:64f8 with SMTP id a640c23a62f3a-b1bb86d78famr689615266b.2.1758210767474; Thu, 18 Sep 2025 08:52:47 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-56-38-125.retail.telecomitalia.it. [82.56.38.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b23a1227bacsm60449766b.41.2025.09.18.08.52.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Sep 2025 08:52:47 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Frank Li , linux-amarula@amarulasolutions.com, Dario Binacchi , Conor Dooley , Conor Dooley , Dmitry Torokhov , Javier Carrasco , Jeff LaBundy , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-input@vger.kernel.org Subject: [PATCH v5 3/6] dt-bindings: touchscreen: add touchscreen-glitch-threshold-ns property Date: Thu, 18 Sep 2025 17:52:31 +0200 Message-ID: <20250918155240.2536852-4-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250918155240.2536852-1-dario.binacchi@amarulasolutions.com> References: <20250918155240.2536852-1-dario.binacchi@amarulasolutions.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add support for glitch threshold configuration. A detected signal is valid only if it lasts longer than the set threshold; otherwise, it is regarded as a glitch. Signed-off-by: Dario Binacchi Acked-by: Conor Dooley --- Changes in v5: - Add Acked-by tag of Conor Dooley Changes in v2: - Added in v2. .../devicetree/bindings/input/touchscreen/touchscreen.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/input/touchscreen/touchscree= n.yaml b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.ya= ml index 3e3572aa483a..a60b4d08620d 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml +++ b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml @@ -206,6 +206,10 @@ properties: =20 unevaluatedProperties: false =20 + touchscreen-glitch-threshold-ns: + description: Minimum duration in nanoseconds a signal must remain stab= le + to be considered valid. + dependencies: touchscreen-size-x: [ touchscreen-size-y ] touchscreen-size-y: [ touchscreen-size-x ] --=20 2.43.0 From nobody Thu Oct 2 09:21:27 2025 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CEB743168FD for ; Thu, 18 Sep 2025 15:52:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758210773; cv=none; b=m7MG8MElI+QD1poGoiyOKRdhFcF7TAk/A5foduXQWhsNLpB0CuFSGtrTrAxvcZV4cnD6v0t4uWIdjHhYKrfhmNsDXpx/3HOTkkPggKMmTzxz8COAiN+WsbhtsppY95EX7SFUZRmNhxIjxXL6iAXP5BYEs1b7JLB9JwEowvoDXXk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758210773; c=relaxed/simple; bh=bKYvTL8MbcZirvGbcTLtImf+31bpwxjEuwrssdUZtAo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bNBavlBUX5lgHkqOCrI/PZj4oQlNFPBS+i33QbK3fESUqxG2cVKLcQw5c/IbWZdkfzkquRvevhQIrs2zt+1gVBMk40EFTOpEffiHc/IyIzawxZpbywEeHzIBchcXzhgalTFe4/ZXMCBr6bv8d8/THzrUQnWsi/lOgVdXOgjQHVY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com; spf=pass smtp.mailfrom=amarulasolutions.com; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b=Uefhcdmo; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="Uefhcdmo" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-b07e3a77b72so319879366b.0 for ; Thu, 18 Sep 2025 08:52:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1758210769; x=1758815569; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9lcdJmzD84uDfab79lyqxcqnmMvBiautmvBU6m3EhEI=; b=UefhcdmoBtjBwTbpcnAf2ErmCwikynF09gDihaFdzPqKJ0v2Mzm8yS3yV96nujBc6I PstEwlyp2ljv5LlCQGlPSujTgyxGC2bSltrJOGUuOUhPkp8wsmSAhWqBSlAYWOUgH/Mo ENwSameNP8fNnt84kP+QLOAhwQkiaEWAQ71J0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758210769; x=1758815569; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9lcdJmzD84uDfab79lyqxcqnmMvBiautmvBU6m3EhEI=; b=nWGJ8PVKf2niYsSDvsa0gb7jehWwshvIkghuwuekTYV5qpYe289gt8K2FHcvmGuuac sQh6A5LigluR0zOj1CwI5BRVyfX3u4plFoE66ddMAQ74sbxWUZH2JNtNxpD5oBCBYuxC nYSeEVxSwC1yhlnpCwa6qsxeZP0Gv6NXRcKeJ9jxVcU6Qh/fqcoEx9G22P7jEEnX071E OGHYjZLB78qqBEgzRpPCt6Nwy4FcHyB1cpzyaSO/dSig+okofQeH11u8SgxaREn/OqR1 52hNXOfxUDOquaP41vKmC9HKW2DEjXtw1RORKgIdrgPja45foLR4+35OV7A8PNabBxsz FKrg== X-Gm-Message-State: AOJu0Yz7oIz3gVwOdCdCA3hnw4Jjci1ypPcgGaShvKCOoobeUAr4ALdP GJ24RWJgJHEur/sgpYJGHMV2qpzyjL3uMZVp2PjB2BOhUnZTijJd4UgXxvGJOS+l3DVd/djoun2 aI5S4 X-Gm-Gg: ASbGncuuyqPf1HMtGYShd7r0OXjO3xnq0Tn9nlCv6M2RoNHoc1jOR49+AAoP9eJoIcZ KIsC6A41JBJsxY929LL/RnTudZa+LCyFmqSbN6kon5mp4TzY1R09BbgJIaegmfmUvaOVknOTOPD Iwy5ZvyUMHw4EDM8ofgPk8prygqQzTAc1cwRSToooVKMmPqHb/g9SgMiG04HrYnCUClyYtU+UUL S95MMTXFmHseGhFL17wVrIxWECnzquOafIulm5vpPPW17alwjh5QcToefOcI6ITvRDkHslj4Cn0 WBnbG0FErTvJiRnOP7uG/a15LCb6orNIm0ve5tmDCHf6zoTkkr9LqQPGILuDp39XbsRJhtThbaZ s060+5VKw9PRw+Oecvpixa91AnzqMCLxS+OxP+yXC+PnRd9N05ehTu+KGCodFPJ/UJd7IG5mgmS 9R6fm0/H308ASLemhG3Al8+Hm3AW/Vg1B9pMkOmhdg9lCeJHfAWQZRZLaSIveyj/53h6xq0ic3P UJ4IdrPtkA= X-Google-Smtp-Source: AGHT+IErelZCb4Ng2hNIph4lDPD33ehWDH5J7iXux+fMT/vxxySG4ibwfi79WajSIooQhiHJCIIbVw== X-Received: by 2002:a17:907:934e:b0:afe:ef8a:a48b with SMTP id a640c23a62f3a-b1fae7a9b82mr410713866b.30.1758210768899; Thu, 18 Sep 2025 08:52:48 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-56-38-125.retail.telecomitalia.it. [82.56.38.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b23a1227bacsm60449766b.41.2025.09.18.08.52.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Sep 2025 08:52:48 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Frank Li , linux-amarula@amarulasolutions.com, Dario Binacchi , Conor Dooley , Dmitry Torokhov , Fabio Estevam , Haibo Chen , Krzysztof Kozlowski , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH v5 4/6] dt-bindings: touchscreen: fsl,imx6ul-tsc: support glitch thresold Date: Thu, 18 Sep 2025 17:52:32 +0200 Message-ID: <20250918155240.2536852-5-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250918155240.2536852-1-dario.binacchi@amarulasolutions.com> References: <20250918155240.2536852-1-dario.binacchi@amarulasolutions.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Support the touchscreen-glitch-threshold-ns property. Drivers must convert this value to IPG clock cycles and map it to one of the four discrete thresholds exposed by the TSC_DEBUG_MODE2 register: 0: 8191 IPG cycles 1: 4095 IPG cycles 2: 2047 IPG cycles 3: 1023 IPG cycles Signed-off-by: Dario Binacchi --- (no changes since v4) Changes in v4: - Adjust property description following the suggestions of Conor Dooley and Frank Li. - Update the commit description. Changes in v3: - Remove the final part of the description that refers to implementation details. .../bindings/input/touchscreen/fsl,imx6ul-tsc.yaml | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul= -tsc.yaml b/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-= tsc.yaml index 678756ad0f92..1975f741cf3d 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.ya= ml +++ b/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.ya= ml @@ -62,6 +62,20 @@ properties: description: Number of data samples which are averaged for each read. enum: [ 1, 4, 8, 16, 32 ] =20 + touchscreen-glitch-threshold-ns: + description: | + Minimum duration in nanoseconds a signal must remain stable + to be considered valid. + + Drivers must convert this value to IPG clock cycles and map + it to one of the four discrete thresholds exposed by the + TSC_DEBUG_MODE2 register: + + 0: 8191 IPG cycles + 1: 4095 IPG cycles + 2: 2047 IPG cycles + 3: 1023 IPG cycles + required: - compatible - reg --=20 2.43.0 From nobody Thu Oct 2 09:21:27 2025 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 244FC318132 for ; Thu, 18 Sep 2025 15:52:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758210774; cv=none; b=IT1V+McPwbhdiEcr675axB0YxXzHGjUKEb6dLQD2/rtV2Y45BQz5opnyssLACbGLVOfIXUAgf/nTLKQdaksF0oMG8r7tYiXLcLinCNvNiRlaf+znIQZUooalRt39d22fzqu2egtEkM+oGa0GRV27tZB3clyCrYBG3t1cMTHwtd0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758210774; c=relaxed/simple; bh=gGgLDa28x4UcF2lKFBKasKuonH4sgYz1s6b2kl6Iy4w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=roDKBTGWCLgBspaVLUrIrzAbeJTyDab3ynjLKLeiHv1HHL40h1PD25dme7biwMaNSzUQ3EHsNnmwM40IfrBbM8sa19hibJmHuT0NrST2fEuE4I1lAiEVXZNkSTueo3HJOb888duoP0zaux5EuUq5QNNRlDvNoqKJM4zx8mYL3+8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com; spf=pass smtp.mailfrom=amarulasolutions.com; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b=cJCirYTE; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="cJCirYTE" Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-61cc281171cso1611360a12.0 for ; Thu, 18 Sep 2025 08:52:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1758210770; x=1758815570; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KC1/Z5A4C1NKjQ4MKJ5mwlwDtHXXOD1eqAPkjlkCE6Q=; b=cJCirYTEA3K8X3dsOlNOqFFbdojIpJR2mG+/OuhKlkofA+JdMdIKIhBA/EV8GGxF2h Yh8WcgLjSxSDfrC+BfeFff77H4XIgNmQLGfC4QfAv8uMCExkkPjHHp5LcpN+V6FFnjUI edpHHLSTCX9oOf/YPmtRfrpNtIOIOzDztueg0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758210770; x=1758815570; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KC1/Z5A4C1NKjQ4MKJ5mwlwDtHXXOD1eqAPkjlkCE6Q=; b=BXsNUn4rJbZoDTljuADXQpTNENrgIkPkwg13iWZTs80Db+hsTmUXD15Y84iF+9824W pFUhQWiS01eHKlq9jUEInMBHLz1L6IVDptSDh7WLTIUsCNGbExnKS7Ovn7/8ofsxCNC3 aw/n6pSLGwmcQUlzOG1xgn8qpsZzysiu6Ovxar23g6/+S2ULfLKk9CoomkNI+XykOczb s+G2wuRAetCV9rv6gingBn8K7ZM2x3/IhgopAAZiPA0M+uudABwRMbYgB1/7inL9mii0 s51cAiPDbYc4/OTHIIFX0rwlQnetgwt4kwP4b+7WI1+Ul+dom65XmG5F5es0blJw/jSa aQaQ== X-Gm-Message-State: AOJu0YysxMCgZFhMWB6s6rn9+LhmQzkSpj/vslTRtyQXQI40OQgCMv0V HUWBUqbApaAjviJ6L6O2udYyiH4TMUoZ6Q/73rV6Umius56KM+q896xlxm7p3Koi0hezTReLuXS A6aIy X-Gm-Gg: ASbGncsNsZYT5R1s8s9my/UG098kKvcyeyeThc0npfr5FTjJezEkqOGKlYajyjOmUv/ kSwD9lXRq+dVtOd6mD+92MMIA1RthFfrukTajiUTSec/ptQwVm0iJDzxAvfnfy14lbhLjctDn+F ILGpvbnI73xmmOMtCAERBB+cWV/kdOk1WzkW87CJDcTiaXD3BXZcYfSfZKw7P8H/p9jnFuh5qm6 U4TTKTYOACgfo0pAhtiFEQH5x+lmIX7Do6wqXI+pBdCrWMDycXGc9mWxwr0cxnyOcPxNXlYlNyF +pvnssUGp1fNuaqXRJUR17EBMeiwdcYkxzoaO0HwqmldBR3LGT80Y9Vmm5FXXqC/esFPO0BRGfU yNVdjHKkUXHtXWj60qqAO8uTKAwaxobfk1LQBTklfhh2vede8ECLpiXrq0h2pAg/N0/glTxuZOm VyEL5yZ2cM82sfwORPQ3PuoIb4QSFu1D3B5UD2E5FVZ1MUYNGF+Lz39a5+hS4eUI2w09tN9rnuK /bgcEupXmw= X-Google-Smtp-Source: AGHT+IHrrgs1HJChTIyvAVV8Pi6aonRsXlQC1gliMmMRrY60B3FFWCvZ01egkSmZM0VTAEb3+in5cw== X-Received: by 2002:a17:906:7310:b0:b04:858e:c1ee with SMTP id a640c23a62f3a-b1bb5e56d90mr782962066b.2.1758210770121; Thu, 18 Sep 2025 08:52:50 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-56-38-125.retail.telecomitalia.it. [82.56.38.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b23a1227bacsm60449766b.41.2025.09.18.08.52.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Sep 2025 08:52:49 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Frank Li , linux-amarula@amarulasolutions.com, Dario Binacchi , Conor Dooley , Fabio Estevam , Krzysztof Kozlowski , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: [PATCH v5 5/6] ARM: dts: imx6ull-engicam-microgea-bmm: set touchscreen glitch threshold Date: Thu, 18 Sep 2025 17:52:33 +0200 Message-ID: <20250918155240.2536852-6-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250918155240.2536852-1-dario.binacchi@amarulasolutions.com> References: <20250918155240.2536852-1-dario.binacchi@amarulasolutions.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable This way the detected signal is valid only if it lasts longer than 62 =C2=B5s, otherwise it is not sampled. Signed-off-by: Dario Binacchi Reviewed-by: Frank Li --- Changes in v5: - Add Reviewed-by tag of Frank Li arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea-bmm.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea-bmm.dts b/a= rch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea-bmm.dts index 279d46c22cd7..f12084d8f2a0 100644 --- a/arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea-bmm.dts +++ b/arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea-bmm.dts @@ -154,6 +154,7 @@ &tsc { pinctrl-0 =3D <&pinctrl_tsc>; measure-delay-time =3D <0x9ffff>; pre-charge-time =3D <0xfff>; + touchscreen-glitch-threshold-ns =3D <62000>; xnur-gpios =3D <&gpio1 3 GPIO_ACTIVE_LOW>; status =3D "okay"; }; --=20 2.43.0 From nobody Thu Oct 2 09:21:27 2025 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61DFF3191B5 for ; Thu, 18 Sep 2025 15:52:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758210775; cv=none; b=sty4aWPKJDmcj73gfZna0imDFiKFNb3jsAA/VRon4+T1Td41QMmq3/fJePWMcYWOCaie7we7Kfu9vti4fNh6aoRfHztxfPNQEvv5XU8HWVPxIsXUwGKyiIIV0Qsunk3c1rtDzRp1v8f5oVM+ZFEnI+GoYJsAy4ugzLp//MXZU6E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758210775; c=relaxed/simple; bh=yv6FeFDp/A6lsGDbam0/SBW6Pnp8tVcvuRDKL2ma60Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=IWV60SzTrwfZQUndykUNv3ci4MOtF2GjLSpHt72kWjsET+bW03ofH1EOLZ4StMWdq4v0tpvlgO8LbnXm377bmbc9+K2KZ4bz1sQ7AJ27gf2+2ZT/zd7KjAqfTcIXOr2W6Lk9C/OZBp/dWoirDHh48+Be6IpoJnuhqndQn2Iimak= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com; spf=pass smtp.mailfrom=amarulasolutions.com; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b=gGfEm5vu; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="gGfEm5vu" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-b211ccfda1dso144034466b.3 for ; Thu, 18 Sep 2025 08:52:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1758210771; x=1758815571; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=K/20C6aqh7jqDUANzEy0rtZwUuYaJgtco0TQqT9aNmo=; b=gGfEm5vuOtREUjvUTpJ3mnQVWPak1L6q9qMujLasn+gAwEvF0h9oOym+JWfgHUbMbk HiAglOFR2u9KG9d1ueCDwUlIEgTTI7C8EGOZXGSTJksOG5hfMQXRKZXrljlM36AUqvTH LRkNHOVvGaa/u2WbQetdD6s5FVTtmE9JN4kXA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758210771; x=1758815571; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K/20C6aqh7jqDUANzEy0rtZwUuYaJgtco0TQqT9aNmo=; b=pW3MqKAhFko6H6j9IPHHzqRzr7Rw2F7RhqSfu75JLJA8DJ1VmW6z6ydWWUaEgjxMIN ugWFN3YL0W02mkFMTNjExC5GxojQd8/gzbBpDLLiym3PIs87kHmxTElXSopGjv9oWjys kIwQ+XnNpCij6uHIajV4m+JRv+whEGNmY8fxchke/3QXLtsiaKH+1eDh9CsOrAfzQZRm gOX+LN/qSK0tMkmhSANEhgYWf5dKkk/tmtX3Ls/IS+Rm9wTAQ6XTEU4kDvrl0n2QN5oX c7U1vxRImAY0g1bh1wml4Kx+ZJLhQcOr63Al+YcxXHAKSSy5OZZiZRuwTU7QikdT8yRC nt+Q== X-Gm-Message-State: AOJu0Yxlxml27avc6I4cUHFKlkxTB1lN98uela5q7oXV3VgLdGYJAo6d /1x5l/AZ6qYFzJ/xngiqN0P58SdLDWDQvtstZS2tEvdsMqrjDJOV17rELavBIXx6q0SHBZHklpW enI5L X-Gm-Gg: ASbGncus0DPsPEFFhkTfSPUII3+RZT8KA+N55NCoY2asmywnbABfwBhBMm7i8snQ+ea /P2isCpDJwhfhndfW553oCJy15gsU93BEDHDlOoA3iqh3+rWGRPpJ2NejKhUm27VI2mCSvPfc9X Tx5hJ0w1st1dTjIpV25Z2a2ItnpwvHc/eVEjEIN6CLzBVLTDERC2L/hSg+13b483TH5ruw+xZaT NcWQBdGW3OAhFUmRkkHN3DhsaJUfyb3EQR42Jf4XHcRk4wus/R2V1eIRGPoR9zvGN87hJ7SF0Jv GAnglM5i+iCBqWZhQNQ/ojd93lXbbLHlBtYooceK9sz53AURE2ia0kjSVW0HBy6AAMy4O+nwmnw w3ZzhBbqX/UjYcXwj2k+bVdKTNNJvNcQUKW0Bl5Qj/R/KK3GvdoGkmaaZEFgoVFyOxvc0PknM87 cTuqGzCzINWivqItnnYfoaMGV0YRYMoyRI4oYKdLf8sdN/d1ykIr2HNy1nCtzZXzvWesDi5ZgZP 2BrNC79JGg= X-Google-Smtp-Source: AGHT+IHdHnn6wGZnvdSsol0igEGKm/m7Cc1hmskwoyS0/5RbE78pl/2ywFREK0jIWPVIywFZyPEDcQ== X-Received: by 2002:a17:906:730e:b0:b07:de95:1c70 with SMTP id a640c23a62f3a-b1bc02f66d5mr759256666b.31.1758210771452; Thu, 18 Sep 2025 08:52:51 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-56-38-125.retail.telecomitalia.it. [82.56.38.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b23a1227bacsm60449766b.41.2025.09.18.08.52.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Sep 2025 08:52:51 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Frank Li , linux-amarula@amarulasolutions.com, Dario Binacchi , Dmitry Torokhov , Fabio Estevam , Michael Trimarchi , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH v5 6/6] Input: imx6ul_tsc - set glitch threshold by DTS property Date: Thu, 18 Sep 2025 17:52:34 +0200 Message-ID: <20250918155240.2536852-7-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250918155240.2536852-1-dario.binacchi@amarulasolutions.com> References: <20250918155240.2536852-1-dario.binacchi@amarulasolutions.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Set the glitch threshold by DTS property and keep the existing default behavior if the 'touchscreen-glitch-threshold-ns' is not present. Signed-off-by: Dario Binacchi Reviewed-by: Frank Li --- Changes in v5: - I didn=E2=80=99t remove patches: - 2/6 Input: imx6ul_tsc - use BIT, FIELD_{GET,PREP} and GENMASK macros - 1/6 Input: imx6ul_tsc - fix typo in register name even though they were accepted, to avoid generating conflicts detected by the kernel test robot. - Re-work the commit message - Add Reviewed-by tag of Frank Li Changes in v4: - Adjust property description fsl,imx6ul-tsc.yaml following the suggestions of Conor Dooley and Frank Li. Changes in v3: - Remove the final part of the description that refers to implementation details in fsl,imx6ul-tsc.yaml. Changes in v2: - Replace patch ("dt-bindings: input: touchscreen: fsl,imx6ul-tsc: add fsl,glitch-threshold") with ("dt-bindings: touchscreen: add touchscreen-glitch-threshold-ns property"), making the previous property general by moving it to touchscreen.yaml. - Rework "Input: imx6ul_tsc - set glitch threshold by DTS property" patch to match changes made to the DTS property. - Move "Input: imx6ul_tsc - use BIT, FIELD_{GET,PREP} and GENMASK macros" patch right after the patch fixing the typo. - Rework to match changes made to the DTS property. drivers/input/touchscreen/imx6ul_tsc.c | 26 ++++++++++++++++++++++++-- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/imx6ul_tsc.c b/drivers/input/touchsc= reen/imx6ul_tsc.c index e2c59cc7c82c..0d753aa05fbf 100644 --- a/drivers/input/touchscreen/imx6ul_tsc.c +++ b/drivers/input/touchscreen/imx6ul_tsc.c @@ -79,7 +79,7 @@ #define MEASURE_SIG_EN BIT(0) #define VALID_SIG_EN BIT(8) #define DE_GLITCH_MASK GENMASK(30, 29) -#define DE_GLITCH_2 0x02 +#define DE_GLITCH_DEF 0x02 #define START_SENSE BIT(12) #define TSC_DISABLE BIT(16) #define DETECT_MODE 0x2 @@ -98,6 +98,7 @@ struct imx6ul_tsc { u32 pre_charge_time; bool average_enable; u32 average_select; + u32 de_glitch; =20 struct completion completion; }; @@ -205,7 +206,7 @@ static void imx6ul_tsc_set(struct imx6ul_tsc *tsc) basic_setting |=3D AUTO_MEASURE; writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETTING); =20 - debug_mode2 =3D FIELD_PREP(DE_GLITCH_MASK, DE_GLITCH_2); + debug_mode2 =3D FIELD_PREP(DE_GLITCH_MASK, tsc->de_glitch); writel(debug_mode2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); =20 writel(tsc->pre_charge_time, tsc->tsc_regs + REG_TSC_PRE_CHARGE_TIME); @@ -391,6 +392,7 @@ static int imx6ul_tsc_probe(struct platform_device *pde= v) int tsc_irq; int adc_irq; u32 average_samples; + u32 de_glitch; =20 tsc =3D devm_kzalloc(&pdev->dev, sizeof(*tsc), GFP_KERNEL); if (!tsc) @@ -513,6 +515,26 @@ static int imx6ul_tsc_probe(struct platform_device *pd= ev) return -EINVAL; } =20 + err =3D of_property_read_u32(np, "touchscreen-glitch-threshold-ns", + &de_glitch); + if (err) { + tsc->de_glitch =3D DE_GLITCH_DEF; + } else { + u64 cycles; + unsigned long rate =3D clk_get_rate(tsc->tsc_clk); + + cycles =3D DIV64_U64_ROUND_UP((u64)de_glitch * rate, NSEC_PER_SEC); + + if (cycles <=3D 0x3ff) + tsc->de_glitch =3D 3; + else if (cycles <=3D 0x7ff) + tsc->de_glitch =3D 2; + else if (cycles <=3D 0xfff) + tsc->de_glitch =3D 1; + else + tsc->de_glitch =3D 0; + } + err =3D input_register_device(tsc->input); if (err) { dev_err(&pdev->dev, --=20 2.43.0