From nobody Thu Oct 2 11:50:18 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D5C22E3AF2 for ; Thu, 18 Sep 2025 06:49:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758178168; cv=none; b=OfwhkwSr9pdMrJIfaroUYHk/7zZohk+faR7ZKlomnsxW5Psz4KszHeU4O0Rbq9k+YhsFL3ZOtD31N1U3v4BrKpIVvjQwiiUEco9KAqJ9ad5KsnpX/Pv7AOpIkV52y57lMlQvrVUx5dLNGdwvf6ZIqnSOUFJ5+f+D8KsUw63Q10A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758178168; c=relaxed/simple; bh=+IOLF0XPvUULiaKZhdl3sSn55zuFmc8DaivaubnewwY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=qgVZeDucU+uaScNGnPuHuRfB25bGCGCyAGMaPaczYe4uH+gCqLCuZ9qVYzMeG12WtHGwgVsutr5i1KTsIA+6RqYdYvsNXyUPFE+DGeVHp0elv6qhj0sRsnMdsWNMbdwcXTQzd6a9QbKoiZsGUxb6E5pEmW9PESdkqSyl49hQxLI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=A3XYrLCV; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="A3XYrLCV" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58I0SaZ9003340 for ; Thu, 18 Sep 2025 06:49:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=QmS6oCHS+MH N39AhLGTMSeGEuEf2T3uv/XWwxaYqPAw=; b=A3XYrLCVG+VL82KO7BbccmXUYH5 b43GANxPmYdJhedIxu18nrKLC5d60hAJwdhFZjYNGxqiH7YM6CH/h5eYu9CEsrqc IC3Xs7DAMydACTSVQYnJ2YfRFe7heeGuOGIb2tEH8yhNcwGBgUPUurMx0MTzqojt Cv7Giieya2wzlWQfLsCLWddaKZ6A8538jxQAXxIifl/XK9q6iHaOj6LCcm2jJvD1 jmZ2RpyslYLpRuJu2GRm9ufXb0UjW0Dr+DZCALFSBzuQHUA0hrBPw/PIRaOM8pK+ EGT/P/S45SlIUSemKLuKwh/s7/7XGFWgtaOwE/HmzifRD4FvYVqIu3+HhXA== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 497wqgtth5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 18 Sep 2025 06:49:25 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-77621c54731so854691b3a.3 for ; Wed, 17 Sep 2025 23:49:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758178164; x=1758782964; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QmS6oCHS+MHN39AhLGTMSeGEuEf2T3uv/XWwxaYqPAw=; b=n+LJnA+NHANSDz6S/WxIWr7w0zgCEhHcAAHMG9x/EhHIHTKrEEmnDvT5vBarJQ439D ebKsAGXcY7AiyAzTAXQmMxcVbtuxbyzqli0vI3cw1LJogYShYNHovxOeJzKAYe5Byonz 95DlNWTsO0YxKqRP9sllyJqtiGyG921VdLL1NQmGcq1U4LyxL85WeynF7/M38kxM0Fir ejZbBrfRmsRu3QCQTsr2Fi3A8uhMARHDoDgzveWCznH1Y80SwJ2OmQcddh1zIIzjvJCw ViepbhLizmWM0vSNDnqV2YVvYK4PUXIahsGUI/kipGWftAYkQjCpvbk3Upikwo7OjBQO qnGQ== X-Forwarded-Encrypted: i=1; AJvYcCVs2Ayn4Qfh8KdEkHtwlkobTANx2aqFj+UTg4qFbahXFCxrTnCS4fEXML4DZbc/+EEAdUu2OET6jGXQtww=@vger.kernel.org X-Gm-Message-State: AOJu0YyP5XAkJGbsfCbPfMm2LjIryY7hJcEIy8trLNLZdYPVmA3Cp4Y6 1fW31oEcWZXfYOyl49t+ozBTbyCco4+9DVilSkLGGyQwCrhRWHOJzBiopBs13LL0LErmfrp6/I+ SbRW24NE8ejhWP54vXKLNOymIhVZ7Q+npMB++jJCgFPYBS4CguCx4EZ7ZFP9mB0mAllY= X-Gm-Gg: ASbGncvtUVy4gkcXVBvNyisgQ7yImCHLK5BsNSAG51RRQR++KnfZPHJE+yQm8Ih8t6E FDC/5nDIZ3OoOwfyorL6Y6wl5yvuICaEbO+XwihhhtWDERmp1z7IfmxedFaXdhjrfiSIxvvZ+KA kXOiwml0m22oyqyng9CG2qcetcWJdOI5w25k9iNYfMf+LS5bbSrMqLSHCuLADZJPs0n9GBXVsQm UDmbxgpNmlMH3cnesURqmOvoorlsyk5Qlm0USShI55e0tUxtTUJBNUsBRYFmY6yjd33r4SnlV8/ XAWg+11ymCR28CM2f+RhDnO31X/SVL5qqhSECx6JqO3Iu26H8x70YjpQIATnmvXL7Xuz9diIbVY a X-Received: by 2002:a05:6a00:18a2:b0:776:2e3:a95b with SMTP id d2e1a72fcca58-77bf72cb98cmr5744825b3a.1.1758178164096; Wed, 17 Sep 2025 23:49:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEGukSBl0fOY+Q+OdY68Z3vITk6rVt7kdWoKiAb3EkNyvnFx81Fn4rVDEc00foqitvN18kvpw== X-Received: by 2002:a05:6a00:18a2:b0:776:2e3:a95b with SMTP id d2e1a72fcca58-77bf72cb98cmr5744803b3a.1.1758178163666; Wed, 17 Sep 2025 23:49:23 -0700 (PDT) Received: from hu-vdadhani-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-77cff22bdb5sm1356789b3a.94.2025.09.17.23.49.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Sep 2025 23:49:23 -0700 (PDT) From: Viken Dadhaniya To: mkl@pengutronix.de, mani@kernel.org, thomas.kopp@microchip.com, mailhol.vincent@wanadoo.fr, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linus.walleij@linaro.org, brgl@bgdev.pl, linux-can@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: mukesh.savaliya@oss.qualcomm.com, anup.kulkarni@oss.qualcomm.com, Gregor Herburger , Viken Dadhaniya Subject: [PATCH v4 2/6] can: mcp251xfd: utilize gather_write function for all non-CRC writes Date: Thu, 18 Sep 2025 12:18:59 +0530 Message-Id: <20250918064903.241372-3-viken.dadhaniya@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250918064903.241372-1-viken.dadhaniya@oss.qualcomm.com> References: <20250918064903.241372-1-viken.dadhaniya@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: k1qoDjefBgz2oVKkgDHHHxqIOsQO6HWS X-Authority-Analysis: v=2.4 cv=HITDFptv c=1 sm=1 tr=0 ts=68cbab75 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=yJojWOMRYYMA:10 a=8f9FM25-AAAA:8 a=EUspDBNiAAAA:8 a=lCqp9tVl3zhOgjhhuWQA:9 a=zc0IvFSfCIW2DFIPzwfm:22 a=uSNRK0Bqq4PXrUp6LDpb:22 X-Proofpoint-GUID: k1qoDjefBgz2oVKkgDHHHxqIOsQO6HWS X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTE3MDEyOCBTYWx0ZWRfX3e9zLVkPWpKu k444n21/P6A1TOlQG2awSTT8JkE8LbsQeOxvt63cV4fK1CbpLk5FHeMePZG1ys9/LmVlWNYMIH1 k1K7dDk977UgcSAjBka9gjEjcMHlTwVvx4oyYqmLho+hEbcuzCb5yJCfOPS330yi0kIiV+bLam8 1sBloWgBkP8h/M5epyHbaza66fI0Ekh21D7MABwFQkbXl874Ie55uaXI/Y8QPm6sVn7KrAtiWxb yKZPhXMagebnlTBmn/f3yka6QL4QD6lHfCtDKwJ5LmNd05y16kXMtO1GBYliFUWducQkivCIHKa wvlo3u44nrU4f/R3jqHlrQA7ffngyQHSjG4os4M7bhdpyp2CRJigg6tgRx1msPxhetZkhkPjwkr 5Yjx72s2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-17_01,2025-09-18_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 phishscore=0 adultscore=0 bulkscore=0 malwarescore=0 impostorscore=0 clxscore=1015 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2509170128 Content-Type: text/plain; charset="utf-8" From: Gregor Herburger This is a preparation patch to add errata workaround for non crc writes. Currently for non-crc writes to the chip can go through the .gather_write, .write or the reg_update_bits callback. To allow the addition of the errata fix at a single location use mcp251xfd_regmap_nocrc_gather_write for all non-CRC write instructions, similar to the crc regmap. Signed-off-by: Gregor Herburger Tested-by: Viken Dadhaniya Signed-off-by: Viken Dadhaniya --- .../net/can/spi/mcp251xfd/mcp251xfd-regmap.c | 25 ++++++++++--------- 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c b/drivers/net= /can/spi/mcp251xfd/mcp251xfd-regmap.c index 8c5be8d1c519..e61cbd209955 100644 --- a/drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c +++ b/drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c @@ -12,14 +12,6 @@ =20 static const struct regmap_config mcp251xfd_regmap_crc; =20 -static int -mcp251xfd_regmap_nocrc_write(void *context, const void *data, size_t count) -{ - struct spi_device *spi =3D context; - - return spi_write(spi, data, count); -} - static int mcp251xfd_regmap_nocrc_gather_write(void *context, const void *reg, size_t reg_len, @@ -47,6 +39,15 @@ mcp251xfd_regmap_nocrc_gather_write(void *context, return spi_sync_transfer(spi, xfer, ARRAY_SIZE(xfer)); } =20 +static int +mcp251xfd_regmap_nocrc_write(void *context, const void *data, size_t count) +{ + const size_t data_offset =3D sizeof(__be16); + + return mcp251xfd_regmap_nocrc_gather_write(context, data, data_offset, + data + data_offset, count - data_offset); +} + static inline bool mcp251xfd_update_bits_read_reg(const struct mcp251xfd_priv *priv, unsigned int reg) @@ -64,6 +65,7 @@ mcp251xfd_update_bits_read_reg(const struct mcp251xfd_pri= v *priv, case MCP251XFD_REG_CON: case MCP251XFD_REG_OSC: case MCP251XFD_REG_ECCCON: + case MCP251XFD_REG_IOCON: return true; default: mcp251xfd_for_each_rx_ring(priv, ring, n) { @@ -139,10 +141,9 @@ mcp251xfd_regmap_nocrc_update_bits(void *context, unsi= gned int reg, tmp_le32 =3D orig_le32 & ~mask_le32; tmp_le32 |=3D val_le32 & mask_le32; =20 - mcp251xfd_spi_cmd_write_nocrc(&buf_tx->cmd, reg + first_byte); - memcpy(buf_tx->data, &tmp_le32, len); - - return spi_write(spi, buf_tx, sizeof(buf_tx->cmd) + len); + reg +=3D first_byte; + mcp251xfd_spi_cmd_write_nocrc(&buf_tx->cmd, reg); + return mcp251xfd_regmap_nocrc_gather_write(context, &buf_tx->cmd, 2, &tmp= _le32, len); } =20 static int --=20 2.34.1