From nobody Thu Oct 2 10:55:40 2025 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C8923191D6 for ; Thu, 18 Sep 2025 17:06:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758215220; cv=none; b=OHsG6SAvSAgoBGC5NUfloNRNLcOzeVZSS9kE/5mLbZRFrpegBQOPCsiWHI4LCL037nwRbM9oOKkn8heA//7KdL8KE64hNkmEn5DDg5FFsGB9DGWPZLKaikrrQwIerZS2zrto2DVTK6c7hzlpWHuEIkVjZx/l4A2dtKRNicsuzdU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758215220; c=relaxed/simple; bh=p0Y001LouGzRYgngGf5yjavclhIzGKKVPJlTdhfMZA8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HE1LsfFv786pRlv+ftJERU7l9m73UFwTdBxajoDuK8tYDRQpclabzQyqbc2w08SzsCfZHmzE+bmDl8vPjid95VVChjqEmplq3bWP8oI0aB24Dt708m7/5eD9NlntPjuEnxS6dU7ZBjPNSEO+RdvnRRggMSHqPccgOMdYFIO84P8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ePNcaYi0; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ePNcaYi0" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-b00a9989633so250787666b.0 for ; Thu, 18 Sep 2025 10:06:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758215217; x=1758820017; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=a/IIuik5CE+0p4i4XUTzTjvbxx21RfH5UCzEfl75uMA=; b=ePNcaYi0NYXJ594ciXRztGPdQJvh5G9RM0wTpkWOqYoHF2880HuUNKLN/rVBc3PcfD VvigLkzwZ1k+jOVEfO0xh/NJ79nNZfXPzIT4lPH/NH1GGo/qencca1OhlLoB8fmQVPwI /Hylgcl4ebdxjhy3rRSAILmC6uR/KEN8uubdnp0H+re/wOxoDJQ4RV1BVOXNCTj9LuT4 ldBw70i76Zpnpy3pO+42Rcmnf5oMcoTS/QbyFU67W59TiV+XvrcdaD32orQ9D6hEnDLN vBenGSoueXZ000MZ3NeWuhNsqTXX6DqQ8f05MTaXVrN74XuQHJ/jhzTmwdbxxXSTMOu7 HEGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758215217; x=1758820017; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=a/IIuik5CE+0p4i4XUTzTjvbxx21RfH5UCzEfl75uMA=; b=THGdR0FYe7X7P8vLzcyVKehzjWWLXTqPvMksLUyYJ0zNI1TO70+vKbTrxNf5kHTn+c 3L293R1MjLny3aktXyJ1wzw2znEMyBsd1iXSKvTIlE520GT03y2WGLBt85hUzXPOdiOG rrGWibmHZAZQq2Po/IIBmOQY86QCS44hfwmXTnGkyb1f7W6CTq43UdEeoIKya6+fjaxm cjIT9SYn7Ds2Xt2boWeSkeUbDRON9z5CooMeuGo1LFSHoK00VjkvKcOgr5QzfPl47jqG 1ITcSfLzP+XjqUpE43vGIpEcMID+6l6+f3hKXAgmUMf6FVN1UzqJiBghDryVlbLIK0si Ld3w== X-Forwarded-Encrypted: i=1; AJvYcCUlGVNQYVdGv+FG54vtrgTZ6VJQBmgJ6ZpofReA9mRxffozaYNbBm9M5Cw/lz1rpTf0TpNzNH8THB2JGk4=@vger.kernel.org X-Gm-Message-State: AOJu0YwuHGD/s+Whojt3ooUUeFPljMbx6VprQKnCDSlvO/Jxtn+M2fX6 dxR2PDo/2x0cXzuzQ/Mam0ZdsCu+QlS3jMeexHrR5pUJJlcKhtu8JIyF X-Gm-Gg: ASbGncswpt5Qw898m6Y+a8xuOF/+xobCn7PuoKVtNVZ6n6aXEWGUp3BrK4rUCr7+V+O 8WgIe3SuYtjqoXn1LQW2TcPRCgC4OeL5d6IR5/qStnC8a1gf2v2JYDeuFshSXHSO5dKDiHrhGcq zHyg8BvXagvRNCEmf3XwqZEl/DhP3b5qCodW3YuNyh+rZimh/bm0zJ01j8UAgYyGYD+rJZ6zNyt igfadOSzcxVm6vk7ToRCUWMXkiWSP3FE5hADYfFgJ1mwfTKrBufoqKGV8eyY/Lw4KcQSmsq1PKd v1/ecPepr3o2uLiGHA3xYPzjEXeYX+QiuclHxq9SJNd5xxofe5X1MpY0Ol7CmWgCpVwJhYaeMjF CkA5fjYDHhls4kPGSyl8iRpGfjpcuGH7XB3lXPEU= X-Google-Smtp-Source: AGHT+IFJXGsnfRuXnGhNyUp+s17bIwH2J9IJyICxXejXnotTF3zx54YprzQcXlmTDWODob125Eq0YQ== X-Received: by 2002:a17:907:6ea5:b0:b04:2dd0:98 with SMTP id a640c23a62f3a-b1faa41447amr487140366b.12.1758215216824; Thu, 18 Sep 2025 10:06:56 -0700 (PDT) Received: from [127.0.1.1] ([46.53.240.27]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-b1fd271f895sm225845366b.97.2025.09.18.10.06.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Sep 2025 10:06:56 -0700 (PDT) From: Dzmitry Sankouski Date: Thu, 18 Sep 2025 20:06:51 +0300 Subject: [PATCH v4 7/9] power: supply: max77705_charger: rework interrupts Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250918-max77705_77976_charger_improvement-v4-7-11ec9188f489@gmail.com> References: <20250918-max77705_77976_charger_improvement-v4-0-11ec9188f489@gmail.com> In-Reply-To: <20250918-max77705_77976_charger_improvement-v4-0-11ec9188f489@gmail.com> To: Chanwoo Choi , Krzysztof Kozlowski , Lee Jones , Sebastian Reichel , Luca Ceresoli Cc: Krzysztof Kozlowski , Sebastian Reichel , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Dzmitry Sankouski X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1758215207; l=3015; i=dsankouski@gmail.com; s=20240619; h=from:subject:message-id; bh=p0Y001LouGzRYgngGf5yjavclhIzGKKVPJlTdhfMZA8=; b=kJ8QFTSv9rLZNHYA6EG0iVEYoNxQCaZcTUPSXBqboxBpRWBLw6i2RPDq64r+FWBOvjL87ZKaV b6k/tDBpI3YDnCZiOnlWXTDimwI6jeyX8WHFHmU9SyOhmK4sBi8Z5d5 X-Developer-Key: i=dsankouski@gmail.com; a=ed25519; pk=YJcXFcN1EWrzBYuiE2yi5Mn6WLn6L1H71J+f7X8fMag= Current implementation uses handle_post_irq to actually handle chgin irq. This is not how things are meant to work in regmap-irq. Remove handle_post_irq, and request a threaded interrupt for chgin. Fixes: a6a494c8e3ce ("power: supply: max77705: Add charger driver for Maxim= 77705") Signed-off-by: Dzmitry Sankouski --- Changes to v4: - remove IRQF_SHARED flag, because interrupt is no longer shared - use IRQF_TRIGGER_NONE, because this is not physical irq - fix intendation - replace pr_err with dev_err_probe - commit msg: remove blank line Changes to v3: - move irq initialization after workqueue and charger initialization --- drivers/power/supply/max77705_charger.c | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/power/supply/max77705_charger.c b/drivers/power/supply= /max77705_charger.c index 3062411dcb45..5c8e46627cb0 100644 --- a/drivers/power/supply/max77705_charger.c +++ b/drivers/power/supply/max77705_charger.c @@ -40,13 +40,13 @@ static enum power_supply_property max77705_charger_prop= s[] =3D { POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT, }; =20 -static int max77705_chgin_irq(void *irq_drv_data) +static irqreturn_t max77705_chgin_irq(int irq, void *irq_drv_data) { struct max77705_charger_data *chg =3D irq_drv_data; =20 queue_work(chg->wqueue, &chg->chgin_work); =20 - return 0; + return IRQ_HANDLED; } =20 static const struct regmap_irq max77705_charger_irqs[] =3D { @@ -64,7 +64,6 @@ static struct regmap_irq_chip max77705_charger_irq_chip = =3D { .name =3D "max77705-charger", .status_base =3D MAX77705_CHG_REG_INT, .mask_base =3D MAX77705_CHG_REG_INT_MASK, - .handle_post_irq =3D max77705_chgin_irq, .num_regs =3D 1, .irqs =3D max77705_charger_irqs, .num_irqs =3D ARRAY_SIZE(max77705_charger_irqs), @@ -593,12 +592,6 @@ static int max77705_charger_probe(struct i2c_client *i= 2c) "cannot allocate regmap field\n"); } =20 - ret =3D regmap_update_bits(chg->regmap, - MAX77705_CHG_REG_INT_MASK, - MAX77705_CHGIN_IM, 0); - if (ret) - return ret; - pscfg.fwnode =3D dev_fwnode(dev); pscfg.drv_data =3D chg; =20 @@ -608,7 +601,7 @@ static int max77705_charger_probe(struct i2c_client *i2= c) =20 max77705_charger_irq_chip.irq_drv_data =3D chg; ret =3D devm_regmap_add_irq_chip(chg->dev, chg->regmap, i2c->irq, - IRQF_ONESHOT | IRQF_SHARED, 0, + IRQF_ONESHOT, 0, &max77705_charger_irq_chip, &irq_data); if (ret) @@ -630,6 +623,15 @@ static int max77705_charger_probe(struct i2c_client *i= 2c) goto destroy_wq; } =20 + ret =3D devm_request_threaded_irq(dev, regmap_irq_get_virq(irq_data, MAX7= 7705_CHGIN_I), + NULL, max77705_chgin_irq, + IRQF_TRIGGER_NONE, + "chgin-irq", chg); + if (ret) { + dev_err_probe(dev, ret, "Failed to Request chgin IRQ\n"); + goto destroy_wq; + } + ret =3D max77705_charger_enable(chg); if (ret) { dev_err_probe(dev, ret, "failed to enable charge\n"); --=20 2.39.5