From nobody Thu Oct 2 09:19:00 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B46322D7B6; Fri, 19 Sep 2025 00:34:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.17 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758242061; cv=none; b=dbYaDpaFxVDidyEhFgy3LwW2Qmp5LGLlVn7FXK57X5C5rcBCSED60N/blkkU98C39ZNeEkbjFJuz9YefVzp2fLPj9cZLIRBeuH+KO6LsCxxFpj5TfVbDpYE8p8IkBEWHDvHuYO2f6uG/Ssi9nygXhwJGi4hb6BJugs/3xvEP9iU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758242061; c=relaxed/simple; bh=xXwKD+ifDBVBCrB7b6koLwrJ7phZIeOxsP1/aBvt6lQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rU6j2QwC6WC07c/iyREmPfyE1mppQ2QxIgEmq0z0ROGeWTILzot2+H2Z7a0iX/z7PajAZ7fbcseIuTgGPv8rkp8vyzdKW3Qz+OmeSpZk1KStEgfOJYrVCBG6a+IkQTq4adJ84AVmBQFiXqtn4/+ky09be4wMyQR+BGWw5Vh9kbk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=I1DlWSeR; arc=none smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="I1DlWSeR" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1758242060; x=1789778060; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=xXwKD+ifDBVBCrB7b6koLwrJ7phZIeOxsP1/aBvt6lQ=; b=I1DlWSeR3pML0uAt90ZgLRJm4lBwk9kkH3tmLbTWP101+t4bkzQUiwei xhFiFDH95ejGuI07hn6OFglarU2rBzkolJXDJK5vWXv5LRTwy3LNZgevS 0pIZD2wedu+71k1q0MiBRi+Qa8baLlT0pbvBSryaH16X6qkOEGXf3/CC9 ZfNtNDZRwPSSxr7nrPgS8Zt8u4oo0oaWkU+RnEFeBkBx2LE+r+tbrLsLj znbQ45bT5TSJmRI4hX049mTVspN7AJkbPxoX5Zw0En8WSqMcCiSn46qGc 6Vd7+9dnafz0+XhucDDZFt7Ejt6YTCEIMjppYLOfCg04pjR13xnmABUBa Q==; X-CSE-ConnectionGUID: Sel4FJQ3QQKTBQmaT+VfTQ== X-CSE-MsgGUID: 6G0ZbZ0SSYGqQqf4jUi+VQ== X-IronPort-AV: E=McAfee;i="6800,10657,11557"; a="60517631" X-IronPort-AV: E=Sophos;i="6.18,276,1751266800"; d="scan'208";a="60517631" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2025 17:34:19 -0700 X-CSE-ConnectionGUID: xzZf/9wESjKMTD+65Dk/dA== X-CSE-MsgGUID: iaK5QreVTCim4C5yw28pOg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.18,276,1751266800"; d="scan'208";a="180119989" Received: from orcnseosdtjek.jf.intel.com (HELO [10.166.28.70]) ([10.166.28.70]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2025 17:34:18 -0700 From: Jacob Keller Date: Thu, 18 Sep 2025 17:33:16 -0700 Subject: [PATCH net 1/3] broadcom: fix support for PTP_PEROUT_DUTY_CYCLE Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250918-jk-fix-bcm-phy-supported-flags-v1-1-747b60407c9c@intel.com> References: <20250918-jk-fix-bcm-phy-supported-flags-v1-0-747b60407c9c@intel.com> In-Reply-To: <20250918-jk-fix-bcm-phy-supported-flags-v1-0-747b60407c9c@intel.com> To: Florian Fainelli , Broadcom internal kernel review list , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vadim Fedorenko , Kory Maincent Cc: Richard Cochran , Yaroslav Kolomiiets , James Clark , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jacob Keller , Vadim Fedorenko X-Mailer: b4 0.15-dev-cbe0e X-Developer-Signature: v=1; a=openpgp-sha256; l=1702; i=jacob.e.keller@intel.com; h=from:subject:message-id; bh=xXwKD+ifDBVBCrB7b6koLwrJ7phZIeOxsP1/aBvt6lQ=; b=owGbwMvMwCWWNS3WLp9f4wXjabUkhowzSzm27kj3bzwpF7zPZgdvP0OIpsSixXOereAqdzoic 0tZoul2RykLgxgXg6yYIouCQ8jK68YTwrTeOMvBzGFlAhnCwMUpABOZzcXIsKD6/K9OBzFvTfPC 3RaSV0ofac8K3LDz4PodKSWqpU+Nwxj+KTYJn58qHr9C5QPj4k6tDyK2ChNzXB/JMC2x4t9ZeLG OGQA= X-Developer-Key: i=jacob.e.keller@intel.com; a=openpgp; fpr=204054A9D73390562AEC431E6A965D3E6F0F28E8 The bcm_ptp_perout_locked() function has support for handling PTP_PEROUT_DUTY_CYCLE, but its not listed in the supported_perout_flags. Attempts to use the duty cycle support will be rejected since commit d9f3e9ecc456 ("net: ptp: introduce .supported_perout_flags to ptp_clock_info"), as this flag accidentally missed while doing the conversion. Drop the unnecessary supported flags check from the bcm_ptp_perout_locked() function and correctly set the supported_perout_flags. This fixes use of the PTP_PEROUT_DUTY_CYCLE support for the broadcom driver. Reported-by: James Clark Fixes: d9f3e9ecc456 ("net: ptp: introduce .supported_perout_flags to ptp_cl= ock_info") Signed-off-by: Jacob Keller Reviewed-by: Vadim Fedorenko --- drivers/net/phy/bcm-phy-ptp.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/phy/bcm-phy-ptp.c b/drivers/net/phy/bcm-phy-ptp.c index eba8b5fb1365..1cf695ac73cc 100644 --- a/drivers/net/phy/bcm-phy-ptp.c +++ b/drivers/net/phy/bcm-phy-ptp.c @@ -597,10 +597,6 @@ static int bcm_ptp_perout_locked(struct bcm_ptp_privat= e *priv, =20 period =3D BCM_MAX_PERIOD_8NS; /* write nonzero value */ =20 - /* Reject unsupported flags */ - if (req->flags & ~PTP_PEROUT_DUTY_CYCLE) - return -EOPNOTSUPP; - if (req->flags & PTP_PEROUT_DUTY_CYCLE) pulse =3D ktime_to_ns(ktime_set(req->on.sec, req->on.nsec)); else @@ -741,6 +737,7 @@ static const struct ptp_clock_info bcm_ptp_clock_info = =3D { .n_pins =3D 1, .n_per_out =3D 1, .n_ext_ts =3D 1, + .supported_perout_flags =3D PTP_PEROUT_DUTY_CYCLE, }; =20 static void bcm_ptp_txtstamp(struct mii_timestamper *mii_ts, --=20 2.51.0.rc1.197.g6d975e95c9d7