From nobody Thu Oct 2 10:57:10 2025 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB031321270; Wed, 17 Sep 2025 15:43:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.152.168 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758123825; cv=fail; b=j5II7FoySFkHjB8MaERE6K5QJkcHp2fOxcm85V+WIK9z3usn5S2khn8rkaqDAVWgYH+zwsf4exCgpnKxNvNGkgC3f6AgXP4oW6F2VfHDt6cDlIMKtYBYPBszblID5YWm/jTC9bWApb2eYRpeACtRu6CmaKd/icSOM8+9XhywGMI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758123825; c=relaxed/simple; bh=hb9k9GIiOLV4EqtNlX0bvO2OPBH7h/3vknX8bFP+kKg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=DkNu0sA8jYQ4JnwIhzdfVPza6aF8mMhev03H826ZpTRi1/VReE39HWRTT4EbTp1JnbGJkKofpcSP6+1CoYD4IhjxiGcedXp5IEV2m3RpSALngodKtwUaeaNLTaihO18D+Wa91ikmEgqlqDuR7E3QS7VVcuTBpGoBytkMBAQ/l9Q= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=OG1nAHx2; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=KwPg02Dx; arc=fail smtp.client-ip=67.231.152.168 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="OG1nAHx2"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="KwPg02Dx" Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 58HB3h4d2718932; Wed, 17 Sep 2025 10:43:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=UGwGFK7zg49rvcd4vRo4ph0J9LpOaUGovnHas9zl3kk=; b= OG1nAHx2hoD7mbYneFwHiFiz2/OM8sNTXcEBK/IJay0GvdZWYru/iXXpYq04wwUs 6B5YYQ7eQ2jaFUFl6LVzyrNTD7G4bk8t98NhJwA7P/0t6pxTKsgK6o/tyT4YzVYv UKhCKoG1K4HwMkvop/jsZNXMNb92EOSvyQtFQ4COtemPhrdZh5hMwBer6xiOJNAS Q9Cd2c3n+H3xMhdLyKA320xmjsDl+DFt9vMVk2dXKDwL6UgdhY0XB/I5VAzIKwtl /vX5dEz6DhaiVoRVH8pJ2JNxWN8koSeg6g39tHoWNFSoptaPrKL/NjZpwRTIv8kT Hsl9tabjUrqqcA2FhOopyg== Received: from nam04-bn8-obe.outbound.protection.outlook.com (mail-bn8nam04on2108.outbound.protection.outlook.com [40.107.100.108]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 497fyks9sy-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 17 Sep 2025 10:43:39 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=eiF/Ch79QgmHC7VDto5Gk2kUB/GjUESxP9RCyeNmSRVQc7YtaBo5tTBr0VCZnDDaFv7Mj7A3SjChmObT/loWiL/W+yt029LJyWt1M7McwvJCRTiLseXeOo6EKCcc2MOcjWInKiJ7UCYMYa+em6H85/E3T5yUw2PR5AttwUieI/enIWNGX7JdiSjMgTGspuxu5KSfwCEDWOPgkmKnVM6mWbcENCIxAyfHFQ8geM43EXq6IucfNAdVhn4qvCRpEcWC8238mSNJ6OHaFU5ohGunpyVHgAFdq13vFhBlK12eKpcSlu1hQG9nIaK6gmJYPnbSEHUXRn37k/ZmigvcPVimjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UGwGFK7zg49rvcd4vRo4ph0J9LpOaUGovnHas9zl3kk=; b=xW49bSG8ljSJbk1Y52DJdm9AYqerPGBx6oBH0waiSwx73jVGjr2P0fGzRsfo4WWzuqPbOhZRSqoOOz59JamCQURrEK4S7moUPxzqKjIOZvAgF8BBaqMeC50QRgIM3i+EIdQbuEXoVZCXr1ceQuyPfHNX7xhWZ6n5Ex2hAz5z1FRELEKN0XjU6zr+54fwqmhNMHHTT0JkB37RIX8tihyjClhC6jhfo9T2BDau/L1XCQsOFKCxK9Gt5pgTkrl0Adj5jTA84HLGMQu7xQ+crM9MCbAHagB6yMWMmz65KWo4YwZhRZrDwukMiOIF1Q08S7FN4LZ5hjVYQi5JgpK8iM5Opw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UGwGFK7zg49rvcd4vRo4ph0J9LpOaUGovnHas9zl3kk=; b=KwPg02DxLH7mhn/z+/a+dsATB3FEN7TdbyxGNB+SQZFl7z2ts06xNb3yQyiRCy3D2w3ncmeD8eovvXOSJWqSPnob+UTLL3SQkOgPVPcvqADC46pMWc2Qf7f3MWJGSwkFaxjOIovTMFUa0mEvXFVM4IXfroNXHf4c0zK53rP9ZQQ= Received: from CH5PR03CA0005.namprd03.prod.outlook.com (2603:10b6:610:1f1::24) by SA6PR19MB8537.namprd19.prod.outlook.com (2603:10b6:806:40d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9115.22; Wed, 17 Sep 2025 15:37:32 +0000 Received: from CH1PEPF0000AD79.namprd04.prod.outlook.com (2603:10b6:610:1f1:cafe::9f) by CH5PR03CA0005.outlook.office365.com (2603:10b6:610:1f1::24) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9137.13 via Frontend Transport; Wed, 17 Sep 2025 15:37:32 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: Fail (protection.outlook.com: domain of opensource.cirrus.com does not designate 84.19.233.75 as permitted sender) receiver=protection.outlook.com; client-ip=84.19.233.75; helo=edirelay1.ad.cirrus.com; Received: from edirelay1.ad.cirrus.com (84.19.233.75) by CH1PEPF0000AD79.mail.protection.outlook.com (10.167.244.57) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9137.12 via Frontend Transport; Wed, 17 Sep 2025 15:37:31 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 1468F406544; Wed, 17 Sep 2025 15:37:31 +0000 (UTC) Received: from lonswws02.ad.cirrus.com (lonswws02.ad.cirrus.com [198.90.188.42]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id CDD7E82254A; Wed, 17 Sep 2025 15:37:30 +0000 (UTC) From: Stefan Binding To: Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, Stefan Binding Subject: [PATCH v3 1/2] ASoC: dt-bindings: cirrus,cs35l41: Document the cirrus,subsystem-id property Date: Wed, 17 Sep 2025 16:37:11 +0100 Message-ID: <20250917153722.94978-2-sbinding@opensource.cirrus.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250917153722.94978-1-sbinding@opensource.cirrus.com> References: <20250917153722.94978-1-sbinding@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000AD79:EE_|SA6PR19MB8537:EE_ X-MS-Office365-Filtering-Correlation-Id: 90b0a11e-5a7f-44aa-4f89-08ddf6001e1f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|36860700013|61400799027; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?J1BXv+mR3ZkTcerSIIfpNwf8Eat0qL0aIi/zf0UNdBgguWBnp1lfCrcPGSnq?= =?us-ascii?Q?VaIsfnvGe0noY2P7ysryAbr/WcqpzA/EL/b7v6euW0zGsO8VYW2SKyzrfFdO?= =?us-ascii?Q?1AMXUqV6JZEBkAeqWsUcoXRU9Q3OOQfv+14ktxQfvo3+KdXOWrjH+NZP7fAQ?= =?us-ascii?Q?AnKFPnr5/LmoUF+3u/ODXb3Y8iEAJF0OwsEjByzkeHXGQepuITZzVVubmvRj?= =?us-ascii?Q?8IaLOMc7DXGV+BTwS4iZdcOV4RV3IyImEAS+vfqxX5Z/m1LztiIuT1kbCC5R?= =?us-ascii?Q?2fdmJWQhU3i15wSg+vieqGM/Vf2N9lvKamdbZiKJDmZdBV/7Y+6g6uXW3qNQ?= =?us-ascii?Q?K3bl8FBQVKHRU5Jv6+9BLVzA8urc8bN8hmZ84GO1ogRDZbYVjmTPmJtPmYiP?= =?us-ascii?Q?HaSnVLU0/91T1F9d7jyI7JuKfn2xk8WQtBZfY4kR2c2N1oTM+ZxT8cqfLJot?= =?us-ascii?Q?6+BMjHxBT9PVQ+8KpLEggij20GJnZ1iyBRBFDvIcRE4SwBzULmMQWd5CwD/y?= =?us-ascii?Q?vKiJ3Q7GwEvbdOwv35OUMmMHtsUnRxV9BWRtuWUNkvm7N6zylNS8VDz1Fhfi?= =?us-ascii?Q?fLAOdw4EtzBQ5ApOY5XlZl3YExTFMhBqtDjC59sWq/XlKlIA/X3hMC6V2sOl?= =?us-ascii?Q?OjcLASyd77Gf05ew+FeEztoXHyhA/un5kNkZqF/JeJ9HUlfT6Sl4LsWPWPQ2?= =?us-ascii?Q?a0um37FtsQfRevm39oKgAPvuG0x+M3+hPc0TR//BaQdIIhRY4P9JQlYjbUnD?= =?us-ascii?Q?56silJUUSegDWkxbCFA4Gw1QldgIBYkX5Ltq4lKdpaGRRjy3kOw4igg490nl?= =?us-ascii?Q?+YqBlWtcb1VYOKSKZ152Drlcwg9SG/Qd0Hu0X5NVGy78rHgrdXvvCqIkZTVW?= =?us-ascii?Q?p32VXIFIHiHABtc2b+PuPwUiBgfp+qHY6UPjoW/GbMrRb7DRCws+yh7fbtZW?= =?us-ascii?Q?6lV4ASwupG6zq7ALG4O7osucx+ChKE5GM9IP2EvxDO8zIjmoF2QT97FMCGm4?= =?us-ascii?Q?8Sec3e04cB+FHtCILr9yVV1+wt2PNzxLPgqmKR3+jWfZbcUYEOFtQDel7tD5?= =?us-ascii?Q?IfsG4LvsU0r76783KXFJB74+AVrzJZbL8V+wZcITz2sk68V+zLgrZxE9e3QX?= =?us-ascii?Q?jzf5V0OcyQir+lxB9eoWYezK9Vg5xw8LJp7oXwBXHge6ywAZZeiq+IaM9YrF?= =?us-ascii?Q?JuUwQmjpsF3lxLOp2IkTvofgL+CprrShE/A5yjweNufLBGL4XeIhST0Ca26W?= =?us-ascii?Q?qctOTsAbKdpOXnyny6Hn+rjOX4S3FRINHaNPbiCAPee/sAilllJs8yw/s16H?= =?us-ascii?Q?XC0Esz7fA7VndabWBdo1HRrupWUE6MFTV1Jtm/UBMxIHCglzl2Wtdib6CPUX?= =?us-ascii?Q?oOeyAp/JPwOXeUBP2adzkxUszWTSoJkgq4fgOnPmDOWc1ls2nQcojAiEa3KO?= =?us-ascii?Q?5WzykS6IRZlsmYG0gYY0Sx8mGGyTArrtoTeg5noC6h5Dg59QXHFlG+cSj5Jf?= =?us-ascii?Q?fdG4r76h5Eys/8MaJ82b6QwPuZc4wFN1H+KQ?= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(82310400026)(36860700013)(61400799027);DIR:OUT;SFP:1102; X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2025 15:37:31.9977 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 90b0a11e-5a7f-44aa-4f89-08ddf6001e1f X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-CH1PEPF0000AD79.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA6PR19MB8537 X-Proofpoint-GUID: z_T-o6_oAwZ-dm9_M0uQa-feoGxhISHE X-Proofpoint-ORIG-GUID: z_T-o6_oAwZ-dm9_M0uQa-feoGxhISHE X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTE3MDE1MyBTYWx0ZWRfX/OzH0XDZVSuk +YyVMsKnCHKmILWYL84mcR1PPpqhAGxl8AmDoUmlUi0GXJgG+ivPPQAOyOUnMQOgNqNQOHTxIjd Dg10ZgeibaKNk/j0cnWkWxVHYPNQBmX5o+nZd2M/RI2ewFR+j2CWInrfd2hlAUtPc0ei8h+rwFm mLMDjrjQTTKlUxBmoqhpW0b3QuMYKMMIXA3g4nBj6dr3HK76gJQeJE1h55m1yaQocdOmf8etu9f WzNwSzXCAkiNddd4fHGjh4UjPILlhmVjMq9jI1roVVYBAgzdZbyTit0c8tU7ozY2tuYWpaPoR5g 1z6zZssgz6K7GLUGmTTLL4N/0dulpW1F65KpeD6v7fiQJ+w64hXnxK5alaBE+0= X-Authority-Analysis: v=2.4 cv=KvRN2XWN c=1 sm=1 tr=0 ts=68cad72b cx=c_pps a=jQSJrZTB3+cRIPJ8FcCqfA==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=yJojWOMRYYMA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=w1d2syhTAAAA:8 a=pTMMdCdBRh1H00hwDNUA:9 X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" Add new property: cirrus,subsystem-id This new property is used to uniquely identify the system if device tree is used, to allow the driver to select the correct firmware and tuning for the system. The DSP driver searches for a compatible firmware (and tuning) based on what it is able to read from the hardware. However, the SSID is based on the system, and cannot be read from the hardware, therefore it needs to be read from the Device Tree. On ACPI-based systems, it is able to read this from the ACPI _SUB property, and to maintain compatibility with the driver between ACPI and Device Tree systems we need an equivalent property. Signed-off-by: Stefan Binding --- Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml b/= Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml index 14dea1feefc5..e6cf2ebcd777 100644 --- a/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml +++ b/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml @@ -151,6 +151,12 @@ properties: minimum: 0 maximum: 5 =20 + cirrus,subsystem-id: + $ref: /schemas/types.yaml#/definitions/string + description: + Subsystem ID. If this property is present, it sets the system name, + used to identify the firmware and tuning to load. + required: - compatible - reg --=20 2.43.0 From nobody Thu Oct 2 10:57:10 2025 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF2EE33B464; Wed, 17 Sep 2025 15:37:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.152.168 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758123464; cv=fail; b=V9IPCVqA7PmTEfevKH7vqn1W1+r6PQDBl8MbWPtA9TrIAmmwH3lYtH15kH5XMljq0OcLNonhTO20z+rJwRuzPtZ70roHvp1BBNRS2T2c/MYLYIBmWb38ilavlNtDLkbFOerPFkz93ZwVVaH8HHJi21QgDe8PkeRpLdMXCq6RKRk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758123464; c=relaxed/simple; bh=9fENK6SNnhV4DAGaNi7Ye8SDSFSJ/NGGImv71zIDeog=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=KWL9zudT9jOs1laX/Verht+injCsZaa65eteZlinU9KQYZOdFBQjFFd0yr9nKJcZSp7rVGFLkA4FPFWlqFs+rIUzj3jt+5ZYGz18+uuo9lLQd6Gl1jfjpBNydAwd+enBDY/vBX/wYJiHQI60HlT0zWtVnnTfegLbDzETsayNbDo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=fWlW7F1+; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=LFx/x3tj; arc=fail smtp.client-ip=67.231.152.168 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="fWlW7F1+"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="LFx/x3tj" Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 58HBDHi92718596; Wed, 17 Sep 2025 10:37:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=gp40NizKm1FM7ylVvmUIRHmLfezg4m3gwW3kPy0zH7s=; b= fWlW7F1+QDtvoSt2Fy0hpHjHhZz3bGCSYYc/f4t54DPJLkZJvlZV4vQ1c+5adQYB 3b3a2QBmCeg38InRzpkdG3aj/i7SqWz9eok0vobUA8Rb2xR9kKwN7JNwTSUfMLeo cAUFdkZMI7p4/ZNorZ3cz1s1mSU8zin8wlQ56OBKI0JZUMqPrmt4Knw8silyf7g+ 8igKLNG7wbJuc0bYSoKuYbF2+V2/PWd4w3uqI0XSnDVaKlMpQSI+CuT7PWO+T6Eh lVx/IR75rrlorrnJGzB7N5cF4f7yw2kKhWmyC+zAiDcZGk6744H22SPQBcUrgzDC repfK+uPqfCF/u6rIGw0/w== Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12on2133.outbound.protection.outlook.com [40.107.244.133]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 497fyks976-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 17 Sep 2025 10:37:39 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JkN+bXm5qMY3jKrllXAOVu4bOIA9rGR3F3iiJTtH2PDaSZXFcCcWFCNC871pgKGPy0INiodzSgLhskfqPZIISz7A87/LAy351wWZscv98GB83jHmx8OJBbM6du7byuh8Lh19d6P2SR86NLRljhFy114dPjhjwf91t4PqcfEOwqs3t7Z8Ae0jMx8JDeSr9LaJ6ve4i/rCuNBasEApP9PmwKjlLmP+c8lsGeoU3GB8zIamSCku8aMDomkJVxZZkuD1vRDndxaGZb7SVMmZnCs3VI+vG3zrHrHnLThbIBjADSkLrobkpLlaxwuuLt4u+QdvGEZLzCc9SbldsB4ll8Tf+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gp40NizKm1FM7ylVvmUIRHmLfezg4m3gwW3kPy0zH7s=; b=Adv4lSFQb/EWP1D1ffRxVVnhe28aAzYCsaQ2BFoBWAcr2rX3R+mA7/Fte5VA9WmVKwg8qNRnWdOasmOzOLK0THriFudRY0IR6dolASvTzEULRl8rZ4mXanU+JFawaRPE6fIR0+PrXcs7xWIgCEaLV4FHpgj68SjaLSEpSBgbX98U3AtvWZaPv4v8AlxHZr+rE9W8kbu6XbOhHOKOLT3jLwv/OwZKhoGeZ2kgWyGtu/3UlINMcWKzbtMwdGNiSwsX2Fg5MZDZc1bY8mJGIPJmY+E6BVS+IuFLKhPs4WQ5ICbYHvuhFLfhux1g38TauT1+9TfU+aBBhtwGSm5CU/UDfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gp40NizKm1FM7ylVvmUIRHmLfezg4m3gwW3kPy0zH7s=; b=LFx/x3tjUeOpCDRvnVJWF/2X8Ol/nWl3LzjH9BU+1xNbbh8oFa1tqcViIyV7p/Ssvm3du1jo5pEhp5smPNSa4dZMiC9IC8J+1iPppCcH3Ei6LQgRbQ7eagPbM+nqvUZuLgOrhpM/XgJLnGYH/G2oUDK9IvA1oIhuz8Y4Jshz57E= Received: from CH0P221CA0036.NAMP221.PROD.OUTLOOK.COM (2603:10b6:610:11d::14) by CO1PR19MB4840.namprd19.prod.outlook.com (2603:10b6:303:f6::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9137.13; Wed, 17 Sep 2025 15:37:35 +0000 Received: from CH1PEPF0000AD76.namprd04.prod.outlook.com (2603:10b6:610:11d:cafe::fe) by CH0P221CA0036.outlook.office365.com (2603:10b6:610:11d::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9137.13 via Frontend Transport; Wed, 17 Sep 2025 15:37:34 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: Fail (protection.outlook.com: domain of opensource.cirrus.com does not designate 84.19.233.75 as permitted sender) receiver=protection.outlook.com; client-ip=84.19.233.75; helo=edirelay1.ad.cirrus.com; Received: from edirelay1.ad.cirrus.com (84.19.233.75) by CH1PEPF0000AD76.mail.protection.outlook.com (10.167.244.53) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9137.12 via Frontend Transport; Wed, 17 Sep 2025 15:37:32 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 50F1A40654A; Wed, 17 Sep 2025 15:37:31 +0000 (UTC) Received: from lonswws02.ad.cirrus.com (lonswws02.ad.cirrus.com [198.90.188.42]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 182E882024A; Wed, 17 Sep 2025 15:37:31 +0000 (UTC) From: Stefan Binding To: Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, Stefan Binding Subject: [PATCH v3 2/2] ASoC: cs35l41: Fallback to reading Subsystem ID property if not ACPI Date: Wed, 17 Sep 2025 16:37:12 +0100 Message-ID: <20250917153722.94978-3-sbinding@opensource.cirrus.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250917153722.94978-1-sbinding@opensource.cirrus.com> References: <20250917153722.94978-1-sbinding@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000AD76:EE_|CO1PR19MB4840:EE_ X-MS-Office365-Filtering-Correlation-Id: d16b2196-850a-4afa-290d-08ddf6001e45 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|61400799027|36860700013|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?7Q1H92xhwJa6dFy8h15cEPUI5oRqq7P1TwwVbFe2zjcHnMvUjymMOhv+/89M?= =?us-ascii?Q?XjJ91g2IE5O0YdXKKbiOYzNLWrGoXjeBkLfAFD1gRH0NNpT+2EGlMJfw6EB1?= =?us-ascii?Q?fLEoGjWwaeeomm2NsXOZTzE4uR71Ra4baGnNMclZO/VMbkl427h1ytgzoRfF?= =?us-ascii?Q?fXGT68kQUZ+dfIhkLwvi//JtNL5v4HZ0xVCe3gabWB5IYy8GudesQ1vYp9Rz?= =?us-ascii?Q?9I6+/sbQaY5BfutEkox3Yjz1+WgiyoLfFRX21+N3d2PI/hHfThWMZiT5Zx96?= =?us-ascii?Q?e+y7BdOnuNRpGP/Za8AmWqw547IFrMQkKg97dMcwb5FT74Xbki2tMOFl5wPM?= =?us-ascii?Q?J2N/Ivk/BYgY0vK7mbVdlSQPm+OzYU54LLtRya7XEyjp9C8vSc8QXcg0YEf+?= =?us-ascii?Q?rQgocdnc9K4s6QPlOJ7Fm4xezvEHTcAvG6XLjJDCZZzbr180KEEpUTefSROa?= =?us-ascii?Q?hjrOlbLHpaOHb2f7VWleSJOP7YB5r5/elRB7qaWNcNxeruj+iC6IOste8F/i?= =?us-ascii?Q?MCj+jUu+ZQlvd5fHQDWIZERFKqKJ0OsLhRoJURiQPGdZU8TD+BdWaz+ZNiWE?= =?us-ascii?Q?RMDT4T1gVmWYJxj9n8p84zm5syBdUVMOYcuQF6CXh4fUIR/VaUUdg7EuX0Oi?= =?us-ascii?Q?JszDhc9QR1jarcO/ATSBcp1Y2Sfh9ZhTkEe3p/hRrkjPyRXD7TBdV55mAMKw?= =?us-ascii?Q?c+331FZQcukPlgsp1H1l3UZ8gWRbdKqK5jis9EjVZC1fy7VRFOVS22XG6IP1?= =?us-ascii?Q?eRm6EuMBt1bvE+uykJyvqeur85RbtO0aQ2y4vzcryAv8Dz5X3QLx6mMRydY1?= =?us-ascii?Q?VcK4FYm/EqYKzyaIAwwzf7bzI/s+/ksiKMidFNd4jyNXjSTTHcqVndjt/nqi?= =?us-ascii?Q?yLuyETivvituYX2XSdiwhYy89bMH+q0ac15EkfuYhTPIhDQz+cNPPvCTOEE4?= =?us-ascii?Q?ZN3qjVlpFIfA7mX1ng2pwms2KViPuBHWv9PjdzsFARNnvk32dSRkJdARQh7A?= =?us-ascii?Q?5FV+7kmntu+VI22Ft0SLmZ474J5cu8/MJXkfCcTki6NId4GT+wh/pPITQyQu?= =?us-ascii?Q?35G7GPYrEp1Omzjn0quXAa1+UsjCVIAjeb1MZRMKa+Uc517jQq2AaPkZ1VMx?= =?us-ascii?Q?uZN0d3T6XfjCXYwL+Ad9XGIzMxsTTH82JVVi/mlq+mAhncOthmT4XouPHraK?= =?us-ascii?Q?VSENLmEjpj68rLYth53r/GFpssIyjER4K8/qw0AmNc8099A4egULlfcXRqTo?= =?us-ascii?Q?duJ2ri+O5T0feGmpC6Seg1PpIMJ4ql7FFQSybsB+VcENicqPoLa7cEHXJuWT?= =?us-ascii?Q?VxFBOLrKcwuXKpQJUy3pvSw1x0GxgvctNV5s9lgNmRTRvDd/46X5KNfYeeIA?= =?us-ascii?Q?FQCbnqKX0QbcuOxV3V3WkljsWoy6YPVcyUTFOK1UEQnj0acxqdqrhHwlN//I?= =?us-ascii?Q?RVqFeKRnySzeZMpC/tpmzB/EiDBpvHUI2zl7Uh4wzrm6oi1RLxuRgLBpmnwI?= =?us-ascii?Q?L2KldSIELg2CXt6CKclXMmuoZY6F22HcIAeG?= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(61400799027)(36860700013)(376014);DIR:OUT;SFP:1102; X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2025 15:37:32.2458 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d16b2196-850a-4afa-290d-08ddf6001e45 X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-CH1PEPF0000AD76.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR19MB4840 X-Proofpoint-GUID: mtGvai5Gkel9Y0Jfl2j3ipgD3m4ssxVe X-Proofpoint-ORIG-GUID: mtGvai5Gkel9Y0Jfl2j3ipgD3m4ssxVe X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTE3MDE1MyBTYWx0ZWRfX9jIhZkFisI5S WX09EmYuDIRiu/ax6DNw9qznsAonzlEuGCFJObFedyE8Uh6ZlX0toi0T2RTci35Hw9MVmIOOvTg cSIB1Cq7QLAEZGlSHDgrvh+UTM1FmtyGy0u1Q2paZlne6c9/8/QSA8LGZFKapLeGeL8XPsOmPHY LmGIUsiuaPd1WkOU0glzw3E/EIawY3XqJraH5JfbMqVtGvFx4AzA2z3+y2a7lQnzpIhWPmITu7J U1Y5t1rC0152vIuTqJaTY0MxnhV2L6oyNEek920zL0SLQoDDYfVhKyS5h88tkIE75Nizxv8Ufvn pXfkZEFXPAv3xnni6Z+ghj+GzZkeQevJeBHBMcO+8YfpeSn/TPcknJQnLNB3Fk= X-Authority-Analysis: v=2.4 cv=KvRN2XWN c=1 sm=1 tr=0 ts=68cad5c3 cx=c_pps a=V+OjpK3aUZD57wWhQcm3pw==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=yJojWOMRYYMA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=w1d2syhTAAAA:8 a=bL0rdlc7CeB77TPmB0MA:9 X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" If ACPI is not used, then there is currently no way of reading a Subsystem ID property used for a system name to uniquely identify the system in order to load the correct firmware and tuning. Add a new property which can be read from device tree to be able to set the system name. Signed-off-by: Stefan Binding --- sound/soc/codecs/cs35l41.c | 77 ++++++++++++++++++++++---------------- 1 file changed, 44 insertions(+), 33 deletions(-) diff --git a/sound/soc/codecs/cs35l41.c b/sound/soc/codecs/cs35l41.c index 224d65987a8d..173d7c59b725 100644 --- a/sound/soc/codecs/cs35l41.c +++ b/sound/soc/codecs/cs35l41.c @@ -7,6 +7,7 @@ // Author: David Rhodes =20 #include +#include #include #include #include @@ -1147,45 +1148,55 @@ static int cs35l41_dsp_init(struct cs35l41_private = *cs35l41) return ret; } =20 -#ifdef CONFIG_ACPI -static int cs35l41_acpi_get_name(struct cs35l41_private *cs35l41) +static int cs35l41_get_system_name(struct cs35l41_private *cs35l41) { struct acpi_device *adev =3D ACPI_COMPANION(cs35l41->dev); - acpi_handle handle =3D acpi_device_handle(adev); - const char *hid; - const char *sub; - - /* If there is no acpi_device, there is no ACPI for this system, return 0= */ - if (!adev) - return 0; + const char *sub =3D NULL; + const char *tmp; + int ret =3D 0; =20 - sub =3D acpi_get_subsystem_id(handle); - if (IS_ERR(sub)) { - /* If no _SUB, fallback to _HID, otherwise fail */ - if (PTR_ERR(sub) =3D=3D -ENODATA) { - hid =3D acpi_device_hid(adev); - /* If dummy hid, return 0 and fallback to legacy firmware path */ - if (!strcmp(hid, "device")) - return 0; - sub =3D kstrdup(hid, GFP_KERNEL); - if (!sub) - sub =3D ERR_PTR(-ENOMEM); - - } else - return PTR_ERR(sub); + /* If there is no acpi_device, there is no ACPI for this system, skip che= cking ACPI */ + if (adev) { + acpi_handle handle =3D acpi_device_handle(adev); + + sub =3D acpi_get_subsystem_id(handle); + ret =3D PTR_ERR_OR_ZERO(sub); + if (ret) { + sub =3D NULL; + /* If no _SUB, fallback to _HID, otherwise fail */ + if (ret =3D=3D -ENODATA) { + tmp =3D acpi_device_hid(adev); + /* If dummy hid, return 0 and fallback to legacy firmware path */ + if (!strcmp(tmp, "device")) { + ret =3D 0; + goto err; + } + sub =3D kstrdup(tmp, GFP_KERNEL); + if (!sub) { + ret =3D -ENOMEM; + goto err; + } + } + } + } else { + if (!device_property_read_string(cs35l41->dev, "cirrus,subsystem-id", &t= mp)) { + sub =3D kstrdup(tmp, GFP_KERNEL); + if (!sub) { + ret =3D -ENOMEM; + goto err; + } + } } =20 - cs35l41->dsp.system_name =3D sub; - dev_dbg(cs35l41->dev, "Subsystem ID: %s\n", cs35l41->dsp.system_name); +err: + if (sub) { + cs35l41->dsp.system_name =3D sub; + dev_info(cs35l41->dev, "Subsystem ID: %s\n", cs35l41->dsp.system_name); + } else + dev_warn(cs35l41->dev, "Subsystem ID not found\n"); =20 - return 0; -} -#else -static int cs35l41_acpi_get_name(struct cs35l41_private *cs35l41) -{ - return 0; + return ret; } -#endif /* CONFIG_ACPI */ =20 int cs35l41_probe(struct cs35l41_private *cs35l41, const struct cs35l41_hw= _cfg *hw_cfg) { @@ -1317,7 +1328,7 @@ int cs35l41_probe(struct cs35l41_private *cs35l41, co= nst struct cs35l41_hw_cfg * goto err; } =20 - ret =3D cs35l41_acpi_get_name(cs35l41); + ret =3D cs35l41_get_system_name(cs35l41); if (ret < 0) goto err; =20 --=20 2.43.0